mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1217 commits 1 branch 183 tags 5.3 GiB
Commit graph

1217 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ales Pergl
bf86718d61 Address cpplint issue "DISALLOW_COPY_AND_ASSIGN should be the last thing in the class [readability/constructors] [3]" 2017-04-05 14:30:16 +02:00
Ales Pergl
161b4e752b Address cpplint issue "public: should be indented +1 space inside class NotificationPresenterWin7 [whitespace/indent] [3]" 2017-04-05 14:30:16 +02:00
Ales Pergl
9d75e9f54c Address cpplint issue "Namespace should be terminated with "// namespace brightray" [readability/namespace] [5]" 2017-04-05 14:30:16 +02:00
Ales Pergl
64bf0d210e Address cpplint issue "An else should appear on the same line as the preceding } [whitespace/newline] [4]" 2017-04-05 14:30:16 +02:00
Ales Pergl
9b7fbd4d22 Address cpplint issue "Using C-style cast. Use reinterpret_cast<BYTE*>(...) instead [readability/casting] [4]" 2017-04-05 14:30:16 +02:00
Ales Pergl
91cff2e6c7 Address cpplint issue "Missing space before ( in if( [whitespace/parens] [5]" 2017-04-05 14:30:16 +02:00
Ales Pergl
29f3332276 Address cpplint issue "{ should almost always be at the end of the previous line [whitespace/braces] [4]" 2017-04-05 14:30:16 +02:00
Ales Pergl
63eeb96e71 Address cpplint issue "Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]" 2017-04-05 14:30:16 +02:00
Ales Pergl
20d0bda538 Address cpplint issue "Found C++ system header after other header. Should be: toast.h, c system, c++ system, other. [build/include_order] [4]" 2017-04-05 14:30:16 +02:00
Ales Pergl
33b4936a68 Address cpplint issue "Include the directory when naming .h files [build/include] [4]" 2017-04-05 14:30:15 +02:00
Ales Pergl
0bba5b9b41 Address cpplint issue "Lines should be <= 80 characters long [whitespace/line_length] [2]" 2017-04-05 14:30:15 +02:00
Ales Pergl
392d606848 Changed member variable naming style to snake case 2017-04-05 14:30:15 +02:00
Ales Pergl
0fa6c82b3f Use NotificationPresenterWin7 on Windows 7 2017-04-05 14:30:15 +02:00
Ales Pergl
fe05b66a6c Added desktop notifications implementation for Windows 7 (and earlier) 2017-04-05 14:30:15 +02:00
Ales Pergl
e6a30388da Make Notification factory function a member of NotificationPresenter so that we can create different types of notifications based on runtime conditions. 2017-04-05 14:30:15 +02:00
Kevin Sawicki
0981807261 Merge pull request #287 from electron/no-anonymous-ns-in-header 
Don't use anonymous namespace in header file.
 2017-04-03 08:27:51 -07:00
Kevin Sawicki
7dce066854 Merge pull request #286 from electron/cleanup-cpp 
Cleanup codebase
 2017-04-03 08:26:32 -07:00
Haojian Wu
e80a9bbb93 Move title_ to InspectableWebContentsViewVies to get rid of cast. 2017-04-01 15:10:52 +02:00
Haojian Wu
ee1f3acf7b Don't use anonymous namespace in header file. 
Anonymous namespace should be forbidden in header files even for the
forward declarations:

* As declarations defined in anonymous namespace are internal linkage, each
translation unit which includes this header will get unique copy, which
wastes space.
* It is easy to violate C++ ODR rule.

Consider the following "foo.h":

```cpp
namespace { class Foo; }
class Bar {
  public:
    Foo* getFoo();
    Foo* foo;
}
```

If the 'foo.h' is included in multiple `.cc` files, the compiler will
put `Foo` into a different anonymous namespace in each `.cc`, which
means there are different definitions of `Foo` in the program (a
violation of the ODR).
 2017-04-01 08:57:34 +02:00
Haojian Wu
f506047a9b Remove an extra blank line. 2017-03-31 21:56:19 +02:00
Haojian Wu
22035e2d6d Fix cpplint: at least two spaces between code and comments. 2017-03-31 20:59:27 +02:00
Haojian Wu
d18b34d55f Replace size() method with empty() when possible. 
There is no guaranteed that size() is a constant-time function.
 2017-03-30 21:49:16 +02:00
Haojian Wu
e4c571fc68 Remove unused using namespace declaration. 2017-03-30 21:49:15 +02:00
Haojian Wu
424078cfdb Fix namespace comments. 2017-03-30 21:49:15 +02:00
Cheng Zhao
bd5c53c2f7 Merge pull request #283 from electron/devtools_shutdown_patch_revert_revert 
Revert "Revert "close devtools web contents when available to trigger cleanup""
 2017-03-27 22:46:06 -07:00
Kevin Sawicki
bf6d21fe08 Merge pull request #285 from electron/cpplint 
Run cpplint on CI
 2017-03-27 09:20:05 -07:00
Kevin Sawicki
21956071e6 Fix compilation issue 2017-03-24 09:52:37 -07:00
Kevin Sawicki
49ef4e326f Initialize submodules in appveyor build 2017-03-24 09:52:27 -07:00
Kevin Sawicki
2ece711c2e Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
Kevin Sawicki
be0c0e278a Remove cpplint errors 2017-03-23 12:48:27 -07:00
Kevin Sawicki
1d42073ceb Run cpplint on CI build 2017-03-23 10:08:25 -07:00
Kevin Sawicki
31cd7a28d8 Ignore more Objective-C headers 2017-03-23 10:08:25 -07:00
Kevin Sawicki
ece7698b6a Add .clang-format file 2017-03-23 10:08:25 -07:00
Kevin Sawicki
97ced7fb07 Move cpplint config to CPPLINT.cfg file 2017-03-23 10:08:25 -07:00
Kevin Sawicki
96de22ba5f Use cpplint from depot_tools 2017-03-23 10:08:25 -07:00
deepak1556
99fd1394e4 Revert "Revert "close devtools web contents when available to trigger cleanup"" 
This reverts commit 7f01bf4e73c188db2406ded1286b661c61c78bba.
 2017-03-19 01:25:22 +05:30
Kevin Sawicki
bbf477291f Merge pull request #282 from electron/revert-278-devtools_shutdown_patch 
Revert "close devtools web contents when available to trigger cleanup"
 2017-03-17 09:37:04 -07:00
Kevin Sawicki
6b387e339b Merge pull request #281 from electron/upgrade-libcc 
Upgrade libcc to latest
 2017-03-17 09:36:54 -07:00
Kevin Sawicki
8877d78e79 Revert "close devtools web contents when available to trigger cleanup" 2017-03-17 09:35:01 -07:00
Kevin Sawicki
1499ba83d9 Upgrade libcc to latest 2017-03-17 09:11:28 -07:00
Cheng Zhao
e0485f5ea1 Merge pull request #278 from electron/devtools_shutdown_patch 
close devtools web contents when available to trigger cleanup
 2017-03-16 17:49:57 +09:00
deepak1556
07c4f3563e close devtools web contents when available to trigger cleanup 2017-03-14 22:23:08 +05:30
Cheng Zhao
b15123938c Merge pull request #270 from electron/pdf_rendering 
Link necessary pdf libraries and load pdf ui resources
 2017-03-10 08:35:00 +09:00
deepak1556
9a321d2479 dont link libfxcrt.a on linux 
It causes multiple definition error
 2017-02-23 22:39:34 +05:30
deepak1556
80de70bf66 address review comments 2017-02-23 22:39:34 +05:30
Haojian Wu
26081d5a11 Link libfx_freetype.a on Mac OS. 2017-02-23 22:39:34 +05:30
deepak1556
7700884ebc link pdf libraries on linux with whole-archive option 2017-02-23 22:39:34 +05:30
deepak1556
5e842b1112 link necessary pdf libraries 2017-02-23 22:39:34 +05:30
deepak1556
2b4948d6aa load pdf resource pak file 2017-02-23 22:39:34 +05:30
Kevin Sawicki
28f96f32f9 Merge pull request #276 from electron/context-shutdown-crash 
Cleanly shutdown browser context
 2017-02-14 08:24:52 -08:00