Commit graph

15253 commits

Author SHA1 Message Date
joshaber
0b7ffd094a Expose through the actual JS API too 2017-04-03 15:25:06 -04:00
Kevin Sawicki
e85e483c71 Parse setting response to surface thrown errors 2017-04-03 12:16:51 -07:00
Kevin Sawicki
f49e748020 Merge pull request #9096 from electron/upgrade-brightray-for-cpp-cleanup
Upgrade brightray to latest
2017-04-03 12:16:10 -07:00
joshaber
bcecba20e6 Fix indentation 2017-04-03 15:09:24 -04:00
joshaber
4ffaf2cd99 Remove old unnecssary change on app 2017-04-03 15:09:04 -04:00
joshaber
6e89cb9d7c Move it into dialog 2017-04-03 15:05:24 -04:00
joshaber
4bbbcd093b Handle the callback and cleanup properly 2017-04-03 14:01:48 -04:00
joshaber
1ed443ea29 Do the callback & release dance 2017-04-03 13:21:44 -04:00
Kevin Sawicki
257f6b142f Add spec for remote setter not surfacing error 2017-04-03 09:10:46 -07:00
Kevin Sawicki
0989fd7a1c Upgrade brightray to latest 2017-04-03 08:32:16 -07:00
Kevin Sawicki
f5a75c4e87 Merge pull request #9076 from electron/cleanup-cpp
Cleanup cpp codebase
2017-04-03 08:30:08 -07:00
Kevin Sawicki
0981807261 Merge pull request #287 from electron/no-anonymous-ns-in-header
Don't use anonymous namespace in header file.
2017-04-03 08:27:51 -07:00
Kevin Sawicki
7dce066854 Merge pull request #286 from electron/cleanup-cpp
Cleanup codebase
2017-04-03 08:26:32 -07:00
Kevin Sawicki
2f692c1002 Merge pull request #9084 from runinspring/patch-1
Update web-contents.md
2017-04-03 08:20:06 -07:00
Ryohei Ikegami
001d03c859 Do not add search paths in devtools 2017-04-03 22:40:36 +09:00
Ryohei Ikegami
d1212d4a43 Fix JS style 2017-04-03 20:23:36 +09:00
Ryohei Ikegami
50c99e4507 Search for module under the app directory 2017-04-03 20:19:10 +09:00
Ryohei Ikegami
673f4f4d0c Add test for require to search under app dir 2017-04-03 20:11:19 +09:00
Haojian Wu
34a91434aa Remove extra spaces. 2017-04-01 22:01:29 +02:00
ZhangYu
671bcf2161 Update web-contents.md 2017-04-02 00:41:36 +08:00
Haojian Wu
e80a9bbb93 Move title_ to InspectableWebContentsViewVies to get rid of cast. 2017-04-01 15:10:52 +02:00
Haojian Wu
f09e3f3835 Remove extra blank. 2017-04-01 15:09:53 +02:00
Haojian Wu
ee1f3acf7b Don't use anonymous namespace in header file.
Anonymous namespace should be forbidden in header files even for the
forward declarations:

* As declarations defined in anonymous namespace are internal linkage, each
translation unit which includes this header will get unique copy, which
wastes space.
* It is easy to violate C++ ODR rule.

Consider the following "foo.h":

```cpp
namespace { class Foo; }
class Bar {
  public:
    Foo* getFoo();
    Foo* foo;
}
```

If the 'foo.h' is included in multiple `.cc` files, the compiler will
put `Foo` into a different anonymous namespace in each `.cc`, which
means there are different definitions of `Foo` in the program (a
violation of the ODR).
2017-04-01 08:57:34 +02:00
Zeke Sikelianos
c2230ca76a generate electron.d.ts during dist creation, not during build 2017-03-31 21:35:58 -07:00
Zeke Sikelianos
c00bac5c0b add a convenience script for manually generating API JSON 2017-03-31 21:09:23 -07:00
Zeke Sikelianos
9a10486514 generate and upload electron.d.ts with each release 2017-03-31 21:01:55 -07:00
joshaber
ee7389bb6d Rename to make VS happy 2017-03-31 22:57:56 -04:00
joshaber
4f3d3557cc Notify that the cert changed 2017-03-31 21:51:29 -04:00
Zeke Sikelianos
a686237d9b Merge pull request #9080 from electron/fixup-docs-5
Add missing finalUpdate prop
2017-03-31 18:29:16 -07:00
joshaber
bde2a597f3 Decode all the intermediates 2017-03-31 21:27:49 -04:00
joshaber
69defc5166 Encode all the intermediates 2017-03-31 21:27:33 -04:00
Samuel Attard
f757912f90
Add missing finalUpdate prop 2017-04-01 12:11:34 +11:00
Kevin Sawicki
372f209363 Merge pull request #9079 from electron/fix-dialog-args
Move normalizeAccessKeys docs to showMessageBox method
2017-03-31 16:35:31 -07:00
Kevin Sawicki
6d516fbae3 Move normalizeAccessKeys docs to right method 2017-03-31 15:08:03 -07:00
Haojian Wu
f506047a9b Remove an extra blank line. 2017-03-31 21:56:19 +02:00
joshaber
302ca8669d Slightly better conversion 2017-03-31 15:44:47 -04:00
Kevin Sawicki
a724b6555f Bump v1.6.5 2017-03-31 12:10:09 -07:00
Kevin Sawicki
0faa15c6ca Merge pull request #9074 from electron/tabbing-mode-version-guard
Only define NSWindowTabbingModeDisallowed on pre-10.12 SDKs
2017-03-31 12:09:54 -07:00
Haojian Wu
22035e2d6d Fix cpplint: at least two spaces between code and comments. 2017-03-31 20:59:27 +02:00
Kevin Sawicki
08db63c3cc Only define NSWindowTabbingModeDisallowed on pre-10.12 2017-03-31 11:28:55 -07:00
Kevin Sawicki
8a01ebef63 Merge pull request #9053 from electron/enable-crash-reporter-upload-windows
Pass `uploadToServer` option to windows crash reporter
2017-03-31 11:28:35 -07:00
joshaber
141a5ad73f Maybe this is a valid conversion? 2017-03-31 14:16:26 -04:00
Haojian Wu
8ae91682cb Lines should be <= 80 characters. 2017-03-31 20:09:13 +02:00
joshaber
16cc79354c Errrrybody's a scoped_refptr now 2017-03-31 13:53:42 -04:00
joshaber
deae70de4d Dummy out the certificate FromV8 converter 2017-03-31 13:53:31 -04:00
Kevin Sawicki
d677a436ec 🎨 2017-03-31 10:42:43 -07:00
Thiago de Arruda
460fb9cdb9 Add tests for uploadToServer option. 2017-03-31 13:48:07 -03:00
Thiago de Arruda
f0d447cd68 Pass uploadToServer to windows crash reporter 2017-03-31 13:46:30 -03:00
Philip Jackson
1c80102218 📝 Document passing null to Menu.setApplicationMenu
[ci skip]
2017-03-31 16:42:03 +13:00
Kevin Sawicki
96407d9c17 Merge pull request #9057 from electron/upgrade-libcc-for-ffmpeg-linking-fix
Upgrade libcc for ffmpeg linking fix
2017-03-30 15:15:32 -07:00