Kevin Sawicki
4ec7cc913d
Merge pull request #9117 from electron/fix_debug_checks
...
Fixed a couple of failing debug checks when calling Chromium APIs
2017-04-06 08:48:15 -07:00
Kevin Sawicki
b11afc8591
Merge pull request #9129 from runinspring/patch-1
...
Update accelerator.md
2017-04-06 08:47:21 -07:00
Kevin Sawicki
7ea1253aae
Merge pull request #9126 from runinspring/master
...
Update menu.md and menu-item.md
2017-04-06 08:46:55 -07:00
Kevin Sawicki
931290bc59
Merge pull request #9125 from electron/fix-chrome-upgrade-link
...
Fix link to the Upgrading Chrome doc
2017-04-06 08:46:25 -07:00
Kevin Sawicki
11abdb6378
Merge pull request #9124 from TasukuUno/fix-docs
...
Fix document of MimeTypedBuffer Object
2017-04-06 08:45:48 -07:00
ZhangYu
a7d9230497
Update accelerator.md
2017-04-06 17:29:06 +08:00
ZhangYu
c305517957
Update menu-item.md
2017-04-06 15:06:46 +08:00
ZhangYu
0eed821788
Update menu.md
2017-04-06 15:06:02 +08:00
Vadim Macagon
95e782d26c
Fix link to the Upgrading Chrome doc
2017-04-06 16:04:19 +10:00
Ryohei Ikegami
34ed1a9ef8
Track child web contents
2017-04-06 12:15:27 +09:00
Ryohei Ikegami
659722924d
Don't show BrowserWindow in test
2017-04-06 11:44:20 +09:00
Ryohei Ikegami
349ea3a15a
Add test for native addon after reload
2017-04-06 11:43:57 +09:00
Tasuku Uno
59fe7d3dbb
📝 Fix document of MimeTypedBuffer Object
...
[ci skip]
2017-04-06 11:38:59 +09:00
Ryohei Ikegami
526086d900
Improve RootWebContentsTracker
2017-04-06 11:37:21 +09:00
Kevin Sawicki
d857b71557
Merge pull request #9111 from electron/deliver-ipc-messages-to-handlers
...
Fix printing on Windows
2017-04-05 16:27:58 -07:00
Thiago de Arruda
ce1a5e3c9c
Fix sandboxed crashReporter for windows.
...
- Use `path` module from browser process in sandboxed renderer. This is required
because the return value of `path.join` is platform-specific, and this is an
assumtion of crash-reporter.js which is shared between sandboxed and
non-sandboxed renderers.
- Set `process.platform` and `process.execPath` in sandboxed renderer
environment. This is required to spawn the windows crash service from
sandboxed renderer.
- Use a single temporary directory for all crashReporter tests. This is required
to make tests more deterministic across platforms(since mac's crashpad doesn't
support changing the crash dump directory). Also make a few improvements/fixes
to the `uploadToServer` test.
2017-04-05 18:09:24 -03:00
Ales Pergl
73e3fd01eb
Fixed a couple of failing debug checks when calling Chromium APIs
2017-04-05 14:45:46 +02:00
Ales Pergl
fbe3b27409
Addressed review feedback
2017-04-05 14:30:17 +02:00
Ales Pergl
f73233ee55
Changed local variable and parameter names to snake case style
2017-04-05 14:30:17 +02:00
Ales Pergl
ba03c544f3
Address cpplint issue ""public:" should be preceded by a blank line [whitespace/blank_line] [3]"
2017-04-05 14:30:17 +02:00
Ales Pergl
3336e02769
Address cpplint issue "Constructors callable with one argument should be marked explicit. [runtime/explicit] [5]"
2017-04-05 14:30:17 +02:00
Ales Pergl
1a7d9a5d20
Address cpplint issue "At least two spaces is best between code and comments [whitespace/comments] [2]"
2017-04-05 14:30:17 +02:00
Ales Pergl
bf86718d61
Address cpplint issue "DISALLOW_COPY_AND_ASSIGN should be the last thing in the class [readability/constructors] [3]"
2017-04-05 14:30:16 +02:00
Ales Pergl
161b4e752b
Address cpplint issue "public: should be indented +1 space inside class NotificationPresenterWin7 [whitespace/indent] [3]"
2017-04-05 14:30:16 +02:00
Ales Pergl
9d75e9f54c
Address cpplint issue "Namespace should be terminated with "// namespace brightray" [readability/namespace] [5]"
2017-04-05 14:30:16 +02:00
Ales Pergl
64bf0d210e
Address cpplint issue "An else should appear on the same line as the preceding } [whitespace/newline] [4]"
2017-04-05 14:30:16 +02:00
Ales Pergl
9b7fbd4d22
Address cpplint issue "Using C-style cast. Use reinterpret_cast<BYTE*>(...) instead [readability/casting] [4]"
2017-04-05 14:30:16 +02:00
Ales Pergl
91cff2e6c7
Address cpplint issue "Missing space before ( in if( [whitespace/parens] [5]"
2017-04-05 14:30:16 +02:00
Ales Pergl
29f3332276
Address cpplint issue "{ should almost always be at the end of the previous line [whitespace/braces] [4]"
2017-04-05 14:30:16 +02:00
Ales Pergl
63eeb96e71
Address cpplint issue "Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]"
2017-04-05 14:30:16 +02:00
Ales Pergl
20d0bda538
Address cpplint issue "Found C++ system header after other header. Should be: toast.h, c system, c++ system, other. [build/include_order] [4]"
2017-04-05 14:30:16 +02:00
Ales Pergl
33b4936a68
Address cpplint issue "Include the directory when naming .h files [build/include] [4]"
2017-04-05 14:30:15 +02:00
Ales Pergl
0bba5b9b41
Address cpplint issue "Lines should be <= 80 characters long [whitespace/line_length] [2]"
2017-04-05 14:30:15 +02:00
Ales Pergl
392d606848
Changed member variable naming style to snake case
2017-04-05 14:30:15 +02:00
Ales Pergl
0fa6c82b3f
Use NotificationPresenterWin7
on Windows 7
2017-04-05 14:30:15 +02:00
Ales Pergl
fe05b66a6c
Added desktop notifications implementation for Windows 7 (and earlier)
2017-04-05 14:30:15 +02:00
Ales Pergl
e6a30388da
Make Notification
factory function a member of NotificationPresenter
so that we can create different types of notifications based on runtime conditions.
2017-04-05 14:30:15 +02:00
Ryohei Ikegami
b683584859
Add better comments to ShouldCreateNewSiteInstance
2017-04-05 18:16:10 +09:00
Ryohei Ikegami
cbdd52e43b
Always create new SiteInstance on root WebContents
2017-04-05 17:51:17 +09:00
Ryohei Ikegami
90852c665d
Pass RenderFrameHost to ShouldCreateNewSiteInstance
2017-04-05 13:47:02 +09:00
Kevin Sawicki
b27b1c3b24
Append printed page to job
2017-04-04 20:47:05 -07:00
Kevin Sawicki
aa75e4562e
Restore delivering IPC messages to utility handlers
2017-04-04 20:40:57 -07:00
Kevin Sawicki
7574c33ef1
Merge pull request #9028 from electron/fix-popover-items-not-updating
...
Fix popover items not updating
2017-04-04 14:09:59 -07:00
Kevin Sawicki
6a22c6645e
Guard against missing popover identifier
2017-04-04 13:51:39 -07:00
Kevin Sawicki
9c73c991d7
Use const references for params
2017-04-04 13:51:39 -07:00
Samuel Attard
bea56bbdc8
Update as per feedback
2017-04-04 13:51:38 -07:00
Samuel Attard
2fd62d090a
Allow items to be assigned to multiple popovers
2017-04-04 13:51:33 -07:00
Samuel Attard
f05dfc74da
Store parent popover in popover touch bar items
2017-04-04 13:51:13 -07:00
Kevin Sawicki
8c8b737fa2
Merge pull request #9023 from electron/touchbar-set-escape-button
...
TouchBar - Method to set escape button
2017-04-04 13:35:55 -07:00
Kevin Sawicki
74a3a34caa
Add spec for interaction event with escape item
2017-04-04 13:14:56 -07:00