deepak1556
|
b9ace16959
|
update libcc for using custom platform with gin
|
2018-01-02 16:37:12 +09:00 |
|
deepak1556
|
769fbd0d3b
|
REVIEW: register BrowserChildProcessObserver once main message loop is ready
|
2018-01-02 16:37:11 +09:00 |
|
deepak1556
|
1b30cac372
|
Don't delay node module initialization
|
2018-01-02 16:37:11 +09:00 |
|
Cheng Zhao
|
1043f07b42
|
Fix compilation on Windows
|
2018-01-02 16:37:11 +09:00 |
|
deepak1556
|
0df464e16a
|
address review comments
|
2018-01-02 16:37:09 +09:00 |
|
deepak1556
|
ee80313666
|
opt into location service on main thread
|
2018-01-02 16:37:09 +09:00 |
|
deepak1556
|
d29c27dc78
|
REVIEW: obtain mime type from file path only on IO allowed sequence
|
2018-01-02 16:37:09 +09:00 |
|
deepak1556
|
e072213923
|
FIXME: dbus ObjectProxy methods should only be invoked on IO allowed sequence
|
2018-01-02 16:37:09 +09:00 |
|
deepak1556
|
a1592446da
|
REVIEW: access GetApplicationLocale on sequence that allows IO
|
2018-01-02 16:37:08 +09:00 |
|
deepak1556
|
69bd44edbb
|
REVIEW: add render process lifecycle observer only once
|
2018-01-02 16:37:08 +09:00 |
|
deepak1556
|
ebb0e46380
|
REVIEW: create AtomNetworkDelegate on the IO thread
|
2018-01-02 16:37:08 +09:00 |
|
Cheng Zhao
|
b2cef31bc0
|
Revert "Fix race condition when calling JsAsker::BeforeStartInUI"
This reverts commit 37317d74adb53afdcb22c85f2d3987fbae290ac7.
|
2018-01-02 16:37:08 +09:00 |
|
Cheng Zhao
|
6d9b186fa7
|
Fix race condition when calling JsAsker::BeforeStartInUI
|
2018-01-02 16:37:07 +09:00 |
|
deepak1556
|
e30131f30b
|
Initialize isolate holder in standalone node mode
|
2018-01-02 16:37:07 +09:00 |
|
deepak1556
|
88e53b1b5e
|
REVIEW: destroy process singleton on sequence where IO is allowed
|
2018-01-02 16:37:07 +09:00 |
|
deepak1556
|
90acb22a58
|
dont use UI methods on IO thread
|
2018-01-02 16:37:06 +09:00 |
|
deepak1556
|
a518c5c3c4
|
derefence weak ptr only on the same sequence runner it was created in
|
2018-01-02 16:37:06 +09:00 |
|
deepak1556
|
b4e6516ad8
|
fix dcheck failure with invalid UTF8 string conversion for base::Value
|
2018-01-02 16:37:05 +09:00 |
|
deepak1556
|
5c25855ac5
|
create user data dir on thread that allows IO
|
2018-01-02 16:37:05 +09:00 |
|
Cheng Zhao
|
d04ae88426
|
The RenderWidgetHostView might not be available when showing menu
|
2018-01-01 19:37:59 +09:00 |
|
Cheng Zhao
|
bc61f2eafa
|
Copy the callback instead of reference
I don't really see how this could be a problem, likely a bug of VS 2017?
|
2018-01-01 19:37:59 +09:00 |
|
Cheng Zhao
|
46330ac2a9
|
Remove the closed event of Menu
The callback of Menu.popup does more things, and there is actually no
request for the closed event.
|
2018-01-01 17:22:07 +09:00 |
|
Cheng Zhao
|
c3eadd5b63
|
mac: Call callback when menu is programmely closed
|
2018-01-01 16:49:25 +09:00 |
|
Cheng Zhao
|
7b01a8b860
|
Add callback parameter to Menu.popup
|
2018-01-01 16:26:19 +09:00 |
|
Cheng Zhao
|
d7bc127c60
|
mac: Correctly close popup menu
|
2018-01-01 15:40:15 +09:00 |
|
Cheng Zhao
|
c0c2461245
|
Do not create duplicate V8Platform in NodeDebugger
|
2017-12-22 20:29:09 +09:00 |
|
Cheng Zhao
|
00afeaba9a
|
Use Node's V8Platform instead of gin's
|
2017-12-22 20:29:08 +09:00 |
|
Cheng Zhao
|
7a8864063b
|
mac: Handle the case when closing all menu runners
|
2017-12-21 15:57:27 +09:00 |
|
Cheng Zhao
|
088042841d
|
win: Correctly close popup menu
|
2017-12-21 15:26:32 +09:00 |
|
Cheng Zhao
|
e4770c7604
|
Coding style fixes
|
2017-12-20 18:48:09 +09:00 |
|
Heilig Benedek
|
ef7357dedc
|
update tests for menu closed event and call cancel on closePopup
|
2017-12-20 15:40:07 +09:00 |
|
Heilig Benedek
|
bcef6eb3df
|
document menu closed event and fix styling issue
|
2017-12-20 15:40:07 +09:00 |
|
Heilig Benedek
|
c586806609
|
fix flash menu being unresponsive to commands
|
2017-12-20 15:40:07 +09:00 |
|
Heilig Benedek
|
d5ab691fdb
|
fix osr devtools crash introduced during merge
|
2017-12-20 12:57:02 +09:00 |
|
Cheng Zhao
|
b2e6340622
|
Reduce the number of helpers
|
2017-12-20 10:49:49 +09:00 |
|
Cheng Zhao
|
4fd8b04329
|
Better field names for details object
|
2017-12-20 10:25:31 +09:00 |
|
Samuel Attard
|
4d7b85bd01
|
Appease the linter
|
2017-12-20 10:21:38 +09:00 |
|
Samuel Attard
|
98e9311669
|
Give user access to the URL that is attempting to be openExternal'ed
|
2017-12-20 10:21:38 +09:00 |
|
Cheng Zhao
|
81527b71ba
|
Merge pull request #11279 from sethlu/openrecent
Update submenu's title at replacement
|
2017-12-19 15:28:02 +09:00 |
|
Shelley Vohr
|
3fc844c15a
|
add loop to catch null values
|
2017-12-13 14:02:43 -05:00 |
|
Shelley Vohr
|
6252ce466c
|
remove failing badDefault
|
2017-12-12 13:39:38 -05:00 |
|
Shelley Vohr
|
8b447b9291
|
fixing error in registerDefaults
|
2017-12-12 13:08:09 -05:00 |
|
Alexey Kuzmin
|
1caa04c0bf
|
Revert "Add systemPreferences.registerDefaults()"
|
2017-12-12 13:59:15 +03:00 |
|
Cheng Zhao
|
19f1fef040
|
Merge pull request #11283 from electron/fix-event-subscriber-race
Fix race condition in event_subscriber.h
|
2017-12-12 10:49:17 +09:00 |
|
Shelley Vohr
|
a8e67e7f61
|
fixes from review
|
2017-12-11 18:20:12 -05:00 |
|
Shelley Vohr
|
84bab48627
|
improve error handling
|
2017-12-11 13:11:03 -05:00 |
|
Shelley Vohr
|
c5aeda1fdd
|
fixes from code review
|
2017-12-11 00:20:26 -05:00 |
|
Shelley Vohr
|
18ee34f1a1
|
add method binding and error guards
|
2017-12-10 11:25:43 -05:00 |
|
Shelley Vohr
|
1ccad4a7e9
|
fix capitalization and clean logic
|
2017-12-10 11:04:05 -05:00 |
|
Shelley Vohr
|
f82086e6d3
|
first pass at adding infra for registerDefaults
|
2017-12-10 00:45:49 -05:00 |
|