Calvin
b8a21dbcd7
test: migrate to helpers & disabled tests list ( #37513 )
...
* test: migrate to helpers & disabled tests list
* can't disable a test suite
* correct condition
* address review comments
2023-04-04 09:48:51 -04:00
Jeremy Rose
e9d5c3517c
fix: apply csp correctly when contextIsolation: false ( #37756 )
...
* fix: apply csp correctly when contextIsolation: false
* better comments
2023-04-04 17:31:49 +09:00
David Sanders
4c8583c365
test: remove workaround for fixed Menu.closePopup issue ( #37802 )
2023-04-04 10:27:51 +02:00
Samuel Attard
a75b892e90
build: remove request dependency ( #37747 )
...
* build: remove request dependency
* oops
2023-03-31 12:20:25 +02:00
John Kleinschmidt
8f3ef39f1e
chore: update line endings on HTML files ( #37755 )
2023-03-29 15:02:13 -04:00
Will Anderson
2b9dae4b06
feat: add will-frame-navigate
event ( #34418 )
...
* feat: add will-navigate-in-frame event to webContents
* docs: add documentation for webview will-frame-navigate event
* feat: Eliminate isInPlace argument from will-frame-navigate event
* fix: Fire will-frame-navigate before will-navigate
* feat: send will-frame-navigate with a WebFrameMain in the event details
* docs: Update WebContents docs for new API signature
* feat: Add custom event forwarding for <webview> will-frame-navigate
* fix: wrap WebFrameMain so it can be sent as an event
* test: update webContents and <webview> tests to match new signatures
* chore: undo unnecessary change
* fix: don't switch will-navigate to use EmitNavigationEventDetails
* test: clean up will-navigate and will-frame-navigate tests for <webview>
* chore: apply lint fixes
* chore: move GetRenderFrameHost helper into anonymous namespace
* docs: auto-generate WillFrameNavigateDetails rather than defining it manually
* test: Update <webview> tests to actually pass under new spec runner
* docs: Add section explaining relationship between various nav events
* test: Add some tests to ensure navigation event order doesn't silently change
* test: Always monitor all nav events to ensure unexpected ones don't fire
* test: Add test to verify in-page navigation event order
* feat: Change to new style where extra params are exposed as event props
* fix: Remove unused EmitNavigationEventDetails
* fix: Update tests to use new async helpers
* docs: Rename and reorder sections documenting navigation events
---------
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2023-03-28 10:55:41 -04:00
Shelley Vohr
b27e4cae21
fix: crash in MessagePortMain
with some postMessage
params ( #37585 )
...
* fix: crash in MessagePortMain postMessage
* Update shell/browser/api/message_port.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2023-03-27 13:56:55 -04:00
Jeremy Rose
fda8ea9277
feat: add protocol.handle ( #36674 )
2023-03-27 10:00:55 -07:00
George Joseph
e0c348a2f8
feat: Allow usage of an absolute path for partitions used in a session ( #37604 )
...
* Allow an absolute path to be used for creating sessions
Allows an absolute path to be used for creating sessions
by adding the session.fromPath() API.
* Fixup! Clarify that an emptry string is not permitted as a parameter to fromPath()
2023-03-20 10:34:49 -04:00
Erick Zhao
095f9067a7
docs: delete synopsis.md ( #37580 )
...
* docs: delete synopsis.md
* remove code references to doc
2023-03-16 17:05:15 -07:00
Shelley Vohr
b8f970c1c7
fix: properly bubble up cookie creation failure message ( #37586 )
2023-03-16 13:48:14 +01:00
Jeremy Spiegel
bf1cc1aeb2
fix: don't set delegate for QLPreviewPanel
( #37530 )
...
fix: don't set delegate for QLPreviewPanel
2023-03-14 14:41:34 +01:00
Shelley Vohr
8ee58e18fd
refactor: createThumbnailFromPath
takes size
not maxSize
( #37362 )
...
refactor: createThumbnailFromPath takes size not maxSize
2023-03-08 21:48:29 -05:00
Shelley Vohr
512e56baf7
feat: expose audio-state-changed
on webContents
( #37366 )
...
feat: expose audio-state-changed on webContents
2023-03-06 17:00:24 +01:00
Calvin
c8f715f9a1
fix: Showing the about panel is async on all platforms ( #37440 )
...
* fix: about panel is a base::Value::Dict
* nix this test for a diff PR
* what if the about dialog was not blocking
* add this test back in
* document synchronicity
* github editor is a fan of spaces
2023-03-06 09:46:35 -05:00
Shelley Vohr
829fb4f586
fix: don't double-log unhandled rejections ( #37464 )
2023-03-06 11:04:43 +01:00
Jeremy Rose
6bd9ee6988
feat: net.fetch() supports custom protocols ( #36606 )
2023-03-02 15:47:45 -08:00
Shelley Vohr
9b20b3a722
chore: improve contents.takeHeapSnapshot
error messages ( #37434 )
...
* chore: improve contents.takeHeapSnapshot error messages
* fix wstring conversion issue
2023-03-01 10:50:36 -05:00
Shelley Vohr
5e25d23794
fix: handle closing webContents
in BrowserView
s ( #37420 )
...
* fix: handle closing webContents in BrowserViews
* test: add window.close() test
2023-03-01 11:35:06 +01:00
Calvin
1f390119fe
test: add disabled tests list ( #37334 )
2023-02-28 17:27:54 -05:00
Calvin
2e03bdb9b6
fix: about panel crash ( #37373 )
...
* fix: about panel is a base::Value::Dict
* nix this test for a diff PR
2023-02-28 17:26:00 -05:00
Jeremy Rose
3a5ae28c95
feat: expose initiator in navigation events ( #37085 )
2023-02-28 11:08:22 -08:00
Milan Burda
ed7b5c44a2
feat: add types to webRequest filter ( #30914 )
2023-02-27 11:16:59 -08:00
Jeremy Rose
a3e3efe4c4
test: use node helpers for events.once and setTimeout promise ( #37374 )
2023-02-23 15:53:53 -08:00
Shelley Vohr
32c60b29bb
fix: html fullscreen when window not fullscreenable ( #37348 )
2023-02-21 12:11:34 +01:00
Black-Hole
868676aa5c
feat: add httpOnly
cookies.get
filter ( #37255 )
...
feat: add httpOnly cookies filter
2023-02-21 11:44:35 +01:00
Cheng Zhao
a92fd2aa05
fix: restoring X11 window should not remove previous maximize state ( #37346 )
2023-02-21 09:49:02 +01:00
Jeremy Rose
872d1fe05a
feat: implement net.fetch ( #36733 )
2023-02-20 12:57:38 -08:00
Milan Burda
f97d68c4bf
test: convert functions to async & eliminate duplicates ( #37316 )
...
test: convert functions to async
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-20 12:30:57 +01:00
Milan Burda
969665eaa2
test: type-safe import of menu-item-roles in api-menu-item-spec.ts ( #37320 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-19 01:27:03 -08:00
Milan Burda
0d8dd61257
test: use expect(dir).to.be.an.instanceof(fs.Dirent); ( #37331 )
2023-02-19 01:25:40 -08:00
Milan Burda
cf10c19c33
test: cleanup let xyz = null as unknown as T; ( #37335 )
2023-02-19 01:24:24 -08:00
Milan Burda
fcfbcbc7e1
test: move desktopCapturer usage from renderer to main in ts-smoke ( #37321 )
2023-02-17 16:29:36 -06:00
Milan Burda
e34cc6f48c
test: enable linting of ts-smoke and fix all issues ( #37322 )
2023-02-17 12:56:09 -06:00
Milan Burda
ee87438d28
test: use async helpers to simplify tests ( #37314 )
...
test: use async helpers to simplify the tests
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-17 12:32:39 -06:00
Cheng Zhao
0de1012280
feat: add BrowserWindow.set/getWindowButtonPosition APIs ( #37094 )
2023-02-17 19:06:32 +09:00
Milan Burda
0a5e634736
test: rename & split internal module tests ( #37318 )
2023-02-17 10:14:40 +01:00
Alexey Kuzmin
73b7aac6a4
test: fix "crash cases" tests not failing properly ( #37304 )
...
* test: fix "crash cases" tests not failing properly
* fixup! test: fix "crash cases" tests not failing properly
2023-02-17 10:14:00 +01:00
Milan Burda
ea848bc1c5
test: use webContents.create() in type-safe way ( #37281 )
...
test: use (webContents as typeof ElectronInternal.WebContents).create()
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-16 15:41:41 +01:00
Milan Burda
beed240454
test: use render-process-gone event in tests ( #37280 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-16 01:25:41 -08:00
Jeremy Rose
71944f2c3b
refactor: simplify events ( #37099 )
2023-02-13 13:39:18 -08:00
Black-Hole
8b3e498436
fix: cookies filter secure invalid ( #37203 )
2023-02-13 15:02:55 +01:00
Jeremy Rose
01f1522cbd
chore: change undocumented protocol.registerProtocol to detect body type ( #36595 )
...
* feat: add protocol.registerProtocol
* remove wip handleProtocol code
* lint
* Update shell/browser/net/electron_url_loader_factory.h
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
* fix
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2023-02-13 16:48:30 +09:00
David Sanders
a37f572388
chore: update links in comments ( #37197 )
2023-02-11 18:52:54 -08:00
Milan Burda
3180312595
chore: update https://cs.chromium.org/ links to https://source.chromium.org/ ( #37190 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-11 18:52:32 -08:00
Milan Burda
e5e9186d61
docs: add missing clipboard-sanitized-write permission value to setPermissionRequestHandler() ( #37173 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-09 11:38:39 +01:00
Samuel Attard
8b380ee2f2
test: ensure fullscreen test is retryable ( #37179 )
...
spec: ensure fullscreen test is retryable
2023-02-08 12:40:24 -08:00
Samuel Attard
00a542358d
build: only retry tests on CI ( #37167 )
2023-02-07 22:44:53 -08:00
Milan Burda
6a3cb34326
fix: expose native bindings by process type ( #35949 )
2023-02-07 20:22:18 -05:00
Jeremy Rose
67dc178e70
refactor: move gin_helper::Constructible methods to prototype ( #37087 )
2023-02-06 12:59:49 -08:00