Charles Kerr
435c9c1486
Force uv loop cleanup ( #11465 )
...
* ensure all uv handles are closed before ending worker's loop
* add DCHECK to test that the Worker loop is finished
* don't call deprecated uv_loop_new(), uv_loop_delete()
* make cpplint happy
* fix comment error
* empty commit for CI
* tweak DCHECK expression
* extract-method: stop_and_close_uv_loop()
* fix DCHECK oops
2018-01-04 11:16:06 -08:00
Zeke Sikelianos
eb89e12c5b
Merge pull request #11532 from sethlu/camelcase-menuitem-role
...
Make MenuItem roles camelCase-compatible
2018-01-04 09:53:58 -08:00
Cheng Zhao
6bc7c8cc49
Merge pull request #11396 from electron/enable_base_dchecks
...
fix: enable additional dchecks
2018-01-04 21:19:12 +09:00
Cheng Zhao
9bd192ea17
Update libcc to latest
2018-01-04 16:14:01 +09:00
Zhuo Lu
df841fa397
Revert changes made to test case
...
The MenuItem role should be lowercase
2018-01-04 14:38:58 +08:00
Samuel Attard
1553b54779
Add window.loadFile and webContents.loadFile helper methods
2018-01-04 11:38:56 +13:00
Cheng Zhao
1ff872519c
posix: Fix assertion when freeing ProcessSingleton
2018-01-03 19:47:01 +09:00
Cheng Zhao
1072c75e38
Closing asar file should be syncronous
2018-01-03 19:12:16 +09:00
Cheng Zhao
fb78052b3d
Remove unnecessary scope
2018-01-03 19:10:48 +09:00
Cheng Zhao
104585e772
Do not create DIR_USER_DATA on IO thread
...
It would slowdown the startup time of apps since we have wait for two
message posts between threads.
2018-01-03 19:07:24 +09:00
Cheng Zhao
952928dc79
Singleton must be created on request
...
The creation of singleton relies on the `userData` dir, which can be
changed by user, we have to ensure singleton uses the `userData` dir set
by user.
2018-01-03 18:59:12 +09:00
Cheng Zhao
0cce6b3d21
Fix cpplint warning
2018-01-03 17:32:18 +09:00
Cheng Zhao
d6068759b6
win: Fix assertion when creating Notification
2018-01-03 17:25:19 +09:00
TechnicalSoup
0ea296b1cb
docs: specify string values for DownloadItem
...
Explicitly list the possible string return values for the updated and done events so that the typescript declaration file can model them more accurately. At present they are represented as a string type.
Fixes : https://github.com/electron/electron-typescript-definitions/issues/71
2018-01-03 13:34:19 +11:00
deepak1556
14de22a8c7
Use cached application locale as default for generating accept-lang header
2018-01-02 17:33:46 +05:30
deepak1556
cbc433d4cb
update libcc to fix DCHECK errors in ui::clipboard on windows
2018-01-02 16:32:07 +05:30
Cheng Zhao
de93b30d3c
win: Fix assertion when getting exe version
2018-01-02 17:02:12 +09:00
Cheng Zhao
82452e7924
win: Fix assertion when getting printers
2018-01-02 16:54:36 +09:00
Cheng Zhao
7bf156d197
win: Fix assertion "IsWprintfFormatPortable(format)"
2018-01-02 16:45:43 +09:00
deepak1556
7b9dd81018
update libcc for macOS render widget dcheck crash fix
2018-01-02 16:37:12 +09:00
deepak1556
b9ace16959
update libcc for using custom platform with gin
2018-01-02 16:37:12 +09:00
deepak1556
769fbd0d3b
REVIEW: register BrowserChildProcessObserver once main message loop is ready
2018-01-02 16:37:11 +09:00
deepak1556
1b30cac372
Don't delay node module initialization
2018-01-02 16:37:11 +09:00
Cheng Zhao
1043f07b42
Fix compilation on Windows
2018-01-02 16:37:11 +09:00
deepak1556
237bd6790b
FIXME: allow IO access on main thread for crash reporter
2018-01-02 16:37:11 +09:00
deepak1556
abe1faea5c
REVIEW: setup request context for NSS OCSP only once
2018-01-02 16:37:11 +09:00
deepak1556
e3a56240c9
REVIEW: fix base::File helper usage on incorrect task sequence
2018-01-02 16:37:10 +09:00
deepak1556
fd297722a8
Note about incorrect usage of blink::SchemeRegistry methods
2018-01-02 16:37:10 +09:00
deepak1556
73919ea91a
update libcc
2018-01-02 16:37:10 +09:00
deepak1556
d27744f455
Some blink::WebSecurityPolicy methods should be invoked before other render threads are created
2018-01-02 16:37:10 +09:00
deepak1556
0df464e16a
address review comments
2018-01-02 16:37:09 +09:00
deepak1556
ee80313666
opt into location service on main thread
2018-01-02 16:37:09 +09:00
deepak1556
d29c27dc78
REVIEW: obtain mime type from file path only on IO allowed sequence
2018-01-02 16:37:09 +09:00
deepak1556
e072213923
FIXME: dbus ObjectProxy methods should only be invoked on IO allowed sequence
2018-01-02 16:37:09 +09:00
deepak1556
a1592446da
REVIEW: access GetApplicationLocale on sequence that allows IO
2018-01-02 16:37:08 +09:00
deepak1556
1912fbb073
reenable some specs
2018-01-02 16:37:08 +09:00
deepak1556
69bd44edbb
REVIEW: add render process lifecycle observer only once
2018-01-02 16:37:08 +09:00
deepak1556
ebb0e46380
REVIEW: create AtomNetworkDelegate on the IO thread
2018-01-02 16:37:08 +09:00
Cheng Zhao
b2cef31bc0
Revert "Fix race condition when calling JsAsker::BeforeStartInUI"
...
This reverts commit 37317d74adb53afdcb22c85f2d3987fbae290ac7.
2018-01-02 16:37:08 +09:00
Cheng Zhao
6d9b186fa7
Fix race condition when calling JsAsker::BeforeStartInUI
2018-01-02 16:37:07 +09:00
deepak1556
e30131f30b
Initialize isolate holder in standalone node mode
2018-01-02 16:37:07 +09:00
deepak1556
88e53b1b5e
REVIEW: destroy process singleton on sequence where IO is allowed
2018-01-02 16:37:07 +09:00
deepak1556
c3154d86e0
FIXME: disable some specs
2018-01-02 16:37:07 +09:00
deepak1556
1d95241185
FIXME: refactor and remove usage of ScopedAllowIO where possible
2018-01-02 16:37:06 +09:00
deepak1556
90acb22a58
dont use UI methods on IO thread
2018-01-02 16:37:06 +09:00
deepak1556
a518c5c3c4
derefence weak ptr only on the same sequence runner it was created in
2018-01-02 16:37:06 +09:00
deepak1556
fedf1d889b
handle NaN conversion from V8
2018-01-02 16:37:06 +09:00
deepak1556
db156865e7
pref store needs to be loaded on a thread that allows IO
2018-01-02 16:37:06 +09:00
deepak1556
b4e6516ad8
fix dcheck failure with invalid UTF8 string conversion for base::Value
2018-01-02 16:37:05 +09:00
deepak1556
5c25855ac5
create user data dir on thread that allows IO
2018-01-02 16:37:05 +09:00
