Commit graph

32 commits

Author SHA1 Message Date
Charles Kerr
402201ac39
Fix cppcheck warnings (#11883)
* remove unused variable

* limit scope of variable 'ret'

* pass shared_ptr<SkBitmap> by reference

* silence warning: value reassign before read

* fix oops

* don't refer to 'response' after std::move()ing it

* make the linter happy
2018-02-14 02:21:46 -06:00
Aleksei Kuzmin
5831a5ffa1 Refactor client cert private key handling.
https://codereview.chromium.org/2898573002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
2c063f93ff Remove raw base::DictionaryValue::Set
https://codereview.chromium.org/2911033002
2017-11-24 10:58:16 +09:00
Thiago de Arruda
a9a9e58b68 Fix random crash on app quit.
Move AtomCTDelegate to brightray as RequireCTDelegate and transfer ownership to
brightray::URLRequestContextGetter. This fixes the wrong lifetime assumptions
that result in AtomCTDelegate being used after free in some scenarios.

Close #10051
2017-11-17 12:03:23 -03:00
Kevin Sawicki
7e185ef1a3 Remove extra newlines 2017-05-19 08:46:15 -07:00
Kevin Sawicki
d7321ed980 Add brightray prefix to include paths from within brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
c4608c0f37 Fix build/include_alpha linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
f193b2b2a6 Fix build/include_what_you_use linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
cfb5b6ac89 Fix build/header_guard linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
bb4a61c7ff Remove unused includes 2017-05-19 08:46:15 -07:00
Cheng Zhao
0a110a44f9 ScopedPtrHashMap has been removed 2017-04-17 16:16:02 +09:00
Haojian Wu
d18b34d55f Replace size() method with empty() when possible.
There is no guaranteed that size() is a constant-time function.
2017-03-30 21:49:16 +02:00
Kevin Sawicki
2ece711c2e Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
Kevin Sawicki
be0c0e278a Remove cpplint errors 2017-03-23 12:48:27 -07:00
Cheng Zhao
db7959619e Update DevToolsNetworkUploadDataStream 2017-01-23 15:18:52 +09:00
Cheng Zhao
0236f87507 Update DevToolsNetworkTransaction 2017-01-23 15:10:34 +09:00
Ales Pergl
85db1bb47d Adjustments after upgrading to Chromium 54 2017-01-17 17:18:51 +09:00
deepak1556
237cb7d0a3 interceptor should handle default values of download and upload throughput 2017-01-06 23:28:49 +05:30
Cheng Zhao
ab14221a85 Fix API changes of Chrome 53 2016-09-06 17:22:52 +09:00
Cheng Zhao
6dfd0518cd Merge pull request #235 from electron/modernize-to-c11
Modernize to C++11
2016-07-11 09:03:09 +09:00
Haojian Wu
0cf7454d4b Modernize to C++11 : use auto. 2016-07-10 13:12:33 +02:00
Haojian Wu
b85c3b5e7f Remove unused using decls. 2016-07-09 22:40:41 +02:00
Cheng Zhao
4ccf4394d7 Fix compilation errors on Linux 2016-05-23 15:26:44 +09:00
Cheng Zhao
851ef398fb Adapt to changes of Chrome 51 API changes 2016-05-23 10:59:07 +09:00
deepak1556
de60acbfde Fix race initialising DevtoolsNetworkController 2016-04-14 08:57:20 +05:30
Robo
215a81d0e6 update devtools network interceptor to throttle uploads 2016-03-14 04:01:30 +05:30
Cheng Zhao
baf5f384cd Pass() is deprecated for std::move 2016-03-08 20:59:29 +09:00
Paul Betts
d204febecf Update DevtoolsNetworkTransaction 2016-03-07 22:29:23 -08:00
Paul Betts
da59c0f58b basictypes.h => macros.h 2016-03-07 21:40:41 -08:00
Robo
9b88fd4021 devtools: exclude devtools related http header from serviceworker context 2015-12-19 02:29:39 +05:30
Cheng Zhao
75d0bc848d Update to API changes of Chrome 47 2015-12-07 19:55:01 +08:00
Robo
a1e646f1b3 enabling network emulation in devtools 2015-09-27 21:38:38 +05:30