Charles Kerr
af54c5a4b6
test: add tests dbus notification images ( #43938 )
...
Provide a NativeImage icon in the notification tests and then inspect
the DBus message payload's `image_data` hint to see if it's correct.
This adds test coverage for LibnotifyNotification::Show() and for
GdkPixbufFromSkBitmap().
2024-09-25 13:17:27 +02:00
Shelley Vohr
bcf4095ace
fix: crash when focusing WebView webContents ( #43921 )
...
fix: crash when focusing WebView
2024-09-24 18:19:04 -05:00
Charles Kerr
500d4f0d05
fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() ( #43896 )
2024-09-24 15:41:24 -05:00
CezaryKulakowski
e64a66bfd3
fix: detach native view when its removed from parent on macOS ( #43627 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
2024-09-24 15:28:36 +02:00
dependabot[bot]
7222a9fe1f
build(deps-dev): bump null-loader from 4.0.0 to 4.0.1 ( #43904 )
...
Bumps [null-loader](https://github.com/webpack-contrib/null-loader ) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/webpack-contrib/null-loader/releases )
- [Changelog](https://github.com/webpack-contrib/null-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/null-loader/compare/v4.0.0...v4.0.1 )
---
updated-dependencies:
- dependency-name: null-loader
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-24 10:13:43 +02:00
dependabot[bot]
65e3c336e0
build(deps-dev): bump eslint from 8.41.0 to 8.57.1 ( #43903 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.41.0 to 8.57.1.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.41.0...v8.57.1 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 23:31:47 -07:00
Charles Kerr
79627deea3
refactor: add SerialChooserController::web_contents_ ( #43823 )
...
Add a `base::WeakPtr<WebContents>` field to SerialChooserController and
stop subclassing from WebContentsObserver. This follows the Observer docs:
> don't create a `WebContentsObserver` just to be able to check
> for a null `WebContentsObserver::web_contents()`.
> Use a `base::WeakPtr<WebContents>` instead.
2024-09-23 22:38:13 -07:00
Charles Kerr
9598d88b7c
refactor: remove C-style void arg type for no-arg functions ( #43884 )
...
A small cleanup to remove use of the C-style function declaration idiom.
2024-09-23 22:37:32 -07:00
Charles Kerr
01330805cb
refactor: prefer member initializers in asar structs ( #43883 )
...
prefactor: prefer member initializers in asar::Archive
prefactor: prefer member initializers in asar::Archive::FileInfo
prefactor: prefer member initializers in asar::IntegrityPayload
2024-09-23 22:37:18 -07:00
Charles Kerr
33d7c9ac3e
refactor: hide printing impl details in api::WebContents ( #43893 )
...
* refactor: move api::WebContents::OnGetDeviceNameToUse() into an anonymous namespace
* refactor: move api::WebContents::OnPDFCreated() into an anonymous namespace
* refactor: remove unused #include
2024-09-23 22:36:55 -07:00
Keeley Hammond
a3af8ea768
build: use Node 20 in Appveyor images ( #43897 )
...
* build: update Appveyor to Node 20
* build: update appveyor images
* chore: return bake script to original form
2024-09-23 16:58:46 -07:00
dependabot[bot]
82879d1f43
build(deps-dev): bump webpack-cli from 4.10.0 to 5.1.4 ( #43880 )
...
Bumps [webpack-cli](https://github.com/webpack/webpack-cli ) from 4.10.0 to 5.1.4.
- [Release notes](https://github.com/webpack/webpack-cli/releases )
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@4.10.0...webpack-cli@5.1.4 )
---
updated-dependencies:
- dependency-name: webpack-cli
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 18:21:43 -05:00
Erick Zhao
fb5baec6d5
docs: add advanced specification for Squirrel updater ( #43234 )
...
* docs: add advanced specification for Squirrel updater
* address feedback
2024-09-23 10:20:43 -07:00
Alice Zhao
ceea1225a2
docs: navigation history example ( #42980 )
...
* docs: add fiddle example
* docs: add tutorial guide
* refactor: PR review comments
* refactor: add eof
* refactor: render navigation history and make demo better.
* refactor: fix broken links
* refactor: add eof newline
* docs: review feedback :)
* chore: lint add space around list
* doc: transformURL
2024-09-23 10:18:26 -07:00
Samuel Attard
517d04de16
build: add support for fetching github token from sudowoodo ( #43808 )
...
* build: add support for fetching github token from sudowoodo
* chore: update release notes cache for tests
* build: support nightlies repo correctly
* build: post token
2024-09-23 09:39:54 -07:00
dependabot[bot]
f0afcaa777
build(deps-dev): bump @types/w3c-web-serial from 1.0.3 to 1.0.7 ( #43879 )
...
Bumps [@types/w3c-web-serial](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/w3c-web-serial ) from 1.0.3 to 1.0.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/w3c-web-serial )
---
updated-dependencies:
- dependency-name: "@types/w3c-web-serial"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 08:07:53 -05:00
Samuel Attard
be68d4f336
build: update-check-skip on dependabot backport PRs ( #43874 )
2024-09-23 11:08:03 +02:00
dependabot[bot]
0fb50c408b
build(deps): bump github/codeql-action from 3.26.7 to 3.26.8 ( #43826 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.7 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](8214744c54...294a9d9291
2024-09-23 11:04:21 +02:00
dependabot[bot]
1b52f005ee
build(deps): bump actions/setup-node from 4.0.3 to 4.0.4 ( #43825 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](1e60f620b9...0a44ba7841
2024-09-22 23:40:30 -07:00
Samuel Attard
da449b00dd
build: stop dependabot doing things ( #43871 )
2024-09-22 23:10:23 -07:00
Samuel Attard
8be458d1a2
build: enable dependabot on supported branches ( #43755 )
2024-09-22 22:57:23 -07:00
Charles Kerr
e894839709
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #43803 )
2024-09-21 17:21:02 -05:00
Shelley Vohr
f89bd745d5
fix: createWindow shouldn't load URL for webContents ( #43775 )
...
* fix: createWindow shouldn't load URL for webContents
* chore: add non about blank test
2024-09-20 09:56:03 +02:00
Charles Kerr
bcb7362ab9
docs: document Windows pitfall when updating patches ( #43787 )
2024-09-19 23:35:21 -05:00
Charles Kerr
53e89b565d
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() ( #43795 )
...
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()
* chore: add a DCHECK to confirm the BigBuffer is full
2024-09-19 23:10:35 -05:00
Fedor Indutny
6aa6bada79
fix: third time screen sharing on macOS ( #43767 )
...
Because we used decrementing negative source ids for fake video id when
instantating a native macOS screen share picker, we eventually hit the
`DesktopMediaID::kFakeId = -3` in Chromium source code which displayed a
test green screen.
In this change we reserve our own fake id of `-4` and decrement the
window id integer for uniqueness instead.
Co-authored-by: Fedor Indutny <238531+indutny@users.noreply.github.com>
2024-09-19 18:28:28 -07:00
Charles Kerr
d100921289
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43794 )
2024-09-19 19:02:49 -05:00
BILL SHEN
855f219301
chore: fix compile issue about ambiguous error of multiple methods named 'highlight'. ( #43773 )
...
chore: fix ambiguous error of multiple methods named 'highlight'
2024-09-19 13:01:36 +02:00
dependabot[bot]
0ac8ff6439
build(deps): bump path-to-regexp from 1.8.0 to 1.9.0 in /spec in the npm_and_yarn group across 1 directory ( #43753 )
...
build(deps): bump path-to-regexp
Bumps the npm_and_yarn group with 1 update in the /spec directory: [path-to-regexp](https://github.com/pillarjs/path-to-regexp ).
Updates `path-to-regexp` from 1.8.0 to 1.9.0
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases )
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md )
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v1.8.0...v1.9.0 )
---
updated-dependencies:
- dependency-name: path-to-regexp
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-19 10:34:06 +02:00
Charles Kerr
5904d31264
perf: hold V8FunctionInvoker args in a std::array ( #43752 )
...
perf: hold V8FunctionInvoker args in a std::array
2024-09-18 16:23:29 -05:00
Samuel Attard
8cff5a7d20
build: let darwin/mas run concurrently ( #43788 )
2024-09-18 13:54:58 -07:00
Charles Kerr
d897359b82
perf: hold Emit() arg arrays in a std::array ( #43750 )
...
* refactor: CallMethodWithArgs() now takes a span of value handles
* perf: use std::array instead of std::vector to hold Emit arg parameter packs
* chore: remove unused gin_helper::EmitEvent(iso, obj, name, span<Local>)
2024-09-18 09:40:14 -05:00
electron-appveyor-updater[bot]
02fd8bbcc1
build: update appveyor image to latest version ( #43772 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-09-18 09:39:49 -05:00
electron-roller[bot]
4bcbc955dd
chore: bump chromium to 130.0.6695.0 (main) ( #43454 )
...
* chore: bump chromium in DEPS to 130.0.6673.0
* chore: bump chromium in DEPS to 130.0.6675.0
* chore: bump chromium in DEPS to 130.0.6677.2
* chore: bump chromium in DEPS to 130.0.6679.0
* 5802981: [Partitioned Popins] UKM
https://chromium-review.googlesource.com/c/chromium/src/+/5802981
* 5799275: ash: Create //chrome/browser/ui/ash/web_view
https://chromium-review.googlesource.com/c/chromium/src/+/5799275
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5805208: Move third_party/jacoco to a cipd/ subdirectory.
https://chromium-review.googlesource.com/c/chromium/src/+/5805208
* chore: fixup patch indices
* 5771091: Introduce InputManager class for handling input in Viz.
https://chromium-review.googlesource.com/c/chromium/src/+/5771091
* 5498921: [Permission] Remove SubscribeToPermissionStatusChange from PermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5498921
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5801311: Don't use int for bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5801311
* 5548827: [Web Install] Define the web-app-installation PermissionPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/5548827
* 5786325: Add Infrastructure for Hand tracking permission
https://chromium-review.googlesource.com/c/chromium/src/+/5786325
* chore: fixup patch indices
* chore: bump chromium in DEPS to 130.0.6681.0
* [Views AX] Move BrowserAccessibility* to //ui/accessibility/platform
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5520052
* chore: e patches all
* Don't have default arguments on virtual functions in render_frame_host.h
https://chromium-review.googlesource.com/c/chromium/src/+/5809399
* test: log if loadURL fails in base url test
* chore: bump chromium in DEPS to 130.0.6683.2
* chore: fix support_mixed_sandbox_with_zygote.patch
content: restore old DisableJit behavior
https://chromium-review.googlesource.com/c/chromium/src/+/5804255
* chore: update patch indices
* chore: bump chromium in DEPS to 130.0.6685.0
* Parallel process launching
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* chore: update feat_expose_documentloader_setdefersloading_on_webdocumentloader.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 130.0.6687.0
* chore: bump chromium in DEPS to 130.0.6689.0
* chore: bump chromium in DEPS to 130.0.6691.0
* chore: bump chromium in DEPS to 130.0.6693.0
* chore: update patches
* chore: bump chromium in DEPS to 130.0.6695.0
* chore: free up macos disk space as soon as possible
* 5824143: Use checked in source lists for third_party/boringssl
https://chromium-review.googlesource.com/c/chromium/src/+/5824143
* chore: update patches
* 5824122: Extensions: Add a new view type enum for developer tools contexts
https://chromium-review.googlesource.com/c/chromium/src/+/5824122
* 5806109: Option for JavaScriptExecuteRequestForTests() to ignore content settings
https://chromium-review.googlesource.com/c/chromium/src/+/5806109
* build: free up disk space on gn check too
* 5799369: [Refactoring] Make allow_http1_for_streaming_upload flags false.
https://chromium-review.googlesource.com/c/chromium/src/+/5799369
* fixup! 5015584: Parallel process launching | https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* Disable failing test for short-term
See: https://github.com/electron/electron/issues/43730
* oops
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
2024-09-17 18:12:11 -07:00
Samuel Attard
de33cc68f6
build: split darwin/mas macOS publish jobs ( #43754 )
2024-09-17 15:32:47 -07:00
Samuel Attard
f987f8ad83
build: improve logging on http errors during release process (again, but more) ( #43758 )
2024-09-17 15:01:02 -07:00
Samuel Attard
cf4ab2186c
build: improve logging on http errors during release process (again) ( #43757 )
2024-09-17 14:49:59 -07:00
Samuel Attard
10ba87a85e
build: improve logging on http errors during release process ( #43756 )
2024-09-17 14:30:51 -07:00
Charles Kerr
233724fe00
chore: iwyu mojom-forward header files ( #43741 )
...
* chore: iwyu mojom.h headers
* fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
* fixup! fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
2024-09-17 12:58:56 -07:00
dependabot[bot]
4dc923a327
build(deps): bump the npm_and_yarn group across 2 directories with 5 updates ( #43681 )
...
Bumps the npm_and_yarn group with 1 update in the / directory: [express](https://github.com/expressjs/express ).
Bumps the npm_and_yarn group with 1 update in the /spec directory: [send](https://github.com/pillarjs/send ).
Updates `express` from 4.19.2 to 4.20.0
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.19.2...4.20.0 )
Updates `body-parser` from 1.20.2 to 1.20.3
- [Release notes](https://github.com/expressjs/body-parser/releases )
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md )
- [Commits](https://github.com/expressjs/body-parser/compare/1.20.2...1.20.3 )
Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases )
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md )
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v0.1.7...v0.1.10 )
Updates `serve-static` from 1.15.0 to 1.16.0
- [Release notes](https://github.com/expressjs/serve-static/releases )
- [Changelog](https://github.com/expressjs/serve-static/blob/master/HISTORY.md )
- [Commits](https://github.com/expressjs/serve-static/compare/v1.15.0...1.16.0 )
Updates `send` from 0.16.2 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases )
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md )
- [Commits](https://github.com/pillarjs/send/compare/0.16.2...0.19.0 )
---
updated-dependencies:
- dependency-name: express
dependency-type: direct:development
dependency-group: npm_and_yarn
- dependency-name: body-parser
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: path-to-regexp
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: serve-static
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: send
dependency-type: direct:development
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-17 11:27:32 -04:00
Charles Kerr
5a76655fb8
fix: in Emit(), don't leak converted Arg Local<Values> into caller's scope ( #43729 )
...
fix: Emit() should not leak converted arg handles into caller's HandleScope
2024-09-17 09:00:52 -05:00
Shelley Vohr
aa719a4066
fix: resizing border on Linux WCO caption buttons ( #43724 )
...
Closes https://github.com/electron/electron/issues/43714 .
Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.
2024-09-17 11:56:43 +02:00
Samuel Attard
c1c8fbfd9a
build: make is_mas_build a generated header instead of config ( #43737 )
2024-09-17 01:38:56 -07:00
dependabot[bot]
b83810982e
build(deps): bump github/codeql-action from 3.26.6 to 3.26.7 ( #43738 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.6 to 3.26.7.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4dd16135b6...8214744c54
2024-09-16 23:09:24 -05:00
Charles Kerr
b6bf277b6f
refactor: reduce code duplication in gin_helper::Promise ( #43716 )
...
* refactor: move scope scaffolding into SettletScope
idea stolen from SpellCheckScope
* refactor: move impl of PromiseBase::RejectPromise() to the cc file
* chore: remove unused #include
2024-09-16 23:08:40 -05:00
Charles Kerr
05dfd14913
refactor: add EmitWarning(v8::Isolate*) helper ( #43722 )
...
* refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove EmitWarning(node::Environment*, ...)
* chore: add code comments
* fixup! refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove unused node #includes
2024-09-16 15:53:04 -05:00
John Kleinschmidt
7d4f202c1c
ci: move Archaeologist to GHA ( #43701 )
...
* chore: move Archaeologist to GHA
* chore: test archaelogist changes
* Revert "chore: test archaelogist changes"
This reverts commit a575d6ef3a6495a71c03e9e2d15ec9bb329c5033.
* chore: properly name steps in archaeologist-dig
2024-09-16 15:58:51 -04:00
Niklas Wenzel
f84ffc8fc8
fix: prevent loading spinner when launching utility process on Windows ( #43657 )
...
fix: prevent spinning cursor when launching utility process on Windows
2024-09-16 14:20:42 -04:00
Niklas Wenzel
8f0dffea9e
docs: document View.removeChildView edge case ( #43673 )
2024-09-16 11:32:03 +02:00
Charles Kerr
1c3a5ba5d1
refactor: remove use of deprecated API BuildServiceInstanceFor() ( #43690 )
...
* refactor: update BadgeManagerFactory
* refactor: update NetworkContextServiceFactory
* refactor: update ElectronExtensionSystemFactory
* refactor: update UsbChooserContextFactory
* refactor: update UsbHidChooserContextFactory
* refactor: update SerialChooserContextFactory
* refactor: update FileSystemAccessPermissionContextFactory
2024-09-12 15:44:14 -05:00
