mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
17255 commits 1 branch 183 tags 5.3 GiB
Commit graph

1745 commits

Author SHA1 Message Date
Kevin Sawicki
2a8b36c761 Merge pull request #8134 from deepak1556/empty_client_certificate_patch 
app: select-client-certificate event callback can accept certificate optionally
 2016-12-15 08:31:12 -08:00
Kevin Sawicki
cd067bca37 Merge pull request #8175 from gerhardberger/createfrombuffer-bitmap 
Add bitmap support to nativeImage.createFromBuffer
 2016-12-14 13:24:45 -08:00
Kevin Sawicki
8680a08a8d Add deprecated comment to scaleFactor parameter 2016-12-14 10:18:01 -08:00
Kevin Sawicki
7a5ec96d53 Prevent input event from main process 2016-12-13 15:54:13 -08:00
Kevin Sawicki
5ae80d541b Remove will-navigate spec 2016-12-13 15:54:13 -08:00
Birunthan Mohanathas
a3b65ad481 Add before-input-event event for webContents (fixes #7586) 
Embedding arbitrary web content is problematic when it comes to keyboard
shortcuts because:

* Web content can steal app shortcuts (see e.g. brave/browser-laptop#4408)

* Blocked web content (e.g. a focused <webview> performing expensive
computation) will also prevent app shortcuts from firing immediately

The new before-input-event event can be used to overcome these issues by
always handle certain keyboard events in the main process.

Note that this requires electron/brightray#261 to compile.
 2016-12-13 15:54:13 -08:00
gellert
9d2c9df992 adds empty bitmap test for createFromBuffer 2016-12-14 00:24:57 +01:00
gellert
7ceb8d1ab8 additional tests for createFromBuffer 2016-12-14 00:18:24 +01:00
gellert
a609e52a14 moves bitmap parameters to options object 2016-12-13 21:32:17 +01:00
gellert
39875c90f1 adds bitmap support to createFromBuffer 2016-12-13 21:32:17 +01:00
Kevin Sawicki
c108088110 Test with some null/undefined windows 2016-12-12 16:25:14 -08:00
Kevin Sawicki
cb7715a572 Merge pull request #8187 from electron/optional-buttons 
Allow buttons to be optional in 'showMessageBox'
 2016-12-12 13:52:17 -08:00
Kevin Sawicki
b08bc02cde Merge pull request #8137 from deepak1556/media_device_id_patch 
session: reset media device id salt when cookies are cleared
 2016-12-12 13:34:24 -08:00
Kevin Sawicki
04e873f78e Make deviceIds const 2016-12-12 13:33:18 -08:00
Kevin Sawicki
04da9257ef Catch any close window errors 2016-12-12 13:32:27 -08:00
Kevin Sawicki
f2aabeefd5 Merge pull request #8085 from deepak1556/protocol_http_session_patch 
protocol: support custom session with interceptHttpProtocol
 2016-12-12 13:07:14 -08:00
Kevin Sawicki
1d288b69e2 Merge pull request #7947 from beakerbrowser/register-standard-secure-schemes 
Add {secure:} opt to protocol.registerStandardSchemes
 2016-12-12 12:52:28 -08:00
Paul Frazee
99ea50649a finish implementation of {secure:true} opt on protocol.registerStandardScehesm, and add working test 2016-12-12 12:49:57 -08:00
Daniel Pham
4b53cd9c3c 🐛 Allow buttons to be optional in 'showMessageBox' 2016-12-12 13:25:32 -05:00
Kevin Sawicki
2fa9ca1f6d Merge pull request #8156 from sindresorhus/remove-dock-window-level 
🍎 Document that the `dock` window level is deprecated
 2016-12-12 09:39:08 -08:00
Kevin Sawicki
1a0fbf84f9 Merge pull request #8165 from geoff-addepar/geoff/fix-sandbox-printing 
Fix printing with the sandbox enabled
 2016-12-12 09:26:52 -08:00
deepak1556
4085ba309a fix spec 2016-12-09 09:56:16 -08:00
deepak1556
21be9a3309 add spec 2016-12-09 09:55:55 -08:00
Kevin Sawicki
d705f4cbac Fix issue where actual/expected was same variable 2016-12-09 09:37:46 -08:00
deepak1556
5d94221c61 fix code style 2016-12-09 09:37:46 -08:00
deepak1556
f124732431 add spec 2016-12-09 09:37:46 -08:00
Sindre Sorhus
3dde669ee8 🍎 Remove deprecated dock window level 
According to the Apple docs, the `NSDockWindowLevel` constant is deprecated: https://developer.apple.com/reference/appkit/nsdockwindowlevel?language=objc
 2016-12-09 12:46:49 +01:00
Geoff Lywood
5345b08d24 Fix printing with the sandbox enabled 
Closes #7984
 2016-12-07 17:40:18 -08:00
deepak1556
2b8b76a527 protocol: support custom session with interceptHttpProtocol 2016-12-07 16:22:34 +05:30
deepak1556
cbddbdb296 fix code style 2016-12-07 15:33:56 +05:30
deepak1556
1c45285fe3 add spec 2016-12-07 13:26:06 +05:30
Kevin Sawicki
63bffbc460 Don't show window 2016-12-06 13:25:46 -08:00
Kevin Sawicki
03263bb5b6 Add failing BrowserWindow.fromDevToolsWebContents spec 2016-12-06 10:36:59 -08:00
Kevin Sawicki
b0a1e2988b Add spec for BrowserWindow.fromWebContents 2016-12-06 10:36:59 -08:00
Kevin Sawicki
b29f7b9acb Clear interval before assert 2016-12-06 09:25:55 -08:00
Kevin Sawicki
c2f516067f Add missing r in variable name 2016-12-06 09:22:29 -08:00
Kevin Sawicki
58cae1d8de Clear interval before destroying window 2016-12-06 09:22:08 -08:00
deepak1556
e043dabcb8 add spec 2016-12-04 00:22:57 +05:30
Kevin Sawicki
c1a02d6556 Add spec for render-view-deleted issue 2016-12-02 10:42:09 -08:00
Kevin Sawicki
b61e1fd69f Add spec for error on removing all IPC listeners 2016-12-01 14:56:00 -08:00
Kevin Sawicki
36371357cd buttonLabel -> Button label for consistency 2016-12-01 14:16:33 -08:00
Kevin Sawicki
750bd9a88b Add initial dialog specs 2016-12-01 14:15:34 -08:00
Kevin Sawicki
eaa5d071ef Remove unneeded timeout call 2016-11-29 16:27:18 -08:00
Kevin Sawicki
d86f0a1686 Add missing call to done 2016-11-29 14:52:47 -08:00
Kevin Sawicki
f0566f3790 isCi -> isCI 2016-11-29 14:48:28 -08:00
Kevin Sawicki
f5f790863d Use 1 or 2 minute timeout for long specs 2016-11-29 14:31:57 -08:00
Kevin Sawicki
10386edea5 Default timeout to 30 seconds on CI and 10 seconds locally 2016-11-29 14:29:35 -08:00
Kevin Sawicki
4ccc3d9fb3 Remove unneeded return 2016-11-29 14:19:20 -08:00
Kevin Sawicki
77fa7ce977 Run more crashReporter specs on CI 2016-11-29 14:18:42 -08:00
Kevin Sawicki
2c8ab72269 Merge pull request #8084 from poiru/systempreferences-setuserdefault 
Add systemPreferences.setUserDefault for macOS
 2016-11-29 14:07:35 -08:00
Kevin Sawicki
df179ed28d Merge pull request #8092 from poiru/setcursorautohide 
Add BrowserWindow.setCursorAutoHide
 2016-11-29 13:36:58 -08:00
Kevin Sawicki
cc2936cfdf closeWindow in an afterEach block 2016-11-29 12:30:40 -08:00
Kevin Sawicki
d20e664ea8 Close window in an afterEach 2016-11-29 12:13:33 -08:00
Kevin Sawicki
fee7683b86 Reuse window variable and only close from root afterEach 2016-11-29 11:52:31 -08:00
Kevin Sawicki
d7e7c2b17f Assert single window from closeWindow helper 2016-11-29 11:29:20 -08:00
Kevin Sawicki
1afa41477d Don't use this.skip() since after hooks won't be run 2016-11-29 10:56:58 -08:00
Kevin Sawicki
217848ca52 Assert windows are not leaking across tests 2016-11-29 10:56:17 -08:00
Birunthan Mohanathas
486b6b9096 Add systemPreferences.setUserDefault for macOS 
This API can be used to e.g. enable key repeat by setting
`ApplePressAndHoldEnabled` to `false` (see also #47).
 2016-11-29 09:46:32 -08:00
Birunthan Mohanathas
18c49285a8 Add BrowserWindow.setAutoHideCursor for macOS 
The `disableAutoHideCursor` BrowserWindow option can be used to control
auto-hiding behavior when the window is created. This new API is needed
to dynamically change the behavior after the fact.
 2016-11-29 09:46:00 -08:00
Kevin Sawicki
1c6e166af5 Value should be true on non-macOS platforms 2016-11-28 15:08:28 -08:00
Kevin Sawicki
f4be3782a2 Add spec for get/setUploadToServer 2016-11-28 15:08:28 -08:00
Kevin Sawicki
774b2f99f2 Merge pull request #8038 from electron/danhp/close-file-preview 
Add 'win.closeFilePreview()'
 2016-11-28 14:47:06 -08:00
Kevin Sawicki
a7395118af Merge pull request #7952 from the-ress/window-setappid 
Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command
 2016-11-28 14:46:14 -08:00
Kevin Sawicki
3897a88082 Use skip for setAppDetails spec 2016-11-28 14:43:18 -08:00
Kevin Sawicki
0a61aad499 Add initial previewFile/closeFilePreview test 2016-11-28 14:32:15 -08:00
Kevin Sawicki
145e40c2f6 Add more origin comparison specs 2016-11-28 10:56:23 -08:00
Kevin Sawicki
41dea03007 window.opener location should be webview src URL 2016-11-28 10:56:23 -08:00
Kevin Sawicki
0799317ff5 Add failing specs window.opener from <webview> opened window 2016-11-23 12:01:09 -08:00
Kevin Sawicki
e356168c9a Merge pull request #8047 from electron/fix-incorrect-window-size 
Fix incorrect window size after restore on Windows
 2016-11-22 14:01:50 -08:00
Kevin Sawicki
6f29d7211e Move restore/unmaximize specs near state ones 2016-11-22 13:32:39 -08:00
Kevin Sawicki
63eec70350 Assert bounds when restoring 2016-11-22 13:22:30 -08:00
Kevin Sawicki
c0d9175bc3 Try specs without setTimeout calls 2016-11-22 13:14:17 -08:00
Kevin Sawicki
89965aa5db Check runner.hasOnly for focused spec check 2016-11-22 13:06:18 -08:00
Kevin Sawicki
238beb72ee Remove .only call 2016-11-22 11:41:02 -08:00
Kevin Sawicki
a7aed98d59 Add initial spec for zoom level limits 2016-11-22 08:43:14 -08:00
Samuel Attard
97b4f12112
Fix linting issues 2016-11-22 16:13:08 +11:00
Samuel Attard
926cabec78
Add spec for maximize restore positioning 2016-11-22 16:07:19 +11:00
Samuel Attard
67f33cdb60
Add failing spec for window size after restore 2016-11-22 15:49:47 +11:00
Kevin Sawicki
cbffd598f9 Add failing spec for unknown user defaults 2016-11-21 09:22:30 -08:00
Kevin Sawicki
d4ba5b4638 Add spec for zoomToPageWidth 2016-11-21 08:45:46 -08:00
Tereza Tomcova
782417b1fa Added tests for BrowserWindow.setAppDetails 2016-11-18 21:34:01 +01:00
Kevin Sawicki
aa2824621a Make scheme const 2016-11-16 08:03:07 -08:00
Kevin Sawicki
04c68745db Always call done callback in before block 2016-11-16 07:50:30 -08:00
Cheng Zhao
81f2e76e36 Fix standard linting errors 2016-11-16 07:50:30 -08:00
Cheng Zhao
a1dfdbdde4 spec: Should check origin before accessing window.opener 2016-11-16 07:50:30 -08:00
Kevin Sawicki
fc1ce3eeab Assert certs further up the chain 2016-11-15 16:32:12 -08:00
Kevin Sawicki
095d711848 Remove select-client-certificate issueCert assert 2016-11-15 16:24:50 -08:00
Kevin Sawicki
a1dca8afc9 🎨 Remove buildup asserts and just use assert.equal 2016-11-15 15:53:42 -08:00
Greg Nolle
86321a2c60 Fixed incorrect subject name of test client certificate. 2016-11-15 15:53:42 -08:00
Greg Nolle
2e5c92d41e Fix listing issues: remove semicolons. 2016-11-15 15:53:42 -08:00
Greg Nolle
93ce2f7800 Add assertions for new fields in existing specs. 2016-11-15 15:53:42 -08:00
Kevin Sawicki
9e51c779e1 Assert expected height 2016-11-15 13:54:25 -08:00
Birunthan Mohanathas
2986b7bc4a Allow webview guests to be resized manually 
This adds the `disableguestresize` property for webviews to prevent the
webview guest from reacting to size changes of the webview element. This
also partially documents the `webContents.setSize` function in order to
manually control the webview guest size.

These two features can be combined to improve resize performance for
e.g. webviews that span the entire window. This greatly reduces the lag
described in #6905.
 2016-11-15 11:00:09 -08:00
Kevin Sawicki
eeffa42513 Merge pull request #7923 from jhen0409/patch-1 
Add support remove / clear for chrome.storage
 2016-11-15 09:04:45 -08:00
Jhen
8b30439d7f Update devtools extension spec for chrome.storage 2016-11-15 19:58:08 +08:00
deepak1556
4deb7c6fa7 fix lint error 2016-11-12 07:16:48 +05:30
Kevin Sawicki
134f8afbe6 Add specs for content type on POST forms 2016-11-11 10:54:01 -08:00
Kevin Sawicki
50019f39e9 🎨 2016-11-11 10:54:01 -08:00
Kevin Sawicki
cbb68f6980 Remove quotes around key 2016-11-11 10:54:01 -08:00
deepak1556
61576c39be uploadData => uploadRawData 2016-11-11 10:54:01 -08:00
deepak1556
ad5f944185 add spec 2016-11-11 10:53:36 -08:00
gellert
5e62d28e50 adds test, adds view to AtomNSWindow and minor fixes 2016-11-11 08:49:57 -08:00
deepak1556
3aab713d24 add failing spec 2016-11-09 11:00:50 +05:30
Kevin Sawicki
18e1de105f Add failing spec for deleted guestinstance when moving webview 2016-11-07 13:42:36 -08:00
Kevin Sawicki
b84fed5cb2 Add failing spec for hide/show reload issue 2016-11-07 13:42:36 -08:00
Kevin Sawicki
f454cb3408 Add failing spec for hide/show webview issue 2016-11-07 13:42:36 -08:00
Kevin Sawicki
73774f21b7 🎨 2016-11-07 08:28:02 -08:00
Kevin Sawicki
19a5d2ba2b Use window close helper instead of destroying for coverage 2016-11-07 08:25:01 -08:00
Kevin Sawicki
16f57b219b Add resize event spec 2016-11-07 08:25:01 -08:00
Samuel Attard
9f18a6e65c Use ES6 template strings, fix docs and remove _ERROR_ IPC event 2016-11-03 09:33:47 -07:00
Samuel Attard
857e1da6a3 Make executeJavaScript return a Promise so that caught errors can be sent to the caller 2016-11-03 09:33:47 -07:00
Samuel Attard
75b010ce63 Add sync executeJavaScript test 2016-11-03 09:33:47 -07:00
Kevin Sawicki
038718717c Add initial ready-to-show spec 2016-10-31 12:40:49 -07:00
Kevin Sawicki
3f8e173452 Call callback asynchronously to match original issue 2016-10-31 08:54:57 -07:00
Kevin Sawicki
611614c649 Use equal/deepEqual for channel/args asserts 2016-10-31 08:54:57 -07:00
Kevin Sawicki
dda3fcef91 Add failing spec for notification permission crash 2016-10-31 08:54:56 -07:00
Cheng Zhao
dfefa00a50 Merge pull request #7577 from thomsonreuters/net_module 
net module
 2016-10-31 10:31:56 +09:00
ali.ibrahim
e9db926b48 Fixing code review issues: fixing linter issues in spec file. 2016-10-25 16:55:17 +02:00
ali.ibrahim
bdb3f4d4cb Fixing code review issues: adding some test cases for partition/session options. 2016-10-25 16:19:26 +02:00
ali.ibrahim
b44d5290e2 Fixing code review issues: adding a partition options and making the session option only takes Session objects. 2016-10-25 15:47:54 +02:00
ali.ibrahim
61278f9ace Fixing code review issues. 2016-10-25 12:41:01 +02:00
Kevin Sawicki
1c3b5835f4 Add spec for read/write find text 2016-10-25 14:15:54 +09:00
Kevin Sawicki
39a5c7dab9 Merge pull request #7631 from beakerbrowser/webview-policy-flags2 
Add 'webpreferences' attribute to webview
 2016-10-25 12:14:25 +09:00
Kevin Sawicki
31b4f61815 Merge pull request #7651 from deepak1556/session_cert_verifier_patch 
session: exclude hosts from CT verification if they are handled by custom cert verifiers
 2016-10-24 16:53:04 +09:00
Kevin Sawicki
271733fc53 Add tests for ses.setCertificateVerifyProc 2016-10-24 16:12:49 +09:00
Paul Frazee
a5c62bb264 add options to webFrame.registerURLSchemeAsPrivileged 2016-10-18 15:52:41 -05:00
ali.ibrahim
43113fcfb4 Fixing net response objects being piped into writable streams test. 2016-10-18 10:28:35 +02:00
ali.ibrahim
c198828e58 Adding gc tests: fixing a memory leak with C++ URLRequest objects. 2016-10-17 19:02:25 +02:00
Cheng Zhao
ce847fc3ca Merge pull request #7578 from electron/windows-logging 
Show console output from Windows when ELECTRON_RUN_AS_NODE is set
 2016-10-17 20:22:39 +08:00
ali.ibrahim
9b4e9c642a Making test code run directly in main browser context to avoid rpc persistent handles. 2016-10-17 11:51:20 +02:00
ali.ibrahim
c6ae27c7c9 Adding a stability test: non referenced, unused requests are collected without crash. 2016-10-17 10:38:10 +02:00
Paul Frazee
e7962c7ba2 fixes and tests for webview 'webpreferences' attr 2016-10-14 18:04:33 -05:00
ali.ibrahim
6f5b0a28c5 Fixing code review issues: function call formatting, renaming JS member variables, refactoring response headers conversion. 2016-10-13 17:14:23 +02:00
Samuel Attard
eac5ba4c56 Fix spec linting issues 2016-10-13 12:47:43 +11:00
Kevin Sawicki
e899050500 Add basic test of spawned ELECTRON_RUN_AS_NODE process 2016-10-12 13:48:49 -07:00
Kevin Sawicki
fefc7c23f9 Merge pull request #7479 from bpasero/process-no-asar 
Introduce ELECTRON_NO_ASAR
 2016-10-12 13:48:03 -07:00
Kevin Sawicki
f553d16539 Only support ELECTRON_NO_ASAR in non browser/renderer processes 2016-10-12 11:11:27 -07:00
Kevin Sawicki
8897a7a926 Add specs for ELECTRON_NO_ASAR env var 2016-10-12 11:11:27 -07:00
ali.ibrahim
16069cd477 Commenting some test code. 2016-10-12 17:13:06 +02:00
ali.ibrahim
ae1c33b863 fixing linter issues. 2016-10-12 14:54:32 +02:00
ali.ibrahim
d21def7b8d Fixing various issues in tests. 2016-10-12 14:54:32 +02:00
ali.ibrahim
bd5e622bec Adding request/response piping tests. 2016-10-12 14:54:31 +02:00
ali.ibrahim
a5c508d2d7 Adding abort, webRequest interception and creation tests. 2016-10-12 14:54:31 +02:00
ali.ibrahim
b731ca50bc Adding HTTP request headers manipulation tests. 2016-10-12 14:54:30 +02:00
ali.ibrahim
4eb9fc1bb6 Adding chunked uploading test. 2016-10-12 14:54:29 +02:00
ali.ibrahim
9b94dfcbdc Adding basic http tests, fixing issues in ClientRequest constructor. 2016-10-12 14:54:29 +02:00
ali.ibrahim
b57ffbf1ab Temporary fix for the post data test. 2016-10-12 14:54:28 +02:00
ali.ibrahim
dcffb51e5e Adding net module spec file skeleton. 2016-10-12 14:54:26 +02:00
Cheng Zhao
46cd8708a4 Merge pull request #7561 from electron/windows-system-colors 
Support retrieving Windows system colors
 2016-10-12 15:35:18 +09:00
Zeke Sikelianos
c46c1dbb1e Merge pull request #7505 from electron/testing-docs 
Update test dependencies and documentation
 2016-10-11 22:28:16 -07:00
Zeke Sikelianos
d4a8a64ba7 Merge pull request #7498 from electron/custom-props-in-menu-item-constructor 
Preserve custom properties passed to MenuItem constructor
 2016-10-11 14:24:13 -07:00
Zeke Sikelianos
af0098f064 remove badge count after each setBadgeCount test 2016-10-11 14:22:48 -07:00
Zeke Sikelianos
156d823b7f remove badge after setBadgeCount test finishes 2016-10-11 14:22:48 -07:00
Zeke Sikelianos
45d9cc6405 update test dependencies 2016-10-11 14:22:48 -07:00
Kevin Sawicki
e7bfd1c959 Add systemPreferences.getColor specs 2016-10-11 13:15:26 -07:00
Cheng Zhao
0baa60caab Merge pull request #7528 from electron/key-and-code-on-sent-input-events 
Set key and code on sendInputEvent keyboard events
 2016-10-11 19:34:05 +09:00
Zeke Sikelianos
bcce7aff18 test that overrideProperty is not overwritten 2016-10-10 15:25:56 -07:00
Kevin Sawicki
7b49d94e9f Add systemPreferences.isInvertedColorScheme API 2016-10-10 10:43:08 -07:00
Kevin Sawicki
987579d391 Send initial keyDown before char event 2016-10-10 09:35:44 -07:00
Kevin Sawicki
99414065a9 Add char/keypress event tests 2016-10-10 09:35:44 -07:00
Kevin Sawicki
e4b0577cb0 Assert key and code in keyup input event spec 2016-10-10 09:35:44 -07:00
Kevin Sawicki
424afd3faf Update expected key and code values 2016-10-10 09:35:43 -07:00
Kevin Sawicki
d69367aa9b Add keydown sendInputEvent specs 2016-10-10 09:35:43 -07:00
Cheng Zhao
91591f37e6 Merge pull request #7500 from electron/store-crashes-in-configured-temp-dir 
Store crash reports in configured temp dir
 2016-10-10 10:19:02 +09:00
Samuel Attard
a0284a9bc5
Add spec for window.open with webPreferences set to null 2016-10-07 12:13:04 +11:00
Zeke Sikelianos
b7e078e98d sanitize MenuItem options 2016-10-06 14:37:13 -07:00
Kevin Sawicki
fbbffe03a5 Add getPath specs 2016-10-06 09:57:25 -07:00
Kevin Sawicki
4a8dcec63a Wait for crash report to become available 2016-10-06 09:47:07 -07:00
Kevin Sawicki
0380d3ae50 Pass crashes directory to crash service process 2016-10-06 09:02:02 -07:00
Kevin Sawicki
2fbb98a97c Remove directory assert 2016-10-06 09:02:02 -07:00
Kevin Sawicki
56d9ce34e4 Use valid Linux report id 2016-10-06 09:02:02 -07:00
Kevin Sawicki
b3b856f476 Set productName in main process on Linux 2016-10-06 09:02:02 -07:00
Kevin Sawicki
773bfea386 Remove unused rimraf spec dependency 2016-10-06 09:02:01 -07:00
Kevin Sawicki
1afe501a36 Add tests for crash reports in custom temp directory 2016-10-06 09:02:01 -07:00
Kevin Sawicki
f282b51c98 🎨 Use ES6 class, destructuring, and let/const 2016-10-06 09:02:01 -07:00
Cheng Zhao
10b91b1291 Merge pull request #7488 from electron/native-image-resize-and-crop 
Support resizing and cropping native images
 2016-10-06 15:01:41 +09:00
Zeke Sikelianos
fdf3f6ce30 remove unneeded new keyword 2016-10-05 13:44:28 -07:00
Zeke Sikelianos
16b3962b66 preserve custom properties passed to MenuItem constructor 2016-10-05 12:24:08 -07:00
Kevin Sawicki
4ffae1d563 Add spec for getAspectRatio 2016-10-05 11:02:58 -07:00
Kevin Sawicki
abffd98e29 Resize images with preserve aspect ratio 2016-10-05 11:02:58 -07:00
Kevin Sawicki
49cc00dedf Add tests of resizing/cropping an empty image 2016-10-05 11:02:57 -07:00
Kevin Sawicki
0eda33f057 Add tests for cropping native images 2016-10-05 11:02:57 -07:00
Kevin Sawicki
a80f4c1605 Add specs for other create image helpers 2016-10-05 11:02:57 -07:00
Kevin Sawicki
6aba4e916a 🎨 Use deepEqual asserts 2016-10-05 11:02:57 -07:00
Kevin Sawicki
6a7f0d70fd Add native image resize tests 2016-10-05 11:02:56 -07:00
Michael Vasseur
edd80d88a9 Update BrowserWindow's test to check additional features upon window.open() call 2016-10-05 13:45:15 +02:00
Kevin Sawicki
3f390c6849 Ensure webviews get reset after spec finishes 2016-09-30 10:15:11 -07:00
Kevin Sawicki
d942694695 openedWindow -> popupWindow 2016-09-30 08:54:24 -07:00
Kevin Sawicki
766f5afabd Explicitly close popup window 2016-09-30 08:50:41 -07:00
Kevin Sawicki
e16fa08e61 🎨 2016-09-30 08:38:21 -07:00
Kevin Sawicki
77b35ba7ab Use separate session for cookies change event test 2016-09-29 09:16:35 -07:00
Kevin Sawicki
d83534d513 Add specs for cookie changed event 2016-09-29 09:16:35 -07:00
Kevin Sawicki
3bed19d70d Add spec for BrowserWindow.setAlwaysOnTop 2016-09-28 09:23:52 -07:00
Cheng Zhao
458c4dd129 Merge branch 'support-chromium-sandbox' of https://github.com/tarruda/electron into tarruda-support-chromium-sandbox 2016-09-27 20:02:23 +08:00
Cheng Zhao
4c8d0ab804 Merge pull request #7298 from deepak1556/content_settings_patch 
protocol: disable storage for non standard custom schemes
 2016-09-27 18:52:36 +08:00
Thiago de Arruda
47fd41715f Add some tests for "sandbox" option 2016-09-27 06:01:47 -03:00
deepak1556
7ba947aee9 add spec 2016-09-22 00:15:25 +05:30
Kevin Sawicki
f8236c1a65 Add more failure asserts for nativeImage.createFromPath 2016-09-21 10:48:24 -07:00
Cheng Zhao
e3e450613d Merge pull request #7157 from Mossop/moveguest 
Allow moving a webcontents to a different webview
 2016-09-20 14:28:42 +09:00
Samuel Attard
ba98109d33
Remove semicolons from spec 2016-09-20 02:41:26 +10:00
Samuel Attard
9f94652792
Add basic spec for getAccentColor 2016-09-20 02:41:26 +10:00
Cheng Zhao
e504d82554 spec: Suppress the download.pdf test on AppVeyor 2016-09-19 17:12:33 +09:00
Cheng Zhao
0ac4b89a0a Merge pull request #7236 from yuya-oc/accelerator-for-redo 
Use Ctrl+Y as the accelerator of redo on Windows
 2016-09-19 15:53:44 +09:00
Yuya Ochiai
43f955194e 🏁 Use Ctrl+Y as the accelerator of redo on Windows 2016-09-18 17:07:34 +09:00
Dave Townsend
47df447e4f ✅ Test that replacement history entries don't break forward navigation. 
This is a test for #7175
 2016-09-16 17:08:54 -07:00
Cheng Zhao
9dad9478fa Merge pull request #7169 from deepak1556/download_defaultname_patch 
browser: provide a default filename when unable to generate from download data
 2016-09-16 21:19:21 +09:00
Cheng Zhao
ea244a5188 Merge pull request #7209 from electron/remote-function-missing-properties 
Guard against missing remote function properties
 2016-09-16 21:11:12 +09:00
deepak1556
d426d4ad90 add failing spec 2016-09-16 16:02:57 +05:30
Cheng Zhao
9714348260 Merge pull request #6941 from deepak1556/blob_data_patch 
protocol: provide blob uuid with uploadData
 2016-09-16 17:01:15 +09:00
Kevin Sawicki
eef42770c6 Don't load remote properties until they are accessed 2016-09-14 13:29:49 -07:00
Kevin Sawicki
f792c720f4 Allow spec to be run multiple times in same runner 2016-09-14 11:16:44 -07:00
Kevin Sawicki
bc13536208 Add failing spec for missing remote properties 2016-09-14 10:53:25 -07:00
Cheng Zhao
fbac635687 Only emit finalUpdate found-in-page events 
Since Chrome 53 all meaningful results of found-in-page are finalUpdate.
 2016-09-14 16:23:01 +09:00
Cheng Zhao
f8bdc7437d module search paths have changed 2016-09-14 16:23:01 +09:00
Cheng Zhao
18fd3e0329 Fix js linting error 2016-09-14 16:23:00 +09:00
Cheng Zhao
a510642a25 finalUpdate can be false 2016-09-14 16:23:00 +09:00
Cheng Zhao
30dd65e3a9 Fix failing spec when refreshing test window 2016-09-14 16:23:00 +09:00
Cheng Zhao
5708e86a05 Fix API change of findInPage API 2016-09-14 16:23:00 +09:00
Dave Townsend
313b2faa3c Add a guestinstance attribute to webviews reflecting their current guest 
instance ID and allowing moving a guest instance to a new webview.
 2016-09-09 10:32:05 -07:00
Phil Haack
cadbd7beb1 Merge pull request #7145 from electron/device-scale-factor-failures 
Get specs passing on displays using certain device scale factors
 2016-09-09 07:38:23 -07:00
Cheng Zhao
e189132176 Merge pull request #7123 from deepak1556/asar_range_patch 
protocol: respect range header when reading from asar
 2016-09-09 20:59:12 +09:00
Cheng Zhao
693ba1375b Merge pull request #7146 from electron/resolve-empty-url-values 
Tweak how empty URLs are resolved
 2016-09-09 19:58:41 +09:00
Cheng Zhao
932b6dc0cf Merge pull request #7142 from electron/require-buffer 
Require Buffer explicitly instead of relying on global
 2016-09-09 19:52:53 +09:00
Kevin Sawicki
64d436682c Verify resolving URL via console-message event 2016-09-08 17:38:40 -07:00
Kevin Sawicki
7c26fe46b8 === -> !== 2016-09-08 17:12:53 -07:00
Kevin Sawicki
7d24df34fc Place resolve specs in correct outer block 2016-09-08 17:08:49 -07:00
Kevin Sawicki
bfd48fe2ad Add specs for resolving attribute URLs 2016-09-08 16:56:29 -07:00
Kevin Sawicki
1dbaf4987e Don't resolve empty src/preload attribute values 2016-09-08 16:48:30 -07:00
Kevin Sawicki
ea069805d1 Add failing specs for empty preload/src attribute 2016-09-08 16:40:31 -07:00
Kevin Sawicki
68c67b64c5 Use delta when scale factor is above 2 and odd 2016-09-08 16:24:11 -07:00
Kevin Sawicki
59a49f6f96 Use bounds helper in failing specs 2016-09-08 16:20:46 -07:00
Kevin Sawicki
7494e286d9 Put actual value first 2016-09-08 16:20:45 -07:00
Kevin Sawicki
d88f70caa2 Use single assert bounds helper 2016-09-08 16:20:45 -07:00
Kevin Sawicki
71fac07a93 Add scale factor assert helpers 2016-09-08 16:20:45 -07:00
Kevin Sawicki
9829baed46 Open about:blank when window.open is called with no URL 2016-09-08 16:10:21 -07:00
Kevin Sawicki
e4e4e8b2eb Add missing {} 2016-09-08 13:12:00 -07:00
Kevin Sawicki
d407eab0ff Set crashReporter productName in specs 2016-09-08 11:52:29 -07:00
Kevin Sawicki
63e9bc4804 Assert isTTY is undefined on Windows 2016-09-08 11:52:29 -07:00
Kevin Sawicki
aaf2bb2751 Add spec for deleting Buffer global in preload 2016-09-08 10:34:09 -07:00
deepak1556
c003c3e28f increase spec timeout 2016-09-08 11:38:24 +05:30
deepak1556
1ae7b2fcbc update 2016-09-08 10:12:23 +05:30
deepak1556
7e6cba1482 add failing spec 2016-09-08 09:37:06 +05:30
Kevin Sawicki
d76c970da6 Assert read value instead of exception 2016-09-07 14:51:05 -07:00
Kevin Sawicki
b5e9bb9e6a Add spec for accessing process.stdin 2016-09-07 14:40:18 -07:00
Kevin Sawicki
b186d752da Add failing spec for restoring noAsar value 2016-09-06 13:40:15 -07:00
deepak1556
7b85ca0301 create helper class to read blob data 2016-09-01 08:52:44 +05:30
deepak1556
be4bc6b7ef fix docs and update specs 2016-09-01 01:01:52 +05:30
Cheng Zhao
4833c4800e Merge pull request #6998 from electron/ipc-v8-converter-crash 
Don't serialize external values over IPC
 2016-08-31 20:45:25 +09:00
Cheng Zhao
f854b27bfb Merge pull request #6867 from electron/remote-function-properties 
Allow accessing remote function properties
 2016-08-31 17:28:09 +09:00
Kevin Sawicki
3e7a0e4b43 Test external value as send argument 2016-08-30 09:27:12 -07:00
Kevin Sawicki
679ee95e8a Explicitly mention external objects 2016-08-29 10:38:17 -07:00
Kevin Sawicki
625bfe53f7 🎨 2016-08-29 10:38:17 -07:00
Kevin Sawicki
558ee08be9 Add explicit test for IPC cycle detection 2016-08-29 10:38:16 -07:00
Kevin Sawicki
434e7cb5e9 Add test for sending webContents instance over IPC 2016-08-29 10:38:16 -07:00
Kevin Sawicki
0f7e43aa47 Re-enable DOM object over IPC asserts 2016-08-29 10:38:16 -07:00
Kevin Sawicki
b17a2874f8 Add empty request error handler 2016-08-29 10:38:16 -07:00
Kevin Sawicki
e38bc17a7b Add regression spec for HTTP request over IPC 2016-08-29 10:38:16 -07:00
Kevin Sawicki
3f4af3a2ba Convert specs to expect empty objects 2016-08-29 10:38:16 -07:00
Cheng Zhao
cd469b5f31 Merge pull request #6983 from electron/download-item-prompt 
Check DownloadItem save path before prompting
 2016-08-26 20:41:03 +09:00
Kevin Sawicki
3108b8aacd Use path to non-existent file 2016-08-25 14:40:15 -07:00
Kevin Sawicki
1de8a0dcf9 Add failing spec for unwanted save dialog 2016-08-25 14:27:37 -07:00
Kevin Sawicki
10d39f673a Add failing spec for duplicate references over IPC 2016-08-25 09:25:13 -07:00
Cheng Zhao
97a004a357 Merge pull request #6963 from electron/remote-buffers 
Serialize ArrayBuffers as Buffers instead of Arrays over remote
 2016-08-25 17:29:12 +09:00
Cheng Zhao
764c84f569 Merge pull request #6952 from deepak1556/custom_scheme_filesystem_patch 
protocol: allow standard schemes to support filesystem api
 2016-08-25 09:28:34 +09:00
Kevin Sawicki
b688539fe9 🎨 Use const 2016-08-24 17:00:03 -07:00
Kevin Sawicki
e1cf61f0cb Add spec for Int16Array remote parameter 2016-08-24 16:47:14 -07:00
Kevin Sawicki
a1a7b1779c Add missing space after comma 2016-08-24 16:41:59 -07:00
Kevin Sawicki
363a02b82d Add more remote Buffer specs 2016-08-24 15:01:52 -07:00
Kevin Sawicki
554e944105 Add test of sending Buffer 2016-08-24 14:49:25 -07:00
Kevin Sawicki
4ce2c221c9 Minor doc edits and link to MDN page 2016-08-24 09:03:44 -07:00
deepak1556
ae297760af add spec and docs 2016-08-24 06:53:14 +05:30
Kevin Sawicki
399470e281 Add spec for detached window crash 2016-08-23 10:06:05 -07:00
Kevin Sawicki
ec44a5d198 Add tests for setting remote function properties 2016-08-22 17:07:18 -07:00
Kevin Sawicki
666a668d91 Support remote function keys and property descriptors 2016-08-22 17:07:18 -07:00
Kevin Sawicki
d226b7bc6c Use Proxy for accessing properties of remote function 2016-08-22 17:07:18 -07:00
Kevin Sawicki
600076b46d Remove lint from fixtures 2016-08-22 17:07:17 -07:00
Kevin Sawicki
d333cc5e38 Support remote function properties 2016-08-22 17:07:17 -07:00
Kevin Sawicki
9e4665fbc4 Add failing spec for remote static members 2016-08-22 17:07:17 -07:00
Kevin Sawicki
5cc61089d9 Add failing spec for remote function with properties 2016-08-22 17:07:17 -07:00
Cheng Zhao
103fea5cdf Use scoped policy for micro tasks 2016-08-22 19:34:59 +09:00
Cheng Zhao
9bc6302aea spec: Add test case for fetch 2016-08-22 19:26:07 +09:00
Mark Wylde
c55b1e87ed Fix spelling mistake from registred to registered 2016-08-20 14:25:13 +01:00
Kevin Sawicki
dfb6a9b07d Show window when not on CI 2016-08-17 14:25:42 -07:00
Cheng Zhao
79f35fa475 Merge pull request #6850 from electron/disable-resize-when-changing-style-mask 
Disable all resizes when changing the window's style mask
 2016-08-17 21:19:35 +09:00
Cheng Zhao
4e355355a9 Merge pull request #6851 from electron/focused-web-contents-from-hidden-windows 
Prevent web contents in hidden windows from reporting as focused
 2016-08-17 20:15:37 +09:00
Kevin Sawicki
6cca62788d Assert first and last web contents types 2016-08-16 16:19:32 -07:00
Kevin Sawicki
1f46574efe Add test for header with . characters 2016-08-16 09:08:36 -07:00
Kevin Sawicki
cc7fe82b74 Add failing webContents.isFocused spec 2016-08-15 14:11:08 -07:00
Kevin Sawicki
c754b5efdc Add failing spec for state changes resizing frameless window 2016-08-15 12:30:26 -07:00
deepak1556
77173be1c6 webFrame: enable privileged schemes to send CORS requests 2016-08-11 23:01:10 +05:30
Kevin Sawicki
b017d2d324 Disable globalShortcut spec on Windows CI 2016-08-10 08:52:50 -07:00
Kevin Sawicki
2a0eb72334 Add asserts for crash report APIs 2016-08-09 15:44:04 -07:00
Kevin Sawicki
ce0165367c Add spec for invalid capture options 2016-08-09 15:31:24 -07:00
Kevin Sawicki
a6353eb98f Add initial global shortcut spec 2016-08-09 15:13:05 -07:00
Kevin Sawicki
39e1541a7e Add initial power save blocker spec 2016-08-09 15:05:56 -07:00
Cheng Zhao
81244c2221 Merge pull request #6768 from electron/felix-set-progress 
Enable mode indication for setProgressBar
 2016-08-09 20:58:07 +09:00
Cheng Zhao
01f92a83ab Merge pull request #6780 from electron/update-available-check 
Mark update available until restart
 2016-08-09 20:44:26 +09:00
Felix Rieseberg
73c91dae9e 🔧 Enable mode indication for setProgressBar 
This commit enables setting a mode for the setProgressBar method.
Old behavior is kept intact, usage is entirely optional.
 2016-08-08 15:52:20 -07:00
Kevin Sawicki
0747957919 Add spec for quitAndInstall with no update on Windows 2016-08-08 13:13:08 -07:00
Kevin Sawicki
e767d3c131 Add spec for executeJavaScript DOM class prototype 2016-08-08 09:42:43 -07:00
Kevin Sawicki
8b3aa4dbb4 Add spec for sending document.location over IPC 2016-08-08 09:35:30 -07:00
Cheng Zhao
3be68ba136 Merge pull request #6736 from electron/maximizable-state 
Always restore maximizable state after changing window behavior/style
 2016-08-05 17:25:22 +09:00
Cheng Zhao
8a33464d41 Merge pull request #6654 from electron/content-bounds 
Add BrowserWindow.get/setContentBounds()
 2016-08-05 17:23:24 +09:00
Kevin Sawicki
23203daf95 Non-resizable windows should only maximizable on Mac 2016-08-04 17:22:09 -07:00
Kevin Sawicki
41a0a3fff2 Add failing spec 2016-08-04 16:46:40 -07:00
Kevin Sawicki
2a20630f2f Use same position as setPosition test 2016-08-04 13:02:41 -07:00
Kevin Sawicki
3a0ceb40b9 Assert new content bounds after resize event 2016-08-04 12:54:45 -07:00
Kevin Sawicki
3041fcc79e Add spec for BrowserWindow.setContentBounds 2016-08-04 12:34:09 -07:00
Kevin Sawicki
79eee0fdf1 Assert after size through getContentBounds() API 2016-08-04 09:58:35 -07:00
deepak1556
52431506ba protocol: custom standard schemes should support cookies 2016-08-04 11:06:21 +05:30
Kevin Sawicki
a665cf1935 Remove unused spec modules 2016-08-03 16:23:40 -07:00
Kevin Sawicki
ad07a20d9a Use electabul to instrument and report coverage 2016-08-03 16:23:39 -07:00
Kevin Sawicki
2c0de93f06 Use once when calling done callback 2016-08-03 16:23:39 -07:00
Kevin Sawicki
0ebe142b2f Close windows instead of destroying them 2016-08-03 16:23:39 -07:00
Kevin Sawicki
cce6be1900 Only prevent unload the first time it is attempted 2016-08-03 16:23:39 -07:00
Kevin Sawicki
916920844e Use once instead of on 2016-08-03 16:23:39 -07:00
Kevin Sawicki
60e60d86d1 Send coverage from chrome extension iframe 2016-08-03 16:23:39 -07:00
Kevin Sawicki
9aec425ea8 Save dev tools coverage when available 2016-08-03 16:23:39 -07:00
Kevin Sawicki
e034bd05d3 Save type in coverage filename 2016-08-03 16:23:39 -07:00
Kevin Sawicki
88dc281242 Use web contents id when pid is unavailable 2016-08-03 16:23:38 -07:00
Kevin Sawicki
eaa567dd86 Ignore windows with no URLs 2016-08-03 16:23:38 -07:00
Kevin Sawicki
016faacf86 Save coverage on beforeunload event 2016-08-03 16:23:38 -07:00
Kevin Sawicki
300bf24241 Save coverage data when browser windows are destroyed 2016-08-03 16:23:38 -07:00
Kevin Sawicki
9299921ee9 Delete output lib folder before instrumenting 2016-08-03 16:23:38 -07:00
Kevin Sawicki
491f69df80 Add ability to run tests with coverage report 2016-08-03 16:23:38 -07:00
Kevin Sawicki
e17e195479 Add run script to generate instrumented code coverage .asar 2016-08-03 16:23:38 -07:00
Kevin Sawicki
5b5d51ecf4 Add helper to instrument electron.asar 2016-08-03 16:23:38 -07:00
Kevin Sawicki
afdff69482 Add initial code coverage reporting 2016-08-03 16:23:37 -07:00
Cheng Zhao
ea8ea1543f Refactor osr_output_device 2016-08-03 13:06:38 +09:00
Cheng Zhao
c8b544ee1f spec: Remove duplicate code in tests 2016-08-03 10:27:55 +09:00
gellert
439ad94afe Merge remote-tracking branch 'upstream/master' into speedup-gpu 2016-08-01 12:00:34 +02:00
gellert
690ca7ec2a filtering out offscreen webcontents in getAllWebcontents call 2016-07-31 22:06:34 +02:00
gellert
35ee99265e adds tests for osr 2016-07-31 17:10:53 +02:00
Cheng Zhao
e73bd00854 Merge pull request #6629 from electron/download-item-get-save-path 
Set download item save path to selected path from dialog
 2016-07-28 15:23:43 +09:00
Kevin Sawicki
55d6e0de1a Assert save path of download item 2016-07-27 17:52:36 -07:00
Cheng Zhao
ac8a490d56 Fix lint warnings 2016-07-27 19:51:16 +09:00
Cheng Zhao
57dbf284c1 spec: shell.writeShortcutLink/readShortcutLink 2016-07-27 19:43:11 +09:00
Kevin Sawicki
3279f5c80a Add spec for starting crash reporter twice 2016-07-26 10:43:57 -07:00
Cheng Zhao
b139d5ad1c Merge pull request #6598 from electron/fs-access-asar 
Add asar implementation of fs.access/accessSync
 2016-07-26 12:42:59 +09:00
Feross Aboukhadijeh
9bc144c880 Fix test for PR #6600 
Just realized that the tests don't pass after my PR. This fixes that :)
 2016-07-25 17:27:45 -07:00
Kevin Sawicki
b627b8711a Add spec for accessing normal files 2016-07-25 11:17:40 -07:00
Kevin Sawicki
8eca019157 Support paths as Buffers 2016-07-25 11:10:36 -07:00
Kevin Sawicki
30fbe92970 Add asar-supported fs.accessSync implementation 2016-07-25 11:05:18 -07:00
Kevin Sawicki
3ad5504194 Add asar-supported fs.access implementation 2016-07-25 10:50:30 -07:00
Cheng Zhao
7a61966423 Use deepEqual for comparing type arrays 2016-07-25 16:41:20 +09:00
Cheng Zhao
eb51e080e5 spec: TypeArray should work in remote 2016-07-25 16:30:40 +09:00
Cheng Zhao
fd8cc63ca9 Merge pull request #6558 from deepak1556/session_proxy_patch 
session: add proxyBypassRules option to setProxy api
 2016-07-25 16:03:50 +09:00
Cheng Zhao
b57665330c Merge branch 'master' into chrome52 2016-07-21 05:34:36 -06:00
Cheng Zhao
fbfae70803 spec: Fix exception when refreshing test window 2016-07-21 17:08:43 +09:00
deepak1556
aa6d79a3d8 session: add proxyBypassRules option to setProxy api 2016-07-21 10:14:54 +05:30
Cheng Zhao
9eacd07eda Merge pull request #6489 from electron/webcontents-static-api 
Document static methods on webContents
 2016-07-15 11:02:00 +09:00
Samuel Attard
450c181da3 Add autoUpdater getFeedURL specs 2016-07-15 10:13:41 +12:00
Kevin Sawicki
a4001fbc55 Sort contents by id for consistent ordering 2016-07-14 09:41:10 -07:00
Kevin Sawicki
34f454a0f5 Use let and const 2016-07-14 09:33:16 -07:00
Kevin Sawicki
d9e15151fb Use getCurrentWebContents() 2016-07-14 09:25:59 -07:00
Kevin Sawicki
446e3f06c9 Add spec for webContents.getFocusedWebContents() 2016-07-14 09:17:16 -07:00
Kevin Sawicki
ebdf8e1fa1 Add initial webContents spec 2016-07-14 09:10:40 -07:00
Cheng Zhao
749ed3473b spec: Fix js lint warning 2016-07-13 13:34:19 +09:00
Cheng Zhao
fd73279d16 spec: Test lifetime of sessions returned by session.fromPartition 2016-07-13 12:23:14 +09:00
Cheng Zhao
62153f4117 spec: Name of tests should match docs 2016-07-13 12:23:14 +09:00
Cheng Zhao
3ce3004595 spec: session.defaultSession test case 2016-07-13 12:23:14 +09:00
Kevin Sawicki
181b8d799e Add spec for min/max window size 2016-07-12 16:36:25 -07:00
Kevin Sawicki
64513f8c69 Enable login item spec on Windows 2016-07-12 09:10:47 -07:00
Cheng Zhao
df0d2b89cd Merge pull request #6446 from electron/accessibility-api 
Add API for Chrome's accessibility support state
 2016-07-12 10:59:12 +09:00
Kevin Sawicki
4e22d5dd8a Add missing typeof 2016-07-11 14:48:48 -07:00
Kevin Sawicki
67b647322f Add spec to verify app.isAccessibilitySupportEnabled return type 2016-07-11 14:32:24 -07:00
Kevin Sawicki
2d9391f7d7 Add more cycle tests 2016-07-11 10:49:23 -07:00
Kevin Sawicki
bd58e1b2c3 Remove linter errors 2016-07-11 10:33:13 -07:00
Kevin Sawicki
71a8bac12a Add more failing circular reference specs 2016-07-11 10:33:13 -07:00
Kevin Sawicki
ab1786c17d Add spec for circular array/object references 2016-07-11 09:52:50 -07:00
Cheng Zhao
6e81c55880 Merge pull request #6385 from electron/only-use-role-accelerator-in-app-menu 
Only use default role accelerator in app menu
 2016-07-08 11:22:21 +09:00
Cheng Zhao
5713e0599b Merge pull request #6375 from electron/login-item 
Add login item API
 2016-07-08 10:39:20 +09:00
Kevin Sawicki
2633c2f735 Add was prefix to current launch settings 2016-07-07 16:29:58 -07:00
Kevin Sawicki
c100300764 Update API to get/setLoginItemSettings 2016-07-07 16:29:09 -07:00
Kevin Sawicki
791cbc929a Update spec to request defualt accelerator from item 2016-07-07 11:55:59 -07:00
Kevin Sawicki
2e02994277 Add parens about constructor 2016-07-06 15:45:35 -07:00
Kevin Sawicki
60ab71a706 Combine launch and current status login item APIs 2016-07-06 13:57:46 -07:00
Kevin Sawicki
2406c82ef5 Add specs for login item APIs 2016-07-06 13:34:14 -07:00
Kevin Sawicki
56739e10e3 Add anonymous class to exports and assert it 2016-07-06 13:11:25 -07:00
Kevin Sawicki
a9b43a0fc9 Use empty string constructor name when missing 2016-07-06 13:06:48 -07:00
Kevin Sawicki
d67dfd09fd Pass through empty constructor names 2016-07-06 09:18:20 -07:00
Kevin Sawicki
a1209b69b3 Add spec for constructor-less param 2016-07-06 09:11:04 -07:00
Cheng Zhao
6c2825c0c4 spec: Ignore cache when testing protocol module 2016-07-04 18:08:41 +09:00
Cheng Zhao
ee0eb9ae08 Merge pull request #6309 from electron/app-launcher-rename 
Implement app.setBadgeCount on Mac
 2016-07-02 01:51:47 +00:00
Cheng Zhao
767124c45c Update for reviews 2016-07-02 10:36:46 +09:00
Cheng Zhao
bb92765ecf spec: Suppress the session.protocol test 2016-07-01 22:24:30 +09:00
Cheng Zhao
1da2a1c2ae app.setBadgeCount should return boolean 2016-07-01 22:20:05 +09:00
Cheng Zhao
cb00d3cfb3 mac: Implement app.setBadgeCount 2016-07-01 17:39:26 +09:00
Jonas Schwabe
9aa8807f83 add specs for app.launcher api 
fix linter errors
 2016-06-29 20:28:16 +02:00
Kevin Sawicki
03497fb984 Update buffer length asserts 2016-06-29 09:46:16 -07:00
Kevin Sawicki
8b35814d10 🎨 2016-06-29 09:46:16 -07:00
Kevin Sawicki
197ec98800 Remove standard linter warnings 2016-06-29 09:46:16 -07:00
Kevin Sawicki
4afa32a7bb Add WebInspector as global 2016-06-29 09:46:16 -07:00
Kevin Sawicki
9922261f9e Set browser env in specs 2016-06-29 09:46:16 -07:00
Kevin Sawicki
8c52279531 Tweak cookie set failure message and add spec 2016-06-29 08:53:52 -07:00
Kevin Sawicki
d2d11ce8bd Invoke callback instead of returning 2016-06-28 13:04:59 -07:00
Kevin Sawicki
2fe83bc5f0 Add failing spec for no specified storage keys 2016-06-28 13:01:51 -07:00
Kevin Sawicki
14df90fd19 Add spec for valid .ico file 2016-06-28 12:17:05 -07:00
Kevin Sawicki
8fb86e10fc Add assert for non-existent .ico 2016-06-28 12:17:05 -07:00
Cheng Zhao
090c8b89bb spec: Make beginFrameSubscription test more reliable 2016-06-26 11:53:58 +09:00
Cheng Zhao
3d2ad0080d Merge pull request #6164 from MaxWhere/master 
beginFrameSubscription bugfix and improvement
 2016-06-26 02:39:59 +00:00
Heilig Benedek
5118def724 damaged -> dirty rename, fixed misc issues, changed signature, updated docs and added tests 2016-06-25 18:23:40 +02:00
Kevin Sawicki
f90ef12814 read/writeBookmark is not implemented on Linux 2016-06-24 17:16:38 -07:00
Kevin Sawicki
5fbba2d27b Add assertions for no available bookmark 2016-06-24 15:32:52 -07:00
Kevin Sawicki
e802d0e4a0 Add bookmark key to clipboard.write 2016-06-24 15:14:28 -07:00
Kevin Sawicki
358bf1bf69 Add read/writeBookmark spec 2016-06-24 15:10:32 -07:00
Kevin Sawicki
c6906deef2 Add failing spec for trailing separator bug 2016-06-23 15:39:21 -07:00
Kevin Sawicki
b273b70eee Filter existing search paths instead reimplementing 2016-06-23 15:27:45 -07:00
Kevin Sawicki
eed240be1c Add specs for Module._nodeModulesPath 2016-06-23 15:20:14 -07:00
Cheng Zhao
e70c622a70 Merge pull request #6190 from electron/default-label-and-accelerator 
Add default label and accelerator for menu item roles
 2016-06-23 05:34:10 +00:00
Cheng Zhao
2893974c05 spec: Set mimeType for protocol's handler 2016-06-23 13:29:18 +09:00
Cheng Zhao
a04c0ce196 spec: Split the session.protocol test into multiple tests 2016-06-23 13:16:53 +09:00
Cheng Zhao
71ab69314c spec: Put protocol registration in beforeEach 2016-06-23 13:11:19 +09:00
Kevin Sawicki
813e528350 Update expected accelerator 2016-06-22 15:41:45 -07:00
Kevin Sawicki
b7afe44a5c Add assert for role with app name in label 2016-06-22 14:22:15 -07:00
Kevin Sawicki
5096d7835f Add spec for default role label/accelerator 2016-06-22 14:07:46 -07:00
Kevin Sawicki
90600ba653 Add failing spec for writeable command id 2016-06-22 10:06:54 -07:00
Kevin Sawicki
38e1abc599 🎨 Destructure requires 2016-06-22 09:21:46 -07:00
Kevin Sawicki
51b8c0292c Add spec for submenu type with no submenu 2016-06-22 09:21:46 -07:00
Kevin Sawicki
93cbe6539f Add spec for invalid menu item type 2016-06-22 09:21:46 -07:00
Cheng Zhao
90b64504fc spec: Fix failing tests of Menu 2016-06-22 13:36:10 +09:00
Kevin Sawicki
8a9f2261d0 Add default error handler to remote promises (#6151) 
* Add failing spec for unhandled main process exception

* Remove unused return

* Use let/const instead of var

* Add spec for unhandled rejection in renderer process

* Prevent unhandled rejection defaul

* Use once instead of on

* Add default fulfilled/rejection handler to promise
 2016-06-21 00:54:15 +00:00
Cheng Zhao
e33e4be257 macOS: Use sheet window as modal window 2016-06-20 14:49:24 +09:00
Cheng Zhao
f4bec78ccb linux: Implement win.setParentWindow(parent) 2016-06-20 11:16:41 +09:00
Cheng Zhao
a6c4bf098b spec: Avoid calling setParentWindow for unrelated tests 2016-06-20 11:16:41 +09:00
Cheng Zhao
85ba382027 Add "parent" option for BrowserWindow 2016-06-20 11:16:41 +09:00
Cheng Zhao
2c5f4aadfb spec: Test cases for win.setModal(modal) 2016-06-20 11:16:41 +09:00
Cheng Zhao
214dd97165 spec: Test cases for parent window 2016-06-20 11:16:41 +09:00
Cheng Zhao
e4d30ccfc3 spec: Suppress isCI test on CI 2016-06-20 11:16:17 +09:00
Cheng Zhao
b74522d9f3 Merge pull request #6130 from rahatarmanahmed/fix-renderer-stdout 
🐛 Don't load 'repl' unless needed
 2016-06-19 12:32:06 +00:00
Rahat Ahmed
3c7c584444 🐛 Don't load 'repl' unless needed 
Git bisect revealed that process.stdout failed to initiate (and was replaced with a write stream that does nothing) when the 'repl' module was loaded. This commit moves `require('repl')` so that it is only loaded when the --interactive flag is present.

Fixes #5051
 2016-06-19 02:34:48 -05:00
Leonard Lamprecht
67dd19ed0f Replace OS X and Mac OS with macOS 2016-06-18 15:26:26 +02:00
Kevin Sawicki
b6f87574ee Reset icon and clear progress bar 2016-06-16 15:01:37 -07:00
Kevin Sawicki
52525ef6bc Add failing spec for icon progress crash 2016-06-16 14:57:07 -07:00
Cheng Zhao
335cd8779c spec: Correctly cleanup the protocol test 2016-06-16 11:09:52 +09:00
Kevin Sawicki
d160be5daa Add web-contents-created event spec 2016-06-13 09:05:04 -07:00
Cheng Zhao
853d7b1b79 Merge pull request #5965 from electron/installed-extension-api 
Add BrowserWindow.getDevToolsExtensions API
 2016-06-13 00:45:58 +00:00
Jessica Lord
c68ca16148 Merge pull request #5974 from electron/chrome-storage-sync 
Add chrome.storage.sync and chrome.storage.get APIs
 2016-06-10 12:20:03 -07:00
Kevin Sawicki
1f245d5ff6 Add getDevToolsExtensions API 2016-06-10 09:26:38 -07:00
Kevin Sawicki
0a26075699 Add BrowserWindow.isDevToolsExtensionInstalled API 2016-06-10 09:24:04 -07:00
Cheng Zhao
90a1b45135 Merge pull request #5975 from electron/disable-only-specs-on-ci 
Log and exit when calling only in specs on CI
 2016-06-10 12:11:31 +00:00
Cheng Zhao
4373dc1eac Merge pull request #5972 from electron/non-writeable-guest-id 
Make guestId on BrowserWindowProxy non-writeable
 2016-06-10 12:02:07 +00:00
Cheng Zhao
21081549fd Merge pull request #5967 from electron/window-opener-webview 
Support window.opener from windows opened from a <webview>
 2016-06-10 11:52:37 +00:00
Cheng Zhao
ccaf837da4 Merge pull request #5964 from electron/manifest-errors 
Throw errors reading/parsing manifest.json files
 2016-06-10 03:28:57 +00:00
Kevin Sawicki
110f1f8b75 Tweak error message 2016-06-09 17:00:32 -07:00
Kevin Sawicki
55a4e2589b Log/exit when only called in specs on CI 2016-06-09 16:56:25 -07:00
Jessica Lord
8fa4d66a5e Remove .only from spec 2016-06-09 16:39:42 -07:00
Jessica Lord
f121f46a24 Merge branch 'master' into chrome-storage-sync 2016-06-09 16:35:00 -07:00
Jessica Lord
d6d4d51173 Fix spec case 2016-06-09 16:26:25 -07:00
Jessica Lord
d6b108b272 Add spec 2016-06-09 14:14:20 -07:00
Jessica Lord
0ed10658a3 Add spec 2016-06-09 13:57:51 -07:00
Kevin Sawicki
39180e6539 Get webContents from guestId 2016-06-09 13:50:42 -07:00
Kevin Sawicki
2f88bec177 Add guestId non-writeable assertions 2016-06-09 13:45:09 -07:00
Kevin Sawicki
c8180ab301 Update spec description 2016-06-09 12:06:49 -07:00
Kevin Sawicki
a184b6afb3 Add spec for window.open from <webview> 2016-06-09 12:02:01 -07:00
Kevin Sawicki
d1ac5dd29b Add specs for manifest.json read/parse error 2016-06-09 09:44:49 -07:00
deepak1556
4749e18fc0 fix spec and docs 2016-06-09 10:48:05 +05:30
deepak1556
b91217f29e emit once for each session and add spec 2016-06-09 10:40:51 +05:30
deepak1556
aa853dd3be move protocol to session properties for working with partitions 2016-06-09 10:39:18 +05:30
Kevin Sawicki
4f7bde38a9 Assert on tab id as well 2016-06-08 12:00:13 -07:00
Kevin Sawicki
bf47056561 Pluralize extension 2016-06-08 12:00:13 -07:00
Kevin Sawicki
19787544b5 Add failing spec for webview devtools extension 2016-06-08 12:00:12 -07:00
Cheng Zhao
1146b2d5c1 spec: Custom protocol can have "fetch" working in it 2016-06-08 14:44:30 +09:00
Kevin Sawicki
d6311daea3 Add failing spec for chrome.runtime.id 2016-06-06 14:41:55 -07:00
Cheng Zhao
f59eecb1cc Merge pull request #5833 from CharlieHess/osx-global-defaults 
Support array / dictionary types in getUserDefault
 2016-06-03 08:36:44 +00:00
Cheng Zhao
707d68f719 spec: Add test case for app.relaunch 2016-06-03 12:12:20 +09:00
Charlie Hess
e377298cd2 Be consistent in spec organization. 2016-06-01 19:29:24 -07:00
Charlie Hess
fa3b17444f All we really need to do is make getUserDefault support array / object types. 2016-06-01 19:21:17 -07:00
Charlie Hess
587dd2fe51 Expose the method to JS and write a simple test. 2016-06-01 18:56:25 -07:00
Cheng Zhao
4d8994df92 spec: child_process.fork shouble be able to pipe stdio 2016-05-31 11:05:58 +09:00
Cheng Zhao
49f1278601 Refactor the URLRequestFetchJob code 
This makes the read end and write end of the pipe have same logic, so it
is more easy to maintain.
 2016-05-30 20:31:00 +09:00
Cheng Zhao
912cedc593 Merge pull request #5753 from deepak1556/url_request_fetch_job_patch 
protocol: store initial response data for when resource loader becomes ready
 2016-05-30 10:53:53 +00:00
Cheng Zhao
ce0d3d93ab spec: disablewebsecurity should not break preload and node integration 2016-05-30 15:23:09 +09:00
Cheng Zhao
a176aaee01 Merge pull request #5734 from danhp/fix-aspect-ratio 
Fix 'setAspectRatio(0)' not resetting the default behaviour.
 2016-05-30 01:14:03 +00:00
Cheng Zhao
9f0fc96025 Merge pull request #5711 from electron/extension-code-cleanup 
Implement partial chrome.* API for devtools extension
 2016-05-29 23:29:08 +00:00
Daniel Pham
34af9794a2 ✅ Add test for 'setAspectRatio(0)' 2016-05-29 08:47:42 -04:00
deepak1556
9d8af43617 add spec 2016-05-29 13:43:26 +05:30
Cheng Zhao
a58b84bbd7 spec: ipcRenderer.sendTo sends message to WebContents 2016-05-28 20:50:30 +09:00
Kevin Sawicki
fc4b224dec Add asserts for properties 2016-05-27 10:52:56 -07:00
Kevin Sawicki
7cf6be07a6 Add failing spec for remote property with no prototype 2016-05-27 10:45:39 -07:00
Kevin Sawicki
71b73a9cfb Use new APIs 2016-05-26 14:24:47 -07:00
Kevin Sawicki
69c69880e5 Tweak spec description 2016-05-25 09:12:52 -07:00
Kevin Sawicki
4e68a8d16e Remove logging in parent page 2016-05-25 09:12:52 -07:00
Kevin Sawicki
73b07f76a3 Support document visiblity state and events in webviews 2016-05-25 09:12:52 -07:00
Kevin Sawicki
1e15ce6ccd Add failing spec for webview visiblity changes 2016-05-25 09:12:52 -07:00
Cheng Zhao
28e2058ff1 Merge pull request #5648 from electron/chrome51 
Update to Chrome 51
 2016-05-24 10:59:11 +00:00
Cheng Zhao
cd444e82f9 Merge pull request #5666 from electron/remote-promise-reject 
Handle rejection of remote promises
 2016-05-24 04:30:25 +00:00
Kevin Sawicki
5e2f36387f Move require spec to api-app-spec 2016-05-23 15:14:55 -07:00
Kevin Sawicki
4a41311409 Test that calling regular module succeeds 2016-05-23 15:14:55 -07:00
Kevin Sawicki
fe0ec67623 Add spec for electron module require 2016-05-23 15:14:55 -07:00
Kevin Sawicki
f3af1dbd54 Add failing spec for rejected remote promise 2016-05-23 15:06:46 -07:00
Cheng Zhao
3402c7be3f Suppress ffi test on Windows 2016-05-23 23:31:00 +09:00
Cheng Zhao
fa0ce7ad5f Adjust to the new behaviors of beforeunload handler 2016-05-23 14:27:39 +09:00
Cheng Zhao
13b4c8bb06 Ignore invalid parameter error in crash service process 2016-05-23 08:59:34 +09:00
deepak1556
c9b314d43c renderer: generate net error strings when requested 2016-05-21 10:21:15 +05:30
Cheng Zhao
8ac93e02c6 Merge pull request #5616 from electron/inherit-zoom 
Inherit zoomFactor in webview
 2016-05-20 00:27:06 +00:00
Kevin Sawicki
b09c81202a Add test for webview zoomFactor inheritance 2016-05-19 14:46:52 -07:00
Juan Cruz Viotti
1a27ecdad4 Override child_process.execFile asar patch for child_process.exec 
NodeJS implements `child_process.exec` by simply passing the whole
command to `child_process.execFile`. See:

- https://github.com/nodejs/node/blob/master/lib/child_process.js#L90
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L99

Electron patches `child_process.execFile` to add support for `asar`
archives by injecting logic that extracts the required files from the
`asar` to a temporary location before delegating the work to the
original `child_process.execFile`.

In order to decide whether to inject the custom `asar` extracting logic,
Electron makes use of a helper function called `splitPath()`. See:

- https://github.com/electron/electron/blob/master/lib/common/asar.js#L37

If the first argument of the returned array equals `true`, means that
the path is considered to be an `asar` archive, and thus the extraction
logic takes place. The problem is that if the command passed to
`child_process.execFile` *contains* a path to an asar archive, padded
with other commands/arguments, `splitPath()` will consider it to be an
`asar` archive, and will try to extract it, throwing a rightfully
`Invalid package` error.

Fixes: https://github.com/electron/electron/issues/5571
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
 2016-05-19 17:19:36 -04:00
Cheng Zhao
242508e22f Merge pull request #5574 from electron/devtools-extension-test 
Add test that loads a devtools extension
 2016-05-18 01:46:44 +00:00
Kevin Sawicki
cee31ff67a Remove semicolon 2016-05-17 16:42:37 -07:00
Kevin Sawicki
9266f9abfc Update interval id variable name 2016-05-17 16:42:21 -07:00
Kevin Sawicki
f95c46d987 Show last panel by id 2016-05-17 16:40:34 -07:00
Kevin Sawicki
13cfc2d2a0 Add comment about panel switching via input event 2016-05-17 15:05:58 -07:00
Kevin Sawicki
8d0c5c30b8 Use consistent function styles 2016-05-17 15:05:27 -07:00
Kevin Sawicki
0b4b79d0a4 Use control on non-mac platforms 2016-05-17 15:01:32 -07:00
Kevin Sawicki
7db2601ea8 DRY up specs 2016-05-17 14:59:33 -07:00
Kevin Sawicki
77b074fbad Add spec for undocked devtools 2016-05-17 14:56:00 -07:00
Kevin Sawicki
189380d4ea Add spec for devtools extension 2016-05-17 14:52:45 -07:00
Cheng Zhao
90f52169af No more need to check for nodeIntegration when creating guest view 2016-05-17 17:06:02 +09:00
Cheng Zhao
0140015500 spec: WebView is disabled when nodeIntegration is disabled 2016-05-17 17:04:13 +09:00
Cheng Zhao
f43b9665c1 And increase timeout for the rest 2016-05-15 10:00:29 +09:00
Cheng Zhao
861a79dd6a Suppress the tests that need to call window.open on Travis CI 2016-05-15 09:41:02 +09:00
Cheng Zhao
0ad03d9ff7 Suppress crashReporter test on x64 Windows for now 2016-05-13 11:12:01 +09:00
Cheng Zhao
0f52a6da39 Merge branch '1-0-release' 2016-05-11 15:14:56 +09:00
Cheng Zhao
8e7a5adc60 spec: protocol.registerStandardSchemes does not throw 2016-05-10 09:57:13 +09:00
Cheng Zhao
797b0ddb9a Fix exception when refreshing specs window 2016-05-09 20:08:50 +09:00
Cheng Zhao
af0afecb45 Merge pull request #5406 from deepak1556/protocol_standard_scheme_patch 
protocol: fix registerStandardSchemes api
 2016-05-09 09:12:35 +09:00
Cheng Zhao
c682ccd9d0 Suppress the window.open tests on travis CI's mac machine 2016-05-08 15:15:16 +09:00
deepak1556
9c71c9fa6a fix docs and spec 2016-05-08 01:37:57 +05:30
deepak1556
0f2ae385ed allow protocol module initialization before app ready. 
* ensure registerStandardSchemes can only be called before app ready
 * ensure other protocol methods can only be used after app ready
 2016-05-08 01:36:34 +05:30
deepak1556
1ff33b7c81 protocol: fix registerStandardSchemes api 2016-05-08 01:36:34 +05:30
Kevin Sawicki
609f5dcaaf Update read path to something that exists 2016-05-06 10:12:55 -07:00
Kevin Sawicki
4d6b95aa52 Tweak spec description 2016-05-06 10:12:55 -07:00
Kevin Sawicki
0eefb282ca Test no handler via call to deprecate.log 2016-05-06 10:12:55 -07:00
Kevin Sawicki
722a07de86 Add explicit call to deprecate.log 2016-05-06 10:12:55 -07:00
Kevin Sawicki
58473f41ab Remove deprecated BrowserWindow options specs 2016-05-06 10:12:54 -07:00
Kevin Sawicki
bea232f53a Update specs for internal module require 2016-05-06 10:12:54 -07:00
Kevin Sawicki
ef801d5543 Remove .only call 2016-05-06 10:12:54 -07:00
Kevin Sawicki
a6cf7a1095 Remove deprecated crashReporter.start options 2016-05-06 10:12:53 -07:00
deepak1556
45b3bd3a22 ipcRenderer: fix crash with multiple listeners to sync message 2016-05-06 02:52:59 +05:30
Cheng Zhao
8e1d2479ac spec: Should not run app.setUserActivity test on non-OS X 2016-05-05 12:27:25 +09:00
Charlie Hess
7b207aa1b6 Don't run this spec on platforms where the method is unavailable. 2016-05-03 23:33:40 -07:00
Charlie Hess
12764a66ed Add an accessor for the current activity type and write the simplest possible test. 2016-05-03 15:51:31 -07:00
Cheng Zhao
f65f8918c9 Fix specs on Windows when running without desktop session 2016-04-30 21:03:22 +09:00
Cheng Zhao
214eb0430c Fix a few failing tests on Windows 2016-04-30 18:21:18 +09:00
Cheng Zhao
8aa88067ca Do not write to stdout in Electron when running on win32 CI machine 
This makes Electron crash on CI machine somehow.
 2016-04-30 17:08:51 +09:00
Zeke Sikelianos
9f99ba3b73 update all references to old atom-log bracket notation 2016-04-29 18:35:02 -07:00
deepak1556
d64e3784f4 renderer: fix desktop capture api not responding different subsequest calls 2016-04-28 14:24:22 +05:30
deepak1556
4e6b148eaa webContents: fix executejavascript when called before page load 2016-04-28 01:54:08 +05:30
Kevin Sawicki
e4bd592e0e Add failing spec 2016-04-21 11:49:42 -07:00
deepak1556
ca756c3c24 session: allow providing permission to handle external protocols 2016-04-21 05:27:07 +05:30
Cheng Zhao
aa29dc0c8a Merge pull request #5199 from Mr0grog/5183-disambiguate-loading-from-main-frame-loading 
Add `isLoadingMainFrame()` to WebContents
 2016-04-20 20:49:56 +09:00
Rob Brackett
d3e879cd7f Change WebContents::IsLoadingMainFrame to compare SiteInstances 
(per @deepak1556's recommendation)

Also updates tests to cover the situation where navigating between pages from the same potential "site" and adds generalized tests for `isLoadingMainFrame()`.
 2016-04-19 22:05:09 -07:00
deepak1556
794d120754 rename importClientCertificate => importCertificate 2016-04-20 08:45:49 +05:30
Rob Brackett
3a9bbe30ac Test for #5183 - webContents.executeJavaScript hangs on subframe load. 2016-04-18 10:33:56 -07:00
deepak1556
2c0494dcef fix spec 2016-04-18 22:57:37 +05:30
deepak1556
2ddac9352f add spec 2016-04-18 21:53:44 +05:30
Cheng Zhao
65c612a66d Avoid external URLs 2016-04-13 19:55:59 +09:00
Cheng Zhao
0a39449694 spec: loadUrl should not crash in did-fail-provisional-load handler 2016-04-13 19:39:11 +09:00
Cheng Zhao
bb70defcb8 spec: webview should work without script tag in page 2016-04-12 15:10:26 +09:00
Cheng Zhao
5efa075aca spec: preload attribute should work without script tag in page 2016-04-12 14:57:40 +09:00
Cheng Zhao
a07612c1ed Merge branch '5074-did-get-response-details-resource-type' of https://github.com/Mr0grog/electron into Mr0grog-5074-did-get-response-details-resource-type 2016-04-11 21:05:40 +09:00
Cheng Zhao
5659ee5c0b Merge pull request #5030 from deepak1556/webrequest_response_headers_patch 
session: webRequest.OnHeadersReceived should accept status line.
 2016-04-11 20:04:32 +09:00
Rob Brackett
15b042b5f6 Add support/tests for did-get-response-details event on <WebView> 2016-04-08 12:55:20 -07:00
Rob Brackett
c1b1348735 Add resourceType arg to webContents did-get-response-details event. 
Fixes #5074 and follows @zcbenz's recommendation to expose ResourceTypeToString from atom_network_delegate publicly.
Also adds testing for other arguments to the `did-get-response-details` events, since there were no existing tests for them.
 2016-04-08 11:19:36 -07:00
deepak1556
3fb39ad3ef provide option to override status line 2016-04-08 14:03:57 +05:30
Cheng Zhao
2f6796bd7f Disable throttling in tests 2016-04-08 15:57:14 +09:00
deepak1556
4fc35a4587 session: webRequest.OnHeadersReceived should follow server redirect 
Its required to follow server redirects.
 2016-04-08 11:40:43 +05:30
Cheng Zhao
82856eb099 Merge pull request #5029 from Mr0grog/5013-add-main-frame-param-for-did-fail-load 
Add `isMainFrame` param to WebContents `did-fail-load` event
 2016-04-07 20:22:02 +09:00
Cheng Zhao
dd283ff8d7 spec: We should not use pre release of Node 2016-04-05 19:53:07 +09:00
Cheng Zhao
c562b24df8 spec: Add test case for #5028 2016-04-05 17:08:27 +09:00
Rob Brackett
f12f87d6f0 Add isMainFrame as last argument to WebContents did-fail-load event. 
Fixes #5013.
 2016-04-04 19:26:06 -07:00
Cheng Zhao
19a172f2f5 Remove the hacks because of transparent background 2016-04-02 21:21:30 +09:00
Kevin Sawicki
527ff66115 Pull app/session from remote 2016-04-01 16:59:13 -07:00
Kevin Sawicki
3695e38719 Remove duplicate require 2016-04-01 16:53:44 -07:00
Kevin Sawicki
7734f6af62 Remove semicolons 2016-04-01 16:52:55 -07:00
Kevin Sawicki
909ed54bef Remove stray log 2016-04-01 16:52:28 -07:00
Kevin Sawicki
230ed78dd6 Remove lint warnings 2016-04-01 16:51:17 -07:00
Kevin Sawicki
ef2a28ca86 Listen for browser-window-created event for asserts 2016-04-01 16:50:20 -07:00
Kevin Sawicki
fd12e1f506 Add failing spec for webview nodeIntegration inheritance 2016-04-01 16:47:17 -07:00
Kevin Sawicki
4890734f66 Add missing title param 2016-04-01 16:42:53 -07:00
Kevin Sawicki
9e66df23d0 Add clearer assertion of process being undefined 2016-04-01 16:40:33 -07:00
Kevin Sawicki
d7b1792503 Use template strings 2016-04-01 16:39:31 -07:00
Kevin Sawicki
2713580d09 Remove stray log 2016-04-01 16:39:31 -07:00
Kevin Sawicki
777704e659 Add failing spec for nodeIntegration inheritance 2016-04-01 16:39:06 -07:00
Kevin Sawicki
3c96d7b726 Rename atom.asar to electron.asar in specs 2016-04-01 16:12:57 -07:00
Cheng Zhao
b35f4c1805 spec: Fix failing test due to path delimiter 2016-04-01 16:42:44 +09:00
Cheng Zhao
247b3f3605 Fix the background color in test app 2016-04-01 16:35:19 +09:00
Cheng Zhao
b9ead472a5 spec: Remote object should be referenced by methods in its prototype chain 2016-04-01 15:35:34 +09:00
Cheng Zhao
f36851fcff spec: Remote object should be referenced by its members 2016-04-01 15:05:05 +09:00
Zeke Sikelianos
7c58f7fb02 eradicate all per-file eslint globals 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
6425ef4261 restrict mocha scope to /spec; break out link tasks 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
b5afad9da7 avoid using eslint comment exceptions 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
e6698102c9 standardize by hand 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
cfdfdc8ccc standardize by hand 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
14fb3c4598 throw error if it exists 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
c5f70c8d99 dance around error checking with this one weird trick 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
5e4696f4a7 standardize more 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
9db733a4ff mostly more globals 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
c4b6cf4a8e do more manual cleanup and specify globals 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
f47fa25e39 tiptoe 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
f35f362272 autoformat more files 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
bd9b0b8ed3 wrap conditional, because return can only be used in a function 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
3855a774ab autoformat more easy files 2016-03-30 17:00:31 -07:00
Cheng Zhao
e08b48ab48 Merge pull request #4840 from atom/undefined-menu-accelerator 
Undefined menu accelerator
 2016-03-21 21:02:44 +09:00
Zeke Sikelianos
827730144b style nit 2016-03-18 10:53:49 -07:00
Zeke Sikelianos
e9ba5abe03 test for null accelerator too 2016-03-17 16:14:31 -07:00
Zeke Sikelianos
87395cdef8 add failing spec for undefined accelerator 2016-03-17 16:09:16 -07:00
Kevin Sawicki
737ffd8d7c Improve deprecated message on webPreferences options 2016-03-17 13:37:08 -07:00
Kevin Sawicki
2acfb8ad82 node-integration -> nodeIntegration 2016-03-17 13:37:07 -07:00