provide option to override status line

This commit is contained in:
deepak1556 2016-04-08 14:03:57 +05:30
parent 4fc35a4587
commit 3fb39ad3ef
3 changed files with 33 additions and 4 deletions

View file

@ -5,6 +5,7 @@
#include "atom/browser/net/atom_network_delegate.h"
#include <string>
#include <utility>
#include "atom/common/native_mate_converters/net_converter.h"
#include "base/stl_util.h"
@ -19,6 +20,9 @@ namespace atom {
namespace {
using ResponseHeadersContainer =
std::pair<scoped_refptr<net::HttpResponseHeaders>*, const std::string&>;
const char* ResourceTypeToString(content::ResourceType type) {
switch (type) {
case content::RESOURCE_TYPE_MAIN_FRAME:
@ -170,16 +174,19 @@ void ReadFromResponseObject(const base::DictionaryValue& response,
}
void ReadFromResponseObject(const base::DictionaryValue& response,
scoped_refptr<net::HttpResponseHeaders>* headers) {
const ResponseHeadersContainer& container) {
const base::DictionaryValue* dict;
std::string status_line;
if (!response.GetString("statusLine", &status_line))
status_line = container.second;
if (response.GetDictionary("responseHeaders", &dict)) {
auto headers = container.first;
*headers = new net::HttpResponseHeaders("");
(*headers)->ReplaceStatusLine(status_line);
for (base::DictionaryValue::Iterator it(*dict);
!it.IsAtEnd();
it.Advance()) {
const base::ListValue* list;
if (base::ToLowerASCII(it.key()) == "location")
(*headers)->ReplaceStatusLine("HTTP/1.1 302 Found");
if (it.value().GetAsList(&list)) {
(*headers)->RemoveHeader(it.key());
for (size_t i = 0; i < list->GetSize(); ++i) {
@ -265,7 +272,8 @@ int AtomNetworkDelegate::OnHeadersReceived(
request, callback, original, override, allowed);
return HandleResponseEvent(
kOnHeadersReceived, request, callback, override, original);
kOnHeadersReceived, request, callback,
std::make_pair(override, original->GetStatusLine()), original);
}
void AtomNetworkDelegate::OnBeforeRedirect(net::URLRequest* request,

View file

@ -446,6 +446,8 @@ The `callback` has to be called with an `response` object:
* `cancel` Boolean
* `responseHeaders` Object (optional) - When provided, the server is assumed
to have responded with these headers.
* `statusLine` String (optional) - Should be provided when overriding `responseHeaders`
to change header status otherwise original response header's status will be used.
#### `ses.webRequest.onResponseStarted([filter, ]listener)`

View file

@ -322,6 +322,25 @@ describe('webRequest module', function () {
}
})
})
it('can change the header status', function (done) {
ses.webRequest.onHeadersReceived(function (details, callback) {
var responseHeaders = details.responseHeaders
callback({
responseHeaders: responseHeaders,
statusLine: "HTTP/1.1 404 Not Found"
})
})
$.ajax({
url: defaultURL,
success: function (data, status, xhr) {
},
error: function (xhr, errorType) {
assert.equal(xhr.getResponseHeader('Custom'), 'Header')
done()
}
})
})
})
describe('webRequest.onResponseStarted', function () {