Juan Cruz Viotti
a99c193cf2
🏁 Preserve file extension when extracting from asar
...
Currently, when calling `copyFileOut`, the original extension from the
file is lost, and a generic `*.tmp` is added instead.
This becomes problematic in the scenario where we use
`child_process.execFile` on a Windows Batch script that lives inside the
`asar` package.
Windows relies on the extension being present in order to interpret the
script accordingly, which results in the following bug because the
operating system doesn't know what do to with this `*.tmp` file:
```
Error: spawn UNKNOWN
```
Steps to reproduce:
1. Create a dummy batch script (test.bat):
```
@echo off
echo "Hello world"
```
2. Create an electron app that attemps to call this script with
`child_process.execFile`:
```js
var child_process = require('child_process');
var path = require('path');
child_process.execFile(path.join(__dirname, 'test.bat'), function(error, stdout) {
if (error) throw error;
console.log(stdout);
});
```
3. Package this small application as an asar archive:
```sh
> asar pack mytestapp app.asar
```
4. Execute the application:
```sh
> electron.exe app.asar
```
2015-12-01 14:55:58 -04:00
Cheng Zhao
85b7aa6933
Merge pull request #3645 from atom/fix-page-title-set
...
Delay the page-title-updated event to next tick
2015-12-01 19:12:34 +08:00
Cheng Zhao
e5974e44ed
Deprecate the page-title-set event
...
We have two names for the same event, page-title-updated wins.
2015-12-01 18:50:56 +08:00
Cheng Zhao
c95117fb22
Delay the page-title-set event to next tick
2015-12-01 18:34:58 +08:00
Cheng Zhao
83ee78451a
Emit event when title becomes empty
2015-12-01 17:53:13 +08:00
Cheng Zhao
8d20dda6d7
No need to override TitleWasSet in NativeWindow
2015-12-01 17:51:09 +08:00
Cheng Zhao
782af41c7c
Merge pull request #3643 from atom/fix-did-fail-load-crash
...
Delay the did-fail-provisional-load event to next tick
2015-12-01 17:19:52 +08:00
Cheng Zhao
1b3eb1cc5d
Delay the did-fail-provisional-load event to next tick
...
Chrome is doing some stuff after the DidFailProvisionalLoad event, if we
call LoadURL at this time crash would happen.
2015-12-01 17:00:42 +08:00
Cheng Zhao
0f17a0163d
Put common constants in atom_constants
2015-12-01 16:21:15 +08:00
Cheng Zhao
a2f1390b0d
Merge pull request #3641 from atom/process-no-asar
...
Add process.noAsar to toggle asar support
2015-12-01 14:40:37 +08:00
Cheng Zhao
165b464a15
docs: process.noAsar
2015-12-01 13:43:52 +08:00
Cheng Zhao
900dc78a47
spec: process.noAsar
2015-12-01 13:09:50 +08:00
Cheng Zhao
e3ec1fe8ab
Add process.noAsar to turn off asar support
2015-12-01 13:09:37 +08:00
Cheng Zhao
757b644909
Merge pull request #3567 from atom/cors
...
Enable all origins via CORS header for custom schemes
2015-12-01 12:43:38 +08:00
Paul Betts
7fd1db192b
Lint harder
2015-11-30 18:12:00 -08:00
Cheng Zhao
bd5d52f825
Merge pull request #3638 from arturts/pt-br-translation
...
📝 [ci skip] Add translation to app.md
2015-12-01 10:06:55 +08:00
Cheng Zhao
dd0b2bc8d5
Merge pull request #3636 from arturts/patch-4
...
📝 [ci skip] Update to match english docs.
2015-12-01 10:06:38 +08:00
Cheng Zhao
290c0c37f4
Merge pull request #3635 from arturts/patch-3
...
📝 [ci skip] Fix typos
2015-12-01 10:06:13 +08:00
Artur de Oliveira Tsuda
7da78a9fa8
📝 [ci skip] Add translation to app.md
2015-11-30 21:56:19 -02:00
Artur de Oliveira Tsuda
97f535251b
📝 [ci skip] Update to match english docs.
2015-11-30 19:43:19 -02:00
Artur de Oliveira Tsuda
c83976dfdc
📝 [ci skip] Fix typos
2015-11-30 19:14:33 -02:00
Paul Betts
549da7fd91
Linting
2015-11-30 11:10:18 -08:00
Paul Betts
15b8d7680e
Add tests to verify behavior
2015-11-30 11:08:45 -08:00
Paul Betts
7cce3987eb
Add CORS header to file jobs
2015-11-30 11:08:45 -08:00
Paul Betts
65cb1488b0
Fix CORS header code to be cleaner
2015-11-30 11:08:44 -08:00
Paul Betts
7622bb40a9
Enable all origins via CORS header for custom schemes
...
This PR disables CORS for custom schemes, which allows you to serve Font
resources from custom schemes after using registerCustomSchemeAsSecure
2015-11-30 11:08:43 -08:00
Cheng Zhao
f931e165d5
Merge pull request #3634 from atom/fix-crash-on-exit
...
Delete BridgeTaskRunner when main message loop is ready
2015-11-30 22:40:48 +08:00
Cheng Zhao
44e24ebf7a
Delete BridgeTaskRunner when main message loop is ready
2015-11-30 22:29:01 +08:00
Cheng Zhao
a7dd6596f1
Merge pull request #3628 from lovemyliwu/patch-1
...
🎨 add miss charactor
2015-11-30 18:26:04 +08:00
Smite Chow
4d5028fb4c
🎨 add miss charactor
2015-11-30 17:16:35 +08:00
Cheng Zhao
dbdfac1133
Merge pull request #3626 from arturts/patch-2
...
Update 'Estilo de código' link.
2015-11-30 16:01:05 +08:00
Cheng Zhao
b9c6f719f3
Merge pull request #3625 from arturts/patch-1
...
Remove 'Google Translator'-like translation
2015-11-30 16:01:01 +08:00
Cheng Zhao
f30a7f5636
Merge pull request #3622 from atom/wl-docs-skip-ci
...
Suggest [ci skip] in documentation-only commits
2015-11-30 15:33:49 +08:00
Cheng Zhao
bf4b94561e
docs: Mention submitting to MAC costs money
...
Close #3617 .
2015-11-30 15:21:39 +08:00
Cheng Zhao
91395102cf
Merge pull request #3618 from preco21/master
...
Update as upstream
2015-11-30 15:01:08 +08:00
Cheng Zhao
23560ff570
Merge pull request #3616 from leftstick/master
...
add packaging translation for ZH-CN
2015-11-30 15:00:33 +08:00
Cheng Zhao
8ba02fb899
Merge pull request #3612 from gunmetal313/translate_to_ru
...
init russian lang docs
2015-11-30 14:57:16 +08:00
Artur de Oliveira Tsuda
45e9ed5f0c
Update 'Estilo de código' link.
...
'Estilo de código' in 'Desenvolvimento' section now points to the translated coding-style.md
2015-11-29 23:25:16 -02:00
Artur de Oliveira Tsuda
7d827c2f3e
Remove 'Google Translator'-like translation
2015-11-29 22:56:34 -02:00
Paul Betts
b67e70334a
Merge pull request #3621 from lukewestby/patch-1
...
fix misspelling in "rotation" string
2015-11-29 15:33:55 -08:00
Wliu
9c0afcd901
Wrap [ci skip] in backticks
2015-11-29 14:57:48 -05:00
Wliu
c7420e17ab
Suggest [ci skip] in documentation-only commits
2015-11-29 14:04:57 -05:00
Luke Westby
df9ecefe01
fix typo in "rotation" string
2015-11-29 12:22:53 -06:00
Plusb Preco
22dbf5e9fc
Small fixes
2015-11-29 23:06:01 +09:00
Plusb Preco
dab7058aa2
Update as upstream
2015-11-29 23:03:31 +09:00
Plusb Preco
9fbe2e6c0f
Merge remote-tracking branch 'refs/remotes/atom/master'
2015-11-29 18:46:01 +09:00
howard.zuo
5bbc46930f
add packaging translation for ZH-CN
2015-11-29 12:14:49 +08:00
Ivan Kulikov
eeb1143deb
init russian lang docs
2015-11-27 22:32:45 +03:00
Cheng Zhao
62add3abcc
Bump v0.35.2
2015-11-27 22:23:19 +08:00
Cheng Zhao
b529efcd8e
Merge pull request #3608 from atom/cp-execfile
...
Add docs and tests for child_process.execFile
2015-11-27 22:21:33 +08:00
