Kevin Sawicki
e7b679ead6
Add IsEmpty helper and remove GetInstance public usage
2017-04-11 09:09:17 -07:00
Kevin Sawicki
0883a9f966
Use CloseAllWindows helper
2017-04-11 09:09:17 -07:00
Ryohei Ikegami
34ed1a9ef8
Track child web contents
2017-04-06 12:15:27 +09:00
Ryohei Ikegami
526086d900
Improve RootWebContentsTracker
2017-04-06 11:37:21 +09:00
Samuel Attard
60cc862031
Make everything pointer like
2017-04-04 12:50:41 -07:00
Samuel Attard
4d6b0fc01b
Add a method to set the escape identifier on the touch bar
2017-04-04 12:50:41 -07:00
Kevin Sawicki
3e9014c371
Merge pull request #9099 from electron/certificate-trust
...
macOS: Add certificate trust API
2017-04-04 11:17:09 -07:00
joshaber
8d465234e4
Appease our linty overlords
2017-04-03 21:40:46 -04:00
joshaber
2badfbe04f
Remove the intermediate function
2017-04-03 21:22:37 -04:00
Ryohei Ikegami
4a7eec8f2d
Pass app path as command line argument
2017-04-04 09:36:01 +09:00
joshaber
74c0cbddae
Linebreak to keep the linter happy
2017-04-03 16:07:02 -04:00
joshaber
11f5c942ce
Conditionalize
2017-04-03 15:25:09 -04:00
joshaber
bcecba20e6
Fix indentation
2017-04-03 15:09:24 -04:00
joshaber
4ffaf2cd99
Remove old unnecssary change on app
2017-04-03 15:09:04 -04:00
joshaber
6e89cb9d7c
Move it into dialog
2017-04-03 15:05:24 -04:00
joshaber
4bbbcd093b
Handle the callback and cleanup properly
2017-04-03 14:01:48 -04:00
joshaber
1ed443ea29
Do the callback & release dance
2017-04-03 13:21:44 -04:00
Kevin Sawicki
f5a75c4e87
Merge pull request #9076 from electron/cleanup-cpp
...
Cleanup cpp codebase
2017-04-03 08:30:08 -07:00
joshaber
4f3d3557cc
Notify that the cert changed
2017-03-31 21:51:29 -04:00
Haojian Wu
8ae91682cb
Lines should be <= 80 characters.
2017-03-31 20:09:13 +02:00
joshaber
16cc79354c
Errrrybody's a scoped_refptr now
2017-03-31 13:53:42 -04:00
joshaber
653b2d15c3
Expose the certificate trust panel as part of app
2017-03-30 17:25:55 -04:00
joshaber
64369cd07f
Show a certificate trust panel
2017-03-30 17:25:44 -04:00
Haojian Wu
e8abee9ca9
Replace C-style casts with static_cast.
2017-03-30 23:05:47 +02:00
Haojian Wu
1b9780035c
Remove redundant calls to smart pointer's get method.
2017-03-30 22:22:40 +02:00
Haojian Wu
00693ba075
Replace "size()" with "empty()".
2017-03-30 21:59:18 +02:00
Haojian Wu
5f724e57bc
Avoid unnecessary copy of parameters.
2017-03-29 22:06:07 +02:00
deepak1556
3ae62615f4
net: allow controlling redirects
2017-03-28 18:46:21 +05:30
deepak1556
4ab2c92418
CommonWebContentsDelegate::DestroyWebContents => ResetManagedWebContents
2017-03-22 07:30:36 +05:30
deepak1556
72adbf7a2f
destroy guest webcontents before embedder
2017-03-19 10:25:13 +05:30
John Kleinschmidt
d5a658bbe4
Fixed pass by reference and added spec
2017-03-08 22:06:26 -05:00
John Kleinschmidt
1c2a78a896
Add WebRTCIPPolicy setting to webContents and webview
...
Resolves #8777
Code to set and get the policy come from the muon framework code:
https://github.com/brave/muon/blob/master/atom/browser/api/atom_api_web_
contents.cc#L1324...L1343
2017-03-08 10:15:48 -05:00
Kevin Sawicki
f549bda9fc
Merge pull request #8799 from nitsakh/baseURLForDataURL
...
Support base URL option to loadURL for data URLs
2017-03-06 10:25:53 -08:00
Kevin Sawicki
886b47e713
Merge pull request #8724 from electron/defer_load_url
...
webContents: defer url load when there is a pending navigation entry
2017-03-06 10:18:36 -08:00
Kevin Sawicki
479af3c9e2
Merge pull request #8678 from liusy182/download-item
...
only emit `download-item done` event once
2017-03-06 10:11:22 -08:00
deepak1556
e936143da2
listen for browser initiated pending nav entries too
2017-03-06 00:21:52 +05:30
deepak1556
dead1ae1ba
webContents: defer url load when there is a pending navigation entry
2017-03-06 00:10:46 +05:30
Kevin Sawicki
51f1c5a557
Use SetTouchBar withe empty vector instead of DestroyTouchBar
2017-03-03 14:00:39 -08:00
Kevin Sawicki
823b3baed0
Use vector of dictionaries instead of mate::Arguments
2017-03-03 14:00:38 -08:00
Kevin Sawicki
98f5858b11
Initial support for dynamic properties
2017-03-03 14:00:38 -08:00
Kevin Sawicki
cbb6f8c33e
Store event listeners in each TouchBar class
2017-03-03 14:00:38 -08:00
Samuel Attard
dd09c91cf2
initial work on updating touch bar item config without rerender
2017-03-03 14:00:38 -08:00
Samuel Attard
d1b3ba39bd
Fix cpp linting
2017-03-03 14:00:38 -08:00
Samuel Attard
18c7c3ece8
Make label and colorpicker types work
2017-03-03 14:00:38 -08:00
Samuel Attard
7857c83ea1
Make dynamic buttons work along with click events
2017-03-03 14:00:38 -08:00
Samuel Attard
703b5738c8
Initial TouchBar Magic
...
* Make the AtomNSWindow also a NSTouchbarDelegate
* Implement basic makeTouchBar and makeItemForIdentifier methods
* Initial sending of touch / update events through IPC to BrowserWindowObjects
TODO:
* JS API
* JS Object Converters
* Generalize methods so that popovers can work
2017-03-03 14:00:38 -08:00
Nitish Sakhawalkar
bcda67b8eb
No more extra whitespace.
2017-03-02 10:50:48 -08:00
Nitish Sakhawalkar
c06c4c0ccb
Reverting formatting changes made by clang format.
2017-03-01 14:04:41 -08:00
Nitish Sakhawalkar
879082b1a6
Issue #8735:Support base URL option to loadURL for data URLs
2017-02-28 16:49:03 -08:00
liusi
ff513f2a84
remove the call to download_item_->Remove() on cancel
2017-02-24 14:08:21 +08:00
Kevin Sawicki
a8d1a7aed4
Make variables private instead of protected
2017-02-22 10:30:28 -08:00
Kevin Sawicki
2006e22aa4
🎨
2017-02-22 10:30:28 -08:00
Kevin Sawicki
ce5ac1b056
Implement ClosePopupAt on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
91d1af053f
Implement Menu.closePopup on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
6a023dc4fe
Add Menu.closePopup API on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
66b6b4f1cb
Map async option to MenuRunner::ASYNC flag
2017-02-22 10:30:28 -08:00
Kevin Sawicki
4430927f98
Add async option to menu.popup
2017-02-22 10:30:28 -08:00
Kevin Sawicki
b091d104f5
Add async menu.popup on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
636ef0fd29
Add async menu.popup on macOS
2017-02-22 10:30:28 -08:00
deepak1556
203a920c64
fix signature of zoom getter apis
2017-02-18 01:34:32 +05:30
deepak1556
5687f8b3b7
Destroy icon manager after file thread is destroyed
2017-02-17 14:16:18 +05:30
Yury Solovyov
977abc6458
Update icon loading API implementation
2017-02-16 23:16:34 +03:00
Kevin Sawicki
36e6501c44
Rename variable for compiler error
2017-02-14 12:30:23 -08:00
Kevin Sawicki
9be42db8d5
Merge pull request #8628 from Spacetech/master
...
Implement invalidate for non-offscreen mode
2017-02-14 11:41:16 -08:00
Kevin Sawicki
5cb6648686
Use underscore variable name for consistency
2017-02-14 11:12:30 -08:00
Kevin Sawicki
82f452568c
🎨 Minor formatting tweaks
2017-02-14 11:09:15 -08:00
liusi
d56c1909df
only emit download-item done
event once.
2017-02-14 14:39:33 +08:00
Gary Wilber
f19924bcb0
Add Invalidate method to NativeWindow and add Mac implementation
2017-02-13 19:41:24 -08:00
deepak1556
7a0aff2bae
code cleanup
2017-02-12 01:48:24 +05:30
deepak1556
cbeaa6be87
simply handling temporary zoom levels of webview
2017-02-12 00:49:17 +05:30
deepak1556
e3fe3cc490
map webframe zoom api to use HostZoomMap
2017-02-12 00:49:17 +05:30
deepak1556
63c0e4cbb1
Add ZoomController to manager zoom changes for webcontents
2017-02-12 00:49:17 +05:30
deepak1556
07794a58aa
use zoom factor webpreference option when required.
...
* When setzoomlevel is not called for the host.
* When there is no zoom preference for the host.
2017-02-12 00:49:17 +05:30
deepak1556
b27c94368d
webContents: set zoom levels with HostZoomMap
2017-02-12 00:49:17 +05:30
Kevin Sawicki
f7f4de36af
Merge remote-tracking branch 'origin/master' into macos-open-save-panel
2017-02-09 11:25:05 -08:00
Kevin Sawicki
867bb5a94e
Add DialogSettings helper struct
2017-02-09 10:13:11 -08:00
Birunthan Mohanathas
c8c11e68c6
Add support for checkbox with dialog.showMessageBox
...
This adds the `checkboxLabel` and `checkboxChecked` options to display a
checkbox in the message box. Fixes #6048 .
2017-02-09 09:03:54 -08:00
Tan Wang Leng
a4a71a1dc9
Change qualifier of ShowSaveDialog() parameter
...
The normal convention in the codebase is to not use references
or 'const' for primitives like 'bool' and 'int'.
2017-02-09 21:50:55 +08:00
Tan Wang Leng
36209ddd90
🍎 Add additional options for Mac's open dialog
...
Support an additional attributes available in macOS's NSOpenPanel:
message.
2017-02-09 20:10:57 +08:00
Tan Wang Leng
1d612a12a1
🍎 Add additional options for Mac's save dialog
...
Support additional attributes available in macOS's NSSavePanel: message,
nameFieldLabel and showsTagField
2017-02-09 20:10:57 +08:00
Kevin Sawicki
1e581d6814
Use unique_ptr for passing VerifyRequestParams
2017-02-08 11:59:43 -08:00
Kevin Sawicki
70178adb6e
Use object for verification request
2017-02-08 11:59:43 -08:00
Greg Nolle
e29b64a18a
modify CertVerifier Class
...
* respond to multiple similar verification requests.
* accept net error result as callback response.
2017-02-08 11:59:43 -08:00
Gary Wilber
11e1f6b56c
Fix lint errors
2017-02-08 00:05:16 -08:00
Gary Wilber
ed44b32ff5
Convert indentation to spaces
2017-02-07 23:08:03 -08:00
Gary Wilber
148898fb75
Implement invalidate for non-offscreen mode
2017-02-07 23:03:42 -08:00
Yury Solovyov
bcf0964c61
Fix more review
2017-02-07 09:55:18 -08:00
Yury Solovyov
29452364f3
Use isolate() method to get isolate
2017-02-07 09:54:22 -08:00
Yury Solovyov
c2bf5bb986
Put locker and handle scope to the top of the function. Remove unneeded header
2017-02-07 09:53:34 -08:00
Yury Solovyov
5794138ed4
Normalize path
2017-02-07 09:53:34 -08:00
Yury
1b4ee6e0d8
Image from icon node-style callback ( #2 )
...
* Try implementing node-style callbacks
* Add locker and handle scope
2017-02-07 09:53:34 -08:00
deepak1556
2e85ff1f57
Fix code style
2017-02-07 09:53:34 -08:00
Yury Solovyov
3d47c9b71d
Fix lint
2017-02-07 09:53:34 -08:00
Yury Solovyov
05cb26a174
Use object for options
2017-02-07 09:53:34 -08:00
Yury Solovyov
bec671bac8
Make size optional
2017-02-07 09:52:11 -08:00
Robo
b25b141642
create iconmanager as singleton class and cleanup code ( #1 )
...
* create iconmanager as singleton class and cleanup code
2017-02-07 09:52:11 -08:00
renaesop
26135b412b
Merge remote-tracking branch 'upstream/master'
...
# Conflicts:
# atom/browser/api/atom_api_web_contents.cc
# chromium_src/chrome/browser/printing/print_job_worker.cc
# chromium_src/chrome/browser/printing/print_job_worker.h
# chromium_src/chrome/browser/printing/print_view_manager_base.cc
# chromium_src/chrome/browser/printing/print_view_manager_base.h
# chromium_src/chrome/browser/printing/printer_query.cc
# chromium_src/chrome/common/print_messages.cc
# chromium_src/chrome/renderer/printing/print_web_view_helper.cc
2017-02-07 09:30:36 +08:00
Cheng Zhao
86215d4300
Allow filter to use any scheme
2017-02-06 10:34:30 -08:00
Cheng Zhao
75627ba6ad
Fix sync printing not working
2017-02-06 10:34:29 -08:00
Cheng Zhao
820c0827c0
Fix cpplint warnings
2017-02-06 10:34:29 -08:00
Cheng Zhao
6165d36351
There is a new INSERTED type of ChangeCause
...
For the purpose of compatibility, we treat it as "explicit".
2017-02-06 10:34:29 -08:00
Cheng Zhao
6763977316
Update URLPattern to its latest version
2017-02-06 10:34:29 -08:00
Cheng Zhao
234e1bb811
base::Bind now prevents the case with no arguments
2017-02-06 10:34:29 -08:00
Cheng Zhao
411696ca19
Clear is replaced with ClearEntriesAddedWithin
2017-02-06 10:34:29 -08:00
Cheng Zhao
4a14b17255
WindowOpenDisposition has become enum class
2017-02-06 10:34:29 -08:00
Cheng Zhao
6d323dd6fe
web/WebInputEvent.h is moved to platform/WebInputEvent.h
2017-02-06 10:34:29 -08:00
Cheng Zhao
5cf2873b77
net::FtpProtocolHandler has changed its constructor
2017-02-06 10:34:29 -08:00
Cheng Zhao
13a1d79ca6
Deperecate AtomSecurityStateModelClient with SecurityStateTabHelper
2017-02-06 10:34:28 -08:00
Cheng Zhao
1d29b23662
Update api::WebContents
2017-02-06 10:34:28 -08:00
Cheng Zhao
231173aa90
Namespace of ChangeCause has changed
2017-02-06 10:34:28 -08:00
Cheng Zhao
d4e3dade39
WindowCapturer and ScreenCapturer are merged to DesktopCapturer
2017-02-06 10:34:28 -08:00
Cheng Zhao
c10eb73166
Signature of OnCreateWindow has changed
2017-02-06 10:34:28 -08:00
Cheng Zhao
d8e9432b0d
contentTracing.setWatchEvent/cancelWatchEvent is removed
2017-02-06 10:34:28 -08:00
Kevin Sawicki
e2501a80e4
Add path and args to LoginItemSettings struct
2017-02-06 08:34:35 -08:00
renaesop
023a3fd547
Print enhancement: add webContents.printerList And a print option to select printer
2017-02-06 17:18:04 +08:00
Kevin Sawicki
5973aa36ad
Initialize color listener after app is ready
2017-02-03 09:00:18 -08:00
Kevin Sawicki
dc1c11a841
Merge pull request #8487 from leethomas/feature/osx-relative-window-levels
...
Feature/macOS relative window levels
2017-01-30 15:34:24 -08:00
Kevin Sawicki
e683f28e32
Require a non-empty drag image to prevent crash
2017-01-26 15:46:04 -08:00
Kevin Sawicki
8ce1930f0d
Add specs for missing startDrag options
2017-01-26 15:46:04 -08:00
leethomas
1f5518b91e
throw an error for out of bounds window levels
2017-01-24 20:14:09 -08:00
leethomas
7a0a87a6f3
implement relative window levels, closes #8153
2017-01-23 23:42:33 -08:00
deepak1556
f9dc08baf6
emit did-fail-load event when the url char length exceeds limit
2017-01-21 14:59:20 +05:30
deepak1556
54559f99a0
Fix dereferencing nullptr
...
RenderWidgetHostView might not be available when
the navigator fails to load a url.
2017-01-21 14:56:58 +05:30
Kevin Sawicki
443040e8d7
Call InspectElement directly on InspectableWebContents
2017-01-19 09:05:59 +02:00
Kevin Sawicki
d6eb0d6629
Implement insertCSS on webFrame
2017-01-19 09:05:59 +02:00
Cheng Zhao
497f5a1199
Update files for Chrome 54 API changes
2017-01-19 09:05:59 +02:00
Kevin Sawicki
8f63fdb278
Destroy web contents when preventing default
2017-01-12 10:28:08 -08:00
Kevin Sawicki
fc75080c28
Merge pull request #8298 from electron/configure-throttling-on-created-callback
...
Configure background throttling on RenderViewCreated callback
2016-12-29 13:31:09 -08:00
Kevin Sawicki
6ea1bacc73
Merge pull request #8250 from gerhardberger/osr-window-size-fix
...
Always create offscreen window frameless
2016-12-29 09:10:14 -08:00
Kevin Sawicki
41afeb744a
Configure background throttling on RenderViewCreated callback
2016-12-28 15:52:47 -08:00
Kevin Sawicki
1308f790ad
Don't load URL if web contents is destroyed
2016-12-28 13:40:06 -08:00
gellert
f81908711b
use only one if statement
2016-12-21 23:15:05 +01:00
gellert
1ef0f6beff
creates offscreen window frameless
2016-12-20 23:43:52 +01:00
Kevin Sawicki
2a8b36c761
Merge pull request #8134 from deepak1556/empty_client_certificate_patch
...
app: select-client-certificate event callback can accept certificate optionally
2016-12-15 08:31:12 -08:00
Kevin Sawicki
590bde5e14
Remove unused include
2016-12-13 16:00:37 -08:00
Kevin Sawicki
7842040d9d
Add ToV8 converter for NativeWebKeyboardEvent
2016-12-13 15:54:13 -08:00
Kevin Sawicki
3237c6751a
Use DCHECK instead of assert
2016-12-13 15:54:13 -08:00
Birunthan Mohanathas
a3b65ad481
Add before-input-event event for webContents ( fixes #7586 )
...
Embedding arbitrary web content is problematic when it comes to keyboard
shortcuts because:
* Web content can steal app shortcuts (see e.g. brave/browser-laptop#4408 )
* Blocked web content (e.g. a focused <webview> performing expensive
computation) will also prevent app shortcuts from firing immediately
The new before-input-event event can be used to overcome these issues by
always handle certain keyboard events in the main process.
Note that this requires electron/brightray#261 to compile.
2016-12-13 15:54:13 -08:00
Kevin Sawicki
b08bc02cde
Merge pull request #8137 from deepak1556/media_device_id_patch
...
session: reset media device id salt when cookies are cleared
2016-12-12 13:34:24 -08:00
Kevin Sawicki
cac85d2a12
Remove linter errors
2016-12-12 12:51:48 -08:00
Paul Frazee
99ea50649a
finish implementation of {secure:true} opt on protocol.registerStandardScehesm, and add working test
2016-12-12 12:49:57 -08:00
Paul Frazee
9d2e23413e
add {secure:} opt to protocol.registerStandardSchemes
2016-12-12 12:49:57 -08:00
Kevin Sawicki
6a829e0179
Throw error when options object is invalid
2016-12-09 10:07:04 -08:00
deepak1556
7456b9ae17
net: add api to set request flags for testing
2016-12-09 09:54:30 -08:00
deepak1556
35349643af
session: api to clear auth cache
2016-12-09 09:54:30 -08:00
deepak1556
5d94221c61
fix code style
2016-12-09 09:37:46 -08:00
deepak1556
f124732431
add spec
2016-12-09 09:37:46 -08:00
deepak1556
86961d0f44
session: add api to create interrupted downloads
2016-12-09 09:37:46 -08:00
deepak1556
cbddbdb296
fix code style
2016-12-07 15:33:56 +05:30
deepak1556
18c0cfa6f5
app: optionally pass cert with select-client-certificate event
2016-12-07 13:26:06 +05:30
deepak1556
3de3fb53bd
session: reset media device id salt when cookies are cleared
2016-12-03 16:44:33 +05:30
Kevin Sawicki
2c8ab72269
Merge pull request #8084 from poiru/systempreferences-setuserdefault
...
Add systemPreferences.setUserDefault for macOS
2016-11-29 14:07:35 -08:00
Birunthan Mohanathas
486b6b9096
Add systemPreferences.setUserDefault for macOS
...
This API can be used to e.g. enable key repeat by setting
`ApplePressAndHoldEnabled` to `false` (see also #47 ).
2016-11-29 09:46:32 -08:00
Birunthan Mohanathas
18c49285a8
Add BrowserWindow.setAutoHideCursor for macOS
...
The `disableAutoHideCursor` BrowserWindow option can be used to control
auto-hiding behavior when the window is created. This new API is needed
to dynamically change the behavior after the fact.
2016-11-29 09:46:00 -08:00
Kevin Sawicki
774b2f99f2
Merge pull request #8038 from electron/danhp/close-file-preview
...
Add 'win.closeFilePreview()'
2016-11-28 14:47:06 -08:00
Kevin Sawicki
a7395118af
Merge pull request #7952 from the-ress/window-setappid
...
Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command
2016-11-28 14:46:14 -08:00
Kevin Sawicki
fff59271af
Initialize app icon index to 0
2016-11-28 14:26:30 -08:00
Daniel Pham
d5a0dd39a1
🎁 Add 'win.closeFilePreview()'
2016-11-28 14:25:11 -08:00
Kevin Sawicki
26137977cd
Fix crash when return value pointer is null
2016-11-21 09:22:30 -08:00
Tereza Tomcova
38b14fc912
Include shell.h only for Windows
2016-11-18 21:33:55 +01:00
Tereza Tomcova
ac9e0b458d
Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command
2016-11-18 21:33:55 +01:00
deepak1556
0410a184ce
webContents: handle POST navigation for new windows
2016-11-11 10:53:00 -08:00
gellert
5e62d28e50
adds test, adds view to AtomNSWindow and minor fixes
2016-11-11 08:49:57 -08:00
gellert
2cf30c0d63
remove method transferred to set with null
2016-11-11 08:49:57 -08:00
gellert
8ad50d1e35
adds vibrancy effect for macos
2016-11-11 08:49:57 -08:00
Cheng Zhao
dfefa00a50
Merge pull request #7577 from thomsonreuters/net_module
...
net module
2016-10-31 10:31:56 +09:00
ali.ibrahim
6d92457095
Fixing code review issues: refactoring emit methods using CustomEmit.
2016-10-26 11:10:15 +02:00
Kevin Sawicki
d85c4da11b
Minor formatting tweaks
2016-10-26 09:55:34 +09:00
Kevin Sawicki
d982376fc4
filename -> displayName
2016-10-26 09:47:38 +09:00
Pierre Laurac
9b19e6ee38
Changing names and memory leak fix
2016-10-26 09:05:42 +09:00
Pierre Laurac
6bac17fb9a
Linter
2016-10-26 09:05:36 +09:00
Pierre Laurac
b44371f4bf
filename as Optional argument
2016-10-26 09:05:01 +09:00
Pierre Laurac
18ac4178fe
Validation with linter
2016-10-26 09:04:22 +09:00
Pierre Laurac
9673cee4d7
Using string from the std
2016-10-26 09:02:36 +09:00
Pierre Laurac
526debb5ab
Adding easy way to preview files
2016-10-26 09:02:29 +09:00
Pierre Laurac
fb444f646b
default template for PreviewFile
2016-10-26 09:02:21 +09:00
ali.ibrahim
bdb3f4d4cb
Fixing code review issues: adding some test cases for partition/session options.
2016-10-25 16:19:26 +02:00
ali.ibrahim
b44d5290e2
Fixing code review issues: adding a partition options and making the session option only takes Session objects.
2016-10-25 15:47:54 +02:00
ali.ibrahim
6d7f179a9b
Fixing code review issues: making delegate_ a raw pointer.
2016-10-25 15:02:35 +02:00
ali.ibrahim
61278f9ace
Fixing code review issues.
2016-10-25 12:41:01 +02:00
ali.ibrahim
7f8b180f70
Fixing authentication cancel with null/undefined credentials.
2016-10-20 11:43:26 +02:00
ali.ibrahim
c198828e58
Adding gc tests: fixing a memory leak with C++ URLRequest objects.
2016-10-17 19:02:25 +02:00
ali.ibrahim
ac9e6eda95
Fixing a crash with pending URLRequests on shutdown.
2016-10-14 17:37:39 +02:00
ali.ibrahim
c0c9e3ac3d
Formatting C++ code using ClangFormat.
2016-10-14 11:51:45 +02:00
ali.ibrahim
4347ce4a53
Formatting C++ code using ClangFormat.
2016-10-14 11:50:47 +02:00
ali.ibrahim
9cc8bfae1c
fixing space formatting issues.
2016-10-14 10:58:16 +02:00
ali.ibrahim
de29f2dde5
Fixing build: removing constness on net::HttpResponseHeaders as otherwise we would need a change in libchromiumcontent.
2016-10-13 17:51:19 +02:00
ali.ibrahim
6f5b0a28c5
Fixing code review issues: function call formatting, renaming JS member variables, refactoring response headers conversion.
2016-10-13 17:14:23 +02:00
ali.ibrahim
b290415bbd
Fixing build on Mac OS
2016-10-12 19:41:13 +02:00
ali.ibrahim
16069cd477
Commenting some test code.
2016-10-12 17:13:06 +02:00
ali.ibrahim
ae1c33b863
fixing linter issues.
2016-10-12 14:54:32 +02:00
ali.ibrahim
b731ca50bc
Adding HTTP request headers manipulation tests.
2016-10-12 14:54:30 +02:00
Ali Ibrahim
046f48db51
Fixing build on Linux
2016-10-12 14:54:28 +02:00
ali.ibrahim
42bae9d71d
Making the HTTP response a full-fledged Readable stream.
2016-10-12 14:54:27 +02:00
ali.ibrahim
8c5751e9f7
Adding systematic checks on the atom_request_ pointer as it may be reset to null.
2016-10-12 14:54:26 +02:00
ali.ibrahim
a655cca0a1
Request/Response state simplification. Removing redundant state flags.
2016-10-12 14:54:25 +02:00
ali.ibrahim
e472d11761
Caching response headers so that AtomURLRequest can be freed after the close event.
2016-10-12 14:54:25 +02:00
ali.ibrahim
ec1fc5a17b
Implementing error, close, finish, abort events management.
2016-10-12 14:54:24 +02:00
ali.ibrahim
bde30b90e8
Adding some implementation comments. Enforcing Chromium coding conventions.
2016-10-12 14:54:23 +02:00
ali.ibrahim
0588435882
Fixing cpplint issues.
2016-10-12 14:54:22 +02:00
ali.ibrahim
08947682b0
Implementing abort workflow, emitting error events.
2016-10-12 14:54:21 +02:00
ali.ibrahim
cbbc4376ca
Adding support for upload chunked encoding.
2016-10-12 14:54:20 +02:00
ali.ibrahim
9498a5738a
Refactoring net module, adding a ClientRequest and IncomingMessage classes.
2016-10-12 14:54:20 +02:00
ali.ibrahim
fcaf9cb031
Some code cleaning.
2016-10-12 14:54:19 +02:00
ali.ibrahim
f7525d7877
Adding support for POST requests.
2016-10-12 14:54:18 +02:00
ali.ibrahim
2b3b41d5f9
Implementing authentication callback.
2016-10-12 14:54:18 +02:00
ali.ibrahim
2d9d4af98d
Implementing URLRequest API, getting response body.
2016-10-12 14:54:17 +02:00
ali.ibrahim
81eab9887b
Adding URLResponse to emit response events, implementing status code.
2016-10-12 14:54:16 +02:00
ali.ibrahim
7521aeea09
Implement URLRequest::Delegate, handle thread sync.
2016-10-12 14:54:15 +02:00
ali.ibrahim
e8d4abe78f
Adding net module and URLRequest class.
2016-10-12 14:54:15 +02:00
Kevin Sawicki
c8189046fe
Emit color-changed event on Windows
2016-10-11 13:15:27 -07:00
Kevin Sawicki
1978b39337
Remove duplicate colors
2016-10-11 13:15:27 -07:00
Kevin Sawicki
663f8f4b54
Add systemPreferences.getColor on Windows
2016-10-11 13:15:26 -07:00
Kevin Sawicki
9b0a32f62c
Add ToRGBHex color helper
2016-10-11 13:15:26 -07:00
Cheng Zhao
4ae190dab9
Merge pull request #7549 from electron/about-panel-options
...
Support setting about panel options
2016-10-11 20:18:23 +09:00
Kevin Sawicki
7de6a06acf
Support setting about panel options
2016-10-10 13:30:58 -07:00
Kevin Sawicki
38281f3364
Implement SysColorChangeListener directly on Windows
2016-10-10 10:43:09 -07:00
Kevin Sawicki
25bcc2dd0d
🎨
2016-10-10 10:43:09 -07:00
Kevin Sawicki
af27c62b07
Doc inverted-color-scheme-changed event
2016-10-10 10:43:08 -07:00
Kevin Sawicki
8b16b82ce9
Add inverted-color-scheme-changed event
2016-10-10 10:43:08 -07:00
Kevin Sawicki
7b49d94e9f
Add systemPreferences.isInvertedColorScheme API
2016-10-10 10:43:08 -07:00
Cheng Zhao
91591f37e6
Merge pull request #7500 from electron/store-crashes-in-configured-temp-dir
...
Store crash reports in configured temp dir
2016-10-10 10:19:02 +09:00
Kevin Sawicki
c37740273f
Add linux guard for SetGlobalAppName call
2016-10-07 13:44:54 -07:00
deepak1556
12fb9f1f18
media: set the application name for audio streams shown in external apps
2016-10-07 16:15:30 +05:30
Kevin Sawicki
30c6ca6751
Only call UTF8ToUTF16 on Windows
2016-10-06 09:14:16 -07:00
Michael Vasseur
c811188e22
Updated required code to handle missing additional features for popup windows
2016-10-04 14:38:32 +09:00
Kevin Sawicki
8abe8fe01d
Remove unneeded locker and handle scope
2016-09-29 09:16:35 -07:00
Kevin Sawicki
77b35ba7ab
Use separate session for cookies change event test
2016-09-29 09:16:35 -07:00
Kevin Sawicki
19c7ee0932
Use scoped_refptr for cookie delegate
2016-09-29 09:16:35 -07:00
Kevin Sawicki
24bcf6ac16
Add initial cookie changed event support
2016-09-29 09:16:29 -07:00
Cheng Zhao
de76bf5f63
Merge pull request #7296 from adammeyer/custom-window-level
...
Allow custom window level when sending window to top
2016-09-28 19:18:12 +08:00
Thiago de Arruda
a64978b812
Use the routing id on api::WebContents::GetID
...
The sandbox option allows multiple webContents in one renderer process, so using
the only the renderer id to identify WebContents instances is no longer an
option.
WebContents::GetID now returns a 64-bit integer, which is composed of both the
process id(high 32), and the RenderViewHost routing id(low 32). Also add a
`GetProcessID` that retrieves the renderer process id, a requirement in some of
our javascript code.
2016-09-27 06:01:47 -03:00
Thiago de Arruda
06cc9a44fe
Add support for native chromium popups on sandboxed renderers.
...
- Allow `api::Window` instances to be created from existing `api::WebContents`.
- Override `WebContentsCreated` and `AddNewContents` to wrap renderer-created
`content::WebContents` into `api::WebContents`.
- For `content::WebContents` that should be displayed in new windows, pass the
wrapped `api::WebContents` object to window manager.
2016-09-27 06:01:46 -03:00
Thiago de Arruda
0b3b29938f
Allow api::WebContents to fully wrap an existing content::WebContents.
...
- Add an overload to `WebContents::CreateFrom` that accepts a type parameter. If
type is `REMOTE`, initialization is the same as before(a thin wrapper). If
not, the `api::WebContents` will be fully initialized, as if it was created by
`api::WebContents::Create`.
- Move common initialization code to `InitWithSessionAndOptions`.
2016-09-27 06:01:46 -03:00
Thiago de Arruda
1b1541fe1a
Decouple api::Window initialization from api::WebContents construction.
2016-09-27 06:01:46 -03:00
adammeyer
783d47f78b
custom window level as string
2016-09-21 22:49:06 -04:00
adammeyer
fbb3a288ec
Allow custom window level when sending window to top
2016-09-21 13:35:59 -04:00
Cheng Zhao
30a6b597a5
Merge pull request #7239 from darkdh/6873
...
Emit scroll-touch-edge event instead of changing the behavior of scrollll-touch-begin/end
2016-09-20 14:51:10 +09:00
Cheng Zhao
e3e450613d
Merge pull request #7157 from Mossop/moveguest
...
Allow moving a webcontents to a different webview
2016-09-20 14:28:42 +09:00
Samuel Attard
456f102cdc
Fix k typo
2016-09-20 02:42:41 +10:00
Samuel Attard
1454510549
Alphabetical method ordering
2016-09-20 02:41:26 +10:00
Samuel Attard
5dd5dbb3d8
Add a systemPreferences API method to fetch the system ColorizationColor
...
This is useful for automatical app theming
* Fetches the color from the registry
* Returns an empty string if the fetch fails (a falsey value)
2016-09-20 02:41:26 +10:00
Cheng Zhao
26004f1a66
Merge pull request #7241 from miniak/crashed-killed
...
Add killed argument for webContents.on("crashed") and app.on("gpu-process-crashed") events
2016-09-19 16:02:52 +09:00
Cheng Zhao
a260647b4f
Merge pull request #7062 from MaxWhere/osr-sizing-fix
...
Offscreen invalidate and sizing fix
2016-09-19 15:38:11 +09:00
Milan Burda
8567f79e67
Add killed argument for webContents.on("crashed") and app.on("gpu-process-crashed") events
2016-09-17 17:02:36 -07:00
Anthony Tseng
269a87b26f
Emit scroll-touch-edge event instead of changing the behavior of scroll-touch-begin/end
...
fix #6873
2016-09-17 22:50:10 +08:00
gellert
b4c220613f
adds invalidate method and proper resizing
2016-09-16 23:27:11 +02:00
Kevin Sawicki
0c3ad527e3
initialize -> require
2016-09-16 13:09:06 -07:00
Kevin Sawicki
577394442b
power-monitor -> powerMonitor
2016-09-16 09:58:27 -07:00
Cheng Zhao
da677b683b
Merge pull request #7163 from MaxWhere/frame-sub-scale-fix
...
Frame subscriber improvements
2016-09-16 21:24:53 +09:00
deepak1556
e7f1265b64
add save-to-disk disposition for new-window event
2016-09-16 16:30:26 +05:30
deepak1556
94faaf7d58
provide a default file name for downloads
2016-09-16 16:02:57 +05:30
gellert
64e53a17bd
reverts subscriber api
2016-09-16 11:18:15 +02:00
Cheng Zhao
9714348260
Merge pull request #6941 from deepak1556/blob_data_patch
...
protocol: provide blob uuid with uploadData
2016-09-16 17:01:15 +09:00
Cheng Zhao
fbac635687
Only emit finalUpdate found-in-page events
...
Since Chrome 53 all meaningful results of found-in-page are finalUpdate.
2016-09-14 16:23:01 +09:00
Cheng Zhao
5708e86a05
Fix API change of findInPage API
2016-09-14 16:23:00 +09:00
Cheng Zhao
6d8f900916
Fix building on Windows
2016-09-14 16:22:43 +09:00
Cheng Zhao
f28e8d7168
Fix API changes of Chrome 53
2016-09-14 16:22:43 +09:00
Cheng Zhao
4eba8094d4
Merge pull request #7096 from minggo/add-option-to-disable-devtools
...
add option to disable devtools
2016-09-13 16:01:56 +09:00
gellert
2435f1b660
lint fix
2016-09-09 23:50:01 +02:00
gellert
d3dc66e308
adds scale factor check and simplifies frame subscription
2016-09-09 23:17:17 +02:00
Dave Townsend
313b2faa3c
Add a guestinstance attribute to webviews reflecting their current guest
...
instance ID and allowing moving a guest instance to a new webview.
2016-09-09 10:32:05 -07:00
Cheng Zhao
b6079ff90b
Merge pull request #7053 from electron/launch-from-notification
...
Send notification info to app.ready, on macOS
2016-09-09 20:01:39 +09:00
Kevin Sawicki
224d3aef3e
Mark detach option for 2.0 removal
2016-09-08 09:05:49 -07:00
minggo
3fdc99c3c6
change the option name to devTools
2016-09-07 10:16:52 +08:00
minggo
7d712b77ba
remove duplicate comment
2016-09-07 09:43:06 +08:00
minggo
91fb85947d
WebContents::InspectElement and WebContents::InspenctServiceWorker return immediately if DevTools is disabled
2016-09-06 17:53:42 +08:00
minggo
baa55caf83
remove unneeded whitespace
2016-09-06 11:48:48 +08:00
minggo
19f6811312
initialize disable_devtools_
2016-09-06 11:08:50 +08:00
minggo
1f1180f857
use webPreferences to disable devtools
2016-09-05 18:25:57 +08:00
minggo
0d7e7be748
add option to disable devtools
2016-09-05 16:27:56 +08:00
Cheng Zhao
14f625d61b
Merge pull request #6826 from enlight/set-jump-list
...
Extend the custom Jump List API provided by Electron
2016-09-01 15:35:21 +09:00
deepak1556
7b85ca0301
create helper class to read blob data
2016-09-01 08:52:44 +05:30
Vadim Macagon
c64294cf60
Extend the custom Jump List API
...
Add `app.getJumpListSettings()` and `app.setJumpList(callback)` that
make it possible to fully customize the Jump List of an Electron app.
It is now possible to:
- Add tasks to the standard `Tasks` category.
- Add separators to the standard `Tasks` category.
- Add custom categories containing tasks and file links.
- Add system managed Recent/Frequent categories.
- Remove the custom Jump List.
2016-09-01 09:56:14 +07:00
Charlie Hess
af9e010162
Send notification userInfo to app.ready, on macOS.
...
Check if the user launched the app from a notification and send the notification args across if so.
2016-08-31 17:17:44 -07:00
deepak1556
5cbc8d5c71
fix ambiguous constructor call
2016-09-01 01:01:52 +05:30
deepak1556
d2e40d4fc1
update api to work on public url and uuid
2016-09-01 01:01:52 +05:30
deepak1556
0fb2339e3d
session: api to retrieve blob data from uuid
2016-09-01 01:01:52 +05:30
Cheng Zhao
ee1571e556
Revert "exit tab fullscreen on destroy"
2016-08-30 17:08:51 +09:00
Cheng Zhao
b5dec9990e
Merge pull request #7003 from brave/exit-tab-fullscreen
...
exit tab fullscreen on destroy
2016-08-29 16:36:44 +09:00
bridiver
4532114965
exit tab fullscreen on destroy
2016-08-26 15:52:15 -07:00
Kevin Sawicki
6285500cdc
Sort includes alphabetically
2016-08-26 15:30:02 -07:00
Kevin Sawicki
7a0129bbc7
Correct misspelling of destroy in method name
2016-08-25 12:28:57 -07:00
Kevin Sawicki
21de91d6e2
Don't open dev tools if already initialized
2016-08-23 15:26:13 -07:00
Kevin Sawicki
463b3de199
Use correct GetToplevelWindow signature
2016-08-23 10:12:55 -07:00
Kevin Sawicki
dd5ee28b2f
Access window through native view
2016-08-23 09:51:54 -07:00
Kevin Sawicki
0485e9eb36
🎨 Go back to single line declaration
2016-08-22 16:26:31 -07:00
Kevin Sawicki
ad3dc3766e
Default network values to 0.0
2016-08-22 14:19:09 -07:00
Mark Wylde
c55b1e87ed
Fix spelling mistake from registred to registered
2016-08-20 14:25:13 +01:00
Cheng Zhao
06d2dfe119
Merge pull request #6788 from electron/felix-progress-enum
...
Use enum to declare ProgressState
2016-08-18 14:35:00 +09:00
Cheng Zhao
56d17a1449
Merge pull request #6829 from electron/fix-thumbar-buttons-vanishing
...
Save the thumbar buttons when setting them to restore later
2016-08-18 14:34:26 +09:00
Cheng Zhao
8f9a0100e3
Certificate data is now a string
2016-08-17 20:48:09 +09:00
Kevin Sawicki
0755349e70
Ensure hidden windows don't have focused webContents
2016-08-15 14:13:24 -07:00
Samuel Attard
2fa7aa3c71
Save the thumbar buttons when setting them
...
Then restore the buttons when restoring the taskbar icon
2016-08-13 01:55:42 +10:00
Samuel Attard
5b07e8dd5b
Send isMainFrame as argument to did-navigate-in-page event
2016-08-12 01:27:50 +10:00
Felix Rieseberg
8b85ee8a20
🔧 Use enum to declare ProgressState
...
As recommended in #6768 , this commit adds an enum for progress states for windows.
2016-08-10 08:56:26 -07:00
Cheng Zhao
6cd99ebf6b
Merge pull request #6752 from lgalabru/feature/macos-native-notifications
...
Send events as native macOS notifications
2016-08-09 21:34:52 +09:00
Cheng Zhao
81244c2221
Merge pull request #6768 from electron/felix-set-progress
...
Enable mode indication for setProgressBar
2016-08-09 20:58:07 +09:00
Ludovic Galabru
a5351407c5
Fixing indentation
2016-08-09 05:57:02 -04:00
Felix Rieseberg
73c91dae9e
🔧 Enable mode indication for setProgressBar
...
This commit enables setting a mode for the setProgressBar method.
Old behavior is kept intact, usage is entirely optional.
2016-08-08 15:52:20 -07:00