Milan Burda
c77e187742
chore: fix "creates offscreen window with correct size" spec on Mac with Retina display ( #16867 )
2019-02-11 10:35:46 -08:00
Milan Burda
7a3d220347
refactor: implement Chrome Extension APIs without the remote module ( #16686 )
...
* refactor: implement Chrome Extension APIs without the remote module
* remove unused potentiallyRemoteRequire
2019-02-10 10:38:14 -08:00
Shelley Vohr
1898f91620
fix: enable property having no effect on submenus ( #16835 )
2019-02-08 18:07:08 -08:00
Cheng Zhao
d16b581140
fix: remove memory leak when using webFrame and spell checker ( #16770 )
...
* fix: do not create native api::WebFrame in webFrame
When reloading a page without restarting renderer process (for example
sandbox mode), the blink::WebFrame is not destroyed, but api::WebFrame
is always recreated for the new page context. This leaves a leak of
api::WebFrame.
* fix: remove spell checker when page context is released
2019-02-08 13:38:31 -08:00
Milan Burda
3f52e18a38
chore: add menu-will-close comment explaining setTimeout ( #16794 )
2019-02-08 13:38:03 -08:00
Electron Bot
70042d2597
Bump v6.0.0-nightly.20190208
2019-02-08 13:28:42 -08:00
Jeremy Apthorp
72f3a22ecc
docs: reorder crashReporter notes to make more sense ( #16825 )
...
the note about reports from child processes on Windows should be next to the code snippet.
Side note: is that code even still necessary?
2019-02-08 13:26:59 -08:00
Shelley Vohr
c80c3c18dc
Revert "Bump v6.0.0-nightly.20190207"
...
This reverts commit c8282efb75
.
2019-02-08 13:26:18 -08:00
Samuel Attard
10607f7e86
chore: make crash-reporter specs not use URL module ( #16840 )
2019-02-08 13:22:07 -08:00
Shelley Vohr
ccf46a57bc
fix: display empty menu item for non-visible submenus ( #16832 )
...
* fix: display empty menu item for nonvisible submenus
* use Chromium UI string ID
2019-02-08 13:19:01 -08:00
Shelley Vohr
062778c031
fix: don't construct submenu if it's invisible ( #16834 )
2019-02-08 12:54:39 -08:00
Samuel Attard
833daaa2b2
chore: add helper to wait for a window to load in a remote-safe way ( #16837 )
2019-02-08 12:26:03 -08:00
Milan Burda
1632c4b837
refactor: implement chrome.i18n.getMessage() without the remote module ( #16739 )
...
* refactor: implement chrome.i18n.getMessage() without the remote module
* replace navigator.language with app.getLocale()
2019-02-08 12:07:09 -08:00
Roller Bot
b97f6bd7d4
chore: bump chromium in DEPS to 72.0.3626.102 ( #16830 )
2019-02-08 10:36:37 -08:00
Samuel Attard
23b84917e0
ci: set MAS_BUILD=true on mas builds ( #16824 )
2019-02-08 10:12:18 -08:00
Shelley Vohr
e790dbd737
chore: add standalone function deprecation helper ( #16782 )
2019-02-08 09:50:11 -08:00
Electron Bot
c8282efb75
Bump v6.0.0-nightly.20190207
2019-02-07 14:13:50 -08:00
Julien Isorce
27bd47a333
feat: implement BrowserWindow.moveTop on X11 ( #16629 )
...
It was implemented on Mac and Win but not on X11.
Tested on Ubuntu 16.04 and 18.04.
Also added a unit test in spec/api-browser-window-spec.js.
This test BrowserWindow.moveTop verifies that calling moveTop
on a window does not give the focus to this window.
notes: BrowserWindow.moveTop is now available on Linux/x11
https://github.com/electron/electron/issues/12516
2019-02-07 12:48:19 -08:00
Samuel Attard
db11b9b13b
fix: restore accidentally removed chrome-extension require ( #16819 )
2019-02-07 12:38:57 -08:00
Jeremy Apthorp
4989ecc5e0
chore: re-export chromium patches ( #16818 )
...
this is the changeset from running import-patches && export-patches. should be idempotent now.
2019-02-07 12:03:25 -08:00
Shelley Vohr
9ebba76c03
chore: improve existing error preservation in promisify ( #16815 )
...
This PR better preserves existing behavior in `deprecate.promisify()` in the cases where the promise fails. Previously, if a callback was only called with `data` instead of `err, data` and the promise was rejected, `data` would be populated with `err`, which could be confusing to users. This makes it such that `err` is called back on promise rejection if a callback is called with `err, data` a la Node.js.
2019-02-07 10:25:20 -08:00
Samuel Attard
4f8ebafa97
chore: dont log 100000000 chars of URL ( #16800 )
2019-02-07 08:50:47 -08:00
Shelley Vohr
29501dbd01
Revert "Bump v6.0.0-nightly.20190206"
...
This reverts commit e8608c2dbd
.
2019-02-06 18:23:14 -08:00
Electron Bot
acabf6f5ab
Bump v6.0.0-nightly.20190206
2019-02-06 16:52:57 -08:00
Shelley Vohr
c6fc5a23fc
Revert "build: hack around GitHub upload API failure / flake ( #16663 )" ( #16802 )
...
This reverts commit ab503c7e43
.
2019-02-06 16:51:45 -08:00
Shelley Vohr
c8a1231ad7
Revert "Bump v6.0.0-nightly.20190206"
...
This reverts commit 2d1438456b
.
2019-02-06 16:23:08 -08:00
Jeremy Apthorp
6d68026c6c
chore: fix ts config to not complain about extraneous files ( #16790 )
2019-02-06 15:46:10 -08:00
Electron Bot
2d1438456b
Bump v6.0.0-nightly.20190206
2019-02-06 15:11:34 -08:00
Roller Bot
dd5264b4d1
chore: bump chromium in DEPS to 72.0.3626.99 ( #16779 )
2019-02-06 14:50:58 -08:00
Electron Bot
e8608c2dbd
Bump v6.0.0-nightly.20190206
2019-02-06 14:43:32 -08:00
Shelley Vohr
a569dad8c5
build: remove non-arm vstsJobs ( #16793 )
2019-02-06 13:36:17 -08:00
Samuel Attard
17c240a639
ci: make macOS CI faster ( #16766 )
...
* ci: cache brew update result
* ci: checkout and sync the macOS build on a linux machine for speed
2019-02-06 13:16:11 -08:00
Samuel Attard
fc06458038
ci: run lint on CircleCI ( #16791 )
2019-02-06 12:53:25 -08:00
Shelley Vohr
84eef16755
chore: depend on mojo audio and video in BUILD.gn ( #16785 )
2019-02-06 11:03:39 -08:00
pol
c76459738e
docs: fix security doc url check ( #16775 )
2019-02-06 10:43:58 -08:00
Gilbert Emerson
76d919fff5
docs: added webContents.getType() method ( #16767 )
...
* docs: added webContents.getType() method
* docs: add enumeration of return value for webContents.getType()
* docs: getType() in WebContents should be class method not module method
2019-02-06 10:42:34 -08:00
Samuel Attard
26df9992cf
build: use typescript for internal Electron JS code ( #16441 )
2019-02-06 10:27:20 -08:00
Shelley Vohr
858781ba83
feat: allow Menu.buildFromTemplate() to accept MenuItems ( #16697 )
...
* feat: allow Menu.buildFromTemplate to accept MenuItems
* add another spec
* fix linter error
* add submenu spec
2019-02-06 10:04:40 -08:00
Milan Burda
4211a9c69f
refactor: use ipcRendererUtils.invokeSync / ipcMainUtils.handleSync ( #16759 )
2019-02-06 09:53:28 -08:00
Jeremy Apthorp
b7d8234a86
docs: add some troubleshooting info related to win_delay_load_hook ( #16764 )
...
* docs: add some troubleshooting info related to win_delay_load_hook
* appease lint
2019-02-06 08:29:58 -08:00
Cheng Zhao
d53b51607c
fix: do not increase ref-counting in wrong thread ( #16738 )
2019-02-06 18:22:02 +09:00
Heilig Benedek
ff461d9d26
fix: make getUserMedia APIs work again on C72+ ( #16763 )
...
* fix: resolve macos check for video and audio capture devices
* fix: resolve a minor compilation error
2019-02-05 21:25:42 -08:00
Jeremy Apthorp
b7afec0743
docs: improve app.commandLine
documentation ( #16757 )
2019-02-05 16:22:25 -08:00
Shelley Vohr
8946cfd4f1
chore: fix dependency vulnerabilities ( #16756 )
2019-02-05 15:19:55 -08:00
Shelley Vohr
793d6c3691
chore: remove release notes semantic PR map ( #16758 )
2019-02-05 15:19:26 -08:00
Samuel Attard
b29e8d18a8
chore: auto-format GN and python files in our precommit ( #16722 )
...
* chore: auto-format GN files in our precommit
* chore: update python linting errors and auto-lint python files
* chore: add trick for CHROMIUM_BUILDTOOLS_PATH
* chore: apply suggestions from code review
Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>
2019-02-05 13:54:45 -08:00
Milan Burda
6d674eebb1
refactor: crashReporterInit ( #16729 )
2019-02-05 12:56:44 -08:00
Roller Bot
c486ab207a
chore: bump chromium in DEPS to 72.0.3626.94 ( #16745 )
2019-02-05 12:17:12 -08:00
Samuel Attard
b202ad1e24
refactor: remove js2asar.py and port logic to JS in more readable / GN-style way ( #16718 )
...
* refactor: remove js2asar.py and port logic to JS in more readable / GN-style way
* refactor: further clean up ASAR impl, add new node_action GN template
2019-02-05 12:10:15 -08:00
Samuel Attard
8582325e85
build: ensure index.json is actually valid JSON before uploading ( #16518 )
...
* build: ensure index.json is actually valid JSON before uploading
* chore: fix py linting for validation of index.json
2019-02-05 11:36:31 -08:00