trop[bot]
9ca68e2b8c
perf: build g_dgettext domain name at compile time ( #43987 )
...
perf: build GettextPackage name at compile time
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 17:07:21 -05:00
trop[bot]
9ef7ec02e5
fix: replace deprecated libnotify API calls ( #43983 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 13:59:21 -04:00
electron-roller[bot]
e32e85abb2
chore: bump chromium to 130.0.6723.19 (33-x-y) ( #43975 )
...
* chore: bump chromium in DEPS to 130.0.6723.19
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-26 12:47:11 -04:00
trop[bot]
6973af4f7a
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43980 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 11:21:24 -05:00
John Kleinschmidt
625d950e32
docs: document breaking change in 33, not 32 ( #43977 )
2024-09-26 09:07:04 -04:00
electron-roller[bot]
d62097e067
chore: bump chromium to 130.0.6723.6 (33-x-y) ( #43453 )
...
* chore: bump chromium in DEPS to 130.0.6673.0
* chore: bump chromium in DEPS to 130.0.6675.0
* chore: bump chromium in DEPS to 130.0.6677.2
* chore: bump chromium in DEPS to 130.0.6679.1
* chore: bump chromium in DEPS to 130.0.6681.1
* chore: bump chromium in DEPS to 130.0.6683.2
* chore: bump chromium in DEPS to 130.0.6685.0
* chore: bump chromium in DEPS to 130.0.6687.0
* chore: bump chromium in DEPS to 130.0.6689.0
* chore: bump chromium in DEPS to 130.0.6691.1
* chore: bump chromium in DEPS to 130.0.6693.1
* chore: bump chromium in DEPS to 130.0.6695.1
* chore: bump chromium in DEPS to 130.0.6697.1
* chore: bump chromium in DEPS to 130.0.6699.1
* chore: bump chromium in DEPS to 130.0.6701.1
* chore: bump chromium in DEPS to 130.0.6703.1
* chore: bump chromium in DEPS to 130.0.6705.1
* chore: bump chromium in DEPS to 130.0.6707.1
* chore: bump chromium in DEPS to 130.0.6709.1
* chore: bump chromium in DEPS to 130.0.6711.1
* chore: bump chromium in DEPS to 130.0.6713.1
* chore: bump chromium in DEPS to 130.0.6715.2
* chore: bump chromium in DEPS to 130.0.6717.0
* chore: bump chromium in DEPS to 130.0.6719.1
* chore: bump chromium in DEPS to 130.0.6720.1
* chore: bump chromium in DEPS to 130.0.6723.1
* chore: bump chromium in DEPS to 130.0.6723.4
* chore: bump chromium in DEPS to 130.0.6723.6
* chore: bump chromium to 130.0.6695.0 (main) (#43454 )
* chore: bump chromium in DEPS to 130.0.6673.0
* chore: bump chromium in DEPS to 130.0.6675.0
* chore: bump chromium in DEPS to 130.0.6677.2
* chore: bump chromium in DEPS to 130.0.6679.0
* 5802981: [Partitioned Popins] UKM
https://chromium-review.googlesource.com/c/chromium/src/+/5802981
* 5799275: ash: Create //chrome/browser/ui/ash/web_view
https://chromium-review.googlesource.com/c/chromium/src/+/5799275
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5805208: Move third_party/jacoco to a cipd/ subdirectory.
https://chromium-review.googlesource.com/c/chromium/src/+/5805208
* chore: fixup patch indices
* 5771091: Introduce InputManager class for handling input in Viz.
https://chromium-review.googlesource.com/c/chromium/src/+/5771091
* 5498921: [Permission] Remove SubscribeToPermissionStatusChange from PermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5498921
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5801311: Don't use int for bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5801311
* 5548827: [Web Install] Define the web-app-installation PermissionPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/5548827
* 5786325: Add Infrastructure for Hand tracking permission
https://chromium-review.googlesource.com/c/chromium/src/+/5786325
* chore: fixup patch indices
* chore: bump chromium in DEPS to 130.0.6681.0
* [Views AX] Move BrowserAccessibility* to //ui/accessibility/platform
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5520052
* chore: e patches all
* Don't have default arguments on virtual functions in render_frame_host.h
https://chromium-review.googlesource.com/c/chromium/src/+/5809399
* test: log if loadURL fails in base url test
* chore: bump chromium in DEPS to 130.0.6683.2
* chore: fix support_mixed_sandbox_with_zygote.patch
content: restore old DisableJit behavior
https://chromium-review.googlesource.com/c/chromium/src/+/5804255
* chore: update patch indices
* chore: bump chromium in DEPS to 130.0.6685.0
* Parallel process launching
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* chore: update feat_expose_documentloader_setdefersloading_on_webdocumentloader.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 130.0.6687.0
* chore: bump chromium in DEPS to 130.0.6689.0
* chore: bump chromium in DEPS to 130.0.6691.0
* chore: bump chromium in DEPS to 130.0.6693.0
* chore: update patches
* chore: bump chromium in DEPS to 130.0.6695.0
* chore: free up macos disk space as soon as possible
* 5824143: Use checked in source lists for third_party/boringssl
https://chromium-review.googlesource.com/c/chromium/src/+/5824143
* chore: update patches
* 5824122: Extensions: Add a new view type enum for developer tools contexts
https://chromium-review.googlesource.com/c/chromium/src/+/5824122
* 5806109: Option for JavaScriptExecuteRequestForTests() to ignore content settings
https://chromium-review.googlesource.com/c/chromium/src/+/5806109
* build: free up disk space on gn check too
* 5799369: [Refactoring] Make allow_http1_for_streaming_upload flags false.
https://chromium-review.googlesource.com/c/chromium/src/+/5799369
* fixup! 5015584: Parallel process launching | https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* Disable failing test for short-term
See: https://github.com/electron/electron/issues/43730
* oops
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
(cherry picked from commit 4bcbc955dd#43772 )
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
(cherry picked from commit 02fd8bbcc1https://chromium-review.googlesource.com/c/chromium/src/+/5844369
(cherry picked from commit 0ac4852763f0dce3468d30907620211f34c4104b)
* (multiple CLs): Use an opaque type for FrameTreeNode IDs
5807683: Use an opaque type for FrameTreeNode IDs, part 1 | https://chromium-review.googlesource.com/c/chromium/src/+/5807683
5829746: Use an opaque type for FrameTreeNode IDs, part 2 | https://chromium-review.googlesource.com/c/chromium/src/+/5829746
5836903: Use an opaque type for FrameTreeNode IDs, part 7 | https://chromium-review.googlesource.com/c/chromium/src/+/5836903
5837249: Use an opaque type for FrameTreeNode IDs, part 8 | https://chromium-review.googlesource.com/c/chromium/src/+/5837249
5836564: Use an opaque type for FrameTreeNode IDs, part 12 | https://chromium-review.googlesource.com/c/chromium/src/+/5836564
5837180: Use an opaque type for FrameTreeNode IDs, part 15 | https://chromium-review.googlesource.com/c/chromium/src/+/5837180
(cherry picked from commit 1dd67f5241a3a24ea5a20f11efefdd2afc520a26)
* 5822889: [task] Make GetForegroundTaskRunner non-virtual
https://chromium-review.googlesource.com/c/v8/v8/+/5822889
(cherry picked from commit ae1e7232a35260cce8c4303d5f9809aa166bf19b)
* 5833297: Remove unused inner WebContents attach params
https://chromium-review.googlesource.com/c/chromium/src/+/5833297
(cherry picked from commit 390bb42e39eba66cd86221461d2822bbd85012df)
* 5806403: Shift PowerMonitor to non static
https://chromium-review.googlesource.com/c/chromium/src/+/5806403
(cherry picked from commit 128e3826e13768e89c7f5117de451ebd2b3ec9a4)
* 5666874: [3/N] Remove old OnPowerChange in PowerObserver
https://chromium-review.googlesource.com/c/chromium/src/+/5666874
(cherry picked from commit 6ea6ea14ae23ced6465b94fd753f8c80ced4b13b)
* 5829085: [v8] Differentiate between UserVisible and BestEffort task runners
https://chromium-review.googlesource.com/c/chromium/src/+/5829085
(cherry picked from commit 1db28ee4a51fb2593e4c11bcaa538a6524abe48c)
* 5791112: [webrtc] Use `c/b/permissions/system` for system permissions
https://chromium-review.googlesource.com/c/chromium/src/+/5791112
(cherry picked from commit 50d4a71923ca99653bf5733145bdc6e21f783b2d)
* fixup! (multiple CLs): Use an opaque type for FrameTreeNode IDs
(cherry picked from commit 9271130e160d479b3d286d295045b9d4acd2005c)
* fixup! 5791112: [webrtc] Use `c/b/permissions/system` for system permissions https://chromium-review.googlesource.com/c/chromium/src/+/5791112
(cherry picked from commit db2c8c69d0c7bdee881997847dfc3c8abf32197c)
* 5825636: [Extensions] Create WebContentsObservers with ExtensionsBrowserClient
https://chromium-review.googlesource.com/c/chromium/src/+/5825636
(cherry picked from commit f2c3d09ccd141dbe2f4b62957b72f98bf8a010ae)
* 5854811: Use kNotAllowedError instead of kSecurityError for Web MIDI
https://chromium-review.googlesource.com/c/chromium/src/+/5854811
* test: fix should support base url for data urls test
Caused by https://chromium-review.googlesource.com/c/chromium/src/+/5802682
* test: fixup extensions can cancel http requests
* chore: document custom protocol handling on Windows change due to Non-Special Scheme URLs shipping
https://chromium-review.googlesource.com/c/chromium/src/+/5802682
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
2024-09-26 11:12:12 +02:00
trop[bot]
ad8f2f8d5d
test: add tests dbus notification images ( #43946 )
...
* test: add tests dbus notification images
Provide a NativeImage icon in the notification tests and then inspect
the DBus message payload's `image_data` hint to see if it's correct.
This adds test coverage for LibnotifyNotification::Show() and for
GdkPixbufFromSkBitmap().
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: use the same notification_icon.png as in main
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 16:48:24 -05:00
trop[bot]
53cc8aef9b
fix: close all open sheets before closing window on macOS ( #43952 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <beutner.john@gmail.com>
2024-09-25 13:30:56 -05:00
trop[bot]
0ffafbc295
test: ensure sender-pid hint is set in Linux notifications ( #43949 )
...
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 13:09:32 -05:00
trop[bot]
134176a1d1
fix: detach native view when its removed from parent on macOS ( #43922 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cezary Kulakowski <cezary@openfin.co>
2024-09-25 13:17:59 +02:00
trop[bot]
d2bd4cf91c
fix: crash when focusing WebView webContents ( #43932 )
...
fix: crash when focusing WebView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-25 06:16:49 -05:00
trop[bot]
1af736bc15
fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() ( #43930 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 11:21:47 +02:00
trop[bot]
f609d77e29
refactor: add SerialChooserController::web_contents_ ( #43920 )
...
Add a `base::WeakPtr<WebContents>` field to SerialChooserController and
stop subclassing from WebContentsObserver. This follows the Observer docs:
> don't create a `WebContentsObserver` just to be able to check
> for a null `WebContentsObserver::web_contents()`.
> Use a `base::WeakPtr<WebContents>` instead.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-24 08:26:29 -05:00
trop[bot]
ae6d5c4661
refactor: hide printing impl details in api::WebContents ( #43917 )
...
* refactor: move api::WebContents::OnGetDeviceNameToUse() into an anonymous namespace
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move api::WebContents::OnPDFCreated() into an anonymous namespace
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unused #include
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-24 10:11:56 +02:00
trop[bot]
cdcfe49592
refactor: prefer member initializers in asar structs ( #43918 )
...
prefactor: prefer member initializers in asar::Archive
prefactor: prefer member initializers in asar::Archive::FileInfo
prefactor: prefer member initializers in asar::IntegrityPayload
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-24 10:11:50 +02:00
trop[bot]
d35b848f95
refactor: remove C-style void arg type for no-arg functions ( #43919 )
...
A small cleanup to remove use of the C-style function declaration idiom.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-24 00:36:20 -07:00
trop[bot]
ff65b58e2c
build: add support for fetching github token from sudowoodo ( #43886 )
...
* build: add support for fetching github token from sudowoodo
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* chore: update release notes cache for tests
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: support nightlies repo correctly
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: post token
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-23 11:07:20 -07:00
trop[bot]
dddcc09185
docs: navigation history example ( #43890 )
...
* docs: add fiddle example
Co-authored-by: Alice Zhao <alice@makenotion.com>
* docs: add tutorial guide
Co-authored-by: Alice Zhao <alice@makenotion.com>
* refactor: PR review comments
Co-authored-by: Alice Zhao <alice@makenotion.com>
* refactor: add eof
Co-authored-by: Alice Zhao <alice@makenotion.com>
* refactor: render navigation history and make demo better.
Co-authored-by: Alice Zhao <alice@makenotion.com>
* refactor: fix broken links
Co-authored-by: Alice Zhao <alice@makenotion.com>
* refactor: add eof newline
Co-authored-by: Alice Zhao <alice@makenotion.com>
* docs: review feedback :)
Co-authored-by: Alice Zhao <alice@makenotion.com>
* chore: lint add space around list
Co-authored-by: Alice Zhao <alice@makenotion.com>
* doc: transformURL
Co-authored-by: Alice Zhao <alice@makenotion.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
2024-09-23 11:02:52 -07:00
trop[bot]
8fa00dbe1a
docs: add advanced specification for Squirrel updater ( #43892 )
...
* docs: add advanced specification for Squirrel updater
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
* address feedback
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2024-09-23 11:02:28 -07:00
dependabot[bot]
eda8205424
build(deps): bump actions/setup-node from 4.0.3 to 4.0.4 ( #43847 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](1e60f620b9...0a44ba7841
2024-09-23 06:56:21 -07:00
dependabot[bot]
c4921d2592
build(deps): bump github/codeql-action from 3.26.3 to 3.26.8 ( #43841 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.3 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](883d8588e5...294a9d9291
2024-09-23 06:54:30 -07:00
dependabot[bot]
723015db29
build(deps): bump actions/upload-artifact from 4.3.6 to 4.4.0 ( #43836 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.6 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.6...50769540e7f4bd5e21e526ee35c689e35e0d6874 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:52:57 -07:00
dependabot[bot]
7d108a163f
build(deps): bump slackapi/slack-github-action from 1.26.0 to 1.27.0 ( #43844 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](70cd7be8e4...37ebaef184
2024-09-23 11:00:17 +02:00
trop[bot]
7f473f2fba
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #43820 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-22 07:11:49 -05:00
trop[bot]
95caa1f0bd
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() ( #43813 )
...
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add a DCHECK to confirm the BigBuffer is full
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-20 08:47:49 -05:00
trop[bot]
45a7a5d22c
fix: createWindow shouldn't load URL for webContents ( #43816 )
...
* fix: createWindow shouldn't load URL for webContents
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: add non about blank test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-20 08:47:30 -05:00
trop[bot]
3232505c55
docs: document Windows pitfall when updating patches ( #43814 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-20 00:30:35 -05:00
trop[bot]
b896dbb103
fix: third time screen sharing on macOS ( #43810 )
...
Because we used decrementing negative source ids for fake video id when
instantating a native macOS screen share picker, we eventually hit the
`DesktopMediaID::kFakeId = -3` in Chromium source code which displayed a
test green screen.
In this change we reserve our own fake id of `-4` and decrement the
window id integer for uniqueness instead.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Fedor Indutny <238531+indutny@users.noreply.github.com>
2024-09-19 22:12:19 -05:00
trop[bot]
3ee3844bdb
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43804 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-19 22:11:48 -05:00
trop[bot]
78ede09ecd
chore: fix compile issue about ambiguous error of multiple methods named 'highlight'. ( #43800 )
...
chore: fix ambiguous error of multiple methods named 'highlight'
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-09-19 07:20:56 -05:00
Charles Kerr
5c92ea76e9
refactor: reduce code duplication in gin_helper::Promise (33-x-y) ( #43778 )
...
refactor: reduce code duplication in gin_helper::Promise (#43716 )
* refactor: move scope scaffolding into SettletScope
idea stolen from SpellCheckScope
* refactor: move impl of PromiseBase::RejectPromise() to the cc file
* chore: remove unused #include
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-19 13:01:13 +02:00
Charles Kerr
68869c18cd
docs: update window customization tutorial (33-x-y) ( #43781 )
...
docs: update window customization tutorial (#43388 )
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
2024-09-19 10:00:36 +02:00
Charles Kerr
d3cfe7aacb
chore: iwyu mojom-forward header files (33-x-y) ( #43777 )
...
chore: iwyu mojom-forward header files (#43741 )
* chore: iwyu mojom.h headers
* fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
* fixup! fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
2024-09-19 09:58:45 +02:00
trop[bot]
753cf3d409
perf: hold V8FunctionInvoker args in a std::array ( #43793 )
...
perf: hold V8FunctionInvoker args in a std::array
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-18 18:45:39 -05:00
trop[bot]
3a4664f836
build: let darwin/mas run concurrently ( #43792 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-18 16:37:06 -07:00
trop[bot]
948a28fdb8
perf: hold Emit() arg arrays in a std::array ( #43776 )
...
* refactor: CallMethodWithArgs() now takes a span of value handles
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* perf: use std::array instead of std::vector to hold Emit arg parameter packs
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove unused gin_helper::EmitEvent(iso, obj, name, span<Local>)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-18 14:55:53 -04:00
trop[bot]
48d4adedaa
build: split darwin/mas macOS publish jobs ( #43764 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-17 20:07:46 -07:00
Samuel Attard
a27df94f71
build: improve logging on http errors during release process ( #43759 )
...
* build: improve logging on http errors during release process (#43756 )
* build: improve logging on http errors during release process (again) (#43757 )
* build: improve logging on http errors during release process (again, but more) (#43758 )
2024-09-17 15:27:27 -07:00
trop[bot]
888928887c
fix: in Emit(), don't leak converted Arg Local<Values> into caller's scope ( #43746 )
...
fix: Emit() should not leak converted arg handles into caller's HandleScope
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-17 10:57:21 -05:00
John Kleinschmidt
4ee00641eb
ci: move Archaeologist to GHA ( #43732 )
...
ci: move Archaeologist to GHA (#43701 )
* chore: move Archaeologist to GHA
* chore: test archaelogist changes
* Revert "chore: test archaelogist changes"
This reverts commit a575d6ef3a6495a71c03e9e2d15ec9bb329c5033.
* chore: properly name steps in archaeologist-dig
2024-09-17 11:23:26 -04:00
trop[bot]
12bb7093e2
fix: resizing border on Linux WCO caption buttons ( #43744 )
...
Closes https://github.com/electron/electron/issues/43714 .
Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-17 15:33:28 +02:00
trop[bot]
6b4f269d22
fix: prevent loading spinner when launching utility process on Windows ( #43731 )
...
fix: prevent spinning cursor when launching utility process on Windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2024-09-17 11:51:12 +02:00
Charles Kerr
d11c840cf0
refactor: add EmitWarning(v8::Isolate*) helper ( #43736 )
...
refactor: add `EmitWarning(v8::Isolate*)` helper (#43722 )
* refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove EmitWarning(node::Environment*, ...)
* chore: add code comments
* fixup! refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove unused node #includes
2024-09-17 11:50:48 +02:00
trop[bot]
18bd295873
docs: document View.removeChildView edge case ( #43725 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2024-09-16 12:53:10 +02:00
trop[bot]
748f293400
refactor: remove use of deprecated API BuildServiceInstanceFor() ( #43707 )
...
* refactor: update BadgeManagerFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update NetworkContextServiceFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update ElectronExtensionSystemFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update UsbChooserContextFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update UsbHidChooserContextFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update SerialChooserContextFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update FileSystemAccessPermissionContextFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* empty commit
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-13 15:26:10 -05:00
trop[bot]
7a04a77ed0
refactor: avoid minor code repetition in native_image.cc ( #43704 )
...
chore: delegate handle creation in NativeImage::Resize()
chore: delegate handle creation in NativeImage::Crop()
chore: delegate handle creation in NativeImage::CreateEmpty()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-12 20:13:27 +02:00
trop[bot]
810a6d6ef4
fix: EyeDropper working in devtools ( #43700 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-12 19:20:34 +02:00
trop[bot]
27aea84411
fix: native View wrapper crash missing when adding child view ( #43696 )
...
fix: native View wrapper crash missing when adding child view
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-12 12:48:16 +02:00
trop[bot]
2aa2611f76
feat: add support for system picker in setDisplayMediaRequestHandler ( #43680 )
...
* tmp
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* feat: add support for system picker in setDisplayMediaRequestHandler
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* oops
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Samuel Attard <sam@electronjs.org>
* stuff
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* well...
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* seems legit
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* chore: update patch to handle screenCapturer
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* feat: modify API to use useSystemPicker
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* fix: gate ScreenCaptureKitPicker to macos 15 or higher
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* fix: don't use native picker with legacy media selection
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* chore: code review, boolean set & docs update
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* fix: add cancelCallback
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* docs: clarify session & desktopCapturer docs
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: Samuel Attard <sam@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-09-11 09:57:39 -07:00
trop[bot]
57aeb9dfc6
fix: ensure SetPluginCanSave updated in PDFs ( #43686 )
...
fix: ensure SetPluginCanSave updated in PDFs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-11 17:56:23 +02:00
