trop[bot]
9829cb5cdd
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #43941 )
...
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (#43803 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 07:05:48 -05:00
dependabot[bot]
5839a66052
build(deps): bump github/codeql-action from 3.24.0 to 3.26.8 ( #43902 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.0 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e8893c57a1...294a9d9291
)
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 23:28:26 -07:00
dependabot[bot]
0d2db85529
build(deps): bump actions/checkout from 4.1.1 to 4.1.7 ( #43900 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.1...692973e3d937129bcbf40652eb9f2f61becf3332 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 23:28:05 -07:00
dependabot[bot]
9d6951d316
build(deps): bump actions/setup-node from 4.0.2 to 4.0.4 ( #43898 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.2 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](60edb5dd54...0a44ba7841
)
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 23:27:55 -07:00
dependabot[bot]
f0ac0a6d64
build(deps): bump actions-cool/issues-helper from 3.3.3 to 3.6.0 ( #43899 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.3.3 to 3.6.0.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](275328970d...a610082f8a
)
---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 22:07:37 -07:00
dependabot[bot]
b60d46b1a2
build(deps): bump peter-evans/create-pull-request from 6.0.0 to 7.0.5 ( #43901 )
...
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request ) from 6.0.0 to 7.0.5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases )
- [Commits](b1ddad2c99...5e914681df
)
---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 22:06:32 -07:00
Samuel Attard
84687e1d56
build: add support for fetching github token from sudowoodo ( #43887 )
...
build: add support for fetching github token from sudowoodo (#43808 )
* build: add support for fetching github token from sudowoodo
* chore: update release notes cache for tests
* build: support nightlies repo correctly
* build: post token
2024-09-23 12:57:25 -07:00
dependabot[bot]
28babae715
build(deps): bump slackapi/slack-github-action from 1.25.0 to 1.27.0 ( #43837 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.25.0 to 1.27.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](6c661ce588...37ebaef184
)
---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:53:13 -07:00
dependabot[bot]
66d27ecda1
build(deps): bump dsanders11/project-actions from 1.2.0 to 1.3.0 ( #43835 )
...
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions ) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/dsanders11/project-actions/releases )
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json )
- [Commits](82e99438bd...eb760c4889
)
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:51:41 -07:00
dependabot[bot]
d4a9d1134f
build(deps): bump actions/download-artifact from 4.1.7 to 4.1.8 ( #43830 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](65a9edc588...fa0a91b85d
)
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:49:30 -07:00
dependabot[bot]
89c68de69e
build(deps): bump amannn/action-semantic-pull-request from 5.4.0 to 5.5.3 ( #43829 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.4.0 to 5.5.3.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](e9fabac35e...0723387faa
)
---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:48:16 -07:00
dependabot[bot]
14bf8b75d8
build(deps): bump mikefarah/yq from 4.40.7 to 4.44.3 ( #43827 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.40.7 to 4.44.3.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bb66c9c872...bbdd97482f
)
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:45:11 -07:00
trop[bot]
46aa14fbc5
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43807 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-20 00:18:39 -05:00
trop[bot]
ef819c7e23
build: let darwin/mas run concurrently ( #43789 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-18 16:36:20 -07:00
trop[bot]
90587d6cba
build: split darwin/mas macOS publish jobs ( #43763 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-17 20:07:53 -07:00
trop[bot]
4b30a2e1d7
build: improve logging on http errors during release process ( #43761 )
...
* build: improve logging on http errors during release process (#43756 )
Co-authored-by: Samuel Attard <sam@electronjs.org>
* build: improve logging on http errors during release process (again) (#43757 )
Co-authored-by: Samuel Attard <sam@electronjs.org>
* build: improve logging on http errors during release process (again, but more) (#43758 )
Co-authored-by: Samuel Attard <sam@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sam@electronjs.org>
2024-09-17 20:06:02 -07:00
trop[bot]
cece35555a
fix: in Emit()
, don't leak converted Arg Local<Values>
into caller's scope ( #43749 )
...
fix: Emit() should not leak converted arg handles into caller's HandleScope
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-17 11:16:35 -05:00
trop[bot]
8d3882e285
ci: move Archaeologist to GHA ( #43735 )
...
* chore: move Archaeologist to GHA
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: test archaelogist changes
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Revert "chore: test archaelogist changes"
This reverts commit a575d6ef3a6495a71c03e9e2d15ec9bb329c5033.
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: properly name steps in archaeologist-dig
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-17 11:48:41 -04:00
trop[bot]
a07a70e8db
fix: restore Chromium default Content-Disposition
header parsing ( #43671 )
...
* fix: restore Chromium default Content-Disposition header parsing
Co-authored-by: Milan Burda <milan.burda@gmail.com>
* Update api-web-request-spec.ts
Co-authored-by: Milan Burda <milan.burda@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2024-09-10 12:10:30 -04:00
trop[bot]
0009a19ce6
test: add -pdf-ready-to-print event to WebContents for testing ( #43652 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-09 21:56:08 -05:00
trop[bot]
4bc1221864
build: fix patchup logic only running on one platform ( #43655 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-09 20:19:59 -05:00
Shelley Vohr
7f3640f761
fix: ensure version of xdg-dialog-portal
with defaultPath
support ( #43631 )
...
fix: ensure version of xdg-dialog-portal with defaultPath support
2024-09-09 17:40:39 +02:00
trop[bot]
01f367a344
refactor: NativeWindow::Create()
returns a unique_ptr ( #43608 )
...
refactor: NativeWindow::Create() returns a unique_ptr
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-06 15:26:09 -05:00
trop[bot]
178d937062
fix: confirm a v8::Value
is a v8::Object
before casting it ( #43602 )
...
fix: confirm a v8::Value is a v8::Object before casting it
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-06 14:19:28 -05:00
trop[bot]
50ef5ed9f0
build: use proper targets for building ( #43589 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-06 10:59:32 +02:00
trop[bot]
74fb38964a
docs: explain ipcRenderer behavior in context-bridge.md ( #43582 )
...
* docs: explain ipcRenderer behavior in context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
* Update context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
* Update context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
* Update docs/api/context-bridge.md
Co-authored-by: Erik Moura <erikian@erikian.dev>
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
* Update context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
* Update context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
* Update context-bridge.md
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
* Update docs/api/context-bridge.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
* Update docs/api/context-bridge.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
2024-09-05 17:07:04 -04:00
trop[bot]
5955d53c48
build: fix telemetry error when using autoninja ( #43571 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-05 12:01:25 +02:00
trop[bot]
3a5479aab6
fix: -Wunsafe-buffer-usage warnings in IsUrlArg() ( #43541 )
...
* fix: -Wunsafe-buffer-usage warnings in IsUrlArg()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: improve code comments for CheckCommandLineArguments()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: reduce diffs from main
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: CheckCommandLineArguments takes a StringVector arg
Fixes another buffer warning!
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: use base::CommandLine::StringPieceType
base:CommandLine::StringViewType has not been invented yet
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-04 21:27:18 -05:00
trop[bot]
7b3143cc84
build: don't run symbol generation on PS ( #43558 )
...
fix: don't run symbol generation on PS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-09-04 20:19:33 -05:00
trop[bot]
d7816993b9
build: free up macos disk space as soon as possible ( #43545 )
...
* chore: free up macos disk space as soon as possible
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* build: free up disk space on gn check too
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-04 08:33:56 -04:00
trop[bot]
01f11a9169
chore: speed up cache only reclient for fork PRs ( #43503 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-08-30 20:25:30 -04:00
trop[bot]
d53ed0bcd7
chore: remove unused method asar::ClearArchives() ( #43467 )
...
chore: remove unused asar::ClearArchives()
last use removed in Jun 2021 (b1d1ac65
, #29293 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-23 17:15:59 -05:00
trop[bot]
999860f569
fix: touch bar functionality on BaseWindow ( #43419 )
...
* fix: touch bar functionality on BaseWindow
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: add test for BaseWindow.setTouchBar
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-22 15:43:51 +02:00
trop[bot]
b8a8fe115f
refactor: move impl functions into private namespace ( #43407 )
...
* refactor: move into unnamed namespace: IsKillURL()
refactor: move into unnamed namespace: ResolvePossiblyRelativeURL()
refactor: move into unnamed namespace: AllowFileAccess()
refactor: move into unnamed namespace: PrepareURLForNavigation()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetMonitors()
refactor: move into unnamed namespace: GetEDIDProperty()
refactor: move into unnamed namespace: MonitorAtomIdToDisplayId()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetPermissionInfos() } refactor: move into unnamed namespace: GetPermissionAliases()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: OnOpenExternal()
refactor: move into unnamed namespace: HandleExternalProtocolInUI()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: BindMimeHandlerService()
refactor: move into unnamed namespace: BindBeforeUnloadControl()
refactor: move into unnamed namespace: BindBadgeServiceForServiceWorker()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetClientIdPath()
refactor: move into unnamed namespace: ReadClientId()
refactor: move into unnamed namespace: WriteClientId()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: HasExplicitLogFile()
refactor: move into unnamed namespace: DetermineLoggingDestination()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetArchiveCache()
refactor: move into unnamed namespace: GetArchiveCacheLock()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetParameters()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetDoomed()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: EncodeToken()
refactor: move into unnamed namespace: PortInfoToValue()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-21 19:42:40 -05:00
trop[bot]
c50fa5486e
chore: remove unused method Erase() ( #43394 )
...
chore: remove unused method Erase() (#43348 )
Last use removed in Mar 2018 by 4b39d17e
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-21 12:29:25 -05:00
trop[bot]
3ad0eb0027
refactor: remove unused SetWMSpecState ( #43395 )
...
refactor: remove unused SetWMSpecState (#43347 )
last use removed in Aug 2022 by 53cd2315
#35179
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-21 14:21:06 +02:00
trop[bot]
6619ad79d0
refactor: NodeBindings::Create() returns a unique_ptr ( #43391 )
...
refactor: NodeBindings::Create() returns a unique_ptr (#43361 )
* refactor: NodeBindings::Create() returns a unique_ptr
* empty commit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-21 14:20:40 +02:00
Keeley Hammond
b74089153a
chore: cherry-pick 9797576 from v8 ( #43387 )
...
* chore: cherry-pick 9797576 from v8 (#43376 )
* chore: update patches
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-20 17:06:07 -07:00
Shelley Vohr
9fec618788
build: use smaller instances for gn-check ( #43360 )
...
build: use smaller instances for gn-check (#43187 )
Co-authored-by: Samuel Attard <sam@electronjs.org>
2024-08-20 12:01:34 +02:00
electron-roller[bot]
55fd99488f
chore: bump node to v20.16.0 (30-x-y) ( #43025 )
...
chore: bump node to v20.16.0
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-19 14:04:13 +02:00
trop[bot]
ff3d3e6944
feat: emit an event when accessing restricted path in File System Access API ( #43162 )
...
* fix: show a dialog when accessing restricted path in File System Access API
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: allow overriding initial blocked paths
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: fix doc
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: change block to deny for consistency
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-13 12:47:53 -04:00
trop[bot]
e39c0f9dae
chore: remove unused Notification fields icon_path_, has_icon_ ( #43296 )
...
Last use of `icon_path_` was removed on May 29, 2017 (c741b584
)
Last use of `has_icon_` was removed on May 30, 2017 (5048425e
)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-12 12:56:00 +02:00
trop[bot]
35b75e2285
fix: accidental handle copying in a range loop ( #43282 )
...
fix: accidental handle copying
Xref: https://github.com/electron/electron/pull/37857
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-10 09:59:32 +02:00
trop[bot]
5e9a959eae
fix: check screen capture permissions in desktopCapturer
( #43272 )
...
fix: check screen capture permissions in desktopCapturer
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-09 19:08:20 +02:00
trop[bot]
0a340b7f31
fix: system-context-menu with frameless BrowserWindows ( #43275 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-09 19:05:08 +02:00
trop[bot]
b3e5978c27
docs: Document ideal iconPath size ( #43240 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
2024-08-07 11:57:20 +02:00
trop[bot]
bce144aaf3
perf: avoid redundant calls to GetView() ( #43230 )
...
* perf: avoid double-calls to GetView()
There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:
if (auto* view = foo->GetView())
view->DoSomething();
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* perf: avoid discarded GetView() call
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-06 19:23:51 -05:00
trop[bot]
5910d3f090
refactor: simplify window moveAbove/moveTop
impl on macOS ( #43203 )
...
refactor: simplify window moveAbove/moveTop impl on macOS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-06 16:42:19 -04:00
Pedro Pontes
b91a920128
chore: cherry-pick 1 changes from 1-M127 ( #43167 )
...
* chore: [30-x-y] cherry-pick 1 changes from 1-M127
* d9f7652c867c from chromium
* chore: e patches all
to make GH actions happy
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-06 12:07:49 -04:00
trop[bot]
a1342720ec
perf: don't build unused vectors in HidChooserContext ( #43212 )
...
* refactor: remove unused code in HidChooserContext::DeviceRemoved()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use structured bindings for readability
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-05 12:54:21 -05:00