Cheng Zhao
d1f0d6c184
fix: remove event monitor before destroying window
2018-11-27 11:10:07 +09:00
Nitish Sakhawalkar
025aa49f67
fix: NSWindow crash happening on macos 10.9 ( #15660 )
2018-11-10 14:53:35 +01:00
Samuel Attard
9aed2a465f
fix: send NSView* as the response to getNativeWindowHandle() instead of a null handle ( #15521 )
2018-11-08 09:03:19 -08:00
Shelley Vohr
dcd2bf451d
refactor: remove 10.9 specific menu code ( #15578 )
2018-11-05 20:42:19 -08:00
Jeremy Apthorp
77f69cbe08
chore: remove unused use_transparent_window.patch ( #15534 )
...
Unneeded since 6f2f761df3 (diff-0bbbec38254ebb1146b15c15277c6aa1)
2018-11-05 13:19:21 -08:00
Andy Dill
7a23980f4b
fix: set NSResizableWindowMask at init time ( #15106 )
2018-10-25 10:34:11 +09:00
Michelle Tilley
13247e592b
fix: correct reversed logic in NativeWindowMac::SetEnabled ( #15257 )
2018-10-22 13:01:45 -07:00
Milan Burda
6f3c46cc7e
refactor: move devtools from brightray to atom ( #15234 )
2018-10-19 15:50:30 +02:00
Kevin Lynagh
af4cf1e969
fix: simpleFullscreen window should be on top of other OS X menu bars. ( #14881 )
...
If an app has no menu bar (because `app.dock.hide()` has been called),
OS X will still render the menu bar of the previously-focused app.
This commit ensures simpleFullscreen windows will be drawn on top of
that menu bar by setting their level to NSPopUpMenuWindowLevel while
simpleFullscreen mode is active.
Ref: https://github.com/electron/electron/issues/11468
2018-10-09 22:38:52 -07:00
Shelley Vohr
dd43e92186
fix: simplify SetBackgroundColor
...
The compositor_superview member of BridgedNativeWidgetMac has been removed so as a consequence there is only one layer on which we need to call setBackgroundColor
2018-10-09 20:37:07 -07:00
Jeremy Apthorp
30850f491f
fix: [mac] restore SetBackgroundColor functionality
2018-10-09 14:39:39 -07:00
Jeremy Apthorp
ec1bd5375a
FIXME: Delete RenderWidgetHostViewMac::AcceleratedWidgetGetNSView
...
https://chromium-review.googlesource.com/c/chromium/src/+/1121957
https://chromium-review.googlesource.com/c/chromium/src/+/1037145
2018-10-09 14:38:00 -07:00
Felix Rieseberg
79c6e7c3f7
fix: Disable new fade animation for BrowserViews ( #14911 )
2018-10-02 11:49:26 +10:00
Shelley Vohr
985d35fc1c
fix: update deprecated NSWindow masks ( #14760 )
2018-09-26 16:00:57 -07:00
Cheng Zhao
6f494b3c58
fix: do not set layer explicitly for frameless window ( #14730 )
2018-09-20 12:24:55 -05:00
Paulius
b89848d683
feat: allow window above full screen windows on mac ( #14122 )
...
* allow window above full screen windows on mac
* add visibility change params to higher level files
* adress feedback, fix bool issue, remove compilation hooks
* adjust readme
* switch to options object
* single argument for native window views
2018-08-31 15:06:02 -07:00
Emmanuel Kimmerlin
5f6706ac33
feat: BrowserWindow.getNormalBounds() ( #13290 )
...
* First commit
* Add Mac support (1st attempt)
* Add Mac support (2nd attempt)
* Simplify tests
* Restore window state !
* Looking at other tests, seems minimize, maximize, fullscreen are skipped when in CI
* Fix Mac tests
* Restore tests in CI
* Fix typo
* widget getRestoredBounds not working on Mac !!
* widget getRestoredBounds not working on Mac !!
* Add IsNormal function
* Add IsNormal
* IsNormal => isNormal
* Deactivate fullscreen on Mac. Do not receive leave-fullscreen event
* Set default original_frame_
* Set default original_frame_
* Fix Mac
2018-08-24 14:33:27 -07:00
Birunthan Mohanathas
a42ca9eecc
feat: Add BrowserWindow.setWindowButtonVisibility()
...
Fixes #12701 and supersedes #13131 .
Ideally we would have added `setTitleBarStyle()`, but that is a
significantly more involved change. For example, consider the case where
we switch from `hidden` to `normal`. We would not only have to show the
traffic light buttons, we would also have to switch the window from a
frameless to a framed window and deal with various other window state.
Lets instead implement a simple solution for #12701 .
2018-07-25 10:12:27 -07:00
Cheng Zhao
0ec4ad288d
fix: fallback to FullSizeContentView for frameless window on mac ( #13599 )
...
fix: draggable regions not working on macOS
2018-07-10 11:43:42 +10:00
Samuel Attard
79fbd6bab1
Revert "fix: Drop support for OS X Mavericks (version 10.9)" ( #13333 )
2018-06-20 07:27:55 -05:00
Milan Burda
794fe741e9
fix: Drop support for OS X Mavericks (version 10.9)
2018-06-19 17:49:27 +02:00
deepak1556
4068a62fa6
Define gfx::AcceleratedWidget to be uint64_t instead of NSView*
...
https://chromium-review.googlesource.com/c/chromium/src/+/792295
2018-06-19 11:49:42 +10:00
Milan Burda
2337237d58
Refactoring: use C++11 class member variable initialization
2018-05-22 00:18:38 +02:00
Cheng Zhao
2f3fcb9dbe
give window a default content view
...
Certain APIs are expecting the window to have a content view, having a
default one simplifies our design.
2018-05-15 14:12:47 +09:00
Cheng Zhao
2b24b26e59
refactor: do not pass WebContents to NativeWindow
2018-05-15 14:03:21 +09:00
Cheng Zhao
a2c3db666e
viewDidMoveToSuperview may not be implemented
2018-05-04 09:55:09 +09:00
Cheng Zhao
5547df6073
report correct content size in AtomNSWindow
...
The views framework relies on NSWindow to return content size of window,
since we don't use the borderless window, the original result would
include titlebar. We have to override the function to return correct
result for frameless window.
2018-05-04 09:55:09 +09:00
Cheng Zhao
28fc58067b
remove usage of FullSizeContentView
2018-05-04 09:55:09 +09:00
Cheng Zhao
a9709a635c
display WebContents as views::View on macOS
2018-05-04 09:55:09 +09:00
Cheng Zhao
ada884a129
refactor: setup contentView on initialization
2018-05-04 09:55:09 +09:00
Cheng Zhao
2225cc9608
refactor: manage widget_ in NativeWindow
2018-04-30 10:56:54 +09:00
Cheng Zhao
cf70267871
remove unnecessary overrides
2018-04-26 09:48:12 +09:00
Cheng Zhao
5e48dd9d45
be aware of views::Widget's layer
2018-04-25 15:10:29 +09:00
Cheng Zhao
39242c978f
fix failed BrowserWindow tests
2018-04-25 15:10:29 +09:00
Cheng Zhao
75a624434c
refactor: use views::Widget on macOS
2018-04-25 15:10:29 +09:00
Shelley Vohr
12a57ff1c2
clang-format objc files ( #12673 )
2018-04-20 11:47:04 -07:00
Cheng Zhao
aa5c80f8a6
Fix new clang warnings
2018-04-20 19:26:20 +09:00
Cheng Zhao
c44279bb10
Move AtomNSWindow to a new file
2018-04-20 19:26:20 +09:00
Cheng Zhao
569967ac21
Move QLPreviewPanelDataSource to AtomNSWindowDelegate
2018-04-20 19:17:08 +09:00
Cheng Zhao
f6a7e5ea23
Move NSTouchBarDelegate to AtomNSWindowDelegate
2018-04-20 19:15:45 +09:00
Cheng Zhao
8e9667d86c
Manage AtomTouchBar in NativeWindow instead of AtomNSWindow
2018-04-20 19:15:01 +09:00
Cheng Zhao
ce54fd334d
Move AtomNSWindowDelegate to a new file
2018-04-20 19:12:17 +09:00
Cheng Zhao
37a7df49d6
mac: Provide ViewsDelegate
2018-04-20 19:10:37 +09:00
Jeremy Apthorp
eb7ccf8afa
Bring mac code into conformance with -Wobjc-missing-property-synthesis
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
f3c00e96aa
Bring mac code into conformance with -Wunguarded-availability
2018-04-19 11:12:58 -07:00
Cheng Zhao
d706a30849
Fix crash when releasing window
2018-04-11 15:12:53 +09:00
Cheng Zhao
2b5bde4071
InstallView is no longer needed
2018-04-11 15:12:53 +09:00
Cheng Zhao
5a95aaaa54
kVibrancyType should be read in InitFromOptions
2018-04-11 15:12:53 +09:00
Cheng Zhao
cfd8ea8eb0
mac: Correctly unload previous content view
2018-04-11 15:12:53 +09:00
Cheng Zhao
56735d4ff5
Add NativeWindow::SetContentView
2018-04-11 15:12:53 +09:00