Birunthan Mohanathas
95c69e660c
build: Bump libcc to latest (3.0.x)
...
This picks up electron/libchromiumcontent#611 and
electron/libchromiumcontent#599 .
2018-07-25 09:54:00 -07:00
trop[bot]
4333020157
fix: create WebContents for webview on request ( #13761 )
2018-07-21 16:51:31 +09:00
John Kleinschmidt
f4ff97038c
Merge pull request #13755 from trop-bot/3-0-x-bp-fix--update-rebuild-test-modules.py-for-node-10-1532100223562
...
fix: update rebuild-test-modules.py for node 10 (backport: 3-0-x)
2018-07-20 14:45:00 -04:00
John Kleinschmidt
967577c335
fix: update for node 10
2018-07-20 15:23:49 +00:00
John Kleinschmidt
8bd5c1f858
Merge pull request #13734 from electron/backport-13727-3-0-x
...
fix: use context counter as contextId (backport 3-0-x)
2018-07-20 10:17:18 -04:00
trop[bot]
2955b0168c
fix: ensure DirectX capturer is supported. (backport: 3-0-x) ( #13738 )
...
* Ensure DirectX capturer is supported.
* Actually try building on Windows.
2018-07-20 14:25:29 +10:00
Cheng Zhao
04b7c77951
fix: use webContentsId with contextId together
...
After after using `processId-contextCounter` as contextId, it may happen
that contexts in different WebContents sharing the same renderer process
get the same contextId. Using webContentsId as part of key in
ObjectsRegistry can fix this.
2018-07-20 10:53:02 +09:00
Cheng Zhao
136cf389e8
fix: use context counter as contextId (backport 3-0-x)
...
For sandboxed renderer it may not have a node::Environment in the context,
using a increasing counter as contextId works for all cases.
2018-07-19 11:27:41 -07:00
Zeke Sikelianos
8d9775b0b1
Bump v3.0.0-beta.3
2018-07-17 09:38:50 -07:00
John Kleinschmidt
9237d46dba
make sure tests don't run for GitHub releases. ( #13701 )
...
Also fix VSTS slack integration and
Update to latest libchromiumcontent
(cherry picked from commit 1c70a1cccd
)
2018-07-17 10:57:59 -05:00
John Kleinschmidt
8f8d198c5a
Merge pull request #13539 from trop-bot/3-0-x-bp-enable-webview-in-sandbox-renderer-1530547750986
...
Backport (3-0-x) - Enable webview in sandbox renderer
2018-07-17 10:01:40 -04:00
trop[bot]
fcdbb8c4a7
fix: create a window capturer correctly (backport: 3-0-x) ( #13693 )
...
* fix: create a window capturer correctly
We were incorrectly creating two screen capturers instead of a window
capturer
* spec: ensure dc tests pass
* spec: enable all tests after verifying dc tests work
2018-07-17 15:30:33 +10:00
trop[bot]
b49b071a1f
fix: remove race condition for executeJavaScript ( #13692 )
...
Replaces 'did-finish-load' with 'did-stop-loading' which semantically
maps to the events inside Chromium. Before I think we were relying
on a natural 99% winnable race condition.
Fixes #13504
2018-07-16 21:22:27 -07:00
trop[bot]
1feb45da29
docs: update second-instance event docs ( #13682 )
2018-07-16 13:57:58 -07:00
John Kleinschmidt
2c43dbdb25
Merge pull request #13680 from trop-bot/3-0-x-bp-fix-crash-when-opening-devtools-for-frameless-window-1531748442042
...
Fix crash when opening devtools for frameless window (backport: 3-0-x)
2018-07-16 10:48:37 -04:00
Cheng Zhao
7eff91dde1
spec: openDevTools should not crash for frameless window
2018-07-16 13:40:48 +00:00
Cheng Zhao
780483ff35
fix: use InspectableWebContentsView as content view
2018-07-16 13:40:48 +00:00
trop[bot]
c2f770df02
Update Windows VS2017 requirement ( #13665 )
2018-07-13 18:17:53 -05:00
John Kleinschmidt
74e6e063d4
Merge pull request #13658 from trop-bot/3-0-x-bp-fix--don't-invoke-callback-after-framesubscriber-is-destroyed-1531475760693
...
fix: don't invoke callback after FrameSubscriber is destroyed (backport: 3-0-x)
2018-07-13 11:51:07 -04:00
Cheng Zhao
7702cc1090
fix: don't invoke callback after FrameSubscriber is destroyed
2018-07-13 09:56:07 +00:00
trop[bot]
97319e5a3a
fix: remember the render_process_id when permission requests occur on the IO thread ( #13651 )
...
Fixes #13620
2018-07-13 12:50:57 +10:00
Jeremy Apthorp
041c952574
fix: enable spell checking, which broke in upgrade to ch66
...
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.
Added the first (!) test for spellchecking, too.
Fixes #13608 .
[1]: 03563dd163
2018-07-12 13:28:15 -07:00
John Kleinschmidt
6c9b6f9cac
Merge pull request #13642 from trop-bot/3-0-x-bp-chore--updates-for-release-process-1531400155960
...
chore: Updates for release process (backport: 3-0-x)
2018-07-12 09:37:12 -04:00
John Kleinschmidt
c4884da601
Update docs to reflect current process
...
Also added troubleshooting steps.
2018-07-12 12:56:02 +00:00
John Kleinschmidt
59b05ed661
Fix Appveyor URL
2018-07-12 12:56:02 +00:00
Cheng Zhao
e3204a5ec1
Merge pull request #13637 from electron/fix-remote-3-0-x
...
fix: guard against double-freeing remote references (3-0-x)
2018-07-12 16:01:52 +09:00
Cheng Zhao
adf49daaac
fix double-freeing remote references
...
After the page does navigations, garbage collection can still happen in
the old context. This commit changes to store references to remote objects
by _pages_, instead of by _WebContents_.
2018-07-12 11:17:26 +09:00
Cheng Zhao
9431677e79
add API to return an unique ID for page
2018-07-12 11:16:13 +09:00
John Kleinschmidt
0141c083d0
Bump v3.0.0-beta.2
2018-07-10 14:12:05 -04:00
John Kleinschmidt
96b2c08293
Merge pull request #13612 from trop-bot/3-0-x-bp-build--updates-to-the-release-process-1531237367452
...
Backport (3-0-x) - build: Updates to the release process
2018-07-10 13:26:24 -04:00
John Kleinschmidt
d6f2c26b0f
Move github release checking to node.js
...
Our upload script was relying on an old python script to find the GitHub release for uploading.
2018-07-10 15:42:53 +00:00
John Kleinschmidt
d478906f9c
Update to run new AppVeyor jobs
...
AppVeyor builds got split into two jobs, `electron-x64` and `electron-ia32`
2018-07-10 15:42:53 +00:00
trop[bot]
85526c7f21
fix: fallback to FullSizeContentView for frameless window on mac ( #13600 )
...
When using `views::Widget` to create window, Chromium will automatically
use a `BridgedContentView` as content view, which however does not
support draggable regions inside it.
By fallback to `FullSizeContentView` we can work around this problem,
with the price of losing the ability to use `views::View` APIs. Since
we don't expect users to use the new `View` APIs in `BrowserWindow`
anyway, it should not be a problem.
This change does not affect users of `TopLevelWindow`, and for users of
`BrowserWindow` there is nothing to lose.
In the long term we should look into how to make draggable regions work
with `BridgedContentView`. The related Chromium code is still being
changed rapidly, we can wait until Chromium migrated its
`NativeAppWindowCocoa` class to use `views::Widget`.
2018-07-10 13:09:46 +09:00
John Kleinschmidt
f6ae438005
Merge pull request #13591 from trop-bot/3-0-x-bp-fix-failed-devtools-tests-due-to-fs.statsyncnoexception-not-working--1531147212282
...
Backport (3-0-x) - Fix failed devtools tests due to fs.statSyncNoException not working
2018-07-09 14:30:42 -04:00
John Kleinschmidt
5e51e608db
Merge pull request #13593 from electron/update-libcc-3-0-x
...
build: Update to latest libchromiumcontent for 3-0-x
2018-07-09 14:30:08 -04:00
John Kleinschmidt
97248a7a56
Update to latest libchromiumcontent
...
Use the latest libchromiumcontent for 3-0-x which is built with Visual Studio 2017 15.7.4
2018-07-09 13:20:41 -04:00
Cheng Zhao
8639466c75
update node to fix fs.statSyncNoException
2018-07-09 14:40:18 +00:00
Cheng Zhao
31e2166cea
Revert "spec: disable the i18nString test"
...
This reverts commit 86c79653de
.
2018-07-09 14:40:18 +00:00
trop[bot]
c2f4144996
Backport (3-0-x) - Fix devtools not functioning well ( #13571 )
...
* implement devtools showItemInFolder message
* add stubs for new devtools messages
* fix: update devtools url
* spec: enable back devtools tests
* spec: disable the i18nString test
It is failed because of fs.statSyncNoException, I'll fix it in another
PR.
2018-07-06 13:19:21 +10:00
Hari Juturu
f63e5ffa65
cache lastwebprefs
2018-07-02 16:09:17 +00:00
Hari Juturu
32e40cb4c3
Enable webview in sandbox renderer Security: Inherit embedder prefs onto webview
2018-07-02 16:09:17 +00:00
John Kleinschmidt
8585372e11
Merge pull request #13517 from trop-bot/3-0-x-bp-fix--tray-setcontextmenu-crash-1530309092727
...
Backport (3-0-x) - fix: tray setContextMenu crash
2018-07-02 09:13:58 -04:00
John Kleinschmidt
2e2289d701
Merge pull request #13530 from electron/fix-mas-build-3-0-x
...
Update libcc to fix private APIs in MAS build (3-0-x)
2018-07-02 08:05:56 -04:00
Cheng Zhao
f6229d9489
fix: update libcc to fix private APIs in mas build
2018-07-02 15:21:18 +09:00
Maxine Whitely
bace4890c8
fix: tray setContextMenu crash
...
Co-authored-by: Zhuo Lu <sethlu@mintkit.net>
Co-authored-by: Kristine Zhang <kzhang@slack-corp.com>
2018-06-29 21:51:38 +00:00
Cheng Zhao
0a3211c387
fix the crash when loading site with jquery ( #13476 )
2018-06-29 09:42:26 +09:00
John Kleinschmidt
7d27c91400
Remove no longer used files from asset validation ( #13372 )
...
Also removed temporary sha value needed for initial 3.0.0-beta.1
2018-06-27 11:12:11 -07:00
trop[bot]
93edf2edd3
Backport (3-0-x) - fix: deprecate properties in app.getAppMetrics() ( #13453 )
...
* fix: deprecate properties in app.getAppMetrics()
* address feedback from review
* fix deprecated property location
* simplify test
2018-06-27 19:07:39 +10:00
trop[bot]
ec993214a2
docs: add native_mate to source code directory structure doc ( #13457 )
2018-06-27 18:28:13 +10:00
Samuel Attard
509120acde
Merge pull request #13456 from electron/native-mate-in-electron-3
...
Native mate in electron 3
2018-06-27 17:45:04 +10:00