Jonathon Simister
9c018744f4
Fixes hexColorDWORDToRGBA for transparent colors
2018-01-09 11:07:29 -08:00
Cheng Zhao
4298aecb7c
Merge pull request #11547 from electron/draggable_regions_patch
...
fix: draggable region ipc should be frame based
2018-01-07 21:15:50 +09:00
Charles Kerr
435c9c1486
Force uv loop cleanup ( #11465 )
...
* ensure all uv handles are closed before ending worker's loop
* add DCHECK to test that the Worker loop is finished
* don't call deprecated uv_loop_new(), uv_loop_delete()
* make cpplint happy
* fix comment error
* empty commit for CI
* tweak DCHECK expression
* extract-method: stop_and_close_uv_loop()
* fix DCHECK oops
2018-01-04 11:16:06 -08:00
Cheng Zhao
1072c75e38
Closing asar file should be syncronous
2018-01-03 19:12:16 +09:00
Cheng Zhao
fb78052b3d
Remove unnecessary scope
2018-01-03 19:10:48 +09:00
Cheng Zhao
104585e772
Do not create DIR_USER_DATA on IO thread
...
It would slowdown the startup time of apps since we have wait for two
message posts between threads.
2018-01-03 19:07:24 +09:00
Cheng Zhao
952928dc79
Singleton must be created on request
...
The creation of singleton relies on the `userData` dir, which can be
changed by user, we have to ensure singleton uses the `userData` dir set
by user.
2018-01-03 18:59:12 +09:00
deepak1556
14de22a8c7
Use cached application locale as default for generating accept-lang header
2018-01-02 17:33:46 +05:30
Cheng Zhao
de93b30d3c
win: Fix assertion when getting exe version
2018-01-02 17:02:12 +09:00
Cheng Zhao
82452e7924
win: Fix assertion when getting printers
2018-01-02 16:54:36 +09:00
Cheng Zhao
7bf156d197
win: Fix assertion "IsWprintfFormatPortable(format)"
2018-01-02 16:45:43 +09:00
deepak1556
b9ace16959
update libcc for using custom platform with gin
2018-01-02 16:37:12 +09:00
deepak1556
769fbd0d3b
REVIEW: register BrowserChildProcessObserver once main message loop is ready
2018-01-02 16:37:11 +09:00
deepak1556
1b30cac372
Don't delay node module initialization
2018-01-02 16:37:11 +09:00
Cheng Zhao
1043f07b42
Fix compilation on Windows
2018-01-02 16:37:11 +09:00
deepak1556
237bd6790b
FIXME: allow IO access on main thread for crash reporter
2018-01-02 16:37:11 +09:00
deepak1556
e3a56240c9
REVIEW: fix base::File helper usage on incorrect task sequence
2018-01-02 16:37:10 +09:00
deepak1556
fd297722a8
Note about incorrect usage of blink::SchemeRegistry methods
2018-01-02 16:37:10 +09:00
deepak1556
d27744f455
Some blink::WebSecurityPolicy methods should be invoked before other render threads are created
2018-01-02 16:37:10 +09:00
deepak1556
0df464e16a
address review comments
2018-01-02 16:37:09 +09:00
deepak1556
ee80313666
opt into location service on main thread
2018-01-02 16:37:09 +09:00
deepak1556
d29c27dc78
REVIEW: obtain mime type from file path only on IO allowed sequence
2018-01-02 16:37:09 +09:00
deepak1556
e072213923
FIXME: dbus ObjectProxy methods should only be invoked on IO allowed sequence
2018-01-02 16:37:09 +09:00
deepak1556
a1592446da
REVIEW: access GetApplicationLocale on sequence that allows IO
2018-01-02 16:37:08 +09:00
deepak1556
69bd44edbb
REVIEW: add render process lifecycle observer only once
2018-01-02 16:37:08 +09:00
deepak1556
ebb0e46380
REVIEW: create AtomNetworkDelegate on the IO thread
2018-01-02 16:37:08 +09:00
Cheng Zhao
b2cef31bc0
Revert "Fix race condition when calling JsAsker::BeforeStartInUI"
...
This reverts commit 37317d74adb53afdcb22c85f2d3987fbae290ac7.
2018-01-02 16:37:08 +09:00
Cheng Zhao
6d9b186fa7
Fix race condition when calling JsAsker::BeforeStartInUI
2018-01-02 16:37:07 +09:00
deepak1556
e30131f30b
Initialize isolate holder in standalone node mode
2018-01-02 16:37:07 +09:00
deepak1556
88e53b1b5e
REVIEW: destroy process singleton on sequence where IO is allowed
2018-01-02 16:37:07 +09:00
deepak1556
1d95241185
FIXME: refactor and remove usage of ScopedAllowIO where possible
2018-01-02 16:37:06 +09:00
deepak1556
90acb22a58
dont use UI methods on IO thread
2018-01-02 16:37:06 +09:00
deepak1556
a518c5c3c4
derefence weak ptr only on the same sequence runner it was created in
2018-01-02 16:37:06 +09:00
deepak1556
fedf1d889b
handle NaN conversion from V8
2018-01-02 16:37:06 +09:00
deepak1556
b4e6516ad8
fix dcheck failure with invalid UTF8 string conversion for base::Value
2018-01-02 16:37:05 +09:00
deepak1556
5c25855ac5
create user data dir on thread that allows IO
2018-01-02 16:37:05 +09:00
deepak1556
99e26b8318
fix: draggable region ipc should be frame based
2018-01-01 22:54:02 +05:30
Cheng Zhao
d04ae88426
The RenderWidgetHostView might not be available when showing menu
2018-01-01 19:37:59 +09:00
Cheng Zhao
bc61f2eafa
Copy the callback instead of reference
...
I don't really see how this could be a problem, likely a bug of VS 2017?
2018-01-01 19:37:59 +09:00
Cheng Zhao
46330ac2a9
Remove the closed event of Menu
...
The callback of Menu.popup does more things, and there is actually no
request for the closed event.
2018-01-01 17:22:07 +09:00
Cheng Zhao
c3eadd5b63
mac: Call callback when menu is programmely closed
2018-01-01 16:49:25 +09:00
Cheng Zhao
7b01a8b860
Add callback parameter to Menu.popup
2018-01-01 16:26:19 +09:00
Cheng Zhao
d7bc127c60
mac: Correctly close popup menu
2018-01-01 15:40:15 +09:00
Cheng Zhao
c0c2461245
Do not create duplicate V8Platform in NodeDebugger
2017-12-22 20:29:09 +09:00
Cheng Zhao
00afeaba9a
Use Node's V8Platform instead of gin's
2017-12-22 20:29:08 +09:00
Cheng Zhao
65871cd567
Merge pull request #11238 from electron/spellchecker_iframe_patch
...
fix: manually set spellchecker for sub frames
2017-12-21 17:00:01 +09:00
Cheng Zhao
7a8864063b
mac: Handle the case when closing all menu runners
2017-12-21 15:57:27 +09:00
Cheng Zhao
088042841d
win: Correctly close popup menu
2017-12-21 15:26:32 +09:00
Cheng Zhao
e4770c7604
Coding style fixes
2017-12-20 18:48:09 +09:00
deepak1556
83d2917363
fix: manually set spellchecker for sub frames
2017-12-20 12:48:02 +05:30
Heilig Benedek
ef7357dedc
update tests for menu closed event and call cancel on closePopup
2017-12-20 15:40:07 +09:00
Heilig Benedek
bcef6eb3df
document menu closed event and fix styling issue
2017-12-20 15:40:07 +09:00
Heilig Benedek
c586806609
fix flash menu being unresponsive to commands
2017-12-20 15:40:07 +09:00
Heilig Benedek
d5ab691fdb
fix osr devtools crash introduced during merge
2017-12-20 12:57:02 +09:00
Cheng Zhao
b2e6340622
Reduce the number of helpers
2017-12-20 10:49:49 +09:00
Cheng Zhao
4fd8b04329
Better field names for details object
2017-12-20 10:25:31 +09:00
Samuel Attard
4d7b85bd01
Appease the linter
2017-12-20 10:21:38 +09:00
Samuel Attard
98e9311669
Give user access to the URL that is attempting to be openExternal'ed
2017-12-20 10:21:38 +09:00
Cheng Zhao
81527b71ba
Merge pull request #11279 from sethlu/openrecent
...
Update submenu's title at replacement
2017-12-19 15:28:02 +09:00
Cheng Zhao
b27e42f3f7
Fix indentions
2017-12-19 10:42:36 +09:00
Hugo Mano
ae7b96991c
Add webFrame.setIsolatedWorldSecurityOrigin
...
Move vector to cc file
Map executed javascript in isolated world to url
Some 💅
Documentation
Use WebSource[] as argument in executeJavaScriptInIsolatedWorld
Refactor and lint with @poiru’s comments
Remove duplicate call
Typo
Lint
2017-12-19 10:36:03 +09:00
Hugo Mano
389edb6229
Add webFrame.setIsolatedWorldHumanReadableName
2017-12-19 10:36:03 +09:00
Hugo Mano
f74f113d23
Add webFrame.setIsolatedWorldContentSecurityPolicy
2017-12-19 10:36:03 +09:00
Alexandre Lachèze
936d8c1117
Add webframe. executeJavaScriptInIsolatedWorld
...
Attempt runInIsolatedWorldContext
Replace RunInIsolatedWorldContext by GetIsolatedWorldGlobalObject
Fix linting
Remove useless getIsolatedWorldGlobalObject
Add support for scriptExecutionType
2017-12-19 10:36:03 +09:00
Shelley Vohr
3fc844c15a
add loop to catch null values
2017-12-13 14:02:43 -05:00
Shelley Vohr
6252ce466c
remove failing badDefault
2017-12-12 13:39:38 -05:00
Shelley Vohr
8b447b9291
fixing error in registerDefaults
2017-12-12 13:08:09 -05:00
Alexey Kuzmin
1caa04c0bf
Revert "Add systemPreferences.registerDefaults()"
2017-12-12 13:59:15 +03:00
Cheng Zhao
19f1fef040
Merge pull request #11283 from electron/fix-event-subscriber-race
...
Fix race condition in event_subscriber.h
2017-12-12 10:49:17 +09:00
Charles Kerr
99c980ab40
Merge pull request #11395 from electron/add-reg-defaults
...
Add systemPreferences.registerDefaults()
2017-12-11 17:45:32 -06:00
Shelley Vohr
a8e67e7f61
fixes from review
2017-12-11 18:20:12 -05:00
Shelley Vohr
84bab48627
improve error handling
2017-12-11 13:11:03 -05:00
Charles Kerr
87f8bd4ea7
Merge pull request #11359 from electron/fix_spell_checker_crash
...
Fixed crash in `atom::api::SpellCheckClient`
2017-12-11 10:18:27 -06:00
Shelley Vohr
c5aeda1fdd
fixes from code review
2017-12-11 00:20:26 -05:00
Shelley Vohr
18ee34f1a1
add method binding and error guards
2017-12-10 11:25:43 -05:00
Shelley Vohr
1ccad4a7e9
fix capitalization and clean logic
2017-12-10 11:04:05 -05:00
Shelley Vohr
f82086e6d3
first pass at adding infra for registerDefaults
2017-12-10 00:45:49 -05:00
simurai
fe0f203312
Replace app icons
2017-12-07 16:10:45 -05:00
deepak1556
19de41b764
BrowserClient::CanCreateWindow is no longer called on the IO thread
...
https://codereview.chromium.org/2821473002
2017-12-07 09:47:32 +05:30
Charles Kerr
5fa29fcf58
Merge pull request #11329 from electron/remove-classes-key
...
fix: Properly cleanup in `removeAsDefaultProtocolClient`
2017-12-06 17:31:50 -06:00
Ales Pergl
7a73b1d523
Fixed crash in atom::api::SpellCheckClient
...
The class didn't save the V8 context for the spell checking JS function. When
it later tried to call the JS function and there was no active context, V8
crashed.
I also optimized the spell checking loop by introducing `SpellCheckScope` and
reusing the V8 handles throughout the whole loop.
2017-12-06 14:50:20 +01:00
Cheng Zhao
9c109daa4b
Merge pull request #11168 from sethlu/fix-icns-color
...
fix: Update icns
2017-12-06 14:45:36 +09:00
Thiago de Arruda
897712359f
Implement powerMonitor "suspend"/"resume" events for Linux.
2017-12-05 08:12:44 -03:00
Cheng Zhao
24b3ee3a4a
Revert some unnecessary changes
2017-12-05 16:50:25 +09:00
Cheng Zhao
cb3a9c69ab
Add a SessionPreferences to manage session related data
...
By design the BrowserClient should not be aware of the api:: classes.
2017-12-05 15:59:15 +09:00
Cheng Zhao
776e8afa2b
Coding style changes
2017-12-05 11:50:06 +09:00
Samuel Attard
e535ba4808
Don't know why we suddenly need this, but hey :/
2017-12-05 11:35:54 +09:00
Samuel Attard
d1aded2831
Appease the almighty linter
2017-12-05 11:35:53 +09:00
Samuel Attard
d9359d8b6c
s/global/session in constants
2017-12-05 11:35:53 +09:00
Samuel Attard
3b80ee0655
Move global preload implementation to be session based
2017-12-05 11:35:53 +09:00
Samuel Attard
448ccc261d
Use const references
2017-12-05 11:35:27 +09:00
Samuel Attard
0ddd078aaf
Add ability to set global preload scripts
2017-12-05 11:35:27 +09:00
Cheng Zhao
d598aa1a67
Merge pull request #11300 from electron/external-devtools
...
Add API to set arbitrary WebContents as devtools
2017-12-05 10:35:49 +09:00
Felix Rieseberg
d4275b144b
🔧 Linter fascism
2017-12-04 10:46:53 -08:00
Felix Rieseberg
f62e0a4ed4
🔧 Make it actually work
2017-12-04 10:30:20 -08:00
Felix Rieseberg
b4b729609a
🔪 Delete classes key if empty
2017-12-01 17:39:54 -08:00
Ales Pergl
dadfbd3a4f
Reset embedder_zoom_controller_ before assigning new one
2017-12-01 17:55:22 +01:00
Ales Pergl
fd7af5c1d9
Don't call ui::SetAtomArrayProperty with an empty vector (fails DCHECK)
2017-12-01 17:55:22 +01:00
Ales Pergl
7613afe6d7
Disabled DCHECKs that fail when running tests
2017-12-01 17:55:22 +01:00
Ales Pergl
8357a33d81
Don't leak the taskbar object, reuse it instead
2017-12-01 17:55:21 +01:00
