Niklas Wenzel
90890e20c0
docs: clarify that sessions use cache by default (33-x-y backport) ( #44875 )
...
docs: clarify that sessions use cache by default (#44547 )
2024-11-29 11:44:58 -06:00
trop[bot]
0fe5035395
fix: misc-use-internal-linkage warnings ( #44871 )
...
* refactor: fix misc-use-internal-linkage warnings
move impl functions into anonymous namespace so that they're not visible
to other compilation units
2024-11-27 12:35:10 -06:00
trop[bot]
f22baeb670
refactor: use base::Extend in AddAdditionalSchemes() ( #44864 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-27 12:30:32 -06:00
trop[bot]
cd6e3d720f
refactor: fix modernize-return-braced-init-list warnings ( #44857 )
...
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
NB: using the braced-initializer list uncovered an error here:
the float returned by std::floor() can't be implicitly cast to
an int. This is solved by using base::ClampFloor<int>() instead.
std::floor()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-26 22:18:00 -06:00
trop[bot]
7152209fb5
fix: modernize-use-using clang-tidy warnings ( #44836 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-25 13:14:15 -05:00
trop[bot]
51e31de79e
fix: modernize-use-nodiscard clang-tidy warnings ( #44832 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-25 11:47:00 -06:00
trop[bot]
fe3467e187
docs: correct stable release dates for v34.0.0 ( #44830 )
...
* docs: correct stable release dates for v34.0.0
Co-authored-by: Ajay Kemparaj <ajaykemparaj@gmail.com>
* docs: correct stable release dates for v34.0.0
Co-authored-by: Ajay Kemparaj <ajaykemparaj@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Ajay Kemparaj <ajaykemparaj@gmail.com>
2024-11-25 11:04:07 -05:00
Charles Kerr
d0e24fca25
fix: clang-tidy performance-inefficient-vector-operation warnings (33-x-y) ( #44814 )
...
fix: clang-tidy `performance-inefficient-vector-operation` warnings (#44743 )
* fix: performance-inefficient-vector-operation warning in Clipboard::WriteFilesForTesting()
* fix: performance-inefficient-vector-operation warning in GetUploadedReports()
2024-11-25 10:47:39 -05:00
trop[bot]
3483cd62d7
refactor: remove unnecessary constructor code ( #44825 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-24 13:02:56 -06:00
trop[bot]
1ef8b47052
fix: remove unused local variables ( #44822 )
...
* chore: remove unused local non-trivial variable relaunch_executable
became unused in June 2016 in 0d066de572a08926
2024-11-24 08:55:27 -06:00
trop[bot]
71c11496b7
docs: update new GitHub issue link ( #44810 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-11-23 11:01:53 +01:00
trop[bot]
bd5c8d7a92
fix: crash calling shell.readShortcutLink ( #44803 )
...
* fix: crash calling shell.readShortcutLink
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: update .patches after trop
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-22 14:57:56 -05:00
trop[bot]
52b5d8ab99
fix: big endian bug in V8 serialization ( #44796 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-22 10:07:06 -05:00
trop[bot]
1329e22fce
fix: ensure context-menu emitted for draggable regions ( #44800 )
...
* fix: ensure context-menu emitted for draggable regions
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: address suggestions from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-22 09:27:32 -05:00
trop[bot]
5b9fbb2e19
build: remove duplicate line in gn file ( #44793 )
...
style: remove duplicate line in gn file
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <15865969+cucbin@users.noreply.github.com>
2024-11-22 15:06:45 +01:00
electron-roller[bot]
c0e51c8646
chore: bump node to v20.18.1 (33-x-y) ( #44780 )
...
* chore: bump node in DEPS to v20.18.1
* chore: update patches
* lib: remove lib/internal/idna.js
https://github.com/nodejs/node/pull/55050
* buffer: fix out of range for toString
https://github.com/nodejs/node/pull/54553
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-22 10:21:58 +01:00
electron-roller[bot]
bf13656e44
chore: bump chromium to 130.0.6723.137 (33-x-y) ( #44781 )
...
* chore: bump chromium in DEPS to 130.0.6723.137
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-21 16:57:05 -05:00
trop[bot]
c014819673
docs: sync 34.0.0 release date to Chromium 132 release date ( #44789 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-21 11:25:44 -08:00
trop[bot]
f0de0348d5
fix: windows save dialog extension bug ( #44771 )
...
* fix: windows save dialog extension bug
* refactor: simplify firstSpec extraction
* refactor: split when necessary
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: nilaoda <nilaoda@live.com>
2024-11-21 11:45:21 -05:00
trop[bot]
c5a820bd31
fix: performance-no-automatic-move clang-tidy warnings ( #44774 )
...
* fix: performance-no-automatic-move in GetLogFileName()
remove `const` from log_filename.
Warning fixed by this commit:
../../electron/shell/common/logging.cc:40:12: warning: constness of 'log_filename' prevents automatic move [performance-no-automatic-move]
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: performance-no-automatic-move in GetBundleResourcePath()
remove `const` from request_relative_path.
Warning fixed by this commit:
electron/shell/browser/extensions/electron_extensions_browser_client.cc:187:10: warning: constness of 'request_relative_path' prevents automatic move [performance-no-automatic-move]
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-21 15:29:42 +01:00
trop[bot]
8255e4e8d2
test: run script to help target discovery and reduce flakes ( #44764 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2024-11-20 16:25:21 -05:00
trop[bot]
8e03e1d4a9
chore: fix textured window conditional on macOS ( #44767 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-20 14:57:00 -05:00
trop[bot]
0010d976c5
fix: tooltips in WCO caption buttons ( #44757 )
...
fix: tooltips in WCO capton buttons
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-20 07:33:46 -06:00
Robo
0c42bf5743
chore: cherry-pick 2ca6d60a from chromium ( #44753 )
2024-11-20 12:49:05 +01:00
trop[bot]
b293c3b23f
fix: bugprone-narrowing-conversions warnings in NativeImage ( #44738 )
...
* fix: bugprone-narrowing-conversions warning in NativeImage::memory_usage_
- fix signed / unsigned math by using base/numerics/safe_conversions
- make memory_usage_ an int64_t so it can safely take the size_t
returned by computeByteSize()
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-19 21:00:25 -06:00
trop[bot]
bc7ab508b1
fix: cyclical #include dependency between autofill_popup.h and autofill_popup_view.h ( #44736 )
...
fix: AutofillPopup warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
refactor: reduce #indclude scope in autofill_popup.h and autofill_popup_view.h
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-19 17:08:49 -06:00
trop[bot]
3d658dfa59
fix: utility process exit code for graceful termination (reland) ( #44732 )
...
fix: utility process exit code for graceful termination (reland) (#44726 )
* chore: reland "fix: utility process exit code for graceful termination"
This reverts commit 1cae73ba092ccf5620c5fce8b896bade3a601346.
* fix: exit code on posix when killed via api
* chore: fix code style
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Robo <hop2deep@gmail.com>
2024-11-19 22:09:56 +01:00
trop[bot]
8b2496af1a
fix: destroy url loader wrapper when JS env exits ( #44729 )
...
* fix: destroy url loader wrapper when JS env exits
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Revert "fix: destroy url loader wrapper when JS env exits"
This reverts commit 419151a98a16814ea63e9abc197c6ae27f48128c.
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Revert "Revert "fix: destroy url loader wrapper when JS env exits""
This reverts commit 4b401b03c62aca79498660f995825491ae52f179.
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* fix: double free of JSChunkedDataPipeGetter
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* fix: crash on process exit after stream completes
Co-authored-by: deepak1556 <hop2deep@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-11-19 13:22:59 -06:00
trop[bot]
43e449c8a7
fix: improve single-pixel resize handling on Windows ( #44723 )
...
* fix: improve single-pixel resize handling
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update spec/api-browser-window-spec.ts
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update shell/browser/native_window_views.cc
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-19 10:53:21 -05:00
trop[bot]
14af0370d8
docs: Make ipcRenderer and ipcMain listener API docs consistent ( #44712 )
...
* docs: Make ipcRenderer and ipcMain listener API docs consistent
Co-authored-by: Will Anderson <will@itsananderson.com>
* test: add some unit tests for ipcRenderer/ipcMain listener behavior
Co-authored-by: Will Anderson <will@itsananderson.com>
* fix: Mark on/off methods as primary and addListener/removeListener as aliases
Co-authored-by: Will Anderson <will@itsananderson.com>
* fix: clear all listeners before running ipcMain removeAllListeners tests
Co-authored-by: Will Anderson <will@itsananderson.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Will Anderson <will@itsananderson.com>
2024-11-19 09:47:41 +01:00
trop[bot]
72115c1948
docs: document why to use the loadBrowserProcessSpecificV8Snapshot fuse ( #44710 )
...
Fixes #44450
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2024-11-18 15:01:38 -08:00
trop[bot]
24874c6adc
fix: utilityProcess pid should be undefined after exit ( #44694 )
...
fix: utilityProcess pid should be undefined after exit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-18 14:44:18 +01:00
trop[bot]
0fd7b33640
chore: update extensions features ( #44682 )
...
* chore: update extensions features
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
* restore header
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
2024-11-15 13:16:37 -05:00
trop[bot]
941965016e
fix: WebContentsView removal should compare directly ( #44671 )
...
* fix: WebContentsView removal should compare directly
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fixup view comparision
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: use erase_if
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Apply review suggestions
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-15 13:09:38 +01:00
Keeley Hammond
b88e1aba10
refactor: unfilter unresponsive events ( #44667 )
...
refactor: unfilter unresponsive events (#44629 )
* feat: internal -unresponsive event
* Reland "refactor: JSify BrowserWindow unresponsive handling"
This reverts commit ef7ae78ed4
2024-11-14 16:59:22 -08:00
trop[bot]
e95e6fac0d
build: fix python warnings "SyntaxWarning: invalid escape sequence '\w'" ( #44660 )
...
* fix: SyntaxWarning: invalid escape sequence '\w'
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove some unused imports
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: E711 warning 'Comparison to should be '
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-14 07:28:08 -06:00
Pedro Pontes
3eb1f02adb
chore: cherry-pick 1 changes from 0-M131 ( #44647 )
...
chore: [33-x-y] cherry-pick 1 changes from 0-M131
* 923797bac925 from chromium
2024-11-13 12:35:47 -06:00
trop[bot]
040e9c317e
fix: WCO buttons hidden on Linux in fullscreen ( #44640 )
...
Closes https://github.com/electron/electron/issues/44569 .
Fixes an issue where the WCO buttons were hidden on Linux in fullscreen mode
but not on Windows or macOS. The Windows behavior is the expected one, so this
commit makes the Linux behavior consistent.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-13 16:54:37 +01:00
trop[bot]
eddae27077
fix: add theme data source for devtools. ( #44635 )
...
* fix: add theme data source for devtools.
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* chore: add ut.
Co-authored-by: bill.shen <shenyb32768@gmail.com>
* chore: remove recording histograms
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* fix: add theme data source for devtools.
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* chore: separate files
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* chore: separate files
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* chore: remove pragma once
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* chore: fix lint issue.
Co-authored-by: bill.shen <shenyb32768@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
2024-11-13 16:04:39 +01:00
electron-roller[bot]
5e07ab9728
chore: bump chromium to 130.0.6723.127 (33-x-y) ( #44638 )
...
chore: bump chromium in DEPS to 130.0.6723.127
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-11-13 15:33:51 +01:00
trop[bot]
3e4c5dcc28
test: exercise fuller globalShortcut matrix ( #44625 )
...
test: test fuller globalShortcut matrix
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-12 18:24:10 -06:00
trop[bot]
2f20dbea55
fix: segfault when moving WebContentsView between BrowserWindows ( #44613 )
...
* fix: segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: actually enable fix
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-11 22:09:29 -05:00
electron-roller[bot]
c9d026e19b
chore: bump chromium to 130.0.6723.118 (33-x-y) ( #44591 )
...
chore: bump chromium in DEPS to 130.0.6723.118
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-11-07 11:14:43 -05:00
reito
65cd09ffaf
feat: GPU shared texture offscreen rendering (33-x-y) ( #44511 )
...
* feat: GPU shared texture offscreen rendering
* fix: EmitWarning in node utils.
Signed-off-by: reito <cnschwarzer@qq.com>
* fix: resolve conflict and reformat
---------
Signed-off-by: reito <cnschwarzer@qq.com>
2024-11-07 09:41:09 -05:00
electron-roller[bot]
c8dc8717a4
chore: bump chromium to 130.0.6723.116 (33-x-y) ( #44583 )
...
chore: bump chromium in DEPS to 130.0.6723.116
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-11-06 13:20:11 -05:00
trop[bot]
6e44a274e9
chore: remove executable flag from docs/api/app.md file permissions ( #44578 )
...
chore: set docs/api/app.md file permissions to 644
md files should not be executable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-05 12:01:25 -05:00
trop[bot]
743fe6f4b4
test: fixup flaky session tests ( #44565 )
...
test: fixup broken tests in 32-x-y (#44389 )
* test: fixup broken tests in 32-x-y
* test: fixup additional failing test
(cherry picked from commit c61bb1654e
2024-11-04 19:21:59 -05:00
trop[bot]
bd81baaf04
fix: remove use of banned std::to_string() ( #44563 )
...
Use base::NumberToString() instead
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#std_sto_i_l_ul_ll_ull_f_d_ld_to_string_banned
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-04 18:00:39 -06:00
trop[bot]
6e1d940ef3
docs: capitalize POSIX and Windows correctly ( #44558 )
...
* docs: capitalize POSIX correctly
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* docs: capitalize Windows correctly
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-04 17:01:50 -05:00
trop[bot]
be69311692
build: add new status to verify if all the required gha jobs have run ( #44553 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-04 16:41:12 -05:00
