trop[bot]
8b3f2c5d7c
fix: trace-startup crashing child process on macOS ( #44276 )
...
* fix: trace-startup crashing child process on macOS
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: disable test on linux arm
* chore: also disable on linux arm64
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-10-17 22:23:30 -04:00
trop[bot]
ad9bf6b041
fix: Linux crash after webContents.print() with no parent window ( #44285 )
...
fix: Linux crash after print with no parent window
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-17 22:21:57 -04:00
trop[bot]
32822cd747
build: remove dead code in prepare release script ( #44289 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-10-17 17:10:49 -04:00
trop[bot]
e1419b2fdf
fix: ensure utilityProcess only emits one 'exit' event ( #44266 )
...
fix: ensure utilityProcess only emits one exit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-16 15:01:09 -04:00
electron-roller[bot]
11c2b61011
chore: bump chromium to 130.0.6723.59 (33-x-y) ( #44271 )
...
chore: bump chromium in DEPS to 130.0.6723.59
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-16 11:01:31 -04:00
trop[bot]
6b458c78b0
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() ( #44260 )
...
* fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211 )
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-16 15:03:38 +02:00
trop[bot]
77324ff514
build: update devcontainer sha ( #44245 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-15 09:19:27 -05:00
Keeley Hammond
63d1d9cb65
fix: SCContentSharingPicker crash in iframes ( #44228 )
...
fix: SCContentSharingPicker crash in iframes (#43905 )
When running `getDisplayMedia` from an `iframe` and then destroying that
`iframe`, the destrutcor for ScreenCaptureKitDeviceMac gets run, but it
doesn't clean up the observers for the shared macOS picker.
In this change we remove the observer on cleanup and fix the associated
crash:
*** Terminating app due to uncaught exception 'NSGenericException', reason: '*** Collection <__NSArrayM: 0x12c024123a0> was mutated while being enumerated.'
0 CoreFoundation 0x000000018eda0ec0 __exceptionPreprocess + 176
1 libobjc.A.dylib 0x000000018e886cd8 objc_exception_throw + 88
2 CoreFoundation 0x000000018ee47f80 -[__NSSingleObjectEnumerator init] + 0
3 ScreenCaptureKit 0x000000022971f3e0 -[SCContentSharingPicker contentPickerDidSelectFilter:forStream:] + 436
4 ReplayKit 0x00000001d7b879d8 -[RPScreenRecorder contentPickerDidSelectFilter:forStream:] + 84
5 ReplayKit 0x00000001d7b95ce0 -[RPDaemonProxy contentPickerDidSelectFilter:forStream:] + 224
6 CoreFoundation 0x000000018ed0e8b4 __invoking___ + 148
7 CoreFoundation 0x000000018ed0e72c -[NSInvocation invoke] + 428
8 ReplayKit 0x00000001d7b91678 -[RPDaemonProxy connection:handleInvocation:isReply:] + 316
9 Foundation 0x0000000190899f64 -[NSXPCConnection _decodeAndInvokeMessageWithEvent:reply:flags:] + 1108
10 Foundation 0x000000019089b7d0 message_handler_message + 88
11 Foundation 0x000000018feb0160 message_handler + 152
12 libxpc.dylib 0x000000018e954460 _xpc_connection_call_event_handler + 144
13 libxpc.dylib 0x000000018e952bb4 _xpc_connection_mach_event + 1120
14 libdispatch.dylib 0x000000018ea94718 _dispatch_client_callout4 + 20
15 libdispatch.dylib 0x000000018eab0c00 _dispatch_mach_msg_invoke + 464
16 libdispatch.dylib 0x000000018ea9bae8 _dispatch_lane_serial_drain + 368
17 libdispatch.dylib 0x000000018eab1954 _dispatch_mach_invoke + 456
18 libdispatch.dylib 0x000000018ea9bae8 _dispatch_lane_serial_drain + 368
19 libdispatch.dylib 0x000000018ea9c79c _dispatch_lane_invoke + 432
20 libdispatch.dylib 0x000000018eaa77e8 _dispatch_root_queue_drain_deferred_wlh + 288
21 libdispatch.dylib 0x000000018eaa7034 _dispatch_workloop_worker_thread + 540
22 libsystem_pthread.dylib 0x000000018ec433d8 _pthread_wqthread + 288
23 libsystem_pthread.dylib 0x000000018ec420f0 start_wqthread + 8
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
2024-10-14 13:51:20 -04:00
trop[bot]
dd5bce17cb
docs: update timelines for E34 ( #44225 )
...
update dates for e34
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: George Xu <george.xu@slack-corp.com>
2024-10-14 13:51:06 -04:00
trop[bot]
258a4a76cf
fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream ( #44223 )
...
* chore: rename v8_value_serializer.cc,h to v8_util.cc,h
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* feat: add electron::util::as_byte_span(v8::Local<v8::ArrayBuffer>)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: -Wunsafe-buffer-usage warnings in ChunkedDataPipeReadableStream::ReadInternal()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5619253
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: restore node buffer span util
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove redundant span wrapper
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-14 11:37:40 -05:00
trop[bot]
f269ca1d93
test: fix visibility-state-spec.ts flaky test ( #44199 )
...
* test: refactor visibility-state-spec
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* ci: shard tests
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* test: update split-tests for use on Windows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* test: run visibility-state-spec.ts first
Co-Authored-By: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-14 09:39:19 -04:00
trop[bot]
7887395e92
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers ( #44208 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-11 18:31:27 -05:00
trop[bot]
9011532b2e
fix: clang variable configuration in generated node headers ( #44200 )
...
* fix: clang variable configuration in generated node headers
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: restore value in common.gypi
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 12:25:42 -05:00
trop[bot]
afce3ce7c7
docs: clarify interplay between utility process events ( #44203 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2024-10-11 09:36:32 -05:00
trop[bot]
eb90fb3b9e
ci: don't call datadog test logging on forks ( #44193 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 09:43:24 -04:00
trop[bot]
6964b79e68
refactor: spanify image utils ( #44178 )
...
* refactor: electron::util::AddImageSkiaRepFromJPEG() takes a span arg
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: electron::util::AddImageSkiaRepFromPNG() takes a span arg
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: electron::util::AddImageSkiaRepFromBuffer() takes a span arg
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* feat: add Node-buffer-to-base-span helper function
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: electron::api::NativeImage::CreateFromPNG() now takes a span param
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: electron::api::NativeImage::CreateFromJPEG() now takes a span param
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use base::as_byte_span()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: -Wunsafe-buffer-usage warning in NativeImage::CreateFromNamedImage()
Warning fixed by this commit:
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: error: function introduces unsafe buffer manipulation [-Werror,-Wunsafe-buffer-usage]
131 | {reinterpret_cast<const uint8_t*>((char*)[png_data bytes]),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
132 | [png_data length]});
| ~~~~~~~~~~~~~~~~~~
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: note: See //docs/unsafe_buffers.md for help.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add // SAFETY comment for Node-buffer-to-span func
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add // SAFETY comment for NSData-to-span func
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-10 13:24:26 -04:00
electron-roller[bot]
5bb1bb9b7a
chore: bump chromium to 130.0.6723.44 (33-x-y) ( #44177 )
...
chore: bump chromium in DEPS to 130.0.6723.44
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-10 12:07:44 -04:00
trop[bot]
78cb71f7b1
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() ( #44171 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 22:25:34 -05:00
trop[bot]
c9474ef5da
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() ( #44169 )
...
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 19:05:24 -05:00
trop[bot]
5244fcecd3
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44163 )
...
fixup e8948397
2024-10-09 16:30:45 -05:00
trop[bot]
af5901bc6a
ci: add datadog test logging ( #44141 )
...
* ci: add datadog test logging
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* ci: only upload to datadog when running tests
(cherry picked from commit c3200d8f1540f78c25673a4a9d9af3b8506f9474)
* Trigger CI
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-09 11:40:53 -04:00
trop[bot]
4e6e77d696
refactor: revert url::DomainIs() for cookie domains ( #44154 )
2024-10-08 20:34:55 -07:00
electron-roller[bot]
9469efb4c9
chore: bump node to v20.18.0 (33-x-y) ( #44118 )
...
* chore: bump node in DEPS to v20.18.0
* chore: update patches
(cherry picked from commit b108b649c263302590cbea83f90e27e371623799)
* src: improve buffer.transcode performance
https://github.com/nodejs/node/pull/54153
(cherry picked from commit 669984dafcb698716fc02a03e4cf027767a6ec59)
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-08 11:21:56 -04:00
electron-roller[bot]
8cbe09d412
chore: bump chromium to 130.0.6723.31 (33-x-y) ( #44111 )
...
chore: bump chromium in DEPS to 130.0.6723.31
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-03 16:05:06 -05:00
Samuel Attard
e9cb85bea6
build: add import/order eslint rule ( #44106 )
...
build: add import/order eslint rule (#44085 )
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-02 20:52:01 -07:00
trop[bot]
479caedc8a
fix: remove use of deprecated API base::Hash() ( #44103 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 19:14:02 -05:00
trop[bot]
86d86768b3
fix: deprecated API and -Wunsafe-buffer-usage warnings in AsarFileValidator ( #44105 )
...
* refactor: const correctness
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: extract-method AsarFileValidator::EnsureHashExists()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use span API in AsarFileValidator::OnRead()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! refactor: use span API in AsarFileValidator::OnRead()
fix: electron-ia32-testing FTBFS
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 19:13:34 -05:00
trop[bot]
bd0277923f
build: fix relative file read during npm publish ( #44089 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-10-01 17:14:02 -07:00
trop[bot]
dd8c3b8dd9
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI ctor ( #44074 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI constructor
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-01 16:14:46 -05:00
trop[bot]
6074f7ed31
build: cleanup release scripts, separate cli entrypoints from logic ( #44082 )
...
* build: cleanup release scripts, separate cli entrypoints from logic
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: use repo/org constants
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-10-01 14:08:15 -07:00
trop[bot]
7b14a305f8
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() ( #44073 )
...
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-01 13:52:00 -05:00
trop[bot]
0646cbfba6
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() ( #44075 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-01 13:51:06 -05:00
Samuel Attard
8af5c6d130
build: update some build dependencies ( #44069 )
...
* build: update some build dependencies (#43882 )
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
* build: s/colors/chalk
2024-10-01 11:09:28 -07:00
dependabot[bot]
ac10ddaa48
build(deps): bump actions/checkout from 4.1.7 to 4.2.0 ( #44040 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.7 to 4.2.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](692973e3d9...d632683dd7
2024-10-01 11:16:20 -05:00
Samuel Attard
fc9cda72d2
build: convert all release scripts to typescript ( #44059 )
...
* build: convert all release scripts to typescript (#44035 )
* build: convert all release scripts to typescript
* fix test imports
* build: fix version bumper export
* refactor: use as const
* spec: fix bad type spec
* build: use ts-node to spawn the version-bumper (#44057 )
Missed this in the tsification, we should probably call this via API instead of spawning a sub-proc?
* build: still colors
2024-10-01 12:04:22 +02:00
dependabot[bot]
52a8d133cd
build(deps): bump github/codeql-action from 3.26.8 to 3.26.10 ( #44039 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.8 to 3.26.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](294a9d9291...e2b3eafc8d
2024-09-30 17:22:50 -07:00
trop[bot]
e019b37231
fix: -Wunsafe-buffer-usage warnings in AddComponentResourceEntries() ( #44031 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
just replace pointer-and-length args with a span
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-30 14:40:42 -05:00
trop[bot]
c8788f8217
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() ( #44028 )
...
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: savepoint
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: savepoint
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: savepoint
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: savepoint
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove logging
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: unconditionally write
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: naming
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add code comments
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: more code comments
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove unrelated changes
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove redundant static keyword on function in anonymous namespace
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: naming
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: naming
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: naming
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: slightly more explicit typing
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove unused #includes
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-30 11:59:24 -04:00
trop[bot]
4d16326b4d
fix: FTBFS when building with enable_plugins = false ( #44025 )
...
* fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
it fails to build from source with this error:
../../content/public/browser/plugin_service.h:17:2: error: "Plugins should be enabled"
17 | #error "Plugins should be enabled"
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: FTBFS in printing_utils.cc when ENABLE_PDF is false
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
fix BUILD.gn linting
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-30 06:23:18 -05:00
Charles Kerr
5836ea1a78
feat: add error event for utility process (33-x-y) ( #43997 )
...
* feat: add error event for utility process (#43774 )
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fixup! feat: add error event for utility process (#43774 )
remove #include "electron/mas.h"
this header did not exist before c1c8fbfd9
2024-09-29 17:12:15 -05:00
trop[bot]
d8cd86c4fa
ci: write test logging to console on Windows ( #44007 )
...
test: write logging to console on Windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-29 09:55:09 +02:00
Charles Kerr
a44059aa05
fix: ensure correct WebContents when checking PDFReadyToPrint (33-x-y) ( #43998 )
...
* fix: ensure correct `WebContents` when checking `PDFReadyToPrint` (#43943 )
* fix: ensure correct WebContents when checking PDFReadyToPrint
* test: fix paths on Windows
* Update spec/api-web-contents-spec.ts
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-27 17:05:42 -04:00
Charles Kerr
73c1413374
build: use Node 20 in Appveyor images (33-x-y) ( #44002 )
...
build: use Node 20 in Appveyor images (#43897 )
* build: update Appveyor to Node 20
* build: update appveyor images
* chore: return bake script to original form
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
2024-09-27 14:47:17 -04:00
trop[bot]
ce2163da2f
fix: remove resize listener when BrowserWindow closed ( #44000 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-27 14:46:22 -04:00
trop[bot]
481f9b25a7
chore: remove unused nogncheck includes ( #43991 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 21:49:42 -05:00
trop[bot]
9ca68e2b8c
perf: build g_dgettext domain name at compile time ( #43987 )
...
perf: build GettextPackage name at compile time
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 17:07:21 -05:00
trop[bot]
9ef7ec02e5
fix: replace deprecated libnotify API calls ( #43983 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 13:59:21 -04:00
electron-roller[bot]
e32e85abb2
chore: bump chromium to 130.0.6723.19 (33-x-y) ( #43975 )
...
* chore: bump chromium in DEPS to 130.0.6723.19
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-26 12:47:11 -04:00
trop[bot]
6973af4f7a
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43980 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 11:21:24 -05:00
John Kleinschmidt
625d950e32
docs: document breaking change in 33, not 32 ( #43977 )
2024-09-26 09:07:04 -04:00
