mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
21454 commits 1 branch 183 tags 5.3 GiB
Commit graph

858 commits

Author SHA1 Message Date
Shelley Vohr
8991c0056e
feat: promisify dialog.showMessageBox() (#17298) 
* feat: promisify dialog.showMessageBox()

* address feedback from review
 2019-03-12 11:06:59 -07:00
Samuel Attard
c7a453226d
fix: remove label/image from segment if they are mutated to undefined/null (#17323) 2019-03-11 11:13:36 -07:00
deepak1556
ac609a3d78 Remove deprecated override of RegisterDictionaryPref 
https://chromium-review.googlesource.com/c/chromium/src/+/1459538
 2019-03-08 15:04:32 -08:00
deepak1556
59cb0ac32e Copy base::JSONReader::Read() to ReadDeprecated(). 
https://chromium-review.googlesource.com/c/chromium/src/+/1435715
 2019-03-08 15:04:32 -08:00
deepak1556
6f14df039e [DevTools] Stop passing base::Value to DevToolsManagerDelegate 
https://chromium-review.googlesource.com/c/chromium/src/+/1459807
 2019-03-08 15:04:32 -08:00
Shelley Vohr
6cb7b8d3a4
feat: promisify dialog.showSaveDialog() (#17054) 
* feat: promisify dialog.showSaveDialog()

* address some feedback from review

* filename => filePath

* fix last filename => filePath
 2019-03-05 13:48:20 -08:00
Shelley Vohr
e05985145b
feat: promisify dialog.showOpenDialog() (#16973) 
* feat: promisify dialog.showOpenDialog()

* address feedback from review

* address feedback from review
 2019-03-05 05:54:48 -08:00
Robo
7936237677
build: enable gn check for //electron:electron_lib (#17100) 
* build: enable gn check for //electron:electron_lib

* ci: add gn check step

* ci: set depot_tools path

* chrome_key_systems_provider.h nogncheck

* chore: fix gn check errors on windows

* chore: gn check //electron:electron_app
 2019-03-05 10:38:55 +05:30
Charles Kerr
ed31cfebc9
fix: check for pane focus before removing it. (#17164) 
Fixes #16883. This bug seems to have been introduced in the #15302's
menu a11y refactor and is new in 5-0-x.
 2019-03-04 09:47:59 -06:00
Shelley Vohr
544d8a423c
feat: allow MenuItems to work optionally when hidden (#16853) 
* feat: allow MenuItems to work optionally when hidden

* fix: actually include forward_declaration
 2019-02-28 17:00:54 +00:00
Samuel Attard
e01c3615c4
chore: replace usage of deprecated beginSheetModalForWindow API (#16994) 2019-02-27 10:23:17 -08:00
Johann Fuechsl
42aa375497 fix: access of out-of-scope reference in ShowOpenDialog and ShowSaveDialog (#17126) 
In the mac file dialog implementation of show*OpenDialog, a settings
object is passed down to the dialog completion handler.
However at the time the completion handler is invoked, the settings
object is already out-of-scope, resulting in an invalid access to
the security_scoped_bookmarks flag.
The fix is to capture the value of the flag and passing that directly
to the completion handler.

fixes issue #16664
 2019-02-27 08:14:04 +00:00
Milan Burda
5e762d6a47 chore: finalize dropping support for OS X Mavericks (version 10.9) (#17102) 2019-02-25 17:21:57 +00:00
deepak1556
d7fea1b484 REVIEW: fix possible -Wdeprecated-declarations warnings 2019-02-14 23:59:26 +05:30
deepak1556
3727982217 Delete tab pulsing feature. 
https://chromium-review.googlesource.com/c/chromium/src/+/1407958
 2019-02-14 23:59:25 +05:30
deepak1556
70bbbb84bb Rename BlendTowardOppositeLuma() to BlendTowardContrastingEndpoint(). 
https://chromium-review.googlesource.com/c/chromium/src/+/1400060
 2019-02-14 23:59:25 +05:30
Jeremy Apthorp
34d7e019ce gfx::Path -> SkPath 
https://chromium-review.googlesource.com/c/1392181
 2019-02-14 23:59:25 +05:30
deepak1556
315f8c0cc7 DevToolsFrontendHost::Create to return unique_ptr instead of raw pointer 
https://chromium-review.googlesource.com/c/chromium/src/+/1396614
 2019-02-14 23:59:23 +05:30
deepak1556
9b82e7d27b Change DevToolsEmbedderMessageDispatcher to use unique_ptr instead of raw pointers. 
https://chromium-review.googlesource.com/c/chromium/src/+/1382701
 2019-02-14 23:59:23 +05:30
deepak1556
abec938b0a Use base::size rather than arraysize 
https://bugs.chromium.org/p/chromium/issues/detail?id=837308
 2019-02-14 23:59:22 +05:30
John Kleinschmidt
46f818b0c3
feat: add file preview for GTK file picker (#16447) 2019-02-13 06:52:14 -10:00
Heilig Benedek
ccc60a1f33 fix: enable autofill popups on mac (#16308) 
* feat: enable autofill popups on mac

* fix: make popup positioning better

* fix: don't try to show popup when widget is closing or not visible

* fix: unify conditions

* refactor: use PopupViewCommon from chrome directly

* lint: mark constructor explicit

* fix: use a patch instead of dummy functions to make things compile on Windows

* chore: address review suggestions

* Update atom/browser/ui/cocoa/views_delegate_mac.mm

Co-Authored-By: brenca <benecene@gmail.com>
 2019-02-11 09:38:58 -10:00
Shelley Vohr
1898f91620
fix: enable property having no effect on submenus (#16835) 2019-02-08 18:07:08 -08:00
Shelley Vohr
ccf46a57bc fix: display empty menu item for non-visible submenus (#16832) 
* fix: display empty menu item for nonvisible submenus

* use Chromium UI string ID
 2019-02-08 13:19:01 -08:00
Shelley Vohr
062778c031 fix: don't construct submenu if it's invisible (#16834) 2019-02-08 12:54:39 -08:00
Julien Isorce
27bd47a333 feat: implement BrowserWindow.moveTop on X11 (#16629) 
It was implemented on Mac and Win but not on X11.
Tested on Ubuntu 16.04 and 18.04.

Also added a unit test in spec/api-browser-window-spec.js.
This test BrowserWindow.moveTop verifies that calling moveTop
on a window does not give the focus to this window.

notes: BrowserWindow.moveTop is now available on Linux/x11

https://github.com/electron/electron/issues/12516
 2019-02-07 12:48:19 -08:00
Heilig Benedek
cbb5164cc8 fix: improve the way frameless windows are handled on Windows (#16596) 
* fix: improve the way frameless windows are handled on Windows

* tidy up code

* fix: return nullAcceleratedWidget instead of nullptr

* fix: format, use reinterpret cast
 2019-01-31 11:19:47 +09:00
Cheng Zhao
323b688ab8 fix: check the root window in MenuBar::SetPanelFocus (#16581) 2019-01-29 13:21:32 -08:00
deepak1556
ed5a865efb Update GetAccessibleName() in view::ImageView and view::Button 
https://chromium-review.googlesource.com/c/chromium/src/+/1256308
 2019-01-22 10:32:05 -08:00
deepak1556
90b6d13714 Remove menu_marker from MenuButton. 
https://chromium-review.googlesource.com/c/chromium/src/+/1324375
 2019-01-22 10:32:05 -08:00
deepak1556
85333a5974 Move ViewsDelegate::NotifyAccessibilityEvent to an observer pattern 
https://chromium-review.googlesource.com/c/chromium/src/+/1352265
 2019-01-22 10:32:05 -08:00
Jeremy Apthorp
deff96a1b0 NativeWidgetMac::CreateNSWindow params changed 
https://chromium-review.googlesource.com/c/1295251
 2019-01-22 10:32:04 -08:00
Jeremy Apthorp
d228bdfb9e gfx::NativeView is no longer NSView on mac 
https://chromium-review.googlesource.com/c/1270343
 2019-01-22 10:32:04 -08:00
Jeremy Apthorp
30e5e993c1 HandleKeyboardEvent returns bool 
https://chromium-review.googlesource.com/c/chromium/src/+/1262404
 2019-01-22 10:32:03 -08:00
Milan Burda
52e257668d fix: windowmenu did not show the window list on macOS (#16387) 2019-01-14 17:27:52 +01:00
Robo
52fe92d02e feat: Upgrade to Chromium 71.0.3578.98 (#15966) 2019-01-11 17:00:43 -08:00
Samuel Attard
f8f091c250 chore: update GetLabelFrontList to be GetLabelStyle in menu model 
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1186702
 2018-12-03 20:07:41 +05:30
Samuel Attard
92f50664d0 chore: fix linting 2018-12-03 20:07:41 +05:30
deepak1556
97aa7b8e68 Use CompletionOnceCallback in URLFetcherResponseWriter. 
https://chromium-review.googlesource.com/c/chromium/src/+/1155087
 2018-12-03 20:07:41 +05:30
deepak1556
f464b8c4c5 Respond for handling protocol commands async 
https://chromium-review.googlesource.com/c/chromium/src/+/1139575
 2018-12-03 20:07:40 +05:30
Samuel Attard
6b4b7c9831 chore: make BrowserObserver a CheckedObserver 
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1053338
 2018-12-03 20:07:38 +05:30
Sylvester Keil
2e91bf1e15 Fix GTK menubar item color (#15878) 
Use menubar item color (not menu item color).
Closes #15194
 2018-11-30 09:28:45 -08:00
Milan Burda
81e00d8e56 chore: fix V8 deprecation warnings (#15842) 2018-11-27 16:42:02 -05:00
Milan Burda
d63a848011 feat: add activate option to webContents.openDevTools (#13852) 2018-11-27 18:34:44 +09:00
Heilig Benedek
0242818f39 feat: add registerAccelerator flag to allow menu items to optionally skip accelerator registration (#15723) 
* feat: add registerAccelerator flag to allow menu items to skip registration

* docs: add docs for registerAccelerator

* docs: re-add accidentally removed line
 2018-11-26 10:43:55 -08:00
Charles Kerr
40619efb3b chore: remove FileChooser AddExtensionForFilename (#15510) 2018-11-20 16:24:39 -05:00
Shelley Vohr
9fd98bb27b
refactor: no longer require submenu for services menuitem (#15656) 2018-11-10 12:47:55 -05:00
Nitish Sakhawalkar
5994bf6745
fix: Menu accelerators not working (#15094) 
This change fixes the regression in the menu accelerators working in linux, on some environments.
 2018-11-09 13:54:16 -08:00
Heilig Benedek
ca2d74e118 feat: add methods to allow customization of save dialog during will-download event (#15497) 
* feat: add method to DownloadItem that allows customization of dialog options

* docs: add docs for get/setSaveDialogOptions

* add missing copy constructor for DialogSettings on mac and linux

* fix: don't filter dialog options for mas build, don't return properties

* test: add test for get/setSaveDialogOptions

* fix: remove openDevtools added for debugging

* test: fix failing test because of new event parameter

* docs: use SaveDialogOptions instead of Object
 2018-11-08 10:51:06 -04:00
Jeremy Apthorp
934a7fc118
refactor: don't use AppIndicatorIcon directly (#15536) 2018-11-06 11:00:37 -08:00