Charles Kerr
dba9181611
Merge pull request #11164 from electron/nstitlebar-hidden
...
fix: Explicitally set "setTitlebarAppearsTransparent"
2017-11-21 07:51:47 +01:00
Cheng Zhao
cb98ed8674
Merge pull request #11176 from electron/proxy-crash-race
...
Avoid proxy handler race condition crash
2017-11-20 20:15:02 +09:00
Cheng Zhao
3cc8330998
Merge branch 'master' into ahmedmohamedali-master
2017-11-20 11:04:47 +09:00
Matt Crocker
efaf7a6b85
Avoid race condition where login handler webcontents becomes null
2017-11-19 14:08:11 -08:00
Felix Rieseberg
daad465fcd
🔧 Eh, let's do it for all the types
2017-11-18 20:19:22 -08:00
Felix Rieseberg
e3b6271806
🔧 setTitlebarAppearsTransparent=YES
2017-11-18 20:00:01 -08:00
Thiago de Arruda
a9a9e58b68
Fix random crash on app quit.
...
Move AtomCTDelegate to brightray as RequireCTDelegate and transfer ownership to
brightray::URLRequestContextGetter. This fixes the wrong lifetime assumptions
that result in AtomCTDelegate being used after free in some scenarios.
Close #10051
2017-11-17 12:03:23 -03:00
Ted Kim
8184cbfb06
Implement login helper to manage login item in Mac App Store build
2017-11-17 10:53:09 +09:00
Alexey Kuzmin
8657169017
Revert "Implement login helper to manage login item in Mac App Store build"
2017-11-16 19:05:13 +03:00
Charles Kerr
31172ecaa0
Merge pull request #11008 from electron/implement-stream-protocol
...
Implement {register,intercept}StreamProtocol
2017-11-14 09:31:57 -06:00
Cheng Zhao
4b8ab8fc97
Merge pull request #10856 from dittos/mas-login-helper
...
Implement login helper to manage login item in Mac App Store build
2017-11-14 21:34:50 +09:00
Thiago de Arruda
5ea3a5886b
Implement {register,intecept}StreamProtocol
...
These new functions are more flexible than the other
{intercept,register}*ProtocoProtocol functions, since it allows the user to
return a node.js stream to feed the data to the protocol handler.
It also allows the user to specify a response header dictionary, which makes it
possible to correctly intercept any request made from renderers.
2017-11-13 16:16:14 -03:00
Thiago de Arruda
68f514b92f
Implement EventSubscriber<T> class.
...
This class simplifies the task of subscribing/handling javascript events from
C++ classes in the main process.
2017-11-13 15:22:50 -03:00
Thiago de Arruda
6b666b69c0
Implement GetLoadTimingInfo in JsAsker class.
...
This is required to avoid a crash in blink when implementing a custom protocol
handler that deals with redirects.
2017-11-13 15:20:56 -03:00
Thiago de Arruda
6b2ddc4814
Stop allowing electron.net requests to be intercepted.
...
Not very useful to intercept requests from `electron.net`, since both the
interception machinery and `electron.net` live in the browser process.
2017-11-13 15:20:46 -03:00
Cheng Zhao
72440d4ae7
No need to add new methods to WebContentsPreferences
2017-11-13 17:35:49 +09:00
Cheng Zhao
cee1c459c7
Do not accidentally change the behavior of did-change-theme-color
2017-11-13 16:20:54 +09:00
Cheng Zhao
7e0593950c
Code style fixes
2017-11-13 16:13:54 +09:00
Heilig Benedek
276e12ce71
pass on web_contents to properly handle devtools
2017-11-13 15:50:50 +09:00
Heilig Benedek
26daffea9c
use smart pointer for paint_canvas
2017-11-13 15:50:49 +09:00
Heilig Benedek
4b10445c2e
lint fix
2017-11-13 15:50:49 +09:00
Heilig Benedek
193beb57c9
fix datalist element popup position when menu is hidden
2017-11-13 15:50:49 +09:00
Heilig Benedek
f8b3009ebf
restructure code to use web_preferences if possible
2017-11-13 15:50:49 +09:00
Heilig Benedek
71b36ef54d
don't show the dummy window for the rest of the dialogs too on mac
2017-11-13 15:46:46 +09:00
Heilig Benedek
13b86598e8
don't show osr dummy window when dialog is shown on mac
2017-11-13 15:46:46 +09:00
Heilig Benedek
35dc6d03b9
lint fix
2017-11-13 15:46:46 +09:00
Heilig Benedek
e39aacb30e
fix a bug that caused a crash when using an offscreen window with detached devtools, related to autofill popups
2017-11-13 15:46:46 +09:00
Samuel Attard
a06a8a6f79
Merge pull request #11056 from ajmacd/allow-browser-window-logs
...
Allow BrowserWindows to emit `console-message` events.
2017-11-11 14:34:39 +11:00
Ahmed
9b3960fe90
Merge branch 'master' into master
2017-11-08 18:03:55 +01:00
Samuel Attard
bb997c2ea4
Forward declare the scrubber layout
2017-11-08 16:48:08 +13:00
Andrew MacDonald
c260a0ab78
Allow BrowserWindows to emit console-message events.
2017-11-07 15:31:15 -08:00
Armagan Amcalar
edd113548a
Make ScrubberItem width dynamic
...
Depending on whether a ScrubberItem has text or an icon, this changeset
calculates the actual width and sizes the TouchBar items accordingly.
Previously, all ScrubberItems, regardless of their content, had a static
width of 50px.
This commit also fixes #10539 .
2017-11-07 00:09:14 +01:00
John Kleinschmidt
5383b4809f
v1.8.2-beta.2
2017-11-06 16:11:34 -05:00
Charles Kerr
4ceeddc09f
Merge pull request #10972 from electron/dpi-issues
...
Workaround for Windows DPI issues
2017-11-02 10:16:11 -05:00
Felix Rieseberg
e8f8100e19
🔧 Add fixme
2017-11-01 11:30:32 -07:00
Felix Rieseberg
58708d6242
🔧 Lowercase
2017-10-31 10:31:05 -07:00
Felix Rieseberg
08b8f2df55
📝 Typo!
2017-10-31 08:38:33 -07:00
Felix Rieseberg
91414dde62
🔧 I can't believe this helps
2017-10-30 11:22:07 -07:00
Samuel Attard
c9926bed9f
Merge pull request #10954 from electron/less-process-metrics-warnings
...
fix: Don't call idleWakeupsPerSecond on Windows
2017-10-28 12:36:45 +13:00
Samuel Attard
dc8b583363
Merge pull request #10944 from electron/fix-notification-ref-crash
...
Close the previous notification on multiple calls to show
2017-10-28 12:33:30 +13:00
Felix Rieseberg
da21d6cdda
🔧 Don't call idleWakeupsPerSecond on Windows
2017-10-27 14:23:06 -07:00
Matt Crocker
b6fb016a9a
Cleanup per review comment
2017-10-27 00:07:54 -07:00
Matt Crocker
77a26882a3
Make linter happy
2017-10-27 00:04:19 -07:00
Matt Crocker
c5914516c8
Upstream good ideas from Muon
2017-10-27 00:04:19 -07:00
Matt Crocker
ca8f45a501
Notifications should emit close on close, not eventual GC
2017-10-27 00:04:19 -07:00
Samuel Attard
8719e9f098
Definitely didn't forget to push the header file
2017-10-27 16:27:37 +13:00
Samuel Attard
fe9069c028
Close the previous notification on multiple calls to show
2017-10-27 16:22:21 +13:00
Paul Frazee
c2d9e082cb
Fix crash in custom protocols caused by bad callback exec
2017-10-25 21:01:53 -05:00
John Kleinschmidt
67f0eb7b3b
Merge pull request #10873 from ahmedmohamedali/fix_issue_10697
...
Fixes #10697
2017-10-23 09:32:28 -04:00
Ahmed Mohamed Ali
463260b249
Electron crashes if user clicks Dev Tools & Zoom options #10697
2017-10-21 22:21:24 +02:00
Ted Kim
4119da607f
Implement login helper to manage login item in Mac App Store build
2017-10-20 11:44:19 +09:00
Ahmed Mohamed Ali
9f3cfa2dbd
Fix crash that happens when the PDF viewer is refreshed.
...
The root cause is the PdfViewerHandler instanceis destroyed but not removed from the list of observer in WebContentsZoomController
2017-10-19 16:27:08 +02:00
John Kleinschmidt
90e7d7e112
v1.8.2-beta.1
2017-10-18 16:49:32 -04:00
Ahmed Mohamed Ali
05035eb1e3
Fix linefeeds
2017-10-18 17:36:56 +02:00
John Kleinschmidt
57537ea10e
Merge pull request #10810 from qazbnm456/add_error_code_to_session_set_certificate_verify_proc
...
Add error code to session.setCertificateVerifyProc
2017-10-18 09:33:37 -04:00
John Kleinschmidt
cbda307ebf
Merge pull request #10696 from primalmotion/patch-1
...
🍎 skip tabbing category if macOS < Sierra
2017-10-17 10:24:11 -04:00
Boik
f40cc5ab54
add error code to session.setCertificateVerifyProc
2017-10-16 17:17:21 +08:00
Ahmed Mohamed Ali
8763e8ee35
Fixing coding style
2017-10-14 11:17:52 +02:00
Ahmed Mohamed Ali
5030db000a
Applying changes requested by @deepak1556 after the review:
...
- Move RenderFrameHost methods in the UI thread
- Check GetAssociatedRenderFrame return value
2017-10-14 11:09:05 +02:00
Ahmed Mohamed Ali
1ad95eca4a
Add support for pdf in sub frames ( https://github.com/electron/electron/issues/9192#issuecomment-335543866 )
2017-10-13 19:56:20 +02:00
Birunthan Mohanathas
06d782279c
Add systemPreferences.removeUserDefault()
...
This can be used to restore the default or global value of a `key`
previously set with `setUserDefault`.
2017-10-10 22:57:47 +03:00
Samuel Attard
d350134c4f
Ensure that the touchbar's esape item can be set before setting it
2017-10-10 02:24:49 +11:00
Shelley Vohr
242e097e9b
Merge pull request #10670 from electron/add-linuxdefaultprotocol
...
add setAsDefaultProtocolClient for Linux
2017-10-07 10:07:02 -05:00
Shelley Vohr
443c30890b
remove dummy check
2017-10-07 10:38:08 -04:00
Shelley Vohr
35eea8bea5
remove unused xdg setting
2017-10-07 00:38:25 -04:00
Shelley Vohr
66827755e7
remove chrome check and change protocol handler
2017-10-07 00:36:18 -04:00
Shelley Vohr
a1347f67a1
remove a space from a comment wow thanks linter
2017-10-06 23:40:58 -04:00
Shelley Vohr
c9da806c84
slight refactor and lin cleanup
2017-10-06 23:32:46 -04:00
Antoine
5e6b683cfb
fixed: trying to fix the build
2017-10-05 15:57:27 -07:00
Antoine
8e1945f768
🍎 skip tabbing category if macOS < Sierra
...
Previously, the macro was ensuring the` MAC_OS_X_VERSION_10_12` was not defined to decide to compile a `NSWindow` category back porting native tabs or not.
This patch ensures to compile the `NSWindow` category only if the min required version is lesser than 1012 (`MAC_OS_X_VERSION_10_12`)
2017-10-05 14:11:58 -07:00
Shelley Vohr
f8f21815eb
syntax updates and pointer conversion
2017-10-05 00:30:14 -04:00
Cheng Zhao
bb71b09452
Fix building on Windows
2017-10-05 11:51:41 +09:00
Cheng Zhao
4342480473
Fix cpplint warnings
2017-10-05 11:49:26 +09:00
Sean Bannigan
0b205019b6
add mouse-move event and click event position for tray
2017-10-05 11:41:08 +09:00
Cheng Zhao
8c5bb5969c
Merge pull request #10667 from dittos/window-opacity
...
Add window opacity support
2017-10-04 15:03:45 +09:00
Felix Rieseberg
4e05d24d1b
Merge pull request #10661 from electron/browserview-multiple-screens
...
BrowserView: Allow dragging of window to screen above menubar
2017-10-03 16:09:11 -07:00
Shelley Vohr
6131a523dc
add xdg helper method
2017-10-03 11:10:38 -04:00
Cheng Zhao
150a4797a4
Merge pull request #10676 from qazbnm456/fix-unhandle-null-pointer
...
Add a null-pointer check before processing base::SupportsUserData::GetUserData
2017-10-03 20:18:51 +09:00
Daniel Ma
1bb042a661
feat(NativeWindowMac): addTabbedWindow
...
Add support for the [`NSWindow addTabbedWindow`][nsw] method on MacOSX
This plays nicely with the changes from #9052 and #9725
Usage samples available in [this commit][c] in my fork of
`electron-quick-start`
[nsw]: https://developer.apple.com/documentation/appkit/nswindow/1855947-addtabbedwindow
[c]: 79f06591df
2017-10-03 20:11:16 +09:00
Boik
d594092675
add a null-pointer check before processing base::SupportsUserData::GetUserData
2017-10-03 12:42:35 +08:00
Taeho Kim
7570ec9d39
Add BrowserWindow.getOpacity for consistency
2017-10-03 00:08:10 +09:00
Shelley Vohr
3f73e000ee
first pass at adding linux setAsDefaultProtocolClient
2017-10-02 10:21:30 -04:00
Taeho Kim
7df5182901
Fix lint
2017-10-02 09:52:27 +09:00
Felix Rieseberg
0cc1ebc021
🔧 Allow dragging window to screen above menubar (for real)
2017-09-29 14:20:34 -04:00
Zeke Sikelianos
9f895879bf
Merge pull request #10191 from electron/add_log_path_support
...
add ability to access logs in getPath()
2017-09-29 11:11:29 -07:00
Ted Kim
7f2c4a9e06
Add window opacity support
2017-09-29 17:49:10 +09:00
Shelley Vohr
5ef4caf8ab
add ability to access logs in getPath()
2017-09-28 13:35:22 -04:00
John Kleinschmidt
7788b33dc9
Bump v1.8.1
2017-09-28 13:13:49 -04:00
Felix Rieseberg
89246f3714
🔧 Allow dragging over menubar
2017-09-27 17:43:09 -04:00
Birunthan Mohanathas
044a3a29a6
Simplify checking for NSFullScreenWindowMask
2017-09-27 16:36:18 +03:00
Felix Rieseberg
d45788a7b8
🔧 Don't drag fullscreen window
2017-09-26 18:03:44 -04:00
Birunthan Mohanathas
e1ddd3bdbc
Stop sending resize event for minimized windows on Windows
...
This makes it consistent with macOS.
This also fixes BrowserView auto-resize on Windows when minimizing and
restoring the window. Previously it would incorrectly grow too in some
cases.
2017-09-25 11:44:32 +09:00
Birunthan Mohanathas
f3f6bedf8e
Make BrowserView auto-resize relative to window size on Windows/Linux
...
Previously it was relative to the window web contents size, which was
not consistent with macOS.
2017-09-25 11:44:32 +09:00
Cheng Zhao
b7119b5756
Create watcher when message loop is ready
2017-09-20 11:58:32 +09:00
Samuel Attard
4147fa4629
Appease the linting gods
2017-09-20 11:58:32 +09:00
Samuel Attard
0ab83b301d
Refactor as per @zcbenz comments
...
Also fix issue where we run the single instance callback *not* on the UI thread,
this apparently results in a hung process.
2017-09-20 11:58:32 +09:00
Samuel Attard
ecbeb0d117
Woops, how did that happen ;)
2017-09-20 11:58:32 +09:00
Samuel Attard
f928a399ae
Move OnBrowserReady call to PreMainMessageLoopRun to account for timing issues on macOS
2017-09-20 11:58:32 +09:00
Samuel Attard
28900a9b63
Fix app.makeSingleInstance hanging on posix systems
...
Wait for the IO thread to be a thing before attempting to listen on the socket
Fixes #9880
2017-09-20 11:58:32 +09:00
Cheng Zhao
ff023115f5
Style fixes
2017-09-14 16:12:34 +09:00
Rafael Nobre
77a1c5d7fc
Avoids deadlock in case NSUserActivityDelegate method start being called from main thread.
2017-09-14 15:59:43 +09:00
Rafael Nobre
9483f0fc14
Adds synchronization logic to allow NSUserActivityDelegate to wait Javascript updating the NSUserActiity UserInfo if requested.
2017-09-14 15:59:43 +09:00
Rafael Nobre
c23b4a48ec
Fixes NSUserActivityDelegate that was called on a background thread thus not working.
2017-09-14 15:59:43 +09:00
Rafael Nobre
76efee675f
Requests updated user info data before each Handoff operation.
2017-09-14 15:59:43 +09:00
Rafael Nobre
a870799c32
Exposes more Handoff related APIs to Electron.
2017-09-14 15:59:43 +09:00
Cheng Zhao
19a7c7ac39
Styling fixes
2017-09-14 14:43:22 +09:00
xaviergonz
e18cdc185a
add the fix for showinactive
2017-09-14 14:35:53 +09:00
xaviergonz
d0c91daaed
make sure setparentwindow only shows the window if already visible
2017-09-14 14:35:53 +09:00
xaviergonz
dc7cc6921e
fix for mac child windows so they honor show option
2017-09-14 14:35:53 +09:00
xaviergonz
dae63d323c
add new internal set parent window method
2017-09-14 14:33:24 +09:00
Cheng Zhao
a19a229a59
Merge pull request #10254 from zachflower/feature/simple-fullscreen-mode
...
Feature/simple fullscreen mode
2017-09-14 09:39:50 +09:00
Zachary Flower
432b912c6a
🎨 Rename ambiguous simple_fullscreen_ variable to always_simple_fullscreen_
2017-09-13 12:16:37 -06:00
Cheng Zhao
2048a1a638
Merge pull request #10429 from qazbnm456/web-request-origin
...
Track the origin of webRequest events
2017-09-13 22:23:44 +09:00
Cheng Zhao
c34fb146f6
Fix styling
2017-09-13 21:40:29 +09:00
Vanessa Yuen
9a7d8a0511
merge master into fix-fullscreen-with-resizable-flag.
2017-09-12 18:34:23 -04:00
Zachary Flower
fa4d52f042
🎨 Track/restore original stylemask, rather than individual states.
2017-09-12 12:27:30 -06:00
Boik
e66341ec59
add back the missing 'resourceType' property
2017-09-12 21:27:49 +08:00
Boik
a01abd0fee
fix lint-cpp
2017-09-12 20:28:30 +08:00
Boik
2d771674bb
get webContentsId instead
2017-09-12 20:17:11 +08:00
Boik
13d363d1f1
fix lint-cpp
2017-09-12 15:40:35 +08:00
Boik
549c30f9b2
first attempt to track the origin requesters of webRequest events
2017-09-12 15:40:35 +08:00
Cheng Zhao
59cadf9e4b
Merge pull request #10366 from syohex/window-close-order
...
Close window in order from newer one on macOS
2017-09-12 16:22:38 +09:00
Cheng Zhao
bca71fcfc1
Merge pull request #10393 from j3l11234/fix_mac_crack
...
fix mac ime crack
2017-09-12 16:19:08 +09:00
Cheng Zhao
8493d5707e
Fix cpplint warnings
2017-09-12 15:35:24 +09:00
Cheng Zhao
10ab870237
Merge pull request #10321 from kaylanm/macos-native-tab-api
...
🍎 Add macOS native tab methods to window API
2017-09-11 18:49:56 +09:00
Cheng Zhao
cc9771a3d0
Merge pull request #10307 from liusy182/10240-theme-color-2
...
return null when theme color is transparent or not found
2017-09-11 18:40:35 +09:00
Cheng Zhao
e6733b4b23
Merge pull request #10305 from ivmirx/macos-accessibility
...
Special attribute for macOS accessibility
2017-09-11 17:58:20 +09:00
Cheng Zhao
0694334487
Merge pull request #10271 from kaylanm/macos-native-tab-menu-items
...
🍎 Add roles for macOS native tab menu items
2017-09-11 17:41:31 +09:00
Birunthan Mohanathas
511e82de67
Fix missing extension when saving a file without filters
...
Previously, when triggering the save dialog through e.g. `<a download>`
links (e.g. http://jsfiddle.net/koldev/cW7W5/ ), the extension was only
saved if Finder was set to show all extensions by default. We now always
display the extension to make sure that it is saved.
If we want to keep the extension hidden, we could also populate the
allowed file types array with the extension from the default filename,
but that would have interfered with how we set the filters.
2017-09-07 16:48:14 -07:00
John Kleinschmidt
4b1e2b42a4
Bump v1.8.0
2017-08-31 16:16:19 -04:00
Samuel Attard
6b010614e2
Implement moveToApplicationsFolder ( #10142 )
...
* Implement moveToApplicationsFolder
* Fix tabs / spaces
* Fix linting
* Use Browser::Quit, instead of exit
* Update documentation as per feedback
* Fix spec
2017-08-31 10:37:12 -04:00
allenliu
5978775ce1
fix mac ime crack
2017-08-30 12:07:04 +08:00
Cheng Zhao
0550a4a9b8
Fix crash when emitting render-view-deleted event
2017-08-29 17:46:46 +09:00
Cheng Zhao
4febbec102
Fix crash when switching menus in menubar
2017-08-29 14:19:23 +09:00
Shohei YOSHIDA
55f2b524e7
Close window in order from newer one on macOS
...
A parent window is not closed if a child modal window still exists.
So a child window should be closed before parent window closed.
2017-08-28 13:56:05 +09:00
Ivan Mir
75b2915fee
Change the parameter name for consistency
2017-08-27 11:53:25 -03:00
Ivan Mir
6717f0d2bb
Add accessibility setter to the app
2017-08-24 11:22:28 -03:00
Samuel Attard
7ecac42214
Merge pull request #10232 from electron/drag-browser-view
...
Add -webkit-app-region support to BrowserView
2017-08-24 10:30:56 +10:00
Felix Rieseberg
fdfbf3abfa
🔧 Respect the header
2017-08-23 17:26:18 -07:00
Felix Rieseberg
a44c2d5dcc
🔧 Extend interface
2017-08-23 16:10:31 -07:00
Siyuan Liu
5cb58cd42f
use nullptr instead of nullptr_t()
2017-08-23 09:30:58 +08:00
Felix Rieseberg
cd5cd25f74
🔪 Bonus colon
2017-08-22 11:14:21 -07:00
Michael Kaylan
b4428e7e41
🍎 Add macOS native tab methods to window API
2017-08-21 23:24:30 -04:00
Cheng Zhao
565ece6986
Merge pull request #10308 from electron/native-view
...
Add WebContents.getNativeView() API
2017-08-22 09:19:27 +09:00
Felix Rieseberg
f0680587fa
🔧 Linter fascism
2017-08-21 16:52:59 -07:00
Charlie Hess
f17bd040ad
Merge pull request #10293 from electron/notification-sounds
...
Add support for soundName in main process notifications
2017-08-21 16:15:47 -07:00
Charlie Hess
db081d95d5
Review CommentZ.
2017-08-21 13:53:50 -07:00
Cheng Zhao
2c1984b6ed
Add WebContents.getNativeView API
2017-08-21 19:50:12 +09:00
Cheng Zhao
70fd42808e
Fix build on Linux
2017-08-21 17:42:45 +09:00
Cheng Zhao
19323c88f9
win: Fix "thickFrame: false" not working for normal window
2017-08-21 17:21:59 +09:00
