Shelley Vohr
832090d01c
feat: add transparency checking to nativeTheme ( #43137 )
...
feat: add transparency checking to nativeTheme
2024-08-01 12:14:07 +02:00
trop[bot]
8e21aad444
chore: remove unused & undocumented function v8Util.deleteHiddenValue() ( #43114 )
...
chore: remove unused v8Util.deleteHiddenValue()
Its last use was removed in Nov 2020 by c8d77cae4a#26659 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-31 20:07:30 -05:00
trop[bot]
31551aba9d
fix: vibrant view is inserted into Views API hierarchy ( #43128 )
...
* fix: vibrant view is inserted into Views API hierarchy (#42263 )
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu>
* Update shell/browser/native_window_mac.mm
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-31 19:59:27 -05:00
trop[bot]
dbcd56209a
chore: remove unused KeyWeakMap JS bindings ( #43144 )
...
The last three pieces of code that used it were removed in:
- Oct 2020 (8df4faa8#25711 )
- Jun 2020 (e1e73fa5#24115 )
- Jun 2020 (c0182bca#24116 ).
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-31 18:56:54 -05:00
trop[bot]
ce426cd957
docs: update Node.js stable release policy ( #43134 )
...
* docs: update Node.js stable release policy
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/tutorial/electron-timelines.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-31 10:44:23 -04:00
trop[bot]
1fe01eb0b1
build: fixup ffmpeg release on x64 macOS ( #43121 )
...
chore: fixup arch on x64 macOS ffmpeg
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-30 19:28:48 -05:00
Keeley Hammond
24db198d52
fix: remove InspectableWebContentsViewMac ( #43096 )
...
* fix: remove InspectableWebContentsViewMac (#43033 )
* Revert "refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )"
This reverts commit e67ab9a93dhttps://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fix: contents_web_view_ -> contents_view_
* chore: remove extraneous includes
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: remove custom border radius feat (#42320 )
* fix: fix views::Widget::InitParams params
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-30 14:51:51 -04:00
trop[bot]
b1921b362e
chore: remove unused class electron::ObjectLifeMonitor ( #43109 )
...
chore: remove unused class `electron::ObjectLifeMonitor` (#43089 )
The last users were removed in June 2020 e1e73fa5f#24115 )
and May 2020 9d7ba982#23592 ).
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-30 13:27:12 -05:00
trop[bot]
35b73514b7
fix: showInactive window not showing ( #43102 )
...
fix: showInactive window not showing
Refs https://github.com/electron/electron/pull/42226 and https://github.com/electron/electron/pull/43033
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-30 13:02:03 -05:00
trop[bot]
6322c329bf
fix: always terminate active Node Streams ( #43071 )
...
`.destroy()` is an important method in the lifecycle of a Node.js
Readable stream. It is typically called to reclaim the resources
(e.g., close file descriptor). The only situations where calling
it manually isn't necessary are when the following events are
emitted first:
- `end`: natural end of a stream
- `error`: stream terminated due to a failure
Prior to this commit the ended state was incorrectly tracked together
with a pending internal error. It led to situations where the request
could get aborted during a read and then get marked as ended (having
pending error).
With this change we disentangle pending "error" and "destroyed" cases to
always properly terminate an active Node.js Readable stream.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
2024-07-27 14:47:12 -05:00
trop[bot]
b6e19c5a45
chore: avoid crash while notification removal ( #43061 )
...
* avoid crash of operation on an invalid entry while erase set iterator.
Co-authored-by: bill.shen <shenyb32768@gmail.com>
* fix notification removal crash due to the nullptr presenter
Co-authored-by: bill.shen <shenyb32768@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-07-26 16:32:43 -04:00
trop[bot]
871136bf91
refactor: move safe_storage functions into anonymous namespace ( #43051 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-25 22:32:17 +02:00
trop[bot]
94381733ff
fix: File System API permissions should reset on WebContents destruction ( #43048 )
...
fix: active File System API permissions should reset on WebContents destruction
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-25 16:01:56 -04:00
electron-roller[bot]
ca9027bc38
chore: bump chromium to 126.0.6478.185 (31-x-y) ( #43027 )
...
chore: bump chromium in DEPS to 126.0.6478.185
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-07-25 10:21:03 -04:00
trop[bot]
139abe73a1
fix: desktopCapturer breaks BrowserWindow resizable on macOS ( #43044 )
...
* fix: desktopCapturer breaks BrowserWindow resizable on macOS
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: oops fix showing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-25 15:35:23 +02:00
trop[bot]
097a3e9024
chore: use v8::Local<>, not v8::Handle<> ( #43037 )
...
v8::Handle is an alias for v8::Local that "is kept around for historical
reasons" and is disabled when V8_IMMINENT_DEPRECATION_WARNING is defined
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-25 11:00:05 +02:00
trop[bot]
9e14f8d828
feat: emit an event when accessing restricted path in File System Access API ( #42994 )
...
* fix: show a dialog when accessing restricted path in File System Access API
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: allow overriding initial blocked paths
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: fix doc
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: change block to deny for consistency
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-24 13:23:33 -04:00
trop[bot]
f797f92716
docs: note macOS fullscreen events in fullscreen query ( #43016 )
...
docs: note macOS fullscreen events in fs query
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-23 16:56:58 -04:00
trop[bot]
7f6eab8c25
docs: improve desktop capture example ( #43005 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-23 12:35:00 +02:00
trop[bot]
b288f3ee59
refactor: remove WindowListObserver::OnWindowAdded() ( #42984 )
...
refactor: remove WindowListObserver::OnWindowRemove()
these have never been used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-22 19:12:59 +02:00
trop[bot]
b833c3f02a
chore: remove unused BaseWindow::GetWeakPtr() ( #42988 )
...
last caller removed in 67ba3040#37902 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-22 10:20:27 -05:00
trop[bot]
d53f1d8ff4
chore: remove unused WrappableBase::AfterInit() ( #42986 )
...
last caller removed in 6159066c#22916 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-22 15:52:56 +02:00
trop[bot]
e259dd591f
chore: remove unused typedef CreateDownloadPathCallback ( #42968 )
...
chore: remove unused typedef ElectronDownloadManagerDelegate::CreateDownloadPathCallback
use was removed in e3c580e9
2024-07-19 21:44:54 -05:00
trop[bot]
daf8d22e07
refactor: remove unused web contents preferences methods ( #42969 )
...
* chore: remove unused WebContentsPreferences::ShouldDisableDialogs()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove unused WebContentsPreferences::ShouldUseSafeDialogs()
caller removed in 85bc005c85bc005c
2024-07-19 18:55:07 -05:00
electron-roller[bot]
6249f596f9
chore: bump chromium to 126.0.6478.183 (31-x-y) ( #42942 )
...
* chore: bump chromium in DEPS to 126.0.6478.182
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6478.184
* chore: bump chromium in DEPS to 126.0.6478.183
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-19 16:30:41 -05:00
trop[bot]
6c1409ae57
chore: remove unused field ElectronBrowserClient::browser_main_parts_ ( #42965 )
...
chore: remove unused field ElectronBrowserClient::browser_main_parts_
caller removed in 48d0b09a
2024-07-19 14:37:32 -05:00
trop[bot]
0d9918cd24
fix: dangling raw_ptr NodeBindings::uv_env_ ( #42955 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-19 12:26:37 -05:00
trop[bot]
bb093817ed
fix: dangling raw_ptr<views::View> in api::View ( #42951 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-17 23:31:40 -05:00
trop[bot]
1de0bb30b1
feat: add getPercentComplete / getCurrentBytesPerSecond / getEndTime to DownloadItem ( #42915 )
...
feat: getCurrentSpeed / getPercentComplete / getEndTime on DownloadItem
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Theo Gravity <theo@suteki.nu>
2024-07-17 09:49:05 -07:00
trop[bot]
e429b6f745
fix: crash with creating OffScreenWebContentsView ( #42941 )
...
On the Mac platform, OffScreenWebContentsView uses Automatic Reference
Counting (ARC) to handle the lifecycle of offScreenView_. However, this
private member variable is not initialized and its value is undefined.
In some cases, it is initialized to a garbage value, which may cause ARC
to release the value incorrectly, resulting in a crash.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jinli Wu <wujinli@bytedance.com>
2024-07-17 09:10:00 -05:00
trop[bot]
e3a5895c2b
fix: getUserMedia needs macOS system permissions check ( #42937 )
...
fix: getUserMedia needs macOS system permissions check
Closes https://github.com/electron/electron/issues/42714
Closes https://github.com/electron/electron/issues/29861
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-17 13:08:34 +02:00
Calvin
5951712f2e
build: fix clang format location helper ( #42926 )
...
* build: fix clang format location helper (again)
* use gclient sync in lint workflow for downloading clang-format
2024-07-17 11:30:36 +02:00
trop[bot]
85cb6d9476
fix: BrowserWindow.setBackgroundColor should work with transparency ( #42928 )
...
fix: BrowserWindow.setBackgroundColor should work with transparency
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-17 11:29:22 +02:00
trop[bot]
5029bce65c
fix: iteration issues in hid RevokeEphemeralDevicePermission ( #42901 )
...
fix: iteration issues in hid RevokeEphemeralDevicePermission
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-16 12:32:35 +02:00
trop[bot]
697f468f36
chore: fix npm run lint not working on Windows ( #42906 )
...
* fix: fixed the `npm run lint` not working on Windows.
* chore: more fixes for lint on Windows
* chore: revert change to patch linting
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: reito <cnschwarzer@qq.com>
2024-07-16 12:32:07 +02:00
John Kleinschmidt
9659dab19e
build: remove CircleCI ( #42844 ) ( #42909 )
...
* build: remove CircleCI
* chore: remove remaining CircleCI references
(cherry picked from commit c006e129b3
2024-07-15 16:00:20 -07:00
electron-roller[bot]
398e34967f
chore: bump node to v20.15.1 (31-x-y) ( #42839 )
...
* chore: bump node in DEPS to v20.15.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-15 17:29:57 -04:00
trop[bot]
9833c7f1e6
build: fixup GHA running on fork PRs ( #42904 )
...
* chore: update build-tools for GHA
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: don't rely on environment variables for source cache location
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-15 14:29:41 -04:00
trop[bot]
266b23745b
fix: File System Access API should remember last picked directory ( #42893 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-15 17:22:56 +02:00
trop[bot]
65f431ab78
fix: crash when resolving proxy due to network service restart ( #42897 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-07-15 14:50:41 +02:00
trop[bot]
5c2a8b9047
fix: desktopCapturer and screen display ids should match ( #42890 )
...
* fix: `desktopCapturer` and `screen` display IDs should match
Co-authored-by: clavin <clavin@electronjs.org>
* simplify wide-to-utf8 conversion
Co-authored-by: clavin <clavin@electronjs.org>
* remove unnecessary include
Co-authored-by: clavin <clavin@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
2024-07-14 18:30:34 +02:00
Samuel Attard
05abc2bab2
build: use new arc runner names ( #42886 )
...
build: use new arc runner names (#42881 )
2024-07-13 12:10:40 -07:00
trop[bot]
c916070300
build: update build-tools for GHA ( #42873 )
...
chore: update build-tools for GHA
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-12 11:17:39 +02:00
trop[bot]
f392f558e0
fix: desktopCapturer and screen source ids should match screen ids ( #42861 )
...
* fix: desktopCapturer screen source ids should match screen ids
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: add a regression test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-11 15:47:33 -04:00
trop[bot]
54d920165e
ci: fix Nan test failure on Linux ( #42865 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-11 15:46:42 -04:00
trop[bot]
c3868809df
chore: speed up azcopy on src cache ( #42847 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-11 09:46:23 -04:00
trop[bot]
e768a1f228
fix: dangling raw_ptr<Session> in UserDataLink ( #42852 )
...
* fix: dangling raw_ptr<Session> in UserDataLink
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! fix: dangling raw_ptr<Session> in UserDataLink
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-11 14:53:06 +02:00
trop[bot]
217e740791
fix: High Contrast mode not working on Windows ( #42859 )
...
Closes https://github.com/electron/electron/issues/42609
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5324688
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5368321
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-10 16:48:24 -07:00
trop[bot]
dc065dfa5a
fix: potentially closed webContents in BrowserView ( #42810 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-10 15:33:27 +02:00
Shelley Vohr
6a15e168ce
build: remove all publish & build on macOS ( #42827 )
...
* build: remove all publish & build on macOS
* ci: fix CircleCI config (#42829 )
* ci: fix CircleCI config
* ci: fix syntax error
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-07-10 14:52:30 +02:00
