Commit graph

3957 commits

Author SHA1 Message Date
Cheng Zhao
7994f087fb Merge pull request #6618 from electron/code-range-registration
Only register code range in Windows crash reporter once
2016-07-27 09:52:18 +09:00
Kevin Sawicki
c4e743d207 Add TODO to deprecate boolean param 2016-07-26 14:18:15 -07:00
Kevin Sawicki
8e1de88512 Correct typo in variable name 2016-07-26 14:17:41 -07:00
Kevin Sawicki
b2f9cce297 Add option to always highlight the tray icon 2016-07-26 13:51:43 -07:00
Kevin Sawicki
bde432b64d Add webContents.copyImageAt 2016-07-26 12:06:11 -07:00
Kevin Sawicki
7a1b796dd0 Change registered flag from InitBreakpad 2016-07-26 10:54:30 -07:00
Kevin Sawicki
8956388804 Only register code range once 2016-07-26 10:40:11 -07:00
gellert
8392ece321 updates impl to newer version of chromium 2016-07-26 16:52:43 +02:00
deepak1556
e65bc481a8 browser: initialize pref registry in brightray 2016-07-26 16:34:04 +05:30
Cheng Zhao
d2ce50e3dd c++11 styling 2016-07-26 13:32:17 +09:00
Cheng Zhao
0da1a772be Set page's font settings with system settings 2016-07-26 13:29:27 +09:00
gellert
9d83ce1676 resolves 2016-07-25 21:09:49 +02:00
gellert
8fb7872b84 removes logs and adds webcontentsview init 2016-07-25 19:58:21 +02:00
gellert
0ad0c79202 adds beginframe scheduling 2016-07-25 19:58:14 +02:00
gellert
9e10f211d7 removes commented includes 2016-07-25 19:44:44 +02:00
gellert
8090278708 breaks down osr api to separate files 2016-07-25 19:44:44 +02:00
gellert
14836cef02 using damage_rect 2016-07-25 19:44:44 +02:00
gellert
96e1ba9c14 gpu acclereted osr added 2016-07-25 19:44:44 +02:00
Heilig Benedek
5371921f8a speed(up) bump 2016-07-25 19:44:44 +02:00
Heilig Benedek
4a0f0063a0 speedup base 2016-07-25 19:44:44 +02:00
liusi
8129c27a4a Merge branch 'master' of https://github.com/electron/electron into restore-issue 2016-07-25 22:53:18 +08:00
liusi
2cc01eea30 issue 6574 - Window position doesn't restore correctly 2016-07-25 22:51:27 +08:00
gellert
6eba509d53 removes logs and adds webcontentsview init 2016-07-25 15:55:00 +02:00
Cheng Zhao
fd8cc63ca9 Merge pull request #6558 from deepak1556/session_proxy_patch
session: add proxyBypassRules option to setProxy api
2016-07-25 16:03:50 +09:00
Cheng Zhao
c497765dea Merge pull request #6524 from liusy182/painted-event-6426
add "view-painted" event to WebContent.
2016-07-25 16:02:50 +09:00
Cheng Zhao
c0f81d14e4 Bump v1.3.0 2016-07-25 12:57:10 +09:00
Cheng Zhao
0c1d91a895 display.h needs to be used together with screen.h 2016-07-22 23:37:20 +09:00
gellert
81be0bc123 adds beginframe scheduling 2016-07-22 13:55:58 +02:00
Cheng Zhao
cf6f4708bc Fix building on Windows 2016-07-21 11:20:43 -06:00
Cheng Zhao
6850500a65 Fix building on Linux 2016-07-21 07:09:01 -06:00
Cheng Zhao
d22dc6c7d3 Update to Chrome 52.0.2743.82 2016-07-21 06:07:05 -06:00
Cheng Zhao
f6f7b41f0a Fix compilation error after merge 2016-07-21 06:03:38 -06:00
Cheng Zhao
b57665330c Merge branch 'master' into chrome52 2016-07-21 05:34:36 -06:00
Cheng Zhao
39bd2bee8e Avoid using CHECK in files using node headesr
Node has its own CHECK macro which requires linking with node::Assert.
2016-07-21 16:56:48 +09:00
Cheng Zhao
cef86f5257 Use node::FreeEnvironment 2016-07-21 16:43:21 +09:00
Cheng Zhao
5fc0201ca1 There is no node_extern.h anymore 2016-07-21 16:36:31 +09:00
Cheng Zhao
7d42797c1f Update node headers including 2016-07-21 00:57:34 -06:00
Cheng Zhao
498e9089b3 Bump v1.2.8 2016-07-20 23:57:08 -06:00
deepak1556
aa6d79a3d8 session: add proxyBypassRules option to setProxy api 2016-07-21 10:14:54 +05:30
gellert
504c79cae7 removes commented includes 2016-07-20 11:32:59 +02:00
gellert
84a5c50b62 breaks down osr api to separate files 2016-07-20 11:30:06 +02:00
gellert
7fc9df4f8f using damage_rect 2016-07-19 23:50:49 +02:00
Anthony Tseng
9e6f623a5c Using base::HexEncode() 2016-07-19 11:06:56 +08:00
Anthony Tseng
42eb0c3eae serial number in hex string 2016-07-18 23:42:42 +08:00
Cheng Zhao
2ed733fedc Redirect relaunch process's stdout to /dev/null 2016-07-18 08:46:01 -06:00
gellert
50dc71d1c2 gpu acclereted osr added 2016-07-18 16:16:23 +02:00
liusi
d335d7d706 add "view-painted" event to WebContent. 2016-07-18 14:54:52 +08:00
Cheng Zhao
4d46189928 Fix cpplint warnings 2016-07-15 22:47:40 +09:00
liusi
154daa8d6a make Session::ClearStorageData's callback optional 2016-07-15 14:13:56 +08:00
Cheng Zhao
d186a01815 Merge pull request #6497 from electron/windows-thumbnail
Add setThumbnailClip API on Windows
2016-07-15 10:18:39 +09:00
Cheng Zhao
5db758297f Merge pull request #6486 from MarshallOfSound/master
Add a getFeedURL API for the autoUpdater
2016-07-15 10:02:05 +09:00
Cheng Zhao
16e43a7f15 Merge pull request #6490 from wilsonpage/add-drop-text-support
Add support for dropped text in osx
2016-07-15 09:12:35 +09:00
Cheng Zhao
3ace677b41 Merge pull request #6474 from darkdh/cert_detail
Add more detail attributes for certificate-error
2016-07-15 08:45:36 +09:00
Kevin Sawicki
ccee3e1fc2 Document setThumbnailClip 2016-07-14 15:54:57 -07:00
Kevin Sawicki
86218fe773 win: Add setThumbnailClip window API 2016-07-14 15:50:31 -07:00
Wilson Page
90f8a7e828 Add support for dropped text in osx 2016-07-14 18:25:58 +01:00
Samuel Attard
fa7526202b Remove unnecessary method 2016-07-15 00:13:04 +12:00
Samuel Attard
51687e1bc9 Add the getFeedURL API for macOS and Windows 2016-07-15 00:04:48 +12:00
Anthony Tseng
02e89d60f1 Use CalculateFingerprint256() 2016-07-14 19:09:11 +08:00
Cheng Zhao
ba887dbde7 Merge pull request #6482 from deepak1556/webcontents_navigation_obs_patch
webcontents: replace deprecated navigation observers
2016-07-14 12:57:26 +09:00
Cheng Zhao
21a2feaf23 Merge pull request #6480 from electron/webcontents-focus
Execute role-based menu items on focused web contents
2016-07-14 12:47:07 +09:00
deepak1556
c8bf6edcc6 webcontents: replace deprecated navigation observers 2016-07-14 06:47:38 +05:30
Kevin Sawicki
7877fa7c0a Add webContents.isFocused() 2016-07-13 14:16:56 -07:00
Heilig Benedek
6e25aea49f speed(up) bump 2016-07-13 17:43:00 +02:00
Anthony Tseng
db39867ad9 Add more detail attributes for certificate-error 2016-07-13 22:14:47 +08:00
Cheng Zhao
6db75a3458 Fix building on Linux 2016-07-13 12:23:14 +09:00
Cheng Zhao
753e92c845 Add cache option for session 2016-07-13 12:23:14 +09:00
Cheng Zhao
e213e09c3e Add options to session.fromPartition 2016-07-13 12:23:14 +09:00
Cheng Zhao
00804e5f98 Move the ability to create BrowserContext to embedder 2016-07-13 12:23:14 +09:00
Cheng Zhao
400bb8d0f3 Hide in_memory parameter in native interface 2016-07-13 12:23:14 +09:00
Cheng Zhao
06a41cedab Move check of isReady to native code 2016-07-13 12:23:14 +09:00
Cheng Zhao
4ebb83e999 Move the warning of registerStandardSchemes to native code 2016-07-13 12:23:14 +09:00
Cheng Zhao
13e1818bf7 Bump v1.2.7 2016-07-13 12:22:42 +09:00
Cheng Zhao
e5ccb3fd5d Remove lock in AtomCertVerifier 2016-07-13 12:07:57 +09:00
Cheng Zhao
24c60019b7 Create AtomCertVerifier on IO thread 2016-07-13 12:05:57 +09:00
Kevin Sawicki
15f7dc6609 Initialize to constraints to current constraints 2016-07-12 16:36:25 -07:00
Kevin Sawicki
afd5e51d6a Add Browser namespace 2016-07-12 09:10:48 -07:00
Kevin Sawicki
3d358ee7ea Fix Windows compilation issues 2016-07-12 09:10:47 -07:00
Kevin Sawicki
af907163a2 Enable LoginItemSettings converter on all platforms 2016-07-12 09:10:47 -07:00
Kevin Sawicki
5a36c5596c Add initial windows login item implementation 2016-07-12 09:10:47 -07:00
Kevin Sawicki
64f9c6a1d7 Add get/setLoginItemSettings on all platforms 2016-07-12 09:10:47 -07:00
Cheng Zhao
3335792200 Remove some unneeded hacks for old OS X versions 2016-07-12 15:15:47 +09:00
Cheng Zhao
2ee8142136 Fix transparent window having border on OS X 10.9 2016-07-12 15:01:37 +09:00
Cheng Zhao
5a604f8e79 Destroy the native tray in next tick 2016-07-12 14:23:38 +09:00
Cheng Zhao
df0d2b89cd Merge pull request #6446 from electron/accessibility-api
Add API for Chrome's accessibility support state
2016-07-12 10:59:12 +09:00
Kevin Sawicki
f5d371e180 Remove linter warnings 2016-07-11 14:46:28 -07:00
Kevin Sawicki
131bff48ea IsAccessibilitySupportEnabled -> isAccessibilitySupportEnabled 2016-07-11 14:44:32 -07:00
Kevin Sawicki
34f7ddec9f Update API to isAccessibilitySupportEnabled 2016-07-11 14:32:14 -07:00
Kevin Sawicki
3fcbac78ac Implement accessiblity change events on Windows 2016-07-11 14:23:25 -07:00
Kevin Sawicki
68d7ae75b0 Implement accessiblity change events on mac 2016-07-11 14:09:01 -07:00
Kevin Sawicki
fc36ac8c1b Add API for accessibility state and changes 2016-07-11 14:04:56 -07:00
Milan Burda
38016b8144 Remove unnecessary >= Windows Vista check 2016-07-11 18:23:33 +02:00
Cheng Zhao
5208bbd2e8 Remove unneeded include 2016-07-11 17:13:21 +09:00
Cheng Zhao
86338290fb win: Fix openExternal not working with non-ASCII characters 2016-07-11 17:12:11 +09:00
Cheng Zhao
31e67788a2 mac: Do not change window size when in fullscreen 2016-07-11 16:44:42 +09:00
Cheng Zhao
381366daf1 Fix indention 2016-07-11 16:43:01 +09:00
Cheng Zhao
db8787fce1 The fullscreen button should always be hidden for frameless window 2016-07-11 16:00:29 +09:00
Cheng Zhao
8269e7b1ef Suppress unresponsive event when showing menu 2016-07-11 15:31:24 +09:00
Cheng Zhao
7848608198 Replace DialogScope with UnresponsiveSuppressor
The latter is global-wide.
2016-07-11 15:29:03 +09:00
Cheng Zhao
fc72df3ba1 win: Use FOS_FORCESHOWHIDDEN for showHiddenFiles 2016-07-11 13:49:51 +09:00
Cheng Zhao
6e0fadbe26 gtk: Set show-hidden property for showHiddenFiles 2016-07-11 13:47:24 +09:00
Cheng Zhao
f08ac07737 mac: Add showHiddenFiles property for showOpenDialog 2016-07-11 13:30:18 +09:00
Cheng Zhao
a1a870fe43 Auto-hide menubar when in fullscreen 2016-07-11 13:10:19 +09:00
Cheng Zhao
e8e2763131 win: Add toolbar type for BrowserWindow 2016-07-11 12:46:50 +09:00
Haojian Wu
4ac4dacffe Some manual change to for-ranged loop.
Use "const auto&" where possible.
2016-07-10 15:57:51 +02:00
Haojian Wu
55b3f1936f Modernize to C++11: Use for-range loop. 2016-07-10 13:33:15 +02:00
Haojian Wu
3bdeac98bf Modernize to C++11: use override. 2016-07-10 13:21:42 +02:00
Haojian Wu
04f9d35312 Modernize to C++11: Use auto key to improve code readability and maintainability. 2016-07-10 13:11:47 +02:00
Haojian Wu
fab02809c6 Modernize to C++11: NULL => nullptr.
No functional change.
2016-07-10 11:57:04 +02:00
Cheng Zhao
f77b9db069 Fix unmaximize() not working 2016-07-09 23:16:57 +09:00
Cheng Zhao
5979c1464f Remember bounds instead of size 2016-07-09 23:10:36 +09:00
Cheng Zhao
c4de246bfb Correctly handle unmaximize 2016-07-09 23:04:42 +09:00
Cheng Zhao
baff744601 Use setBounds to implement maximize for window without thickFrame 2016-07-09 22:49:55 +09:00
Cheng Zhao
2ece9e2885 Add thickFrame option 2016-07-09 21:49:15 +09:00
Cheng Zhao
54f74e8160 Redirect relaunch process's stdout to /dev/null 2016-07-09 17:59:40 +09:00
Cheng Zhao
627028e3a0 Clear protocol handlers on exit 2016-07-09 17:02:55 +09:00
Cheng Zhao
6e81c55880 Merge pull request #6385 from electron/only-use-role-accelerator-in-app-menu
Only use default role accelerator in app menu
2016-07-08 11:22:21 +09:00
Cheng Zhao
5713e0599b Merge pull request #6375 from electron/login-item
Add login item API
2016-07-08 10:39:20 +09:00
Kevin Sawicki
7326d3d3d5 🎨 2016-07-07 16:38:12 -07:00
Kevin Sawicki
2633c2f735 Add was prefix to current launch settings 2016-07-07 16:29:58 -07:00
Kevin Sawicki
c100300764 Update API to get/setLoginItemSettings 2016-07-07 16:29:09 -07:00
Kevin Sawicki
e4906f2d87 Add back getCurrentActivityType 2016-07-07 14:29:43 -07:00
Kevin Sawicki
cb943cec77 🎨 2016-07-07 14:28:01 -07:00
Kevin Sawicki
10a2454921 Remove unneeded atom:: prefix 2016-07-07 14:25:09 -07:00
Kevin Sawicki
2faf00dc19 Only use default accelerator in Windows/Linux app menu 2016-07-07 11:50:19 -07:00
Cheng Zhao
6381f44f26 mac: Pass useDefaultAccelerator to getAcceleratorForCommandId 2016-07-07 11:50:19 -07:00
Cheng Zhao
d23c1bf917 Cleanup the code of SetBounds 2016-07-07 20:02:18 +09:00
Cheng Zhao
43e9f30b21 Merge pull request #6363 from MarshallOfSound/master
Bound the target width and height of window when calling SetSize
2016-07-07 19:52:47 +09:00
Samuel Attard
ceb2864881 Move size bounding logic to SetBounds 2016-07-07 20:55:10 +12:00
Cheng Zhao
c7e0df09bc Merge pull request #6370 from electron/send-key-event-to-main-menu
Give menu a chance to handle keydown event before window
2016-07-07 10:11:12 +09:00
Kevin Sawicki
60ab71a706 Combine launch and current status login item APIs 2016-07-06 13:57:46 -07:00
Kevin Sawicki
c5610b2186 Add API to add/remove app as login item 2016-07-06 13:26:16 -07:00
Kevin Sawicki
b55f55cfc4 Add app.getLoginItemStatus API 2016-07-06 13:17:39 -07:00
Kevin Sawicki
98a97a52ea Add getLoginItemLaunchStatus API 2016-07-06 12:49:08 -07:00
Kevin Sawicki
bd33961964 Give menu a chance to handle key event before window 2016-07-06 10:12:40 -07:00
Kevin Sawicki
07ccb6af2b 🎨 2016-07-06 09:42:43 -07:00
Kevin Sawicki
b900ff93e4 Make OnCapturePageDone static 2016-07-06 09:32:58 -07:00
Kevin Sawicki
4a4a8528ea Fix linter warnings 2016-07-06 09:21:29 -07:00
Kevin Sawicki
12dddae2ca Remove unused callback 2016-07-06 09:21:28 -07:00
Kevin Sawicki
f7b72f0948 Move capturePage to WebContents 2016-07-06 09:21:28 -07:00
Samuel Attard
6bd343b112 Bound the target width and height of window when calling SetSize 2016-07-07 00:49:35 +12:00
Heilig Benedek
74120493fd Merge pull request #12 from electron/master
update as upstream
2016-07-06 14:12:24 +02:00
Cheng Zhao
92b97d3576 Bump v1.2.6 2016-07-06 13:20:36 +09:00
Heilig Benedek
6fb6b93003 speedup base 2016-07-05 21:33:22 +02:00
Cheng Zhao
41b8dda071 For hidden window focus() should do nothing 2016-07-05 10:34:52 +09:00
Cheng Zhao
381689d3ed Fix building on Windows 2016-07-05 09:31:29 +09:00
Cheng Zhao
8d3e09747a directWrite option is removed 2016-07-05 09:20:57 +09:00
Cheng Zhao
d0719e9b4b Fix cpplint warnings 2016-07-04 19:19:20 +09:00
Cheng Zhao
0a6bb9c36a Fix crash when creating protocol module 2016-07-04 15:32:43 +09:00
Cheng Zhao
1ba3907038 Update to API changes of Chrome 52 2016-07-04 15:32:43 +09:00
Cheng Zhao
eb378bef3a Upgrade to Chrome 52 2016-07-04 15:32:43 +09:00
Cheng Zhao
23582cc9d3 Reduce the scope of ScopedNestableTaskAllower 2016-07-03 15:30:27 +09:00
Cheng Zhao
7916f0ea18 win: Use drag_utils::CreateDragImageForFile 2016-07-03 14:44:47 +09:00
Cheng Zhao
63a8961ed1 views: Implement webContents.startDrag 2016-07-03 14:34:35 +09:00
Cheng Zhao
fa468a529b Support dragging multiple files 2016-07-03 13:58:31 +09:00
Cheng Zhao
13c668f22b mac: Implement webContents.startDrag 2016-07-03 12:26:43 +09:00
Cheng Zhao
14c4be50c1 Avoid calling GetWebContentsFromProcessID for twice 2016-07-02 16:54:12 +09:00
Cheng Zhao
b0faa62f76 Merge pull request #6313 from MarshallOfSound/silent-notification-when-muted
Override the Notification API constructor to create silent notificatons when the webContents is muted
2016-07-02 07:44:33 +00:00
Cheng Zhao
e76ec92812 Set window icon before showing window 2016-07-02 16:16:47 +09:00
Cheng Zhao
cd38e5c85e Update to Chrome 51.0.2704.106 2016-07-02 13:54:34 +09:00
Cheng Zhao
ee0eb9ae08 Merge pull request #6309 from electron/app-launcher-rename
Implement app.setBadgeCount on Mac
2016-07-02 01:51:47 +00:00
Cheng Zhao
767124c45c Update for reviews 2016-07-02 10:36:46 +09:00
Samuel Attard
4f660f3e6f Implement WebContenstAudioMuted in AtomBrowserClient 2016-07-02 13:28:28 +12:00
Cheng Zhao
431ea61ff8 Don't use MatchesExtension for matching filters
MatchesExtension compares double extensions like .tar.gz, which does not
match the filters.
2016-07-01 22:55:15 +09:00
Cheng Zhao
1da2a1c2ae app.setBadgeCount should return boolean 2016-07-01 22:20:05 +09:00
Cheng Zhao
cb00d3cfb3 mac: Implement app.setBadgeCount 2016-07-01 17:39:26 +09:00
Kevin Sawicki
45dbbfdfe9 Use nullptr comparisons 2016-06-29 11:52:58 -07:00
Kevin Sawicki
e797eb5ca3 Use set context menu when param is not specified 2016-06-29 11:52:58 -07:00
Jonas Schwabe
8ac205685d Add ifdef for property, which should only be availabe on Linux 2016-06-29 20:22:17 +02:00
Jonas Schwabe
e2d389fbd4 Rename the unityLauncher api to launcher and make it available on linux in general. + Document it only works on ubuntu 2016-06-29 20:22:17 +02:00
Jonas Schwabe
e3ba6818af Fix linter errors 2016-06-29 20:22:17 +02:00
Jonas Schwabe
b22ce93477 Implement libunity launcher badge counter to be set via electron, fixes #4193 2016-06-29 20:22:17 +02:00
Kevin Sawicki
8c52279531 Tweak cookie set failure message and add spec 2016-06-29 08:53:52 -07:00
Milan Burda
a886261518 Fix crash in ReadImageSkiaFromICO when CreateSkBitmapFromHICON fails 2016-06-28 12:17:05 -07:00
Cheng Zhao
e1ad64013e Cleanup code of beginFrameSubscription 2016-06-26 11:46:40 +09:00
Cheng Zhao
3d2ad0080d Merge pull request #6164 from MaxWhere/master
beginFrameSubscription bugfix and improvement
2016-06-26 02:39:59 +00:00
Heilig Benedek
5118def724 damaged -> dirty rename, fixed misc issues, changed signature, updated docs and added tests 2016-06-25 18:23:40 +02:00
Florent Delayen
4d55175649 Execute click handlers for top level menu items 2016-06-25 16:51:43 +02:00
Cheng Zhao
04b30afbed Merge pull request #6233 from electron/clipboard-bookmark-support
Add support for reading/writing bookmarks from the clipboard
2016-06-25 05:23:32 +00:00
Kevin Sawicki
e802d0e4a0 Add bookmark key to clipboard.write 2016-06-24 15:14:28 -07:00
Kevin Sawicki
271808b278 Support reading/writing bookmarks to clipboard 2016-06-24 15:08:12 -07:00
Milan Burda
dfc2f3f0c6 Fix uninitialized member variable in CrashReporterWin 2016-06-24 18:30:38 +02:00
Cheng Zhao
ee28f4fc32 Handle v8::MicrotasksScope in the main process 2016-06-24 14:45:31 +09:00
Cheng Zhao
ed6213e951 Do not emit did-fail-load for canceled requests 2016-06-23 20:32:19 +09:00
Cheng Zhao
a00c5e3363 Bump v1.2.5 2016-06-23 14:37:58 +09:00
Cheng Zhao
7f3a296050 mac: Avoid calling setTitleVisibility for OS X 10.9 2016-06-23 13:00:14 +09:00
Kevin Sawicki
e9222583cb toPng/toJpeg -> toPNG/toJPEG 2016-06-22 15:47:42 -07:00
Milan Burda
c243cf0c0f Add BrowserWindow.prototype.setContentProtection(enable) 2016-06-22 10:40:33 +02:00
Cheng Zhao
6f9c4766fc Fix usages of global BrowserContext in App::ImportCertificate 2016-06-22 16:10:36 +09:00
Cheng Zhao
01bc8305f8 Add ses.getUserAgent()/setUserAgent(...) APIs 2016-06-22 15:57:51 +09:00
Cheng Zhao
9c8e64f268 Cache the BrowserContext::GetUserAgent 2016-06-22 15:46:46 +09:00
Cheng Zhao
b0f04de50c Do not force creating default session in C++ 2016-06-22 15:41:56 +09:00
Cheng Zhao
8ffd069689 mac: Fix maximize/unmaximize event emitted before window is maximized 2016-06-22 14:06:54 +09:00
Cheng Zhao
8d08e215b2 Add "event" parameter for "click" handler of MenuItem 2016-06-22 11:22:14 +09:00
Cheng Zhao
e6327fb015 Add EventEmitter::CreateEventFromFlags 2016-06-22 11:00:45 +09:00
Cheng Zhao
08a1e92650 Bump v1.2.4 2016-06-22 10:26:54 +09:00
Cheng Zhao
4e811fc377 Merge pull request #6169 from electron/map-roles-by-command-id
Map roles by command id instead of index
2016-06-22 01:24:20 +00:00
Cheng Zhao
c0aebc9d4f Merge pull request #6168 from electron/forward-delete
Support forward delete menu item accelerator
2016-06-22 01:12:10 +00:00
Kevin Sawicki
812dea9a8b Add comment about map key/values 2016-06-21 15:28:02 -07:00
Kevin Sawicki
583cc925ac Map roles by command id 2016-06-21 15:25:14 -07:00