Felix Rieseberg
61ec8df418
🔧 More detailed macOS notification logging
2017-12-13 10:31:59 -08:00
Felix Rieseberg
ffd85bfaac
🔧 Allow notifications debugging (macOS)
2017-12-12 16:09:34 -08:00
deepak1556
16d96a6ef2
Force MediaCaptureDevicesDispatcher to be created on UI thread
2017-12-07 09:47:32 +05:30
Cheng Zhao
d598aa1a67
Merge pull request #11300 from electron/external-devtools
...
Add API to set arbitrary WebContents as devtools
2017-12-05 10:35:49 +09:00
Ales Pergl
7613afe6d7
Disabled DCHECKs that fail when running tests
2017-12-01 17:55:22 +01:00
Cheng Zhao
5e4914700e
Enable using external WebContents as devtools
2017-12-01 10:35:23 +09:00
Ales Pergl
f8b683ca3d
Don't access unique pointer after it was moved from
2017-11-27 17:55:21 +01:00
Ales Pergl
9ca658238b
Made NotificationDelegateImpl
final
...
The class is designed to call `delete` on itself and because it doesn't have
a virtual destructor, it shouldn't be derived from.
2017-11-24 10:58:53 +09:00
deepak1556
505f2ab9e7
Fix crash when destroying NetLog
2017-11-24 10:58:53 +09:00
deepak1556
214cbf357a
Fix cpp lint errors
2017-11-24 10:58:53 +09:00
deepak1556
e60557e2e6
simplify URLRequestContextGetter for HttpNetworkSession::Context
2017-11-24 10:58:53 +09:00
deepak1556
e0860ea7a0
Stop file observer of NetLog to finish writing to disk
2017-11-24 10:58:53 +09:00
Ales Pergl
f3c32647af
Sanitized notification delegate implementation
...
I made `brightray::NotificationDelegate` back into just an interface and
extracted the implementation used by `PlatformNotificationService`, so that
the main process notification implementation can inherit only the interface.
2017-11-24 10:58:53 +09:00
deepak1556
7a9892f151
REVIEW: Inject devtools extensions API via browser
...
Behavior was changed in https://crbug.com/706169
2017-11-24 10:58:53 +09:00
Tomas Rycl
c9b7fc2922
It fixes crash in tests on Windows
...
Notification delegate copies the notification ID string
instead of storing reference.
2017-11-24 10:58:53 +09:00
Samuel Attard
ef40bd4786
Remove dead header file for notification delegate
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
c6333728d9
Fix brightray::URLRequestContextGetter::GetURLRequestContext()
...
Split HttpNetworkSession::Params into two structs.
https://codereview.chromium.org/2907463002
Make HttpNetworkSession::host_mapping_rules no longer a pointer.
https://codereview.chromium.org/2906463002
2017-11-24 10:58:17 +09:00
Tony Ganch
0ad967c9a5
Don't specify URLRequestContext when starting logging
...
Related CL: https://codereview.chromium.org/2698143004
2017-11-24 10:58:17 +09:00
Tony Ganch
4412836e77
Include header for net::URLRequestContext
2017-11-24 10:58:17 +09:00
deepak1556
12a4321e2b
Reporting: Wire ReportingDelegate into ChromeNetworkDelegate
...
https://codereview.chromium.org/2891133003
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
7d1c1700f8
Implement GetBrowsingDataRemoverDelegate() for BrowserContext subclasses
...
https://codereview.chromium.org/2898443002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
6ba372f9f2
Move some of IOThread's command line logic to network_session_configurator.
...
https://codereview.chromium.org/2914893002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
6c7ad3ac58
Remove the dependence on BrowserThread::FILE for
...
https://codereview.chromium.org/2944313003
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
5831a5ffa1
Refactor client cert private key handling.
...
https://codereview.chromium.org/2898573002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
b69913975b
chromeos: Check both original and absolute paths for file: scheme
...
https://codereview.chromium.org/2786583002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
14c61a96af
VR: Check focus state browser-side before sending input to renderer.
...
https://chromium-review.googlesource.com/c/565760
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
fe48a92422
Propagate opener to BackgroundsContents.
...
https://codereview.chromium.org/2882513005
2017-11-24 10:58:16 +09:00
Tony Ganch
f694b64d71
FIXME: DesktopNotificationDelegate has been removed
...
Related CL: https://codereview.chromium.org/2906883003
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
2c063f93ff
Remove raw base::DictionaryValue::Set
...
https://codereview.chromium.org/2911033002
2017-11-24 10:58:16 +09:00
Tony Ganch
cf00fc0661
Rename WriteToFileNetLogObserver to FileNetLogObserver
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ea8e113b19
SkBitmap and SkPixelRef no longer need lock/unlock
...
https://codereview.chromium.org/2823003002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
90b0984a14
Add missing IWYU message_loop.h includes.
...
https://codereview.chromium.org/2876013002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
b81ae1c36f
REVIEW: Move MediaDeviceIDSalt from ProfileIOData to ProfileImpl.
...
https://codereview.chromium.org/2820163002
2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
364c330887
Replace uses of hash_map in //base
...
https://codereview.chromium.org/2830093003
2017-11-24 10:58:15 +09:00
Thiago de Arruda
a9a9e58b68
Fix random crash on app quit.
...
Move AtomCTDelegate to brightray as RequireCTDelegate and transfer ownership to
brightray::URLRequestContextGetter. This fixes the wrong lifetime assumptions
that result in AtomCTDelegate being used after free in some scenarios.
Close #10051
2017-11-17 12:03:23 -03:00
Heilig Benedek
573f664899
fix devtools again
2017-11-13 15:50:49 +09:00
Heilig Benedek
5373afa472
set devtools window to visible to avoid a visual glitch on mac with osr window's devtools
2017-11-13 15:46:46 +09:00
Heilig Benedek
45d16d5add
don't automatically show window when devtools is opened on mac
2017-11-13 15:46:46 +09:00
Samuel Attard
85ef4c6d91
Ensure the click event is only dispatched on ContentsClicked activation type
2017-10-27 16:08:15 +13:00
Shelley Vohr
fc920ffd06
base::UTF8ToWide --> base::FromUTF8Unsafe
2017-10-26 00:27:27 -04:00
Shelley Vohr
c9dca6b8ad
remove unnecessary boolean
2017-10-26 00:21:52 -04:00
Shelley Vohr
246c808222
move away from wstring
2017-10-26 00:18:55 -04:00
Shelley Vohr
06811cc557
appropriately cast pointers to strings
2017-10-25 12:02:50 -04:00
Shelley Vohr
3c1c5a4099
combine homepath and homedrive into single line
2017-10-25 11:46:51 -04:00
Shelley Vohr
1e8bdc15e2
use _wgetenv to get windows env variables
2017-10-25 10:40:38 -04:00
Cheng Zhao
4dc74776c1
Merge pull request #10709 from electron/fix-notification-actions-hs
...
Fix notification actions not working on High Sierra
2017-10-17 15:18:53 +08:00
Ales Pergl
1d25d58c26
Fixed font DPI scaling
2017-10-09 10:17:00 +02:00
Samuel Attard
e5d4574d3a
Use NSUserNotification identifiers to uniquely find the correct notification from CocoaNotification
2017-10-07 14:51:28 +11:00
Shelley Vohr
96f1a25bbd
convert to wstring for windows
2017-09-29 10:29:45 -04:00
Shelley Vohr
e7bb553d3b
consolidate code and rename for clarity
2017-09-29 09:32:30 -04:00
Shelley Vohr
c620d0de05
move overrides into the appropriate namespace
2017-09-28 23:03:01 -04:00
Shelley Vohr
0dfadf7c09
remove unresolved external symbol
2017-09-28 13:35:24 -04:00
Shelley Vohr
911e266e9a
add function signature declaration
2017-09-28 13:35:24 -04:00
Shelley Vohr
223942bf99
fix incorrect std namespacing
2017-09-28 13:35:24 -04:00
Zeke Sikelianos
94f46c9059
fix typo in comment
2017-09-28 13:35:24 -04:00
Shelley Vohr
fc443a8c2c
fix header and line length lint errors
2017-09-28 13:35:24 -04:00
Shelley Vohr
d2d4b4cc23
fix escape backslashes
2017-09-28 13:35:24 -04:00
Shelley Vohr
c1c8f7b0f1
fix string concat errors
2017-09-28 13:35:23 -04:00
Shelley Vohr
2353fdb400
add dir creation if none exists
2017-09-28 13:35:23 -04:00
Shelley Vohr
e81cf74b39
add windows override path and cleanup linux
2017-09-28 13:35:23 -04:00
Shelley Vohr
e096b5ce83
fix override path
2017-09-28 13:35:23 -04:00
Shelley Vohr
3de008035a
appeasing the linter
2017-09-28 13:35:23 -04:00
Shelley Vohr
f026bbb454
add first go at linux log path override
2017-09-28 13:35:23 -04:00
Shelley Vohr
5ef4caf8ab
add ability to access logs in getPath()
2017-09-28 13:35:22 -04:00
Cheng Zhao
91e11f8e6f
Merge pull request #10609 from electron/win32_toast_update
...
Fix for narrowing conversion warnings, minor style change
2017-09-26 10:50:45 +09:00
Felix Rieseberg
741dc1eb0b
🔧 Ensure correct path
2017-09-25 13:51:16 -07:00
Ales Pergl
75feb495ad
Fix for narrowing conversion warnings, minor style change
2017-09-25 18:08:54 +02:00
Yuya Ochiai
d621471eb2
🏁 Set duration for Windows 7 notifications based on Control Panel
2017-09-22 21:28:29 +09:00
Ales Pergl
af92a639be
Fixed potential crash in Win32 notifications.
2017-09-14 11:52:53 +02:00
Charlie Hess
2b9b186fd1
Rename soundName → sound.
2017-08-17 17:28:14 -07:00
Charlie Hess
0cfae1cc2b
Plumb in the macOS soundName property for notifications.
2017-08-17 13:31:20 -07:00
Kevin Sawicki
ad33e569d6
Register default layout provider
2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
48821a6d2a
Fix compilation
2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
adddff3ee2
Move PrefRegistrySimple to use unique_ptr<Value>
...
https://codereview.chromium.org/2784513002
2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
99e57f9072
Add display::GetDisplayNearestView
...
https://codereview.chromium.org/2751833004
2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
7c7300ff82
Make GetDisplayedNotifications asynchronous.
...
https://codereview.chromium.org/2749453002
2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
a20f633272
Remove base::StringValue
...
https://codereview.chromium.org/2664753002
2017-08-15 16:19:20 +03:00
Milan Burda
a196bf97bc
🍎 Add subtitle to Notification properties
2017-06-30 16:54:28 +02:00
Samuel Attard
3774482859
Update notification PR as per feedback
2017-06-28 17:00:19 +10:00
Samuel Attard
7eb14243eb
Refactor notification options
2017-06-24 21:39:06 +10:00
Samuel Attard
17e737eba2
s/label/text
2017-06-23 21:04:39 +10:00
Samuel Attard
4f0d48f164
Add support for notification actions on macOS
2017-06-23 20:50:20 +10:00
Cheng Zhao
e82af41591
Merge pull request #9269 from electron/main-notifications
...
Notifications from the main process
2017-05-31 17:21:05 +09:00
Cheng Zhao
5fa2831756
Coding style fixes
2017-05-31 16:17:29 +09:00
Samuel Attard
227a2bd5dc
Fix reference typed reply placeholder
2017-05-30 20:29:27 +10:00
Samuel Attard
3938373ecb
Fix linting errors and add isSupported
2017-05-30 20:27:24 +10:00
Samuel Attard
686b1388b1
Fix linting issues
2017-05-30 19:12:36 +10:00
Samuel Attard
5048425e6e
Update implementation as per feedback
2017-05-30 19:06:51 +10:00
Samuel Attard
9aa6b83f86
Fix compilation and click events on macOS
2017-05-29 21:22:44 +10:00
Samuel Attard
058bdfbced
Use NotificationPresenter - macOS
2017-05-29 20:02:33 +10:00
Kevin Sawicki
c43c3b3d80
Revert "protocol: use streaming interface between fetcher and requestjob"
...
This reverts commit 71b5d946e0
.
2017-05-26 09:47:22 -07:00
Kevin Sawicki
7e185ef1a3
Remove extra newlines
2017-05-19 08:46:15 -07:00
Kevin Sawicki
e19eef025d
Remove lint from inspectable_web_contents_view_views.h/cc
2017-05-19 08:46:15 -07:00
Kevin Sawicki
4625159310
Add memory include for std::unique_ptr
2017-05-19 08:46:15 -07:00
Kevin Sawicki
278a283801
🎨 Group includes
2017-05-19 08:46:15 -07:00
Kevin Sawicki
d7321ed980
Add brightray prefix to include paths from within brightray
2017-05-19 08:46:15 -07:00
Kevin Sawicki
c4608c0f37
Fix build/include_alpha linter violations in brightray
2017-05-19 08:46:15 -07:00
Kevin Sawicki
f193b2b2a6
Fix build/include_what_you_use linter violations in brightray
2017-05-19 08:46:15 -07:00
Kevin Sawicki
cfb5b6ac89
Fix build/header_guard linter violations in brightray
2017-05-19 08:46:15 -07:00
Kevin Sawicki
bb4a61c7ff
Remove unused includes
2017-05-19 08:46:15 -07:00