Biru Mohanathas
7f1e3ca3de
fix: shutdown crash in DownloadItem callback ( #27342 )
...
The call stack for one of our top crashes looks like this:
```
node::Abort (node_errors.cc:241)
node::Assert (node_errors.cc:256)
node::MakeCallback (callback.cc:226)
gin_helper::internal::CallMethodWithArgs (event_emitter_caller.cc:23)
gin_helper::EmitEvent<T> (event_emitter_caller.h:51)
gin_helper::EventEmitterMixin<T>::Emit<T> (event_emitter_mixin.h:81)
electron::api::DownloadItem::OnDownloadUpdated (electron_api_download_item.cc:115)
download::DownloadItemImpl::UpdateObservers (download_item_impl.cc:482)
content::DownloadManagerImpl::Shutdown (download_manager_impl.cc:508)
content::BrowserContext::~BrowserContext (browser_context.cc:476)
```
Full stack here: https://sentry.io/share/issue/9b030a0601b547188181b543c16ecda2/
During browser shutdown, the `DownloadManager` was being cleaned up
*after* the Node environment had already been destroyed. This caused the
`DownloadItem::OnDownloadUpdated` callback to crash when trying to emit
the JS `done` event.
To prevent this, we now manually shut down the `DownloadManager`
earlier. This is also mentioned in the comment on
`DownloadManager::Shutdown`:
```
// Shutdown the download manager. Content calls this when BrowserContext is
// being destructed. If the embedder needs this to be called earlier, it can
// call it. In that case, the delegate's Shutdown() method will only be called
// once.
```
2021-01-20 11:30:08 -08:00
Electron Bot
b6a0fcd51d
Bump v13.0.0-nightly.20210120
2021-01-20 06:33:03 -08:00
Electron Bot
5fb1095806
Bump v13.0.0-nightly.20210119
2021-01-19 07:51:27 -08:00
Electron Bot
b0c1a2ae25
Revert "Bump v13.0.0-nightly.20210119"
...
This reverts commit 9a336a6a3b
2021-01-19 07:48:40 -08:00
Electron Bot
9a336a6a3b
Bump v13.0.0-nightly.20210119
2021-01-19 06:32:53 -08:00
Cheng Zhao
c3091c3a70
fix: make SetWindowButtonVisibility work for customButtonsOnHover ( #27073 )
2021-01-19 19:12:09 +09:00
David Sanders
5e7e0a4c7e
fix: improve redirect behavior in protocol module ( #26297 )
...
* fix: improve redirect behavior in protocol module
* Add test for redirection
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2021-01-19 19:06:14 +09:00
Samuel Maddock
4334110339
fix: prevent crash when keyboard event immediately precedes calling BrowserWindow.close() ( #27315 )
...
* fix: prevent crash when destroyed widget receives keyboard event
Activating a key to close a window will cause a silent crash. Handling the keyboard
event will lead to a nullptr dereferenced in Chromium code if the window widget has
already been destroyed.
* test: ensure BrowserWindow doesn't crash from keyboard events during close
2021-01-19 11:37:21 +09:00
riccardopiola
d7b02e123a
chore: duplicate symbols for mojom interfaces in component build ( #27186 )
...
* fix duplicate symbols in component build
* fix: duplicate symbols for mojom interfaces in component build
2021-01-19 11:31:44 +09:00
Electron Bot
b27fa567bc
Bump v13.0.0-nightly.20210118
2021-01-18 06:31:32 -08:00
Electron Bot
3b38ba2ed8
Bump v13.0.0-nightly.20210115
2021-01-15 06:33:34 -08:00
Milan Burda
2be3d03630
feat: add webFrameMain.send() / webFrameMain.postMessage() ( #26807 )
2021-01-15 09:00:37 +09:00
Electron Bot
28b6579538
Bump v13.0.0-nightly.20210114
2021-01-14 06:33:16 -08:00
Cheng Zhao
cd42933f41
chore: remove ancient Browser::Focus implementation on Windows ( #27279 )
2021-01-13 13:46:54 -08:00
Shelley Vohr
0599487e65
refactor: use platform-specific TaskRunner to print ( #27225 )
2021-01-13 09:17:11 -08:00
Electron Bot
1c66cacf70
Bump v13.0.0-nightly.20210113
2021-01-13 06:34:32 -08:00
loc
ceda33dd5e
chore: surface webcontents load error more readily ( #22824 )
2021-01-13 18:01:51 +09:00
Electron Bot
adf0a73543
chore: bump chromium to a264339194bfa02f5ecb3b8cba449 (master) ( #27111 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2021-01-12 15:31:23 -08:00
Electron Bot
1cd72425aa
Bump v13.0.0-nightly.20210112
2021-01-12 06:33:44 -08:00
Electron Bot
d69f578179
Bump v13.0.0-nightly.20210111
2021-01-11 06:32:34 -08:00
Jeremy Rose
088f2e625f
feat: add frame and webContents to webRequest details ( #27078 )
...
* feat: add frame and webContents to webRequest details
* chore: use frame_converter.h
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2021-01-11 12:20:43 +09:00
Shelley Vohr
e74b425803
fix: set presentationModeEnabled value for PDF viewer ( #27223 )
2021-01-11 10:48:39 +09:00
Electron Bot
8c305b4113
Bump v13.0.0-nightly.20210108
2021-01-08 06:31:06 -08:00
Electron Bot
2268c64a55
Bump v13.0.0-nightly.20210107
2021-01-07 06:32:08 -08:00
Electron Bot
0be4430431
Bump v13.0.0-nightly.20210106
2021-01-06 06:32:17 -08:00
Milan Burda
3d59aa5609
feat: add webFrameMain.executeJavaScriptInIsolatedWorld() ( #26913 )
2021-01-05 17:18:38 +09:00
Cheng Zhao
5f99569b6c
feat: make win.setAspectRatio() work on Windows ( #26941 )
...
* feat: make win.setAspectRatio() work on Windows
* update patches
Co-authored-by: Electron Bot <electron@github.com>
2021-01-05 17:17:33 +09:00
Shelley Vohr
3286b5fa46
fix: handle BrowserView reparenting ( #27000 )
2021-01-04 16:34:22 -08:00
Shelley Vohr
6307b52dc5
fix: default offset when no drag regions ( #27147 )
2021-01-04 14:01:32 -08:00
Shelley Vohr
3455136e9d
refactor: remove path from nativeImage converter ( #26546 )
2021-01-04 12:58:31 -08:00
Shelley Vohr
29c2e2cb97
fix: unclickable regions in some draggable BrowserViews ( #27143 )
2021-01-04 11:22:14 -08:00
Electron Bot
6d31f1ad4c
Bump v13.0.0-nightly.20210104
2021-01-04 10:59:29 -08:00
Electron Bot
1078590bbd
Bump v13.0.0-nightly.20201223
2020-12-23 06:32:07 -08:00
Electron Bot
8383c14aba
chore: bump chromium to 7264889ce3aad1568ff3d211c81fe (master) ( #27003 )
...
* chore: bump chromium in DEPS to 91c9f44297abe2844f593ec7956e6ce79c81f463
* chore: update chromium patches
* chore: update v8 patches
* build: service_names.mojom has been deleted
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2568681
* chore: add DISPLAY_CAPTURE permission to converter
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2551098
* chore: handle AXPropertyFilter::SCRIPT in accessibility_ui
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2563923
* refactor: web_isolated_world_ids.h has been deleted
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585255
* refactor: ResourceType has been deprecated / removed in ExtensionsBrowserClient
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2562002
* chore: fix lint
* chore: remove deleted headers
* build: disable gn check for blink header
* fix: refactor X11 event handling
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2577887
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585750
* chore: update patches
* chore: bump chromium in DEPS to bfd8e7dbd37af8b1bc40d887815edd5a29496fa3
* chore: update patches
* refactor: xeventobserver is now x11:eventobserver
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585750
* refactor: remove UseWebUIBindingsForURL
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2583590
* chore: DidProcessXEvent has been removed
* chore: bump chromium in DEPS to b13e791d7244a08d9d61dbfa2bb2b6cdf1ff6294
* chore: update patches
* build: change gfx::GetAtom to x11:GetAtom
Refs: d972a0ae4ad972a0ae4ac38f8571a8https://chromium-review.googlesource.com/c/chromium/src/+/2572896
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-12-22 14:14:44 -08:00
Electron Bot
729c45637d
Bump v13.0.0-nightly.20201222
2020-12-22 06:33:47 -08:00
Electron Bot
3a970825b2
Bump v13.0.0-nightly.20201221
2020-12-21 06:32:03 -08:00
Eryk Rakowski
bf24759354
fix(extensions): implement missing web_request hooks ( #22655 )
...
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com>
2020-12-18 15:11:43 -08:00
Electron Bot
8f1bc338e5
Bump v13.0.0-nightly.20201218
2020-12-18 06:34:00 -08:00
Cheng Zhao
cdc94e4cef
chore: remove extra setTitlebarAppearsTransparent ( #27042 )
2020-12-18 09:51:05 +09:00
Cheng Zhao
f99ea7c0ba
chore: put NativeWindowMac's methods in order ( #27040 )
2020-12-18 09:50:51 +09:00
Electron Bot
8cbcb04e84
Bump v13.0.0-nightly.20201217
2020-12-17 06:31:25 -08:00
Shelley Vohr
75247d18d0
refactor: remove last use of InternalCallbackScope ( #27029 )
...
* refactor: remove last use of InternalCallbackScope
* update patches
Co-authored-by: Electron Bot <electron@github.com>
2020-12-16 14:02:36 -06:00
Electron Bot
9377b04e0b
Bump v13.0.0-nightly.20201216
2020-12-16 06:32:14 -08:00
Shelley Vohr
9eab298779
feat: add missing 'context-menu' values ( #26788 )
...
* fix: add missing 'context-menu' values
* Add missing canSave
* Remove canTranslate
2020-12-16 14:32:11 +09:00
Cheng Zhao
e01b1831d9
feat: make trafficLightPosition work for customButtonOnHover ( #26789 )
2020-12-16 14:30:39 +09:00
Eryk Rakowski
1e2a2004e9
feat: add support for webContents option in BrowserView ( #26802 )
...
* feat: add support for webContents option in BrowserView
* tests: add tests
2020-12-16 08:52:43 +09:00
Milan Burda
6932e17088
chore: remove deprecated systemPreferences methods ( #26849 )
2020-12-16 08:34:24 +09:00
Shelley Vohr
b266b5208a
refactor: use public node::CallbackScope where possible ( #27001 )
...
* refactor: use public node::CallbackScope where possible
* Remove unused node_env() getter
2020-12-15 11:39:25 -08:00
Nick Harper
21024011d7
fix: incorrect case in content::PermissionType mapping ( #27006 )
2020-12-15 11:14:42 -08:00
Jeremy Rose
833baa4c54
fix: throw when using globalShortcut before ready ( #27002 )
2020-12-15 11:13:56 -08:00
