Samuel Attard
866cbb0147
fix: SetCanonicalCookieAsync now takes the full CookieOptions
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1471244
2019-04-02 14:43:04 -07:00
Samuel Attard
7467e91880
fix: RFH->ExecuteJavascriptForTesting now requires a callback
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1492042
2019-04-02 14:43:04 -07:00
Samuel Attard
74ac80e218
fix: ViewHierarchyChangedDetails moved to the views namespace
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1531481
2019-04-02 14:43:04 -07:00
Samuel Attard
ab92cfd174
fix: enable_file_url_support and enable_data_url_support have been
...
removed
Unsure how the change in default of file_url_support affects us
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1512337
2019-04-02 14:43:04 -07:00
Samuel Attard
f95de3d6f3
fix: RFH->ExecuteJavascript now requires a callback
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1492042
2019-04-02 14:43:04 -07:00
Samuel Attard
2bf740d2fe
fix: remove enable_data_url_support from OnNetworkServiceCreated
...
data URLs are _always_ enabled in the network service now and this is
enforced in the Content layer.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1512337
2019-04-02 14:43:04 -07:00
Jeremy Apthorp
e44b5263a1
add extra arguments to HandleExternalProtocol
...
https://chromium-review.googlesource.com/c/chromium/src/+/1491812
2019-04-02 14:43:03 -07:00
Samuel Attard
75442b794f
fix: make devtools extensions load correctly ( #17614 )
2019-03-30 17:36:13 -07:00
Samuel Attard
3475cd168e
fix: handle a race condition between preload scripts executing and ( #17577 )
...
navigations
There is a race condition between DidCreateScriptContext and another
navigation occuring in the main process. If the navigation occurs while
the preload script is running, the same process is re-used. This
ensures that any pending navigations are completely removed / ignored
when we trigger a new navigation.
Fixes #17576
2019-03-28 11:13:05 -07:00
Samuel Attard
f4434763fe
fix: use file path as key for safeDialogs on filesystem ( #17546 )
2019-03-27 11:21:10 -07:00
Samuel Attard
2188a6ea99
fix: set default_id and cancel_id correctly on confirm dialogs ( #17547 )
2019-03-27 11:15:58 -07:00
Shelley Vohr
4e57a732a8
feat: allow windows to be excluded from the windows menu ( #17404 )
...
* feat: allow windows to be excluded from the windows menu
* excludedfromWindowsMenu => excludedFromShownWindowsMenu
* implement no-op for win & linux
2019-03-27 08:10:23 -04:00
Robo
6c20c6e668
refactor: Enable network service (Part 1) ( #17431 )
...
* Convert InspectableWebContentsImpl::LoadNetworkResource to SimpleURLLoader
https://bugs.chromium.org/p/chromium/issues/detail?id=721408
* Plumb creation of network context with the service
2019-03-26 10:10:48 +09:00
Cheng Zhao
49f13e38f9
fix: close context menu before popup ( #17474 )
2019-03-21 21:56:22 -07:00
Jeremy Apthorp
6555be2636
chore: bump chromium to 74.0.3729.27 (master) ( #17345 )
...
* chore: bump chromium to 74.0.3729.5 (master)
* Remove ScopedBlockingCall constructor without location
https://chromium-review.googlesource.com/c/chromium/src/+/1496560
* Use XCode 9.4.1 for Mac SDK 10.13
* chore: roll chromium 74.0.3729.27
2019-03-21 11:45:22 -04:00
Shelley Vohr
b140a82fe8
fix: take foreground visibility into account for isVisible on macOS ( #17463 )
2019-03-20 15:33:59 -07:00
Samuel Attard
45d90e77b7
fix: use a more unique identifier for NSUserNotification instances ( #17469 )
...
So although apple has it documented that notifications with duplicate identifiers in the same session won't be presented. They apparently forgot to mention that macOS also non-deterministically and without any errors, logs or warnings will also not present some notifications in future sessions if they have a previously used identifier.
As such, we're going to truly randomize these identifiers so they are
unique between apps and sessions. The identifier now consists of a
randomly generated UUID and the app bundle id.
2019-03-20 09:53:20 -07:00
Milan Burda
4c51fa93f5
feat: add systemPreferences.getAnimationSettings() ( #17382 )
2019-03-19 12:15:40 -07:00
Shelley Vohr
2fb9085e5b
feat: add tray.getTitle() ( #17385 )
...
* feat: add tray.getTitle
* fix spec
2019-03-18 12:40:34 -07:00
Shelley Vohr
38d75010c7
chore: rename atomBinding to electronBinding ( #17419 )
2019-03-18 12:37:06 -07:00
Samuel Attard
5025c991ee
fix: pass the correct HostPort into the node inspector ( #17380 )
...
Fixes #17348
2019-03-18 09:19:33 -07:00
Shelley Vohr
961c9a88a8
feat: promisify dialog.showCertificateTrustDialog() ( #17181 )
...
* feat: promisify dialog.showCertificateTrustDialog()
* update promisification doc
2019-03-15 09:02:50 +09:00
Shelley Vohr
12b6a0f5b2
feat: add native emoji picker ( #17359 )
2019-03-14 13:39:52 -07:00
Shelley Vohr
aa8b66aae1
feat: promisify session.getBlobData() ( #17303 )
2019-03-14 08:11:01 -07:00
Shelley Vohr
d9234798d3
chore: clean up promise resoution with helpers ( #17268 )
2019-03-13 14:30:21 -07:00
Shelley Vohr
3e5a98b5f4
feat: promisify In-App Purchase ( #17355 )
...
* feat: promisify In-App Purchase
* use mate::Arguments in GetProducts
2019-03-13 13:56:01 -07:00
Heilig Benedek
14cc8a1808
fix: improve focused menu bar item visibility ( #17291 )
2019-03-12 15:29:45 -07:00
Shelley Vohr
8991c0056e
feat: promisify dialog.showMessageBox() ( #17298 )
...
* feat: promisify dialog.showMessageBox()
* address feedback from review
2019-03-12 11:06:59 -07:00
Nitish Sakhawalkar
e77d065875
chore: node_includes header no longer needs to be at the end of the list ( #17090 )
...
Until one of the latest version of node, the definition of the DISALLOW_COPY_AND_ASSIGN macro in node was different than in chromium. That is no longer the case, so just undefining the macro in node_includes.h works.
2019-03-11 17:13:43 -07:00
Samuel Attard
c7a453226d
fix: remove label/image from segment if they are mutated to undefined/null ( #17323 )
2019-03-11 11:13:36 -07:00
Electron Bot
b43e4b8e0e
Bump v6.0.0-nightly.20190311
2019-03-11 10:56:01 -07:00
Electron Bot
a958eb9c44
Bump v6.0.0-nightly.20190308
2019-03-08 19:38:21 -08:00
Electron Bot
7343a2f232
Revert "Bump v6.0.0-nightly.20190308"
...
This reverts commit 40af881844
.
2019-03-08 19:36:24 -08:00
Electron Bot
40af881844
Bump v6.0.0-nightly.20190308
2019-03-08 19:36:08 -08:00
Shelley Vohr
9ea6c01e02
feat: promisify session.clearAuthCache() ( #17259 )
...
* feat: promisify session.clearAuthCache()
* remove unused callback runner helpers
2019-03-08 18:41:42 -08:00
Electron Bot
58a9a81895
Revert "Bump v6.0.0-nightly.20190308"
...
This reverts commit 4728cebd9e
.
2019-03-08 17:46:53 -08:00
Electron Bot
4728cebd9e
Bump v6.0.0-nightly.20190308
2019-03-08 17:13:26 -08:00
Samuel Attard
e185057ef9
chore: fix linting issues in atom_api_cookies.cc
2019-03-08 15:13:22 -08:00
deepak1556
457ff0687c
device/fido/mac: add more specific check for TouchID availability
...
https://chromium-review.googlesource.com/c/chromium/src/+/1487811
2019-03-08 15:13:12 -08:00
Jeremy Apthorp
bf6fea3b59
AttachToOuterWebContentsFrame => AttachInnerWebContents
...
https://chromium-review.googlesource.com/c/1492653
2019-03-08 15:13:12 -08:00
Jeremy Apthorp
0d534b3c52
fix: compile error in frame_subscriber.h
...
https://chromium-review.googlesource.com/c/1460096
2019-03-08 15:13:12 -08:00
Jeremy Apthorp
69bf9aa605
fix extra-semi warnings
2019-03-08 15:10:52 -08:00
deepak1556
e8f6f31fe4
Disable network service
...
https://github.com/electron/electron/issues/15791
2019-03-08 15:06:16 -08:00
deepak1556
fb9d1bd83c
Change net::CookieStore::SetCookiesCallback to return CookieInclusionStatus
...
https://chromium-review.googlesource.com/c/chromium/src/+/1470931
2019-03-08 15:06:16 -08:00
deepak1556
c735116cc3
Take scheme in CookieStore::SetCanonicalCookieAsync, not just whether it's secure.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1450420
2019-03-08 15:06:16 -08:00
deepak1556
bfe876afcd
Use IPEndPoint instead of HostPortPair
...
https://chromium-review.googlesource.com/c/chromium/src/+/1473094
2019-03-08 15:06:16 -08:00
deepak1556
3f4f774838
Remove const interfaces from content::ResourceRequestInfo.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1474632
2019-03-08 15:06:16 -08:00
deepak1556
66128a7152
Add RenderFrameHost as parameter to WebContentsDelegate::HandleContextMenu
...
https://chromium-review.googlesource.com/c/chromium/src/+/1472696
2019-03-08 15:06:16 -08:00
Jeremy Apthorp
38c3891337
fix: initialize field trial list
...
https://chromium-review.googlesource.com/c/1402880
2019-03-08 15:06:15 -08:00
Jeremy Apthorp
014654e794
[OnionSoup] Replace content::RendererPreferences with the mojom one.
...
https://chromium-review.googlesource.com/c/1426522
2019-03-08 15:04:32 -08:00
deepak1556
d04d11cfb5
[mojo] include mojo header
...
https://chromium-review.googlesource.com/c/chromium/src/+/1447145
2019-03-08 15:04:32 -08:00
deepak1556
03f9d40635
Expand GpuInfo to include image decode acceleration support.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1471913
2019-03-08 15:04:32 -08:00
deepak1556
527e8f3a31
IWYU: add missing headers
2019-03-08 15:04:32 -08:00
deepak1556
49f414b439
[Mac] Remove GC calls from Chromium.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1471382
2019-03-08 15:04:32 -08:00
deepak1556
43361164e8
Change signature of GetCookieListCallback to include list of excluded cookies
...
https://chromium-review.googlesource.com/c/chromium/src/+/1416151
2019-03-08 15:04:32 -08:00
deepak1556
ccd4a3c80c
CookieStore::DeleteCookieAsync appears unused (outside a few tests), so remove it
...
https://chromium-review.googlesource.com/c/chromium/src/+/1456677
2019-03-08 15:04:32 -08:00
deepak1556
ac609a3d78
Remove deprecated override of RegisterDictionaryPref
...
https://chromium-review.googlesource.com/c/chromium/src/+/1459538
2019-03-08 15:04:32 -08:00
deepak1556
611b36719b
Remove channel_id_path from NetworkContextParams (and other related places)
...
https://chromium-review.googlesource.com/c/chromium/src/+/1435678
2019-03-08 15:04:32 -08:00
deepak1556
59cb0ac32e
Copy base::JSONReader::Read() to ReadDeprecated().
...
https://chromium-review.googlesource.com/c/chromium/src/+/1435715
2019-03-08 15:04:32 -08:00
deepak1556
6f14df039e
[DevTools] Stop passing base::Value to DevToolsManagerDelegate
...
https://chromium-review.googlesource.com/c/chromium/src/+/1459807
2019-03-08 15:04:32 -08:00
deepak1556
4450c26206
[v8] Advance deprecation for Value::BooleanValue
...
https://chromium-review.googlesource.com/c/v8/v8/+/1458245
2019-03-08 15:04:32 -08:00
deepak1556
b99ff3448e
Use base::BindOnce in notifications code
...
https://chromium-review.googlesource.com/c/chromium/src/+/1418170
2019-03-08 15:04:32 -08:00
Shelley Vohr
fc10620082
feat: promisify session cache methods ( #17185 )
2019-03-08 14:42:03 -08:00
Shelley Vohr
2769e75b49
feat: promisify session proxy methods ( #17222 )
2019-03-08 12:51:12 -08:00
Robo
5afb7dc715
refactor: load electron builtin modules with process._linkedBinding ( #17247 )
...
* refactor: load electron builtin modules with process._linkedBinding
NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are
removed in https://github.com/nodejs/node/pull/25829 . This changes
uses the alternative available without any functionality change.
* chore: roll node
2019-03-08 10:29:52 -08:00
Shelley Vohr
e5e6aa207c
feat: promisify ses.clearHostResolverCache() ( #17229 )
2019-03-08 10:26:17 -08:00
Shelley Vohr
bbfa63fd9d
feat: promisify session.clearStorageData() ( #17249 )
2019-03-08 09:02:30 -08:00
Shelley Vohr
a4418a9014
chore: add static promise resolution helpers ( #17223 )
...
* chore: add static promise resolution helpers
* address feedback
* address feedback from review
2019-03-07 18:07:04 -08:00
Samuel Maddock
ac88b3ead5
feat: add 'disableHtmlFullscreenWindowResize' option to webPreferences ( #17203 )
...
This option allows users to prevent the window from resizing when the HTML5 FullScreen API is used.
2019-03-07 15:29:37 -08:00
Electron Bot
8c4d6438de
Bump v6.0.0-nightly.20190307
2019-03-07 12:51:33 -08:00
Electron Bot
229934ec66
Revert "Bump v6.0.0-nightly.20190307"
...
This reverts commit ab785e73ac
.
2019-03-07 12:47:33 -08:00
Electron Bot
ab785e73ac
Bump v6.0.0-nightly.20190307
2019-03-07 12:34:10 -08:00
Robo
d4d6b9862f
fix: make StreamSubscriber ref counted ( #17221 )
...
It is owned by URLRequestStreamJob on the IO thread once request starts,
but if the ownership was abondoned while transfering it to IO thread
which is possible when a request is aborted, then we need to make sure
its destroyed on the right thread to avoid lock in v8.
2019-03-07 20:50:03 +05:30
Shelley Vohr
6cb7b8d3a4
feat: promisify dialog.showSaveDialog() ( #17054 )
...
* feat: promisify dialog.showSaveDialog()
* address some feedback from review
* filename => filePath
* fix last filename => filePath
2019-03-05 13:48:20 -08:00
Shelley Vohr
e05985145b
feat: promisify dialog.showOpenDialog() ( #16973 )
...
* feat: promisify dialog.showOpenDialog()
* address feedback from review
* address feedback from review
2019-03-05 05:54:48 -08:00
Robo
7936237677
build: enable gn check for //electron:electron_lib ( #17100 )
...
* build: enable gn check for //electron:electron_lib
* ci: add gn check step
* ci: set depot_tools path
* chrome_key_systems_provider.h nogncheck
* chore: fix gn check errors on windows
* chore: gn check //electron:electron_app
2019-03-05 10:38:55 +05:30
Charles Kerr
ed31cfebc9
fix: check for pane focus before removing it. ( #17164 )
...
Fixes #16883 . This bug seems to have been introduced in the #15302 's
menu a11y refactor and is new in 5-0-x.
2019-03-04 09:47:59 -06:00
Shelley Vohr
544d8a423c
feat: allow MenuItems to work optionally when hidden ( #16853 )
...
* feat: allow MenuItems to work optionally when hidden
* fix: actually include forward_declaration
2019-02-28 17:00:54 +00:00
Nitish Sakhawalkar
bfa07ec4be
feat: Add new powerMonitor synchronous API ( #17144 )
...
`powerMonitor.querySystemIdleState` and `powerMonitor.querySystemIdleTime` had async backing APIs in chromium (https://chromium-review.googlesource.com/c/chromium/src/+/1379183 ). However, that has changed in ch73. So, this PR deprecates the old async APIs and adds new sync APIs.
2019-02-27 15:54:01 -05:00
Nitish Sakhawalkar
5da89c3a2b
chore:Remove transparency hack ( #17128 )
...
This change undoes the hack that was put in because of a bug in chromium. That has since been fixed in chromium, so this is no longer need, hence removing.
The 'BrowserWindow' > 'preserves transparency' test, validates this working.
2019-02-27 14:51:30 -05:00
Samuel Attard
e01c3615c4
chore: replace usage of deprecated beginSheetModalForWindow API ( #16994 )
2019-02-27 10:23:17 -08:00
Electron Bot
a07cb2afd7
Bump v6.0.0-nightly.20190227
2019-02-27 09:55:19 -08:00
Johann Fuechsl
42aa375497
fix: access of out-of-scope reference in ShowOpenDialog and ShowSaveDialog ( #17126 )
...
In the mac file dialog implementation of show*OpenDialog, a settings
object is passed down to the dialog completion handler.
However at the time the completion handler is invoked, the settings
object is already out-of-scope, resulting in an invalid access to
the security_scoped_bookmarks flag.
The fix is to capture the value of the flag and passing that directly
to the completion handler.
fixes issue #16664
2019-02-27 08:14:04 +00:00
Electron Bot
848d16525f
Revert "Bump v6.0.0-nightly.20190226"
...
This reverts commit 7c78f11b82
.
2019-02-26 15:20:32 -08:00
Electron Bot
7c78f11b82
Bump v6.0.0-nightly.20190226
2019-02-26 14:56:19 -08:00
Robo
ddcebb096f
fix: use frame tree api to remove <webview> frame ( #16501 )
...
Replaces the usage of testing api added in
03d499bf34
2019-02-25 17:47:29 -08:00
Shazron Abdullah
6da939629b
fix: respect the user's active app focus ( #16400 )
...
* Respect the user's active app
Apple recommends not setting this to true. https://developer.apple.com/documentation/appkit/nsapplication/1428468-activateignoringotherapps?language=objc
* Remove atom_bundle_mover.mm change for [NSApp activateIgnoringOtherApps:]
2019-02-25 17:44:38 -08:00
Milan Burda
5e762d6a47
chore: finalize dropping support for OS X Mavericks (version 10.9) ( #17102 )
2019-02-25 17:21:57 +00:00
Thomas Beverley
1674388028
Fix webContents.print() ( #17052 )
2019-02-25 13:30:21 +00:00
Cheng Zhao
32a4de4a68
chore: make util::Promise a move-only type ( #17071 )
2019-02-21 12:32:44 +00:00
Shelley Vohr
3edc497d3d
feat: show user gesture type in click event ( #16954 )
2019-02-20 12:20:24 +00:00
Milan Burda
7e7abc28f5
feat: promisify netLog.stopLogging ( #16862 )
2019-02-19 10:48:27 +00:00
Milan Burda
975a035d34
chore: re-enable devtools renderer sandbox ( #16864 )
...
* chore: re-enable devtools renderer sandbox
* chore: enable sandbox for chrome extension background script host renderers
2019-02-15 15:10:32 +05:30
Samuel Attard
5790869a3f
chore: refactor browser IPC into TS and app API into TS ( #16921 )
...
* chore: refactor browser IPC into typescript
* chore: refactor app.ts into Typescript
* Refactors app.dock into cpp
* Removes app.launcher which has not existed for 3 years
* Removes 2 deprecated APIs (that have been deprecated for more than one
major)
* Refactors deprecate.ts as well
2019-02-14 14:29:20 -08:00
deepak1556
d7fea1b484
REVIEW: fix possible -Wdeprecated-declarations warnings
2019-02-14 23:59:26 +05:30
Heilig Benedek
d7557cb66a
chore: use c++ manifests instead of json
2019-02-14 23:59:26 +05:30
Heilig Benedek
cece8bce0b
chore: make OSR compile on Windows
2019-02-14 23:59:26 +05:30
deepak1556
66db627913
Remove "layouttest" or "layout test" in //content
...
https://chromium-review.googlesource.com/c/chromium/src/+/1367391
2019-02-14 23:59:26 +05:30
deepak1556
76fde58e27
REVIEW: ui::Compositor: Simplify how ExternalBeginFrameClient is used.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1388384
2019-02-14 23:59:26 +05:30
deepak1556
8a51c9c2f6
REVIEW: Have MouseWheelPhaseHandler agree on whether to route its wheel event
...
https://chromium-review.googlesource.com/c/chromium/src/+/1401664
2019-02-14 23:59:26 +05:30