Jeremy Apthorp
76a62b44dc
build: [gn] simplify resource pak build
2018-07-24 10:18:27 -07:00
Aleksei Kuzmin
ea16445be7
chore: [tests] update some BrowserWindow tests
...
- manually close an existing windows before creating a new one.
We have to do it because the `afterEach` hook doesn't get called
if a test fails.
- add some async/await goodies
2018-07-24 10:02:54 -07:00
Cheng Zhao
3094f62f0b
fix: use webContentsId with contextId together ( #13749 )
...
After after using `processId-contextCounter` as contextId, it may happen
that contexts in different WebContents sharing the same renderer process
get the same contextId. Using webContentsId as part of key in
ObjectsRegistry can fix this.
2018-07-24 16:21:38 +09:00
Jeremy Apthorp
d7b41462af
build: [gn win] fix dllimport usage in node's usage of icu
...
We're abusing the nodejs build a little bit by building it without ICU support, but forcing the inspector to be built, which depends on ICU. This synchronizes one of the build flags that's required to get ICU to link on Windows.
2018-07-23 10:11:32 -07:00
Cheng Zhao
305e3aad40
refactor: remove private webContents.getId() API ( #13674 )
2018-07-23 18:08:36 +09:00
Cheng Zhao
a88cdf2d1f
spec: suppress mixed-sandbox test in Windows CI ( #13769 )
2018-07-23 18:08:06 +09:00
Cheng Zhao
9d6f1a372e
fix: create WebContents for webview on request ( #13713 )
2018-07-21 11:11:28 +09:00
Jeremy Apthorp
014832237c
Merge pull request #13747 from nornagon/nornagon/gn-ci-builds
...
build: [ci] add GN linux CI build
2018-07-20 16:08:45 -07:00
Jeremy Apthorp
4918e279e2
build: stop defining is_mas_build ( #13742 )
...
is_mas_build is now defined in libcc.
2018-07-20 14:34:12 -07:00
Jeremy Apthorp
77004c6be8
Update DEPS
2018-07-20 14:33:51 -07:00
Jeremy Apthorp
1aa16d0ac0
build: [gn win] fix webrtc link error
...
Fixes link errors of the form
```
init_webrtc.lib(init_webrtc.obj) : error LNK2005: "class webrtc::metrics::Histogram * __cdecl webrtc::metrics::HistogramFactoryGetCounts(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,int,int,int)" (?HistogramFactoryGetCounts@metrics@webrtc@@YAPAVHistogram@12@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@HHH@Z) already defined in metrics_default.obj
```
2018-07-20 14:30:14 -07:00
John Kleinschmidt
6b3ee233ff
Use actual binary instead of python wrapper
2018-07-20 17:07:31 -04:00
John Kleinschmidt
856483fe61
Add sccache
...
Also removed unneeded slack notifcations
2018-07-20 16:29:57 -04:00
John Kleinschmidt
004abe3ce8
build: [ci] add GN linux CI build
2018-07-20 13:02:28 -07:00
Tiago Danin
1fd6d38a0a
docs: Improved documentation ( #13403 )
2018-07-20 10:58:19 -07:00
John Kleinschmidt
2440d03595
Merge pull request #13739 from electron/fix-rebuild-native-modules
...
fix: update rebuild-test-modules.py for node 10
2018-07-20 11:20:32 -04:00
John Kleinschmidt
af241c8b4b
Merge pull request #13748 from electron/gn-win32
...
build: [gn] working on 32bit windows
2018-07-20 10:25:04 -04:00
John Kleinschmidt
d757e03d86
Merge pull request #13746 from electron/gn-refactor
...
build: [gn] reorganize :electron_lib target
2018-07-20 10:10:47 -04:00
Jeremy Apthorp
16b66db9c7
build: [gn] working on 32bit windows
2018-07-19 17:04:44 -07:00
Jeremy Apthorp
803f84d7ec
build: [gn] reorganize :electron_lib target
2018-07-19 16:30:23 -07:00
Zeke Sikelianos
a2ac31a4bf
Merge pull request #13736 from electron/build--make-nightly-filenames-more-guessable-with-YMD-format
...
build: make nightly filenames more guessable with YMD format
2018-07-19 16:23:11 -07:00
Jeremy Apthorp
9fff635453
build: stop defining is_mas_build
2018-07-19 16:10:16 -07:00
Zeke Sikelianos
9b91d632e0
build: make nightly filenames more guessable with YMD format
2018-07-19 14:12:12 -07:00
John Kleinschmidt
3247d789f2
Merge pull request #13737 from electron/build--do-not-load-dotenv-on-CI
...
chore(ci): do not load dotenv on CI
2018-07-19 15:32:10 -04:00
John Kleinschmidt
f8b646c90a
Merge pull request #13543 from electron/ajm-win7-crash
...
Ensure DirectX capturer is supported.
2018-07-19 15:11:42 -04:00
Zeke Sikelianos
94ea703a32
build: do not load dotenv on CI
2018-07-19 11:48:13 -07:00
Jeremy Apthorp
f2a7fd44ce
build: enable v8 checks in debug mode
2018-07-19 11:39:36 -07:00
Cheng Zhao
e2029435c4
fix: use context counter as contextId
...
For sandboxed renderer it may not have a node::Environment in the context,
using a increasing counter as contextId works for all cases.
2018-07-19 11:00:10 -07:00
John Kleinschmidt
3f228ad715
fix: update for node 10
2018-07-19 13:18:10 -04:00
John Kleinschmidt
9acfe34286
Merge pull request #13724 from electron/windows-release-test-fix
...
build: Temporarily disable found-in-page event test
2018-07-18 21:31:30 -04:00
John Kleinschmidt
f1cc40e3bf
Merge pull request #13359 from electron/release-notes-generator
...
build: New release notes generator
2018-07-18 16:19:32 -04:00
John Kleinschmidt
1d6766008a
Merge pull request #13725 from electron/node-headers
...
build: [gn] add target for building node headers
2018-07-18 16:16:18 -04:00
Jeremy Apthorp
70068f313a
build: [gn] add target for building node headers
2018-07-18 12:01:16 -07:00
John Kleinschmidt
613b03c3c7
build: disable found-in-page event
test
...
On Windows release builds, the found-in-page event test causes the test suite to hang. If the test is run individually, it works fine, but running it as part of the whole test suite causes the test suite to hang. This works around the issue in #13704 by temporarily disabling that test.
2018-07-18 14:59:46 -04:00
John Kleinschmidt
fc33130aa3
Merge pull request #13672 from brunolemos/patch-1
...
docs: remove known issues from mac app store submission guide
2018-07-18 14:44:50 -04:00
Samuel Attard
f26880db03
Update docs on semantic requirements for #13359 ( #13365 )
2018-07-18 10:41:58 -05:00
Jeremy Apthorp
91172d6387
build: [gn] move native_mate build config to native_mate dir ( #13706 )
2018-07-18 11:45:13 +10:00
Jeremy Apthorp
0c366f5a7a
chore: [gn] roll libcc DEPS
2018-07-17 15:54:58 -07:00
Samuel Attard
81640806bc
add semantic prefixes from docs
2018-07-18 02:25:56 +10:00
Samuel Attard
57a18d4c49
clean up release notes script
2018-07-18 02:25:56 +10:00
Samuel Attard
2c255680a9
new release notes generator
2018-07-18 02:25:56 +10:00
John Kleinschmidt
05538aa32c
Merge pull request #13629 from electron/use-dot-env
...
docs: use .env (and .env.example) for tokens used in release
2018-07-17 11:57:42 -04:00
John Kleinschmidt
6edbb3e3ed
Merge pull request #13662 from electron/nightly-updates
...
chore: Updates for nightly builds
2018-07-17 11:13:20 -04:00
John Kleinschmidt
3581bf0cfc
Merge pull request #13688 from electron/gn-custom-sysroot
...
build: [gn] use libnotify from custom sysroot
2018-07-17 09:22:49 -04:00
Milan Burda
c8030a0f2a
feat: support chrome:// URLs in default_app ( #13575 )
2018-07-17 17:23:44 +10:00
Samuel Attard
c313fd614c
build: handle win32 path separator in js2asar ( #13694 )
2018-07-17 15:31:06 +10:00
Samuel Attard
777d0113d5
fix: create a window capturer correctly ( #13689 )
...
* fix: create a window capturer correctly
We were incorrectly creating two screen capturers instead of a window
capturer
* spec: ensure dc tests pass
* spec: enable all tests after verifying dc tests work
2018-07-17 14:20:50 +10:00
Samuel Attard
ad9e64d086
fix: remove race condition for executeJavaScript ( #13691 )
...
Replaces 'did-finish-load' with 'did-stop-loading' which semantically
maps to the events inside Chromium. Before I think we were relying
on a natural 99% winnable race condition.
Fixes #13504
2018-07-17 13:32:28 +10:00
Jeremy Apthorp
5864fa321c
build: [gn] use libnotify from custom sysroot
...
Instead of hackily copying from the local machine.
Depends on electron/libchromiumcontent#601
2018-07-16 17:33:42 -07:00
Samuel Attard
12fcac59a2
refactor: clean up the default app, add CSP ( #13437 )
...
* refactor: clean up the default app, add CSP
* chore: appease the linter
* refactor: make js2asar more generic, dont assume default_app as target
2018-07-17 10:26:58 +10:00