7593605a6a
Inject custom workflow
2024-11-27 20:01:19 +00:00
trop[bot]
fb47716885
fix: remove unused local variables ( #44821 )
...
* chore: remove unused local non-trivial variable relaunch_executable
became unused in June 2016 in 0d066de572a08926
2024-11-24 13:03:09 -06:00
trop[bot]
efa354e9d9
docs: update new GitHub issue link ( #44812 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-11-22 16:50:47 -06:00
trop[bot]
67ccd2792e
fix: big endian bug in V8 serialization ( #44794 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-22 12:55:55 -05:00
trop[bot]
0c83fb1540
test: run script to help target discovery and reduce flakes ( #44763 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2024-11-20 16:34:52 -05:00
John Kleinschmidt
2bd3a9fe65
fix: WebContentsView removal should compare directly ( #44673 )
...
fix: `WebContentsView` removal should compare directly (#44656 )
* fix: WebContentsView removal should compare directly
* fixup view comparision
* chore: use erase_if
* Apply review suggestions
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-15 13:09:47 +01:00
Pedro Pontes
9c5c5d0fea
chore: cherry-pick 1 changes from 0-M131 ( #44649 )
...
chore: [31-x-y] cherry-pick 1 changes from 0-M131
* 923797bac925 from chromium
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
2024-11-13 17:25:38 -06:00
trop[bot]
b6e16fa18d
fix: WCO buttons hidden on Linux in fullscreen ( #44643 )
...
Closes https://github.com/electron/electron/issues/44569 .
Fixes an issue where the WCO buttons were hidden on Linux in fullscreen mode
but not on Windows or macOS. The Windows behavior is the expected one, so this
commit makes the Linux behavior consistent.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-13 15:44:51 -05:00
Pedro Pontes
d85a59b6ea
chore: cherry-pick 1 changes from 3-M130 ( #44646 )
...
chore: [31-x-y] cherry-pick 1 changes from 3-M130
* e699ac35ac6c from chromium
2024-11-13 11:15:21 -08:00
trop[bot]
a05ebed03d
fix: segfault when moving WebContentsView between BrowserWindows ( #44614 )
...
* fix: segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: actually enable fix
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-12 10:34:02 -05:00
trop[bot]
2d150ccb33
chore: remove executable flag from docs/api/app.md file permissions ( #44579 )
...
chore: set docs/api/app.md file permissions to 644
md files should not be executable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-05 12:12:23 -05:00
trop[bot]
7037042566
build: add new status to verify if all the required gha jobs have run ( #44560 )
...
build: add new status to verify if all the required gha jobs have run (#44432 )
(cherry picked from commit 1c1eb3e19dad1c60dc8926542ce9bbb3a71735f9)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-04 21:13:54 -06:00
trop[bot]
b0698ec9f4
build: remove unused lint package ( #44533 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-11-04 19:22:24 -05:00
trop[bot]
aa16c04abc
build: handle out of disk space on source cache ( #44491 )
...
* build: handle out of disk space on source cache
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* build: add cron job to free up source cache disk space
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-31 20:27:27 -04:00
Pedro Pontes
15f8a19c98
chore: cherry-pick 2 changes from 1-M130 ( #44483 )
...
* chore: cherry-pick 2 changes from 1-M130
* chore: cherry-pick 1 change from 2-M130
2024-10-31 17:31:19 -04:00
Pedro Pontes
098680c4bb
chore: cherry-pick 1 change from 2-M130 ( #44485 )
2024-10-31 14:43:15 -04:00
Charles Kerr
17c9c79202
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() (31-x-y) ( #44455 )
...
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() (#44238 )
* fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons()
* fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211 )
2024-10-29 21:41:36 +01:00
trop[bot]
9e9bb3dc7a
fix: crash on netlog connection error ( #44421 )
...
* fix: crash on netlog connection error
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* refactor: remove default PromiseBase constructor
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* Revert "refactor: remove default PromiseBase constructor"
This reverts commit 9292324a0d5f9e63ba8f73f63dfff1d48eb2f38f.
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* remove dcheck
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2024-10-28 14:37:47 +01:00
trop[bot]
1e000ff2d6
test: deflake flaky tests on linux ( #44404 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-25 15:54:57 -05:00
Keeley Hammond
87947793d5
chore: cherry-pick 3 changes from 2-M129 ( #44236 )
...
* chore: [31-x-y] cherry-pick 3 changes from 2-M129
* 56be91796b85 from chromium
* c333ed995449 from chromium
* a7766feb0a90 from v8
* chore: update patches
* chore: update patches
* Remove an unnecessary backport, update another.
---------
Co-authored-by: Pedro Pontes <pepontes@microsoft.com>
2024-10-23 17:18:11 -04:00
Pedro Pontes
c6714ee45c
chore: backport 15 changes from 2-M127 to 1-M129 ( #44355 )
...
chore: backport 18 changes from 2-M127 to 1-M129
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-22 16:20:35 +02:00
Pedro Pontes
afad838a8b
chore: backport 2 changes from 0-M130 ( #44356 )
2024-10-22 11:53:48 +02:00
trop[bot]
a826f895d2
build: fixup reclient use for prod builds ( #44343 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-21 16:32:30 -05:00
trop[bot]
028863a93c
fix: respect setAlwaysOnTop before showInactive on Linux under X11 ( #44323 )
...
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44078 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <31829097+cptpcrd@users.noreply.github.com>
2024-10-18 16:19:15 -04:00
trop[bot]
ff024cd396
chore: fixup reclient read only access on forks ( #44310 )
...
chore: fixup reclient read only access on forks (#44280 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-18 12:05:31 -04:00
Keeley Hammond
c2c6bc57c1
chore: cherry-pick 3 changes from 1-M129 ( #44255 )
...
* chore: [31-x-y] cherry-pick 3 changes from 1-M129
* 85dd0fcc70ed from chromium
* 8068f489ec2c from v8
* f612d9a40b19 from v8
* chore: update patches
* chore: remove cherry-pick-85dd0fcc70ed.patch
* 901496: [M126-LTS][ganesh] Avoid int overflow in DrawAtlasOpImpl | https://skia-review.googlesource.com/c/skia/+/901496
* Trigger CI
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-18 09:52:41 -04:00
trop[bot]
2f247ad050
fix: Linux crash after webContents.print() with no parent window ( #44283 )
...
fix: Linux crash after print with no parent window
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-17 22:22:27 -04:00
trop[bot]
9d2c0ac9fe
build: remove dead code in prepare release script ( #44288 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-10-17 10:21:34 -04:00
trop[bot]
00e5d0ad56
fix: ensure utilityProcess only emits one 'exit' event ( #44267 )
...
fix: ensure utilityProcess only emits one exit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-16 15:04:26 +02:00
Keeley Hammond
1ab051bb69
chore: cherry-pick 2 changes from 3-M129 ( #44232 )
...
* chore: [31-x-y] cherry-pick 2 changes from 3-M129
* 9542895cdd3d from v8
* 81155a8f3b20 from v8
* chore: update patches
2024-10-14 22:10:02 -05:00
Charles Kerr
48b962898d
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (31-x-y) ( #44215 )
...
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (#44185 )
2024-10-13 20:04:33 +02:00
Charles Kerr
dce705efc0
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44149 ) ( #44216 )
...
fixup e8948397
2024-10-13 20:04:18 +02:00
trop[bot]
e206378680
fix: clang variable configuration in generated node headers ( #44202 )
...
* fix: clang variable configuration in generated node headers
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: restore value in common.gypi
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 14:52:49 -04:00
trop[bot]
4ccf4fa97d
ci: don't call datadog test logging on forks ( #44194 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 09:42:10 -04:00
trop[bot]
d262568f77
ci: add datadog test logging ( #44165 )
...
* ci: add datadog test logging
(cherry picked from commit 394ea2979fda0c1551df5d5bdf7c13b57d9be181)
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* ci: only upload to datadog when running tests
(cherry picked from commit c3200d8f1540f78c25673a4a9d9af3b8506f9474)
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-10 10:21:38 +02:00
trop[bot]
dbfe4742d5
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() ( #44168 )
...
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 19:36:05 -05:00
trop[bot]
478defb15c
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() ( #44172 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 16:47:48 -05:00
electron-roller[bot]
ba88433eb3
chore: bump node to v20.18.0 (31-x-y) ( #44115 )
...
* chore: bump node in DEPS to v20.18.0
* chore: update patches
* src: improve buffer.transcode performance
https://github.com/nodejs/node/pull/54153
(cherry picked from commit 669984dafcb698716fc02a03e4cf027767a6ec59)
(cherry picked from commit 4b76e4e4937219b8aad665b8c83fb912528ab304)
* chore: update patches
(cherry picked from commit 1f3019564967486104c289025cc68830b7aeb266)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-09 09:53:12 -04:00
Samuel Attard
ba6d9291d2
build: add import/order eslint rule ( #44108 )
...
build: add import/order eslint rule (#44085 )
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-03 15:21:54 -07:00
trop[bot]
6da785fd10
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (31-x-y) ( #44100 )
...
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (#44053 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 20:46:47 -05:00
trop[bot]
daca2d327f
fix: remove use of deprecated API base::Hash() ( #44101 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 20:46:26 -05:00
trop[bot]
f7159b6898
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (31-x-y) ( #44104 )
...
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (#44067 )
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 19:13:48 -05:00
trop[bot]
8e1e4541af
build: fix relative file read during npm publish ( #44090 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-10-01 17:19:43 -07:00
Samuel Attard
01e64d3932
build: cleanup release scripts, separate cli entrypoints from logic ( #44083 )
...
build: cleanup release scripts, separate cli entrypoints from logic (#44058 )
* build: cleanup release scripts, separate cli entrypoints from logic
* build: use repo/org constants
2024-10-01 14:08:20 -07:00
Samuel Attard
075a297347
build: ensure consistent usage of getRepo ( #44079 )
2024-10-01 13:27:02 -07:00
Samuel Attard
5bdaa42b01
build: update some build dependencies ( #44071 )
...
* build: update some build dependencies (#43882 )
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
* build: s/colors/chalk
* build: node 20 on windows
2024-10-01 13:14:08 -07:00
trop[bot]
9222396159
fix: ensure correct WebContents when checking PDFReadyToPrint (31-x-y) ( #44010 )
2024-10-01 18:32:31 +02:00
trop[bot]
a0802f7ce6
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (31-x-y) ( #44036 )
...
* fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (#44014 )
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
* chore: remove redundant static keyword on function in anonymous namespace
* refactor: slightly more explicit typing
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
* chore: remove unused #includes
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use string_view.rfind() instead of base::RSplitStringOnce()
base::RSplitStringOnce() does not exist in Chromium 128
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-01 12:17:16 -04:00
Samuel Attard
9ee51dbe92
build: convert all release scripts to typescript ( #44061 )
...
* build: convert all release scripts to typescript (#44035 )
* build: convert all release scripts to typescript
* fix test imports
* build: fix version bumper export
* refactor: use as const
* spec: fix bad type spec
* build: use ts-node to spawn the version-bumper (#44057 )
Missed this in the tsification, we should probably call this via API instead of spawning a sub-proc?
2024-10-01 08:49:36 -07:00
trop[bot]
0a4b0de4f7
fix: ensure SetPluginCanSave updated in PDFs ( #44020 )
...
fix: ensure SetPluginCanSave updated in PDFs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-30 14:52:14 +02:00
