mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
18407 commits 1 branch 183 tags 5.3 GiB
Commit graph

4719 commits

Author SHA1 Message Date
Aleksei Kuzmin
6c7ad3ac58 Remove the dependence on BrowserThread::FILE for 
https://codereview.chromium.org/2944313003
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
b29c485ec4 Consolidate PowerSaveBlocker and WakeLock inside Device Service. 
https://chromium-review.googlesource.com/c/chromium/src/+/563159
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
7608a0489c Network Traffic Annotation added to DownloadURLParams. 
https://chromium-review.googlesource.com/c/530307
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
e926473e5a Partial revert of Provide WebContents::CreateParams to tab helpers. 
https://chromium-review.googlesource.com/c/571285
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
9566904838 Speech recognition: Use BindOnce / OnceCallback / OnceClosure where applicable 
https://chromium-review.googlesource.com/c/565762
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
5831a5ffa1 Refactor client cert private key handling. 
https://codereview.chromium.org/2898573002
 2017-11-24 10:58:16 +09:00
Tony Ganch
f694b64d71 FIXME: DesktopNotificationDelegate has been removed 
Related CL: https://codereview.chromium.org/2906883003
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
2c063f93ff Remove raw base::DictionaryValue::Set 
https://codereview.chromium.org/2911033002
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
1127452429 PlzNavigate: make NavigationResourceHandler a LayeredResourceHandler 
https://codereview.chromium.org/2847443002
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
a72a08bccc Convert iOS to use X509CertificateBytes. 
https://codereview.chromium.org/2864133002
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ea8e113b19 SkBitmap and SkPixelRef no longer need lock/unlock 
https://codereview.chromium.org/2823003002
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ea4a36039a Add Keyboard Latency UMA Metrics. 
https://codereview.chromium.org/2756893002
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
f03ca53af5 Add blink::WebInputEvent::IsPinchGestureEventType(). 
https://codereview.chromium.org/2861373004
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
650902c656 Renamed LoadCommittedDetails.is_in_page to is_same_document. 
https://codereview.chromium.org/2841833002
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
90b0984a14 Add missing IWYU message_loop.h includes. 
https://codereview.chromium.org/2876013002
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
11fa935359 Introduce TaskRunner::RunsTasksInCurrentSequence() 
https://codereview.chromium.org/2823103003
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
f2bcdab037 Provide WebContents::CreateParams to tab helpers. 
https://codereview.chromium.org/2894973002
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
971002a197 Switch to using scoped_ptr with UserData 
https://codereview.chromium.org/2815913005
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ee9a547985 Service CreateNewWindow on the UI thread with a new mojo interface 
https://codereview.chromium.org/2821473002
 2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
ba6e8b4dff Merge ResourceRequestBodyImpl and ResourceRequestBody. 
https://codereview.chromium.org/2954343005
 2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
b77b67bfbe Remove client_certs from SSLCertRequestInfo. 
https://codereview.chromium.org/2838243002
 2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
ba2f33d629 Remove base::Value::GetAsBinary 
https://codereview.chromium.org/2839753005
 2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
58e0771e47 Remove base::Value::Get{Buffer,Size} 
https://codereview.chromium.org/2841623003
 2017-11-24 10:58:15 +09:00
Aleksei Kuzmin
132029ea32 Move components/display_compositor to components/viz/display_compositor 
https://codereview.chromium.org/2873243002
 2017-11-24 10:58:15 +09:00
Cheng Zhao
f8adaed763
Merge pull request #11208 from electron/mips64el 
Add support for mips64el
 2017-11-24 10:54:19 +09:00
Heilig Benedek
bb5eecc16c Use SizeConstraints instead of window events 2017-11-23 21:25:25 +01:00
Heilig Benedek
ca76dda6a6 remove incorrect checks 2017-11-23 21:25:25 +01:00
Heilig Benedek
7a7f1ee711 dont resize on taskbar resize if resizable is false 2017-11-23 21:25:25 +01:00
Felix Rieseberg
3cb062b3d6 🔧 BrowserView.getAllViews() 2017-11-22 16:58:32 -08:00
Cheng Zhao
4f9c5310a9 Fix compiler warning when building with gcc 2017-11-21 21:47:51 +09:00
Charles Kerr
dba9181611
Merge pull request #11164 from electron/nstitlebar-hidden 
fix: Explicitally set "setTitlebarAppearsTransparent"
 2017-11-21 07:51:47 +01:00
Cheng Zhao
cb98ed8674
Merge pull request #11176 from electron/proxy-crash-race 
Avoid proxy handler race condition crash
 2017-11-20 20:15:02 +09:00
Cheng Zhao
3cc8330998 Merge branch 'master' into ahmedmohamedali-master 2017-11-20 11:04:47 +09:00
Matt Crocker
efaf7a6b85 Avoid race condition where login handler webcontents becomes null 2017-11-19 14:08:11 -08:00
Zhuo Lu
367f7f123d Update icns 2017-11-19 00:33:33 -08:00
Felix Rieseberg
daad465fcd 🔧 Eh, let's do it for all the types 2017-11-18 20:19:22 -08:00
Felix Rieseberg
e3b6271806 🔧 setTitlebarAppearsTransparent=YES 2017-11-18 20:00:01 -08:00
Thiago de Arruda
a9a9e58b68 Fix random crash on app quit. 
Move AtomCTDelegate to brightray as RequireCTDelegate and transfer ownership to
brightray::URLRequestContextGetter. This fixes the wrong lifetime assumptions
that result in AtomCTDelegate being used after free in some scenarios.

Close #10051
 2017-11-17 12:03:23 -03:00
Ted Kim
8184cbfb06 Implement login helper to manage login item in Mac App Store build 2017-11-17 10:53:09 +09:00
Alexey Kuzmin
8657169017
Revert "Implement login helper to manage login item in Mac App Store build" 2017-11-16 19:05:13 +03:00
Charles Kerr
31172ecaa0
Merge pull request #11008 from electron/implement-stream-protocol 
Implement {register,intercept}StreamProtocol
 2017-11-14 09:31:57 -06:00
Cheng Zhao
4b8ab8fc97
Merge pull request #10856 from dittos/mas-login-helper 
Implement login helper to manage login item in Mac App Store build
 2017-11-14 21:34:50 +09:00
Thiago de Arruda
5ea3a5886b Implement {register,intecept}StreamProtocol 
These new functions are more flexible than the other
{intercept,register}*ProtocoProtocol functions, since it allows the user to
return a node.js stream to feed the data to the protocol handler.

It also allows the user to specify a response header dictionary, which makes it
possible to correctly intercept any request made from renderers.
 2017-11-13 16:16:14 -03:00
Thiago de Arruda
68f514b92f Implement EventSubscriber<T> class. 
This class simplifies the task of subscribing/handling javascript events from
C++ classes in the main process.
 2017-11-13 15:22:50 -03:00
Thiago de Arruda
6b666b69c0 Implement GetLoadTimingInfo in JsAsker class. 
This is required to avoid a crash in blink when implementing a custom protocol
handler that deals with redirects.
 2017-11-13 15:20:56 -03:00
Thiago de Arruda
6b2ddc4814 Stop allowing electron.net requests to be intercepted. 
Not very useful to intercept requests from `electron.net`, since both the
interception machinery and `electron.net` live in the browser process.
 2017-11-13 15:20:46 -03:00
Cheng Zhao
72440d4ae7 No need to add new methods to WebContentsPreferences 2017-11-13 17:35:49 +09:00
Cheng Zhao
cee1c459c7 Do not accidentally change the behavior of did-change-theme-color 2017-11-13 16:20:54 +09:00
Cheng Zhao
7e0593950c Code style fixes 2017-11-13 16:13:54 +09:00
Heilig Benedek
276e12ce71 pass on web_contents to properly handle devtools 2017-11-13 15:50:50 +09:00
Heilig Benedek
26daffea9c use smart pointer for paint_canvas 2017-11-13 15:50:49 +09:00
Heilig Benedek
4b10445c2e lint fix 2017-11-13 15:50:49 +09:00
Heilig Benedek
193beb57c9 fix datalist element popup position when menu is hidden 2017-11-13 15:50:49 +09:00
Heilig Benedek
f8b3009ebf restructure code to use web_preferences if possible 2017-11-13 15:50:49 +09:00
Heilig Benedek
71b36ef54d don't show the dummy window for the rest of the dialogs too on mac 2017-11-13 15:46:46 +09:00
Heilig Benedek
13b86598e8 don't show osr dummy window when dialog is shown on mac 2017-11-13 15:46:46 +09:00
Heilig Benedek
35dc6d03b9 lint fix 2017-11-13 15:46:46 +09:00
Heilig Benedek
e39aacb30e fix a bug that caused a crash when using an offscreen window with detached devtools, related to autofill popups 2017-11-13 15:46:46 +09:00
Samuel Attard
a06a8a6f79
Merge pull request #11056 from ajmacd/allow-browser-window-logs 
Allow BrowserWindows to emit `console-message` events.
 2017-11-11 14:34:39 +11:00
Ahmed
9b3960fe90
Merge branch 'master' into master 2017-11-08 18:03:55 +01:00
Samuel Attard
bb997c2ea4 Forward declare the scrubber layout 2017-11-08 16:48:08 +13:00
Andrew MacDonald
c260a0ab78 Allow BrowserWindows to emit console-message events. 2017-11-07 15:31:15 -08:00
Armagan Amcalar
edd113548a Make ScrubberItem width dynamic 
Depending on whether a ScrubberItem has text or an icon, this changeset
calculates the actual width and sizes the TouchBar items accordingly.
Previously, all ScrubberItems, regardless of their content, had a static
width of 50px.

This commit also fixes #10539.
 2017-11-07 00:09:14 +01:00
John Kleinschmidt
5383b4809f v1.8.2-beta.2 2017-11-06 16:11:34 -05:00
Charles Kerr
4ceeddc09f
Merge pull request #10972 from electron/dpi-issues 
Workaround for Windows DPI issues
 2017-11-02 10:16:11 -05:00
Felix Rieseberg
e8f8100e19 🔧 Add fixme 2017-11-01 11:30:32 -07:00
Felix Rieseberg
58708d6242 🔧 Lowercase 2017-10-31 10:31:05 -07:00
Felix Rieseberg
08b8f2df55
📝 Typo! 2017-10-31 08:38:33 -07:00
Felix Rieseberg
91414dde62 🔧 I can't believe this helps 2017-10-30 11:22:07 -07:00
Samuel Attard
c9926bed9f
Merge pull request #10954 from electron/less-process-metrics-warnings 
fix: Don't call idleWakeupsPerSecond on Windows
 2017-10-28 12:36:45 +13:00
Samuel Attard
dc8b583363
Merge pull request #10944 from electron/fix-notification-ref-crash 
Close the previous notification on multiple calls to show
 2017-10-28 12:33:30 +13:00
Felix Rieseberg
da21d6cdda 🔧 Don't call idleWakeupsPerSecond on Windows 2017-10-27 14:23:06 -07:00
Matt Crocker
b6fb016a9a Cleanup per review comment 2017-10-27 00:07:54 -07:00
Matt Crocker
77a26882a3 Make linter happy 2017-10-27 00:04:19 -07:00
Matt Crocker
c5914516c8 Upstream good ideas from Muon 2017-10-27 00:04:19 -07:00
Matt Crocker
ca8f45a501 Notifications should emit close on close, not eventual GC 2017-10-27 00:04:19 -07:00
Samuel Attard
8719e9f098 Definitely didn't forget to push the header file 2017-10-27 16:27:37 +13:00
Samuel Attard
fe9069c028 Close the previous notification on multiple calls to show 2017-10-27 16:22:21 +13:00
Paul Frazee
c2d9e082cb Fix crash in custom protocols caused by bad callback exec 2017-10-25 21:01:53 -05:00
John Kleinschmidt
67f0eb7b3b Merge pull request #10873 from ahmedmohamedali/fix_issue_10697 
Fixes #10697
 2017-10-23 09:32:28 -04:00
Ahmed Mohamed Ali
463260b249 Electron crashes if user clicks Dev Tools & Zoom options #10697 2017-10-21 22:21:24 +02:00
Ted Kim
4119da607f Implement login helper to manage login item in Mac App Store build 2017-10-20 11:44:19 +09:00
Ahmed Mohamed Ali
9f3cfa2dbd Fix crash that happens when the PDF viewer is refreshed. 
The root cause is the PdfViewerHandler instanceis destroyed but not removed from the list of observer in WebContentsZoomController
 2017-10-19 16:27:08 +02:00
John Kleinschmidt
90e7d7e112 v1.8.2-beta.1 2017-10-18 16:49:32 -04:00
Ahmed Mohamed Ali
05035eb1e3 Fix linefeeds 2017-10-18 17:36:56 +02:00
John Kleinschmidt
57537ea10e Merge pull request #10810 from qazbnm456/add_error_code_to_session_set_certificate_verify_proc 
Add error code to session.setCertificateVerifyProc
 2017-10-18 09:33:37 -04:00
John Kleinschmidt
cbda307ebf Merge pull request #10696 from primalmotion/patch-1 
🍎 skip tabbing category if macOS < Sierra
 2017-10-17 10:24:11 -04:00
Boik
f40cc5ab54 add error code to session.setCertificateVerifyProc 2017-10-16 17:17:21 +08:00
Ahmed Mohamed Ali
8763e8ee35 Fixing coding style 2017-10-14 11:17:52 +02:00
Ahmed Mohamed Ali
5030db000a Applying changes requested by @deepak1556 after the review: 
- Move RenderFrameHost methods in the UI thread
- Check GetAssociatedRenderFrame return value
 2017-10-14 11:09:05 +02:00
Ahmed Mohamed Ali
1ad95eca4a Add support for pdf in sub frames (https://github.com/electron/electron/issues/9192#issuecomment-335543866) 2017-10-13 19:56:20 +02:00
Birunthan Mohanathas
06d782279c Add systemPreferences.removeUserDefault() 
This can be used to restore the default or global value of a `key`
previously set with `setUserDefault`.
 2017-10-10 22:57:47 +03:00
Samuel Attard
d350134c4f Ensure that the touchbar's esape item can be set before setting it 2017-10-10 02:24:49 +11:00
Shelley Vohr
242e097e9b Merge pull request #10670 from electron/add-linuxdefaultprotocol 
add setAsDefaultProtocolClient for Linux
 2017-10-07 10:07:02 -05:00
Shelley Vohr
443c30890b
remove dummy check 2017-10-07 10:38:08 -04:00
Shelley Vohr
35eea8bea5
remove unused xdg setting 2017-10-07 00:38:25 -04:00
Shelley Vohr
66827755e7
remove chrome check and change protocol handler 2017-10-07 00:36:18 -04:00
Shelley Vohr
a1347f67a1
remove a space from a comment wow thanks linter 2017-10-06 23:40:58 -04:00
Shelley Vohr
c9da806c84
slight refactor and lin cleanup 2017-10-06 23:32:46 -04:00
Antoine
5e6b683cfb fixed: trying to fix the build 2017-10-05 15:57:27 -07:00
Antoine
8e1945f768 🍎 skip tabbing category if macOS < Sierra 
Previously, the macro was ensuring the` MAC_OS_X_VERSION_10_12` was not defined to decide to compile a `NSWindow` category back porting native tabs or not.

This patch ensures to compile the `NSWindow` category only if the min required version is lesser than 1012 (`MAC_OS_X_VERSION_10_12`)
 2017-10-05 14:11:58 -07:00
Shelley Vohr
f8f21815eb
syntax updates and pointer conversion 2017-10-05 00:30:14 -04:00
Cheng Zhao
bb71b09452 Fix building on Windows 2017-10-05 11:51:41 +09:00
Cheng Zhao
4342480473 Fix cpplint warnings 2017-10-05 11:49:26 +09:00
Sean Bannigan
0b205019b6 add mouse-move event and click event position for tray 2017-10-05 11:41:08 +09:00
Cheng Zhao
8c5bb5969c Merge pull request #10667 from dittos/window-opacity 
Add window opacity support
 2017-10-04 15:03:45 +09:00
Felix Rieseberg
4e05d24d1b Merge pull request #10661 from electron/browserview-multiple-screens 
BrowserView: Allow dragging of window to screen above menubar
 2017-10-03 16:09:11 -07:00
Shelley Vohr
6131a523dc
add xdg helper method 2017-10-03 11:10:38 -04:00
Cheng Zhao
150a4797a4 Merge pull request #10676 from qazbnm456/fix-unhandle-null-pointer 
Add a null-pointer check before processing base::SupportsUserData::GetUserData
 2017-10-03 20:18:51 +09:00
Daniel Ma
1bb042a661 feat(NativeWindowMac): addTabbedWindow 
Add support for the [`NSWindow addTabbedWindow`][nsw] method on MacOSX

This plays nicely with the changes from #9052 and #9725

Usage samples available in [this commit][c] in my fork of
`electron-quick-start`

[nsw]: https://developer.apple.com/documentation/appkit/nswindow/1855947-addtabbedwindow
[c]: 79f06591df
 2017-10-03 20:11:16 +09:00
Boik
d594092675 add a null-pointer check before processing base::SupportsUserData::GetUserData 2017-10-03 12:42:35 +08:00
Taeho Kim
7570ec9d39 Add BrowserWindow.getOpacity for consistency 2017-10-03 00:08:10 +09:00
Shelley Vohr
3f73e000ee
first pass at adding linux setAsDefaultProtocolClient 2017-10-02 10:21:30 -04:00
Taeho Kim
7df5182901 Fix lint 2017-10-02 09:52:27 +09:00
Felix Rieseberg
0cc1ebc021 🔧 Allow dragging window to screen above menubar (for real) 2017-09-29 14:20:34 -04:00
Zeke Sikelianos
9f895879bf Merge pull request #10191 from electron/add_log_path_support 
add ability to access logs in getPath()
 2017-09-29 11:11:29 -07:00
Ted Kim
7f2c4a9e06 Add window opacity support 2017-09-29 17:49:10 +09:00
Shelley Vohr
5ef4caf8ab
add ability to access logs in getPath() 2017-09-28 13:35:22 -04:00
John Kleinschmidt
7788b33dc9 Bump v1.8.1 2017-09-28 13:13:49 -04:00
Felix Rieseberg
89246f3714 🔧 Allow dragging over menubar 2017-09-27 17:43:09 -04:00
Birunthan Mohanathas
044a3a29a6 Simplify checking for NSFullScreenWindowMask 2017-09-27 16:36:18 +03:00
Felix Rieseberg
d45788a7b8 🔧 Don't drag fullscreen window 2017-09-26 18:03:44 -04:00
Birunthan Mohanathas
e1ddd3bdbc Stop sending resize event for minimized windows on Windows 
This makes it consistent with macOS.

This also fixes BrowserView auto-resize on Windows when minimizing and
restoring the window. Previously it would incorrectly grow too in some
cases.
 2017-09-25 11:44:32 +09:00
Birunthan Mohanathas
f3f6bedf8e Make BrowserView auto-resize relative to window size on Windows/Linux 
Previously it was relative to the window web contents size, which was
not consistent with macOS.
 2017-09-25 11:44:32 +09:00
Cheng Zhao
b7119b5756 Create watcher when message loop is ready 2017-09-20 11:58:32 +09:00
Samuel Attard
4147fa4629 Appease the linting gods 2017-09-20 11:58:32 +09:00
Samuel Attard
0ab83b301d Refactor as per @zcbenz comments 
Also fix issue where we run the single instance callback *not* on the UI thread,
this apparently results in a hung process.
 2017-09-20 11:58:32 +09:00
Samuel Attard
ecbeb0d117 Woops, how did that happen ;) 2017-09-20 11:58:32 +09:00
Samuel Attard
f928a399ae Move OnBrowserReady call to PreMainMessageLoopRun to account for timing issues on macOS 2017-09-20 11:58:32 +09:00
Samuel Attard
28900a9b63 Fix app.makeSingleInstance hanging on posix systems 
Wait for the IO thread to be a thing before attempting to listen on the socket

Fixes #9880
 2017-09-20 11:58:32 +09:00
Cheng Zhao
ff023115f5 Style fixes 2017-09-14 16:12:34 +09:00
Rafael Nobre
77a1c5d7fc Avoids deadlock in case NSUserActivityDelegate method start being called from main thread. 2017-09-14 15:59:43 +09:00
Rafael Nobre
9483f0fc14 Adds synchronization logic to allow NSUserActivityDelegate to wait Javascript updating the NSUserActiity UserInfo if requested. 2017-09-14 15:59:43 +09:00
Rafael Nobre
c23b4a48ec Fixes NSUserActivityDelegate that was called on a background thread thus not working. 2017-09-14 15:59:43 +09:00
Rafael Nobre
76efee675f Requests updated user info data before each Handoff operation. 2017-09-14 15:59:43 +09:00
Rafael Nobre
a870799c32 Exposes more Handoff related APIs to Electron. 2017-09-14 15:59:43 +09:00
Cheng Zhao
19a7c7ac39 Styling fixes 2017-09-14 14:43:22 +09:00
xaviergonz
e18cdc185a add the fix for showinactive 2017-09-14 14:35:53 +09:00
xaviergonz
d0c91daaed make sure setparentwindow only shows the window if already visible 2017-09-14 14:35:53 +09:00
xaviergonz
dc7cc6921e fix for mac child windows so they honor show option 2017-09-14 14:35:53 +09:00
xaviergonz
dae63d323c add new internal set parent window method 2017-09-14 14:33:24 +09:00
Cheng Zhao
a19a229a59 Merge pull request #10254 from zachflower/feature/simple-fullscreen-mode 
Feature/simple fullscreen mode
 2017-09-14 09:39:50 +09:00
Zachary Flower
432b912c6a 🎨 Rename ambiguous simple_fullscreen_ variable to always_simple_fullscreen_ 2017-09-13 12:16:37 -06:00
Cheng Zhao
2048a1a638 Merge pull request #10429 from qazbnm456/web-request-origin 
Track the origin of webRequest events
 2017-09-13 22:23:44 +09:00
Cheng Zhao
c34fb146f6 Fix styling 2017-09-13 21:40:29 +09:00
Vanessa Yuen
9a7d8a0511 merge master into fix-fullscreen-with-resizable-flag. 2017-09-12 18:34:23 -04:00
Zachary Flower
fa4d52f042 🎨 Track/restore original stylemask, rather than individual states. 2017-09-12 12:27:30 -06:00
Boik
e66341ec59 add back the missing 'resourceType' property 2017-09-12 21:27:49 +08:00
Boik
a01abd0fee fix lint-cpp 2017-09-12 20:28:30 +08:00
Boik
2d771674bb get webContentsId instead 2017-09-12 20:17:11 +08:00
Boik
13d363d1f1 fix lint-cpp 2017-09-12 15:40:35 +08:00
Boik
549c30f9b2 first attempt to track the origin requesters of webRequest events 2017-09-12 15:40:35 +08:00
Cheng Zhao
59cadf9e4b Merge pull request #10366 from syohex/window-close-order 
Close window in order from newer one on macOS
 2017-09-12 16:22:38 +09:00
Cheng Zhao
bca71fcfc1 Merge pull request #10393 from j3l11234/fix_mac_crack 
fix mac ime crack
 2017-09-12 16:19:08 +09:00
Cheng Zhao
8493d5707e Fix cpplint warnings 2017-09-12 15:35:24 +09:00
Cheng Zhao
10ab870237 Merge pull request #10321 from kaylanm/macos-native-tab-api 
🍎 Add macOS native tab methods to window API
 2017-09-11 18:49:56 +09:00
Cheng Zhao
cc9771a3d0 Merge pull request #10307 from liusy182/10240-theme-color-2 
return null when theme color is transparent or not found
 2017-09-11 18:40:35 +09:00
Cheng Zhao
e6733b4b23 Merge pull request #10305 from ivmirx/macos-accessibility 
Special attribute for macOS accessibility
 2017-09-11 17:58:20 +09:00
Cheng Zhao
0694334487 Merge pull request #10271 from kaylanm/macos-native-tab-menu-items 
🍎 Add roles for macOS native tab menu items
 2017-09-11 17:41:31 +09:00
Birunthan Mohanathas
511e82de67 Fix missing extension when saving a file without filters 
Previously, when triggering the save dialog through e.g. `<a download>`
links (e.g. http://jsfiddle.net/koldev/cW7W5/), the extension was only
saved if Finder was set to show all extensions by default. We now always
display the extension to make sure that it is saved.

If we want to keep the extension hidden, we could also populate the
allowed file types array with the extension from the default filename,
but that would have interfered with how we set the filters.
 2017-09-07 16:48:14 -07:00
John Kleinschmidt
4b1e2b42a4 Bump v1.8.0 2017-08-31 16:16:19 -04:00
Samuel Attard
6b010614e2 Implement moveToApplicationsFolder (#10142) 
* Implement moveToApplicationsFolder

* Fix tabs / spaces

* Fix linting

* Use Browser::Quit, instead of exit

* Update documentation as per feedback

* Fix spec
 2017-08-31 10:37:12 -04:00
allenliu
5978775ce1 fix mac ime crack 2017-08-30 12:07:04 +08:00
Cheng Zhao
0550a4a9b8 Fix crash when emitting render-view-deleted event 2017-08-29 17:46:46 +09:00
Cheng Zhao
4febbec102 Fix crash when switching menus in menubar 2017-08-29 14:19:23 +09:00
Shohei YOSHIDA
55f2b524e7 Close window in order from newer one on macOS 
A parent window is not closed if a child modal window still exists.
So a child window should be closed before parent window closed.
 2017-08-28 13:56:05 +09:00
Ivan Mir
75b2915fee Change the parameter name for consistency 2017-08-27 11:53:25 -03:00
Ivan Mir
6717f0d2bb Add accessibility setter to the app 2017-08-24 11:22:28 -03:00
Samuel Attard
7ecac42214 Merge pull request #10232 from electron/drag-browser-view 
Add -webkit-app-region support to BrowserView
 2017-08-24 10:30:56 +10:00
Felix Rieseberg
fdfbf3abfa 🔧 Respect the header 2017-08-23 17:26:18 -07:00
Felix Rieseberg
a44c2d5dcc 🔧 Extend interface 2017-08-23 16:10:31 -07:00
Siyuan Liu
5cb58cd42f use nullptr instead of nullptr_t() 2017-08-23 09:30:58 +08:00
Felix Rieseberg
cd5cd25f74 🔪 Bonus colon 2017-08-22 11:14:21 -07:00
Michael Kaylan
b4428e7e41 🍎 Add macOS native tab methods to window API 2017-08-21 23:24:30 -04:00
Cheng Zhao
565ece6986 Merge pull request #10308 from electron/native-view 
Add WebContents.getNativeView() API
 2017-08-22 09:19:27 +09:00
Felix Rieseberg
f0680587fa 🔧 Linter fascism 2017-08-21 16:52:59 -07:00
Charlie Hess
f17bd040ad Merge pull request #10293 from electron/notification-sounds 
Add support for soundName in main process notifications
 2017-08-21 16:15:47 -07:00
Charlie Hess
db081d95d5
Review CommentZ. 2017-08-21 13:53:50 -07:00
Cheng Zhao
2c1984b6ed Add WebContents.getNativeView API 2017-08-21 19:50:12 +09:00
Cheng Zhao
70fd42808e Fix build on Linux 2017-08-21 17:42:45 +09:00
Cheng Zhao
19323c88f9 win: Fix "thickFrame: false" not working for normal window 2017-08-21 17:21:59 +09:00
Siyuan Liu
eeb2e58ad8 return null when theme color is not found 2017-08-20 22:48:13 +08:00
Ivan Mir
94dd068e15 Special attribute for macOS accessibility #7206 
In the linked issue we were discussing that Electron apps are inaccessible unless VoiceOver is enabled. While it's a working solution for users with vision impairment, all other users and apps that require accessibility can't interact with Electron-based software because they don't keep VoiceOver running.

I suggest adding `AXManualAccessibility` for programmatically enabling it in Electron apps. The reason for a new attribute is that `AXEnhancedUserInterface` is already reserved by VoiceOver.

Adding this attribute will allow both Electron developers and 3rd party developers to enable and disable accessibility from their code by calling `accessibilitySetValue:forAttribute:` on the application.

It will be also possible to create a small utility app to switch accessibility in Electron-based apps until there's a native UI solution (like the accessibility settings page in Chrome).
 2017-08-19 17:18:12 -03:00
Charlie Hess
2b9b186fd1
Rename soundName → sound. 2017-08-17 17:28:14 -07:00
Charlie Hess
0cfae1cc2b
Plumb in the macOS soundName property for notifications. 2017-08-17 13:31:20 -07:00
Cheng Zhao
9c552644d8 Fix compilation on mac 2017-08-17 16:47:12 +09:00
Cheng Zhao
ecff620528 Merge pull request #10081 from renaesop/master 
Add a callback option to `webContents.print`
 2017-08-17 15:56:02 +09:00
Cheng Zhao
f908678e8e Merge pull request #10183 from andens/mouse_forward 
Mouse forward functionality on Windows
 2017-08-17 15:54:22 +09:00
Andreas Flöjt
d4bbd7c7ab Add example of using mouse forwarding. 2017-08-16 03:28:52 +02:00
Andreas Flöjt
814702f5b8 Cleanup potential mouse forwarding resources when window is destroyed. 2017-08-16 03:28:07 +02:00
Felix Rieseberg
6191e6e787 🔧 Implement feedback 2017-08-15 16:14:58 -07:00
Michael Kaylan
7741a0e6ad 🍎 Add roles for macOS native tab menu items 
Fixes #9086, #10064.
 2017-08-15 11:30:39 -04:00
Catalin Fratila
60b363fa3b Fixing Windows tray icon content menu - based on chrome/browser/ui/views/status_icons/status_icon_win.cc 2017-08-15 16:19:23 +03:00
Kevin Sawicki
9d2aa6f1c7 Upgrade to node 8.2.0 2017-08-15 16:19:23 +03:00
Ales Pergl
9f8f95f4c9 Lock pixels before calling SkBitmap::getPixels and copy bitmap row-wise in case (stride != width) 2017-08-15 16:19:23 +03:00
Gellert Hegyi
6ab0a8a287 removes unused autoresizelock from osrrwhv 2017-08-15 16:19:22 +03:00
Gellert Hegyi
1d10654a22 fixes bitmap to canvas conversion 2017-08-15 16:19:22 +03:00
Gellert Hegyi
76d46ce509 adds compositor resize lock client implementation 2017-08-15 16:19:22 +03:00
Gellert Hegyi
ca4a6e4692 fixes offscreen rendering on macos 2017-08-15 16:19:22 +03:00
Kevin Sawicki
9945fc5148 Don't destroy menu delegate until OnMenuClosed fires 2017-08-15 16:19:21 +03:00
Kevin Sawicki
34fff57646 Grant the devtools access to the extension origins 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
4fc2b3e642 Make download item drags look like bookmark 
https://codereview.chromium.org/2750253002
 2017-08-15 16:19:21 +03:00
Kevin Sawicki
4bb95acc2b 👕 Remove linter errors 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
627eb30409 The Blink Rename 2017-08-15 16:19:21 +03:00
Tony Ganch
4d9f309888 Fix HasServiceWorker check 
Revert cb2014f9e8ae0283e5f20d4e2167be1592228887.
 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
e16e1e2854 Remove URLRequestJobFactory::IsHandledURL. 
https://codereview.chromium.org/2783343002
 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
b997c2ffc1 Don't call deprecated copyPixelsTo 
don't call deprecated copyPixelsTo
https://codereview.chromium.org/2812853002

stop using copyPixelsTo -- deprecated
https://codereview.chromium.org/2798413002

remove unused SkBitmap::copyPixelsTo
https://skia-review.googlesource.com/c/13171/
 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
f824b1e9d4 Migrate base::TaskRunner from Closure to OnceClosure 
Migrate base::TaskRunner from Closure to OnceClosure
https://codereview.chromium.org/2637843002

Pass Callback to TaskRunner by value and consume it on invocation (1)
https://codereview.chromium.org/2726523002

Replace base::get with std::get
https://codereview.chromium.org/2797133002
 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
48821a6d2a Fix compilation 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
d09cab2e21 Migrate base::TaskRunner from Closure to OnceClosure 
Migrate base::TaskRunner from Closure to OnceClosure
https://codereview.chromium.org/2637843002

Pass Callback to TaskRunner by value and consume it on invocation (1)
https://codereview.chromium.org/2726523002

Replace base::get with std::get
https://codereview.chromium.org/2797133002
 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
ffbb16e854 Adds a basic offline check to InstallableManager. 
https://codereview.chromium.org/2751343002
 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
30fafc2772 Fix CompositorResizeLock to do something. 
https://codereview.chromium.org/2773433003
 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
9b8a77f0d8 Adds the ability for WebContentsDelegate to decide if event should be updated 
https://codereview.chromium.org/2775553002
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
d322769de8 WebMouseEvent coordinates are now fractional & private 
https://codereview.chromium.org/2782893002
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
99e57f9072 Add display::GetDisplayNearestView 
https://codereview.chromium.org/2751833004
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
6415f181ca Downloads: Added transient flag to download item and download database 
https://codereview.chromium.org/2720613002
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
bd971b6371 Added last_access_time to DownloadItem and History DB 
https://codereview.chromium.org/2705283003
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
0adc887b32 [downloads] Allow download target determination to indicate an error. 
https://chromium-review.googlesource.com/c/465526/
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
bda5e4efcb Moving LatencyInfo into a separate component. 
https://codereview.chromium.org/2783973002
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
cc350efbd8 Remove base::BinaryValue 
https://codereview.chromium.org/2799093006
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
49fbb52b01 Add X509CertificateBytes which uses CRYPTO_BUFFER instead of macOS-native certificate types. 
https://codereview.chromium.org/2746103003
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
3d700ee49f Remove base::Value::CreateNullValue 
https://codereview.chromium.org/2792573002
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
c7f2e2731c Allow content embedder to set a cursor for RenderWidgetHost 
https://codereview.chromium.org/2808763009
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
a20f633272 Remove base::StringValue 
https://codereview.chromium.org/2664753002
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
7a4ca08a8d The Blink Rename 2017-08-15 16:19:20 +03:00
renaesop
6d16eb81d2 Add a callback option to webContents.print 2017-08-15 14:44:24 +08:00
Andreas Flöjt
3d33da7696 Make mouse forward option of setIgnoreMouseMessages and update documentation. 2017-08-14 20:21:00 +02:00
Andreas Flöjt
60c0bf1636 Set up legacy window subclass and mouse hook during setForwardMouseMessages. 
As opposed to when a legacy window is created/destroyed. This enables forwarding on a per-window basis.
 2017-08-14 18:12:55 +02:00
Zachary Flower
ba5fa2c8b1 Add support for simple (pre-Lion) fullscreen on Mac OS 2017-08-13 00:28:33 -06:00
Felix Rieseberg
b4bb00843b 🔧 Spaces for the Spacelord 2017-08-10 09:38:01 -07:00
Felix Rieseberg
d913b53fea 🔧 Handle offset BrowserView 2017-08-10 08:00:21 -07:00
Felix Rieseberg
47d652b5a2 🔧 Properly derive 2017-08-09 15:21:58 -07:00
Felix Rieseberg
7bfece1144 🔧 Make work with complex shapes 2017-08-09 15:21:58 -07:00
Felix Rieseberg
a55015d63d 🔧 Support older versions of macOS 2017-08-09 15:21:58 -07:00
Felix Rieseberg
a5dfb09037 🔧 Draggable (using the window’s regions) 2017-08-09 15:21:58 -07:00
Vanessa Yuen
b81aab9eae Bump v1.7.6 2017-08-09 15:28:55 -04:00
Cheng Zhao
eeca6fcb55 Revert "Fix window.opener being null when nativeWindowOpen is used" 2017-08-07 19:50:23 +09:00
Cheng Zhao
63d7aee1a6 Merge pull request #9961 from electron/fix-window-opener 
Fix window.opener being null when nativeWindowOpen is used
 2017-08-04 21:18:47 +09:00
Andreas Flöjt
0736de1e8d Fix lint errors 2017-08-03 23:23:42 +02:00
Andreas Flöjt
a84fa0eecb 🏁 Add API to forward mouse messages. 
As opposed to the existing setIgnoreMouseEvents this call makes Chromium aware of mouse movements, allowing the user to stop forwarding according to movements in the webpage.
 2017-08-02 21:16:37 +02:00
Cheng Zhao
4e2cb549c7 Notify net error asyncronously 
Notifying net error syncronously would result in crash.
 2017-08-02 11:14:06 +09:00
Cheng Zhao
a7035b08d5 Merge pull request #10070 from electron/fix-dbus-menu 
Only update dbus menu when it has been changed
 2017-07-31 10:42:08 +09:00
Samuel Attard
bd99bcbf64 Fix typo in comment 2017-07-31 11:00:00 +10:00
Samuel Attard
32327b77a5 Remove unneeded check but document why it is not there now 2017-07-31 10:47:25 +10:00
Samuel Attard
3ac2f674bc
Fix nativeWindowOpen's opener being null 2017-07-29 19:21:28 +10:00
Birunthan Mohanathas
20ae611dd9 Merge pull request #10097 from liusy182/liusy182-browserview 
#10039 add BrowserView.fromId
 2017-07-28 01:27:47 +03:00
Samuel Attard
f385e19594 Indenting stuff 2017-07-27 11:54:06 +10:00
Shelley Vohr
ed717a9b45 revert accidental overbeautification 2017-07-26 18:41:25 -07:00
Shelley Vohr
24ab5075e7 appease the linter 2017-07-26 18:29:10 -07:00
Shelley Vohr
919d7fa22e Add header declarations in auto_updater 2017-07-26 18:10:09 -07:00
Shelley Vohr
8cf00fece6 add onError with three params and move to atom-auto-updater 2017-07-26 17:33:32 -07:00
Shelley Vohr
1cfd20f861 prefix autoupdater error with statuscode and domain 2017-07-26 14:18:53 -07:00
Siyuan Liu
ae7c1ae741 #10039 add BrowserView.fromId 2017-07-24 11:32:30 +08:00
Cheng Zhao
edc2dae496 Make the status string shorter 2017-07-20 22:45:06 +09:00
Cheng Zhao
74df5f84fd Only update dbus menu when it has been changed 
The dbus menu implementaion of KDE would send the about-to-show signal
whenever the menu has been changed, resulting in infinite loop on our
side.
 2017-07-20 20:50:14 +09:00
Cheng Zhao
52c6c7e676 Merge pull request #9819 from ferreus/dev/vladimir_fix9231 
🐛 Fix #9231: Don't load url when detached.
 2017-07-19 11:15:30 +09:00
Kevin Sawicki
959231f766 Merge pull request #9834 from shubham2892/input-type-file-treating-packaged-app-as-directory 
Fix treat packaged app as directory
 2017-07-18 10:21:07 -07:00
Shubham
b25a1d10a2 🍎 Add treatPackageasDirectory as an option 2017-07-18 10:13:25 -07:00
Kevin Sawicki
1d9f69e742 Merge pull request #10008 from qazbnm456/fix-pdf-viewer 
Fix a query string parsing problem happend to PDF Viewer
 2017-07-18 09:10:55 -07:00
Kevin Sawicki
2bac358064 Merge pull request #10015 from electron/input-dialog-filter-titles 
Add filter descriptions for common accept types
 2017-07-18 09:10:11 -07:00
Kevin Sawicki
5b9d31d3ff Bump v1.7.5 2017-07-17 12:45:30 -07:00
Kevin Sawicki
fdb1fddc26 Only reset preferences when conversion succeeds 2017-07-17 11:55:16 -07:00
Kevin Sawicki
06e60e5d4d Map pending process id to webContents for frame host initiating navigation 2017-07-17 11:55:15 -07:00
Kevin Sawicki
34c5abfe43 Update web preferences when creating with existing webContents 2017-07-17 11:55:15 -07:00
Kevin Sawicki
25e1ed97b5 Use constants from content_switches.h 2017-07-17 11:55:15 -07:00
Vladimir Vainer
e0518444da Minor changes to match style, init variables 2017-07-17 16:52:02 +03:00
Cheng Zhao
a43553aa25 Merge pull request #9962 from ferreus/dev/vladimir_fix_8768 
Fix #8768: Show() on already open modal
 2017-07-17 10:49:18 +03:00
Boik
4fb1fffe44 fix lint 2017-07-15 10:57:16 +08:00
Boik
8d6ee5aad2 add some minor fixes 2017-07-15 10:34:25 +08:00
Kevin Sawicki
5581d1d652 Merge pull request #9788 from shubham2892/Add-option-to-show-title-text-in-titlebar-in-fullscreen 
Add alwaysShowTitleTextInFullscreen flag
 2017-07-14 11:58:12 -07:00
Kevin Sawicki
c4ffb91190 🎨 2017-07-14 11:49:40 -07:00
Kevin Sawicki
9102c07ec7 always_show_title_text_in_full_screen -> fullscreen_window_title 2017-07-14 11:48:10 -07:00
Kevin Sawicki
c4956132d2 Add filter descriptions for common accept types 2017-07-14 11:04:06 -07:00
Kevin Sawicki
720755e124 Merge pull request #9745 from yuya-oc/input-allow-all-files 
Add 'All Files (*.*)' filter for <input> file dialog
 2017-07-14 10:41:11 -07:00
Kevin Sawicki
0a71a9b992 Merge pull request #9695 from shubham2892/alwaysOnTop-window-disappears-when-restored-fix 
Fix an issue where alwaysOnTop window disappears when restore…
 2017-07-14 10:09:13 -07:00
Kevin Sawicki
4935e8567f Initialize level_ in initWithShell 2017-07-14 10:07:06 -07:00
Boik
9a7651a93f fix a pdf-viewer's parsing logic, and this should resolve the related issue at https://github.com/electron/electron/issues/10007 2017-07-14 12:09:14 +08:00
Birunthan Mohanathas
812b529881 Add app.disableDomainBlockingFor3DAPIs() 
By default, Chromium disables 3D APIs (e.g. WebGL) until restart on a
per domain basis if the GPU processes crashes too frequently. This
function disables that behaviour.
 2017-07-14 01:41:43 +03:00
Vladimir Vainer
42cb3461af 🐛 Fix #9231: Don't load url when detached. 2017-07-09 06:54:22 +03:00
Vladimir Vainer
06b5acdac0 Fix #8768: Show() on already open modal 
Calling show() on an already open modal causes the parent to become unusable
 2017-07-09 06:49:12 +03:00
Milan Burda
d5df114bb4 🎨 Make Notification getters const methods 2017-06-30 16:54:31 +02:00
Milan Burda
a196bf97bc 🍎 Add subtitle to Notification properties 2017-06-30 16:54:28 +02:00
Kevin Sawicki
1c1cf0d1f2 Merge pull request #9857 from alexeykuzmin/add-enable-osr-flag 
[WIP] Add enable_osr flag
 2017-06-29 12:30:44 -07:00
Kevin Sawicki
4a7eb5077e Bump v1.7.4 2017-06-28 14:37:04 -07:00
Kevin Sawicki
0f83180377 Merge pull request #9837 from electron/notification-actions 
Notification actions
 2017-06-28 12:59:10 -07:00
Kevin Sawicki
06a550b412 Autorelease tracking area 2017-06-28 12:37:31 -07:00
Kevin Sawicki
e44f655503 Merge pull request #9760 from shubham2892/Add-mouse-enter-and-mouse-exit-event-for-Tray 
Add mouse-enter and mouse-exit events for tray
 2017-06-28 12:15:32 -07:00
Kevin Sawicki
d53f07cc20 🎨 2017-06-28 12:13:12 -07:00
Kevin Sawicki
70544440f9 Add location and keyboard modifiers to tray mouse events 2017-06-28 12:10:24 -07:00
Kevin Sawicki
2406d6c279 Rename to mouse-leave for consistency with drag-leave 2017-06-28 11:40:21 -07:00
Kevin Sawicki
4958771b8a Merge pull request #9852 from electron/webcontents-ignorekeyboardshortcuts 
Add webContents.setIgnoreMenuShortcuts()
 2017-06-28 10:35:02 -07:00
Kevin Sawicki
2cd49f3036 Merge pull request #9644 from electron/webview-sandbox 
Enable sandbox on webview
 2017-06-28 10:10:25 -07:00
Aleksei Kuzmin
da36bdfcc4 Add enable_osr build flag 2017-06-28 18:58:52 +02:00
Kevin Sawicki
628744f9e1 Put enableMixedSandbox before deprecation TODO 2017-06-28 08:37:56 -07:00
Kevin Sawicki
7fcc00f137 Add spec for app.enableMixedSandbox() 2017-06-28 08:33:11 -07:00
Samuel Attard
3774482859 Update notification PR as per feedback 2017-06-28 17:00:19 +10:00
Hari Juturu
1258240067 fixing build error 2017-06-26 16:20:12 -07:00
Hari Krishna Reddy Juturu
74196b96a1 Adding enableMixedSandbox api 2017-06-26 14:13:41 -07:00
Birunthan Mohanathas
f20f87829b Add webContents.setIgnoreMenuShortcuts() 
This allows you to disable application menu shortcut handling on a per
web contents basis.
 2017-06-26 14:01:17 -07:00
Shubham
a38f0f5f46 rename alwaysShowTitleTextInFullscreen to fullscreenWindowTitle 2017-06-26 16:58:45 -04:00
Kevin Sawicki
bda21216e7 Merge pull request #9743 from electron/number-accelerator-modifier 
Don't mutate the accelerator character with the shift key if it's a number
 2017-06-26 11:20:52 -07:00
Kevin Sawicki
4c8592b8ef Merge pull request #9828 from electron/fix-browserview-file-chooser-crash 
Fix crash when using file chooser in BrowserView
 2017-06-26 09:54:31 -07:00
Cheng Zhao
00d023cd71 Merge pull request #9725 from danielma/dma/native-tab-new-button 
Add "New Tab" button for Native macOS Tabs
 2017-06-26 15:07:10 +09:00
Samuel Attard
7eb14243eb Refactor notification options 2017-06-24 21:39:06 +10:00
Samuel Attard
17e737eba2 s/label/text 2017-06-23 21:04:39 +10:00
Samuel Attard
4f0d48f164 Add support for notification actions on macOS 2017-06-23 20:50:20 +10:00
Shubham
80e35b6682 🍎 Fix treat packaged app as directory 2017-06-22 17:10:22 -04:00
Birunthan Mohanathas
eb19562316 Fix crash when using file chooser in BrowserView 
The crash was a segfault caused by a null `WebDialogHelper::window_`.
 2017-06-21 16:26:38 -07:00
Shubham
1b8963ff6e 🍎 Fix full screen when resizable is set to true 2017-06-20 16:11:28 -04:00
Tony Ganch
471f6e0fa5 Fix invisible titlebar on macOS 10.13 2017-06-19 14:34:37 +02:00
Shubham
25c651c40a add alwaysShowTitleTextInFullscreen flag 2017-06-17 20:45:29 -04:00
Samuel Attard
231d4f7581 Use the isdigit helper 2017-06-17 03:52:19 +10:00
Shubham
12b90a2304 🐛 store current level fix 2017-06-15 18:05:58 -04:00
Kevin Sawicki
e8911fe48c Merge pull request #9610 from shubham2892/incorrect-file-extension-with-showSaveDialog-fix 
Fix incorrect extension when filters is used
 2017-06-15 10:29:11 -07:00
Kevin Sawicki
15dd0eb583 Add braces to if statement 2017-06-15 10:27:34 -07:00
Shubham
8dbb8ccbab add mouse-enter and mouse-exit events for tray 2017-06-14 18:00:29 -04:00
Kevin Sawicki
dae27de504 Merge pull request #9588 from electron/poiru/dialog-default-file-name 
Use last selected directory when using default file name in dialog.showSaveDialog()
 2017-06-14 14:41:45 -07:00
Kevin Sawicki
45dc6fc04f Merge pull request #9645 from dharders/issue6036-fix-windows-fullscreen-startup-toggle 
Fix unresponsive app after fullscreen->normal state toggle (Windows)
 2017-06-14 14:10:00 -07:00
Cheng Zhao
fd0a742683 Merge pull request #9700 from brenca/pdf-zoom-improvements 
Zoom controller improvements
 2017-06-14 19:15:28 +09:00
Hari Juturu
421bf71b98 Adding no-sandbox to non sandbox webcontents 2017-06-13 18:45:24 -07:00
dharders
112f4656c3 👕 fix lint warning 2017-06-14 11:30:33 +10:00
dharders
265ab45bd7 🎨 Reuse existing function 2017-06-14 11:05:39 +10:00
Heilig Benedek
a3ec28ddf3 remove unused includes 2017-06-14 00:49:11 +02:00
Yuya Ochiai
be9463b7b7 Add 'All Files (*.*)' filter for <input> file dialog 
The dialog would filter files as well as Chrome.
 2017-06-13 22:33:06 +09:00
Samuel Attard
29dbb93f16 Don't mutate the accelerator character wuth the shift key if it's a number 2017-06-13 20:29:54 +10:00
deepak1556
538b97582a app: add support for inspect/inspect-brk in forked node process 2017-06-13 00:23:11 +05:30
Daniel Ma
4fb9f825b1 Add "New Tab" button for Native macOS Tabs 
Adds responders for `newWindowForTab` to `AtomApplicationDelegate` and
`NativeWindowMac`, so that `BrowserWindow`s with a `tabbingIdentifier`
will get the new tab button, and both `app` and `window` will emit a
`new-tab-for-window` event.
 2017-06-11 02:26:26 -07:00
Hari Juturu
cbbd4a4a3b Indentation 2017-06-08 23:31:58 -07:00
Hari Juturu
07f550a748 enable-mixed-sandbox option 2017-06-08 23:29:35 -07:00
Kevin Sawicki
4c00176599 Bump v1.7.3 2017-06-08 10:43:50 -07:00
Heilig Benedek
f8d3b363ea 🎨 lint fix 2017-06-08 09:57:24 +02:00
Heilig Benedek
0f4341da42 add zoom behaviour code from chromium and make pdf viewer use manual zoom behaviour to match chromium 2017-06-08 02:15:17 +02:00
Heilig Benedek
a47fe715d1 pass ref part of url to allow #page= for pdf viewer 2017-06-08 02:15:17 +02:00
Shubham
373decd07e 🎨 2017-06-07 19:01:06 -04:00
Shubham
f001377493 🍎 Fix an issue where alwaysOnTop window disappears when restored from the application icon 2017-06-07 12:28:50 -04:00
Kevin Sawicki
7a3a092c72 Merge pull request #9687 from electron/fix-custom-window-button-view 
Simplify customButtonsOnHover implementation
 2017-06-06 18:54:04 -07:00
Birunthan Mohanathas
391c07b80a Simplify custom window button positioning 2017-06-07 03:33:33 +03:00
Kevin Sawicki
dc5221d551 Guard against null window like before 2017-06-06 17:02:23 -07:00
Birunthan Mohanathas
f60315141b Remove unnecessary if check 2017-06-07 01:19:53 +03:00
Birunthan Mohanathas
3106478510 Rename SemaphoreView to CustomWindowButtonView 2017-06-07 01:18:22 +03:00
Birunthan Mohanathas
7d2226e05e Let Chromium manage document.visibilityState and document.hidden 
Chromium already includes the necessary plumbing to manage the
visibility properties and `visibilitychange` event so this gets rid of
most of our custom logic for `BrowserWindow` and `BrowserView`.

Note that `webview` remains unchanged and is still affected by the issues
listed below.

User facing changes:

- The `document` visibility properties and `visibilitychange` event are
  now also updated/fired in response to occlusion changes on macOS. In
  other words, `document.visibilityState` will now be `hidden` on macOS
  if the window is occluded by another window.

- Previously, `visibilitychange` was also fired by *both* Electron and
  Chromium in some cases (e.g. when hiding the window). Now it is only
  fired by Chromium so you no longer get duplicate events.

- The visiblity state of `BrowserWindow`s created with `{ show: false }`
  is now initially `visible` until the window is shown and hidden.

- The visibility state of `BrowserWindow`s with `backgroundThrottling`
  disabled is now permanently `visible`.

This should also fix #6860 (but not for `webview`).
 2017-06-06 15:16:01 -07:00
Kevin Sawicki
4989b21dbc Autorelease semaphore view 2017-06-05 14:28:58 -07:00
Kevin Sawicki
3a2abde804 Add TODO for hidden-inset deprecation 2017-06-05 13:58:50 -07:00
Kevin Sawicki
de0daa2481 Autorelease tracking area 2017-06-05 13:48:30 -07:00
Kevin Sawicki
7d10bf229d Switch to titleBarStyle for custom window buttons on hover 2017-06-05 13:30:32 -07:00
Kevin Sawicki
566e04f1c0 🎨 2017-06-05 13:13:16 -07:00
Kevin Sawicki
37ba1b0a6b Declare mouse inside variable in interface 2017-06-05 12:55:39 -07:00
Kevin Sawicki
1493d6763c Make custom window buttons an option 2017-06-05 12:50:18 -07:00
Kevin Sawicki
2880cfdc9c 🎨 Minor formatting tweaks 2017-06-05 11:08:05 -07:00
mst128256
96251e55de Removed commented code 2017-06-05 10:41:52 -07:00