Commit graph

86 commits

Author SHA1 Message Date
Milan Burda
6f3c46cc7e refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
Robo
434a6e3561 refactor: create request context from network context (#14656)
* [ci skip] refactor: create request context from network context

* [ci skip] refactor: subscribe to mojo cookiemanager for cookie changes

* [ci skip] refactor: manage the lifetime of custom URLRequestJobFactory

* refactor: use OOP mojo proxy resolver

* revert: add support for kIgnoreCertificateErrorsSPKIList

* build: provide service manifest overlays for content services

* chore: gn format

* fix: log-net-log switch not working as expected

* spec: verify proxy settings are respected from pac script with session.setProxy

* chore: use chrome constants where possible

* fix: initialize request context for global cert fetcher

* refactor: fix destruction of request context getters

* spec: use custom session for proxy tests

* fix: queue up additional stop callbacks while net log is being stopped

* fix: Add CHECK for cookie manager retrieval

* chore: add helper to retrieve logging state for net log module

* fix: ui::ResourceBundle::GetRawDataResourceForScale => GetRawDataResource

* style: comment unused parameters

* build: move //components/certificate_transparency deps from //brightray

* chore: update gritsettings_resource_ids patch

* chore: update api for chromium 68

* fix: net log instance is now a property of session
2018-10-04 13:08:56 -05:00
Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
Robo
2cd03bf360 build: remove duplicate devtools sources (#14522)
* build: remove duplicate devtools sources

* build: create separate target for chrome sources

* Move sources that are always depended on by electron,
  starting with security_state_tab_helper.{cc|h}
* Add //component/strings to pak for devtools security tab

* fix: allow specifying type of the added filesystem.

https://chromium-review.googlesource.com/c/chromium/src/+/729250

* fix: do not index excluded folders

https://chromium-review.googlesource.com/c/chromium/src/+/972579
2018-09-12 08:45:08 -05:00
Cheng Zhao
dd5b8769be fix: use OOPIF for webview tag (#13869)
* fix: use OOIF for webview tag

* fix: do not call GetNativeView for webview

* fix: OOIPF webview's WebContents is managed by embedder frame

* fix: guest view can not be focused

* fix: clear zoom controller when guest is destroyed

* fix: implement the webview resize event

The webview is no longer a browser plugin with the resize event, use
ResizeObserver instead.

* test: disable failed tests due to OOPIF webview

* fix: embedder can be destroyed earlier than guest

This happens when embedder is manually destroyed.

* fix: don't double attach

* fix: recreate iframe when webview is reattached

* fix: resize event may happen very early

* test: some tests are working after OOPIF webview

* chore: remove unused browser plugin webview code

* fix: get embedder via closure

When the "destroyed" event is emitted, the entry in guestInstances would be
cleared.

* chore: rename browserPluginNode to internalElement

* test: make the visibilityState test more robust

* chore: guestinstance can not work with OOPIF webview

* fix: element could be detached before got response from browser
2018-08-16 15:57:40 -07:00
Cheng Zhao
705bbd31e9 add stubs for new devtools messages 2018-07-06 09:07:56 +09:00
Cheng Zhao
29ff9873f4 implement devtools showItemInFolder message 2018-07-06 09:07:56 +09:00
deepak1556
f6665edc73 Convert ColorChooser from ipc to mojo.
https://chromium-review.googlesource.com/c/chromium/src/+/800350
https://chromium-review.googlesource.com/c/chromium/src/+/821954
2018-06-19 11:46:59 +10:00
deepak1556
c29f08c53e DevTools: remove the 'forced' attribute from the AgentHostClosed in DevToolsAgentHost.
https://chromium-review.googlesource.com/c/chromium/src/+/745301
2018-06-19 11:46:59 +10:00
Jeremy Apthorp
e6695cf2ec [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
Shelley Vohr
284aca68c0
clang-format brightray 2018-04-17 21:46:27 -04:00
Cheng Zhao
5e4914700e Enable using external WebContents as devtools 2017-12-01 10:35:23 +09:00
deepak1556
7a9892f151 REVIEW: Inject devtools extensions API via browser
Behavior was changed in https://crbug.com/706169
2017-11-24 10:58:53 +09:00
Aleksei Kuzmin
14c61a96af VR: Check focus state browser-side before sending input to renderer.
https://chromium-review.googlesource.com/c/565760
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
fe48a92422 Propagate opener to BackgroundsContents.
https://codereview.chromium.org/2882513005
2017-11-24 10:58:16 +09:00
Kevin Sawicki
d7321ed980 Add brightray prefix to include paths from within brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
c4608c0f37 Fix build/include_alpha linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
f193b2b2a6 Fix build/include_what_you_use linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
cfb5b6ac89 Fix build/header_guard linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
bb4a61c7ff Remove unused includes 2017-05-19 08:46:15 -07:00
Cheng Zhao
c41fb922b3 Fix API changes of Chrome 58 2017-04-17 16:16:02 +09:00
Cheng Zhao
0a110a44f9 ScopedPtrHashMap has been removed 2017-04-17 16:16:02 +09:00
Kevin Sawicki
2ece711c2e Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
Cheng Zhao
622fd8d1d7 Update InspectableWebContentsImpl 2017-01-23 15:43:17 +09:00
Ales Pergl
85db1bb47d Adjustments after upgrading to Chromium 54 2017-01-17 17:18:51 +09:00
deepak1556
cddce77ea4 force attach devtools client when requested by inspectable webcontents 2017-01-10 16:43:16 +05:30
Cheng Zhao
ab14221a85 Fix API changes of Chrome 53 2016-09-06 17:22:52 +09:00
deepak1556
caba44ab6c allow delegate to handle file and color chooser 2016-07-22 21:09:55 +05:30
Cheng Zhao
851ef398fb Adapt to changes of Chrome 51 API changes 2016-05-23 10:59:07 +09:00
deepak1556
e858c0c6d2 pass the current dock state to devtools url when available 2016-04-19 18:13:08 +05:30
Robo
c25264113f fix devtools filesystem api and allow delegate to request stored filesystem paths 2016-03-15 07:53:40 +05:30
Cheng Zhao
ead0bb0cfc Fix devtools not working 2016-03-09 14:55:46 +09:00
Cheng Zhao
d3a39540b5 Fix compilation errors on OS X 2016-03-08 23:28:28 +09:00
Paul Betts
40c98381ab Update headers for InspectableWebContentsImpl 2016-03-07 22:18:16 -08:00
Paul Betts
da59c0f58b basictypes.h => macros.h 2016-03-07 21:40:41 -08:00
Cheng Zhao
38a211db2e Fix API changes 2015-09-02 15:16:34 +08:00
Haojian Wu
f82ab5f193 Implement devtools preference interfaces. 2015-08-11 09:49:57 +08:00
Haojian Wu
c5ae2926e1 WebContentsFocused is removed.
Use OnWebContentsFocused instead.
2015-08-11 09:49:56 +08:00
Robo
a56a0505fa save devtools zoom level preference 2015-07-29 12:08:31 +05:30
Cheng Zhao
5e943e1456 view_ needs to be destroyed after web_contents_ 2015-06-09 11:09:16 +08:00
Cheng Zhao
64c4a34507 Make devtools_web_contents_ is destroyed before everything
The WebContentsDestroyed still access the other members, so if they are
destroyed before the devtools_web_contents_ in the destructor, we will
crash there.
2015-06-09 10:44:48 +08:00
Cheng Zhao
d1e70e7826 Add InspectableWebContents::GetDevToolsWebContents 2015-06-05 14:33:37 +08:00
Cheng Zhao
05f182f650 Clean up code 2015-06-05 12:24:48 +08:00
Cheng Zhao
aa926680a2 No more need to override DidFinishLoad 2015-06-05 12:10:01 +08:00
Cheng Zhao
56747e975e Avoid calling JavaScript of devtools WebContents too early
It would craete a context that window.location is about:blank
2015-06-05 11:58:27 +08:00
Cheng Zhao
9a9bc5530e Handle network requests from devtools 2015-06-05 11:20:20 +08:00
Cheng Zhao
d48a80bdfa Update to new devtools messages 2015-06-05 11:03:47 +08:00
Cheng Zhao
a9a5765544 Remove trailing space 2015-05-27 15:02:01 +08:00
deepak1556
145c18f4c8 method to reset agent_host 2015-05-18 19:26:03 +05:30
Cheng Zhao
90b255f2cd Fix API changes 2015-04-21 18:54:57 +08:00