Commit graph

28505 commits

Author SHA1 Message Date
trop[bot]
6d94e1a436
docs: fix apostrophe typo "Electrons" -> "Electron's" (#44538)
s/Electrons/Electron's/

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-03 09:33:24 -06:00
trop[bot]
2e33636033
refactor: remove unused C string ToV8() gin converter (#44523)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-02 13:56:55 -05:00
trop[bot]
faa1910ffe
perf: use v8::String::NewFromUtf8Literal in ToV8() gin converter (#44518)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-01 16:56:09 -05:00
trop[bot]
c1069f778e
docs: add custom titlebar example (#44508)
* docs: add custom titlebar example

* docs: add links and other small edits

* docs: add panel window docs

* docs: remove panel example

* docs: specify expected emphasis style

* docs: responding to feedback

* docs: fix section names in links

* docs: rework baseWindow note

* docs: making window customization its own section

* responding to feedback

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Anny Yang <anny@electronjs.org>
2024-11-01 14:02:42 -04:00
trop[bot]
201629f206
build: handle out of disk space on source cache (#44493)
* build: handle out of disk space on source cache

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* build: add cron job to free up source cache disk space

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-31 16:45:08 -05:00
trop[bot]
85272b00a4
fix: EventSource undefined in Renderer/Worker (#44497)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-31 16:44:00 -05:00
Pedro Pontes
6356cdf49f
chore: backport 1 change from 2-M130 (#44484) 2024-10-31 15:24:23 -04:00
Pedro Pontes
e492fba70d
chore: cherry-pick 3 changes from 1-M130 (#44482)
chore: [32-x-y] cherry-pick 3 changes from 1-M130

* 153d4e84e5d1 from v8
* d9893f4856af from v8
* 8c4edae5e34d from chromium
2024-10-31 14:46:18 -04:00
trop[bot]
310319b00a
perf: remove isolate scope from DidProcessTask() (#44472)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-31 11:30:10 +01:00
trop[bot]
9b15acb514
docs: fix win.setContentView() arg type (#44479)
fix: setContentView type

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-30 16:25:57 -04:00
trop[bot]
318a8dcd22
docs: fix win.getContentView() return type (#44465)
docs: fix win.getContentView() return type

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-29 16:59:55 -04:00
trop[bot]
b4a5684493
build: fix python util verbose mode logic (#44452)
build: fix verbose mode logic

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-29 21:41:22 +01:00
Charles Kerr
1cbd5f451a
fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (32-x-y) (#44440)
* fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211)

* chore: rename v8_value_serializer.cc,h to v8_util.cc,h

* feat: add electron::util::as_byte_span(v8::Local<v8::ArrayBuffer>)

* fix: -Wunsafe-buffer-usage warnings in ChunkedDataPipeReadableStream::ReadInternal()

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5619253

* refactor: restore node buffer span util

* refactor: remove redundant span wrapper

* empty commit to force the Valid Backport check to rerun 🤷
2024-10-29 14:51:59 -05:00
trop[bot]
bc90b60005
build: improve gen-libc++-filenames output (#44442)
build: improve gen-libc++-filenames output

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-29 14:16:07 +01:00
trop[bot]
91fb7ff6e3
fix: keep gdk_pixbuf a dynamic dependency (#44437)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-10-28 21:46:47 -05:00
trop[bot]
e781fe50df
fix: crash on netlog connection error (#44419)
* fix: crash on netlog connection error

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

* refactor: remove default PromiseBase constructor

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

* Revert "refactor: remove default PromiseBase constructor"

This reverts commit 9292324a0d5f9e63ba8f73f63dfff1d48eb2f38f.

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

* remove dcheck

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2024-10-28 12:35:32 -04:00
trop[bot]
1a2015c87d
perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals (#44427)
* perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals

the string length is known at compile time and no need to call ToLocalChecked()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* perf: string length is known when calling NewFromUtf8(), so use it

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* perf: remove unnecessary calls to c_str()

these just force the code being called to have to recalculate the string length

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-28 10:51:41 -05:00
trop[bot]
2138b5a3e0
test: deflake flaky tests on linux (#44403)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-25 14:32:26 -04:00
John Kleinschmidt
477f06a987
build: update linux container (#44397)
build: update linux container (#44392)

(cherry picked from commit a0f51d816e7b66e1f60943c672b53bbede94a34a)
2024-10-24 20:46:55 -04:00
John Kleinschmidt
c61bb1654e
test: fixup broken tests in 32-x-y (#44389)
* test: fixup broken tests in 32-x-y

* test: fixup additional failing test
2024-10-24 16:55:23 -04:00
trop[bot]
e9988c2fc4
test: fixup flaky tests (#44380)
* test: fixup flaky test

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* test: disable flaky protocol speed test on macOS

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* test: fixup flaky test in api-browser-window-spec.ts

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* test: update waitUntil to handle async functions

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-24 15:21:55 +02:00
trop[bot]
1a9b93ca96
docs: clarify utilityProcess child.pid value (#44365)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-22 19:22:08 +02:00
Pedro Pontes
d213161010
chore: backport 2 changes from 0-M130 (#44357) 2024-10-22 11:53:27 +02:00
trop[bot]
89ef924a99
fix: software compositing infinite loop (#44351)
* fix: software compositing infinite loop

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

Co-authored-by: Sam Maddock <smaddock@slack-corp.com>

* chore: update patches

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-10-21 20:40:59 -04:00
trop[bot]
9a86172607
build: fixup reclient use for prod builds (#44344)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-21 17:16:01 -04:00
trop[bot]
15486ec73d
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44325)
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44078)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <31829097+cptpcrd@users.noreply.github.com>
2024-10-18 16:19:43 -04:00
trop[bot]
7cfbdfaf34
fix: Linux crash after webContents.print() with no parent window (#44282)
fix: Linux crash after print with no parent window

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-18 11:25:31 -04:00
Pedro Pontes
aaeedc768c
chore: backport 2 changes from 2-M127 to 0-M129 (#44312) 2024-10-18 11:21:50 -04:00
Robo
d5d936d078
fix: trace-startup crashing child process on macOS (32-x-y) (#44292)
* fix: trace-startup crashing child process on macOS (32-x-y)

* chore: disable test on linux arm

* chore: also disable on linux arm64
2024-10-18 11:16:53 -04:00
John Kleinschmidt
519da8e634
chore: fixup reclient read only access on forks (#44306)
* chore: fixup reclient read only access on forks (#44280)

* Trigger CI
2024-10-17 22:21:23 -04:00
trop[bot]
2d9af751fa
build: remove dead code in prepare release script (#44287)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-10-17 10:34:45 -04:00
trop[bot]
b39ba84e87
fix: ensure utilityProcess only emits one 'exit' event (#44268)
fix: ensure utilityProcess only emits one exit

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-16 17:11:25 -04:00
trop[bot]
db2050e9d2
build: update devcontainer sha (#44244)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-15 10:19:55 -04:00
Keeley Hammond
f3de5b9092
chore: cherry-pick 3 changes from 3-M129 (#44231)
* chore: [32-x-y] cherry-pick 3 changes from 3-M129

* 9542895cdd3d from v8
* 259a5f8fed67 from v8
* 81155a8f3b20 from v8

* chore: update patches
2024-10-14 17:35:26 -05:00
trop[bot]
2e63ae0cfb
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (#44207)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-11 20:15:03 -05:00
trop[bot]
7182bc2359
fix: clang variable configuration in generated node headers (#44201)
* fix: clang variable configuration in generated node headers

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* chore: restore value in common.gypi

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* chore: update patches

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 15:25:34 -04:00
trop[bot]
868a713208
ci: don't call datadog test logging on forks (#44195)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 09:41:24 -04:00
trop[bot]
0e9722dc50
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() (#44167)
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 20:38:19 -05:00
trop[bot]
ca8479d859
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() (#44170)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 17:07:20 -05:00
trop[bot]
b30973a5de
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (#44164)
fixup e8948397 really fix the warning this time

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 13:01:22 -05:00
electron-roller[bot]
90bc239f25
chore: bump chromium to 128.0.6613.186 (32-x-y) (#44162)
chore: bump chromium in DEPS to 128.0.6613.186

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-09 12:36:07 -04:00
John Kleinschmidt
44d2bbea0c
ci: add datadog test logging (#44142)
* ci: add datadog test logging

(cherry picked from commit 394ea2979fda0c1551df5d5bdf7c13b57d9be181)

* ci: only upload to datadog when running tests

(cherry picked from commit c3200d8f1540f78c25673a4a9d9af3b8506f9474)
2024-10-09 11:41:02 -04:00
electron-roller[bot]
da32971374
chore: bump node to v20.18.0 (32-x-y) (#44116)
* chore: bump node in DEPS to v20.18.0

* chore: update patches

* src: improve buffer.transcode performance

https://github.com/nodejs/node/pull/54153
(cherry picked from commit 669984dafcb698716fc02a03e4cf027767a6ec59)

* chore: update patches

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-09 09:53:06 -04:00
Samuel Attard
27c38bdead
build: add import/order eslint rule (#44107)
build: add import/order eslint rule (#44085)

* build: add import/order eslint rule

* chore: run lint:js --fix
2024-10-02 21:36:15 -07:00
trop[bot]
bf8de29f9b
fix: remove use of deprecated API base::Hash() (#44102)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 17:56:49 -05:00
Charles Kerr
058a616135
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (32-x-y) (#44095)
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (#44067)

perf: use ArrayBuffer::Data() API

Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is

> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
2024-10-02 16:37:54 -04:00
Charles Kerr
bd8b9daa74
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (32-x-y) (#44097)
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (#44053)
2024-10-02 16:35:26 -04:00
electron-roller[bot]
a635dac618
chore: bump chromium to 128.0.6613.178 (32-x-y) (#44086)
chore: bump chromium in DEPS to 128.0.6613.178

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-01 21:57:30 -05:00
trop[bot]
653b928e0d
build: fix relative file read during npm publish (#44092)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-10-01 17:19:29 -07:00
trop[bot]
98b1d305b6
build: cleanup release scripts, separate cli entrypoints from logic (#44081)
* build: cleanup release scripts, separate cli entrypoints from logic

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>

* build: use repo/org constants

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-10-01 14:08:03 -07:00