mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1
24732 commits 1 branch 190 tags 567 MiB
Commit graph

1509 commits

Author SHA1 Message Date
Cheng Zhao
af4a050a1b
feat: add roundedCorners option for BrowserWindow (#27572) 
* feat: add roundedCorner option for BrowserWindow

* Make roundedCorner work with vibrancy views

* roundedCorner => roundedCorners
 2021-02-09 08:38:35 -08:00
Electron Bot
e51ad4fa45 Bump v13.0.0-nightly.20210209 2021-02-09 06:32:23 -08:00
Jeremy Rose
28599e5e7c
feat: add exit code to render-process-gone details (#27580) 2021-02-08 17:08:11 -08:00
Samuel Attard
09870d97b5
perf: optimize data structures in context_bridge::ObjectCache (#27639) 
* Use std::forward_list instead of base::LinkedList for better perf,
more consistent memory management.  Better than std::list because we
don't need the double-linked-list behavior of std::list
* Use std::unordered_map instead of std::map for the v8 hash table
 2021-02-08 12:30:25 -08:00
Samuel Maddock
1bbfa934f0
fix: early GC of WebFrameMain instances (#27648) 2021-02-08 11:30:18 -08:00
Shelley Vohr
fa09183ed1
fix: BrowserView rendering flicker (#27585) 2021-02-08 09:14:46 -08:00
Electron Bot
0dcc623ab7 Bump v13.0.0-nightly.20210208 2021-02-08 06:32:00 -08:00
Ikko Ashimine
b88f585066
chore: fix typo in electron_api_base_window.cc (#27644) 
reseting -> resetting
 2021-02-08 10:18:08 +09:00
Jeremy Rose
e87803919b
fix: memory leak in BrowserWindow (#27621) 2021-02-05 13:20:20 -08:00
Samuel Attard
b6a91ef5df
fix: clean up base::LinkedList in context_bridge::ObjectCache (#27630) 
base::LinkedList does not delete its members on destruction. We need to
manually ensure the linkedlist is empty when the ObjectCache is
destroyed.

Fixes #27039

Notes: Fixed memory leak when sending non-primitives over the context
bridge
 2021-02-05 12:39:05 -08:00
Keeley Hammond
d06bb7c97b
fix: do not run display check on "closed" windows in tray (#27615) 
* fix: only run display check on restored wndow if minimized

* fix: don't run display check on hidden, non-minimized windows
 2021-02-05 12:11:26 -08:00
Electron Bot
d5bcf742be Bump v13.0.0-nightly.20210205 2021-02-05 06:32:00 -08:00
Cheng Zhao
eb91b1c965
fix: avoid flicker when leaving fullscreen in frameless window (#27587) 2021-02-05 10:03:12 +09:00
Electron Bot
476d86491b Bump v13.0.0-nightly.20210204 2021-02-04 06:31:28 -08:00
Electron Bot
a831ae9c0d Bump v13.0.0-nightly.20210203 2021-02-03 06:33:49 -08:00
Charles Kerr
72127b2916
refactor: precache atoms in window-state-watcher (#27575) 2021-02-02 09:50:32 -08:00
Electron Bot
6b744171b1 Bump v13.0.0-nightly.20210202 2021-02-02 06:31:51 -08:00
Cyrus Roshan
444ad26f89
feat: add option to not transform processes on win.SetVisibleOnAllWorkspaces (#27200) 
* fix: optionally transform processes on win.SetVisibleOnAllWorkspaces on macOS, making it backwards-compatible with v9.2.1 (#27101)

* fix: optionally transform processes on win.SetVisibleOnAllWorkspaces on macOS, making it backwards-compatible with v9.2.1 (#27101)

Co-authored-by: Cyrus Roshan <cyrusroshan@users.noreply.github.com>
 2021-02-02 21:24:04 +09:00
Samuel Maddock
b6df7cd327
fix: crash when loadExtension fails (#27561) 2021-02-02 19:20:05 +09:00
Samuel Maddock
20a71be849
refactor: remove unused extension content script code (#27570) 
This code was leftover from the old JS extensions implementation.
 2021-02-02 19:03:10 +09:00
Сковорода Никита Андреевич
a5e9af330f
feat: implement allowFileAccess loadExtension option (#25198) 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
 2021-02-01 14:41:08 -08:00
Electron Bot
a75cd89d2a Bump v13.0.0-nightly.20210201 2021-02-01 06:31:11 -08:00
Cheng Zhao
8bf66f8974
fix: clean up implementations of titleBarStyle (#27489) 
* Rewrite titleBarStyle impls with WindowButtonsView

* Remove fullscreenWindowTitle option

* Make buttons show correctly under RTL

* Fix docs about traffic lights position

* Fix test on fullscreen resizable

* Fix button states with closabe/minimizable/fullscreenable

* Fix typo

* Deprecate the fullscreenWindowTitle option
 2021-01-30 17:15:10 -06:00
Cheng Zhao
6edf6c6a95
fix: pass button callback in constructor (#27545) 2021-01-29 12:43:51 -08:00
Electron Bot
c7aa35a519 Bump v13.0.0-nightly.20210129 2021-01-29 06:31:35 -08:00
Shelley Vohr
40aeb0d994
fix: dont try to serialize WasmModuleObjects (#27518) 2021-01-28 18:20:28 -08:00
Electron Bot
0ee7bc67bd Bump v13.0.0-nightly.20210128 2021-01-28 06:32:05 -08:00
Shelley Vohr
bf6a50c538
fix: pdf viewer missing resources (#27499) 
* fix: pdf viewer missing resources

* test: add simple regression test

* 2638992: PDF Viewer: Stop respecting the PDFViewerUpdate flag.

https://chromium-review.googlesource.com/c/chromium/src/+/2638992

* 2439433: PDF Viewer Update: Add aria-label for thumbnails

https://chromium-review.googlesource.com/c/chromium/src/+/2439433
 2021-01-28 10:09:55 +09:00
Electron Bot
e94f97f2c9 Bump v13.0.0-nightly.20210127 2021-01-27 06:32:06 -08:00
Samuel Attard
db08f08b88
feat: enable world safe JS by default (#26889) 
* feat: enable world safe JS by default

* refactor: use the ctx bridge to send executeJavaScript results in a world safe way

* docs: add more info about the breaking change

* include default in IsEnabled check
 2021-01-26 14:23:35 -08:00
Milan Burda
bde714c1c6
refactor: cleanup WebFrameMain + improve tests (#27455) 2021-01-26 13:46:09 -08:00
Milan Burda
ddf3ef0a5f
refactor: use C++11 class member variable initialization (#27477) 2021-01-26 12:16:21 -06:00
Electron Bot
4f08bfffc1 Bump v13.0.0-nightly.20210126 2021-01-26 06:31:58 -08:00
Electron Bot
ed126eced4
chore: bump chromium to bf3f97675b5d9eade34526ebf730c (master) (#27305) 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2021-01-25 08:46:00 -08:00
Milan Burda
1023988ea8
build: fix build with enable_printing=false (#27456) 2021-01-25 08:27:25 -08:00
Electron Bot
d0c4a685fc Bump v13.0.0-nightly.20210125 2021-01-25 06:31:18 -08:00
Milan Burda
949fd0728f
refactor: replace base::Bind() with base::BindOnce() / base::BindRepeating() (#27447) 2021-01-25 10:27:40 +09:00
Charles Kerr
5a8f40ae13
fix: don't throw on bad icons in BrowserWindow constructor (#27441) 
* fix: do not throw if NativeImage conversion fails.

Throwing is an unannounced semver/major breaking change, so revert that
behavior but keep the rest of the #26546 refactor.

* test: add invalid icon test

* refactor: be explicit about when to throw or warn.
 2021-01-25 10:24:10 +09:00
Shelley Vohr
d69e0d0573
fix: hiddenInset missing maximize button (#27428) 2021-01-25 09:59:06 +09:00
Electron Bot
fcdb7ad21a Bump v13.0.0-nightly.20210122 2021-01-22 06:33:30 -08:00
Michaela Laurencin
4f930b6e42
fix: add eyedropper tool functionality to browser view (#27275) 2021-01-21 13:02:29 -08:00
Electron Bot
96e8620e1b Bump v13.0.0-nightly.20210121 2021-01-21 11:33:09 -08:00
Shelley Vohr
949cfea1e9
fix: actually clear pending requests in devtoolsagenthost (#27379) 2021-01-21 11:00:43 -08:00
Electron Bot
c8696d2c3d Revert "Bump v13.0.0-nightly.20210121" 
This reverts commit 09b6db4616.
 2021-01-21 07:21:36 -08:00
Electron Bot
09b6db4616 Bump v13.0.0-nightly.20210121 2021-01-21 07:20:19 -08:00
Electron Bot
5c6ad53bd6 Revert "Bump v13.0.0-nightly.20210121" 
This reverts commit 299bc9adc2.
 2021-01-21 07:18:45 -08:00
Electron Bot
299bc9adc2 Bump v13.0.0-nightly.20210121 2021-01-21 07:14:35 -08:00
John Kleinschmidt
e5d64da68a Revert "Bump v13.0.0-nightly.20210121" 
This reverts commit 6d6a785982.
 2021-01-21 10:11:30 -05:00
Electron Bot
6d6a785982 Bump v13.0.0-nightly.20210121 2021-01-21 06:32:20 -08:00
John Kleinschmidt
c5a41defbd
fix: enable navigator.setAppBadge/clearAppBadge (#27067) 2021-01-21 14:45:06 +09:00
Biru Mohanathas
7f1e3ca3de
fix: shutdown crash in DownloadItem callback (#27342) 
The call stack for one of our top crashes looks like this:

```
node::Abort (node_errors.cc:241)
node::Assert (node_errors.cc:256)
node::MakeCallback (callback.cc:226)
gin_helper::internal::CallMethodWithArgs (event_emitter_caller.cc:23)
gin_helper::EmitEvent<T> (event_emitter_caller.h:51)
gin_helper::EventEmitterMixin<T>::Emit<T> (event_emitter_mixin.h:81)
electron::api::DownloadItem::OnDownloadUpdated (electron_api_download_item.cc:115)
download::DownloadItemImpl::UpdateObservers (download_item_impl.cc:482)
content::DownloadManagerImpl::Shutdown (download_manager_impl.cc:508)
content::BrowserContext::~BrowserContext (browser_context.cc:476)
```

Full stack here: https://sentry.io/share/issue/9b030a0601b547188181b543c16ecda2/

During browser shutdown, the `DownloadManager` was being cleaned up
*after* the Node environment had already been destroyed. This caused the
`DownloadItem::OnDownloadUpdated` callback to crash when trying to emit
the JS `done` event.

To prevent this, we now manually shut down the `DownloadManager`
earlier. This is also mentioned in the comment on
`DownloadManager::Shutdown`:

```
// Shutdown the download manager. Content calls this when BrowserContext is
// being destructed. If the embedder needs this to be called earlier, it can
// call it. In that case, the delegate's Shutdown() method will only be called
// once.
```
 2021-01-20 11:30:08 -08:00
Electron Bot
b6a0fcd51d Bump v13.0.0-nightly.20210120 2021-01-20 06:33:03 -08:00
Electron Bot
5fb1095806 Bump v13.0.0-nightly.20210119 2021-01-19 07:51:27 -08:00
Electron Bot
b0c1a2ae25 Revert "Bump v13.0.0-nightly.20210119" 
This reverts commit 9a336a6a3b.
 2021-01-19 07:48:40 -08:00
Electron Bot
9a336a6a3b Bump v13.0.0-nightly.20210119 2021-01-19 06:32:53 -08:00
Cheng Zhao
c3091c3a70
fix: make SetWindowButtonVisibility work for customButtonsOnHover (#27073) 2021-01-19 19:12:09 +09:00
David Sanders
5e7e0a4c7e
fix: improve redirect behavior in protocol module (#26297) 
* fix: improve redirect behavior in protocol module

* Add test for redirection

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
 2021-01-19 19:06:14 +09:00
Samuel Maddock
4334110339
fix: prevent crash when keyboard event immediately precedes calling BrowserWindow.close() (#27315) 
* fix: prevent crash when destroyed widget receives keyboard event

Activating a key to close a window will cause a silent crash. Handling the keyboard
event will lead to a nullptr dereferenced in Chromium code if the window widget has
already been destroyed.

* test: ensure BrowserWindow doesn't crash from keyboard events during close
 2021-01-19 11:37:21 +09:00
riccardopiola
d7b02e123a
chore: duplicate symbols for mojom interfaces in component build (#27186) 
* fix duplicate symbols in component build

* fix: duplicate symbols for mojom interfaces in component build
 2021-01-19 11:31:44 +09:00
Electron Bot
b27fa567bc Bump v13.0.0-nightly.20210118 2021-01-18 06:31:32 -08:00
Electron Bot
3b38ba2ed8 Bump v13.0.0-nightly.20210115 2021-01-15 06:33:34 -08:00
Milan Burda
2be3d03630
feat: add webFrameMain.send() / webFrameMain.postMessage() (#26807) 2021-01-15 09:00:37 +09:00
Electron Bot
28b6579538 Bump v13.0.0-nightly.20210114 2021-01-14 06:33:16 -08:00
Cheng Zhao
cd42933f41
chore: remove ancient Browser::Focus implementation on Windows (#27279) 2021-01-13 13:46:54 -08:00
Shelley Vohr
0599487e65
refactor: use platform-specific TaskRunner to print (#27225) 2021-01-13 09:17:11 -08:00
Electron Bot
1c66cacf70 Bump v13.0.0-nightly.20210113 2021-01-13 06:34:32 -08:00
loc
ceda33dd5e
chore: surface webcontents load error more readily (#22824) 2021-01-13 18:01:51 +09:00
Electron Bot
adf0a73543
chore: bump chromium to a264339194bfa02f5ecb3b8cba449 (master) (#27111) 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2021-01-12 15:31:23 -08:00
Electron Bot
1cd72425aa Bump v13.0.0-nightly.20210112 2021-01-12 06:33:44 -08:00
Electron Bot
d69f578179 Bump v13.0.0-nightly.20210111 2021-01-11 06:32:34 -08:00
Jeremy Rose
088f2e625f
feat: add frame and webContents to webRequest details (#27078) 
* feat: add frame and webContents to webRequest details

* chore: use frame_converter.h

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
 2021-01-11 12:20:43 +09:00
Shelley Vohr
e74b425803
fix: set presentationModeEnabled value for PDF viewer (#27223) 2021-01-11 10:48:39 +09:00
Electron Bot
8c305b4113 Bump v13.0.0-nightly.20210108 2021-01-08 06:31:06 -08:00
Electron Bot
2268c64a55 Bump v13.0.0-nightly.20210107 2021-01-07 06:32:08 -08:00
Electron Bot
0be4430431 Bump v13.0.0-nightly.20210106 2021-01-06 06:32:17 -08:00
Milan Burda
3d59aa5609
feat: add webFrameMain.executeJavaScriptInIsolatedWorld() (#26913) 2021-01-05 17:18:38 +09:00
Cheng Zhao
5f99569b6c
feat: make win.setAspectRatio() work on Windows (#26941) 
* feat: make win.setAspectRatio() work on Windows

* update patches

Co-authored-by: Electron Bot <electron@github.com>
 2021-01-05 17:17:33 +09:00
Shelley Vohr
3286b5fa46
fix: handle BrowserView reparenting (#27000) 2021-01-04 16:34:22 -08:00
Shelley Vohr
6307b52dc5
fix: default offset when no drag regions (#27147) 2021-01-04 14:01:32 -08:00
Shelley Vohr
3455136e9d
refactor: remove path from nativeImage converter (#26546) 2021-01-04 12:58:31 -08:00
Shelley Vohr
29c2e2cb97
fix: unclickable regions in some draggable BrowserViews (#27143) 2021-01-04 11:22:14 -08:00
Electron Bot
6d31f1ad4c Bump v13.0.0-nightly.20210104 2021-01-04 10:59:29 -08:00
Electron Bot
1078590bbd Bump v13.0.0-nightly.20201223 2020-12-23 06:32:07 -08:00
Electron Bot
8383c14aba
chore: bump chromium to 7264889ce3aad1568ff3d211c81fe (master) (#27003) 
* chore: bump chromium in DEPS to 91c9f44297abe2844f593ec7956e6ce79c81f463

* chore: update chromium patches

* chore: update v8 patches

* build: service_names.mojom has been deleted

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2568681

* chore: add DISPLAY_CAPTURE permission to converter

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2551098

* chore: handle AXPropertyFilter::SCRIPT in accessibility_ui

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2563923

* refactor: web_isolated_world_ids.h has been deleted

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585255

* refactor: ResourceType has been deprecated / removed in ExtensionsBrowserClient

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2562002

* chore: fix lint

* chore: remove deleted headers

* build: disable gn check for blink header

* fix: refactor X11 event handling

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2577887
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585750

* chore: update patches

* chore: bump chromium in DEPS to bfd8e7dbd37af8b1bc40d887815edd5a29496fa3

* chore: update patches

* refactor: xeventobserver is now x11:eventobserver

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585750

* refactor: remove UseWebUIBindingsForURL

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2583590

* chore: DidProcessXEvent has been removed

* chore: bump chromium in DEPS to b13e791d7244a08d9d61dbfa2bb2b6cdf1ff6294

* chore: update patches

* build: change gfx::GetAtom to x11:GetAtom

Refs: d972a0ae4a

* build: change gfx namespace to x11

Ref: d972a0ae4a

* build: change ui namespace to x11

Refs: c38f8571a8:ui/gfx/x/xproto_util.h;dlc=ba9145d0c7f2b10e869e2ba482ca05b75ca35812

* chore: add patch to fix blink prefs fetching during frame swap

* chore: fix lint

* fix: do not make invalid SKImageRep in FrameSubscriber

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2572896

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
 2020-12-22 14:14:44 -08:00
Electron Bot
729c45637d Bump v13.0.0-nightly.20201222 2020-12-22 06:33:47 -08:00
Electron Bot
3a970825b2 Bump v13.0.0-nightly.20201221 2020-12-21 06:32:03 -08:00
Eryk Rakowski
bf24759354
fix(extensions): implement missing web_request hooks (#22655) 
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com>
 2020-12-18 15:11:43 -08:00
Electron Bot
8f1bc338e5 Bump v13.0.0-nightly.20201218 2020-12-18 06:34:00 -08:00
Cheng Zhao
cdc94e4cef
chore: remove extra setTitlebarAppearsTransparent (#27042) 2020-12-18 09:51:05 +09:00
Cheng Zhao
f99ea7c0ba
chore: put NativeWindowMac's methods in order (#27040) 2020-12-18 09:50:51 +09:00
Electron Bot
8cbcb04e84 Bump v13.0.0-nightly.20201217 2020-12-17 06:31:25 -08:00
Shelley Vohr
75247d18d0
refactor: remove last use of InternalCallbackScope (#27029) 
* refactor: remove last use of InternalCallbackScope

* update patches

Co-authored-by: Electron Bot <electron@github.com>
 2020-12-16 14:02:36 -06:00
Electron Bot
9377b04e0b Bump v13.0.0-nightly.20201216 2020-12-16 06:32:14 -08:00
Shelley Vohr
9eab298779
feat: add missing 'context-menu' values (#26788) 
* fix: add missing 'context-menu' values

* Add missing canSave

* Remove canTranslate
 2020-12-16 14:32:11 +09:00
Cheng Zhao
e01b1831d9
feat: make trafficLightPosition work for customButtonOnHover (#26789) 2020-12-16 14:30:39 +09:00
Eryk Rakowski
1e2a2004e9
feat: add support for webContents option in BrowserView (#26802) 
* feat: add support for webContents option in BrowserView

* tests: add tests
 2020-12-16 08:52:43 +09:00
Milan Burda
6932e17088
chore: remove deprecated systemPreferences methods (#26849) 2020-12-16 08:34:24 +09:00
Shelley Vohr
b266b5208a
refactor: use public node::CallbackScope where possible (#27001) 
* refactor: use public node::CallbackScope where possible

* Remove unused node_env() getter
 2020-12-15 11:39:25 -08:00
Nick Harper
21024011d7
fix: incorrect case in content::PermissionType mapping (#27006) 2020-12-15 11:14:42 -08:00
Jeremy Rose
833baa4c54
fix: throw when using globalShortcut before ready (#27002) 2020-12-15 11:13:56 -08:00