Charles Kerr
31172ecaa0
Merge pull request #11008 from electron/implement-stream-protocol
...
Implement {register,intercept}StreamProtocol
2017-11-14 09:31:57 -06:00
Cheng Zhao
4b8ab8fc97
Merge pull request #10856 from dittos/mas-login-helper
...
Implement login helper to manage login item in Mac App Store build
2017-11-14 21:34:50 +09:00
Thiago de Arruda
5ea3a5886b
Implement {register,intecept}StreamProtocol
...
These new functions are more flexible than the other
{intercept,register}*ProtocoProtocol functions, since it allows the user to
return a node.js stream to feed the data to the protocol handler.
It also allows the user to specify a response header dictionary, which makes it
possible to correctly intercept any request made from renderers.
2017-11-13 16:16:14 -03:00
Thiago de Arruda
68f514b92f
Implement EventSubscriber<T> class.
...
This class simplifies the task of subscribing/handling javascript events from
C++ classes in the main process.
2017-11-13 15:22:50 -03:00
Thiago de Arruda
64bfabdeba
Make BindFunctionWith function visible to other modules.
2017-11-13 15:21:22 -03:00
Thiago de Arruda
6b666b69c0
Implement GetLoadTimingInfo in JsAsker class.
...
This is required to avoid a crash in blink when implementing a custom protocol
handler that deals with redirects.
2017-11-13 15:20:56 -03:00
Thiago de Arruda
6b2ddc4814
Stop allowing electron.net requests to be intercepted.
...
Not very useful to intercept requests from `electron.net`, since both the
interception machinery and `electron.net` live in the browser process.
2017-11-13 15:20:46 -03:00
Thiago de Arruda
32113bf7f9
Implement V8 -> C++ conversion of net::HttpResponseHeaders.
2017-11-13 15:20:40 -03:00
Thiago de Arruda
9c04d18387
Modify FillRequestDetails to pass headers dictionary.
2017-11-13 15:19:59 -03:00
Felix Rieseberg
163a33a9db
Add fallbacks
2017-11-13 09:27:02 -08:00
Felix Rieseberg
b382dec4a2
🔧 Rename the label
2017-11-13 09:26:52 -08:00
Cheng Zhao
72440d4ae7
No need to add new methods to WebContentsPreferences
2017-11-13 17:35:49 +09:00
Cheng Zhao
cee1c459c7
Do not accidentally change the behavior of did-change-theme-color
2017-11-13 16:20:54 +09:00
Cheng Zhao
7e0593950c
Code style fixes
2017-11-13 16:13:54 +09:00
Heilig Benedek
276e12ce71
pass on web_contents to properly handle devtools
2017-11-13 15:50:50 +09:00
Heilig Benedek
26daffea9c
use smart pointer for paint_canvas
2017-11-13 15:50:49 +09:00
Heilig Benedek
4b10445c2e
lint fix
2017-11-13 15:50:49 +09:00
Heilig Benedek
193beb57c9
fix datalist element popup position when menu is hidden
2017-11-13 15:50:49 +09:00
Heilig Benedek
f8b3009ebf
restructure code to use web_preferences if possible
2017-11-13 15:50:49 +09:00
Heilig Benedek
71b36ef54d
don't show the dummy window for the rest of the dialogs too on mac
2017-11-13 15:46:46 +09:00
Heilig Benedek
13b86598e8
don't show osr dummy window when dialog is shown on mac
2017-11-13 15:46:46 +09:00
Heilig Benedek
35dc6d03b9
lint fix
2017-11-13 15:46:46 +09:00
Heilig Benedek
e39aacb30e
fix a bug that caused a crash when using an offscreen window with detached devtools, related to autofill popups
2017-11-13 15:46:46 +09:00
Heilig Benedek
5daaff91ea
fix a bug where datalist elements wouldn't actually set the value of the input associated with them
2017-11-13 15:46:46 +09:00
Felix Rieseberg
7b0b87bfef
🔧 Use full version string
2017-11-12 22:37:46 -08:00
Samuel Attard
3c0b233d04
Fix line length in caller.cc
2017-11-13 11:42:42 +11:00
Samuel Attard
aa6b9a5025
Fix crash when emitting unhandled error on native EventEmitter
2017-11-13 03:03:58 +11:00
Samuel Attard
a06a8a6f79
Merge pull request #11056 from ajmacd/allow-browser-window-logs
...
Allow BrowserWindows to emit `console-message` events.
2017-11-11 14:34:39 +11:00
Ahmed
9b3960fe90
Merge branch 'master' into master
2017-11-08 18:03:55 +01:00
Samuel Attard
bb997c2ea4
Forward declare the scrubber layout
2017-11-08 16:48:08 +13:00
Andrew MacDonald
c260a0ab78
Allow BrowserWindows to emit console-message events.
2017-11-07 15:31:15 -08:00
Armagan Amcalar
edd113548a
Make ScrubberItem width dynamic
...
Depending on whether a ScrubberItem has text or an icon, this changeset
calculates the actual width and sizes the TouchBar items accordingly.
Previously, all ScrubberItems, regardless of their content, had a static
width of 50px.
This commit also fixes #10539 .
2017-11-07 00:09:14 +01:00
John Kleinschmidt
5383b4809f
v1.8.2-beta.2
2017-11-06 16:11:34 -05:00
Charles Kerr
4ceeddc09f
Merge pull request #10972 from electron/dpi-issues
...
Workaround for Windows DPI issues
2017-11-02 10:16:11 -05:00
Shelley Vohr
24acd74d15
update deprecation warning
2017-11-01 22:23:33 -04:00
Shelley Vohr
3af83f1c97
add new method and mark setExtraParameter for deprecation
2017-11-01 21:57:43 -04:00
Felix Rieseberg
e8f8100e19
🔧 Add fixme
2017-11-01 11:30:32 -07:00
Shelley Vohr
7f89cd0774
remove const from non-member function
2017-10-31 23:55:22 -04:00
Shelley Vohr
93df164485
add const and other small edits
2017-10-31 23:42:25 -04:00
Shelley Vohr
a538e47994
complete GetParameters method & all tests passing
2017-10-31 18:19:04 -04:00
Shelley Vohr
3136f833a5
fixes and updates to GetParameters
2017-10-31 13:51:44 -04:00
Felix Rieseberg
58708d6242
🔧 Lowercase
2017-10-31 10:31:05 -07:00
Shelley Vohr
a9c13359dc
first attempt to add new GetParameters method to CrashReporter
2017-10-31 13:06:54 -04:00
Felix Rieseberg
08b8f2df55
📝 Typo!
2017-10-31 08:38:33 -07:00
Shelley Vohr
06075c4499
extrapolate removeExtraParameter into new method
2017-10-30 23:12:04 -04:00
Felix Rieseberg
91414dde62
🔧 I can't believe this helps
2017-10-30 11:22:07 -07:00
Samuel Attard
c9926bed9f
Merge pull request #10954 from electron/less-process-metrics-warnings
...
fix: Don't call idleWakeupsPerSecond on Windows
2017-10-28 12:36:45 +13:00
Samuel Attard
dc8b583363
Merge pull request #10944 from electron/fix-notification-ref-crash
...
Close the previous notification on multiple calls to show
2017-10-28 12:33:30 +13:00
Felix Rieseberg
da21d6cdda
🔧 Don't call idleWakeupsPerSecond on Windows
2017-10-27 14:23:06 -07:00
Matt Crocker
b6fb016a9a
Cleanup per review comment
2017-10-27 00:07:54 -07:00
Matt Crocker
77a26882a3
Make linter happy
2017-10-27 00:04:19 -07:00
Matt Crocker
c5914516c8
Upstream good ideas from Muon
2017-10-27 00:04:19 -07:00
Matt Crocker
ca8f45a501
Notifications should emit close on close, not eventual GC
2017-10-27 00:04:19 -07:00
Samuel Attard
8719e9f098
Definitely didn't forget to push the header file
2017-10-27 16:27:37 +13:00
Samuel Attard
fe9069c028
Close the previous notification on multiple calls to show
2017-10-27 16:22:21 +13:00
Charles Kerr
c72e0c1508
Merge pull request #10902 from mattlyons0/master
...
🐧 Don't wait for xdg-open to exit
2017-10-26 09:43:34 -05:00
Paul Frazee
c2d9e082cb
Fix crash in custom protocols caused by bad callback exec
2017-10-25 21:01:53 -05:00
Matt Lyons
424f9aeae6
🐧 Don't wait for xdg-open to exit
...
Waiting for xdg-open to return freezes Electron application.
Some file managers (ex: Nemo) don't return until some time after they are closed, this freezes the Electron application until the process returns.
The same is true about any application that can potentially be opened with OpenItem
2017-10-24 19:39:54 -07:00
John Kleinschmidt
67f0eb7b3b
Merge pull request #10873 from ahmedmohamedali/fix_issue_10697
...
Fixes #10697
2017-10-23 09:32:28 -04:00
Ahmed Mohamed Ali
463260b249
Electron crashes if user clicks Dev Tools & Zoom options #10697
2017-10-21 22:21:24 +02:00
Ted Kim
4119da607f
Implement login helper to manage login item in Mac App Store build
2017-10-20 11:44:19 +09:00
Ahmed Mohamed Ali
9f3cfa2dbd
Fix crash that happens when the PDF viewer is refreshed.
...
The root cause is the PdfViewerHandler instanceis destroyed but not removed from the list of observer in WebContentsZoomController
2017-10-19 16:27:08 +02:00
John Kleinschmidt
90e7d7e112
v1.8.2-beta.1
2017-10-18 16:49:32 -04:00
Ahmed Mohamed Ali
05035eb1e3
Fix linefeeds
2017-10-18 17:36:56 +02:00
John Kleinschmidt
57537ea10e
Merge pull request #10810 from qazbnm456/add_error_code_to_session_set_certificate_verify_proc
...
Add error code to session.setCertificateVerifyProc
2017-10-18 09:33:37 -04:00
John Kleinschmidt
cbda307ebf
Merge pull request #10696 from primalmotion/patch-1
...
🍎 skip tabbing category if macOS < Sierra
2017-10-17 10:24:11 -04:00
Boik
f40cc5ab54
add error code to session.setCertificateVerifyProc
2017-10-16 17:17:21 +08:00
Ahmed Mohamed Ali
8763e8ee35
Fixing coding style
2017-10-14 11:17:52 +02:00
Ahmed Mohamed Ali
5030db000a
Applying changes requested by @deepak1556 after the review:
...
- Move RenderFrameHost methods in the UI thread
- Check GetAssociatedRenderFrame return value
2017-10-14 11:09:05 +02:00
Ahmed Mohamed Ali
1ad95eca4a
Add support for pdf in sub frames ( https://github.com/electron/electron/issues/9192#issuecomment-335543866 )
2017-10-13 19:56:20 +02:00
Birunthan Mohanathas
13b9b5c0c0
Merge pull request #10746 from electron/removeuserdefault
...
Add systemPreferences.removeUserDefault()
2017-10-12 16:08:57 +03:00
Samuel Attard
bdf3552be6
Merge pull request #10727 from electron/named-nativeimage
...
Add an API to get a nativeImage from a named NSImage
2017-10-12 10:02:07 +11:00
Birunthan Mohanathas
06d782279c
Add systemPreferences.removeUserDefault()
...
This can be used to restore the default or global value of a `key`
previously set with `setUserDefault`.
2017-10-10 22:57:47 +03:00
Samuel Attard
2c7787900f
Follow style guide
2017-10-10 17:20:55 +11:00
Samuel Attard
9308c96f95
Appease the linting overlords
2017-10-10 17:17:51 +11:00
Samuel Attard
b5ba8699f3
Enable hsl shifting of named images
2017-10-10 17:05:13 +11:00
Samuel Attard
767a178bd1
Do not throw if the named image can not be found
2017-10-10 03:18:44 +11:00
Samuel Attard
e027ba9c47
Add nativeImage.createFromNamedImage API
2017-10-10 03:13:40 +11:00
Samuel Attard
d350134c4f
Ensure that the touchbar's esape item can be set before setting it
2017-10-10 02:24:49 +11:00
Shelley Vohr
242e097e9b
Merge pull request #10670 from electron/add-linuxdefaultprotocol
...
add setAsDefaultProtocolClient for Linux
2017-10-07 10:07:02 -05:00
Shelley Vohr
443c30890b
remove dummy check
2017-10-07 10:38:08 -04:00
Shelley Vohr
35eea8bea5
remove unused xdg setting
2017-10-07 00:38:25 -04:00
Shelley Vohr
66827755e7
remove chrome check and change protocol handler
2017-10-07 00:36:18 -04:00
Shelley Vohr
a1347f67a1
remove a space from a comment wow thanks linter
2017-10-06 23:40:58 -04:00
Shelley Vohr
c9da806c84
slight refactor and lin cleanup
2017-10-06 23:32:46 -04:00
Antoine
5e6b683cfb
fixed: trying to fix the build
2017-10-05 15:57:27 -07:00
Antoine
8e1945f768
🍎 skip tabbing category if macOS < Sierra
...
Previously, the macro was ensuring the` MAC_OS_X_VERSION_10_12` was not defined to decide to compile a `NSWindow` category back porting native tabs or not.
This patch ensures to compile the `NSWindow` category only if the min required version is lesser than 1012 (`MAC_OS_X_VERSION_10_12`)
2017-10-05 14:11:58 -07:00
Shelley Vohr
f8f21815eb
syntax updates and pointer conversion
2017-10-05 00:30:14 -04:00
Cheng Zhao
bb71b09452
Fix building on Windows
2017-10-05 11:51:41 +09:00
Cheng Zhao
4342480473
Fix cpplint warnings
2017-10-05 11:49:26 +09:00
Sean Bannigan
0b205019b6
add mouse-move event and click event position for tray
2017-10-05 11:41:08 +09:00
Cheng Zhao
8c5bb5969c
Merge pull request #10667 from dittos/window-opacity
...
Add window opacity support
2017-10-04 15:03:45 +09:00
Felix Rieseberg
a337b12877
Merge pull request #10680 from electron/idlewakeups-windows
...
Don't call GetIdleWakeupsPerSecond on Win
2017-10-03 22:04:55 -07:00
Felix Rieseberg
4e05d24d1b
Merge pull request #10661 from electron/browserview-multiple-screens
...
BrowserView: Allow dragging of window to screen above menubar
2017-10-03 16:09:11 -07:00
Felix Rieseberg
9fcf7eb27c
🔧 Don't call GetIdleWakeupsPerSecond on Win
2017-10-03 10:21:31 -07:00
Shelley Vohr
6131a523dc
add xdg helper method
2017-10-03 11:10:38 -04:00
Cheng Zhao
150a4797a4
Merge pull request #10676 from qazbnm456/fix-unhandle-null-pointer
...
Add a null-pointer check before processing base::SupportsUserData::GetUserData
2017-10-03 20:18:51 +09:00
Daniel Ma
1bb042a661
feat(NativeWindowMac): addTabbedWindow
...
Add support for the [`NSWindow addTabbedWindow`][nsw] method on MacOSX
This plays nicely with the changes from #9052 and #9725
Usage samples available in [this commit][c] in my fork of
`electron-quick-start`
[nsw]: https://developer.apple.com/documentation/appkit/nswindow/1855947-addtabbedwindow
[c]: 79f06591df
2017-10-03 20:11:16 +09:00
Boik
d594092675
add a null-pointer check before processing base::SupportsUserData::GetUserData
2017-10-03 12:42:35 +08:00
Taeho Kim
7570ec9d39
Add BrowserWindow.getOpacity for consistency
2017-10-03 00:08:10 +09:00
