Commit graph

183 commits

Author SHA1 Message Date
Keeley Hammond
0696320d28
build: remove S3 uploads (#34104) 2022-05-05 21:40:34 -07:00
Samuel Attard
d2c3e78117
build: actually verify az urls too (#33929) 2022-04-27 10:37:26 -07:00
John Kleinschmidt
6a1748da06
ci: update release script to handle new CircleCI configs (#33914) 2022-04-25 11:14:16 -04:00
electron-roller[bot]
f3e0517b6e
chore: bump chromium to 102.0.4999.0 (main) (#33731)
* chore: bump chromium in DEPS to 102.0.4999.0

* 3576640: Set OOM handler during V8 initialization

https://chromium-review.googlesource.com/c/chromium/src/+/3576640

* 3574964: Remove deprecated base::Value usage in print_settings_conversion code.

https://chromium-review.googlesource.com/c/chromium/src/+/3574964

* 3570062: Replicate Active state to render process for all RenderViews.

https://chromium-review.googlesource.com/c/chromium/src/+/3570062

* chore: fixup patch indices

* 3380402: Remove legacy SwiftShader

https://chromium-review.googlesource.com/c/chromium/src/+/3380402

* 3570254: [Local Fonts] Rename permission name from FONT_ACCESS to LOCAL_FONTS.

https://chromium-review.googlesource.com/c/chromium/src/+/3570254

* 3572172: Rename or remove several parameters involved in creation of MimeHandler streams

https://chromium-review.googlesource.com/c/chromium/src/+/3572172

* fix: add missing base/bits include

* chore: fix lint

* chore: remove ia32 Linux support

* chore: patch out swift-format cipd dep on macOS

* build: apply patch better

* build: reset all caches

* build: update zip manifests to remove swiftshared libraries

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3380402

* Revert "build: update zip manifests to remove swiftshared libraries"

This reverts commit 6aeec01ef1a79425a7b7d8c1cfb131a26b91c494.

* Revert "3380402: Remove legacy SwiftShader"

This reverts commit 4c7eebbbf2d0a459cc192959e17ae20f970c2da2.

* build: remove unused swiftshader egl libraries

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <sattard@salesforce.com>
2022-04-22 15:36:22 -07:00
Keeley Hammond
3d4d39d67b
chore: interpret bytes to string (#33766) 2022-04-13 14:51:00 -07:00
Keeley Hammond
2ca46058cd
build: migrate urllib to python3 (#33737) 2022-04-12 14:07:40 -07:00
Jeremy Rose
c0d442364a
build: explicitly run scripts with python3 (#33720)
* build: explicitly run scripts with python3

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-04-12 13:21:55 +02:00
Keeley Hammond
41c1a7e318
chore: modify uploaded assets for win-ia32 (#33699)
* chore: filter correct symbol files

* chore: upload correct assets
2022-04-11 11:02:01 -07:00
John Kleinschmidt
94c2a7671c
build: temporarily disable 32-bit Windows symbol generation (#33653)
* build: temporarily disable 32-bit Windows symbol generation

* fix: modify upload.py

* chore: fix comment

Co-authored-by: VerteDinde <vertedinde@electronjs.org>
2022-04-08 04:17:51 -07:00
Inclusive Coding Bot
68d6d8d451
chore: switch to gender neutral terms (#33532)
* Switch to gender neutral terms

* Update docs/api/web-contents.md

Co-authored-by: Milan Burda <milan.burda@gmail.com>

* Update docs/api/webview-tag.md

Co-authored-by: Milan Burda <milan.burda@gmail.com>

* Update script/release/uploaders/upload.py

Co-authored-by: John Kleinschmidt <jkleinsc@github.com>

* Update docs/tutorial/in-app-purchases.md

Co-authored-by: Milan Burda <milan.burda@gmail.com>

Co-authored-by: inclusive-coding-bot <inclusive-coding-bot@github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
2022-04-06 17:19:32 -04:00
Samuel Attard
204b53e7b8
build: upload to AZ as well as S3 (#33573)
* build: upload to AZ aswell as S3

* fix: provide env to azput
2022-04-04 02:32:57 -07:00
David Sanders
27ddf19f3c
chore: use pylint-2.7 (#33232)
* chore: use pylint-2.7

* chore: fix pylint errors
2022-03-22 20:17:35 -04:00
David Sanders
45e2f86fe0
chore: fix pylint-2.7 errors (#33233) 2022-03-21 11:11:21 +09:00
BIKI DAS
fdb60240f3
fix: removed unused imported Objects (#33304) 2022-03-21 10:21:21 +09:00
John Kleinschmidt
3d9b9b97cf
build: put v8_context_snapshot_generator.dSYM in its own zip file (#33183) 2022-03-07 18:47:58 -05:00
Keeley Hammond
83a4b234d7
build: account for path-filtering workflow in release-build script (#32063)
* build: account for path-filtering workflow in release-build script

* build: update syntax for workflow id

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2021-11-30 09:17:04 -08:00
Keeley Hammond
43f36b5b24
build: add CI path-filtering for docs-only changes (#31741)
build: (wip) initial dynamic config research

* build: (wip) test path filtering option

* build: (wip) remove doc-only script, use path filtering to check changes

* build: (wip) add docker image with Electron dependencies

* build: (wip) clean up config

* build (wip): readd parameters, executors and env*s

* build: re-add steps and commands

* build: change doc-only to ts-compile-doc-only

* build: re-add workflows and jobs

* build: split configs to setup & build

* build: move lint to "always run" config

* build: clean up, remove old reference config

* build: bump to path-filtering 0.1.0

* build: remove ts-compile step from build-linux

* build: remove nightly-linux-release-test, linux-checks-nightly

* build: don't run build on publish

* build: set base-revision to main (runs branch vs commit)

* build: update config from chromium roll
2021-11-29 18:09:07 -05:00
Michaela Laurencin
6bc5fa3758
fix: generate angle brackets in release notes (#31757) 2021-11-10 10:06:59 +09:00
Keeley Hammond
0f0ed5921d
chore: fix supported versions automation (#31602) 2021-10-26 22:26:17 -07:00
Samuel Attard
add94f5fe6
build: retry hasher function if it fails first time (#30899)
* build: retry hasher function if it fails first time

* Update script/release/get-url-hash.js

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2021-10-25 14:11:07 -07:00
Alexey Kuzmin
2d111a4e25
chore: fix pylint (#31138)
* chore: fix pylint

* chore: fix linter errors
2021-09-29 13:10:13 -04:00
Samuel Attard
aab5ea5f9d
build: embed binary checksums in the npm package (#30611)
* build: embed binary checksums in the npm package

* Update docs/tutorial/installation.md

Co-authored-by: Jeremy Rose <jeremya@chromium.org>

* refactor: replace reduce with loop

Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-08-19 11:26:17 -07:00
Samuel Attard
0c1f762119
build: fix publish-to-npm script post requests migration 2021-08-13 13:26:38 -07:00
Samuel Attard
fc9a197f6c
build: do not excessively log response bodies 2021-08-13 13:15:39 -07:00
Samuel Attard
61117a11a1
build: ensure getAssetContents is called in a async wrapper fn 2021-08-13 13:07:17 -07:00
Samuel Attard
d1bd9afbbf
build: use basic auth to trigger CI if either a username OR password is provided 2021-08-13 10:40:26 -07:00
Samuel Attard
a48968c1ce
build: do not pass undefined to Auth header in CI scripts 2021-08-13 10:37:30 -07:00
Samuel Attard
93b1d2d932
build: fix release CI jobs start script (#30521)
This broke in #30492, we weren't handled 20X status codes and weren't authing to appveyor correctly.
2021-08-13 10:25:17 -07:00
Samuel Attard
439e83de6c
refactor: remove all usages of the legacy request module (#30492)
* Replaces request with got
* Replaces nugget with got streams
* Replaces request in docs with got
* Upgrades dugite to drop requests dependency
2021-08-12 10:34:49 -07:00
Samuel Attard
59ab79417d
build: rebase release branch before reverting bump (#30400) 2021-08-05 10:49:12 -07:00
John Kleinschmidt
cce27a0961
chore: update publish to npm to use GitHub token (#30275)
ensures that we don't get hit with a rate limit while trying to publish a release.
2021-07-27 09:52:18 -04:00
Samuel Attard
9fe70c5580
build: handle release failure by existing with code 1 (#30216) 2021-07-21 00:45:57 -07:00
Keeley Hammond
deb75ceaa5
build: update version-bumper to support alpha (#30165)
* build: update version-bumper to support alpha

* build: seperate alpha bump version tests

For easier deletion. If we want to continue supporting an alpha channel,
they can be reintegrated with main tests.

* chore: fix regex

Co-authored-by: Samuel Attard <sam@electronjs.org>

Co-authored-by: Samuel Attard <sam@electronjs.org>
2021-07-19 17:58:15 -07:00
George Xu
4b780f9770
docs: update supported versions to match new release cadence (#30121) 2021-07-14 15:38:28 -07:00
Samuel Attard
331444d103
build: add support for spawning builds for a specific commit on appveyor (#29971) 2021-06-30 18:17:59 -07:00
Samuel Attard
c48ec133a5
build: remove individual release build workflows (#29344)
* build: remove individual release build workflows

* build: ensure even builds we do not want to run have at least one step
2021-06-07 10:17:27 -04:00
Keeley Hammond
d8d6e2ebc0
build: update support.md on stable version bumps (#29381)
* build: update support.md on stable version bumps

* build: update supported on major stable & nightly bumps

* test: updateSupported tests

* chore: fix syntax

* chore: use fspromise in version-bumper script/spec
2021-06-02 12:53:23 -07:00
Jeremy Rose
8ce63a9f18
refactor: point prepare-release at main (#29394) 2021-06-02 12:21:20 -07:00
Jeremy Rose
95bb0ba001
fix: use default_branch in release-notes (#29415) 2021-05-30 17:22:33 -07:00
Jeremy Rose
750ebfdbca
refactor: use main in release-notes (#29395) 2021-05-28 12:14:50 -07:00
Jeremy Rose
a61f1446bc
refactor: publish-to-npm respects main (#29375) 2021-05-28 12:13:12 -07:00
Jeremy Rose
1373a030b4
refactor: version-utils respects main (#29374) 2021-05-27 17:32:37 -07:00
Samuel Attard
1d77af0aff
build: only upload libcxx headers on linux 2021-05-23 17:11:21 -07:00
Keeley Hammond
d03325541f
test: rebuild nan tests with libc++ and libc++abi (#29281)
* test: re-enable nan test: typedarrays-test.js

Fixes #28414.

I've confirmed this fix wfm on Linux. Pushing into a PR to get CI to run
it out on Win and Mac platforms too.

* chore: clarify comment

* test: fix NAN test string alignment

* test: (wip) add ldflags, archive file for libc++

* test: (wip) add libc++ to CircleCI

* test: (wip) add llvm flags

* test: (wip) change ldflag syntax

* test: (wip) build libc++abi as static

* fix: correct ldflags

* test: add ld env

* fix: do not commit this

* test: add lld from src to circleci

* test: add lld link to ld

* chore: preserve third_party

* seems legit

* sam swears this works kinda sort of sometimes'
:

* build: add gn visibility patch

* chore: update patches

* build: check for flatten_relative_to = false

* build: upload zip files, add to release.js validation

* debug: what the hell gn

* build: add libcxx gni to lint ignore

Linting the file adjusted the licenses array, which only contains
one value, and causes the gn check to fail later

* build: also use nan-spec-runner flags on Windows

* build: add linked flags for win32 only

* build: build libc++ as source on win

* build: clean up patch, add -fPIC for IA32

* build: delete libcxx .a files from root

* build: rename libc++.zip, clean up upload per platform

* build: fix gni lint

* ci: add libcxx gen to circleci config

* build: correct libcxx-object syntax

Co-authored-by: Samuel Attard <sam@electronjs.org>

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sam@electronjs.org>
2021-05-22 11:48:38 -07:00
Samuel Attard
8944bceae2
build: merge double space in SHASUM validation logic (#29117) 2021-05-12 01:49:16 -07:00
Samuel Attard
35f2ed8978
build: offload hash checking logic to lambda worker during release (#29096) 2021-05-11 09:30:35 -07:00
Samuel Attard
56c3103e73
build: remove dead python methods and helper (#28884) 2021-04-28 00:39:30 -07:00
Samuel Attard
3879e9e065
build: remove the vendor directory (#28883)
The `vendor` directory is a remnant of times long since gone when we had
brightray and libchromiumcontent (never forget).  It is currently the
hope to a single header file that afaics we do not need anymore and
randomly pyyaml gets cloned there but that is easily movable.

This commit removes all references to the vendor directory from scripts,
docs, helpers, etc. and removes the directory itself.
2021-04-28 00:38:08 -07:00
Samuel Attard
7884f52976
build: fix releases that failed halfway through npm publish actions (#28851) 2021-04-26 13:02:14 -07:00
John Kleinschmidt
8164322195
build: read node files as binary files (#28729) 2021-04-19 12:55:17 -07:00
Samuel Attard
e37533b73a
build: do not require vsts token for releases (#28643) 2021-04-13 15:30:46 -07:00
Shelley Vohr
f78f8d15a9
build: better error handling for release builds (#28621) 2021-04-13 09:37:23 +02:00
John Kleinschmidt
034a792df1
ci: enable arm64 macOS tests (#24832)
* ci: enable arm64 macOS tests
2021-01-21 18:36:52 -05:00
Biru Mohanathas
44ca6e0818
fix: Upload all *.dll.pdb to symbol server (#26962)
Fixes #26961.

Notes: Add Electron DLLs like libGLESv2.dll to symbol server
2020-12-11 12:34:03 -08:00
Samuel Attard
b894151745
build: update npx.py to support npx@7 (#26662)
* build: update npx.py to support npx@7

* build: set npm_config_yes for all npx callsites
2020-11-23 21:26:54 -08:00
John Kleinschmidt
cdc9625a86
build: upload dsym files for all mac releases (#26425) 2020-11-10 11:12:41 -08:00
Samuel Attard
8b7e10cf4d
build: verbose is flag, no value (#26414) 2020-11-09 15:08:27 -08:00
Samuel Attard
946802600b
chore: move upload-to-github to TS (#26390) 2020-11-09 13:57:53 -08:00
Samuel Attard
dcffa7449a
build: fix usage of octokit/rest and make uploading better (#26386) 2020-11-09 12:30:43 -08:00
David Sanders
e9cd227b5b
build: Python3 compat and Win line-endings fixes (#26091) 2020-10-30 19:05:38 +09:00
Charles Kerr
16caa54248
chore: tweak branch detection in release notes. (#25973) 2020-10-19 11:36:37 -07:00
David Sanders
c27e5fdbb6
chore: fix linter errors (#25996) 2020-10-19 20:55:27 +09:00
Jeremy Rose
603f9242d9
build: print upload script output (#25814) 2020-10-07 17:13:06 -07:00
Jeremy Rose
d64b9c20bd
build: fix mergeShasums (#25752) 2020-10-02 13:26:29 -07:00
Jeremy Rose
7027217dbb
build: use aws-sdk-js instead of boto (#25693) 2020-09-30 13:30:10 -07:00
Charles Kerr
515e85079f
chore: fix minor script warnings (#25575) 2020-09-23 13:21:34 -07:00
Charles Kerr
7f885bd266
chore: remove unused code from our js scripts (#25419) 2020-09-14 10:22:13 -07:00
Charles Kerr
9b08fbefe5
chore: remove unused imports in our python scripts (#25406)
Seen at https://lgtm.com/projects/g/electron/electron/?mode=list&id=py%2Funused-import
and confirmed with manual inspection.
2020-09-14 10:25:49 +09:00
Charles Kerr
4484e95fc8
chore: graceful handling of notes with sub-lists (#25279)
* chore: graceful handling of notes with sub-lists

Handle multine release notes that contain their own bullet points.

Also, if a release note begins with a bullet point, remove it because it
will confuse the markdown parser to have two bullet points.
2020-09-03 14:42:48 -05:00
Samuel Attard
075502477e
chore: we do not use the nightly tag on npm (#25147) 2020-08-27 12:11:27 -07:00
Samuel Attard
1646f938f3
Revert "refactor: use aws-sdk-js instead of boto (#24863)"
This reverts commit a3581aa992.
2020-08-22 16:42:45 -07:00
Samuel Attard
ab6769d7f8
build: upload windows breakpad symbols (#25000) 2020-08-17 14:52:08 -07:00
Jeremy Rose
a3581aa992
refactor: use aws-sdk-js instead of boto (#24863)
* refactor: use js instead of boto for s3put

* replace merge-electron-checksums.py with js, remove boto

* fix auth

* actually pass the env to execute()
2020-08-13 13:25:40 -04:00
Charles Kerr
7e84d3a2c1
build: in release notes script, do not assume electron dirname (#24927) 2020-08-10 16:56:54 -07:00
Shelley Vohr
16c32d2eb2
build: handle unhandled promise rejection in notes (#24923)
Handle any potential Git processes without throwing unhandled rejection errors.
2020-08-10 10:18:08 -07:00
Samuel Attard
854b74809a
build: upload the file stream not a JSON blob for the read stream (#24889) 2020-08-07 12:00:12 -07:00
Samuel Attard
4f4c383ec5
build: only do the lower case symbol copy on case sensitive file systems (#24876) 2020-08-06 10:39:24 -07:00
Samuel Attard
a2c82f2342
build: ensure symbol files are named lowercase on disk so that boto can find them (#24856) 2020-08-05 14:03:50 -07:00
Shelley Vohr
9274117e12
build: quash octokit deprecation warning (#24790) 2020-08-05 11:59:52 -04:00
Samuel Attard
06cb550c75
build: upload sentry src bundles on windows as well (#24773) 2020-07-29 12:41:53 -07:00
Charles Kerr
b39a5b71fe
chore: add trop annotations to release notes. (#24672)
Trop annotations are in the form of "(Also in 7.3, 8, 9)" with links to
the sibling branches.

Previously seen in b43e601b83 but is now
free of optional chaining and nullish coalescing, to run on Node < 14 :)
2020-07-27 10:01:41 -05:00
Samuel Attard
5795e59352
build: upload x-compiled arm mksnapshot only on linux (#24680)
* build: upload x-compiled arm mksnapshot only on linux

* Update upload.py
2020-07-22 01:45:18 -07:00
Samuel Attard
a76e74ac3f
Revert "chore: add Trop annotations to release notes. (#24644)"
This reverts commit b43e601b83.
2020-07-21 09:38:28 -07:00
Charles Kerr
b43e601b83
chore: add Trop annotations to release notes. (#24644)
* chore: add Trop annotations to release notes.

Trop annotations are in the form of "(Also in 7.3, 8, 9)"
with links to the sibling branches.
2020-07-21 10:32:36 -05:00
Samuel Attard
589968f9fc
build: add arm64 macOS publish jobs (#24652)
* build: add arm64 macOS publish jobs

* update ci-release-build to run new arm64 macOS publish jobs

* fixup circleci config validate issues

Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
2020-07-21 07:55:00 -04:00
Samuel Attard
f146a164af
build: add apple silicon support (#24545)
* chore: add patches to prevent installation of non-arm pip packages

* chore: add patches for apple-silicon

* build: add apple silicon build

* ci: add testing of new arm binary

* chore: remove / update for upstreamed patches

* Skip content tracing on macos on arm

* build: ensure that spec native modules are rebuilt for arm64 on apple-silicon

* chore: fix patches

* chore: fix broken patch

* chore: fix arm64 DCHECK

* build: add MAS arm64 build

* build: disable arm2 tests

* chore: update patches

* build: actually build MAS version of apple silicon app

Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
2020-07-17 09:08:44 -07:00
Samuel Attard
eb6616e4e9
build: update to standard 14 (#24479) 2020-07-09 10:18:49 -07:00
Charles Kerr
980e592271
chore: ensure release notes always come from Clerk (#23777)
* chore: ensure release notes always come from Clerk

Now with tests!

* chore: move sinon devDependency into `spec-main`

* refactor: tweak note-spec variable for readability
2020-06-08 11:39:44 -07:00
Samuel Attard
5ed2512881
fix: support 10-x-y in the release notes generator (#23709) 2020-05-21 13:55:27 -07:00
Charles Kerr
2342aaffbd
feat: look harder for a commit's pull request. (#23593)
PR numbers are almost always listed parenthetically in the commit message;
but when something is committed manually, it could be missing. This change
uses octokit's listPullRequestsAssociatedWithCommit() as a second approach
to finding a commit's PR.

Last night's Releases WG meeting noted that "re-enable pdf viewer" was
missing from the notes. This PR fixes that omission.
2020-05-14 18:50:39 -05:00
Charles Kerr
8bc6b81edc
Remove redundant release note items (#23335) 2020-04-30 17:00:59 -07:00
Shelley Vohr
e95075f2fe
build: fix nightly release copy (#23097) 2020-04-14 11:14:21 -04:00
Samuel Attard
0e86163a3e
build: rename atom.rc to electron.rc (#23098) 2020-04-13 14:28:59 -07:00
Andrea Brancaleoni
ff21444429
build: implement zip64 stripping (#22998)
When zip contains files larger than 4GB 4bytes length headers are
not sufficient anymore. Zip64 defines an extra header 0x0001 which
may contain 8byte lengthed (16 exabytes) lengths [uncompressed and compressed].

Read this value when performing extra data cleaning and override the
bogus value if the header is available.

Read https://blog.yaakov.online/zip64-go-big-or-go-home/ for more
information on Zip64 extra header.

This is the first known implementation of zip64 stripping.
2020-04-09 10:39:46 -07:00
Andrea Brancaleoni
884b46fce7
fix: strip extra data from release zips (#22891) 2020-04-01 10:14:41 -04:00
John Kleinschmidt
be5511393b
ci: use smaller vms for testing since we are using goma (#22887) 2020-03-30 15:46:42 -04:00
Samuel Attard
e678794dd0
build: fix beta version bumper logic for betas beyond 10 (#22810) 2020-03-24 09:04:12 -04:00
Samuel Attard
5d657dece4
build: enable JS semicolons (#22783) 2020-03-20 13:28:31 -07:00
Samuel Attard
b87b501161
build: update eslint + eslint plugins (#22777)
* build: run eslint --fix

* chore: manually fix all hasOwnProperty errors

* chore: manually fix all void 0 vs undefined errors

* chore: manually fix all async-in-promise errors

* chore: manually fix lexical declaration in case block
2020-03-20 11:12:18 -04:00
Shelley Vohr
c0374b5796
chore: don't delete nightly tag after draft (#22588) 2020-03-09 20:13:10 -07:00