Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	985d35fc1c 
 
						 
						
							
							
								
								
								fix: update deprecated NSWindow masks ( #14760 )  
							
							
							
						 
						
							2018-09-26 16:00:57 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Aleksei Kuzmin 
								
							 
						 
						
							
							
								
							
							
	7fc3bcaa02  
						 
						
							
							
								
								
								chore: run clang-format  
							
							... 
							
							
							
							- atom/
 - brightray/
 - chromium_src/ 
							
						 
						
							2018-09-19 17:18:10 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Robo 
								
							 
						 
						
							
							
								
							
							
	2cd03bf360  
						 
						
							
							
								
								
								build: remove duplicate devtools sources ( #14522 )  
							
							... 
							
							
							
							* build: remove duplicate devtools sources
* build: create separate target for chrome sources
* Move sources that are always depended on by electron,
  starting with security_state_tab_helper.{cc|h}
* Add //component/strings to pak for devtools security tab
* fix: allow specifying type of the added filesystem.
https://chromium-review.googlesource.com/c/chromium/src/+/729250 
* fix: do not index excluded folders
https://chromium-review.googlesource.com/c/chromium/src/+/972579  
							
						 
						
							2018-09-12 08:45:08 -05:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	dd5b8769be  
						 
						
							
							
								
								
								fix: use OOPIF for webview tag ( #13869 )  
							
							... 
							
							
							
							* fix: use OOIF for webview tag
* fix: do not call GetNativeView for webview
* fix: OOIPF webview's WebContents is managed by embedder frame
* fix: guest view can not be focused
* fix: clear zoom controller when guest is destroyed
* fix: implement the webview resize event
The webview is no longer a browser plugin with the resize event, use
ResizeObserver instead.
* test: disable failed tests due to OOPIF webview
* fix: embedder can be destroyed earlier than guest
This happens when embedder is manually destroyed.
* fix: don't double attach
* fix: recreate iframe when webview is reattached
* fix: resize event may happen very early
* test: some tests are working after OOPIF webview
* chore: remove unused browser plugin webview code
* fix: get embedder via closure
When the "destroyed" event is emitted, the entry in guestInstances would be
cleared.
* chore: rename browserPluginNode to internalElement
* test: make the visibilityState test more robust
* chore: guestinstance can not work with OOPIF webview
* fix: element could be detached before got response from browser 
							
						 
						
							2018-08-16 15:57:40 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Sidney 
								
							 
						 
						
							
							
								
							
							
	23541b5b2a  
						 
						
							
							
								
								
								feat: On macOS, Closing Notifications Triggers the 'close' Event ( #13306 )  
							
							... 
							
							
							
							* feat(macOS): implement NotificationDismissed() for Cocoa
* feat(macOS): emit NotificationDismissed() when closing "Alert" notifications
* feat(macOS): emit NotificationDismissed() when closing "Banner" notifications
* fix(macos): Remove calls to private APIs from MAS builds (github.com/electron/electron/pull/13306) 
							
						 
						
							2018-08-13 23:09:25 +12:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	79fbd6bab1  
						 
						
							
							
								
								
								Revert "fix: Drop support for OS X Mavericks (version 10.9)" ( #13333 )  
							
							
							
						 
						
							2018-06-20 07:27:55 -05:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	794fe741e9  
						 
						
							
							
								
								
								fix: Drop support for OS X Mavericks (version 10.9)  
							
							
							
						 
						
							2018-06-19 17:49:27 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	12a57ff1c2  
						 
						
							
							
								
								
								clang-format objc files ( #12673 )  
							
							
							
						 
						
							2018-04-20 11:47:04 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Apthorp 
								
							 
						 
						
							
							
								
							
							
	f3c00e96aa  
						 
						
							
							
								
								
								Bring mac code into conformance with -Wunguarded-availability  
							
							
							
						 
						
							2018-04-19 11:12:58 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Apthorp 
								
							 
						 
						
							
							
								
							
							
	e6695cf2ec  
						 
						
							
							
								
								
								[chromium-style] override / virtual warnings  
							
							
							
						 
						
							2018-04-19 11:12:10 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Apthorp 
								
							 
						 
						
							
							
								
							
							
	a635f078c6  
						 
						
							
							
								
								
								[chromium-style] auto variable type must not deduce to a raw pointer type  
							
							
							
						 
						
							2018-04-19 11:10:52 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	284aca68c0 
 
						 
						
							
							
								
								
								clang-format brightray  
							
							
							
						 
						
							2018-04-17 21:46:27 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	
	
	af92b04eb9 
 
						 
						
							
							
								
								
								Merge pull request  #11654  from sethlu/set-notification-close-button-text  
							
							... 
							
							
							
							feat: Set macOS notification close button title 
							
						 
						
							2018-02-15 16:01:30 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Zhuo Lu 
								
							 
						 
						
							
							
								
							
							
	0b7a629a41  
						 
						
							
							
								
								
								Overload method for naming consistency  
							
							
							
						 
						
							2018-02-10 03:20:20 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Zhuo Lu 
								
							 
						 
						
							
							
								
							
							
	75b990faff  
						 
						
							
							
								
								
								Use std::string::empty to check  
							
							
							
						 
						
							2018-02-10 03:20:20 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Zhuo Lu 
								
							 
						 
						
							
							
								
							
							
	1e1087abbb  
						 
						
							
							
								
								
								Simplify formatting  
							
							
							
						 
						
							2018-02-10 03:20:20 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Zhuo Lu 
								
							 
						 
						
							
							
								
							
							
	31baafab3b  
						 
						
							
							
								
								
								NSUserNotification should respond  
							
							... 
							
							
							
							NSUserNotification is expected to responsd to `@selector(setContentImage:)` with macOS ^10.9 
							
						 
						
							2018-02-10 03:20:20 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Zhuo Lu 
								
							 
						 
						
							
							
								
							
							
	09d51f0a3d  
						 
						
							
							
								
								
								Fix include order  
							
							
							
						 
						
							2018-02-10 03:20:20 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Zhuo Lu 
								
							 
						 
						
							
							
								
							
							
	844ee0a3f4  
						 
						
							
							
								
								
								Accept additional notification actions  
							
							... 
							
							
							
							Change to the existing API definition: The first action with type `button` seen will be displayed on the notification, the rest listed as additional actions (shown when holding down on the primary action button) 
							
						 
						
							2018-02-10 03:20:20 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Zhuo Lu 
								
							 
						 
						
							
							
								
							
							
	be118d4f13  
						 
						
							
							
								
								
								Make it able to set close button text  
							
							
							
						 
						
							2018-02-10 03:19:47 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Felix Rieseberg 
								
							 
						 
						
							
							
								
							
							
	76d9756fb9  
						 
						
							
							
								
								
								🔧  Use LOG instead of NSLOG  
							
							
							
						 
						
							2017-12-13 14:47:23 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Felix Rieseberg 
								
							 
						 
						
							
							
								
							
							
	61ec8df418  
						 
						
							
							
								
								
								🔧  More detailed macOS notification logging  
							
							
							
						 
						
							2017-12-13 10:31:59 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Felix Rieseberg 
								
							 
						 
						
							
							
								
							
							
	ffd85bfaac  
						 
						
							
							
								
								
								🔧  Allow notifications debugging (macOS)  
							
							
							
						 
						
							2017-12-12 16:09:34 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Heilig Benedek 
								
							 
						 
						
							
							
								
							
							
	573f664899  
						 
						
							
							
								
								
								fix devtools again  
							
							
							
						 
						
							2017-11-13 15:50:49 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Heilig Benedek 
								
							 
						 
						
							
							
								
							
							
	5373afa472  
						 
						
							
							
								
								
								set devtools window to visible to avoid a visual glitch on mac with osr window's devtools  
							
							
							
						 
						
							2017-11-13 15:46:46 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Heilig Benedek 
								
							 
						 
						
							
							
								
							
							
	45d16d5add  
						 
						
							
							
								
								
								don't automatically show window when devtools is opened on mac  
							
							
							
						 
						
							2017-11-13 15:46:46 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	85ef4c6d91  
						 
						
							
							
								
								
								Ensure the click event is only dispatched on ContentsClicked activation type  
							
							
							
						 
						
							2017-10-27 16:08:15 +13:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	e5d4574d3a  
						 
						
							
							
								
								
								Use NSUserNotification identifiers to uniquely find the correct notification from CocoaNotification  
							
							
							
						 
						
							2017-10-07 14:51:28 +11:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Charlie Hess 
								
							 
						 
						
							
							
								
							
							
	
	
	2b9b186fd1 
 
						 
						
							
							
								
								
								Rename soundName → sound.  
							
							
							
						 
						
							2017-08-17 17:28:14 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Charlie Hess 
								
							 
						 
						
							
							
								
							
							
	
	
	0cfae1cc2b 
 
						 
						
							
							
								
								
								Plumb in the macOS soundName property for notifications.  
							
							
							
						 
						
							2017-08-17 13:31:20 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	a196bf97bc  
						 
						
							
							
								
								
								🍎  Add subtitle to Notification properties  
							
							
							
						 
						
							2017-06-30 16:54:28 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	3774482859  
						 
						
							
							
								
								
								Update notification PR as per feedback  
							
							
							
						 
						
							2017-06-28 17:00:19 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	7eb14243eb  
						 
						
							
							
								
								
								Refactor notification options  
							
							
							
						 
						
							2017-06-24 21:39:06 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	17e737eba2  
						 
						
							
							
								
								
								s/label/text  
							
							
							
						 
						
							2017-06-23 21:04:39 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	4f0d48f164  
						 
						
							
							
								
								
								Add support for notification actions on macOS  
							
							
							
						 
						
							2017-06-23 20:50:20 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	5fa2831756  
						 
						
							
							
								
								
								Coding style fixes  
							
							
							
						 
						
							2017-05-31 16:17:29 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	227a2bd5dc 
 
						 
						
							
							
								
								
								Fix reference typed reply placeholder  
							
							
							
						 
						
							2017-05-30 20:29:27 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	3938373ecb 
 
						 
						
							
							
								
								
								Fix linting errors and add isSupported  
							
							
							
						 
						
							2017-05-30 20:27:24 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	5048425e6e 
 
						 
						
							
							
								
								
								Update implementation as per feedback  
							
							
							
						 
						
							2017-05-30 19:06:51 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	9aa6b83f86  
						 
						
							
							
								
								
								Fix compilation and click events on macOS  
							
							
							
						 
						
							2017-05-29 21:22:44 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	058bdfbced  
						 
						
							
							
								
								
								Use NotificationPresenter - macOS  
							
							
							
						 
						
							2017-05-29 20:02:33 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	d7321ed980  
						 
						
							
							
								
								
								Add brightray prefix to include paths from within brightray  
							
							
							
						 
						
							2017-05-19 08:46:15 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	c4608c0f37  
						 
						
							
							
								
								
								Fix build/include_alpha linter violations in brightray  
							
							
							
						 
						
							2017-05-19 08:46:15 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	f193b2b2a6  
						 
						
							
							
								
								
								Fix build/include_what_you_use linter violations in brightray  
							
							
							
						 
						
							2017-05-19 08:46:15 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	cfb5b6ac89  
						 
						
							
							
								
								
								Fix build/header_guard linter violations in brightray  
							
							
							
						 
						
							2017-05-19 08:46:15 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	c6190dc094  
						 
						
							
							
								
								
								Remove unused BRYApplication class  
							
							
							
						 
						
							2017-05-19 08:46:15 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Ales Pergl 
								
							 
						 
						
							
							
								
							
							
	0bba5b9b41  
						 
						
							
							
								
								
								Address cpplint issue "Lines should be <= 80 characters long  [whitespace/line_length] [2]"  
							
							
							
						 
						
							2017-04-05 14:30:15 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Ales Pergl 
								
							 
						 
						
							
							
								
							
							
	e6a30388da  
						 
						
							
							
								
								
								Make Notification factory function a member of NotificationPresenter so that we can create different types of notifications based on runtime conditions.  
							
							
							
						 
						
							2017-04-05 14:30:15 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Haojian Wu 
								
							 
						 
						
							
							
								
							
							
	e4c571fc68  
						 
						
							
							
								
								
								Remove unused using namespace declaration.  
							
							
							
						 
						
							2017-03-30 21:49:15 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	0a5f7171d4  
						 
						
							
							
								
								
								Add more guards around null notification  
							
							
							
						 
						
							2016-10-28 10:54:55 -07:00