electron

Author	SHA1	Message	Date
John Kleinschmidt	4ce7ca6cfb	test: disable flaky arm tests (#26046 ) * tests: disable flaking test on all arm platforms * tests: disable flaky did-change-theme-color tests on WOA	2020-10-19 20:11:30 -04:00
Milan Burda	decb1eb87b	feat: add serviceName to 'child-process-gone' / app.getAppMetrics() (#25975 )	2020-10-19 14:55:47 +03:00
Lishid	05b5c197ae	feat: Expose renderer spellcheck API (#25060 )	2020-10-19 20:48:16 +09:00
Electron Bot	46f3491c7d	chore: bump chromium to 6b9fa6b352d824d052222e1abe541 (master) (#25558 ) * chore: bump chromium in DEPS to d5c9bf9e2a18fa508201a88e5803bec1d107b1ae * chore: bump chromium in DEPS to 45f1316afae33e52c92480b34bf4f7fe4a7db898 * update patches * WillCreateURLLoaderFactory now gets a ukm_source_id Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2346803 * ink_drop_visible_opacity -> GetInkDropVisibleOpacity Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415368 * chore: bump chromium in DEPS to ddb5b6db5e35ab1a7b5adbd9f15373af6c35ea2a * 2418471: PDF Viewer update: Add missing aria-labels to various buttons. https://chromium-review.googlesource.com/c/chromium/src/+/2418471 * update printing.patch given print settings mojoification Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2409467 * update patches * content::BluetoothChooser::Event -> content::BluetoothChooserEvent Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2387901 * set_ink_drop_base_color -> SetInkDropBaseColor Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2419388 * chore: bump chromium in DEPS to ecf7c9ee830d4d85f300b461a2fa13aa40c79a4c * update patches * gfx::ConvertPointToPixel -> gfx::ConvertPointToPixels Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2418568 * remove ContentSettingsObserver::AllowStorage() Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2401847 * service_manager::kCrashDumpSignal -> kCrashDumpSignal Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2417073 * chore: bump chromium in DEPS to abdb7ebe5f8c8328b8f435283df90d0a3ecff7bd * chore: bump chromium in DEPS to 2a7e138ab1066534ceb2622e8a9d2c8ebf574215 * chore: bump chromium in DEPS to ab1884e75ced904e4276851eb4e1ad89919ca93b * chore: bump chromium in DEPS to a12413902380dcc2a73ac74d582328280a8af686 * Fixup printing patch https://chromium-review.googlesource.com/c/chromium/src/+/2428623 * Fixup OSR patch https://chromium-review.googlesource.com/c/chromium/src/+/2415128 * Make ExtensionURLLoaderFactory always owned by its \|receivers_\|. https://chromium-review.googlesource.com/c/chromium/src/+/2357523 * Add deprecated_default_sources_assignment_filter variable https://chromium-review.googlesource.com/c/chromium/src/+/2416496 * Fixup patch indices * Remove several references to BrowserPlugin from content https://chromium-review.googlesource.com/c/chromium/src/+/2401031 * Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation https://chromium-review.googlesource.com/c/chromium/src/+/2415128 * Add DragOperation and AllowedDragOperations Mojo types https://chromium-review.googlesource.com/c/chromium/src/+/2196167 * chore: bump chromium in DEPS to 378450342cf6aa160663d0ce3a178a11b570c25a * Fixup patch indices * Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation https://chromium-review.googlesource.com/c/chromium/src/+/2415128 * Add DragOperation and AllowedDragOperations Mojo types https://chromium-review.googlesource.com/c/chromium/src/+/2196167 * 2426564: Remove global sources assignment filter value https://chromium-review.googlesource.com/c/chromium/src/+/2426564 * Fixup blink_local_frame.patch * [XProto] Remove a subset of ui/gfx/x/x11.h https://chromium-review.googlesource.com/c/chromium/src/+/2430328 * Fixup patch indices * Remove several references to BrowserPlugin from content https://chromium-review.googlesource.com/c/chromium/src/+/2401031 * Remove lossy ConvertSizeToPixel() methods https://chromium-review.googlesource.com/c/chromium/src/+/2419534 * serial: Use USB driver name to disambiguate ports https://chromium-review.googlesource.com/c/chromium/src/+/2413176 * Remove set_sources_filter import * Fix ModMask usage * [XProto] Remove usage of all Xlib headers https://chromium-review.googlesource.com/c/chromium/src/+/2392140 * [XProto] Remove usage of Xlib Visuals https://chromium-review.googlesource.com/c/chromium/src/+/2429933 * Skip Angle manifest file https://chromium-review.googlesource.com/c/angle/angle/+/2425197 * Add whole src\third_party\angle\.git directory This directory is needed in order to properly generate gen/angle/angle_commit.h * [libvpx] Fix HighBD config on Windows ARM64 https://chromium-review.googlesource.com/c/chromium/src/+/2437745 * update patches * fix: correct calling convention for Windows on Arm https://chromium-review.googlesource.com/c/v8/v8/+/2440717 * Add third_party/angle/.git to the archive before adding the rest of the source * fixup source caching on Windows * Fixup erroneous close paren * fixup for goma issues * This should work * chore: bump chromium roll manually https://chromium-review.googlesource.com/c/chromium/src/+/2435142 This landed the day after we paused roller-bot and may resolve the visibility test flakes that we're seeing. h/t to @jkleinsc for finding this with me. * chore: remove obsoleted cherry-pick fix for libvpx https://chromium-review.googlesource.com/c/chromium/src/+/2437745 * chore: remove obsoleted cherry-pick libvpx patch https://chromium-review.googlesource.com/c/chromium/src/+/2437745 * chore: re-export patches * chore: add tracer comment to visibility-stat-spec. The line numbers between the source and the CI runs don't seem to match up, so this temp tracer is to help track the source of that difference. * chore: bump chromium in DEPS to 7c2b8cc3b8638aee8abeb013042a6c1d15b2da6b * update patches * impl SortingLSH service Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2425327 * 2446525: [Flash] Remove some Flash APIs https://chromium-review.googlesource.com/c/chromium/src/+/2446525 * 2440974: Reland "Delete service_manager/embedder/switches.h" https://chromium-review.googlesource.com/c/chromium/src/+/2440974 * 2359402: Remove ContentBrowserClient::NonNetworkURLLoaderFactoryDeprecatedMap. https://chromium-review.googlesource.com/c/chromium/src/+/2359402 * 2250506: Implement tabs.removeCSS https://chromium-review.googlesource.com/c/chromium/src/+/2250506 * 2429143: Remove implicit-conversion-to-integer ConvertRectToPixel() methods. https://chromium-review.googlesource.com/c/chromium/src/+/2429143 * 2444430: Remove DataElementType::kBlob https://chromium-review.googlesource.com/c/chromium/src/+/2444430 * 2441964: Clean up WebView public API https://chromium-review.googlesource.com/c/chromium/src/+/2441964 * 2357523: Make ExtensionURLLoaderFactory always owned by its \|receivers_\|. https://chromium-review.googlesource.com/c/chromium/src/+/2357523 * 2461606: Use blink::mojom::PreferredColorScheme instead of blink::PreferredColorScheme https://chromium-review.googlesource.com/c/chromium/src/+/2461606 * 2461235: a11y inspect reorg: move PropertyFilter struct to a new location https://chromium-review.googlesource.com/c/chromium/src/+/2461235 * remove flash support * fix frame_host_manager patch * fix lint * remove flash info from docs * fix build * fix osr * chore: bump chromium in DEPS to 9269f9eb1d98d29564c2b2ab97f30c6e148c4e11 * fix visibilityState tests * 2463049: Replace all uses of web_pref::AutoplayPolicy with mojom::AutoplayPolicy https://chromium-review.googlesource.com/c/chromium/src/+/2463049 * update patches * fix tests harder * 2414921: Add Group and Ungroup functions to Tabs extension API https://chromium-review.googlesource.com/c/chromium/src/+/2414921 * more test fix * Remove all keyboard related usage of Xlib Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2436787 * fix linux build * 2453807: [XProto] Remove usage of Xlib error handling https://chromium-review.googlesource.com/c/chromium/src/+/2453807 * lint * fixup! 2453807: [XProto] Remove usage of Xlib error handling * disable CalculateNativeWinOcclusion on win ci * remove UploadBlob from docs * Update appveyor.yml Co-authored-by: Andy Locascio <andy@slack-corp.com> Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Jeremy Rose <nornagon@nornagon.net> Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: Jeremy Rose <jeremya@chromium.org>	2020-10-15 18:30:41 -07:00
Milan Burda	2c68bad631	refactor: create IPC_MESSAGES enum for IPC message channels (#25694 )	2020-10-14 00:11:06 +03:00
Shelley Vohr	e8166db9d7	fix: uv loop polling when render process reuse enabled (#25869 )	2020-10-13 09:19:44 -07:00
Samuel Attard	501900cdc6	fix: update squirrel.mac to handle bug in Big Sur (#25864 ) Fixes #25626 This is not the greatest workaround but at least it works.	2020-10-13 11:01:49 +09:00
Jeremy Rose	cbe751d349	fix: NativeImage.getScaleFactors returns correct scales (#25832 ) * fix: NativeImage.getScaleFactors returns correct scales * fix tests	2020-10-13 10:59:18 +09:00
Samuel Maddock	704d69a8f9	feat: add webFrameMain API to the main process (#25464 )	2020-10-09 09:50:46 -07:00
Milan Burda	fb11a12d5b	refactor: replace a few any-s with proper types (#25681 )	2020-10-08 03:01:23 +02:00
CezaryKulakowski	73adeef877	fix: window.open doesn't work correctly in child window (#25080 ) If speculative render view host is deleted during naviagation to page we try to open with call to window.open window is destroyed right after it is created. It may happen when naviagation triggers redirect from http to https. To void that we should emit event current-render-view-deleted only when render view host which was destroyed is the current webcontent's rvh.	2020-10-07 16:11:19 -07:00
Milan Burda	65089a69a1	test: improve app 'session-created' event spec (#25799 )	2020-10-07 15:59:27 +02:00
marcin-prochownik	fec1c0b68b	fix: passing content-length down the stream for intercepted requests (#25324 ) * fix: pass content length if avilable in headers * fix: fixed unit test after changes video is being played for standard scheme when content-length is available * fix: fixed review remakrs added is_string check and changed stol to StringToInt64 * fix: fix test case name * fix: fixed typo	2020-10-06 09:53:13 +09:00
Keeley Hammond	6356cd4018	fix: allow ClientRequest responses to be throttled (#25531 ) * fix: allow net streams to be throttled [WIP] * fix: handle resume throttling within IncomingMessage [WIP] * fix: fix urlLoader typing, add throttle test * fix: fix lint and increase test timeout for Linux * fix: increase test chunk limit to 20 and timeout to 2000 Co-authored-by: Jeremy Rose <nornagon@nornagon.net>	2020-10-06 09:47:41 +09:00
Cheng Zhao	57dc170e81	fix: no more need to hijack process.stdout on Win32 (#25765 )	2020-10-05 10:10:38 -07:00
Milan Burda	508b8d902b	chore: move remote module fixtures for easier deletion when removed (#25736 )	2020-10-05 10:22:35 +09:00
Samuel Attard	a189dc779e	feat: add webContents.forcefullyCrashRenderer() to forcefully terminate a renderer process (#25580 ) * feat: add webContents.forcefullyCrashRenderer() to forcefully terminate a renderer process * chore: fix up docs and tests	2020-10-02 14:50:24 -07:00
bitdisaster	b43859f098	feat: custom toast xml and failure reporting for notifications (#25401 ) * allow custom toast xml and report failures * docs * tests * don't use namespaces * lint doesn't like trailing commas * addressing feedback	2020-09-29 12:20:10 -07:00
Jeremy Rose	0e7d59dd79	feat: [net] add "credentials" option to net.request (#25284 ) * feat: [net] add "credentials" option to net.request * remove debugging log * add tests	2020-09-29 12:03:33 -04:00
John Kleinschmidt	fd63510ca9	feat: add serial api support (#25237 ) * feat: add serial api support resolves #22478 * Put serial port support behind a flag and mark as experimental * Update docs/api/session.md Co-authored-by: Jeremy Rose <jeremya@chromium.org> * Use enable-blink-features=Serial instead of enable-experimental-web-platform-features * Set enableBlinkFeatures on webPreferences instead of commandline Co-authored-by: Jeremy Rose <jeremya@chromium.org>	2020-09-28 12:22:03 -04:00
Charles Kerr	515e85079f	chore: fix minor script warnings (#25575 )	2020-09-23 13:21:34 -07:00
Samuel Maddock	9d0d9a1664	feat(extensions): expose ExtensionRegistryObserver events in Session (#25385 ) * feat(extensions): expose ExtensionRegistryObserver events in Session Extensions can be loaded and unloaded for various reasons. In some cases this can occur by no means of the Electron programmer, such as in the case of chrome.runtime.reload(). In order to be able to manage state about extensions outside of Electron's APIs, events reloaded to loading and unloaded are needed. * docs(extensions): elaborate on extension-loaded/unloaded details * fix: remove scoped extension registry observer * docs: update extension-unloaded	2020-09-23 15:29:08 -04:00
Samuel Attard	3503d3745b	fix: order menu items before filtering excess separators (#25563 )	2020-09-23 10:39:08 -07:00
Electron Bot	69f1731bbb	chore: bump chromium to ec5bc1743792d64724693eb357083 (master) (#24984 ) * chore: bump chromium in DEPS to cbdeef954dfc34e94c8ca9cf72ad326b4a121158 * chore: bump chromium in DEPS to 29723f905baeab1d4228eef2c31cdb341ebeffe0 * chore: bump chromium in DEPS to 44d6d78e852137fff58c14ed26ab1e803e5bf822 * update patches * chore: bump chromium in DEPS to 8a3a0fccb39d6b8334c9a0496c0d5056e50cdb3f * chore: update patches * refactor: fix PrintBackend::CreateInstance() calls Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2354541 * chore: bump chromium in DEPS to b9ebec3bcb1cabdd1426f367636f54cc98e0500e * chore: remove patches to code that was deleted upstream CL: https://chromium-review.googlesource.com/c/chromium/src/+/2360314 * Remove uses of kCGColorSpaceITUR_2020_PQ_EOTF/HLG CL: https://chromium-review.googlesource.com/c/chromium/src/+/2363950 just garden variety code shear * chore: update patch indices * Move ColorModel to //printing/mojom/print.mojom https://chromium-review.googlesource.com/c/chromium/src/+/2355083 sync with printing ColorModel changes: moved to mojo, different naming scheme * chore: bump chromium in DEPS to 56c4b4d2ce5ba941acd2e0fdb5100e8a48847134 * chore: bump chromium in DEPS to 130501f220b684a79dc82c17e236e63ac1f2a093 * Convert PrintHostMsg_DidGetPrintedPagesCount to Mojo https://chromium-review.googlesource.com/c/chromium/src/+/2326857 Update argument list to Print() * chore: update patch indices * DumpAccTree: convert utf16 to utf8 in PropertyFilter https://chromium-review.googlesource.com/c/chromium/src/+/2360218 * chore: bump chromium in DEPS to 3058368c6646e0dc8be6f8ea838b0343428b7998 * chore: bump chromium in DEPS to f51b4e6555364363c61438dac7afd988c8347bfc * chore: bump chromium in DEPS to 2dcc6f8fc23ac41b2499eb69dee0b4017e9d1046 * update patches * chore: bump chromium in DEPS to 2d8e98ecedc7e4905540b053bc1c87e964715be5 * update patches * 2345900: Move content::RecordContentToVisibleTimeRequest struct to mojo https://chromium-review.googlesource.com/c/chromium/src/+/2345900 * update patches * 2345900: Move content::RecordContentToVisibleTimeRequest struct to mojo https://chromium-review.googlesource.com/c/chromium/src/+/2345900 * 2367394: Remove net::LOAD_DO_NOT_SEND_COOKIES and net::LOAD_DO_NOT_SEND_AUTH_DATA. https://chromium-review.googlesource.com/c/chromium/src/+/2367394 * 2373227: [XProto] Consolidate all <X11/> includes to //ui/gfx/x/x11.h https://chromium-review.googlesource.com/c/chromium/src/+/2373227 fixup! 2373227: [XProto] Consolidate all <X11/> includes to //ui/gfx/x/x11.h chore: bump chromium in DEPS to c090e3f960520cbd2328608b97f87238c76d6143 * update patches * chore: bump chromium in DEPS to 13a25e0a755de9a14271022c595f3d2e29829e1a * chore: bump chromium in DEPS to 6adbb767b012c41efaeab0d1bdbb3eefed0977bc * chore: bump chromium in DEPS to 339ec5455c5932ef1322ea9953a6349b0732199e * chore: bump chromium in DEPS to 20291807c33f7ef4ef4f57d62075e099b027bfe6 * chore: bump chromium in DEPS to 226fbd1b8b17d4ac84fdb9548ef3a1c646878d47 * update patches * fixup disable_color_correct_rendering patch * chore: bump chromium in DEPS to 577c45979cad4359f2e206d68efd9317d3d79315 * update patches * viz: Rename RenderPass to CompositorRenderPass (and related types). https://chromium-review.googlesource.com/c/chromium/src/+/2380730 * chore: bump chromium in DEPS to 37e2ad5303f2c03a1b5d8eda65341bf2561196cd * update patches * add kOmitCookies_Electron * update patch * chore: bump chromium in DEPS to 256e42409ea63a7e71016de07818a983a97db463 * update patches * fix worker script ready hook https://chromium-review.googlesource.com/c/chromium/src/+/2335713 * Fixup printing page ranges patch * [printing] Move PrintMsg_PrintPages_Params to print.mojom https://chromium-review.googlesource.com/c/chromium/src/+/2340854 * Add MIME sniffer overloads that take base::StringPieces https://chromium-review.googlesource.com/c/chromium/src/+/2382896 * [printing] Move PrintHostMsg_PreviewIds to print.mojom https://chromium-review.googlesource.com/c/chromium/src/+/2379455 * fixup test due to new DCHECK https://chromium-review.googlesource.com/c/chromium/src/+/2333750 * stop sending cookies when useSessionCookies is false * chore: bump chromium in DEPS to dd429dbc556449951ee8160d8a4d61fd95a139d5 * update patches * chore: bump chromium in DEPS to 5202bde3f9f44c2065f5dacf27e7000dd19e4e4d * chore: bump chromium in DEPS to 099e8e07b89da65932431bb0fd51b6f7f5344c19 * chore: bump chromium in DEPS to 104e5da2a43b759732d5b94bfc750b3a9a639653 * chore: bump chromium in DEPS to a4519ce657af25834e355315fd7fefa77b13426a * update patches * Make FileURLLoaderFactory always owned by its \|receivers_\|. https://chromium-review.googlesource.com/c/chromium/src/+/2337411 * Make FileURLLoaderFactory always owned by its \|receivers_\|. https://chromium-review.googlesource.com/c/chromium/src/+/2337411 * chore: bump chromium in DEPS to 1b62e9e8c8eaf6b8e3a9c77ee67a4c1bfa6a4d6b * chore: update patches * fixup! Make FileURLLoaderFactory always owned by its \|receivers_\|. * chore: update patches - mac: Disable CoreServices _CSCheckFix. https://chromium-review.googlesource.com/c/chromium/src/+/2401334 - [XProto] Remove bad DCHECK in x11_error_tracker.cc https://chromium-review.googlesource.com/c/chromium/src/+/2402304 - Move content/browser/frame_host/* over to content/browser/renderer_host/ https://chromium-review.googlesource.com/c/chromium/src/+/2401303 * Refactor WebContentSettingsClient to dedupe AllowXYZ methods https://chromium-review.googlesource.com/c/chromium/src/+/2353552 * Introduce NonNetworkURLLoaderFactoryBase class. https://chromium-review.googlesource.com/c/chromium/src/+/2357559 * [XProto] Remove usage of all Xlib headers https://chromium-review.googlesource.com/c/chromium/src/+/2392140 * fixup! chore: update patches * chore: bump chromium in DEPS to c1df55fbeb8207d036a604f59e4ea4e8ee79930a * chore: update patches * Move content::WebPreferences struct to Blink https://chromium-review.googlesource.com/c/chromium/src/+/2397670 * chore: bump chromium in DEPS to 57a23ec4884fff6c2f8d9b8536131cdc9b551ec2 * Set appid on Pip windows. https://chromium-review.googlesource.com/c/chromium/src/+/2388274 * fixup! Set appid on Pip windows. * fix: add a patch to remove deprecated factory * chore: bump chromium in DEPS to 1a9ddb7ea43955877823d5c4dcbf241b64228635 * fix compilation on windows * chore: bump chromium in DEPS to 234e6c6a77f61ffad9335099d9b13892cf88fd44 * chore: update patches * chore: bump chromium in DEPS to 7631eb0a9f57a8a47d3c28e1d265961b3a4d6b2b * chore: update patches * chore: bump chromium in DEPS to f9c34cd485845b95c2d17a7f55fdf92cda9a1b3a * chore: update patches * chore: implement GetSurveyAPIKey Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2362182 * chore: replace CreateWebUIURLLoader with CreateWebUIURLLoaderFactory Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2358309 * chore: bump chromium in DEPS to 5bdbd2373da884adf41c087be1465fcc344d168c * chore: update node patches for common.gypi * chore: update patches * chore: non_network_url_loader_factory_base was moved Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2357431 * 2415752: Reland "Reland "OOR-CORS: Remove BlinkCORS supporting code outside Blink"" Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415752 * chore: bump chromium in DEPS to b943d006a33ec5bc1743792d64724693eb357083 * fix: replace x11::None with x11::Window::None * chore: update patches * chore: update patches * fix: cast x11::Window to int * 2402123: Use end date when deleting http auth cache Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2402123 * 2320268: Migrate DragHostMsg_StartDragging to Mojo Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2320268 * 2401303: Move content/browser/frame_host/* over to content/browser/renderer_host/ https://chromium-review.googlesource.com/c/chromium/src/+/2401303 * chore: fix lint * chore: fix build * Update config.yml Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Jeremy Rose <nornagon@nornagon.net> Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: Samuel Attard <sattard@slack-corp.com>	2020-09-21 01:00:36 -07:00
Shelley Vohr	a65f7f7d42	fix: close window when leave fs crash (#25468 )	2020-09-17 17:40:07 -06:00
Shelley Vohr	77038b7bda	chore: upgrade to Node.js v14.9.0 (#25249 )	2020-09-17 16:08:57 -06:00
Cheng Zhao	0b055b2fb8	test: retry the "v8 samples" test for a few times (#25477 )	2020-09-17 10:04:53 +09:00
mlaurencin	53aaeb7a16	fix: prevent destroyed view references from causing crashes (#25411 ) Closes #21666. This PR is fixing crashes caused by referencing and attempting to modify previously destroyed views. Before, when a view was destroyed and then the contents were referenced for modification, the system would crash as undefined memory was accessed. This fix explicitly makes the pointer to the destroyed view's contents null, so that this will not happen.	2020-09-16 18:10:49 -06:00
Cheng Zhao	993eab691f	fix: disable CORS when webSecurity is disabled (#25463 )	2020-09-16 14:55:53 -07:00
Jeremy Rose	ba55aaa53b	fix: check for destroyed webcontents in converter (#25431 )	2020-09-16 12:25:49 -07:00
Cheng Zhao	e5933c6910	fix: ensure ready-to-show event is fired (#25448 ) * fix: ensure ready-to-show event is fired * test: acutally draw something when capturePage	2020-09-15 12:48:39 -06:00
Cheng Zhao	2091fd7dd9	test: make a few tests hide their windows (#25466 )	2020-09-15 12:48:12 -06:00
Samuel Maddock	45170fdbd7	fix(extensions): define platform info to prevent renderer crash (#25357 )	2020-09-15 10:29:32 -06:00
Jeremy Rose	87d67a9365	refactor: use owner window for BrowserWindow.fromWebContents (#25408 )	2020-09-14 13:49:57 -07:00
Jeremy Rose	9f4a097e03	feat: remove getMediaSourceIdForWebContents() (#25414 ) This reverts commit `204f001c5d`.	2020-09-14 10:38:05 -07:00
Jeremy Rose	cd455c8b40	test: reduce flakiness in pdf test (#25407 )	2020-09-10 16:47:36 -07:00
Jeremy Rose	dd781c4f63	chore: deprecate remote (#25293 )	2020-09-10 09:17:17 -07:00
Samuel Maddock	5a8046c994	fix(extensions): devtools now open for background pages (#22217 ) refactor(extensions): remove unused InitWithBrowserContext method fix(extensions): release background page WebContents to avoid crash The background page WebContents instance is managed by the ExtensionHost. fix(extensions): open background page devtools detached by default test(extensions): add background page devtools test chore: test fix for null web_contents() fix: close background page devtools in test after opening	2020-09-08 20:55:40 +09:00
Jeremy Rose	4dc09ea9dc	feat: [crashReporter] enable compression by default (#25288 )	2020-09-03 12:43:58 -07:00
Charles Kerr	4484e95fc8	chore: graceful handling of notes with sub-lists (#25279 ) * chore: graceful handling of notes with sub-lists Handle multine release notes that contain their own bullet points. Also, if a release note begins with a bullet point, remove it because it will confuse the markdown parser to have two bullet points.	2020-09-03 14:42:48 -05:00
Cheng Zhao	43485b8705	fix: multiple dock icons when calling dock.show/hide (#25269 ) * fix: mulitple dock icons when calling dock.show/hide * test: run dock.show tests after dock.hide tests	2020-09-03 20:46:24 +09:00
Jeremy Rose	1b6534b326	feat: add shell.trashItem() to replace shell.moveItemToTrash() (#25114 )	2020-09-02 10:32:33 -07:00
Eryk Rakowski	3745b76da8	feat(extensions): add support for some chrome.management APIs (#25098 ) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings	2020-09-02 09:59:56 +09:00
John Kleinschmidt	7c10f86c6e	ci: cleanup up test app directories (#25145 ) * ci: cleanup up test app directories * ci: use electron prefix for a testing apps so that the can be cleaned up * Revert "ci: cleanup up test app directories" This reverts commit a47daba812ee95f506cac0f1bfedda8be7b4e2f0. * fixup test due to app name change	2020-08-31 14:07:12 -04:00
Cheng Zhao	8f727b3569	fix: do not reset process_id in URLLoaderFactoryParams (#25139 )	2020-08-28 10:43:08 +09:00
Markus Olsson	bab69ae4d2	fix: make shell.moveItemToTrash return false on Windows when move unsuccessful (#25124 )	2020-08-27 09:55:33 -07:00
Electron Bot	443540fd13	Bump v12.0.0-nightly.20200827	2020-08-27 07:31:51 -07:00
Jeremy Rose	2c9e79c8d5	test: add tests for shell.moveItemToTrash (#25113 )	2020-08-26 09:34:29 -07:00
Shelley Vohr	c8a0b2b71d	fix: prevent crash if BrowserView webContents was destroyed (#25112 )	2020-08-25 20:04:13 -07:00
Cheng Zhao	cd3fadc2fb	fix: save normal window bounds when maximizing (#25051 ) * fix: save normal window bounds when maximizing * fix: prevent maximize being emitted twice	2020-08-24 13:32:08 -07:00
John Kleinschmidt	d8fe7af703	ci: fix WOA failing tests (#25018 ) * tests: fix failing WOA tests tests: fix startDrag for WOA tests: fix early-in-memory-session-create crash test on WOA ci: cleanup user app data directories on WOA * tests: disable nativeImage.createFromBuffer tests on WOA * disable failing nativeImage.createFromPath on WOA * disable another nativeImage test for WOA	2020-08-24 12:58:55 -04:00
Alfred Xing	a23c66e4e1	feat: allow monospaced font styles to be specified for macOS tray titles (#25059 ) * feat: add optional font type to macOS tray title * test: add tests for tray font type * docs: update API reference for Tray setTitle * review: change API to use an options object * review: fix string enum in docs Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> * review: return after throwing errors * review: don't need thrower anymore now that we have args Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>	2020-08-23 14:39:29 -07:00
Samuel Attard	b1e2185c5e	refactor: wire will-navigate up to a navigation throttle instead of OpenURL (#25065 ) * refactor: wire will-navigate up to a navigation throttle instead of OpenURL * spec: add test for x-site _top navigation	2020-08-21 12:34:09 -07:00
Jeremy Rose	5d3301769b	feat: record v8 cpu samples in the main process (#24819 )	2020-08-21 09:25:30 -07:00
Cheng Zhao	52d7afa4ef	fix: calculate frame when setting window placement (#25014 )	2020-08-19 12:34:15 -07:00
Eryk Rakowski	9e53112ee1	fix(extensions): enable WebSQL in background pages (#24798 ) * fix(extensions): enable WebSQL in background pages * fix: apply suggestions * fix: remove duplicate include * fix: remove trailing spaces	2020-08-19 09:41:47 +09:00
Shelley Vohr	ff24caf798	test: use custom partition for sw tests (#24999 )	2020-08-18 09:31:24 -07:00
Jeremy Rose	bac2f46ba9	fix: browser contexts live forever (#24964 )	2020-08-17 13:21:53 -07:00
Teo Koon Peng	14aba3f0de	fix: export libuv symbols (#24659 ) * fix: export libuv symbols * add test for linux and windows * mac linker flags * assuming same foo.so path for macos * use --whole-archive flag for mac as well * use force_load for mac * refactor: use napi c api directly Co-authored-by: Cheng Zhao <zcbenz@gmail.com>	2020-08-11 19:17:18 +09:00
Jeremy Rose	481b19bee6	fix: send guid with linux crashes (#24881 )	2020-08-07 15:30:49 -07:00
Eryk Rakowski	f53aac97f5	fix(extensions): bypass cors in requests made from background pages (#24483 )	2020-08-03 16:56:18 -07:00
Shelley Vohr	948cc08265	chore: add V8 crash information to crashReporter (#24771 ) * feat: add V8 crash information to crashReporter * Address review feedback	2020-07-29 19:04:24 -07:00
Jeremy Rose	d93bb34ac4	fix: increase max crash key value length (#24782 ) * fix: increase max crash key value length * chore: fix linting * chore: fix linux * Update spec-main/api-crash-reporter-spec.ts Co-authored-by: Jeremy Rose <jeremya@chromium.org> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: Samuel Attard <sattard@slack-corp.com>	2020-07-29 19:04:04 -07:00
Robo	01023435c0	fix: save crash reports locally when uploadToServer: false on linux (#24778 ) * fix: generate dumps under crashDumps folder in linux * Update spec-main/api-crash-reporter-spec.ts Co-authored-by: Jeremy Rose <jeremya@chromium.org> Co-authored-by: Jeremy Rose <jeremya@chromium.org>	2020-07-29 17:45:02 -07:00
George Xu	1b175a0609	feat: add capabilities to app.getLoginItemSettings() and app.setLoginItemSettings() (#24494 ) * fixed * semantic commit * add comments to browser.h Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>	2020-07-29 10:08:37 -07:00
Samuel Attard	f859d4ce44	test: fail tests if the spec runner promise rejects (#24762 )	2020-07-28 20:36:35 -07:00
Robo	b6321cc22d	fix: crash when navigating from a page with webview that has inherited zoom level (#24757 ) * fix: cleanup webview zoom level observers on navigation * add spec * webview should be on same partition * wait for webview to finish loading	2020-07-28 13:00:44 -07:00
Jeremy Rose	362da77c0a	refactor: ginify SystemPreferences (#24675 )	2020-07-28 11:03:30 -07:00
Robo	76e3ee6fe6	fix: loading dedicated/shared worker scripts over custom protocol (#20625 ) Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2020-07-27 18:48:37 -07:00
Charles Kerr	b39a5b71fe	chore: add trop annotations to release notes. (#24672 ) Trop annotations are in the form of "(Also in 7.3, 8, 9)" with links to the sibling branches. Previously seen in `b43e601b83` but is now free of optional chaining and nullish coalescing, to run on Node < 14 :)	2020-07-27 10:01:41 -05:00
Samuel Attard	5cfe956fe1	fix: ensure that errors thrown in the context bridge are created in the correct context (#24534 )	2020-07-23 14:32:38 -07:00
Samuel Attard	b500294c1d	feat: add worldSafe flag for executeJS results (#24114 ) * feat: add worldSafe flag for executeJS results * chore: do not log warning for webContents.executeJS * Apply suggestions from code review Co-authored-by: Jeremy Rose <jeremya@chromium.org> * chore: apply PR feedback * chore: split logic a bit * chore: allow primitives through the world safe checl * chore: clean up per PR feedback * chore: flip boolean logic * chore: update per PR feedback * chore: fix typo * chore: fix spec Co-authored-by: Jeremy Rose <jeremya@chromium.org>	2020-07-23 14:32:20 -07:00
Samuel Attard	d4a4269989	perf: do not convert object keys in ctx bridge as they are always primitives (#24671 ) * perf: do not convert object keys in ctx bridge as they are always primitives * Update shell/renderer/api/electron_api_context_bridge.cc Co-authored-by: Jeremy Rose <jeremya@chromium.org> Co-authored-by: Jeremy Rose <jeremya@chromium.org>	2020-07-21 15:26:16 -07:00
Samuel Attard	a76e74ac3f	Revert "chore: add Trop annotations to release notes. (#24644 )" This reverts commit `b43e601b83`.	2020-07-21 09:38:28 -07:00
Charles Kerr	b43e601b83	chore: add Trop annotations to release notes. (#24644 ) * chore: add Trop annotations to release notes. Trop annotations are in the form of "(Also in 7.3, 8, 9)" with links to the sibling branches.	2020-07-21 10:32:36 -05:00
Paul Frazee	509740c357	fix: Close protocol response streams when aborted (#24014 )	2020-07-21 09:51:38 +09:00
Samuel Attard	682f78b9a8	test: add more auto updater tests for squirrel.mac (#24611 )	2020-07-20 09:51:33 -07:00
Samuel Attard	f146a164af	build: add apple silicon support (#24545 ) * chore: add patches to prevent installation of non-arm pip packages * chore: add patches for apple-silicon * build: add apple silicon build * ci: add testing of new arm binary * chore: remove / update for upstreamed patches * Skip content tracing on macos on arm * build: ensure that spec native modules are rebuilt for arm64 on apple-silicon * chore: fix patches * chore: fix broken patch * chore: fix arm64 DCHECK * build: add MAS arm64 build * build: disable arm2 tests * chore: update patches * build: actually build MAS version of apple silicon app Co-authored-by: John Kleinschmidt <jkleinsc@github.com>	2020-07-17 09:08:44 -07:00
Samuel Attard	3f54f240bd	perf: pass primitives directly through the context bridge, avoids copying (#24531 )	2020-07-14 18:38:54 -07:00
Electron Bot	8bbdc224ac	chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) (#24256 ) * chore: bump chromium in DEPS to 7fb9778894d73378bff51087ce869ea5aa6e5d5d * chore: bump chromium in DEPS to 83da426e53d423f0530fc23433b6d2c4d0548442 * update patches * remove chromeos-only TtsControllerDelegate Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2255314 * SharedUserScriptMaster -> SharedUserScriptManager Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2258357 * avoid deprecated DISALLOW_COPY_AND_ASSIGN https://groups.google.com/a/chromium.org/forum/#!msg/cxx/qwH2hxaEjac/TUKq6eqfCwAJ * chore: bump chromium in DEPS to b2eaf9ff4e6b03267bf279583ea20ceb2b25e9d0 * update patches * rename GetHighContrastColorScheme -> GetPlatformHighContrastColorScheme Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2250224 * remove vulkan info collection Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2252818 * add max_xcode_version build var Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2264867 * add missing headers * chore: bump chromium in DEPS to cded18ca1138f7e8efc904f077ddcca34f0135cf * update patches * add empty floc blocklist to BrowserProcessImpl Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2240873 * chore: bump chromium in DEPS to f06602226cd80bf677b2ce013a94a2fb7f6ac58d * chore: bump chromium in DEPS to 747aa4bfc74fc6cf7f08ee72624cd69ae41ae28d * chore: bump chromium in DEPS to 31c0105e50fcc4e94de33e5c8602c755ace4a32b * chore: update patches * Reland "[base] Stop including check.h, notreached.h, etc. in logging.h" https://chromium-review.googlesource.com/c/chromium/src/+/2264297 * X11 and Ozone: make sure gfx::AcceleratedWidget to be uint32_t https://chromium-review.googlesource.com/c/chromium/src/+/2260554 * Move zygote from //services/service_manager back to //content https://chromium-review.googlesource.com/c/chromium/src/+/2252466 * chore: update v8 patches * [XProto] Remove usage of Shape extension https://chromium-review.googlesource.com/c/chromium/src/+/2262113 * fixup! add empty floc blocklist to BrowserProcessImpl * Require macOS 10.15.1 sdk https://chromium-review.googlesource.com/c/chromium/src/+/2238504 * Use newer Xcode version 11.5.0 * update src cache * chore: bump chromium in DEPS to 60a9883e35db3f6f91916f0878e88e1849c17b11 * chore: update patches * Reland "Reland "New toolchain for Windows 10 19041 SDK"" https://chromium-review.googlesource.com/c/chromium/src/+/2255527 * update patches * Convert raw NonClientFrameViews to unique_ptrs https://chromium-review.googlesource.com/c/chromium/src/+/2240417 * [printing] Move PrintHostMsg_DidPreviewDocument_Params to print.mojom https://chromium-review.googlesource.com/c/chromium/src/+/2257035 * chore: bump chromium in DEPS to 12c233c2a85bfa28fb279f390121ba681e52a71b * chore: update patches * Removing oppressive language for the directory chrome/browser/apps https://chromium-review.googlesource.com/c/chromium/src/+/2269822 * Inclusion: rename SpellcheckLanguageBlacklistPolicyHandler https://chromium-review.googlesource.com/c/chromium/src/+/2267646 * Clean up duplicate WebContents "is fullscreen" functions https://chromium-review.googlesource.com/c/chromium/src/+/2275148 * Adds icon loading service with sandbox for Windows. https://chromium-review.googlesource.com/c/chromium/src/+/1987273 * No more Vulkan info collection for UMA on Windows https://chromium-review.googlesource.com/c/chromium/src/+/2252818 * fix lint * chore: update buildflag conditions * chore: bump chromium in DEPS to a837d4c4230ace4f10b2768728f4044b7995dfa5 * update hunspell files * chore: update patches * Make content::FileSelectListener a RefCounted https://chromium-review.googlesource.com/c/chromium/src/+/2275338 * fix build failures on MAS * update patches * fixup! Reland "[base] Stop including check.h, notreached.h, etc. in logging.h" * fix build on windows * Check for GDI exhaustion if window creation fails https://chromium-review.googlesource.com/c/chromium/src/+/2244124 * chore: bump chromium in DEPS to 2c9b2a73be4ef9ec22d8b6da8e174cb80753f125 * chore: update patches * Network Service: Move DeleteCookiePredicate into public folder https://chromium-review.googlesource.com/c/chromium/src/+/2264186 * chore: bump chromium in DEPS to fa2606299bcc02c362528d26b5dcf8c8a0db0735 * chore: bump chromium in DEPS to d9c235d1227204dbae3708daae851573a3566b94 * chore: bump chromium in DEPS to 2f82c284243c035f49a747fd1ead6c44b4b31093 * chore: update patches * Move creating the LayerTreeSettings into blink. https://chromium-review.googlesource.com/c/chromium/src/+/2267720 * chore: bump chromium in DEPS to 914112f1d9af9e4974059dc403da62699a55550f * update patches * chore: bump chromium in DEPS to e0bc1ffae6393fc543a2da94c88167df75859b36 * refactor: match upstream print preview handling (#24452) * update patches * chore: bump chromium in DEPS to 0881423156abe084164b51ab58ce93a8bd380524 * update patches * update patches * give a type to pendingPromise * chore: bump chromium in DEPS to 11a8c1534b16d130075d378a64187360ba4e7820 * update patches * 2272609: Move //services/service_manager/sandbox to //sandbox/policy. https://chromium-review.googlesource.com/c/chromium/src/+/2272609 * update patches * fixup! 2272609: Move //services/service_manager/sandbox to //sandbox/policy. * fixup! 2272609: Move //services/service_manager/sandbox to //sandbox/policy. * 2264511: Cookies: Update SetCanonicalCookie to return CookieAccessResult https://chromium-review.googlesource.com/c/chromium/src/+/2264511 * chore: fix setAlwaysOnTop test The window must be visible for state to be updated properly. * Revert "Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex." https://webrtc-review.googlesource.com/c/src/+/179080 * update patches Co-authored-by: Andy Locascio <andy@slack-corp.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Jeremy Rose <nornagon@nornagon.net> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>	2020-07-13 21:13:34 -04:00
Shelley Vohr	6c4017ff45	fix: always callback error with invalid print settings (#24476 )	2020-07-10 09:42:22 -07:00
Samuel Attard	ef9addcb92	build: fix linting issue in spec-main	2020-07-09 11:25:43 -07:00
Samuel Attard	eb6616e4e9	build: update to standard 14 (#24479 )	2020-07-09 10:18:49 -07:00
Jeremy Rose	9bd0fc5348	refactor: ginify BrowserView (#23578 )	2020-07-09 08:48:39 -07:00
Samuel Attard	8d25847318	build: update webpack / TS build deps (#24460 ) * build: update webpack / TS build deps * chore: fix JS inferred types	2020-07-09 01:05:16 -07:00
Samuel Attard	ad16e6c647	build: update linting deps (#24461 )	2020-07-08 21:19:49 -07:00
Milan Burda	7fd96cd188	feat: add name to app.getAppMetrics() output (#24359 )	2020-07-07 14:00:45 -04:00
Jeremy Rose	71a7e1b2e3	chore: tsify menu (#24358 )	2020-07-06 13:24:54 -07:00
Jeremy Rose	1f23807271	chore: tsify web-contents (#24325 )	2020-07-06 10:50:03 -07:00
Robo	d330c6f9fe	feat: expose sessionId in debugger module (#24170 )	2020-07-02 13:04:20 -07:00
Milan Burda	4c449fbc75	test: convert more tests to async / await (#24373 )	2020-07-01 15:14:38 -04:00
Milan Burda	c6db47182a	test: make sure tests fail properly instead of timing out (#24316 )	2020-07-01 00:10:36 +02:00
George Xu	ee61eb9aa4	feat: add app.getApplicationInfoForProtocol API (#24112 ) * pre merge * windows changes * added tests * clean up * more cleanup * lint error * windows 7 support * added windows 7 implementation * code review * lint and code review * code review * app.md merge conflict * merge conflict app.md accidently deleted code block * 'lint' * mis-moved getapplicationinfoforprotocol() into anonymous namespace * fix test * lint * code review	2020-06-30 12:22:30 -07:00
Cheng Zhao	ef3579eae3	refactor: rename TopLevelWindow to BaseWindow (#24305 )	2020-06-29 16:06:20 +09:00
Jeremy Rose	80e5007c47	chore: tsify browser-window (#24326 ) * chore: tsify browser-window * fix focus * also tsify top-level-window	2020-06-29 10:22:55 +09:00
Milan Burda	1c49e4e376	test: use delay() helper (#24321 )	2020-06-26 22:59:54 +02:00
Jeremy Rose	605e50269e	chore: convert rpc-server to ts (#24271 )	2020-06-25 10:19:08 -07:00
Milan Burda	9b4572de44	feat: implement systemPreferences.getMediaAccessStatus() on Windows (#24275 )	2020-06-25 09:47:50 -07:00
Shelley Vohr	659e79fc08	refactor: prevent consistent early exception (#24191 ) * refactor: prevent consistent early exception * Use _linkedBinding where possible * Remove dead electronBinding	2020-06-22 20:32:45 -07:00
Electron Bot	72a089262e	chore: bump chromium to a84d34e372b8fb5e9a94b1b4b447e (master) (#23908 ) * chore: bump chromium in DEPS to a7249f73ae05d456c04487ef1693325f719556dd * chore: bump chromium in DEPS to 202466fa40b58f0bb9c9a76a037d1c50154c099e * chore: bump chromium in DEPS to 2dd1b25c8d794b50fb0dd911e0c4e909ff39f145 * Update patches * update patches * Revert "[printing] Mojofy PrintHostMsg_CheckForCancel" https://chromium-review.googlesource.com/c/chromium/src/+/2226002 * chore: bump chromium in DEPS to 8c1542e7dd36854fdf4abd1a8021eeb65a6a2e2b * chore: bump chromium in DEPS to 078bc6d796334fb403acd8975b99d1c8ecd028e8 * chore: bump chromium in DEPS to d96e9f16ae852ec9dbd15bf17df3d440402413bb * update patches * chore: update patches * Use ExtensionSystem::is_ready() instead of ExtensionService::is_ready() https://chromium-review.googlesource.com/c/chromium/src/+/2207499 * Remove WebImeTextSpan https://chromium-review.googlesource.com/c/chromium/src/+/2225240 * Remove PDFAnnotations flag altogether. https://chromium-review.googlesource.com/c/chromium/src/+/2229317 * Rework find-from-selection so it's synchronous -- fixes flaky tests https://chromium-review.googlesource.com/c/chromium/src/+/2181570 * fixup! Revert "[printing] Mojofy PrintHostMsg_CheckForCancel" * chore: bump chromium in DEPS to a8a280835830c65145ed8573a9a09f36d3920418 * update sysroots * update patches * update patches * Take RFH as a parameter for DidUpdateFavicon/ManifestURL https://chromium-review.googlesource.com/c/chromium/src/+/2224745 * chore: bump chromium in DEPS to b6149cb5a5e32caf8eab67b97ef3072b72521ca8 * Update patches * Rename net::cookie_util::StripStatuses to StripAccessResults https://chromium-review.googlesource.com/c/chromium/src/+/2212697 * use net::CookieAccessResultList instead of net::CookieAccessResultList * fix mas_no_private_api patch https://chromium-review.googlesource.com/c/chromium/src/+/2230281 * chore: bump chromium in DEPS to a27feee1643d952e48f77c92d8c03aedea14b720 * update patches * fix: add new navigation state REUSE_SITE_INSTANCE To fix the new set of state checks added in https://chromium-review.googlesource.com/c/chromium/src/+/2215141 * chore: bump chromium in DEPS to ff4559a4c13d20888202474e4ab9917dbdad8a9a * update patches * Cleanup usages of old mojo types and remove unused code https://chromium-review.googlesource.com/c/chromium/src/+/2235699 * chore: bump chromium in DEPS to 05279845f76eb22900a8b0d1a11d4fd339a8e53b * chore: bump chromium in DEPS to 821558279767cffec90e3b5b947865f90089fed3 * chore: bump chromium in DEPS to 1aef04e6486be337d3dd820b2d64d6320a1b9c13 * chore: bump chromium in DEPS to dc86386e8fdd796a0f7577e91e42a7f8b7e9bc78 * chore: bump chromium in DEPS to 64f2360794f14643764092ba3e58e2ed8f9fee12 * chore: update patches * refactor: MessageLoop, you are terminated \o/ Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2246173 * refactor: plumb DownloadSchedule to DownloadItem Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2242202 * chore: fix variable typo in IPC * chore: s/BindPipeAndPassReceiver/BindNewPipeAndPassReceiver * chore: update patches * chore: XEvent becomes x11::Event Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2240355 * fixup! refactor: MessageLoop, you are terminated \o/ * fixup! chore: XEvent becomes x11::Event * build: update v8 headers * chore: fix windows build * chore: disable SameSite-by-default changes https://chromium-review.googlesource.com/c/chromium/src/+/2231445 * update printing.patch * chore: bump chromium DEPS to 9ae03ef8f7d4f6ac663f725bcfe70311987652f3 * Convert WidgetHostMsg_SelectionBoundsChanged/TextInputStateChanged https://chromium-review.googlesource.com/c/chromium/src/+/2243531 * chore: update v8 patches * [XProto] Replace usages of XID and ::Window with x11::Window https://chromium-review.googlesource.com/c/chromium/src/+/2249389 * Update VideoFrameMetadata to use base::Optionals https://chromium-review.googlesource.com/c/chromium/src/+/2231706 https://chromium-review.googlesource.com/c/chromium/src/+/2238361 * --disable-dev-shm-usage for gpu process crash * [v8] Allow for 4GB TypedArrays https://chromium-review.googlesource.com/c/v8/v8/+/2249668 * update lib_src_switch_buffer_kmaxlength_to_size_t.patch * disable app.getGPUInfo spec on linux * update patches Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>	2020-06-22 10:35:10 -07:00
Robo	7cc780d077	fix: let Node.js perform microtask checkpoint in the main process (#24131 ) * fix: let Node.js perform microtask checkpoint in the main process * fix: don't specify v8::MicrotasksScope for explicit policy * fix: remove checkpoint from some call-sites We already perform checkpoint at the end of a task, either through MicrotaskRunner or through NodeBindings. There isn't a need to add them again when calling into JS except when dealing with promises. * fix: remove checkpoint from some call-sites We already perform checkpoint at the end of a task, either through MicrotaskRunner or through NodeBindings. There isn't a need to add them again when calling into JS except when dealing with promises. * fix incorrect specs * default constructor arguments are considered for explicit mark * add regression spec	2020-06-17 10:08:10 -07:00
Milan Burda	673169a7ba	chore: remove unused deprecate.fnToProperty() (#24069 )	2020-06-15 18:59:04 -07:00
Jeremy Rose	c0182bca15	chore: remove test usages of createIDWeakMap (#24116 )	2020-06-15 13:56:51 -07:00
Jeremy Rose	178e46cd23	test: add test for gc race in remote (#24087 )	2020-06-12 14:19:20 -07:00
Jeremy Rose	7c7ea141f0	test: extract defer helper (#24019 )	2020-06-11 11:35:50 -07:00
Paul Frazee	81d09bea44	fix: correctly handle nexttick scheduling in stream reads (#24022 )	2020-06-11 09:55:59 -07:00
Eryk Rakowski	04be1ac4a1	fix: assign session to remote webContents (#23989 ) * fix: assign session to remote webContents * fix: test name	2020-06-11 12:57:51 +09:00
Gellert Hegyi	ce042184de	fix: Add .paks for media-internals and webrtc-internals pages (#24010 ) * fix: adds paks for media-internals and webrtc-internals pages * adds tests	2020-06-11 11:07:49 +09:00
Felix Rieseberg	3eade2c228	fix: Allow windows behind macOS elements if frame = false (#23976 )	2020-06-09 11:52:14 -07:00
Jeremy Rose	71e2b7151c	test: extract RemoteControlApp to spec-helpers (#24020 )	2020-06-09 11:42:53 -07:00
dependabot[bot]	b2ef299efc	build(deps): bump minimist from 1.2.0 to 1.2.5 in /spec-main (#24026 ) Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.5. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.5) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2020-06-09 11:29:15 -07:00
Charles Kerr	980e592271	chore: ensure release notes always come from Clerk (#23777 ) * chore: ensure release notes always come from Clerk Now with tests! * chore: move sinon devDependency into `spec-main` * refactor: tweak note-spec variable for readability	2020-06-08 11:39:44 -07:00
Paul Frazee	c6c022dc46	feat: add {stream} opt to custom protocol registry to configure media player (#22955 )	2020-06-08 09:49:36 -07:00
Jeremy Rose	5185501b85	test: reduce flakiness of post-context-release ipc test (#23992 )	2020-06-05 16:51:42 -07:00
Jeremy Apthorp	a1c55a13e1	fix: throw instead of crash when using ipcRenderer after context released (#23917 )	2020-06-04 16:25:25 -07:00
Milan Burda	3fa4299939	fix: use acceptLanguages argument in session.setUserAgent() (#23944 )	2020-06-04 13:05:37 +02:00
Cheng Zhao	5de6adfb84	test: load page with some content when testing extension (#23901 ) * test: load page with some content when testing extension * test: use dom-ready to wait for page loaded with extension	2020-06-03 16:56:28 +09:00
Samuel Attard	d3fa5ed1e8	docs: move protocol-ns to protocol.md (#23883 ) * docs: move protocol-ns to protocol.md * chore: fix up tests and implement missing pieces required for tests	2020-06-02 09:46:18 -07:00
Cheng Zhao	5918dd6e65	test: wait for beforeunload handler to be installed (#23874 )	2020-06-02 11:32:39 +09:00
Electron Bot	a4de915b74	chore: bump chromium to d66c2e32380bf5d1eb5e1fe37faef (master) (#23791 ) * chore: bump chromium in DEPS to db7d7b3e7cb2bc925f2abfde526280cfdfc21a41 * Update patches * chore: bump chromium in DEPS to 5613e1b99a44fcbe22f3910f803ca76903a77ec1 * Update patches * Network service: Remove primary_network_context bool. https://chromium-review.googlesource.com/c/chromium/src/+/2204678 * WebContentsObserver now implements OnRendererResponsive https://chromium-review.googlesource.com/c/chromium/src/+/2211066 * update patches * Fixup printing patch * chore: bump chromium in DEPS to e387b972cdd7160c416fa6c64a724e2258aa0218 * update patches * [printing] Move PrintHostMsg_DidPrintContent_Params to print.mojom https://chromium-review.googlesource.com/c/chromium/src/+/2212110 * [XProto] Move items from ::x11::XProto to ::x11 https://chromium-review.googlesource.com/c/chromium/src/+/2218476 * revert Add IChromeAccessible This was added in https://chromium-review.googlesource.com/c/chromium/src/+/2206224 but it breaks WOA builds because third_party/win_build_output/midl/ui/accessibility/platform/arm64 does not exist. The link above says that the new interface is behind a feature flag which is disabled by default so it is safe to remove for now. * rebaseline ichromeaccessible for Windows arm64 This patch will not be needed once we get the next roll. * Update to 1b9e01844e8bf1aaafc4a52c0c62af7f56d9637b to get arm64 fix * update patches * chore: bump chromium in DEPS to 096aefa04092ea00f7b68d8d19345883f20db3c3 * chore: bump chromium in DEPS to a524a45ffd1d6fd46a7a86138fe2b22df5b6651a * chore: update patches * Window Placement: Gate cross-screen fullscreen behavior on permission https://chromium-review.googlesource.com/c/chromium/src/+/2203268 * chore: add spec for https://crbug.com/1085836 * chore: bump chromium in DEPS to ff6c4f4b826d66c2e32380bf5d1eb5e1fe37faef * update patches Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: deepak1556 <hop2deep@gmail.com>	2020-06-01 16:34:34 -04:00
Alexey Kuzmin	4133c71105	build: fix for "enable_desktop_capturer = false" (#23864 )	2020-06-01 10:13:47 -04:00
Shelley Vohr	e8ea007104	fix: ensure nativeImage serialization main->renderer (#23759 )	2020-05-28 09:43:15 -07:00
Shelley Vohr	6516110c70	fix: volume key globalShortcut registration (#23782 )	2020-05-28 08:56:48 -04:00
Alexey Kuzmin	3a7775fa73	test: refactor how spec files are collected (#23774 )	2020-05-28 00:21:02 +02:00
Shelley Vohr	f78504515b	fix: handle asynchronous URL loading in bw proxy (#23776 )	2020-05-27 13:50:54 -07:00
Jeremy Judeaux	204f001c5d	feat: add desktopCapturer.getMediaSourceIdForWebContents() to get stream source id from web contents (#22701 ) * feat: add desktopCapturer.getMediaSourceIdForWebContents() to get stream source id from web contents * Cleanup from #22701 PR comments	2020-05-26 16:34:24 -04:00
Electron Bot	dc72f74020	chore: bump chromium to 580fe983e138952553cd6af11ee8b (master) (#23379 ) * chore: bump chromium in DEPS to 5ce64b91b4d6a78c97480059f15ff6469fc0918e * chore: bump chromium in DEPS to e74c73d0000f81b3f40a513176c8d024bba57d28 * chore: bump chromium in DEPS to 501640e650d4657ba63db65fa257e4a899168de7 * chore: bump chromium in DEPS to 00db20e1bc3d77706723a87ada3c1c647a1c37b7 * chore: update patches * refactor: AddNewContents now takes a target_url Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2167732 * chore: SetHostCleanupFinalizationGroupCallback has been removed from V8 * refactor: use WebInputEvent::Namespace types directly Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2160523 * refactor: FollowRedirect takes in cors exempt headers now Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2129787 * refactor: printing::DuplexMode moved to mojo Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2162388 * refactor: use MessagePortDescriptor instead of raw mojo::MessagePipeHandles Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1952124 * chore: update patches * chore: bump chromium in DEPS to f1537676d613f3567cfb43adf577b3847fba4bc3 * chore: update patches * refactor: service_manager::BinderMapWithContext merged into mojo::BinderMap Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2174654 * chore: unused argument removed from ReadAvailableTypes in ui::Clipboard Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2173666 * chore: bump chromium in DEPS to 949888433ab935dd6125c107226a4c9d6da9bf48 * chore: update patches * update patches * chore: update sysroots * chore: bump chromium in DEPS to eaac5b5035fe189b6706e1637122e37134206059 * chore: bump chromium in DEPS to 258b54b903d33dab963adf59016691e6537f8b70 * build: update patches * refactor: cursor.mojom and cursor_types.mojom moved to //ui/base/cursor/mojom Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2172874 * chore: DesktopWindowTreeHostLinux becomes DesktopWindowTreeHostPlatform Refs: * refactor: LogErrorEventDescription moved from ui to x11 Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2164245 * chore: update patches * chore: bump chromium in DEPS to bd06abcfe807d4461683479237cdd920dafa52ca * chore: bump chromium in DEPS to 1afb0891e56f1e79d204db43ca053a46d0974511 * chore: bump chromium in DEPS to 5cb0f794bf7f155bf8c0a241b94e01c9d90c2744 * chore: bump chromium in DEPS to 37327ba3303234e1a3cd3310ca11a68e81b95123 * update patches * remove ClientSideDetectionService from browser_process Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2175320 * refactor: shuttle cursor changed event to WebContentsObserver Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2172779 * chore: bump chromium in DEPS to 1d97904bb6936e106df13705208b73e47367c2b9 * avoid IPC crash introduced earlier in the roll Refs: `b67334e781 (diff-607f4e8f7c5686aa09af98c783925babR128)` * remove WebContentsView::SizeContents Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2188931 * chore: bump chromium in DEPS to 87066d1db0546a9de33952ba964e1e42f76f1dae * update patches * adapt to //content creating NetworkContexts https://chromium-review.googlesource.com/c/chromium/src/+/2195196 * WIP temporarily ignore mojo-ified PrintHostMsg_PrintPreviewFailed Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2195343 * add checkout_pgo_profiles to DEPS * chore: bump chromium in DEPS to a095318bec1dedf580d676f408eaeefdbd9956b1 * add blink's execution_context to electron_lib deps Refs: `b67334e781`#, https://chromium-review.googlesource.com/c/chromium/src/+/1952124 * update patches * update patches * refactor: use newly mojo-ified PrintPreviewFailed Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2195343 Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * chore: update patches * chore: remove NOTIFICATION_EXTENSIONS_READY_DEPRECATED Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2199874 * avoid a call to Profile::FromBrowserContext in printing Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2195757 * chore: bump chromium in DEPS to 8f5c6a46861a991e12ffd80554b6bd41a11b0b65 * chore: bump chromium in DEPS to ab66134739ff3b6bdb8de53bbc58a97d1b7b5d8a * chore: bump chromium in DEPS to dd08df9f6c8d6198f0a7b931ca9e845e27dae033 * chore: update patches * [printing] Mojofy PrintHostMsg_PrintPreviewCancelled https://chromium-review.googlesource.com/c/chromium/src/+/2198331 * [printing] Mojofy PrintHostMsg_PrintPreviewInvalidPrinterSettings https://chromium-review.googlesource.com/c/chromium/src/+/2200556 * [printing] Mojofy PrintHostMsg_DidPrepareDocumentForPreview https://chromium-review.googlesource.com/c/chromium/src/+/2201496 * fix: inherit base network context params * fix: use message handle api specific to embedders * update patches * chore: update v8 headers * fixup! avoid a call to Profile::FromBrowserContext in printing * chore: bump chromium in DEPS to f198bc3276828d992b6202d75a9da6a8363164ea * chore: update patches * Remove cors_exempt_headers.h https://chromium-review.googlesource.com/c/chromium/src/+/2203759 * Supply speech recognition sandbox from service_sandbox_type.h https://chromium-review.googlesource.com/c/chromium/src/+/2206918 * [content] Remove unused methods from WebContents https://chromium-review.googlesource.com/c/chromium/src/+/2199113 * [XProto] Replace XAtom with x11::Atom https://chromium-review.googlesource.com/c/chromium/src/+/2202789 * chore: bump chromium in DEPS to 5df37fabaaed09f3ea511f4ef49203d8ebee7b68 * [UI] Support secondary labels in dropdown menus https://chromium-review.googlesource.com/c/chromium/src/+/2208976 * chore: update patches * refactor: GetSublabelAt => GetSecondaryLabelAt * Revert "[printing] Mojofy PrintHostMsg_DidPrepareDocumentForPreview" This reverts commit 44ed0892a0c81716229638f17253bbb2cf8f037d. https://chromium-review.googlesource.com/c/chromium/src/+/2208778 * Unnest CanonicalCookie::CookieInclusionStatus https://chromium-review.googlesource.com/c/chromium/src/+/2203171 * update print-to-pdf.html with latest html data https://bugs.chromium.org/p/chromium/issues/detail?id=1085667 * chore: bump chromium in DEPS to 5dfa8d5f706580fe983e138952553cd6af11ee8b * fix crash in x server when setting window icon * chore: update patches * Use a normal return value for WebContentsView::GetContainerBounds. https://chromium-review.googlesource.com/c/chromium/src/+/2212481 * fix build on windows * chore: bump chromium in DEPS to 9d15054f4cba060901e43deecf74002f11f47be3 * chore: update patches * [printing] Mojofy PrintHostMsg_CheckForCancel https://chromium-review.googlesource.com/c/chromium/src/+/2212181 Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: Andy Locascio <andy@slack-corp.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>	2020-05-26 13:06:26 -07:00
Cheng Zhao	0a026cde0c	test: return after inspector connection is closed (#23763 )	2020-05-26 10:47:49 -04:00
John Kleinschmidt	db5cf816b4	ci: deflake WOA tests (#23707 )	2020-05-26 10:25:57 -04:00
Cheng Zhao	08f288faf1	test: use WebContents event to test beforeunload (#23699 )	2020-05-26 09:21:38 -04:00
Cheng Zhao	0dabd5e8c7	test: more logging in node inspector test (#23746 )	2020-05-26 10:20:16 +09:00
Samuel Attard	9bc5e98238	chore: tsify more of lib (#23721 ) * chore: tsify more of lib * Update lib/browser/api/session.ts Co-authored-by: Jeremy Apthorp <jeremya@chromium.org> Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>	2020-05-22 12:46:22 -07:00
mtgto	7b55a70a36	feat: Add Secure Keyboard Entry APIs in macOS (#20678 ) * feat: Add Secure Keyboard Entry APIs in macOS Add methods: - app.isSecureInputEnabled() - app.setSecureInputEnabled(enabled) These enable to prevent other process listens keyboard input events. * fix: lint error in app.md for #20678 * fix: crash app.setSecureInputEnabled() in password textfield * fix: export Secure keyboard Entry API to only macOS * fix: lint error in browser_mac.mm for #20678 * test: add test for app.setSecureKeyboardEntryEnabled in macOS	2020-05-21 11:53:44 -04:00
Jeremy Apthorp	5bdf97e7ae	test: hide child windows in webview spec (#23682 )	2020-05-21 11:46:17 -04:00
Cheng Zhao	3137d5f011	test: multiple processes may crash in crashReporter test (#23695 )	2020-05-21 11:43:47 -04:00
Milan Burda	df53816eea	feat: expose the desktopCapturer module in the main process (#23548 )	2020-05-20 20:25:49 -04:00
Shelley Vohr	4b23a85475	refactor: correctly serialize nativeImage/buffer with typeUtils (#23666 ) * refactor: correctly serialize nativeImage/buffer with typeUtils * test: add serialization specs * fix: construct from dataURL * test: test for dataURL specificity	2020-05-20 13:42:42 -07:00
Alexey Kuzmin	33d6a99d40	test: call "expect()" on a correct call stack (#23675 )	2020-05-20 22:18:48 +02:00
LuoJinghua	9d851b8791	net: Don't ignore the referer header in net.request (#23386 )	2020-05-20 13:28:38 -04:00
Jeremy Apthorp	de44d28c8e	refactor: ginify Session (#23569 )	2020-05-19 10:18:12 -07:00
Jeremy Apthorp	3f3a760a01	test: bind to 127.0.0.1 in contextBridge spec (#23639 )	2020-05-19 10:17:40 -07:00
Jeremy Apthorp	01579cc8ed	test: add retries to another beforeunload test (#23644 )	2020-05-19 11:06:19 +09:00
Jeremy Apthorp	c00103d274	test: fix multiple connections in inspector test (#23648 ) * test: fix multiple connections in inspector test * debug log	2020-05-19 11:05:49 +09:00
Jeremy Apthorp	7e841ceb5c	refactor: tsify net module (#23618 )	2020-05-18 10:22:48 -07:00
John Kleinschmidt	8879a3db58	ci: use longer mocha timeout on WOA testing (#23633 )	2020-05-18 12:33:54 -04:00
Shelley Vohr	ee0f67d541	fix: nativeImage remote serialization (#23543 ) We weren't serializing nativeImages properly in the remote module, leading to gin conversion errors when trying to, for example, create a new context menu in the renderer with icons using nativeImage. This fixes that by adding a new special case to handle them.	2020-05-18 09:29:24 -07:00
Jeremy Apthorp	8bbb68be79	test: retry beforeunload test (#23576 )	2020-05-18 11:04:41 -04:00
Milan Burda	52b50e6b33	feat: add app render-process-gone event (#23560 )	2020-05-17 17:05:05 +02:00
Samuel Attard	9d7ba98209	refactor: remove the RenderFrameFunctionStore and use privates to memory manage (#23592 )	2020-05-15 11:57:40 -07:00
Milan Burda	4afc756094	feat: add contents.getBackgroundThrottling() + backgroundThrottling property (#21036 )	2020-05-14 15:11:45 +02:00
Milan Burda	7656480247	test: remove usage of the remote module from tests (#23571 )	2020-05-14 00:33:37 +02:00
Milan Burda	fc468cce3b	test: skip remote module related tests when enable_remote_module = false (#23557 )	2020-05-13 20:05:44 +02:00
Felix Rieseberg	dcbed18f44	feat: app.getPath('recent') (#23381 ) * feat: getPath("recent") * test: Add a spec and docs * fix: Integrate feedback * fix: Handle path change * chore: Cut SetRecentPath	2020-05-13 11:27:56 +09:00
Samuel Attard	7f9b7b2e95	chore: clean up context bridge scopes and add specs for internal bridge (#23334 ) * chore: clean up context bridge context scopes * spec: add specs for internalContextBridge	2020-05-11 13:41:42 -07:00
Milan Burda	653c36b8c9	test: skip "handles Promise timeouts correctly" when ELECTRON_RUN_AS_NODE is disabled (#23415 )	2020-05-11 14:19:39 -04:00
Alexey Kuzmin	dc3de49a08	spec: fix conditions for some tests (#23489 )	2020-05-11 10:46:45 +09:00
Pavel Feldman	3c132dc445	chore: handle Browser.close over CDP (#23436 )	2020-05-08 16:13:32 -07:00
Samuel Attard	091f45b879	chore: fix linting (#23473 )	2020-05-08 11:30:37 -07:00
Samuel Attard	21900fe4f4	fix: do not initialize any extension related logic in OffTheRecord contexts (#22772 )	2020-05-08 11:17:28 -07:00
Pavel Feldman	93f6129c80	chore: support --remote-debugging-pipe (#23433 )	2020-05-07 21:27:55 -07:00
Jeremy Apthorp	06bf0d08dc	fix: crashReporter incompatible with sandbox on Linux (#23265 )	2020-05-07 13:31:26 -07:00
Robo	a707a3eda3	feat: add enableWebSQL webpreference (#23311 ) * feat: add enableWebSQL webpreference * chore: update indexedDB test	2020-05-06 12:52:59 -07:00
Sorah Fukumori	f176d2494f	fix: respect system language preferences on Win/macOS (#23247 ) This commit fixes https://github.com/electron/electron/issues/18829 Previously the full preferences set to OS was not given to Chromium. Also, this commit improves fallback font selection for CJK text. Chromium uses browser languages to determine fallback fonts on Windows, especially kanji/han characters in CJK. For instance, when user sets 'en-US, ja-JP' to Accept-Language, while Chromium chooses Japanese font for kanji text, but Electron chooses Chinese font. This is because only the first language was given to Accept-Language on Electron. This patch is based on https://github.com/electron/electron/pull/15532 Co-authored-by: Nitish Sakhawalkar <nitsakh@icloud.com> Co-authored-by: Kasumi Hanazuki <kasumi@rollingapple.net> Co-authored-by: Nitish Sakhawalkar <nitsakh@icloud.com> Co-authored-by: Kasumi Hanazuki <kasumi@rollingapple.net>	2020-05-04 10:49:29 -07:00
shelley vohr	0f0cc51b35	refactor: return null when passing empty menu templates (#23364 )	2020-05-04 08:19:21 -07:00
Jeremy Apthorp	8d0a612265	refactor: remove code for non-native extensions shim (#23340 )	2020-04-30 09:38:09 -07:00
shelley vohr	f50f725a9c	fix: prevent Menu.buildFromTemplate with empty array (#23308 ) Prevent issues with menu creation and subsequent pane focus from menu bar by preventing menus from being created from an empty array. I can't conceive a valid use case for this, since if one wants to remove a menu they should be be passing null to win.setMenu() or calling win.removeMenu(). This issue is also specific to top-level menus, and not submenus, so the new check and exception is scoped to top-level menus.	2020-04-30 08:29:02 -07:00
Jeremy Apthorp	176a120ec2	test: fix crashReporter test on woa (#23242 ) * test: fix crashReporter test on woa * disable some tests on woa	2020-04-23 16:08:50 -04:00
Cheng Zhao	cb6a1e2c5e	fix: set default menu in will-finish-launching event (#23214 )	2020-04-23 10:51:31 -07:00
Jeremy Apthorp	6fa05dd123	test: refactor crashReporter tests (#23178 )	2020-04-22 15:53:12 -07:00
Samuel Attard	96bf9ce77f	refactor: port parts of window-setup to use ctx bridge instead of being run in the main world (#23194 ) * refactor: port parts of window-setup to use ctx bridge instead of being run in the main world * chore: update ctx bridge specs for new base numbers	2020-04-22 12:42:51 -07:00
Jeremy Apthorp	c798a6e5d1	fix: block custom window.open when nativeWindowOpen is true (#23188 )	2020-04-22 10:48:54 -07:00
Samuel Attard	0cbcee6740	fix: ensure that functions are not retained beyond their context being released (#23207 )	2020-04-21 18:05:01 -07:00
loc	aca2e4f968	refactor: improve feature string parsing (#23130 ) * test: add pre-change snapshot of new-window event * move to .ts file for easier diff * refactor: improve feature string parsing logic * test: update snapshots * update type names per review * update comma-separated parse test * use for loop instead of reduce per review * tighten up types * avoid variable guest contents id returnValue in test snapshot	2020-04-21 16:23:00 -04:00
loc	a041882192	test: add test for datalist autofills (#23110 ) * test: add test for datalist autofills * address style nits * move fixture to spec-main	2020-04-21 12:28:31 -07:00
Charles Kerr	07654c47ec	fix: use Node's microtasks policy in node_main.cc (#23153 ) Fixes #21515.	2020-04-21 12:18:22 -07:00
Shelley Vohr	f3dc3997b1	feat: support fullScreen BrowserWindow property (#23145 )	2020-04-20 20:25:18 -07:00
Shelley Vohr	ba3928103f	spec: fix type errors in devToolsWebContents (#23187 )	2020-04-20 16:51:27 -07:00
Jeremy Apthorp	2541d62486	chore: remove disable_user_gesture... patch (#23066 )	2020-04-16 15:22:39 -07:00
Samuel Attard	e4c82fdf2d	Merge pull request from GHSA-h9jc-284h-533g	2020-04-16 14:10:18 -07:00
Electron Bot	3e8d77d564	chore: bump chromium to 98ebf6c3f0b7bd96bdb1a4b42208f (master) (#22999 ) Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>	2020-04-13 16:39:26 -07:00
loc	5154e8ff75	fix: enable workaround for nativeWindowOpen hang (#22825 )	2020-04-13 11:37:41 -04:00
Robo	abbe7417f2	chore: fix type check in systemPreferences module specs (#23064 )	2020-04-09 15:55:47 -07:00
Cheng Zhao	ca947307db	chore: make WebContentsView take webPreferences as parameter (#22997 ) * chore: add WebContentsView.webContents helper * chore: no need to handle webContents option * chore: Create WebContentsView in C++ * chore: make WebContentsView accept web_preferences * fix: nativeWindowOpen still passes WebContents to BrowserWindow * chore: no more need of WebContentsViewRelay * test: WebContentsView now takes options * fix: avoid creating 2 constructors	2020-04-09 16:01:16 +09:00
Samuel Attard	0d2e967960	feat: expose electron/{process} typed modules (#22937 ) * feat: expose electron/{process} typed modules * chore: update imports for common modules * chore: update typescript generator * chore: remap electron/* to the internal packages	2020-04-06 17:04:09 -07:00
Jeremy Apthorp	0a78ab4b98	refactor: ginify DownloadItem (#22924 )	2020-04-02 17:22:46 -07:00
Jeremy Apthorp	6159066c26	refactor: ginify Menu (#22916 )	2020-04-02 16:07:56 -07:00
Samuel Attard	1d158399a6	feat: expose the sameSite value for cookies (#22789 ) * feat: expose the sameSite value for cookies * Apply suggestions from code review Co-Authored-By: Charles Kerr <ckerr@github.com> * Apply suggestions from code review Align with cookie samesite values for the extensions API https://developer.chrome.com/extensions/cookies#type-SameSiteStatus * chore: add tests for sameSite cookies get/set * chore: update docs parser * chore: update docs for MessageChannel and MessagePort to have correct process information * chore: remove LOG warning * chore: throw error if the string->samesite conversion fails Co-authored-by: Charles Kerr <ckerr@github.com>	2020-04-02 11:28:43 -07:00
Shelley Vohr	da67cbf551	feat: add property support for remainder of BrowserWindow (#22771 ) Adds property-based support for the remainder of primitive gette/setter pairs on `BrowserWindow`. Namely: - `win.simpleFullScreen` - `win.title` - `win.visibleOnAllWorkspaces` - `win.documentEdited` - `win.representedFilename` - `win.shadow` - `win.kiosk` - `win.menuBarVisible`	2020-04-01 08:22:32 -07:00
Cheng Zhao	14051ff945	test: do not trigger unhandled promise rejections (#22922 )	2020-04-01 09:45:39 -04:00
Cheng Zhao	e6f2605ad0	fix: webRequest module should work with file:// protocol (#22903 ) * fix: override file:// instead of intercepting * test: webRequest module should work with file:// * fix: service work with file:// url * fix: original_response_headers can be null * fix: only register file:// when necessary	2020-04-01 16:38:40 +09:00
Robo	bac1c7f532	fix: ensure standard schemes are registered in nw service process (#22867 ) * fix: ensure standard schemes are registered in nw service process Refs https://github.com/electron/electron/pull/20546 * chore: add test * chore: apply suggestions from code review Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org> Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>	2020-03-31 19:33:16 -07:00
Jeremy Apthorp	765c08c600	refactor: ginify Notification (#22821 )	2020-03-31 11:42:32 -07:00
Samuel Attard	fea3366bc7	fix: propagate preferred color scheme to the renderer (#22896 ) * fix: do not crash if the window is closed syncronously with a nativeTheme change * fix: propogate preferred color scheme to the renderer and keep it up to date	2020-03-30 15:39:50 -07:00
Jeremy Apthorp	a3e28788ce	refactor: ginify Tray (#22822 ) * refactor: ginify Tray * lint * improve argument parsing logic * remove redundant imports from tray.js * new Tray produces an instanceof Tray * make Constructible generic * lint * clean up on exit	2020-03-30 10:32:02 +09:00
Jeremy Apthorp	ac501e8194	fix: heap-use-after-free in tray.popUpContextMenu (#22842 )	2020-03-26 18:30:21 -07:00
Heilig Benedek	74372d65ae	feat: enhance native window.open to match the custom implementation's behavior (#19703 ) Co-authored-by: Andy Locascio <andy@slack-corp.com>	2020-03-26 11:05:45 -07:00
Jeremy Apthorp	b327478cf0	fix: prevent remote from messing with constructor names (#22820 )	2020-03-25 13:13:10 -07:00
CezaryKulakowski	bdef77bad8	fix: don't allow window to go behind menu bar on mac (#22770 )	2020-03-25 11:13:43 +09:00
Jeremy Apthorp	07cd70a37e	refactor: ginify powerMonitor (#22751 )	2020-03-24 09:03:29 -07:00
Samuel Attard	e678794dd0	build: fix beta version bumper logic for betas beyond 10 (#22810 )	2020-03-24 09:04:12 -04:00
Samuel Attard	af46c1ed8d	fix: allow net requests to use Same-Site cookies (#22788 )	2020-03-20 16:39:03 -07:00
Samuel Attard	60bd52880f	feat: add support for net requests to use the session cookie store (#22704 )	2020-03-20 15:56:02 -07:00
Samuel Attard	5d657dece4	build: enable JS semicolons (#22783 )	2020-03-20 13:28:31 -07:00
Samuel Attard	b87b501161	build: update eslint + eslint plugins (#22777 ) * build: run eslint --fix * chore: manually fix all hasOwnProperty errors * chore: manually fix all void 0 vs undefined errors * chore: manually fix all async-in-promise errors * chore: manually fix lexical declaration in case block	2020-03-20 11:12:18 -04:00
Samuel Attard	aa15a2cc03	build: update typescript and webpack (#22776 )	2020-03-19 16:55:49 -07:00
Cheng Zhao	47e27aee5b	test: no need to loadURL in menu test (#22737 )	2020-03-19 10:49:40 +09:00
Jeremy Apthorp	c4a7eade28	refactor: ginify session.netLog (#22732 )	2020-03-18 16:46:05 -07:00
Samuel Attard	e58a35e5aa	chore: fix net specs when rerunning locally (#22745 )	2020-03-18 16:35:23 -07:00
Shelley Vohr	fc661ec56b	chore: update app module property support (#22713 )	2020-03-18 10:06:41 -07:00
Samuel Attard	1ea21e42bb	chore: refactor all the net specs to be async with better error handling (#22731 )	2020-03-18 08:59:44 -07:00
Shelley Vohr	674e4a9fdd	chore: more modules to dual prop/fn support (#22688 )	2020-03-17 18:06:52 -07:00
Shelley Vohr	97d8caa1e0	chore: support props/fns for BrowserWindow (#22686 )	2020-03-16 14:03:35 -07:00
Shelley Vohr	a4c4c86b9d	fix: crash on invalid zoomFactor (#22673 )	2020-03-13 16:13:05 -07:00
Jeremy Apthorp	9c5874306d	fix: crash when destroying WebContentsView during GC (#22674 )	2020-03-13 10:33:37 -07:00
Shelley Vohr	1b353d1ed3	chore: revert deprecated WebContents properties (#22640 ) * chore: revert deprecated WebContents properties * Fix failing zoomFactor test	2020-03-13 10:16:08 -07:00
Jeremy Apthorp	0c02d794c9	feat: add onclose method to MessagePort (#22532 ) * feat: add onclose method to MessagePort * more scope, more good * de-flake GC test	2020-03-13 10:00:50 -07:00
Jeremy Apthorp	b4d07f76d3	feat: MessagePorts in the main process (#22404 )	2020-03-11 18:07:54 -07:00
Erick Zhao	34e004015d	feat: add API to check if session is persistent (#22622 )	2020-03-11 16:02:22 +09:00
Jeremy Apthorp	19314d3caf	fix: remove catch-all HandleScope (#22531 )	2020-03-10 18:16:58 -07:00
Shelley Vohr	b607cfa220	test: test setPath for errors thrown (#22626 )	2020-03-10 09:03:52 -07:00
Alexey Kuzmin	bf75e5a91f	build: fix build without built-in spellchecker (#22594 )	2020-03-10 18:39:40 +09:00
Erick Zhao	3ff98e15d0	fix: prevent in-memory sessions from writing to custom spellchecker dictionary (#22157 ) * fix: prevent in-memory sessions from writing to custom dictionary * docs * spec	2020-03-10 16:45:43 +09:00
Cheng Zhao	8075a55815	test: disable spellchecker context menu test for arm (#22590 )	2020-03-10 11:13:41 +09:00
Samuel Attard	3e2cec83d9	feat: programmatically modify traffic light positioning (#22533 ) * setter * getter * specs and docs * fixup Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>	2020-03-05 14:22:12 -08:00
John Kleinschmidt	0201b3e571	feat(extensions): add chrome.tabs.connect API (#22457 ) * feat(extensions): add chrome.tabs.connect API * test(extensions): verify that chrome.tabs.connect port communication works	2020-03-05 09:59:32 -05:00
John Kleinschmidt	d6701ff435	feat(extensions): add chrome.i18n API (#22455 ) * feat(extensions): implement chrome.i18n API * refactor(extensions): use forward declaration for ScriptExecutor * fix(extensions): add message filter to handle i18n GetMessageBundle * test(extensions): add chrome.i18n tests * fix(extensions): message filter lint error * fix: remove exclusive test * fix(extensions): format api feature arrays Co-Authored-By: Jeremy Apthorp <nornagon@nornagon.net> * fix(extensions): uncomment chrome.i18n usage in old extensions test Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>	2020-03-05 09:56:21 -05:00
Samuel Attard	2563681583	fix: disable contextBridge object identity caching (#21803 ) * fix: disable contextBridge object identity caching * cleanup * chore: make non-const references raw pointers * fix: zero-param constructors are not explicit * refactor: use base::LinkedList Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>	2020-03-03 23:18:22 -08:00
Electron Bot	39baf68790	chore: bump chromium to 5b340c815ce15ab2efcf277ed19e9 (master) (#22064 ) Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: loc <andy@slack-corp.com> Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>	2020-03-03 13:35:05 -08:00
Cheng Zhao	0e0c8e7c6f	test: give arm machines more time to load spellchecker (#22494 )	2020-03-03 15:03:54 +09:00
Erick Zhao	01c597a646	test: add specs for custom dictionary API (#22158 ) * tests * test: add specs for custom dictionary API * await	2020-03-02 16:57:46 -08:00
CezaryKulakowski	0bc906853e	fix: call focus on native window on call to webContents.focus on mac (#22323 ) * fix: call focus on native window on call to webContents.focus on mac On mac call to web_contents()->Focus() is not enough so it's necessary to call it on native window. * fixup! fix: call focus on native window on call to webContents.focus on mac * fixup! fix: call focus on native window on call to webContents.focus on mac * test: close all windows after test * fix: also match the behavior on Linux Co-authored-by: Cheng Zhao <zcbenz@github.com>	2020-03-02 16:51:02 +09:00
Cheng Zhao	4c6150ea3d	fix: make webRequest work for CORS preflight requests (#22407 ) * fix: support CORS preflight * test: webRequest should work for CORS requests	2020-03-02 10:23:43 +09:00
Shelley Vohr	2c974915a3	fix: do not call close on sheets themselves (#22410 )	2020-02-28 23:10:21 +00:00
Samuel Attard	4323b6d618	chore: add tests for the spellchecker (#22099 ) * chore: add tests for the spellchecker * chore: do not run spellchecker tests on windows	2020-02-26 17:29:19 -08:00
Samuel Attard	ee04c7f7ee	fix: allow persistent media salts (#22386 ) * fix: allow persistent media salts * chore: add regression test for persistent media device ids across reloads	2020-02-26 16:03:55 -08:00
Erick Zhao	85ef762269	fix: guard against duplicate TouchBarItem IDs (#22272 ) * feat: Add OtherItemsProxy touchbar item * review! * fix: guard against duplicate TouchBarItem IDs * add spec	2020-02-26 22:12:56 +00:00
Samuel Attard	12c1d4411d	chore: add deprecation warning on setting app.allowRendererProcessReuse to false (#22337 ) * chore: add deprecation warning on setting app.allowRendererProcessReuse to false * fix: no deprecation warnings in process reuse spec * chore: add test for new deprecate removeProperty behavior	2020-02-26 14:03:52 -08:00
Samuel Attard	7b7def7d1e	feat: set app.enableRendererProcessReuse to true by default (#22336 ) * feat: set app.enableRendererProcessReuse to true by default * chore: add context aware info to breaking changes doc * spec: fix nodeIntegration in child windows test for rendererprocessreuse * spec: fix remote listeners in destroyed renderers spec as the error is now async * Update api-browser-window-spec.ts * chore: deprecate affinity * chore: fix docs * spec: handle tests crashing without an exist code * spec: update tests for new rendererprocessreuse default * spec: with renderer process re-use we get to destroy less views	2020-02-24 18:11:06 -08:00
Erick Zhao	1848e3f658	feat: Add OtherItemsProxy TouchBar item (#22270 ) * feat: Add OtherItemsProxy touchbar item * review!	2020-02-24 17:55:06 +09:00
Samuel Maddock	68c6d53156	feat(extensions): add more properties to extension object (#22244 )	2020-02-24 12:30:32 +09:00
Jeremy Apthorp	a25d7fa440	fix: emit will-navigate for sandboxed contents (#22188 )	2020-02-21 11:08:26 -08:00
John Kleinschmidt	e0c0875d6f	docs: update session.clearAuthCache (#22292 ) * docs: update session.clearAuthCache * Update specs to match doc change.	2020-02-21 13:40:45 -05:00
Samuel Attard	e7b0a9ca8f	feat: add API for receiving logs from service workers (#20624 ) * feat: add API for receiving logs from service workers * feat: add new serviceWorkerContext APIs * chore: add missing #include's * refactor: rename serviceWorkerContext to serviceWorkers * chore: clean up based on review * chore: remove native_mate * chore: add tests for the service worker module * Update spec-main/api-service-workers-spec.ts Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org> * chore: fix linting * chore: handle renames Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>	2020-02-20 15:19:06 -08:00
Shelley Vohr	6ed396df17	fix: crash on custom printing margins (#22164 )	2020-02-13 11:15:25 -06:00
Jeremy Apthorp	d590f2efe3	feat: enable pdf viewer (#21794 )	2020-02-12 16:39:12 -08:00
Cheng Zhao	c608d6d7fb	fix: make webRequest work with WebSocket (#22040 ) * fix: web request support proxying websocket * fix: make tests work * chore: do not use api:: code outside api/ folder * chore: do not create proxy when no listener * test: use separate session to avoid conflicts * chore: address review	2020-02-11 14:56:09 +09:00
Cheng Zhao	9ad6f06831	fix: remove cyclic references of BrowserWindow (#22006 ) * fix: remove cyclic references in BrowserWindow * fix: prevent TopLevelWindow from garbage collection * test: garbage collection of BrowserWindow * chore: createIDWeakMap is used in tests	2020-02-11 09:37:46 +09:00
Jeremy Apthorp	b77f701aeb	feat: disable the remote module by default (#22091 )	2020-02-10 10:49:09 -08:00
Jeremy Apthorp	af631f8204	fix: disallow loading extensions in temp sessions (#22090 ) * fix: disallow loading extensions in temp sessions * docs	2020-02-10 10:28:03 -06:00
Shelley Vohr	83124889e5	feat: enable passing Node.js cli flags (#21110 ) * feat: enable passing Node.js cli flags * Allow cli flags in ELECTRON_RUN_AS_NODE mode	2020-02-07 02:59:38 +00:00
Jeremy Apthorp	9107157073	feat: [extensions] support extension.getBackgroundPage (#21951 ) * feat: [extensions] support extension.getBackgroundPage * cleanup * how does c++ * tests * test for runtime.getBackgroundPage too	2020-02-06 16:42:34 -05:00
Cheng Zhao	629c2121ba	chore: print more logging for failed tests (#22060 )	2020-02-06 11:15:55 -05:00
Shelley Vohr	303ca10846	feat: allow macOS apps to set activation policies (#21983 )	2020-02-05 19:12:25 +00:00
Shelley Vohr	928175bdfe	feat: allow specifying pageSize for print (#22014 )	2020-02-05 04:25:02 +00:00
Charles Kerr	c83f836faf	refactor: prefer using app.whenReady() (#21972 ) * docs: add references to app.whenReady() in isReady * refactor: prefer app.whenReady() In the docs, specs, and lib, replace instances of `app.once('ready')` (seen occasionally) and `app.on('ready')` (extremely common) with `app.whenReady()`. It's better to encourage users to use whenReady(): 1. it handles the edge case of registering for 'ready' after it's fired 2. it avoids the minor wart of leaving an active listener alive for an event that wll never fire again	2020-02-03 22:43:22 +00:00
Jeremy Apthorp	a061c87e56	feat: enable native extensions support (#21814 )	2020-02-03 14:01:10 -08:00
Jeremy Apthorp	720cf6eb27	test: add test for app.on('certificate-error') event (#21978 )	2020-01-31 15:25:01 -08:00
Jeremy Apthorp	1c6d8f5af6	fix: return path from netLog.stopLogging (#21985 )	2020-01-31 10:43:02 -08:00
bitdisaster	89eb309d0b	feat: allow GUID parameter to avoid systray demotion on Windows (#21891 ) * fix: systray icon demotion Adding support for GUID parameter in Tray API. In combination with signed binaries this allows to maintain the position in the systray on Windows. * unit tests * make mac and linux compile	2020-01-31 14:37:03 +09:00
Shelley Vohr	2955c67c4e	fix: prevent print crash on bad deviceName (#21946 ) * fix: prevent print crash on bad deviceName * address review feedback	2020-01-31 11:49:13 +09:00
Shelley Vohr	23382e6e08	test: check actual output generated from printToPDF (#21949 )	2020-01-30 20:12:35 +00:00
Electron Bot	2b53788c35	chore: bump chromium to 4b6692e4cc2839729bb7ac009586a (master) (#21864 ) * chore: bump chromium in DEPS to a1ea0d7aedd6b5fe58fbabfa3b05aa8ee41304ff * update patches * update extensions code * Remove WebPoint https://chromium-review.googlesource.com/c/chromium/src/+/2007474 * fix build * chore: bump chromium in DEPS to 9351e26c2a3714f8bbb10789c71bb51b0b494c75 * update patches * Remove error description from the DidFailLoadWithError message https://chromium-review.googlesource.com/c/chromium/src/+/2011280 * Make SimpleNetworkHintsHandlerImpl use the right NetworkIsolationKey https://chromium-review.googlesource.com/c/chromium/src/+/1994430 * Rename libgtkui to gtk https://chromium-review.googlesource.com/c/chromium/src/+/2011683 * [metrics] Remove histogram Startup.WarmStartTimeFromRemoteProcessStart. https://chromium-review.googlesource.com/c/chromium/src/+/2003211 fix requestSingleInstanceLock test * chore: bump chromium in DEPS to a813567a4f17ea08292c2b26fa10d0ffd47010d9 * chore: bump chromium in DEPS to f0aca2de536ceecd6eb66e928051d11e6d11991f * chore: bump chromium in DEPS to 865556af6d0c9d990f5b1816cb792f7c3859667b * chore: bump chromium in DEPS to 98538fdd28c4b6692e4cc2839729bb7ac009586a * update patches * fix broken tests * Update node tests for v8 changes * Update node patches for test failures * Update for number of tests Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net> Co-authored-by: John Kleinschmidt <jkleinsc@github.com>	2020-01-29 07:01:37 -05:00
Hye Sung Jung	0bd8a97f38	update (#21915 )	2020-01-29 18:42:25 +09:00
Shelley Vohr	548b290ea7	feat: add more options to printToPDF (#21906 )	2020-01-28 20:47:24 +00:00
Cheng Zhao	0209302d84	test: use exit event to wait for process exit (#21865 )	2020-01-27 10:29:50 +09:00
Cheng Zhao	74acd17771	test: make window.history.pushState test more robust (#21875 )	2020-01-23 10:51:41 -08:00
Shelley Vohr	b90537a629	feat: add tray.closeContextMenu() (#21807 )	2020-01-22 15:25:17 -08:00
Cheng Zhao	fbc2f8344f	fix: crash when doing redirect navigation with webRequest listener (#21838 ) * fix: pass navigation_ui_data to proxying factory * fix: clone response instead of move in redirect	2020-01-22 10:31:10 +09:00
Cheng Zhao	36fac7bfec	fix: call SetCanActivate in setFocusable (#21846 )	2020-01-22 10:13:48 +09:00
Jeremy Apthorp	acb5b75057	chore: [extensions] support old APIs when enable_electron_extensions = true (#21812 )	2020-01-21 09:42:55 -08:00
Cheng Zhao	42d8933d66	fix: crash when restoring minimized hidden window (#21813 )	2020-01-17 11:29:01 -08:00
Shelley Vohr	1e99907acc	fix: printToPDF failing to generate PDF (#21783 )	2020-01-15 21:05:36 -08:00
Jeremy Apthorp	b9eb68c0b4	feat: [extensions] implement a couple of tabs APIs (#21779 )	2020-01-15 15:11:51 -08:00
Jeremy Apthorp	55368e4d97	feat: just enough //extensions to load a simple devtools extension (#19515 )	2020-01-14 16:20:30 -08:00
Cheng Zhao	ceacadb4f4	fix: pass full response headers in net module (#21552 )	2020-01-14 09:36:08 -08:00
Jeremy Apthorp	fa42b5980e	feat: flesh out the api for //extensions (#21587 )	2020-01-13 14:56:28 -08:00
Jeremy Apthorp	8bc0c92137	feat: [extensions] background pages (#21591 )	2020-01-13 14:55:58 -08:00
Jeremy Apthorp	d68f17b32c	fix: stream protocols not completing (#21733 )	2020-01-13 10:28:21 -08:00
Jeremy Apthorp	768a6ace1b	test: move some fixtures from spec/ to spec-main/ (#21403 )	2020-01-09 11:50:56 -08:00
Cheng Zhao	8a92b65fd3	test: retry for a few flaky tests (#21658 )	2020-01-09 11:50:30 -08:00
Milan Burda	31c93fec67	fix: load window-setup in sandboxed renderer (#21416 )	2020-01-06 22:23:03 +01:00
Jeremy Apthorp	1cac62f0a2	feat: remove deprecated base::Value-based serialization (#21560 ) * feat: remove deprecated base::Value-based serialization * add note to breaking-changes	2019-12-18 15:24:50 +09:00
Jeremy Apthorp	54b4756a29	refactor: try just using regular [Sync] for MessageSync (#20797 )	2019-12-17 11:35:28 -08:00
Shelley Vohr	dba8a0caa8	feat: enable explicit IAP restoration (#21461 )	2019-12-17 07:07:11 -08:00
Victor Bennich	cf833a7650	feat: add win.getBackgroundColor() for macOS (#21448 ) thanks @vbennich - great work on this 🌟	2019-12-13 11:08:30 -05:00
Cheng Zhao	f9a1dc10fe	fix: quit after Chromium is fully started (#21488 ) * fix: quit when chromium is fully started * test: remove hacks on app.quit * chore: RunUntilIdle is unnecessary	2019-12-13 18:57:02 +09:00
Cheng Zhao	d5192853f9	fix: name and expirationDate should be optional when setting cookie (#21454 ) * fix: correctly set cookie date * fix: name is not required for setting cookie * test: clear cookie after each cookie test * test: should test session property * chore: style fixes	2019-12-11 16:44:49 +09:00
loc	5cecc230fb	fix: restore POST forms that open a new window with target=_blank (#21469 ) * fix: restore parts of original ResourceRequestBody V8 conversion Restore some of the original conversion logic in order to fix target=_blank post form submissions. * test: add test for POST form submission	2019-12-11 15:46:25 +09:00
Electron Bot	49b47ee4ed	chore: bump chromium to f755b70e34659441e72c1a928a406 (master) (#21000 )	2019-12-10 16:22:35 -08:00
Cheng Zhao	3cb0ed306b	fix: hiding window menu should work on startup (#21436 ) * fix: menu visibility should not be overwritten on startup * fix: removing menu for window without global menubar * test: setMenu tests are not for mac	2019-12-09 11:17:36 -08:00
Jeremy Apthorp	7f6b308bf1	test: move remote specs to main process (#21387 )	2019-12-09 10:27:30 -08:00
Jeremy Apthorp	092e00f7f0	fix: fix ClientRequest.getUploadProgress (#21388 )	2019-12-06 13:14:44 -08:00
Samuel Attard	ee58d60612	fix: ensure no node globals passively leak when nodeIntegration is disabled (#21342 )	2019-12-02 10:09:47 -08:00
Jeremy Apthorp	f09cb114e4	test: retry beforeunload tests up to 3 times (#21293 )	2019-11-27 09:42:54 -08:00
Jeremy Apthorp	d25256dcf5	refactor: rewrite the net module to simplify state tracking (#21244 )	2019-11-26 17:01:13 -08:00
OJ Kwon	ca61d2fae7	fix: allow reading body from non-2xx responses in net.request (#21055 ) * fix(urlrequest): allow non-2xx repsponse results - closes #21046 * test(net): add test cases to verify non-2xx body * test(session): update spec to match clientrequest behavior * test(net): update test cases to match clientrequest behavior * spec: clean up async net spec	2019-11-25 14:34:25 -08:00
Jeremy Apthorp	2e25999c52	test: refactor net tests (#21265 )	2019-11-25 12:56:18 -08:00
Shelley Vohr	d20273f95b	chore: improve nativeImage path converter error (#21243 )	2019-11-22 19:16:43 -08:00
Samuel Attard	34452ee69e	feat: expose executeJavaScriptInIsolatedWorld on webContents (#21190 ) * feat: expose executeJavaScriptInIsolatedWorld on webContents * Apply suggestions from code review Co-Authored-By: loc <andy@slack-corp.com>	2019-11-22 15:33:55 -08:00
Milan Burda	3f2cb91a35	refactor: declare KeyWeakMap<K, V> returned by createIDWeakMap() / createDoubleIDWeakMap() (#21171 )	2019-11-21 13:32:31 +01:00

... 4 5 6 7 8 ...

738 commits