Cheng Zhao
3b81312cf7
clear pointer when WebContents is closed
2018-05-21 10:53:09 +09:00
Cheng Zhao
51db1efb8a
prevent double-adding a WebContents to view
2018-05-21 10:53:09 +09:00
Cheng Zhao
aeeb2a259f
destruct objects in stack order
2018-05-21 10:53:09 +09:00
Cheng Zhao
fd4a0626c5
destroy WebContents when view is destroyed
2018-05-21 10:53:08 +09:00
htk3
7c2303c758
Correct app-command name of APPCOMMAND_MEDIA_PLAY_PAUSE ( #12408 )
...
* correct app-command name
* add compatibility with old app-command name
* add temporary compatibility with old app-command name
* add a comment saying that media-play_pause is deprecated
* fix lint
2018-05-21 10:52:04 +09:00
Nitish Sakhawalkar
b842a4b133
update mac symbol dump ( #12982 )
...
* Update mac symbol dump
Update posix generate_breakpad_symbols.py file to use argparse instead of deprecated optparse.
Also, make changes to the posix generate_breakpad_symbols.py file to accept multiple binaries.
And update dump-symbols.py to get symbols for the mac helper app as well.
* Changes to appease the linter
2018-05-21 10:01:17 +09:00
Milan Burda
7c19ae302e
replace isEventEmitter with instanceof EventEmitter (rpc-server) ( #12998 )
2018-05-21 10:00:56 +09:00
Heilig Benedek
8b2bffcf9e
Only expand maximum size constraint if there was a constraint originally ( #13003 )
2018-05-21 10:56:45 +10:00
Jeremy Apthorp
156a97b80d
fix: Menu.setApplicationMenu(null) crash on Linux ( #12983 )
2018-05-18 10:29:28 -07:00
Milan Burda
a0a5e4abb2
Bump vendor/native_mate
2018-05-18 16:30:20 +02:00
John Kleinschmidt
91173320e6
Merge pull request #12987 from electron/fix-arm-release-build
...
Fix ARM Release build
2018-05-18 08:17:06 -04:00
Felix Rieseberg
f087f8e205
docs: Document missing quit events during shutdown ( #12986 )
...
* docs: Document missing events during shutdown
2018-05-18 07:27:44 -04:00
John Kleinschmidt
7177e941eb
Merge pull request #12993 from electron/electron-download-4.x
...
feat: upgrade electron-download to 4.x
2018-05-18 07:20:42 -04:00
John Kleinschmidt
3fbc3869dc
Merge pull request #12991 from electron/drop-arm-alias-builds
...
build: don't upload aliased arm builds anymore
2018-05-18 07:19:17 -04:00
Mark Lee
cda13e5e79
feat: upgrade electron-download to 4.x
...
This is a breaking change, as it causes the `electron` module to require
Node 4.x (which has been EOL'd anyway).
Upgrading adds features such as a customizable cache location (via the
`ELECTRON_CACHE` environment variable).
Originally merged in https://github.com/electron/electron/pull/10922 but
was reverted because it was going into a version of Electron that did
not allow breaking changes.
2018-05-17 23:16:27 -07:00
Mark Lee
022ffe69e0
Don't upload aliased arm builds anymore
...
They are literally a copy/paste of the armv7l builds, and have been
deprecated ever since they were renamed 2 years ago.
2018-05-17 22:22:46 -07:00
Milan Burda
5a5eb43359
detect EventEmitter in removeRemoteListenersAndLogWarning ( #12975 )
2018-05-18 11:09:25 +09:00
Cheng Zhao
5f461cd5cd
fix release build on arm
2018-05-18 10:50:31 +09:00
Milan Burda
850051463b
don't use native_mate/compat.h macros ( #12984 )
2018-05-18 09:08:28 +09:00
Shelley Vohr
83993fede8
update locale documentation ( #12967 )
2018-05-17 10:34:54 -07:00
Zhuo Lu
d2653e8192
Fix: Prevent menu update while it's open ( #12809 )
...
* Update application menu on default runloop
Menu change should be prevented while the menu is open
* Fix code style
* Memory safety
2018-05-17 11:19:28 +10:00
Shelley Vohr
f068ed9ee7
fix docs formatting for ts defs ( #12968 )
2018-05-16 14:59:44 -07:00
Felix Rieseberg
e8735cc005
docs: Document Python TLS requirements ( #12276 )
...
* 🔧 Add simple test script
* 📝 Add documentation
* 🔧 It works, use it
* 🔧 Make the linter happy
* 🔧 Check on bootstrap
* Trivial copyediting
s/operation system/operating system/
2018-05-16 14:19:49 -07:00
Jeremy Apthorp
b160093b91
refactor: GN builds on linux ( #12957 )
2018-05-16 12:51:11 -07:00
Jeremy Apthorp
da0fd10423
refactor: chromium-style warnings in linux code ( #12949 )
2018-05-16 14:12:45 -05:00
Mod John
2a161e1725
Fix broken link ( #12387 )
...
* Fix broken link
Link was producing a 404 error as the file no longer exists. Wasn't sure where this intended link used to go so took a guess at a appropriate target.
* Update quick-start.md
2018-05-16 10:23:46 -07:00
John Kleinschmidt
04855bc499
Merge pull request #12921 from electron/commit-package-lock
...
Add package-lock.json
2018-05-16 11:47:21 -04:00
John Kleinschmidt
2b26206ea2
Merge pull request #12844 from didrocks/fix-communitheme-session
...
fix: support multiple inherited ubuntu session for indicators
2018-05-16 11:44:04 -04:00
John Kleinschmidt
9488ef4867
Merge pull request #12496 from mikeykhalil/8952-ignore-tray-double-click-events
...
8952 option to ignore tray double click events
2018-05-16 10:17:36 -04:00
John Kleinschmidt
e1c374de6e
Merge pull request #12954 from electron/web-dialog-helper
...
Fix empty description when only one extension is given (GetFileTypesFromAcceptType)
2018-05-16 10:15:54 -04:00
Didier Roche
6feec2e2a5
Fix linting error
...
Thx @MarshallOfSound
2018-05-16 14:34:13 +02:00
Milan Burda
211d7825d3
feat: DIP <-> screen coordinate conversions ( #12879 )
2018-05-16 18:34:09 +09:00
Milan Burda
9d9d6ca20b
Fix empty description when only one extension is given
2018-05-16 01:58:58 +02:00
Jeremy Apthorp
73eb5af2cc
refactor: remove unnecessary std::moves in linux code ( #12951 )
...
The compiler was complaining that the move was preventing copy elision.
2018-05-15 14:33:47 -07:00
Jeremy Apthorp
8fa48d1c04
fix: unused variable warnings in linux code ( #12950 )
2018-05-15 13:49:27 -05:00
Jeremy Apthorp
c4134c3516
refactor: breakpad #includes to work with GN and GYP ( #12953 )
2018-05-15 11:33:19 -07:00
Jeremy Apthorp
136105e353
fix: wrong list index type in file_dialog_gtk.cc ( #12952 )
2018-05-15 13:22:52 -05:00
Jeremy Apthorp
0fb6dc79d8
Merge pull request #12948 from nornagon/node-config
...
[gn] Include node/common.gypi when building node
2018-05-15 10:42:29 -07:00
Jeremy Apthorp
7a36322432
[gn] Include node/common.gypi when building node
...
Not sure how this ever worked, but the GN build certainly doesn't work
on Linux without this.
2018-05-15 09:53:24 -07:00
Milan Burda
6a4d9309b2
Remove unnecessary heap allocations of atom::V8ValueConverter instances ( #12924 )
2018-05-15 09:21:23 -05:00
Cheng Zhao
9fc6b9dda2
Merge pull request #12858 from electron/api-view
...
Refactor NativeWindow (Part 13): Add View and WebContentsView APIs
2018-05-15 22:05:27 +09:00
Cheng Zhao
2f3fcb9dbe
give window a default content view
...
Certain APIs are expecting the window to have a content view, having a
default one simplifies our design.
2018-05-15 14:12:47 +09:00
Cheng Zhao
ea97f43145
check content view in SetMenuBarVisibility
2018-05-15 14:12:47 +09:00
Cheng Zhao
bb2715e7a5
feat: add TopLevelWindow.setContentView API
2018-05-15 14:12:47 +09:00
Cheng Zhao
2b24b26e59
refactor: do not pass WebContents to NativeWindow
2018-05-15 14:03:21 +09:00
Cheng Zhao
640877ebf8
attach native view after widget is created
2018-05-15 14:03:21 +09:00
Cheng Zhao
5a320222e2
feat: add WebContentsView API
2018-05-15 14:03:21 +09:00
Cheng Zhao
e058d11657
feat: add View API
2018-05-15 14:03:21 +09:00
Cheng Zhao
874af5c982
Merge pull request #12837 from nornagon/build-gn
...
GN build
2018-05-15 14:02:51 +09:00
Milan Burda
56cdf94f95
Fix contents.setSize(options) documentation in web-contents.md ( #12922 )
2018-05-15 10:17:04 +10:00