Commit graph

2715 commits

Author SHA1 Message Date
Cheng Zhao
4ff7976060
fix: add missing require in chromium-spec () 2018-12-20 16:58:46 +09:00
Milan Burda
547097b036 security: allow to block desktopCapturer.getSources() calls ()
* security: allow to block desktopCapturer.getSources() calls

* return empty instead of error

* fix: release resources of DesktopCapturer on exit
2018-12-20 11:44:30 +09:00
Pedro Pontes
9c783f53ba fix: do not allow the window to grab focus when tabbing / shift+tabbing ()
* fix: do not allow the window to grab focus when tabbing / shift+tabbing

* test: add tests.
2018-12-18 23:44:51 -07:00
Jeremy Apthorp
ed3e5739dc test: promisify a bunch of tests ()
* test: promisify a bunch of tests

* fix lint

* fix affinity tests

* more cowbell^Wawait

* less done
2018-12-18 23:44:03 -07:00
David Baker
cc85946f55 feat: Support response headers in File protocol handler ()
* feat: Support response headers in File protocol handler

* bugfix: Null check headers value & fix tests

* refactor: Use non-deprecated FindKeyOfType
2018-12-18 23:17:02 -07:00
Alex Greenland
dc93d94bc8 fix: support async child process methods without callback in asar ()
* fix: support async child process methods without callback in asar

* fix: support async child process methods without callback in asar (improved)
2018-12-18 16:27:39 +09:00
Cheng Zhao
8584c2f14b
fix: register webview in main world when using contextIsolation () 2018-12-14 15:38:35 +09:00
Simone Cattaneo
649633bbb7 fix: make 'setParentWindow' compatible under Windows () 2018-12-12 16:05:16 -08:00
Jeremy Apthorp
1152fecb75
test: fix flaky before-input-event test () 2018-12-11 17:01:48 -08:00
Cheng Zhao
624ade2c25 fix: return pointer instead of pointer's content () 2018-12-11 12:45:55 -05:00
Shelley Vohr
163361ee6a chore: disable bump-version on arm32 () 2018-12-10 10:57:44 -08:00
Shelley Vohr
4b18a38e9f
chore: simplify promisify helper ()
chore: simplify promisify helper
2018-12-10 08:13:09 -08:00
Jeremy Apthorp
442c1b22e3
feat: webContents.loadURL returns a promise () 2018-12-06 12:16:19 -08:00
Shelley Vohr
1b8c11121f
chore: convert bump script to js () 2018-12-06 11:00:10 -08:00
Jeremy Apthorp
2845267c18
feat: support mixed-sandbox mode on linux () 2018-12-05 17:42:12 -08:00
Shelley Vohr
3f15f51615
feat: promisify app.getFileIcon() () 2018-12-05 08:50:12 -08:00
Milan Burda
d561c5531b feat: deprecate modules internally using remote.require in sandboxed renderer context () 2018-12-05 10:34:09 +01:00
Pedro Pontes
d5d1fa8290 fix: use appropriate site instance for cross-site nav's ()
* fix: use Chromium's determined new site instance as candidate when navigating.

When navigating to a new address, consider using Chromium's determined site instance
for the new page as it should belong to an existing browsing instance when the
navigation was triggered by window.open().

fixes 8100.

* Revert "fix: use Chromium's determined new site instance as candidate when navigating."

This reverts commit eb95f935654a2c4d4457821297670836c10fdfd5.

* fix: delegate site instance creation back to content when sandboxed.

* fix: ensure site isolation is on

* test: adapt ut for cross-site navigation

* fix: register pending processes during a navigation.

* refactor: dont call loadURL for a window constructed from an existing webContents.

* test: add sandboxed affinity UT's.

* fix: check affinity before deciding if to force a new site instance.

* chore: adapt subsequent patch.

* refactor: constify logically const methods.

* fix: do not reuse site instances when navigation redirects cross-site.

* test: ensure localStorage accessible after x-site redirect.

* test: adapt localStorage acess denied UT for site isolation.

* fix: do not send render-view-deleted for speculative frames.

* chore: amend tests after rebase.

* test: add ut for webContents' render-view-deleted emission

* fix: introduce current-render-view-deleted for current RVH's deletions.

Revert render-view-deleted to being emitted with any RVH's deletion.
current-render-view-deleted is emitted only when the RVH being deleted
is the current one.

* refactor: style and comments fixed.
2018-12-05 17:03:39 +09:00
Shelley Vohr
46e7214974
chore: remove electabul () 2018-12-04 20:50:37 -08:00
Cheng Zhao
ca7dec2082 fix: default prop of location should be empty str 2018-12-04 17:11:26 +09:00
Cheng Zhao
fc4e10b6c0 fix: set setter of window.location 2018-12-04 16:23:52 +09:00
Shelley Vohr
a1a431eb87
fix: make windowMenu role correct on MacOS () 2018-12-03 11:52:46 -08:00
Heilig Benedek
6deb7afb82 fix: reimplement FrameSubscriber with mojo, re-enable tests 2018-12-03 20:07:43 +05:30
deepak1556
00294a5b25 FIXME: disable some specs 2018-12-03 20:07:42 +05:30
deepak1556
c491fa59df spec: update inspector-binding.js
* https://github.com/nodejs/node/pull/22251
* https://github.com/nodejs/node/pull/20137
2018-12-03 20:07:42 +05:30
deepak1556
d97cf8c438 spec: force create network context for proxy tests 2018-12-03 20:07:42 +05:30
Heilig Benedek
78b88a70bb fix: backport patch that ensures that cookie store is always created ()
* fix: backport patch that ensures that cookie store is always created

* fix: disable cookie encryption

* fix: flush the cookie store when NetworkContext shuts down

* test: add test for cookie store persistance

* Update patches/common/chromium/ensure_cookie_store.patch

Co-Authored-By: brenca <benecene@gmail.com>

* Update patches/common/chromium/ensure_cookie_store.patch

Co-Authored-By: brenca <benecene@gmail.com>
2018-11-29 10:51:13 -08:00
Jeremy Apthorp
30109d64f2
test: fix a bunch of flaky tests related to emittedOnce () 2018-11-28 17:52:19 -08:00
Nitish Sakhawalkar
9890d1e251 feat: Implement process.getProcessMemoryInfo to get the process memory usage ()
* feat: Implement process.getMemoryFootprint to get the process memory usage

* Add spec

* fix: must enter node env in callback

* Update function call

* Update spec

* Update API data

* update spec

* Update include

* update test for shared bytes

* Update atom/common/api/atom_bindings.cc

Co-Authored-By: nitsakh <nitsakh@icloud.com>

* Update atom/common/api/atom_bindings.cc

Co-Authored-By: nitsakh <nitsakh@icloud.com>

* Update API

* Update the callback isolate

* Update to work after app ready

* Update docs

* Update docs/api/process.md

Co-Authored-By: nitsakh <nitsakh@icloud.com>

* Update docs/api/process.md

Co-Authored-By: nitsakh <nitsakh@icloud.com>

* Fix crash
2018-11-28 17:57:53 +09:00
Shelley Vohr
41c2685204
feat: promisify win.capturePage() ()
* feat: promisify win.capturePage

* mark optional arg correctly

* Add to breaking changes doc

* properly deprecate win.capturePage

* remove change from api-contract

* document both callback and promise versions

* address docs feedback

* update promisification progress doc
2018-11-27 23:50:53 -05:00
Jeremy Apthorp
5d54d42953 test: fix remote-debugging-port test calling done twice () 2018-11-28 10:59:05 +09:00
Jeremy Apthorp
455f0669e7
fix: add missing shell_resources.pak to repack target () 2018-11-27 11:18:18 -08:00
Milan Burda
d63a848011 feat: add activate option to webContents.openDevTools () 2018-11-27 18:34:44 +09:00
Cheng Zhao
63874da087 test: add test for window.open in BrowserView 2018-11-27 11:10:07 +09:00
Samuel Attard
f02f9ba9fb chore: add spec for --inspect after a -- () 2018-11-20 16:23:50 -05:00
Ondřej Záruba
de05ff894b feat: Add app.getLocaleCountryCode() method for region detection ()
* Add method to get system´s user region

* Fix linter

* Remove auto types

* Improved detection for POSIX

* Change name, add specs, minor fixes

* Remove left overs

* Fix locale test

* Fix Linux test

* Coding style fixes

* Fix docs

* Add test excaption for Linux

* fix spelling

* Polishing
2018-11-20 15:33:23 -05:00
Pedro Pontes
57d2ae1aec revert: "fix: window.open site instance should belong to same browsing instance ()" ()
This reverts commit 8f35198bfb.
2018-11-20 21:28:26 +01:00
Jeremy Apthorp
0642be296d
fix: crash in sandbox on linux when getting execPath () 2018-11-15 12:59:01 -08:00
Shelley Vohr
565e4c5910
chore: fix window width in spec for win () 2018-11-13 11:31:03 -05:00
Pedro Pontes
8f35198bfb fix: window.open site instance should belong to same browsing instance () 2018-11-12 22:01:43 +01:00
Shelley Vohr
c06f023313
feat: allow partial setting of window bounds ()
Extend the existing win.setBounds functionality by allowing developers to partially update bounds without being forced to pass in all four bounds values. No existing functionality is altere
2018-11-12 15:31:14 -05:00
Jacob
b21dbdb20d fix: bypass DOM storage quota () 2018-11-12 18:19:01 +01:00
Nitish Sakhawalkar
5994bf6745
fix: Menu accelerators not working ()
This change fixes the regression in the menu accelerators working in linux, on some environments.
2018-11-09 13:54:16 -08:00
John Kleinschmidt
9e2b7dbea5
ci: add testing for mksnapshot ()
* ci: add testing for mksnapshot
2018-11-09 10:54:17 -04:00
Robo
82322968a3 refactor: printing implementation ()
* refactor: basic printing

* move build files to chromium_src/BUILD.gn
* remove dependency on chrome prerender sources

* spec: move printing specs behind feature flag

* build: register pdf compositor service
2018-11-09 14:42:34 +11:00
Cheng Zhao
746beb0d8b fix: destroy WebContents synchronously on shutdown () 2018-11-08 07:57:28 -08:00
Jeremy Apthorp
7e0e12b8a3 fix: match Chrome's font fallback behavior ()
* fix: match Chrome's font fallback behavior

Fixes 

* add a cache

* add test

* another test

* fix tests

* arial -> dejavu sans on linux apparently?
2018-11-08 10:51:51 -04:00
Heilig Benedek
ca2d74e118 feat: add methods to allow customization of save dialog during will-download event ()
* feat: add method to DownloadItem that allows customization of dialog options

* docs: add docs for get/setSaveDialogOptions

* add missing copy constructor for DialogSettings on mac and linux

* fix: don't filter dialog options for mas build, don't return properties

* test: add test for get/setSaveDialogOptions

* fix: remove openDevtools added for debugging

* test: fix failing test because of new event parameter

* docs: use SaveDialogOptions instead of Object
2018-11-08 10:51:06 -04:00
Shelley Vohr
e9ba26f50e
feat: allow registering multiple shortcuts ()
This PR allows for multiple global shortcuts to be registered such that triggering any of them calls the same callback.
2018-11-07 09:40:38 -08:00
Jeremy Apthorp
10969b8c3c
fix: make feature strings more robust to whitespace ()
Fixes 
2018-11-06 15:52:06 -08:00