Kevin Sawicki
4e5b8ac3ee
Remove throws and assert object directly
2017-01-30 09:38:15 -08:00
James Ide
0430380de1
Update the Node submodule to use the new module wrapper
...
See the fixed issue for the context. This pulls in a vendored copy of Node that includes the described patch.
Fixes #8358
Test Plan: Built Electron and verified it loaded the sample app correctly and that the module wrapper is the new one by viewing Node's source code in the Blink Inspector.
Added specs and tested with `npm test -- --grep "global variables"`
2017-01-30 09:37:14 -08:00
Kevin Sawicki
6e2f977f7a
Merge pull request #8511 from electron/start-drag-crash
...
Fix startDrag crash on macOS with empty image
2017-01-26 17:10:21 -08:00
Kevin Sawicki
76e5589a31
Schedule function after executeJavaScript completes
2017-01-26 16:15:10 -08:00
Kevin Sawicki
651ea7ef02
Merge pull request #8421 from oukan/feature/translate-zh-CN
...
translate zh cn
2017-01-26 15:48:57 -08:00
Kevin Sawicki
eb6d92d427
Mention image cannot be empty on macOS
2017-01-26 15:46:04 -08:00
Kevin Sawicki
e683f28e32
Require a non-empty drag image to prevent crash
2017-01-26 15:46:04 -08:00
Kevin Sawicki
8ce1930f0d
Add specs for missing startDrag options
2017-01-26 15:46:04 -08:00
Kevin Sawicki
2ee5f6f358
Merge pull request #8507 from electron/fix-node-upgrade-patches
...
Redo node 7.4 error handling patch
2017-01-26 15:43:58 -08:00
Kevin Sawicki
06c025050e
Fix typo in spec description
2017-01-26 14:46:51 -08:00
Kevin Sawicki
ff718b19db
Upgrade node for new 7.4 patches and changes
2017-01-26 14:46:50 -08:00
Kevin Sawicki
1004d205d8
Add spec for unhandledRejection event in main process
2017-01-26 14:46:50 -08:00
Kevin Sawicki
24fb560a9d
Add failing spec for uncaught main process errors
2017-01-26 14:46:50 -08:00
Kevin Sawicki
a4e25a8917
Merge pull request #8519 from electron/consolidate-panel-showing
...
Use helper function to show last dev tools panel
2017-01-26 14:44:45 -08:00
Kevin Sawicki
2cfa67bdff
Remove linter warning
2017-01-26 09:59:07 -08:00
Kevin Sawicki
a851695bb9
Clear interval before setting new one
2017-01-26 09:57:53 -08:00
Kevin Sawicki
e2e33a8cf0
Guard against destroyed window or web contents
2017-01-26 09:57:00 -08:00
Kevin Sawicki
515f689814
Use helper function to show last dev tools panel
2017-01-26 09:42:45 -08:00
Kevin Sawicki
640b03f7d0
Merge pull request #8510 from electron/empty-image-crashes
...
Fix empty image crashes
2017-01-26 09:08:52 -08:00
Kevin Sawicki
104cae8f68
Only call getNativeHandle on macOS
2017-01-25 14:26:05 -08:00
Kevin Sawicki
e1281342f6
Return empty buffers when image is empty
2017-01-25 14:26:05 -08:00
Kevin Sawicki
2ad46f1842
Add failing spec for empty image crashes
2017-01-25 14:26:05 -08:00
Kevin Sawicki
8e69f94df0
Merge pull request #8357 from electron/remote-events-error-message
...
Don't crash when calling stale remote listeners
2017-01-25 14:23:57 -08:00
Kevin Sawicki
330ac5f266
Fix standard linting error
2017-01-25 12:36:55 -08:00
Kevin Sawicki
56a8eb3a94
Check that sender is a WebContents instance
2017-01-25 12:36:55 -08:00
Charlie Hess
ddedcf22d1
Move console.warn inside the helper method.
2017-01-25 12:36:55 -08:00
Charlie Hess
f6410d3b77
Assert that listener count decreases after a remove event.
2017-01-25 12:36:55 -08:00
Charlie Hess
c213971a2d
Write a warning instead of crashing.
2017-01-25 12:36:55 -08:00
Charlie Hess
bc2f1e8199
Argh.
2017-01-25 12:36:55 -08:00
Charlie Hess
63d8137da2
Use EventEmitter public methods instead of _events.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
45986405b8
Assert remote event names
2017-01-25 12:36:55 -08:00
Charlie Hess
b04db2e546
Add a spec for the "renderer window closed" error.
2017-01-25 12:36:55 -08:00
Charlie Hess
a0b24bd155
Simplify.
2017-01-25 12:36:55 -08:00
Charlie Hess
67f7a60524
Review CommentZ
2017-01-25 12:36:55 -08:00
Charlie Hess
41ea169784
L I N T I N G P T I I
2017-01-25 12:36:55 -08:00
Charlie Hess
49c6446267
L I N T I N G
2017-01-25 12:36:55 -08:00
Charlie Hess
26e3ad3c2e
Display more information about remote event crashes.
...
If possible, we'll dig into the function args and print the ones that are attached remotely.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
c13ea6eb36
Merge pull request #8497 from electron/enable-crash-reporter-specs-on-ci
...
Run crash reporter server specs on CI
2017-01-25 10:54:56 -08:00
Kevin Sawicki
f104e019be
Run crash reporter server specs on CI
2017-01-25 10:36:16 -08:00
Kevin Sawicki
8e39aea34a
Merge pull request #8478 from deepak1556/load_url_max_char_patch
...
WebContents: emit did-fail-load event when url exceeds character limit
2017-01-25 09:46:40 -08:00
deepak1556
d8a16a8ffb
fix spec
2017-01-25 14:20:33 +05:30
Kevin Sawicki
90470617ab
Merge pull request #8430 from ramya-rao-a/crash-for-children-docs
...
Updated docs for crash reporter to support child processes
2017-01-24 14:08:36 -08:00
Kevin Sawicki
ce6a46ee59
Use template strings
2017-01-24 14:08:10 -08:00
Kevin Sawicki
108a3473ed
Use crashesDirectory in example
2017-01-24 14:07:00 -08:00
Kevin Sawicki
4985e073c4
Mention how to test
2017-01-24 14:04:56 -08:00
Kevin Sawicki
7b03c05b4e
Capitalize Electron, fence as JS
2017-01-24 14:03:54 -08:00
Kevin Sawicki
ce472315f4
Merge pull request #8109 from ramya-rao-a/crash-for-children
...
Expose crash reporter start for child node processes
2017-01-24 14:02:47 -08:00
Kevin Sawicki
43ef4faf79
🎨
2017-01-24 14:00:03 -08:00
Kevin Sawicki
795b674996
Add StartInstance helper on CrashReporter
2017-01-24 13:54:46 -08:00
Kevin Sawicki
170c51ae85
Add spec for crashing node process
2017-01-24 13:49:45 -08:00
