mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9930 commits 1 branch 183 tags 5.3 GiB
Commit graph

826 commits

Author SHA1 Message Date
Cheng Zhao
4d8994df92 spec: child_process.fork shouble be able to pipe stdio 2016-05-31 11:05:58 +09:00
Cheng Zhao
49f1278601 Refactor the URLRequestFetchJob code 
This makes the read end and write end of the pipe have same logic, so it
is more easy to maintain.
 2016-05-30 20:31:00 +09:00
Cheng Zhao
912cedc593 Merge pull request #5753 from deepak1556/url_request_fetch_job_patch 
protocol: store initial response data for when resource loader becomes ready
 2016-05-30 10:53:53 +00:00
Cheng Zhao
ce0d3d93ab spec: disablewebsecurity should not break preload and node integration 2016-05-30 15:23:09 +09:00
Cheng Zhao
a176aaee01 Merge pull request #5734 from danhp/fix-aspect-ratio 
Fix 'setAspectRatio(0)' not resetting the default behaviour.
 2016-05-30 01:14:03 +00:00
Cheng Zhao
9f0fc96025 Merge pull request #5711 from electron/extension-code-cleanup 
Implement partial chrome.* API for devtools extension
 2016-05-29 23:29:08 +00:00
Daniel Pham
34af9794a2 ✅ Add test for 'setAspectRatio(0)' 2016-05-29 08:47:42 -04:00
deepak1556
9d8af43617 add spec 2016-05-29 13:43:26 +05:30
Cheng Zhao
a58b84bbd7 spec: ipcRenderer.sendTo sends message to WebContents 2016-05-28 20:50:30 +09:00
Kevin Sawicki
fc4b224dec Add asserts for properties 2016-05-27 10:52:56 -07:00
Kevin Sawicki
7cf6be07a6 Add failing spec for remote property with no prototype 2016-05-27 10:45:39 -07:00
Kevin Sawicki
71b73a9cfb Use new APIs 2016-05-26 14:24:47 -07:00
Kevin Sawicki
69c69880e5 Tweak spec description 2016-05-25 09:12:52 -07:00
Kevin Sawicki
4e68a8d16e Remove logging in parent page 2016-05-25 09:12:52 -07:00
Kevin Sawicki
73b07f76a3 Support document visiblity state and events in webviews 2016-05-25 09:12:52 -07:00
Kevin Sawicki
1e15ce6ccd Add failing spec for webview visiblity changes 2016-05-25 09:12:52 -07:00
Cheng Zhao
28e2058ff1 Merge pull request #5648 from electron/chrome51 
Update to Chrome 51
 2016-05-24 10:59:11 +00:00
Cheng Zhao
cd444e82f9 Merge pull request #5666 from electron/remote-promise-reject 
Handle rejection of remote promises
 2016-05-24 04:30:25 +00:00
Kevin Sawicki
5e2f36387f Move require spec to api-app-spec 2016-05-23 15:14:55 -07:00
Kevin Sawicki
4a41311409 Test that calling regular module succeeds 2016-05-23 15:14:55 -07:00
Kevin Sawicki
fe0ec67623 Add spec for electron module require 2016-05-23 15:14:55 -07:00
Kevin Sawicki
f3af1dbd54 Add failing spec for rejected remote promise 2016-05-23 15:06:46 -07:00
Cheng Zhao
3402c7be3f Suppress ffi test on Windows 2016-05-23 23:31:00 +09:00
Cheng Zhao
fa0ce7ad5f Adjust to the new behaviors of beforeunload handler 2016-05-23 14:27:39 +09:00
Cheng Zhao
13b4c8bb06 Ignore invalid parameter error in crash service process 2016-05-23 08:59:34 +09:00
deepak1556
c9b314d43c renderer: generate net error strings when requested 2016-05-21 10:21:15 +05:30
Cheng Zhao
8ac93e02c6 Merge pull request #5616 from electron/inherit-zoom 
Inherit zoomFactor in webview
 2016-05-20 00:27:06 +00:00
Kevin Sawicki
b09c81202a Add test for webview zoomFactor inheritance 2016-05-19 14:46:52 -07:00
Juan Cruz Viotti
1a27ecdad4 Override child_process.execFile asar patch for child_process.exec 
NodeJS implements `child_process.exec` by simply passing the whole
command to `child_process.execFile`. See:

- https://github.com/nodejs/node/blob/master/lib/child_process.js#L90
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L99

Electron patches `child_process.execFile` to add support for `asar`
archives by injecting logic that extracts the required files from the
`asar` to a temporary location before delegating the work to the
original `child_process.execFile`.

In order to decide whether to inject the custom `asar` extracting logic,
Electron makes use of a helper function called `splitPath()`. See:

- https://github.com/electron/electron/blob/master/lib/common/asar.js#L37

If the first argument of the returned array equals `true`, means that
the path is considered to be an `asar` archive, and thus the extraction
logic takes place. The problem is that if the command passed to
`child_process.execFile` *contains* a path to an asar archive, padded
with other commands/arguments, `splitPath()` will consider it to be an
`asar` archive, and will try to extract it, throwing a rightfully
`Invalid package` error.

Fixes: https://github.com/electron/electron/issues/5571
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
 2016-05-19 17:19:36 -04:00
Cheng Zhao
242508e22f Merge pull request #5574 from electron/devtools-extension-test 
Add test that loads a devtools extension
 2016-05-18 01:46:44 +00:00
Kevin Sawicki
cee31ff67a Remove semicolon 2016-05-17 16:42:37 -07:00
Kevin Sawicki
9266f9abfc Update interval id variable name 2016-05-17 16:42:21 -07:00
Kevin Sawicki
f95c46d987 Show last panel by id 2016-05-17 16:40:34 -07:00
Kevin Sawicki
13cfc2d2a0 Add comment about panel switching via input event 2016-05-17 15:05:58 -07:00
Kevin Sawicki
8d0c5c30b8 Use consistent function styles 2016-05-17 15:05:27 -07:00
Kevin Sawicki
0b4b79d0a4 Use control on non-mac platforms 2016-05-17 15:01:32 -07:00
Kevin Sawicki
7db2601ea8 DRY up specs 2016-05-17 14:59:33 -07:00
Kevin Sawicki
77b074fbad Add spec for undocked devtools 2016-05-17 14:56:00 -07:00
Kevin Sawicki
189380d4ea Add spec for devtools extension 2016-05-17 14:52:45 -07:00
Cheng Zhao
90f52169af No more need to check for nodeIntegration when creating guest view 2016-05-17 17:06:02 +09:00
Cheng Zhao
0140015500 spec: WebView is disabled when nodeIntegration is disabled 2016-05-17 17:04:13 +09:00
Cheng Zhao
f43b9665c1 And increase timeout for the rest 2016-05-15 10:00:29 +09:00
Cheng Zhao
861a79dd6a Suppress the tests that need to call window.open on Travis CI 2016-05-15 09:41:02 +09:00
Cheng Zhao
0ad03d9ff7 Suppress crashReporter test on x64 Windows for now 2016-05-13 11:12:01 +09:00
Cheng Zhao
0f52a6da39 Merge branch '1-0-release' 2016-05-11 15:14:56 +09:00
Cheng Zhao
8e7a5adc60 spec: protocol.registerStandardSchemes does not throw 2016-05-10 09:57:13 +09:00
Cheng Zhao
797b0ddb9a Fix exception when refreshing specs window 2016-05-09 20:08:50 +09:00
Cheng Zhao
af0afecb45 Merge pull request #5406 from deepak1556/protocol_standard_scheme_patch 
protocol: fix registerStandardSchemes api
 2016-05-09 09:12:35 +09:00
Cheng Zhao
c682ccd9d0 Suppress the window.open tests on travis CI's mac machine 2016-05-08 15:15:16 +09:00
deepak1556
9c71c9fa6a fix docs and spec 2016-05-08 01:37:57 +05:30
deepak1556
0f2ae385ed allow protocol module initialization before app ready. 
* ensure registerStandardSchemes can only be called before app ready
 * ensure other protocol methods can only be used after app ready
 2016-05-08 01:36:34 +05:30
deepak1556
1ff33b7c81 protocol: fix registerStandardSchemes api 2016-05-08 01:36:34 +05:30
Kevin Sawicki
609f5dcaaf Update read path to something that exists 2016-05-06 10:12:55 -07:00
Kevin Sawicki
4d6b95aa52 Tweak spec description 2016-05-06 10:12:55 -07:00
Kevin Sawicki
0eefb282ca Test no handler via call to deprecate.log 2016-05-06 10:12:55 -07:00
Kevin Sawicki
722a07de86 Add explicit call to deprecate.log 2016-05-06 10:12:55 -07:00
Kevin Sawicki
58473f41ab Remove deprecated BrowserWindow options specs 2016-05-06 10:12:54 -07:00
Kevin Sawicki
bea232f53a Update specs for internal module require 2016-05-06 10:12:54 -07:00
Kevin Sawicki
ef801d5543 Remove .only call 2016-05-06 10:12:54 -07:00
Kevin Sawicki
a6cf7a1095 Remove deprecated crashReporter.start options 2016-05-06 10:12:53 -07:00
deepak1556
45b3bd3a22 ipcRenderer: fix crash with multiple listeners to sync message 2016-05-06 02:52:59 +05:30
Cheng Zhao
8e1d2479ac spec: Should not run app.setUserActivity test on non-OS X 2016-05-05 12:27:25 +09:00
Charlie Hess
7b207aa1b6 Don't run this spec on platforms where the method is unavailable. 2016-05-03 23:33:40 -07:00
Charlie Hess
12764a66ed Add an accessor for the current activity type and write the simplest possible test. 2016-05-03 15:51:31 -07:00
Cheng Zhao
f65f8918c9 Fix specs on Windows when running without desktop session 2016-04-30 21:03:22 +09:00
Cheng Zhao
214eb0430c Fix a few failing tests on Windows 2016-04-30 18:21:18 +09:00
Cheng Zhao
8aa88067ca Do not write to stdout in Electron when running on win32 CI machine 
This makes Electron crash on CI machine somehow.
 2016-04-30 17:08:51 +09:00
Zeke Sikelianos
9f99ba3b73 update all references to old atom-log bracket notation 2016-04-29 18:35:02 -07:00
deepak1556
d64e3784f4 renderer: fix desktop capture api not responding different subsequest calls 2016-04-28 14:24:22 +05:30
deepak1556
4e6b148eaa webContents: fix executejavascript when called before page load 2016-04-28 01:54:08 +05:30
Kevin Sawicki
e4bd592e0e Add failing spec 2016-04-21 11:49:42 -07:00
deepak1556
ca756c3c24 session: allow providing permission to handle external protocols 2016-04-21 05:27:07 +05:30
Cheng Zhao
aa29dc0c8a Merge pull request #5199 from Mr0grog/5183-disambiguate-loading-from-main-frame-loading 
Add `isLoadingMainFrame()` to WebContents
 2016-04-20 20:49:56 +09:00
Rob Brackett
d3e879cd7f Change WebContents::IsLoadingMainFrame to compare SiteInstances 
(per @deepak1556's recommendation)

Also updates tests to cover the situation where navigating between pages from the same potential "site" and adds generalized tests for `isLoadingMainFrame()`.
 2016-04-19 22:05:09 -07:00
deepak1556
794d120754 rename importClientCertificate => importCertificate 2016-04-20 08:45:49 +05:30
Rob Brackett
3a9bbe30ac Test for #5183 - webContents.executeJavaScript hangs on subframe load. 2016-04-18 10:33:56 -07:00
deepak1556
2c0494dcef fix spec 2016-04-18 22:57:37 +05:30
deepak1556
2ddac9352f add spec 2016-04-18 21:53:44 +05:30
Cheng Zhao
65c612a66d Avoid external URLs 2016-04-13 19:55:59 +09:00
Cheng Zhao
0a39449694 spec: loadUrl should not crash in did-fail-provisional-load handler 2016-04-13 19:39:11 +09:00
Cheng Zhao
bb70defcb8 spec: webview should work without script tag in page 2016-04-12 15:10:26 +09:00
Cheng Zhao
5efa075aca spec: preload attribute should work without script tag in page 2016-04-12 14:57:40 +09:00
Cheng Zhao
a07612c1ed Merge branch '5074-did-get-response-details-resource-type' of https://github.com/Mr0grog/electron into Mr0grog-5074-did-get-response-details-resource-type 2016-04-11 21:05:40 +09:00
Cheng Zhao
5659ee5c0b Merge pull request #5030 from deepak1556/webrequest_response_headers_patch 
session: webRequest.OnHeadersReceived should accept status line.
 2016-04-11 20:04:32 +09:00
Rob Brackett
15b042b5f6 Add support/tests for did-get-response-details event on <WebView> 2016-04-08 12:55:20 -07:00
Rob Brackett
c1b1348735 Add resourceType arg to webContents did-get-response-details event. 
Fixes #5074 and follows @zcbenz's recommendation to expose ResourceTypeToString from atom_network_delegate publicly.
Also adds testing for other arguments to the `did-get-response-details` events, since there were no existing tests for them.
 2016-04-08 11:19:36 -07:00
deepak1556
3fb39ad3ef provide option to override status line 2016-04-08 14:03:57 +05:30
Cheng Zhao
2f6796bd7f Disable throttling in tests 2016-04-08 15:57:14 +09:00
deepak1556
4fc35a4587 session: webRequest.OnHeadersReceived should follow server redirect 
Its required to follow server redirects.
 2016-04-08 11:40:43 +05:30
Cheng Zhao
82856eb099 Merge pull request #5029 from Mr0grog/5013-add-main-frame-param-for-did-fail-load 
Add `isMainFrame` param to WebContents `did-fail-load` event
 2016-04-07 20:22:02 +09:00
Cheng Zhao
dd283ff8d7 spec: We should not use pre release of Node 2016-04-05 19:53:07 +09:00
Cheng Zhao
c562b24df8 spec: Add test case for #5028 2016-04-05 17:08:27 +09:00
Rob Brackett
f12f87d6f0 Add isMainFrame as last argument to WebContents did-fail-load event. 
Fixes #5013.
 2016-04-04 19:26:06 -07:00
Cheng Zhao
19a172f2f5 Remove the hacks because of transparent background 2016-04-02 21:21:30 +09:00
Kevin Sawicki
527ff66115 Pull app/session from remote 2016-04-01 16:59:13 -07:00
Kevin Sawicki
3695e38719 Remove duplicate require 2016-04-01 16:53:44 -07:00
Kevin Sawicki
7734f6af62 Remove semicolons 2016-04-01 16:52:55 -07:00
Kevin Sawicki
909ed54bef Remove stray log 2016-04-01 16:52:28 -07:00
Kevin Sawicki
230ed78dd6 Remove lint warnings 2016-04-01 16:51:17 -07:00
Kevin Sawicki
ef2a28ca86 Listen for browser-window-created event for asserts 2016-04-01 16:50:20 -07:00
Kevin Sawicki
fd12e1f506 Add failing spec for webview nodeIntegration inheritance 2016-04-01 16:47:17 -07:00
Kevin Sawicki
4890734f66 Add missing title param 2016-04-01 16:42:53 -07:00
Kevin Sawicki
9e66df23d0 Add clearer assertion of process being undefined 2016-04-01 16:40:33 -07:00
Kevin Sawicki
d7b1792503 Use template strings 2016-04-01 16:39:31 -07:00
Kevin Sawicki
2713580d09 Remove stray log 2016-04-01 16:39:31 -07:00
Kevin Sawicki
777704e659 Add failing spec for nodeIntegration inheritance 2016-04-01 16:39:06 -07:00
Kevin Sawicki
3c96d7b726 Rename atom.asar to electron.asar in specs 2016-04-01 16:12:57 -07:00
Cheng Zhao
b35f4c1805 spec: Fix failing test due to path delimiter 2016-04-01 16:42:44 +09:00
Cheng Zhao
247b3f3605 Fix the background color in test app 2016-04-01 16:35:19 +09:00
Cheng Zhao
b9ead472a5 spec: Remote object should be referenced by methods in its prototype chain 2016-04-01 15:35:34 +09:00
Cheng Zhao
f36851fcff spec: Remote object should be referenced by its members 2016-04-01 15:05:05 +09:00
Zeke Sikelianos
7c58f7fb02 eradicate all per-file eslint globals 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
6425ef4261 restrict mocha scope to /spec; break out link tasks 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
b5afad9da7 avoid using eslint comment exceptions 2016-03-30 17:00:34 -07:00
Zeke Sikelianos
e6698102c9 standardize by hand 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
cfdfdc8ccc standardize by hand 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
14fb3c4598 throw error if it exists 2016-03-30 17:00:33 -07:00
Zeke Sikelianos
c5f70c8d99 dance around error checking with this one weird trick 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
5e4696f4a7 standardize more 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
9db733a4ff mostly more globals 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
c4b6cf4a8e do more manual cleanup and specify globals 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
f47fa25e39 tiptoe 2016-03-30 17:00:32 -07:00
Zeke Sikelianos
f35f362272 autoformat more files 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
bd9b0b8ed3 wrap conditional, because return can only be used in a function 2016-03-30 17:00:31 -07:00
Zeke Sikelianos
3855a774ab autoformat more easy files 2016-03-30 17:00:31 -07:00
Cheng Zhao
e08b48ab48 Merge pull request #4840 from atom/undefined-menu-accelerator 
Undefined menu accelerator
 2016-03-21 21:02:44 +09:00
Zeke Sikelianos
827730144b style nit 2016-03-18 10:53:49 -07:00
Zeke Sikelianos
e9ba5abe03 test for null accelerator too 2016-03-17 16:14:31 -07:00
Zeke Sikelianos
87395cdef8 add failing spec for undefined accelerator 2016-03-17 16:09:16 -07:00
Kevin Sawicki
737ffd8d7c Improve deprecated message on webPreferences options 2016-03-17 13:37:08 -07:00
Kevin Sawicki
2acfb8ad82 node-integration -> nodeIntegration 2016-03-17 13:37:07 -07:00
Kevin Sawicki
1b6e01ce6d Add missing semicolons 2016-03-17 13:37:07 -07:00
Kevin Sawicki
1e8e8f18b4 Add failing specs for deprecated options usage 2016-03-17 13:37:07 -07:00
Kevin Sawicki
5c9b19b508 web-preferences -> webPreferences 2016-03-17 13:37:07 -07:00
Cheng Zhao
081ab17e13 Merge pull request #4791 from atom/nativeimage-as-nsimage 
Convert NativeImage instances to OS-specific representations
 2016-03-17 21:49:46 +09:00
Paul Betts
148014f99a Fix spec failure 2016-03-16 12:42:23 -07:00
Paul Betts
fa197ad583 Fix failing test 2016-03-16 12:40:28 -07:00
Paul Betts
665d3166ed Update the tests 2016-03-14 21:00:58 -07:00
Cheng Zhao
73a5f323e7 Merge pull request #4788 from deepak1556/find_in_page_patch 
webcontents: provide position of match with found-in-page event
 2016-03-14 15:03:38 +09:00
Cheng Zhao
152e6af4b4 spec: Add test case for #4785 2016-03-14 14:54:45 +09:00
Paul Betts
248ac5c37b Add unit tests 2016-03-13 20:25:49 -07:00
Robo
8378cbb1e8 webcontents: provide position of match with found-in-page event 2016-03-14 06:49:45 +05:30
Todd Wolfson
7569d180c9 Added support for window.location on window.open windows 2016-03-12 18:05:01 -06:00
Cheng Zhao
71fb684069 spec: Skip webview.executeJavaScript in Travis on OS X 
It is very easy to get timeout.
 2016-03-12 09:18:12 +09:00
Cheng Zhao
6aec1e6949 Merge pull request #4714 from atom/chrome49 
Upgrade to Chrome 49
 2016-03-11 21:39:52 +09:00
Cheng Zhao
03ec5ced05 Merge pull request #4751 from maxbeatty/window-blur 
Add blur method to window
 2016-03-11 19:15:51 +09:00
Max Beatty
704b8335aa Add blur method to window ref #4724 2016-03-10 21:45:51 -08:00
Cheng Zhao
d564727583 spec: Increase timeout for executeJavaScript 2016-03-11 11:17:02 +09:00
Cheng Zhao
256c2684ee spec: Do not enter fullscreen in travis on OS X 
It is too flaky
 2016-03-11 10:36:08 +09:00
Arek Sredzki
fcc1f4d7ed Finalized browser-window show & hide events, added tests & fixed os x implementation 2016-03-10 13:51:31 -08:00