Cheng Zhao
498f5d65fd
mac: UninstallView is not used
2018-03-06 16:20:37 +09:00
Cheng Zhao
3b3e69f8b2
Save browser_view_ in the NativeWindow
...
No need to store it separately in subclasses.
2018-03-06 16:20:37 +09:00
Cheng Zhao
503b0ba1b1
mac: Move draggable region code to BrowserWindow
...
On macOS current draggable region implementation highly relies on
WebContents, the code is only meaningful for BrowserWindow.
2018-03-06 16:20:37 +09:00
Cheng Zhao
bc34ca9e25
mac: Call setMouseDownCanMoveWindow in BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
7d4ff3b061
mac: Call SetBackgroundOpaque in BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
8a1884c407
mac: AcceleratedWidget should be window's content view
2018-03-06 16:20:37 +09:00
Cheng Zhao
e7f175d578
Only mac needs to call SetActive
2018-03-06 16:20:37 +09:00
Cheng Zhao
4c7b48e596
mac: Window's native view should be its content view
2018-03-06 16:20:37 +09:00
Cheng Zhao
1681ee35db
Set WebContents background color in BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
7b8890a4c9
web_contents can't be null
2018-03-06 16:20:37 +09:00
Cheng Zhao
2eaa6d0874
Move StoreFocus/RestoreFocus to BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
cad3d694ab
mac: Remove access to webContents in windowWillUseStandardFrame
2018-03-06 16:20:37 +09:00
Cheng Zhao
e73326a324
Merge pull request #11613 from electron/safe-dialogs
...
Implement dialog (alert/confirm) blocking as a user switch after the first dialog
2018-03-06 14:28:53 +09:00
Cheng Zhao
90bd1fd7e9
Native confirm/alert throws differently
2018-03-06 14:06:29 +09:00
Cheng Zhao
ca42325ade
Make OnMessageBoxCallback a method since it is accessing members
2018-03-06 11:35:53 +09:00
Cheng Zhao
7516b059fe
Code style fixes
2018-03-06 11:31:56 +09:00
Cheng Zhao
d8f16f4116
docs: Default message is not localized
2018-03-06 11:24:42 +09:00
Cheng Zhao
26a071ea00
docs: Defaults of safeDialogs
2018-03-06 11:21:40 +09:00
Samuel Attard
7dec3c9320
Fixup cpplint
2018-03-06 11:19:15 +09:00
Samuel Attard
731240e0e9
Use USER_WANTS_NO_MORE_DIALOGS constant for -1 magic number
2018-03-06 11:19:15 +09:00
Charles Kerr
a5a068b2ee
fix cpplint errors
...
atom/browser/atom_javascript_dialog_manager.cc:39: Lines should be <= 80 characters long [whitespace/line_length] [2]
atom/browser/atom_javascript_dialog_manager.cc:39: If/else bodies with multiple statements require braces [readability/braces] [4]
atom/browser/atom_javascript_dialog_manager.cc:62: Lines should be <= 80 characters long [whitespace/line_length] [2]
atom/browser/atom_javascript_dialog_manager.cc:89: If/else bodies with multiple statements require braces [readability/braces] [4]
2018-03-06 11:19:15 +09:00
Charles Kerr
2435ffaf09
fix cpplint error
...
atom/browser/atom_javascript_dialog_manager.h:9: Include "map" not in alphabetical order [build/include_alpha] [4]
2018-03-06 11:19:15 +09:00
Samuel Attard
795447f61a
Implement dialog (alert/confirm) blocking as a user switch after the first dialog
...
* This is to enable more browser-like behavior so that users who run third-party code
will not be DOS'ed with alerts and confirms. This is already handled like this
in most major browsers so this will greatly help these developers
2018-03-06 11:19:15 +09:00
shelley vohr
a3d4d461a3
Merge pull request #12135 from electron/deprecate-getMenuBarHeight
...
deprecate screen.getMenuBarHeight
2018-03-05 17:56:51 -08:00
Shelley Vohr
3635872f37
remove screen.getMenuBarHeight spec
2018-03-05 20:10:34 -05:00
Shelley Vohr
199cf31b9e
deprecate screen.getMenuBarHeight
2018-03-05 19:45:51 -05:00
Charles Kerr
642dc96956
Add optional verbose switch '-v' to build script. ( #12118 )
...
* Add optional verbose switch '-v' to build script.
* Remove tracer comment.
* Add --ninja-path switch.
For compatiblity with https://github.com/electron/electron/pull/12120
2018-03-06 03:27:58 +09:00
Charles Kerr
e9808d138f
Better error logging in api-app-spec.js. ( #12122 )
...
In the 'exits gracefully on macos' test for app.exit(exitCode),
print the relevant error information if the test fails.
2018-03-06 03:13:47 +09:00
Samuel Attard
b530d70a7b
Merge pull request #12058 from philfreo/patch-1
...
Include backtrace i/o as a crash reporter backend option
2018-03-06 05:13:18 +11:00
John Kleinschmidt
1005a63130
Merge pull request #12127 from electron/set-dev-version-everywhere
...
Use version 0.0.0-dev everywhere
2018-03-05 12:28:55 -05:00
Aleksei Kuzmin
52c0864cb8
Use version 0.0.0-dev everywhere
2018-03-05 16:24:48 +01:00
John Kleinschmidt
3a55e5b384
Merge pull request #12113 from electron/FranzDeCopenhague-patch-1
...
Fix typo found during the Spanish translation
2018-03-05 10:08:17 -05:00
Franz de Copenhague
847cf17b77
Fix typo found during the Spanish translation
2018-03-04 10:07:46 -08:00
Adrien Fery
6d82966ebe
Update inAppPurchase API doc ( #12072 )
...
* Update inAppPurchase API doc
`addTransactionsListener` is no longer supported. Users have to listen for the `transactions-updated` event instead.
* Tweak `transactions-updated` timing description
Make the documentation edit suggested by @felixrieseberg and thumbs-upped by @AdrienFery
2018-03-02 07:25:37 -06:00
Tiago Danin
efeabfe3ef
📝 Fix url to unity-launcher and tiny correction ( #12084 )
2018-02-28 18:28:40 -06:00
Phil Freo
738b10adea
Include backtrace i/o as a crash reporter backend option
...
Note: I have no affiliation with this company - just thought this would be helpful for people
2018-02-28 14:21:14 -05:00
shelley vohr
dfa1dc43df
Merge pull request #12059 from electron/add-tabbedwindow-warning
...
add warning when addTabbedWindow is called on self
2018-02-28 01:18:10 -08:00
Shelley Vohr
bf491de9fe
fix styling and add spec
2018-02-28 00:22:42 -08:00
Shelley Vohr
2abc69780e
move native-mate back into the api layer
2018-02-27 13:00:42 -08:00
Zeke Sikelianos
1db05a2655
Merge pull request #12067 from electron/fix-typo-in-inAppPurchase-API-doc
...
fix typo in inAppPurchase API doc
2018-02-27 11:07:45 -08:00
Zeke Sikelianos
b05d818f45
fix typo in inAppPurchase API doc
2018-02-27 10:22:29 -08:00
Shelley Vohr
837a2d4bbd
appease the linter
2018-02-26 22:25:09 -08:00
Cheng Zhao
35cbe9d140
Fix dockMenu not being referenced in JavaScript ( #12062 )
...
* Fix dockMenu not being referenced in JavaScript
* spec: Test garbage collecting dock menu
2018-02-26 22:15:06 -08:00
Samuel Attard
b722150d87
Don't cast manually for NativeWindow*
2018-02-27 16:13:17 +11:00
Samuel Attard
5336b4a89c
Pass arguments instance through the chain in order to throw error
2018-02-27 16:11:58 +11:00
Shelley Vohr
e84d7c0cda
add warning when addTabbedWindow is called on self
2018-02-26 14:47:36 -08:00
Cheng Zhao
53229e3d6c
Fix network delegate race condition ( #12044 )
...
* Fix race condition when getting network delegate
* Remove the evil URLRequestContextGetter::network_delegate
* Move the arguments instead of const referrencing
Safer and more efficient.
2018-02-26 06:23:59 -08:00
Cheng Zhao
fdd66bd76d
Merge pull request #11607 from bughit/frame_navigation_api
...
frame navigation API
2018-02-26 15:50:11 +09:00
Cheng Zhao
ccf30e0934
Coding style fixes
2018-02-26 15:19:44 +09:00
Cheng Zhao
25f04d5b03
Fix descriptions to make docs parser happy
2018-02-26 15:05:46 +09:00