Commit graph

19780 commits

Author SHA1 Message Date
Nitish Sakhawalkar
48ebebcafe fix: Linux empty menu model handling (#15605)
* fix: Linux empty menu model handling

* Update root_view.cc
2018-11-08 08:11:15 -08:00
trop[bot]
ae9f4ef425 chore: add simple set/unset loginitem spec (#15600) 2018-11-06 22:08:44 -08:00
Electron Bot
5c14992e43 Bump v3.0.8 2018-11-05 14:36:14 -08:00
trop[bot]
53b871ecbd fix: use NSURL path for receipt url (#15573) 2018-11-05 13:21:40 -08:00
John Kleinschmidt
ec6fe27fca
build: add v8_context_generator to mksnapshot zip (3-0-x) (#15505)
* build: add v8_context_generator to mksnapshot

Starting with 3-0-x, in order to use custom snapshots the v8_context_snapshot_generator binary is also needed.
Also, add tests for mksnapshot.

* Actually run verify-mksnapshot
2018-11-05 13:31:33 -04:00
Nitish Sakhawalkar
8566f8712c fix: Empty menu case (#15553) 2018-11-02 12:32:57 -07:00
Alexey Kuzmin
08ec270b90 docs: fix the "second-instance" event handler signature in the docs (#15546) 2018-11-02 22:18:12 +11:00
trop[bot]
b2822ed800 docs: add Size as an option for pageSize in docs for printToPDF (#15525) 2018-11-01 07:16:08 -07:00
Samuel Attard
6bec85f30c chore: publish to the latest tag correctly when releasing old versions (#15515) (#15520)
Manual backport of #15274 to <= 3-0-x
2018-11-01 07:15:32 -07:00
trop[bot]
6d658b319b fix: explicitly set windowsHide to the old node default (#15514)
Notes: fix Electron not being visible when launching in development mode on node v11
2018-11-01 15:37:06 +11:00
Cheng Zhao
5c853b681c
Fix missing remote object error when calling remote function created in preload script (3-0-x) (#15445)
* fix: report wrong context error based on contextId

* fix: destroyed remote renderer warning is now async
2018-11-01 08:55:02 +09:00
Electron Bot
7b0959ed2b Bump v3.0.7 2018-10-31 16:11:44 -07:00
trop[bot]
3e8b854975 docs: add return type for subscribeNotification (#15499) 2018-10-31 09:48:33 -07:00
trop[bot]
fd97fcf6f0 doc: clarify menu item properties not available top-level (#15461) 2018-10-29 16:23:58 -07:00
Heilig Benedek
809534dca0 fix: enable FixAltGraph to fix Ctrl+Alt accelerators on Windows (#15378) 2018-10-30 02:33:44 +11:00
Roller Bot
b2763cad9f chore: bump libcc (3-0-x) (#15420)
* chore: bump libcc submodule to d2c3189f30cfb39f888a917671024733fe5cffcc

* chore: bump libcc in DEPS to d2c3189f30cfb39f888a917671024733fe5cffcc
2018-10-29 10:37:37 -04:00
trop[bot]
b6b9966162 fix: use gio as default linux trash impl (backport: 3-0-x) (#15421)
* fix: use gio as default linux trash impl

* doc: add ELECTRON_TRASH env var
2018-10-26 11:10:35 -07:00
trop[bot]
a41e919b95 doc: correct ipcRenderer sendTo windowId param (#15418) 2018-10-26 08:36:29 -07:00
Heilig Benedek
bdda248194 fix: check for shared memory handle validity before closing, remove DebugDumpData call (#15402) 2018-10-26 09:57:03 -05:00
trop[bot]
41e86efda0 fix: folder open not working in devtools (#15396) 2018-10-25 10:01:29 -07:00
trop[bot]
88b1f7d9c8 fix: set NSResizableWindowMask at init time (#15384) 2018-10-25 15:30:16 +09:00
Electron Bot
dcdbc87ef4 Bump v3.0.6 2018-10-24 15:40:18 -07:00
Alexey Kuzmin
9e03783781
chore: bump libcc (3-0-x) (#15374)
Resolves #15344
2018-10-24 22:40:38 +02:00
John Kleinschmidt
8208296143 Make sure node is set in path 2018-10-24 15:21:43 -04:00
Roller Bot
518467cf4c chore: bump libcc in DEPS to 82816abaad3930c3702cf23489f0506ba13b1529 2018-10-24 07:23:09 -07:00
Roller Bot
648bf54bb3 chore: bump libcc submodule to 82816abaad3930c3702cf23489f0506ba13b1529 2018-10-24 07:23:07 -07:00
trop[bot]
8dce40137c fix: honor dialog.showMessageBox()'s Icon argument on Linux (#15342)
* Don't call gtk_widget_show_all() on popup dialog.

Fixes #15317.

Notes: Fixed incorrect display of some GtkMessageDialog icons.

The issue is caused because GtkMessageDialog contains an icon widget
which is not shown when there's no associated icon. Our call to
`gtk_widget_show_all()` overrides this, showing the uninitialized
icon widget.

This PR fixes the issue by calling `gtk_widget_show()` where needed
and removing use of `gtk_widget_show_all()` in the message dialog.

* use gtk_dialog_set_default_response() for default

* fix: support icons on gtk+ messageboxes.
2018-10-23 12:01:05 -07:00
trop[bot]
dab77256d2 fix: Native window close crash (#15338) 2018-10-23 12:00:39 -07:00
trop[bot]
c7501bd7ca fix: correct reversed logic in NativeWindowMac::SetEnabled (#15324) 2018-10-23 23:22:19 +11:00
trop[bot]
203c47f038 docs: we don't emit an event object for session-created (#15308) 2018-10-21 10:18:08 -07:00
Shelley Vohr
02cd96875d
fix: ability to fetch separators by id (#15299) 2018-10-19 21:58:07 -07:00
trop[bot]
9349b0a273 fix: correctly enable and disable windows on Windows and Linux (backport: 3-0-x) (#15255)
* fix: correctly enable and disable windows

* Move has_child_modal_ to NativeWindowViews

* Track modal children as an int instead of a bool

* Use correct types

* Move Increment/DecrementChildModals to NativeWindowViews

* Use parent() in NativeWindowViews

* Add test for not enabling disabled parent when modal child closes
2018-10-19 17:30:55 -07:00
trop[bot]
1c42715e1d spec: increase MAS timeout for login items (#15296) 2018-10-19 16:57:00 -07:00
Alexey Kuzmin
ef4a7e22fd test: asyncawaitify one of sandbox related tests (backport: 3-0-x) (#15281)
* test: asyncawaitify one of sandbox related tests (#15252)

(cherry picked from commit b3f134de06)

* test: backport "openTheWindow" function to "BrowserWindow module" specs
2018-10-19 09:14:36 -07:00
trop[bot]
ead294fe13 fix: trim app name and productName (#15286)
Fixes #15245
2018-10-19 09:13:10 -07:00
trop[bot]
f119e4cc4b chore: make macOS release builds higher priority to skip the queue (#15284)
Release builds should be run before branch builds on our limited macOS
infra.

Refs: https://docs.microsoft.com/en-us/rest/api/vsts/build/builds/queue?view=vsts-rest-4.1#queuepriority
2018-10-19 09:12:21 -07:00
trop[bot]
00489e6106 fix: make release-artifact-cleanup executable (backport: 3-0-x) (#15272)
* fix: make release-artifact-cleanup executable

* fix misc issues in cleanup script
2018-10-18 20:27:53 -07:00
trop[bot]
a7c34b8a0a fix: Convert to lower case in upload symbols script (backport: 3-0-x) (#15261)
* fix: Convert to lower case in upload symbols script

* fix: Convert to lower case in upload symbols script
2018-10-18 19:17:15 -07:00
trop[bot]
906436f31b fix: loading of devtools extensions on startup (backport: 3-0-x) (#15264)
* Fix loading of devtools extensions on startup

The persisted DevTools Extensions were not being loaded correctly at startup. The `addDevToolsExtension` function was not defined when it was being called. An error was being thrown and ignored, so the whole thing would fail silently. I moved the code to load the extensions to the end of the event handler, so now it works.

* fixup: remove trailing spaces to unblock CI

* fixup: add logging when the Electron Enable Logging env var is set

* Fix linter error on undefined srcDirectory

* fixup: catch exception when loading extension

* Revert "fixup: catch exception when loading extension"

This reverts commit 42c2cf95bcaab8abfc5fbecbe4365d3adfe36d5b.
2018-10-18 19:13:01 -07:00
Electron Bot
b208fcbf0d Bump v3.0.5 2018-10-18 17:03:53 -07:00
Samuel Attard
6899ac9bde
Revert "Bump v3.0.5"
This reverts commit 72c033299f.
2018-10-18 23:46:35 +11:00
Electron Bot
72c033299f Bump v3.0.5 2018-10-17 22:56:11 -07:00
Samuel Attard
7fb6b3bda8 Revert "build: enable PIE when compiling Linux builds, fix #14961. (#15152)"
This reverts commit 70d4644742.
2018-10-18 14:09:34 +11:00
Samuel Attard
1d79840025 Revert "build: enable BIND_NOW when compiling Linux builds, fix #15149. (#15153)"
This reverts commit 049381c6ac.
2018-10-18 14:09:19 +11:00
Samuel Attard
07deaaa502 Revert "Bump v3.0.5"
This reverts commit 259f0a62e8.
2018-10-18 14:08:56 +11:00
Electron Bot
259f0a62e8 Bump v3.0.5 2018-10-17 19:33:27 -07:00
Samuel Attard
4f78df9cfa Revert "Bump v3.0.5"
This reverts commit b2be093bd3.
2018-10-18 13:26:20 +11:00
Electron Bot
b2be093bd3 Bump v3.0.5 2018-10-17 10:28:20 -07:00
Roller Bot
4f666bb6ac chore: bump libcc (3-0-x) (#15201)
* chore: bump libcc submodule to c110392d8556a6428679328f9075b3f4fb54aa3c

* chore: bump libcc in DEPS to c110392d8556a6428679328f9075b3f4fb54aa3c
2018-10-18 00:54:31 +11:00
trop[bot]
12f75832b8 add width to webview iframe (#15204) 2018-10-17 11:54:43 +09:00