electron-roller[bot]
e86d1cba75
chore: bump chromium to 105.0.5129.0 (main) ( #34403 )
...
* chore: bump chromium in DEPS to 104.0.5096.0
* 3651284: Use the entry settings object for window.open navigation
https://chromium-review.googlesource.com/c/chromium/src/+/3651284
* 3644598: Make RenderFrameHost used for notification permission decision
https://chromium-review.googlesource.com/c/chromium/src/+/3644598
* 3642842: Window Placement: Prototype Fullscreen Capability Delegation - Part 2
https://chromium-review.googlesource.com/c/chromium/src/+/3642842
* 3652785: [sandbox] Enable sandboxed pointers on sanitizer builds
https://chromium-review.googlesource.com/c/v8/v8/+/3652785
* 3611967: webhid: Migrate HidDelegate to use BrowserContext and Origin
https://chromium-review.googlesource.com/c/chromium/src/+/3611967
* 3665762: Remove RenderFrameHost::IsRenderFrameCreated from //content/.
https://chromium-review.googlesource.com/c/chromium/src/+/3665762
* 3659375: Fold x509_util_ios and most of x509_util_mac into x509_util_apple
https://chromium-review.googlesource.com/c/chromium/src/+/3659375
* 3656234: [CodeHealth] Remove uses of base::ListValue::Append() (Final, take 2)
https://chromium-review.googlesource.com/c/chromium/src/+/3656234
* chore: update patch indices
* chore: fix lint
* 3644598: Make RenderFrameHost used for notification permission decision
https://chromium-review.googlesource.com/c/chromium/src/+/3644598
* webhid: Migrate HidDelegate to use BrowserContext and Origin
This is a temporary fix for https://chromium-review.googlesource.com/c/chromium/src/+/3611967 to get the build compiling, but we need to either patch around https://chromium-review.googlesource.com/c/chromium/src/+/3611967 or move our device permissioning to BrowserContext
* chore: fix lint
* build: run electron/script/gen-libc++-filenames.js
fixes gn check
* chore: bump chromium in DEPS to 104.0.5098.0
* chore: disable flaking tests
* 3682394: Change pipes surrounding code references in comments to backticks
https://chromium-review.googlesource.com/c/chromium/src/+/3682394
* 3652749: Delete GLRenderer and related classes
https://chromium-review.googlesource.com/c/chromium/src/+/3652749
* chore: fixup patch indices
* 3671199: Remove ContentMainDelegate::PostFieldTrialInitialization
https://chromium-review.googlesource.com/c/chromium/src/+/3671199
* 3607963: hid: Do not exclude HID device with no collections
https://chromium-review.googlesource.com/c/chromium/src/+/3607963
* refactor: use ElectronBrowserContext instead of WebContents to persist devices
due to changes like https://chromium-review.googlesource.com/c/chromium/src/+/3611967 ,
we can no longer use WebContents to store device permissions so this commit
moves device permission storage to live in memory in ElectronBrowserContext
instead.
* 3557253: Deprecate some signature checks
https://chromium-review.googlesource.com/c/v8/v8/+/3557253
* chore: bump chromium in DEPS to 104.0.5100.0
* 3680781: Add policy for Renderer App Container.
https://chromium-review.googlesource.com/c/chromium/src/+/3680781
* chore: update patch indices
* 3675465: Update NetLog network service API to use mojom::DictionaryValue.
https://chromium-review.googlesource.com/c/chromium/src/+/3675465
* chore: bump chromium in DEPS to 104.0.5102.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5103.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5104.0
* chore: update patches
* fix: add patch for DCHECK in fullscreen test
* build: fix nan build
* build: make the nan spec runner work on macOS
* chore: bump chromium in DEPS to 104.0.5106.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5108.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5110.0
* chore: update patches
* chore: bump chromium in DEPS to 104.0.5112.0
* chore: bump chromium in DEPS to 105.0.5113.0
* chore: bump chromium in DEPS to 105.0.5115.0
* chore: bump chromium in DEPS to 105.0.5117.0
* chore: update patches
* chore: update libcpp patch
* 3693745: Delete base::LowerCaseEqualsASCII()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3693745
* 3669226: Remove printing PostTask usage of IO thread
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3669226
* 3687395: Remove DictionaryValue::HasKey().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3687395
* 3691014: Prevent unsafe narrowing: ui/accessibility, part 2
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3691014
* 3560567: [MSC] Porting GenerateStreams clients to handle stream vectors.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560567
* 3684873: [Bluetooth][Win/Linux] Add bluetooth pair confirmation prompt
https://chromium-review.googlesource.com/c/chromium/src/+/3684873
* chore: bump chromium in DEPS to 105.0.5119.0
* chore: missing includes in desktop_notification_controller
* chore: update patches
* 3685951: Reland "Make sure screen object is created once in tests."
https://chromium-review.googlesource.com/c/chromium/src/+/3685951
* fixup: Reland "Make sure screen object is created once in tests."
* 3646014: [API] Deprecate LegacyOOMErrorCallback
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3646014
* chore: bump chromium in DEPS to 105.0.5121.0
* chore: update patches
* 3699085: [cleanup] update PrintBackend::EnumeratePrinters to use reference
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3699085
* chore: bump chromium in DEPS to 105.0.5123.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5125.0
* chore: update patches
* 3630082: [sandbox] Also enable the sandbox outside of Chromium builds
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3630082
* chore: bump chromium in DEPS to 105.0.5127.0
* chore: update patches
* chore: bump chromium in DEPS to 105.0.5129.0
* chore: update patches
* 3703741: Remove WebContents::GetMainFrame.
https://chromium-review.googlesource.com/c/chromium/src/+/3703741
* chore: update patches
* fixup! 3703741: Remove WebContents::GetMainFrame.
* fix lint
* more lint
* chore: document breaking change
* 3687671: [v8] Freeze flags after initialization
https://chromium-review.googlesource.com/c/chromium/src/+/3687671
* fixup! 3560567: [MSC] Porting GenerateStreams clients to handle stream vectors.
* use the v8 allocator for node serdes
* chore: update patches
* remove faulty non-v8-sandbox-compatible code
* make NodeArrayBufferAllocator use the v8 allocator under the hood
* fixup! 3560567: [MSC] Porting GenerateStreams clients to handle stream vectors.
* fix build on windows
* 3691954: [Reland][Extensions Bindings] Validate arguments sent to API events
https://chromium-review.googlesource.com/c/chromium/src/+/3691954
* chore: remove deprecated AccessorSignatures
https://github.com/nodejs/nan/pull/941
* Update patches/chromium/notification_provenance.patch
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* remove chore_expose_v8_initialization_isolate_callbacks.patch
* add link to nodejs/nan#941
* 52026: Do not allow md4 or md5 based signatures in X.509 certificates.
https://boringssl-review.googlesource.com/c/boringssl/+/52026
* chore: update patches
* disable nan buffer-test
* disable sandboxed pointers for now
* force sandboxed pointers off
* improve node allocation patch
* restore accidentally dropped node crypto test patch
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@salesforce.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Jeremy Rose <japthorp@slack-corp.com>
2022-06-27 15:50:08 -05:00
Josh Soref
ea4278754c
chore: fix spelling errors in multiple files ( #34574 )
...
* chore: fix spelling in .circleci
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in BUILD.gn
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in appveyor.yml
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in build
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in docs
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in lib
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in script
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in shell
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in spec
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in spec-main
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-06-16 16:46:11 +09:00
Jeremy Rose
bad8d5e08a
fix: make preload calculation identical between sandbox & non-sandboxed ( #34531 )
2022-06-15 13:22:28 -07:00
Shelley Vohr
db79734bfb
feat: support more color formats for backgroundColor ( #31868 )
2022-03-21 18:35:54 +01:00
Jeremy Rose
4342b7ff55
chore: remove awkward semi-documented preloadURL WebPreference ( #33228 )
2022-03-16 16:23:41 -07:00
electron-roller[bot]
28ada6ea8b
chore: bump chromium to 100.0.4857.0 (main) ( #32419 )
...
* chore: bump chromium in DEPS to 99.0.4819.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4824.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4827.0
* chore: update patches
* 3352511: PiP: Add inkdrop and pointer cursor to PiP window buttons
https://chromium-review.googlesource.com/c/chromium/src/+/3352511
* 3309164: webhid: Show FIDO devices in the chooser if allowed
https://chromium-review.googlesource.com/c/chromium/src/+/3309164
* 3297868: hid: Add experimental HIDDevice.forget()
https://chromium-review.googlesource.com/c/chromium/src/+/3297868
* 3362491: [Extensions] Move i18n API to //extensions
https://chromium-review.googlesource.com/c/chromium/src/+/3362491
* MCC Refactor step0: Allow embedders to register associated_interface binders with RenderFrameHostImpl::associated_registry_.
https://chromium-review.googlesource.com/c/chromium/src/+/3281481
* 3352616: [Gtk] Remove libgtk from the link-line
https://chromium-review.googlesource.com/c/chromium/src/+/3352616
* 3249211: Clear-Site-Data support for partitioned cookies
https://chromium-review.googlesource.com/c/chromium/src/+/3249211
* [Extensions][COIL] Use [allow|block]list in //extensions/common
https://chromium-review.googlesource.com/c/chromium/src/+/3372668
* Begin ScopedUserPrefUpdate migration to modern base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3376154
* [Code Health] Refactor PrefService GetDict + GetList to use base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3343526
* 3354997: [CodeHealth] Remove deprecated SetDictionary method
https://chromium-review.googlesource.com/c/chromium/src/+/3354997
* 3287323: Add LacrosPrefStore for lacros settings
https://chromium-review.googlesource.com/c/chromium/src/+/3287323
* 3365916: [PA] Clean up remaining lazy commit code
https://chromium-review.googlesource.com/c/chromium/src/+/3365916
* [MPArch] Target the external protocol error at the responsible frame.
https://chromium-review.googlesource.com/c/chromium/src/+/3011560
* Pass origin to RegisterNonNetworkSubresourceURLLoaderFactories
https://chromium-review.googlesource.com/c/chromium/src/+/3350608
* Linux: Send OSCrypt raw encryption key to the Network Service
https://chromium-review.googlesource.com/c/chromium/src/+/3320484
* [PlzServiceWorker] Remove remaining references to PlzServiceWorker.
https://chromium-review.googlesource.com/c/chromium/src/+/3359441
* chore: fixup for lint
* 3327621: Fix tablet mode detection for Win 11.
https://chromium-review.googlesource.com/c/chromium/src/+/3327621
* 3342428: ax_mac: move AXTextMarker conversion utils under ui umbrella
https://chromium-review.googlesource.com/c/chromium/src/+/3342428
* 3353974: Mac: Use base::Feature for overlay features
https://chromium-review.googlesource.com/c/chromium/src/+/3353974
* chore: bump chromium in DEPS to 99.0.4828.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4837.0
* chore: update patches
* chore: update patches
* 3379142: Drop FALLTHROUGH macro
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3379142
* 3381749: C++17: Allow use of std::map::try_emplace and std::map::insert_or_assign
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3381749
* chore: bump chromium in DEPS to 99.0.4839.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4840.0
* chore: bump chromium in DEPS to 99.0.4844.0
* 3395881: [api] Deprecate Local<v8::Context> v8::Object::CreationContext()
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3395881
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4845.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4847.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4849.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4851.0
* chore: bump chromium in DEPS to 100.0.4853.0
* update patches
* chore: update patches
* update patches
* 3383599: Fonts Access: Remove prototype that uses a font picker.
https://chromium-review.googlesource.com/c/chromium/src/+/3383599
* 3404768: Remove ALLOW_UNUSED macros
https://chromium-review.googlesource.com/c/chromium/src/+/3404768
* 3374762: Remove ignore_result.h
https://chromium-review.googlesource.com/c/chromium/src/+/3374762
* 3399305: [unseasoned-pdf] Apply proper frame offsets for touch selections
https://chromium-review.googlesource.com/c/chromium/src/+/3399305
* 3402210: [Extensions] Don't trigger unload event for already unloaded extension
https://chromium-review.googlesource.com/c/chromium/src/+/3402210
* 3410912: Combine URLLoaderClient OnReceiveResponse and OnStartLoadingResponseBody.
https://chromium-review.googlesource.com/c/chromium/src/+/3410912
* 3370428: Make the AuthSchemes policy support dynamic refresh
https://chromium-review.googlesource.com/c/chromium/src/+/3370428
* 3407603: Finish ScopedUserPrefUpdate migration to modern base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3407603
* 3378352: ozone/x11: move code from //ui/p/x11 to //ui/ozone/p/x11
https://chromium-review.googlesource.com/c/chromium/src/+/3378352
* 3370810: Delete chrome/service, AKA the Cloud Print service process.
https://chromium-review.googlesource.com/c/chromium/src/+/3370810
* chore: bump chromium in DEPS to 100.0.4855.0
* chore: update patches
* fixup! 3370810: Delete chrome/service, AKA the Cloud Print service process.
* revert 3348007 to fix windows build
* 3318572: [Code health] Fix gn check errors in //extensions/browser:*
https://chromium-review.googlesource.com/c/chromium/src/+/3318572
* fix printing.patch
* fix iwyu issue
* 3408515: win: Make ShorcutOperation an enum class and modernize names
https://chromium-review.googlesource.com/c/chromium/src/+/3408515
* 3388333: [UIA] Remove dead code accessibility_misc_utils.h/cc
https://chromium-review.googlesource.com/c/chromium/src/+/3388333
* fix windows build? i hope
* patch gn visibility of //ui/ozone/platform/x11
* missing include base/logging.h
* use BUILDFLAG for USE_NSS_CERTS
https://chromium-review.googlesource.com/c/chromium/src/+/3379123
* defined(OS_*) ==> BUILDFLAG(IS_*)
https://bugs.chromium.org/p/chromium/issues/detail?id=1234043
* fixup! 3404768: Remove ALLOW_UNUSED macros
* another attempt to fix windows build
* temporarily disable the custom scheme service worker test
https://github.com/electron/electron/issues/32664
* fix loading mv3 extensions
not sure what cl broke this unfort.
* fixup! 3404768: Remove ALLOW_UNUSED macros
* patch nan
https://chromium-review.googlesource.com/c/v8/v8/+/3395880
* fix node test
* fix nullptr in FindPdfFrame
* patch perfetto to fix build issue on win-ia32
bc44c3c753https://github.com/electron/electron/issues/32705
* test: fix failing tests of focus/blur events of WebContents (#32711 )
* inherit stdio from app module test child processes
this prevents them from timing out due to full stdout buffers
* test to see if we can get better logs on windows ci
* try again for appveyor log things
* skip contentTracing tests on ia32
* ci: disable gpu compositing
* drop applied patch
* fix merge fail
* Revert "ci: disable gpu compositing"
This reverts commit 0344129fcb19ea3e87e06c1110d751f22eba3fec.
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2022-02-09 18:58:52 -08:00
electron-roller[bot]
b0f315a637
chore: bump chromium to 99.0.4767.0 (main) ( #31986 )
...
* chore: bump chromium in DEPS to 98.0.4726.0
* 3292117: Remove unneeded base/compiler_specific.h includes in //chrome.
https://chromium-review.googlesource.com/c/chromium/src/+/3292117
* 3289198: Enables calculating line, word and sentence boundaries on the browser
https://chromium-review.googlesource.com/c/chromium/src/+/3289198
* 3276176: Remove expired gdi-text-printing flag and associated code.
https://chromium-review.googlesource.com/c/chromium/src/+/3276176
* 3240963: content: allow embedder to prevent locking scheme registry
https://chromium-review.googlesource.com/c/chromium/src/+/3240963
* 3269899: Rename WebContentsImpl::GetFrameTree to GetPrimaryFrameTree
https://chromium-review.googlesource.com/c/chromium/src/+/3269899
* chore: fixup patch indices
* 3276279: Enable -Wshadow by default for the "chromium code" config.
https://chromium-review.googlesource.com/c/chromium/src/+/3276279
* 3279737: appcache: Remove WebPreference/WebSetting
https://chromium-review.googlesource.com/c/chromium/src/+/3279737
* 3275564: [api] Advance API deprecation for APIs last marked in v9.6
https://chromium-review.googlesource.com/c/v8/v8/+/3275564
* 3261873: Clean up WebScriptSource constructors
https://chromium-review.googlesource.com/c/chromium/src/+/3261873
* 3279346: appcache: Remove ConsoleMessage appcache field
https://chromium-review.googlesource.com/c/chromium/src/+/3279346
* 3264212: Move legacy file loading to legacy_test_runner
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264212
Both Persistence and UI have been removed from globals, but the issues they
seemed to be patching are no longer reproducible from what I can tell, and
so we can just delete these and re-evaluate if something surfaces.
* 3290415: x11: remove the USE_X11 define.
https://chromium-review.googlesource.com/c/chromium/src/+/3290415
* chore: bump Chromium to 98.0.4728.0
* 3179530: Defer system calls in PrintingContext for OOP printing
https://chromium-review.googlesource.com/c/chromium/src/+/3179530
* 3299445: Consolidate is_win conditionals in chrome/test/BUILD.gn.
https://chromium-review.googlesource.com/c/chromium/src/+/3299445
* chore: update patch indices
* 3223975: Break PrintJobWorker OOP logic into separate class
https://chromium-review.googlesource.com/c/chromium/src/+/3223975
* chore: bump chromium in DEPS to 98.0.4730.0
* 3279001: Remove support for font-family: -webkit-pictograph
https://chromium-review.googlesource.com/c/chromium/src/+/3279001
* chore: fixup patch indices
* chore: bump chromium in DEPS to 98.0.4732.0
* chore: update patches
* chore: bump chromium in DEPS to 98.0.4734.0
* chore: bump chromium in DEPS to 98.0.4736.0
* chore: update patches
* chore: update printing patch for miracle ptr
* chore: add noexcept to fix clang error
* chore: bump chromium in DEPS to 98.0.4738.0
* chore: update patches
* chore: bump chromium in DEPS to 98.0.4740.0
* chore: bump chromium in DEPS to 98.0.4742.0
* chore: bump chromium in DEPS to 98.0.4744.0
* chore: bump chromium in DEPS to 98.0.4746.0
* chore: bump chromium in DEPS to 98.0.4748.0
* chore: bump chromium in DEPS to 98.0.4750.0
* chore: update patches
* 3293841: Remove File Handling permissions code
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3293841
* chore: update patches
3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700
* 3289260: [CodeHealth]: Remove uses of Notification Service
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3289260
* 3301600: Disable scripted print in fenced frames
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3301600
* chore: add missing thread_restrictions headers
* 3305132: Rewrite most `Foo* field_` pointer fields to `raw_ptr<Foo> field_`.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3305132
* fix: add ppapi_sandbox header for linux
3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700
* chore: manually bump chromium in DEPS to 98.0.4757.0
* chore: update patches
* 3321044: Remove DictionaryValue::Clear()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3321044
* chore: update printing.patch
Refs:
- 3304556: [code health] Remove notification observation from PrintJob. | https://chromium-review.googlesource.com/c/chromium/src/+/3304556
- 3305095: [code health] Remove NotificationService from PrintViewManagerBase. | https://chromium-review.googlesource.com/c/chromium/src/+/3305095
* build: add v8-embedder-state headers to GN patch
* chore: bump chromium in DEPS to 99.0.4767.0
* chore: update patches
* chore: rename CookiePartitionKeychain
...to CookiePartitionKeyCollection
* chore: update video consumers
* refactor: use newer base::Value API
* 3232598: Convert net::DnsOverHttpsServerConfig into a class | https://chromium-review.googlesource.com/c/chromium/src/+/3232598
* 3327865: Remove the default WebContentsUserData ctor. | https://chromium-review.googlesource.com/c/chromium/src/+/3327865
* 3302814: DevTools: Add getPreference binding | https://chromium-review.googlesource.com/c/chromium/src/+/3302814
* 3301474: [tq][runtime] Use build flags for JS context promise hooks | https://chromium-review.googlesource.com/c/v8/v8/+/3301474
* oops 😵💫
* 3272411: Reland "base/allocator: Enable PartitionAlloc-Everywhere on macOS" | https://chromium-review.googlesource.com/c/chromium/src/+/3272411
build: turn PartitionAlloc back off on mac for now
* fix: WCO method got renamed
* 3344749: Revert "Stop using NSRunLoop in renderer process"
https://chromium-review.googlesource.com/c/chromium/src/+/3344749
* 3288746: [serial] Fix BluetoothSerialDeviceEnumerator threading issues.
https://chromium-review.googlesource.com/c/chromium/src/+/3288746
* Revert "3288746: [serial] Fix BluetoothSerialDeviceEnumerator threading issues."
This reverts commit 5cc69f102e43ca72ac9ef45063711bcc7d849740.
* chore: disable serial device enumerator sequence dcheck
* fix: comment out line in DeviceService dtor
* fixup! 3279001: Remove support for font-family: -webkit-pictograph
* fixup! 3279346: appcache: Remove ConsoleMessage appcache field
* chore: update patches after rebase
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2022-01-10 17:31:39 -05:00
Jeremy Rose
d44a187d0b
feat: remove nativeWindowOpen option ( #29405 )
...
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2022-01-06 09:28:03 -08:00
Charles Kerr
cac871c027
Revert "refactor: only create webContents after 'will-attach-webview' ( #30311 )" ( #31785 )
...
This reverts commit 6e43b0bcbf
2021-11-11 15:04:06 -05:00
Keeley Hammond
86f6285299
fix: apply transparency settings to WebContentsPreferences ( #31685 )
...
* fix: add transparency to web_contents_preferences
* fix: correctly apply transparency settings to new webContents from webPreferences
2021-11-03 11:16:18 -07:00
electron-roller[bot]
87f7625c5d
chore: bump chromium to 96.0.4664.4 (main) ( #31317 )
...
* chore: bump chromium in DEPS to 96.0.4662.0
* chore: bump chromium in DEPS to 96.0.4663.0
* chore: update patches
* [Extensions] Remove RuntimeData entirely
https://chromium-review.googlesource.com/c/chromium/src/+/3177328
* Make helper macros behave consistently for //content/public UserData types
https://chromium-review.googlesource.com/c/chromium/src/+/3198788
* Enabling sandboxing for the speech recognition service browser tests
https://chromium-review.googlesource.com/c/chromium/src/+/3146090
* [devtools] Add 'RegisterPreference' host binding
https://chromium-review.googlesource.com/c/chromium/src/+/3162281
* [Reland][Extensions]: Add persistAcrossSessions flag (scripting API)
https://chromium-review.googlesource.com/c/chromium/src/+/3175161
* [Bluetooth] Add Passkey prompt dialog for bonding.
https://chromium-review.googlesource.com/c/chromium/src/+/2841104
* Clipboard: Remove ReadImage path in browser
https://chromium-review.googlesource.com/c/chromium/src/+/3194826
* Split printing metafile code into its own target.
https://chromium-review.googlesource.com/c/chromium/src/+/3164925
* Cleanup unused DesktopMediaListObserver params
https://chromium-review.googlesource.com/c/chromium/src/+/3179203
* Remove base::DictionaryValue::GetBinary
https://chromium-review.googlesource.com/c/chromium/src/+/3201974
* Window Placement: change RWHV::GetDisplayList to GetScreenInfos
https://chromium-review.googlesource.com/c/chromium/src/+/3138774
* Add a preview to the Tab Capture picker dialog
https://chromium-review.googlesource.com/c/chromium/src/+/3045268
* Add service-based usage to update print settings
https://chromium-review.googlesource.com/c/chromium/src/+/3155426
* chore: bump chromium in DEPS to 96.0.4664.2
* chore: update patches
* chore: bump chromium in DEPS to 96.0.4664.4
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4666.0
* Revert "chore: bump chromium in DEPS to 97.0.4666.0"
This reverts commit d73caae8ba4b39efc9b3ea4de52685b9c92ef3d0.
* Reland "Block external protocol handler with sandbox."
https://chromium-review.googlesource.com/c/chromium/src/+/3198263
* fixup for lint
* Add CookiePartitionKeychain parameter to CookeManager.GetCookieList.
https://chromium-review.googlesource.com/c/chromium/src/+/3206016
* Move ui/gfx/transform*,rrect*,mask_filter_info* into ui/gfx/geometry
https://chromium-review.googlesource.com/c/chromium/src/+/3200392
* fixup Move ui/gfx/transform*,rrect*,mask_filter_info* into ui/gfx/geometry
* ozone: //chrome/browser clean up from USE_X11
https://chromium-review.googlesource.com/c/chromium/src/+/3186490
* content: don't load v8 snapshot in browser process
https://chromium-review.googlesource.com/c/chromium/src/+/3183394
* [devtools] Add 'RegisterPreference' host binding
https://chromium-review.googlesource.com/c/chromium/src/+/3162281
* 3186491: Add 'devtools.sync_preferences' preference
https://chromium-review.googlesource.com/c/chromium/src/+/3186491
* 2951147: DCHECK accessible names for focusable Views
https://chromium-review.googlesource.com/c/chromium/src/+/2951147
* 3201014: Use real font size for calculation of SmallTextRatio
https://chromium-review.googlesource.com/c/chromium/src/+/3201014
* fixup Clipboard: Remove ReadImage path in browser
* chore: update patches
* fix: disable PlzServiceWorker to fix custom protocol SW script loading
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3199761
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-10-21 11:51:36 -07:00
Samuel Maddock
7379e5eb36
fix: BrowserWindow backgroundColor ( #30778 )
...
* fix: BrowserWindow backgroundColor
* refactor: propagate transparency via backgroundColor
2021-09-06 16:59:09 +09:00
Jeremy Rose
e223b4db94
fix: respect image animation policy pref ( #30403 )
2021-08-09 09:58:03 -07:00
Jeremy Rose
8179349625
feat: enable sandbox by default in limited circumstances ( #30197 )
2021-08-03 15:07:03 -07:00
Milan Burda
6e43b0bcbf
refactor: only create webContents after 'will-attach-webview' ( #30311 )
2021-08-03 10:08:49 -07:00
Milan Burda
c5ad7ed0cd
refactor: remove guestInstanceId from WebPreferences ( #30280 )
...
* refactor: remove guestInstanceId from WebPreferences
* refactor: remove WebViewManager::GetEmbedder
2021-07-28 15:32:53 -07:00
Jeremy Rose
385d0f590f
refactor: remove base::Value from WebContentsPreferences ( #30193 )
2021-07-26 09:04:09 -07:00
electron-roller[bot]
b8261f1591
chore: bump chromium to 93.0.4550.0 (main) ( #29751 )
2021-06-22 12:17:16 -07:00
Samuel Attard
8446ce1fc7
feat: add new imageAnimationPolicy webpref and webContents setter ( #29095 )
2021-06-08 11:00:22 +09:00
Jeremy Rose
9601dc59fc
refactor: replace --offscreen flag with ApplyWebPreferences ( #28938 )
2021-05-03 15:28:14 +02:00
Jeremy Rose
f8bdef5349
feat: enable nativeWindowOpen by default ( #28552 )
...
* feat: enable nativeWindowOpen by default
* set nativeWindowOpen: false on spec/ main window
* update snapshots
* fix tests
* fix test
* fix webview test missing allowpopups
* fix other test
* update default
2021-04-13 15:36:38 -04:00
Milan Burda
da8c35e3b2
chore: remove deprecated worldSafeExecuteJavaScript option ( #28456 )
2021-04-08 12:03:57 -04:00
Jeremy Rose
5b598037bb
windows build fixes
2021-03-22 15:49:43 -07:00
Jeremy Rose
ea62ecd188
fix GetAsString maybe?
2021-03-22 14:47:24 -07:00
Jeremy Rose
205f572181
incantations for WebContentsPreferences::GetPreloadPath wide strings
2021-03-22 12:15:30 -07:00
Jeremy Rose
deeb2de14b
undo changes to WebContentsPreferences::GetPreloadPath to fix mac build
2021-03-22 10:35:11 -07:00
John Kleinschmidt
2d3c65beca
2757472: Reland "Reland "[LSC] Remove base::string16 alias""
...
https://chromium-review.googlesource.com/c/chromium/src/+/2757472
2021-03-18 15:55:51 -04:00
John Kleinschmidt
22d8f22cfb
2757472: Reland "Reland "[LSC] Remove base::string16 alias""
...
https://chromium-review.googlesource.com/c/chromium/src/+/2757472
2021-03-16 12:18:45 -04:00
John Kleinschmidt
57a8781c01
Merge branch 'master' into roller/chromium/master
2021-03-15 18:43:25 -04:00
Samuel Attard
186301e126
feat: enable context isolation by default ( #26890 )
...
* feat: enable context isolation by default
* chore: set default in ctx iso getter
* spec: make all specs work with the new contextIsolation default
* spec: fix affinity specs
* spec: update tests for new ctx iso default
* spec: update tests for new ctx iso default
* spec: update tests for new ctx iso default
* spec: update tests for new ctx iso default
* chore: move stray prod deps to dev deps
* spec: update tests for new ctx iso default
* turn off contextIsolation for visibility tests
* turn off contextIsolation for <webview> tag nodeintegration attribute loads native modules when navigation happens
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2021-03-01 16:52:29 -05:00
Samuel Attard
db08f08b88
feat: enable world safe JS by default ( #26889 )
...
* feat: enable world safe JS by default
* refactor: use the ctx bridge to send executeJavaScript results in a world safe way
* docs: add more info about the breaking change
* include default in IsEnabled check
2021-01-26 14:23:35 -08:00
loc
0b85fdf26c
feat: add webContents.setWindowOpenHandler API ( #24517 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-11-10 09:06:03 -08:00
Samuel Maddock
10a209ecba
feat: add webPreferences.enablePreferredSizeMode ( #25874 )
...
* feat: add preferredSizeMode preference
* docs: webPreferences.preferredSizeMode and event
* docs: better explain preferred size
* docs: small improvement
* refactor: preferredSizeMode -> enablePreferredSizeMode
2020-10-21 15:44:19 -07:00
Electron Bot
46f3491c7d
chore: bump chromium to 6b9fa6b352d824d052222e1abe541 (master) ( #25558 )
...
* chore: bump chromium in DEPS to d5c9bf9e2a18fa508201a88e5803bec1d107b1ae
* chore: bump chromium in DEPS to 45f1316afae33e52c92480b34bf4f7fe4a7db898
* update patches
* WillCreateURLLoaderFactory now gets a ukm_source_id
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2346803
* ink_drop_visible_opacity -> GetInkDropVisibleOpacity
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415368
* chore: bump chromium in DEPS to ddb5b6db5e35ab1a7b5adbd9f15373af6c35ea2a
* 2418471: PDF Viewer update: Add missing aria-labels to various buttons.
https://chromium-review.googlesource.com/c/chromium/src/+/2418471
* update printing.patch given print settings mojoification
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2409467
* update patches
* content::BluetoothChooser::Event -> content::BluetoothChooserEvent
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2387901
* set_ink_drop_base_color -> SetInkDropBaseColor
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2419388
* chore: bump chromium in DEPS to ecf7c9ee830d4d85f300b461a2fa13aa40c79a4c
* update patches
* gfx::ConvertPointToPixel -> gfx::ConvertPointToPixels
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2418568
* remove ContentSettingsObserver::AllowStorage()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2401847
* service_manager::kCrashDumpSignal -> kCrashDumpSignal
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2417073
* chore: bump chromium in DEPS to abdb7ebe5f8c8328b8f435283df90d0a3ecff7bd
* chore: bump chromium in DEPS to 2a7e138ab1066534ceb2622e8a9d2c8ebf574215
* chore: bump chromium in DEPS to ab1884e75ced904e4276851eb4e1ad89919ca93b
* chore: bump chromium in DEPS to a12413902380dcc2a73ac74d582328280a8af686
* Fixup printing patch
https://chromium-review.googlesource.com/c/chromium/src/+/2428623
* Fixup OSR patch
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Make ExtensionURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2357523
* Add deprecated_default_sources_assignment_filter variable
https://chromium-review.googlesource.com/c/chromium/src/+/2416496
* Fixup patch indices
* Remove several references to BrowserPlugin from content
https://chromium-review.googlesource.com/c/chromium/src/+/2401031
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Add DragOperation and AllowedDragOperations Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/2196167
* chore: bump chromium in DEPS to 378450342cf6aa160663d0ce3a178a11b570c25a
* Fixup patch indices
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Add DragOperation and AllowedDragOperations Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/2196167
* 2426564: Remove global sources assignment filter value
https://chromium-review.googlesource.com/c/chromium/src/+/2426564
* Fixup blink_local_frame.patch
* [XProto] Remove a subset of ui/gfx/x/x11.h
https://chromium-review.googlesource.com/c/chromium/src/+/2430328
* Fixup patch indices
* Remove several references to BrowserPlugin from content
https://chromium-review.googlesource.com/c/chromium/src/+/2401031
* Remove lossy ConvertSizeToPixel() methods
https://chromium-review.googlesource.com/c/chromium/src/+/2419534
* serial: Use USB driver name to disambiguate ports
https://chromium-review.googlesource.com/c/chromium/src/+/2413176
* Remove set_sources_filter import
* Fix ModMask usage
* [XProto] Remove usage of all Xlib headers
https://chromium-review.googlesource.com/c/chromium/src/+/2392140
* [XProto] Remove usage of Xlib Visuals
https://chromium-review.googlesource.com/c/chromium/src/+/2429933
* Skip Angle manifest file
https://chromium-review.googlesource.com/c/angle/angle/+/2425197
* Add whole src\third_party\angle\.git directory
This directory is needed in order to properly generate gen/angle/angle_commit.h
* [libvpx] Fix HighBD config on Windows ARM64
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* update patches
* fix: correct calling convention for Windows on Arm
https://chromium-review.googlesource.com/c/v8/v8/+/2440717
* Add third_party/angle/.git to the archive before adding the rest of the source
* fixup source caching on Windows
* Fixup erroneous close paren
* fixup for goma issues
* This should work
* chore: bump chromium roll manually
https://chromium-review.googlesource.com/c/chromium/src/+/2435142
This landed the day after we paused roller-bot and may resolve the
visibility test flakes that we're seeing. h/t to @jkleinsc for
finding this with me.
* chore: remove obsoleted cherry-pick fix for libvpx
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* chore: remove obsoleted cherry-pick libvpx patch
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* chore: re-export patches
* chore: add tracer comment to visibility-stat-spec.
The line numbers between the source and the CI runs don't seem to match
up, so this temp tracer is to help track the source of that difference.
* chore: bump chromium in DEPS to 7c2b8cc3b8638aee8abeb013042a6c1d15b2da6b
* update patches
* impl SortingLSH service
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2425327
* 2446525: [Flash] Remove some Flash APIs
https://chromium-review.googlesource.com/c/chromium/src/+/2446525
* 2440974: Reland "Delete service_manager/embedder/switches.h"
https://chromium-review.googlesource.com/c/chromium/src/+/2440974
* 2359402: Remove ContentBrowserClient::NonNetworkURLLoaderFactoryDeprecatedMap.
https://chromium-review.googlesource.com/c/chromium/src/+/2359402
* 2250506: Implement tabs.removeCSS
https://chromium-review.googlesource.com/c/chromium/src/+/2250506
* 2429143: Remove implicit-conversion-to-integer ConvertRectToPixel() methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2429143
* 2444430: Remove DataElementType::kBlob
https://chromium-review.googlesource.com/c/chromium/src/+/2444430
* 2441964: Clean up WebView public API
https://chromium-review.googlesource.com/c/chromium/src/+/2441964
* 2357523: Make ExtensionURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2357523
* 2461606: Use blink::mojom::PreferredColorScheme instead of blink::PreferredColorScheme
https://chromium-review.googlesource.com/c/chromium/src/+/2461606
* 2461235: a11y inspect reorg: move PropertyFilter struct to a new location
https://chromium-review.googlesource.com/c/chromium/src/+/2461235
* remove flash support
* fix frame_host_manager patch
* fix lint
* remove flash info from docs
* fix build
* fix osr
* chore: bump chromium in DEPS to 9269f9eb1d98d29564c2b2ab97f30c6e148c4e11
* fix visibilityState tests
* 2463049: Replace all uses of web_pref::AutoplayPolicy with mojom::AutoplayPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/2463049
* update patches
* fix tests harder
* 2414921: Add Group and Ungroup functions to Tabs extension API
https://chromium-review.googlesource.com/c/chromium/src/+/2414921
* more test fix
* Remove all keyboard related usage of Xlib
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2436787
* fix linux build
* 2453807: [XProto] Remove usage of Xlib error handling
https://chromium-review.googlesource.com/c/chromium/src/+/2453807
* lint
* fixup! 2453807: [XProto] Remove usage of Xlib error handling
* disable CalculateNativeWinOcclusion on win ci
* remove UploadBlob from docs
* Update appveyor.yml
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-10-15 18:30:41 -07:00
David Sanders
b194030a34
chore: cleanup some typos in comments ( #25770 )
2020-10-13 10:25:21 -07:00
Electron Bot
69f1731bbb
chore: bump chromium to ec5bc1743792d64724693eb357083 (master) ( #24984 )
...
* chore: bump chromium in DEPS to cbdeef954dfc34e94c8ca9cf72ad326b4a121158
* chore: bump chromium in DEPS to 29723f905baeab1d4228eef2c31cdb341ebeffe0
* chore: bump chromium in DEPS to 44d6d78e852137fff58c14ed26ab1e803e5bf822
* update patches
* chore: bump chromium in DEPS to 8a3a0fccb39d6b8334c9a0496c0d5056e50cdb3f
* chore: update patches
* refactor: fix PrintBackend::CreateInstance() calls
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2354541
* chore: bump chromium in DEPS to b9ebec3bcb1cabdd1426f367636f54cc98e0500e
* chore: remove patches to code that was deleted upstream
CL: https://chromium-review.googlesource.com/c/chromium/src/+/2360314
* Remove uses of kCGColorSpaceITUR_2020_PQ_EOTF/HLG
CL: https://chromium-review.googlesource.com/c/chromium/src/+/2363950
just garden variety code shear
* chore: update patch indices
* Move ColorModel to //printing/mojom/print.mojom
https://chromium-review.googlesource.com/c/chromium/src/+/2355083
sync with printing ColorModel changes: moved to mojo, different naming scheme
* chore: bump chromium in DEPS to 56c4b4d2ce5ba941acd2e0fdb5100e8a48847134
* chore: bump chromium in DEPS to 130501f220b684a79dc82c17e236e63ac1f2a093
* Convert PrintHostMsg_DidGetPrintedPagesCount to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/2326857
Update argument list to Print()
* chore: update patch indices
* DumpAccTree: convert utf16 to utf8 in PropertyFilter
https://chromium-review.googlesource.com/c/chromium/src/+/2360218
* chore: bump chromium in DEPS to 3058368c6646e0dc8be6f8ea838b0343428b7998
* chore: bump chromium in DEPS to f51b4e6555364363c61438dac7afd988c8347bfc
* chore: bump chromium in DEPS to 2dcc6f8fc23ac41b2499eb69dee0b4017e9d1046
* update patches
* chore: bump chromium in DEPS to 2d8e98ecedc7e4905540b053bc1c87e964715be5
* update patches
* 2345900: Move content::RecordContentToVisibleTimeRequest struct to mojo
https://chromium-review.googlesource.com/c/chromium/src/+/2345900
* update patches
* 2345900: Move content::RecordContentToVisibleTimeRequest struct to mojo
https://chromium-review.googlesource.com/c/chromium/src/+/2345900
* 2367394: Remove net::LOAD_DO_NOT_SEND_COOKIES and net::LOAD_DO_NOT_SEND_AUTH_DATA.
https://chromium-review.googlesource.com/c/chromium/src/+/2367394
* 2373227: [XProto] Consolidate all <X11/*> includes to //ui/gfx/x/x11.h
https://chromium-review.googlesource.com/c/chromium/src/+/2373227
* fixup! 2373227: [XProto] Consolidate all <X11/*> includes to //ui/gfx/x/x11.h
* chore: bump chromium in DEPS to c090e3f960520cbd2328608b97f87238c76d6143
* update patches
* chore: bump chromium in DEPS to 13a25e0a755de9a14271022c595f3d2e29829e1a
* chore: bump chromium in DEPS to 6adbb767b012c41efaeab0d1bdbb3eefed0977bc
* chore: bump chromium in DEPS to 339ec5455c5932ef1322ea9953a6349b0732199e
* chore: bump chromium in DEPS to 20291807c33f7ef4ef4f57d62075e099b027bfe6
* chore: bump chromium in DEPS to 226fbd1b8b17d4ac84fdb9548ef3a1c646878d47
* update patches
* fixup disable_color_correct_rendering patch
* chore: bump chromium in DEPS to 577c45979cad4359f2e206d68efd9317d3d79315
* update patches
* viz: Rename RenderPass to CompositorRenderPass (and related types).
https://chromium-review.googlesource.com/c/chromium/src/+/2380730
* chore: bump chromium in DEPS to 37e2ad5303f2c03a1b5d8eda65341bf2561196cd
* update patches
* add kOmitCookies_Electron
* update patch
* chore: bump chromium in DEPS to 256e42409ea63a7e71016de07818a983a97db463
* update patches
* fix worker script ready hook
https://chromium-review.googlesource.com/c/chromium/src/+/2335713
* Fixup printing page ranges patch
* [printing] Move PrintMsg_PrintPages_Params to print.mojom
https://chromium-review.googlesource.com/c/chromium/src/+/2340854
* Add MIME sniffer overloads that take base::StringPieces
https://chromium-review.googlesource.com/c/chromium/src/+/2382896
* [printing] Move PrintHostMsg_PreviewIds to print.mojom
https://chromium-review.googlesource.com/c/chromium/src/+/2379455
* fixup test due to new DCHECK
https://chromium-review.googlesource.com/c/chromium/src/+/2333750
* stop sending cookies when useSessionCookies is false
* chore: bump chromium in DEPS to dd429dbc556449951ee8160d8a4d61fd95a139d5
* update patches
* chore: bump chromium in DEPS to 5202bde3f9f44c2065f5dacf27e7000dd19e4e4d
* chore: bump chromium in DEPS to 099e8e07b89da65932431bb0fd51b6f7f5344c19
* chore: bump chromium in DEPS to 104e5da2a43b759732d5b94bfc750b3a9a639653
* chore: bump chromium in DEPS to a4519ce657af25834e355315fd7fefa77b13426a
* update patches
* Make FileURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2337411
* Make FileURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2337411
* chore: bump chromium in DEPS to 1b62e9e8c8eaf6b8e3a9c77ee67a4c1bfa6a4d6b
* chore: update patches
* fixup! Make FileURLLoaderFactory always owned by its |receivers_|.
* chore: update patches
- mac: Disable CoreServices _CSCheckFix.
https://chromium-review.googlesource.com/c/chromium/src/+/2401334
- [XProto] Remove bad DCHECK in x11_error_tracker.cc
https://chromium-review.googlesource.com/c/chromium/src/+/2402304
- Move content/browser/frame_host/* over to content/browser/renderer_host/
https://chromium-review.googlesource.com/c/chromium/src/+/2401303
* Refactor WebContentSettingsClient to dedupe AllowXYZ methods
https://chromium-review.googlesource.com/c/chromium/src/+/2353552
* Introduce NonNetworkURLLoaderFactoryBase class.
https://chromium-review.googlesource.com/c/chromium/src/+/2357559
* [XProto] Remove usage of all Xlib headers
https://chromium-review.googlesource.com/c/chromium/src/+/2392140
* fixup! chore: update patches
* chore: bump chromium in DEPS to c1df55fbeb8207d036a604f59e4ea4e8ee79930a
* chore: update patches
* Move content::WebPreferences struct to Blink
https://chromium-review.googlesource.com/c/chromium/src/+/2397670
* chore: bump chromium in DEPS to 57a23ec4884fff6c2f8d9b8536131cdc9b551ec2
* Set appid on Pip windows.
https://chromium-review.googlesource.com/c/chromium/src/+/2388274
* fixup! Set appid on Pip windows.
* fix: add a patch to remove deprecated factory
* chore: bump chromium in DEPS to 1a9ddb7ea43955877823d5c4dcbf241b64228635
* fix compilation on windows
* chore: bump chromium in DEPS to 234e6c6a77f61ffad9335099d9b13892cf88fd44
* chore: update patches
* chore: bump chromium in DEPS to 7631eb0a9f57a8a47d3c28e1d265961b3a4d6b2b
* chore: update patches
* chore: bump chromium in DEPS to f9c34cd485845b95c2d17a7f55fdf92cda9a1b3a
* chore: update patches
* chore: implement GetSurveyAPIKey
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2362182
* chore: replace CreateWebUIURLLoader with CreateWebUIURLLoaderFactory
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2358309
* chore: bump chromium in DEPS to 5bdbd2373da884adf41c087be1465fcc344d168c
* chore: update node patches for common.gypi
* chore: update patches
* chore: non_network_url_loader_factory_base was moved
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2357431
* 2415752: Reland "Reland "OOR-CORS: Remove BlinkCORS supporting code outside Blink""
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415752
* chore: bump chromium in DEPS to b943d006a33ec5bc1743792d64724693eb357083
* fix: replace x11::None with x11::Window::None
* chore: update patches
* chore: update patches
* fix: cast x11::Window to int
* 2402123: Use end date when deleting http auth cache
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2402123
* 2320268: Migrate DragHostMsg_StartDragging to Mojo
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2320268
* 2401303: Move content/browser/frame_host/* over to content/browser/renderer_host/
https://chromium-review.googlesource.com/c/chromium/src/+/2401303
* chore: fix lint
* chore: fix build
* Update config.yml
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
2020-09-21 01:00:36 -07:00
Electron Bot
8798571a77
chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) ( #24687 )
...
* chore: bump chromium in DEPS to 1f1c4d91f6eaa4a033ec8f499d63a0717f79a42a
* viz: Do not apply white level scaling for RGBA fp16 HDR video
https://chromium-review.googlesource.com/c/chromium/src/+/2296006
* Move WebPreferences to WebContents
https://chromium-review.googlesource.com/c/chromium/src/+/2263635
* Fix missing WeakPtr check in PreconnectManager
https://chromium-review.googlesource.com/c/chromium/src/+/2309029
* Fixup swiftshader roll revision
* Update patch indices
* Move WebDeviceEmulationParams into common.
https://chromium-review.googlesource.com/c/chromium/src/+/2303356
* Move EnableDisableDeviceEmulation to blink mojom messages
https://chromium-review.googlesource.com/c/chromium/src/+/2303367
* PDF Viewer: Remove flag for two-up view
https://chromium-review.googlesource.com/c/chromium/src/+/2311130
* Add mojom definition for DeviceEmulationParams.
https://chromium-review.googlesource.com/c/chromium/src/+/2303491
* Remove ServiceWorkerContextWatcher from PaymentAppInstaller
https://chromium-review.googlesource.com/c/chromium/src/+/2291186
* Loader: Move transferrable_url_loader.mojom into blink's mojom directory
https://chromium-review.googlesource.com/c/chromium/src/+/2306123
* chore: bump chromium in DEPS to 4974f436479739025a90ebc2cc2e36d67ee1ac46
* mac: Work around Xcode 12b3 SDK bug
https://chromium-review.googlesource.com/c/chromium/src/+/2315078
* Reland Update core items for macOS Big Sur.
https://chromium-review.googlesource.com/c/chromium/src/+/2315162
* Update Swiftshader revision
* mac/arm64: When cross-building the snapshot, use page size of the target ISA instead of the host.
https://chromium-review.googlesource.com/c/v8/v8/+/2310575
* Update patch indices
* Rename {,Non}ClientView::CanClose() to OnWindowCloseRequested()
https://chromium-review.googlesource.com/c/chromium/src/+/2247838
* chore: bump chromium in DEPS to e9465d70d1dea539400f0fddad43358ea3c31d71
* chore: bump chromium in DEPS to bd5b71c5f20288eb26068a39ae6e0579566a51c5
* chore: bump chromium in DEPS to 786ee543048bd07d07c5ac50b7dbbdd6bdd8dcce
* chore: bump chromium in DEPS to 34eb6ecbf2c5894b648900bf771a2a29de204798
* chore: bump chromium in DEPS to 567ff038d68e3adb8116a01eec863cdf34d775f5
* chore: bump chromium in DEPS to 340b45c8d4ceb2dd61969fc34e1928d3c46db48c
* chore: update patches
* chore: base::DeleteFile with two params is removed
Should use base::DeleteFile and base::DeletePathRecursively when
appropriate
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2313376
* chore: add patch for NodePlatform::PostJob impl
* chore: update patches
* chore: extension file access is now instrumented
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2209995
* chore: implement SetWindowFrameInScreen in OSR RWHV
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2321409
* chore: NotifyUserActivation requires a type now
This is just for a histogram thing and therefore it does not matter what
we pass in
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2281303
* chore: update patches
* chore: bump chromium in DEPS to cd570e6dd3dcb84463ac252b04e92ceb02d8400c
* chore: update patches
* chore: bump chromium in DEPS to 0187908a31866992b90c59719ac1d016328f6ee0
* chore: bump chromium in DEPS to 3c9df38c508f3dba26a75248beed4882ddfb98e9
* chore: bump chromium in DEPS to 1a47d3b9cee710bd3c958c4f2d8b205710df9d50
* chore: bump chromium in DEPS to baac93040d96abdab72d46dd034c60f86e108702
* chore: bump chromium in DEPS to 13836145f97299e636491de38064b78861c4fb2e
* update patches
* change OS_MACOSX -> OS_MAC
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1105907
* patch: add header for ToExecutionContext in WebMessagePortConverter
* chore: bump chromium in DEPS to 91ab9b6ac5d04dc034a03ad847fbfa8261328c2b
* update patches
* NeedToFireBeforeUnloadOrUnload -> NeedToFireBeforeUnloadOrUnloadEvents
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2288711
* chore: bump chromium in DEPS to 290deb11f0e30cb1382fd8f8793d340560283c23
* update patches
* add dragdrop header for autofill popup
* int -> x11::Time
* patch out accessibility private API use
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2330812
* remove usage of XEvent
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2317767
* trigger recalculation of WebPreferences before renderer initialization
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2263635
* chore: bump chromium in DEPS to 6bdb484583b99c96ef3388d0c2184326581b2d5a
* chore: bump chromium in DEPS to 1eb2a79cde04fd5c8ae51b4d813e6521635269e5
* chore: bump chromium in DEPS to 3dc8e3c0f400e4ca9c0a63d7a39bd910997ad4c6
* chore: update patches
* fixup! trigger recalculation of WebPreferences before renderer initialization
* views: Make MenuButton and RadioButton default constructible
https://chromium-review.googlesource.com/c/chromium/src/+/2339586
* chore: fix code style
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2020-08-12 11:33:58 -07:00
Samuel Attard
b500294c1d
feat: add worldSafe flag for executeJS results ( #24114 )
...
* feat: add worldSafe flag for executeJS results
* chore: do not log warning for webContents.executeJS
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* chore: apply PR feedback
* chore: split logic a bit
* chore: allow primitives through the world safe checl
* chore: clean up per PR feedback
* chore: flip boolean logic
* chore: update per PR feedback
* chore: fix typo
* chore: fix spec
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-07-23 14:32:20 -07:00
Electron Bot
8bbdc224ac
chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) ( #24256 )
...
* chore: bump chromium in DEPS to 7fb9778894d73378bff51087ce869ea5aa6e5d5d
* chore: bump chromium in DEPS to 83da426e53d423f0530fc23433b6d2c4d0548442
* update patches
* remove chromeos-only TtsControllerDelegate
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2255314
* SharedUserScriptMaster -> SharedUserScriptManager
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2258357
* avoid deprecated DISALLOW_COPY_AND_ASSIGN
https://groups.google.com/a/chromium.org/forum/#!msg/cxx/qwH2hxaEjac/TUKq6eqfCwAJ
* chore: bump chromium in DEPS to b2eaf9ff4e6b03267bf279583ea20ceb2b25e9d0
* update patches
* rename GetHighContrastColorScheme -> GetPlatformHighContrastColorScheme
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2250224
* remove vulkan info collection
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2252818
* add max_xcode_version build var
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2264867
* add missing headers
* chore: bump chromium in DEPS to cded18ca1138f7e8efc904f077ddcca34f0135cf
* update patches
* add empty floc blocklist to BrowserProcessImpl
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2240873
* chore: bump chromium in DEPS to f06602226cd80bf677b2ce013a94a2fb7f6ac58d
* chore: bump chromium in DEPS to 747aa4bfc74fc6cf7f08ee72624cd69ae41ae28d
* chore: bump chromium in DEPS to 31c0105e50fcc4e94de33e5c8602c755ace4a32b
* chore: update patches
* Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
https://chromium-review.googlesource.com/c/chromium/src/+/2264297
* X11 and Ozone: make sure gfx::AcceleratedWidget to be uint32_t
https://chromium-review.googlesource.com/c/chromium/src/+/2260554
* Move zygote from //services/service_manager back to //content
https://chromium-review.googlesource.com/c/chromium/src/+/2252466
* chore: update v8 patches
* [XProto] Remove usage of Shape extension
https://chromium-review.googlesource.com/c/chromium/src/+/2262113
* fixup! add empty floc blocklist to BrowserProcessImpl
* Require macOS 10.15.1 sdk
https://chromium-review.googlesource.com/c/chromium/src/+/2238504
* Use newer Xcode version 11.5.0
* update src cache
* chore: bump chromium in DEPS to 60a9883e35db3f6f91916f0878e88e1849c17b11
* chore: update patches
* Reland "Reland "New toolchain for Windows 10 19041 SDK""
https://chromium-review.googlesource.com/c/chromium/src/+/2255527
* update patches
* Convert raw NonClientFrameViews to unique_ptrs
https://chromium-review.googlesource.com/c/chromium/src/+/2240417
* [printing] Move PrintHostMsg_DidPreviewDocument_Params to print.mojom
https://chromium-review.googlesource.com/c/chromium/src/+/2257035
* chore: bump chromium in DEPS to 12c233c2a85bfa28fb279f390121ba681e52a71b
* chore: update patches
* Removing oppressive language for the directory chrome/browser/apps
https://chromium-review.googlesource.com/c/chromium/src/+/2269822
* Inclusion: rename SpellcheckLanguageBlacklistPolicyHandler
https://chromium-review.googlesource.com/c/chromium/src/+/2267646
* Clean up duplicate WebContents "is fullscreen" functions
https://chromium-review.googlesource.com/c/chromium/src/+/2275148
* Adds icon loading service with sandbox for Windows.
https://chromium-review.googlesource.com/c/chromium/src/+/1987273
* No more Vulkan info collection for UMA on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2252818
* fix lint
* chore: update buildflag conditions
* chore: bump chromium in DEPS to a837d4c4230ace4f10b2768728f4044b7995dfa5
* update hunspell files
* chore: update patches
* Make content::FileSelectListener a RefCounted
https://chromium-review.googlesource.com/c/chromium/src/+/2275338
* fix build failures on MAS
* update patches
* fixup! Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
* fix build on windows
* Check for GDI exhaustion if window creation fails
https://chromium-review.googlesource.com/c/chromium/src/+/2244124
* chore: bump chromium in DEPS to 2c9b2a73be4ef9ec22d8b6da8e174cb80753f125
* chore: update patches
* Network Service: Move DeleteCookiePredicate into public folder
https://chromium-review.googlesource.com/c/chromium/src/+/2264186
* chore: bump chromium in DEPS to fa2606299bcc02c362528d26b5dcf8c8a0db0735
* chore: bump chromium in DEPS to d9c235d1227204dbae3708daae851573a3566b94
* chore: bump chromium in DEPS to 2f82c284243c035f49a747fd1ead6c44b4b31093
* chore: update patches
* Move creating the LayerTreeSettings into blink.
https://chromium-review.googlesource.com/c/chromium/src/+/2267720
* chore: bump chromium in DEPS to 914112f1d9af9e4974059dc403da62699a55550f
* update patches
* chore: bump chromium in DEPS to e0bc1ffae6393fc543a2da94c88167df75859b36
* refactor: match upstream print preview handling (#24452 )
* update patches
* chore: bump chromium in DEPS to 0881423156abe084164b51ab58ce93a8bd380524
* update patches
* update patches
* give a type to pendingPromise
* chore: bump chromium in DEPS to 11a8c1534b16d130075d378a64187360ba4e7820
* update patches
* 2272609: Move //services/service_manager/sandbox to //sandbox/policy.
https://chromium-review.googlesource.com/c/chromium/src/+/2272609
* update patches
* fixup! 2272609: Move //services/service_manager/sandbox to //sandbox/policy.
* fixup! 2272609: Move //services/service_manager/sandbox to //sandbox/policy.
* 2264511: Cookies: Update SetCanonicalCookie to return CookieAccessResult
https://chromium-review.googlesource.com/c/chromium/src/+/2264511
* chore: fix setAlwaysOnTop test
The window must be visible for state to be updated properly.
* Revert "Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex."
https://webrtc-review.googlesource.com/c/src/+/179080
* update patches
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2020-07-13 21:13:34 -04:00
Samuel Attard
16a3f41fd3
chore: add deprecation warning for the default of contextIsolation ( #23507 )
...
* chore: add deprecation warning for the default of contextIsolation
* chore: add to breaking changes
* Update docs/breaking-changes.md
Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
* chore: fix specs on windows
Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
2020-06-25 10:55:17 -07:00
Robo
f67aff2704
feat: add V8CacheOptions webpreference ( #23842 )
...
* feat: add V8CacheOptions webpreference
* address review comments
2020-05-31 20:09:23 -07:00
Robo
a707a3eda3
feat: add enableWebSQL webpreference ( #23311 )
...
* feat: add enableWebSQL webpreference
* chore: update indexedDB test
2020-05-06 12:52:59 -07:00
Jeremy Apthorp
b77f701aeb
feat: disable the remote module by default ( #22091 )
2020-02-10 10:49:09 -08:00
Jeremy Apthorp
2e1531ad90
feat: warn when remote is used without enableRemoteModule: true ( #21546 )
...
* feat: warn when remote is used without enableRemoteModule: true
* fix security warning
2020-01-13 15:23:03 +09:00
Samuel Attard
6bcf67e051
feat: enable builtin spellchecker ( #20692 )
...
* chore: add code required to use chromes spellchecker
* chore: fix linting
* chore: manifests needs buildflags now
* chore: add dictionarySuggestions to the context menu event when the spellchecker is active
* chore: enable by default for windows builds
* chore: add patch to remove incognito usage in the spellchecker
* chore: add dependencies on spellcheck common and flags
* chore: conditionally include spell check panel impl
* chore: fix deps for spellcheck feature flags
* chore: add patch for electron resources
* chore: add dependency on //components/language/core/browser
* chore: patches to make hunspell work on windows
* build: collect hunspell dictionaries into a zip file and publish
* chore: clean up patches
* chore: add docs and set spell checker url method
* chore: fix error handling
* chore: fix hash logic
* build: update hunspell filename generator
* fix: default spellchecker list to the current system locale if we can
* docs: document the language getter
* chore: patch IDS_ resources for linux builds
* feat: add spellcheck webpref flag to disable the builtin spellchecker
* chore: fix docs typo
* chore: clean up spellchecker impl as per feedback
* remove unneeded deps
2019-10-31 13:11:51 -07:00
Cheng Zhao
3ae3233e65
chore: remove native_mate (Part 12) ( #20869 )
...
* refactor: move mate::Event to gin
* refactor: move mate::Locker to gin
* refactor: convert contextBridge to gin
* refactor: convert contentTracing to gin
* refactor: remove callback converter of native_mate
* refactor: remove file_dialog_converter and native_window_converter from native_mate
* refactor: convert webFrame to gin
* refactor: move blink_converter to gin
* refactor: remove net_converter from native_mate
* refactor: remove event_emitter_caller_deprecated
* refactor: remove gurl_converter from native_mate
* refactor: remove file_path and string16_converter from native_mate
* refactor: remove image_converter from native_mate
* refactor: move value_converter to gin
2019-10-31 16:56:00 +09:00
Cheng Zhao
0fe6767d6b
chore: remove native_mate (Part 11) ( #20719 )
...
* refactor: convert Menu and globalShortcut to gin
* refactor: convert api::Cookies to gin
* refactor: convert View and WebContentsView to gin
* refactor: convert WebContents related classes to gin
* refactor: convert powerMonitor to gin
* refactor: prepare for header change
* refactor: remove last uses of mate::EventEmitter
* refactor: remove mate::EventEmitter
* refactor: move trackable_object to gin_helper
* fix: custom converter should not use Handle
* fix: no more need to check if icon is empty
It was a bug that the Handle<NativeImage> can be non-empty when the
image file does not exist. The bug was caused by the converter code
writing out the image even when the convertion fails.
The bug was work-arounded by adding an additional check, but since the
original bug had been fixed, the additional check is no longer needed.
* fix: should always set frameId even when callback is null
* fix: do not mix gin/mate handles for NativeImage
2019-10-25 22:03:28 +09:00
Milan Burda
11cd0db86b
build: add enable_remote_module build flag ( #19821 )
2019-09-18 09:52:06 -07:00
Milan Burda
01fdb80f7c
refactor: implement isRemoteModuleEnabled via getLastWebPreferences() ( #19220 )
2019-08-28 15:57:03 -07:00
Charles Kerr
f6fb877de9
chore: pass base::StringPiece args by value ( #19432 )
...
https://cs.chromium.org/chromium/src/base/strings/string_piece.h?l=14
discusses this, saying "Prefer passing StringPieces by value" because
"[p]assing by value generates slightly smaller code."
2019-07-25 10:19:04 -05:00
