Cheng Zhao
91c4ed26fc
Print warnings for deprecated APIs
2015-11-09 21:51:30 +08:00
Cheng Zhao
f0bd28ca8d
Do not turn off deprecation notice by default
...
It is v4 now, people should be punished if they are still using
deprecated Node.js APIs.
2015-11-09 21:19:16 +08:00
Cheng Zhao
89ff62b1b5
Add "deprecate" module
2015-11-09 21:19:16 +08:00
Cheng Zhao
312a79165b
Bump v0.34.3
2015-11-06 21:37:37 +08:00
Cheng Zhao
d70706f876
Make sure handles of callbacks are releases on exit
...
Some callbacks are stored in native resources that not managed by
JavaScript, so when those resources are destroyed the JavaScript context
may already be destroyed, and releasing callbacks then would result in
crash.
2015-11-06 21:00:32 +08:00
Cheng Zhao
acf4372cf7
win: Add ELECTRON_DEFAULT_ERROR_MODE env
...
It is useful to help debugging crashes without opening debugger.
2015-11-06 20:25:20 +08:00
Cheng Zhao
863199348f
Make process.exit() quit gracefully
...
Instead of abrupting the whole program immediately, we should close all
windows and release all native resources gracefully on exit. This avoids
possible crashes.
Fix #3350 .
2015-11-06 20:25:20 +08:00
Nishanth Shanmugham
8a296f82a0
Tray: Remove extra qualification in header
2015-11-05 19:02:24 -06:00
Nishanth Shanmugham
818892d474
Tray: Add drag-entered and drag-exited events
2015-11-05 18:46:49 -06:00
Cheng Zhao
2505ebb9a6
win: Guard against failure of RtlAddFunctionTable
...
On some machines this call will fail and CHECK will abort the
application.
2015-11-05 22:00:40 +08:00
Cheng Zhao
47649ffd17
win: Fix calling showItemInFolder in renderer process
2015-11-05 20:47:27 +08:00
Tyler Gibson
4ff5ce4d6d
Fixing MoveItemToTrash behavior in Windows
...
Modifying MoveItemToTrash for Windows to actually verify file can be
moved to a drive's recycle bin before attempting to delete it.
PR: #3337 .
2015-11-05 20:42:30 +08:00
Ryan Molden
4ce840d8e6
Re-enable accessibility in Electron on Windows
...
In conjunction with commit 7c41f0e
.
2015-11-05 19:49:48 +08:00
Cheng Zhao
d56b34de3b
Make sure all native resources get freed on exit
2015-11-04 18:21:03 +08:00
Cheng Zhao
07c55f321f
Destroy JS env immediately after running destruction callbacks
2015-11-04 17:31:10 +08:00
Cheng Zhao
84410a7e1c
mac: Destroy the app delegate before running destruction callbacks
...
Otherwise users might be able to access wrapper functions after they are
destroyed.
2015-11-04 17:23:27 +08:00
Cheng Zhao
75f49477ca
Cleanup wrapper function when app has done quitting
...
The app may still do something when quitting, we need to make sure the
wrapper function is still there at that time.
2015-11-04 16:54:36 +08:00
Cheng Zhao
441cc3e57e
Style fix
2015-11-04 16:50:19 +08:00
mgarciaisaia
4013b652ff
🏁 🐛 Buffer overflows in tooltips
...
Fixes #3290 .
2015-11-04 15:34:58 +08:00
Joao Moreno
7c41f0e0e3
remove kDisableLegacyIntermediateWindow switch set
2015-11-03 16:12:01 -08:00
Cheng Zhao
1b165559f5
win: Use electron.app.$1 as default user model id
...
This is to keep compatibility with old apps that don't set app user
model id explicitly.
2015-11-03 15:50:43 +08:00
Cheng Zhao
7b47b70c9e
Fix building on POSIX
2015-11-03 15:30:37 +08:00
Cheng Zhao
9047f81835
win: Set app user model ID in one place
...
Fix #3297 .
Fix #2573 .
2015-11-03 15:09:31 +08:00
Cheng Zhao
7c7a7b96de
win: Do not set app user model id by default
...
When user drags exe file into taskbar directly the pinned icon will not
has an app user model id, so if we set app user model id in the
application two icons will show in the taskbar.
For apps installed with a installer it is not a problem since the
shortcut icon will be created with app user model id, but we should also
keep the ability to make portable apps work out of box.
Fix #3303 .
2015-11-03 14:55:43 +08:00
Cheng Zhao
9236adfbf5
Translate menu template directly in C++
2015-11-02 23:31:44 +08:00
Cheng Zhao
56e6b28370
Merge pull request #3288 from deepak1556/flash_context_menu_pathc
...
browser: handle flash context menu request
2015-11-02 21:20:44 +08:00
Cheng Zhao
f7c0418bd8
Ignore case for type of savePage
2015-11-02 21:19:00 +08:00
Cheng Zhao
647a0c4e2b
Code cleanup for remote module
2015-11-02 20:28:01 +08:00
Max Claus Nunes
bbb5aef5d2
Improve error handling from remote
...
This way copy all properties available in the error object and keep the real stack trace
2015-10-31 21:20:54 -02:00
Robo
c969052f12
browser: handle flash context menu
2015-11-01 01:13:17 +05:30
Cheng Zhao
cb91d4487b
Clean up the code handling renderer callback
2015-10-31 15:00:06 +08:00
Cheng Zhao
323ab92299
Merge pull request #3251 from deepak1556/remote_callback_patch
...
remote: track listeners on browser side
2015-10-31 14:18:58 +08:00
Robo
2c59f4567e
use webcontents id to identify callbacks
2015-10-30 19:51:19 +05:30
Antonio Scandurra
9c69877421
Allow v8 to optimize fs.readFileSync
2015-10-30 10:30:27 +01:00
Cheng Zhao
21a7c459d8
Bump v0.34.2
2015-10-30 14:50:57 +08:00
Robo
3a154ab8ea
add line and column values to callback id
2015-10-29 21:21:30 +05:30
Robo
ac4df34ecd
create binding to idweakmap
2015-10-29 17:51:56 +05:30
Robo
eae7c840b7
use idweakmap for holding callbacks in browser
2015-10-29 17:51:56 +05:30
Robo
62d15953ff
remote: track listeners for browser side
2015-10-29 17:51:56 +05:30
Cheng Zhao
917b33dbe7
Small code cleanup
2015-10-29 10:55:08 +08:00
Cheng Zhao
0f89f67a84
Merge pull request #3254 from templateK/master
...
Fix remove boolean parameter at IsSwitchEnabled function
2015-10-29 10:54:56 +08:00
Cheng Zhao
bf9e6ba11e
Merge pull request #3256 from omrilitov/master
...
Use WPARAM as uint64_t and LPARAM as int64_t
2015-10-29 10:41:11 +08:00
Omri Litov
ef038257d1
Returns buffer instead of WPARAM and LPARAM
2015-10-29 03:00:44 +02:00
Omri Litov
f22837523f
Use WPARAM as uint64_t and LPARAM as int64_t
2015-10-28 21:54:50 +02:00
taemu
16eafdb0ce
Fix remove boolean parameter at IsSwitchEnabled function
2015-10-29 03:22:08 +09:00
Cheng Zhao
51ba37440d
Guard against multiple calls of auth
2015-10-28 21:20:08 +08:00
Cheng Zhao
569e87035a
Also emit "login" on WebContents
2015-10-28 21:00:39 +08:00
Cheng Zhao
f40a3f72d7
Converted callback can only be called for once
2015-10-28 20:44:46 +08:00
Cheng Zhao
4eac6b31b1
Also pass "webContents" in "login" event
2015-10-28 20:23:18 +08:00
Cheng Zhao
131531219e
Pass auth_info and request in "login" event
2015-10-28 20:13:06 +08:00
Cheng Zhao
d05255179a
Add login event for "app" module
2015-10-28 19:54:59 +08:00
Cheng Zhao
54dad72d92
Don't leak TranslaterHolder
2015-10-28 19:54:59 +08:00
Cheng Zhao
9847747736
Use the callback converter in JsAsker
2015-10-28 19:54:59 +08:00
Cheng Zhao
3881ad1c4b
Don't leak FunctionTemplate when converting C++ callback
2015-10-28 19:54:59 +08:00
Cheng Zhao
9df89cf79b
Add dummy LoginHandler
2015-10-28 19:54:59 +08:00
Cheng Zhao
b86267aa3b
Use uint64_t instead of LPARAM
...
LPARAM is defined to differnt types on differnt machines with different
SDKs, so there is no way to represent it on all platforms safely, using
uint64_t seems to be the only safe choice.
2015-10-28 19:51:24 +08:00
Cheng Zhao
5fd310c75f
Add converter for LPARAM
2015-10-28 19:43:05 +08:00
Cheng Zhao
c9b53a6e8b
Merge pull request #3240 from atom/reland-win-remove-wildcard-extension
...
Reland win remove wildcard extension
2015-10-27 20:52:43 +08:00
Cheng Zhao
142f380376
Merge pull request #3231 from omrilitov/master
...
Hooking windows messages
2015-10-27 20:48:19 +08:00
Haojian Wu
f69bafd48a
Win: Fix adding '.*' to filename in callback.
2015-10-27 20:15:43 +08:00
Haojian Wu
fa24e15d8b
Win: Remove adding '*.*' to file name in a save dialog.
2015-10-27 20:15:20 +08:00
Omri Litov
e355532d27
Change windows messages api to hook instead of emitter
2015-10-27 14:00:08 +02:00
Cheng Zhao
dacd921a04
Revert "Win: Remove adding default file filter(*.*) in a save dialog."
...
This reverts commit 00493f64b7
.
2015-10-27 14:58:44 +08:00
Cheng Zhao
3042f604cc
Merge pull request #3234 from atom/win-remove-default-filter
...
Win: Remove adding default file filter(*.*) in a save dialog.
2015-10-27 14:30:35 +08:00
Haojian Wu
00493f64b7
Win: Remove adding default file filter(*.*) in a save dialog.
2015-10-27 13:10:34 +08:00
Omri Litov
edbebf84b9
Added browser-window event 'message'
2015-10-27 03:12:01 +02:00
Gohy Leandre
b29a8c94b9
Add extra headers option to webContents.loadUrl
2015-10-26 22:18:16 +01:00
Cheng Zhao
f399f50e9e
Fix calling showItemInFolder in renderer
...
The remote method always assumes the existence of the remote object but
doesn't keep a reference to it, so if we only keep the reference of a
remote method we will get into troubles once the remote object is
garbage collected.
We should probably fix this in remote module, but since most things are
already working quite good, I'm using the work-around for now.
Fix #3139 .
2015-10-26 16:48:27 +08:00
Robo
70fe169b0f
nativemate: use maybe version of v8::Function::Call to avoid exceptions
2015-10-26 10:59:40 +05:30
Cheng Zhao
30ec7fdeed
Bump v0.34.1
2015-10-23 20:32:02 +08:00
Cheng Zhao
fae2c7bc7a
win: Make auto-updater really work
...
Apparently that PR was never tested.
2015-10-23 19:41:54 +08:00
Cheng Zhao
aeafc46ded
Keep compatibility with old API style
2015-10-23 15:50:55 +08:00
Cheng Zhao
f89d28a63e
Simplify the auto-updater implementations
...
We used to use Sparkle on OS X, and the design was reserved to be
extended to all platforms, which are all wrong now.
2015-10-23 15:40:56 +08:00
Cheng Zhao
d74ef5c078
Move implementation of auto-updater on OS X to another file
2015-10-23 15:13:24 +08:00
Cheng Zhao
85c84a0eb0
Emit Date object in C++ directly
2015-10-23 14:58:19 +08:00
Cheng Zhao
a3f62da615
Fix passing Date object in remote
...
Close #2017 .
2015-10-23 14:51:41 +08:00
Cheng Zhao
95fe4beda8
Pass real Error object in error event
2015-10-23 14:37:35 +08:00
Cheng Zhao
d5c964c68c
Fix passing Error object in remote
...
Closes #3089
2015-10-23 14:37:28 +08:00
Cheng Zhao
07adbc8e8a
Merge pull request #1984 from patrickdet/windows-auto-updater
...
Windows Auto Updater
2015-10-23 13:54:29 +08:00
Cheng Zhao
e36d455d51
Add setBackgroundColor method
2015-10-23 11:35:33 +08:00
Cheng Zhao
4a6134f3f7
win: Set native window's background color
2015-10-23 11:17:14 +08:00
Cheng Zhao
6182e4ce81
Merge pull request #3179 from deepak1556/session_api_patch
...
session: allow setproxy to use external pac script
2015-10-23 10:36:37 +08:00
Cheng Zhao
79d4d52172
Merge pull request #3178 from deepak1556/node_debugger_patch
...
debugger: expose v8debug
2015-10-23 10:36:06 +08:00
Robo
e9a5d05b27
session: allow setproxy to use external pac script
2015-10-22 23:03:47 +05:30
Cheng Zhao
6bfe06ec4e
Pass original argv in callback
2015-10-22 19:02:21 +08:00
Robo
7b5a1b06ba
debugger: expose v8debug
2015-10-22 16:20:48 +05:30
Cheng Zhao
afc1fff792
Remove the need for ProcessSingletonStartupLock
2015-10-22 17:12:09 +08:00
Cheng Zhao
70e74d05e0
Revert "app.makeSingleInstance is not available on OS X"
...
This reverts commit bcb78ebc00
.
2015-10-22 17:03:18 +08:00
Cheng Zhao
f9d797d1ea
win: Fix compiler warning
2015-10-22 16:55:54 +08:00
Cheng Zhao
e14fd62f46
Correctly handle notification callback when shutting down
...
When returning false in the notification callback the ProcessSingleton
will assume current process is quitting, we should met its expectation.
2015-10-22 16:24:35 +08:00
Cheng Zhao
ca876e424b
Fix crash when calling app.quit() before app is ready
2015-10-22 16:06:37 +08:00
Cheng Zhao
05c6300329
Don't discard tasks in BridgeTaskRunner
2015-10-22 15:54:27 +08:00
Cheng Zhao
bcb78ebc00
app.makeSingleInstance is not available on OS X
2015-10-22 15:02:32 +08:00
Cheng Zhao
310954713f
Simplify the usage of singleton
2015-10-22 14:59:12 +08:00
Cheng Zhao
acb2c099f6
Make sure current task runner is available
...
When calling makeSingleInstance we have to ensure current task runnder
is available, otherwise crash may happen.
2015-10-22 14:56:57 +08:00
Cheng Zhao
04d3eed60e
Merge pull request #3145 from atom/single-instance
...
Implement Single-Instance for Windows / Linux
2015-10-22 14:18:31 +08:00
Robo
9411508d3e
browser: option to set window background color
2015-10-22 09:54:29 +05:30
Paul Betts
de66888051
Remove atom_process_singleton, just use the Chrome classes directly
2015-10-21 13:38:39 -07:00
Paul Betts
d020a7dc86
cpplinting
2015-10-21 13:17:56 -07:00
Paul Betts
938d68eb36
Move all the browser.cc code over to atom_api_app.cc
2015-10-21 13:04:50 -07:00
Paul Betts
658a9872fb
Only cleanup if we are the main process
2015-10-21 12:29:21 -07:00
Paul Betts
a160891a27
If a user calls makeSingleInstance more than once, just ignore it
2015-10-21 12:29:00 -07:00
Paul Betts
38d6ff79c8
Need to free this early or get a SIGSEGV on Linux
2015-10-21 11:06:42 -07:00
Cheng Zhao
444f461269
Fix memory corruption when cleaning timer
2015-10-21 20:46:16 +08:00
Cheng Zhao
2d410ede48
Initialize things in the same sequence with main process
2015-10-21 16:24:54 +08:00
Cheng Zhao
d092c6acc9
osx: Implement draggable region with mouseDownCanMoveWindow
...
Previously we implemented draggable region by tracking mouse position,
it is buggy and causing some problems. But it is interesting that until
this didn't cause troubles until recently.
2015-10-21 08:54:46 +08:00
Paul Betts
e5094fff3e
Since setting up process_singleton is now conditional, its cleanup / unlock must be too
2015-10-20 17:27:28 -07:00
Paul Betts
4a7a09aae1
Infinite Linting
2015-10-20 15:00:10 -07:00
Paul Betts
f759471e01
Update to use Chromium sources
2015-10-20 14:36:01 -07:00
Paul Betts
b6f1729acd
Move initialization of Single Instance into MakeSingleInstance call
2015-10-20 13:38:57 -07:00
Paul Betts
5d4c29a1e3
Ditch double-callback, just use mate directly
2015-10-20 13:27:34 -07:00
Paul Betts
a2eedcc027
Wire up the final callback to JS
2015-10-20 13:17:26 -07:00
Paul Betts
63417bc975
I am not good at C++ at all
2015-10-20 13:17:25 -07:00
Paul Betts
4a4b829cfc
Fix callback handle usage
2015-10-20 13:17:25 -07:00
Paul Betts
50fab0733b
At Browser ctor time, DIR_USER_DATA is unset, wait
2015-10-20 13:16:49 -07:00
Paul Betts
b02f89e63b
Typo
2015-10-20 13:16:49 -07:00
Paul Betts
cdd51fa96d
Wire everything up
2015-10-20 13:16:48 -07:00
Paul Betts
c38f2fcf75
Add a native mate converter for command lines
2015-10-20 13:15:12 -07:00
Paul Betts
7491ae4000
Set up Browser to create the process singleton
2015-10-20 13:15:12 -07:00
Paul Betts
4d5495a0a0
Bring in chrome_process_singleton but nuke the active dialog bits
2015-10-20 13:15:11 -07:00
Paul Betts
717aba9631
Create a dummy method in app that we'll twerk
2015-10-20 13:15:11 -07:00
Paul Betts
8288a22458
Fix build against old OneShotTimer
2015-10-20 13:14:08 -07:00
Paul Betts
88dd1480cc
Get POSIX mostly compiling
2015-10-20 13:14:08 -07:00
Paul Betts
c46579b1ac
Remove a bunch of stuff we don't need in process_singleton_win
2015-10-20 13:14:07 -07:00
Paul Betts
1b3363c811
Get process finder working
2015-10-20 13:14:07 -07:00
Paul Betts
daa65a138b
Come Correct with headers
2015-10-20 13:14:06 -07:00
Paul Betts
d3b23a2032
Renames to avoid confusion, add file
2015-10-20 13:14:06 -07:00
Paul Betts
05b22b9372
Import process_finder verbatim
2015-10-20 13:14:05 -07:00
Paul Betts
ff2d9759d5
Start to remove / rearrange some header files
2015-10-20 13:14:05 -07:00
Paul Betts
27fa5d880a
Copy some relevant files over from Chromium
2015-10-20 13:14:04 -07:00
Patrick Detlefsen
db3bc28937
PR feedback adressed
2015-10-20 19:25:03 +02:00
Cheng Zhao
a7a399dcd8
Code cleanup
2015-10-20 13:52:39 +08:00
Cheng Zhao
370cb5b5e1
Merge pull request #3120 from atom/ntlm-part-two
...
Optionally allow NTLM authentication for all domains
2015-10-20 13:48:12 +08:00
Cheng Zhao
fb8ca33d5d
Add ELECTRON_ENABLE_STACK_DUMPING env
...
It enables in-process stack dumping, which is convenient for debugging.
2015-10-20 13:02:48 +08:00
Cheng Zhao
2c4a24d26b
Add ELECTRON_ENABLE_LOGGING env
...
It is the same with --enable-logging.
2015-10-20 13:00:28 +08:00
Cheng Zhao
bb8bb3dbea
Merge pull request #3147 from deepak1556/cipher_suite_disable_patch
...
browser: flag to disable specified cipher suites
2015-10-20 10:29:49 +08:00
Robo
9f8479e9d8
browser: flag to diable specified cipher suites
2015-10-20 02:51:56 +05:30
Paul Betts
e3535d664b
Fixed linter issues but now the code looks awful
2015-10-19 13:12:17 -07:00
Paul Betts
b3c7e2bf33
Plumb the method back
2015-10-19 13:07:14 -07:00
Paul Betts
489090fcf8
Set up our browser context to use new delegate-based API
2015-10-19 13:03:20 -07:00
Cheng Zhao
de3e16ce60
Merge pull request #3129 from brandoncash/fix-tray-notify-typo
...
Fix: tray NotfiyDropFiles typo
2015-10-19 19:11:26 +08:00
Cheng Zhao
72e0da069c
Merge pull request #3132 from princejwesley/issue-readFileSync
...
Fix: honor fs.readFileSync contract for empty packed asar file
2015-10-19 16:59:47 +08:00
Cheng Zhao
0d9e0a38c0
Merge pull request #3128 from atom/fix-save-page-position
...
Fix: 'savePage API' saves external resources in a wrong directory.
2015-10-19 16:40:45 +08:00
Prince J Wesley
810af2f95d
🐛 Honor fs.readFileSync contract for empty packed asar file
2015-10-19 08:43:50 +05:30
Brandon Cash
60b14d03e9
Fix: tray NotfiyDropFiles typo
2015-10-18 00:32:13 -05:00
Haojian Wu
49d25d0069
Fix: savePage API saves external resources in a wrong directory.
2015-10-18 11:28:05 +08:00
Paul Betts
a3fc25110e
Linter fixes
2015-10-16 16:55:28 -07:00
Paul Betts
5ae6bd2ef4
Wire it up
2015-10-16 16:46:05 -07:00
Paul Betts
7ac643d5f8
Create a new method on App to override URL Security Manager's decisions wrt NTLM
2015-10-16 16:45:54 -07:00
Cheng Zhao
d9fdfb711f
Clean up CallbackRegistry
...
There were some ancient code there.
2015-10-16 20:25:30 +08:00