mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
28516 commits 1 branch 185 tags 5.5 GiB
Commit graph

28516 commits

This branch
This branch
All branches
Author SHA1 Message Date
Pedro Pontes
45d4f25099
chore: cherry-pick 1 changes from 3-M130 (#44645) 
chore: [32-x-y] cherry-pick 1 changes from 3-M130

* e699ac35ac6c from chromium
 2024-11-13 17:35:21 -08:00
trop[bot]
85289c8218
fix: WCO buttons hidden on Linux in fullscreen (#44642) 
Closes https://github.com/electron/electron/issues/44569.

Fixes an issue where the WCO buttons were hidden on Linux in  fullscreen mode
but not on Windows or macOS. The Windows behavior is the expected one, so this
commit makes the Linux behavior consistent.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-11-13 15:59:29 -05:00
trop[bot]
7dd1fc92d4
test: exercise fuller globalShortcut matrix (#44626) 
test: test fuller globalShortcut matrix

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-11-13 19:36:10 +01:00
trop[bot]
f06f6d565e
fix: segfault when moving WebContentsView between BrowserWindows (#44615) 
* fix: segfault when moving WebContentsView between BrowserWindows

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* chore: actually enable fix

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* fixup segfault when moving WebContentsView between BrowserWindows

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-11-12 11:42:42 -05:00
trop[bot]
bcd7ac5481
chore: remove executable flag from docs/api/app.md file permissions (#44577) 
chore: set docs/api/app.md file permissions to 644

md files should not be executable

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-05 12:01:40 -05:00
Robo
b0f22f7ed4
chore: backport editcontext ime input alignment fixes (#44572) 
Refs https://issues.chromium.org/issues/351029417
 2024-11-05 10:22:46 -06:00
trop[bot]
2f524dfb1d
fix: remove use of banned std::to_string() (#44561) 
Use base::NumberToString() instead

Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#std_sto_i_l_ul_ll_ull_f_d_ld_to_string_banned

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-04 20:31:08 -06:00
trop[bot]
555c368052
docs: capitalize POSIX and Windows correctly (#44557) 
* docs: capitalize POSIX correctly

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* docs: capitalize Windows correctly

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-04 17:02:14 -05:00
John Kleinschmidt
aa02f3db47
build: add new status to verify if all the required gha jobs have run (#44555) 
build: add new status to verify if all the required gha jobs have run (#44432)

(cherry picked from commit 1c1eb3e19dad1c60dc8926542ce9bbb3a71735f9)
 2024-11-04 16:41:40 -05:00
trop[bot]
6a9f44f867
build: remove unused lint package (#44532) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
 2024-11-04 09:06:02 -05:00
Robo
fb6faaab69
chore: add process memory limit details in parition_alloc oom handler (#44512) 
chore: backport b5b8e05a8 from chromium
 2024-11-04 20:49:06 +09:00
trop[bot]
6d94e1a436
docs: fix apostrophe typo "Electrons" -> "Electron's" (#44538) 
s/Electrons/Electron's/

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-03 09:33:24 -06:00
trop[bot]
2e33636033
refactor: remove unused C string ToV8() gin converter (#44523) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-02 13:56:55 -05:00
trop[bot]
faa1910ffe
perf: use v8::String::NewFromUtf8Literal in ToV8() gin converter (#44518) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-01 16:56:09 -05:00
trop[bot]
c1069f778e
docs: add custom titlebar example (#44508) 
* docs: add custom titlebar example

* docs: add links and other small edits

* docs: add panel window docs

* docs: remove panel example

* docs: specify expected emphasis style

* docs: responding to feedback

* docs: fix section names in links

* docs: rework baseWindow note

* docs: making window customization its own section

* responding to feedback

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Anny Yang <anny@electronjs.org>
 2024-11-01 14:02:42 -04:00
trop[bot]
201629f206
build: handle out of disk space on source cache (#44493) 
* build: handle out of disk space on source cache

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* build: add cron job to free up source cache disk space

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-31 16:45:08 -05:00
trop[bot]
85272b00a4
fix: EventSource undefined in Renderer/Worker (#44497) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-31 16:44:00 -05:00
Pedro Pontes
6356cdf49f
chore: backport 1 change from 2-M130 (#44484) 2024-10-31 15:24:23 -04:00
Pedro Pontes
e492fba70d
chore: cherry-pick 3 changes from 1-M130 (#44482) 
chore: [32-x-y] cherry-pick 3 changes from 1-M130

* 153d4e84e5d1 from v8
* d9893f4856af from v8
* 8c4edae5e34d from chromium
 2024-10-31 14:46:18 -04:00
trop[bot]
310319b00a
perf: remove isolate scope from DidProcessTask() (#44472) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-10-31 11:30:10 +01:00
trop[bot]
9b15acb514
docs: fix win.setContentView() arg type (#44479) 
fix: setContentView type

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-10-30 16:25:57 -04:00
trop[bot]
318a8dcd22
docs: fix win.getContentView() return type (#44465) 
docs: fix win.getContentView() return type

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-29 16:59:55 -04:00
trop[bot]
b4a5684493
build: fix python util verbose mode logic (#44452) 
build: fix verbose mode logic

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-29 21:41:22 +01:00
Charles Kerr
1cbd5f451a
fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (32-x-y) (#44440) 
* fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211)

* chore: rename v8_value_serializer.cc,h to v8_util.cc,h

* feat: add electron::util::as_byte_span(v8::Local<v8::ArrayBuffer>)

* fix: -Wunsafe-buffer-usage warnings in ChunkedDataPipeReadableStream::ReadInternal()

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5619253

* refactor: restore node buffer span util

* refactor: remove redundant span wrapper

* empty commit to force the Valid Backport check to rerun 🤷
 2024-10-29 14:51:59 -05:00
trop[bot]
bc90b60005
build: improve gen-libc++-filenames output (#44442) 
build: improve gen-libc++-filenames output

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-29 14:16:07 +01:00
trop[bot]
91fb7ff6e3
fix: keep gdk_pixbuf a dynamic dependency (#44437) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2024-10-28 21:46:47 -05:00
trop[bot]
e781fe50df
fix: crash on netlog connection error (#44419) 
* fix: crash on netlog connection error

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

* refactor: remove default PromiseBase constructor

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

* Revert "refactor: remove default PromiseBase constructor"

This reverts commit 9292324a0d5f9e63ba8f73f63dfff1d48eb2f38f.

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

* remove dcheck

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
 2024-10-28 12:35:32 -04:00
trop[bot]
1a2015c87d
perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals (#44427) 
* perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals

the string length is known at compile time and no need to call ToLocalChecked()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* perf: string length is known when calling NewFromUtf8(), so use it

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* perf: remove unnecessary calls to c_str()

these just force the code being called to have to recalculate the string length

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-10-28 10:51:41 -05:00
trop[bot]
2138b5a3e0
test: deflake flaky tests on linux (#44403) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-25 14:32:26 -04:00
John Kleinschmidt
477f06a987
build: update linux container (#44397) 
build: update linux container (#44392)

(cherry picked from commit a0f51d816e7b66e1f60943c672b53bbede94a34a)
 2024-10-24 20:46:55 -04:00
John Kleinschmidt
c61bb1654e
test: fixup broken tests in 32-x-y (#44389) 
* test: fixup broken tests in 32-x-y

* test: fixup additional failing test
 2024-10-24 16:55:23 -04:00
trop[bot]
e9988c2fc4
test: fixup flaky tests (#44380) 
* test: fixup flaky test

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* test: disable flaky protocol speed test on macOS

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* test: fixup flaky test in api-browser-window-spec.ts

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* test: update waitUntil to handle async functions

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-24 15:21:55 +02:00
trop[bot]
1a9b93ca96
docs: clarify utilityProcess child.pid value (#44365) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-22 19:22:08 +02:00
Pedro Pontes
d213161010
chore: backport 2 changes from 0-M130 (#44357) 2024-10-22 11:53:27 +02:00
trop[bot]
89ef924a99
fix: software compositing infinite loop (#44351) 
* fix: software compositing infinite loop

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

Co-authored-by: Sam Maddock <smaddock@slack-corp.com>

* chore: update patches

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
 2024-10-21 20:40:59 -04:00
trop[bot]
9a86172607
build: fixup reclient use for prod builds (#44344) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-21 17:16:01 -04:00
trop[bot]
15486ec73d
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44325) 
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44078)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <31829097+cptpcrd@users.noreply.github.com>
 2024-10-18 16:19:43 -04:00
trop[bot]
7cfbdfaf34
fix: Linux crash after webContents.print() with no parent window (#44282) 
fix: Linux crash after print with no parent window

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-18 11:25:31 -04:00
Pedro Pontes
aaeedc768c
chore: backport 2 changes from 2-M127 to 0-M129 (#44312) 2024-10-18 11:21:50 -04:00
Robo
d5d936d078
fix: trace-startup crashing child process on macOS (32-x-y) (#44292) 
* fix: trace-startup crashing child process on macOS (32-x-y)

* chore: disable test on linux arm

* chore: also disable on linux arm64
 2024-10-18 11:16:53 -04:00
John Kleinschmidt
519da8e634
chore: fixup reclient read only access on forks (#44306) 
* chore: fixup reclient read only access on forks (#44280)

* Trigger CI
 2024-10-17 22:21:23 -04:00
trop[bot]
2d9af751fa
build: remove dead code in prepare release script (#44287) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
 2024-10-17 10:34:45 -04:00
trop[bot]
b39ba84e87
fix: ensure utilityProcess only emits one 'exit' event (#44268) 
fix: ensure utilityProcess only emits one exit

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-16 17:11:25 -04:00
trop[bot]
db2050e9d2
build: update devcontainer sha (#44244) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-15 10:19:55 -04:00
Keeley Hammond
f3de5b9092
chore: cherry-pick 3 changes from 3-M129 (#44231) 
* chore: [32-x-y] cherry-pick 3 changes from 3-M129

* 9542895cdd3d from v8
* 259a5f8fed67 from v8
* 81155a8f3b20 from v8

* chore: update patches
 2024-10-14 17:35:26 -05:00
trop[bot]
2e63ae0cfb
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (#44207) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-10-11 20:15:03 -05:00
trop[bot]
7182bc2359
fix: clang variable configuration in generated node headers (#44201) 
* fix: clang variable configuration in generated node headers

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* chore: restore value in common.gypi

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* chore: update patches

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-11 15:25:34 -04:00
trop[bot]
868a713208
ci: don't call datadog test logging on forks (#44195) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-11 09:41:24 -04:00
trop[bot]
0e9722dc50
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() (#44167) 
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-10-09 20:38:19 -05:00
trop[bot]
ca8479d859
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() (#44170) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-10-09 17:07:20 -05:00