Commit graph

28 commits

Author SHA1 Message Date
Cheng Zhao
5639faf069 Also fix the Windows and Linux side of async openExternal 2016-11-17 12:13:07 +09:00
Gabriel Handford
5b260dbee3 Fix win/linux compile (again) 2016-11-17 10:33:24 +09:00
Gabriel Handford
f0ca9dff81 Fix win/linux compile 2016-11-17 10:33:24 +09:00
Gabriel Handford
99a5258999 Callback uses (platform specific) error, with message 2016-11-17 10:33:24 +09:00
Gabriel Handford
08a9af3a85 Linting 2016-11-17 10:33:24 +09:00
Gabriel Handford (linux)
d186fd78e3 Fix header 2016-11-17 10:33:23 +09:00
Gabriel Handford
6524a33ffc Include callback header 2016-11-17 10:33:23 +09:00
Gabriel Handford
cfd2a029ad Fix linting 2016-11-17 10:33:23 +09:00
Gabriel Handford
9ca684d87f Remove redundant method 2016-11-17 10:33:23 +09:00
Gabriel Handford
128feb17cb Fix method call 2016-11-17 10:33:23 +09:00
Gabriel Handford
b266533dfc Shell openExternal can take optional callback (macOS) 2016-11-17 10:33:23 +09:00
Cheng Zhao
20d5a50ac9 Merge pull request #7178 from aichingm/master
🐧 Add support for different trash implementations
2016-09-16 17:43:09 +09:00
Kevin Sawicki
55eab8e385 Return boolean from shell.openItem 2016-09-12 14:29:06 -07:00
Kevin Sawicki
72558654ef Return boolean from shell.showItemInFolder 2016-09-12 14:22:29 -07:00
Mario Aichinger
893fc2cd53 🐧 Add support for different trash implementations
Make the trash implemantation in MoveItemToTrash selectable via an environment variable
2016-09-12 10:41:23 +02:00
Pete Burgers
00ff209fe7 Ensure process is cleaned up, to avoid leaks 2016-04-08 08:35:35 +01:00
Pete Burgers
46365f4076 wait_for_exit param should be const 2016-04-08 08:32:45 +01:00
Pete Burgers
79ba8feaf8 Don't wait for xdg-open to exit when OpenExternal is called (Linux)
Some browsers (eg. Firefox) may not return until the browser window is
closed. This causes the Electron application to lock up while the browser
window is open.

See https://github.com/atom/atom/issues/6320
2016-04-07 17:04:15 +01:00
Kevin Sawicki
f5bed87199 without_activation -> activate 2016-02-17 08:56:58 -08:00
Ben Gotow
d8679b3899 Allow openExternal to open URLs in the background #3224 2016-02-17 08:56:58 -08:00
msullivan
b4674923c9 return bool on shell.openExternal 2015-06-10 11:06:22 -04:00
Cheng Zhao
b987656f1f It is not safe to get exit code once the child is reaped
Continues #1311.
2015-03-29 20:32:23 +08:00
Robo
bedea89dcf shell: return status for moveItemToTrash on all platforms 2015-03-29 00:47:50 +05:30
Cheng Zhao
750db6aed8 base/file_util.h has been moved to base/files/file_util.h 2015-01-27 13:18:30 -08:00
Kevin Sawicki
b6b6fc3bfd Remove All Rights Reserved after GitHub copyright
Closes #762
2014-10-31 11:17:05 -07:00
Cheng Zhao
fd806f81ce linux: Don't set PR_SET_NO_NEW_PRIVS when creating process, fixes #623. 2014-09-05 21:04:27 +08:00
Cheng Zhao
f176b2c58f Switch to use MIT license. 2014-05-04 20:29:08 +08:00
Cheng Zhao
516d46444d Move all sources under atom/. 2014-03-16 08:30:26 +08:00
Renamed from common/platform_util_linux.cc (Browse further)