Cheng Zhao
0937144849
Merge pull request #4111 from evgenyzinoviev/movable
...
Added an option to prevent a window from being moved on OS X
2016-01-15 23:24:22 +08:00
Cheng Zhao
9ccc7ee30d
Small ajustments on lifetime of webContents
2016-01-15 16:36:35 +08:00
Cheng Zhao
c10c419f1d
No need to call sender.callbacks.remove
...
The IDWeakMap automatically removes the key when object is garbage
collected.
2016-01-15 16:36:35 +08:00
Cheng Zhao
3875b30fcf
Merge pull request #4109 from atom/const
...
[WIP] Use `const` for requires
2016-01-15 16:32:07 +08:00
Cheng Zhao
39225ac5ec
Bump v0.36.4
2016-01-15 14:27:19 +08:00
evgenyzinoviev
2598b00b41
Animate window resizing on OS X
2016-01-15 05:59:58 +01:00
evgenyzinoviev
cda88db77c
Added option to prevent a window from being moved on OS X
2016-01-15 03:58:57 +01:00
Jessica Lord
003de0debe
Clean up variable declarations
2016-01-14 18:07:29 -08:00
Jessica Lord
ae2893ceaa
Inline var
2016-01-14 15:44:33 -08:00
Jessica Lord
1779701445
Use const
2016-01-14 14:40:12 -08:00
Jessica Lord
3a0fb42737
Use const
2016-01-14 14:33:45 -08:00
Jessica Lord
9103253f62
Use const
2016-01-14 14:26:10 -08:00
Kevin Sawicki
030d2a843c
Remove extra newlines around comments
2016-01-14 11:10:12 -08:00
Kevin Sawicki
990dc30e8d
Use // for multi-line comments
2016-01-14 10:44:21 -08:00
Kevin Sawicki
f4af744519
Use // for single line comments
2016-01-14 10:35:29 -08:00
Cheng Zhao
26350f4ccb
GetHttpCacheInIO => DoCacheActionInIO
2016-01-14 20:48:14 +08:00
Robo
10e4698baa
session: api to get current cache size
2016-01-14 17:15:45 +05:30
Cheng Zhao
489539d62e
Merge pull request #4071 from deepak1556/session_flush_data_patch
...
session: api to flush DOMStorage data
2016-01-13 16:18:37 +08:00
Cheng Zhao
44b8343585
Fix crash when closing page with webview
2016-01-13 14:47:39 +08:00
Cheng Zhao
af02739c4e
Change webview's zoom level on JavaScript side
2016-01-13 12:50:02 +08:00
Cheng Zhao
350c572a8c
Handle default parameter of executeJavaScript in C++
2016-01-13 12:17:56 +08:00
Cheng Zhao
55dfddba77
Handle executeJavaScript in JavaScript
2016-01-13 12:11:46 +08:00
Cheng Zhao
5b7d1a9890
Add insertText to WebContents
2016-01-13 11:55:49 +08:00
Robo
8433d94cac
session: api to flush DOMStorage data
2016-01-13 08:56:00 +05:30
Kevin Sawicki
ab73f4c94a
Copy JS files to tempdir before packing asar
2016-01-12 16:24:06 -08:00
Kevin Sawicki
1f9691ae13
Convert all source files to JavaScript
2016-01-12 16:24:06 -08:00
Kevin Sawicki
403870a27e
Migrate to block comments
2016-01-12 16:22:34 -08:00
Cheng Zhao
eb63e6b9a7
Destroy the native class when webContents is destroyed
2016-01-12 21:10:24 +08:00
Cheng Zhao
c7a89b6e29
Merge pull request #4058 from kyku/master
...
Pass --touch-devices to chromium contents under X11
2016-01-11 22:57:00 +08:00
Cheng Zhao
9e82334b67
Merge pull request #4057 from princejwesley/browser-window
...
Return null for no focused window when calling BrowserWindow.getFocusedWindow
2016-01-11 22:53:38 +08:00
Cheng Zhao
192fa4c86b
Cleanup docs and code of setProxy
2016-01-11 22:45:34 +08:00
Cheng Zhao
34c9279fc5
Merge pull request #4046 from deepak1556/session_proxy_patch
...
session: allow user to isolate pac script and proxy bypass rules
2016-01-11 21:49:15 +08:00
Cheng Zhao
26bd97d6cf
Fix style issues of #4029
2016-01-11 21:12:07 +08:00
Cheng Zhao
edcd34d4ce
Merge pull request #4029 from leethomas/show-message-box-default-button
...
Show message box default button
2016-01-11 20:58:03 +08:00
Krzysztof
440c588a33
Pass --touch-devices to chromium contents under X11
2016-01-11 12:23:53 +01:00
Cheng Zhao
91ca84d106
Merge pull request #4050 from etiktin/cosmetic
...
Remove unneeded extra semicolons (;; -> ;)
2016-01-11 15:41:06 +08:00
Prince J Wesley
018ae5189b
Return null for no focused window when calling BrowserWindow.getFocusedWindow()
2016-01-11 12:58:44 +05:30
Robo
8557cd223c
maintain api compatibility
2016-01-11 12:24:01 +05:30
Cheng Zhao
1944472c2f
docs: Make win.getNativeWindowHandle more clear
2016-01-11 13:43:24 +08:00
Cheng Zhao
54e1d7b3bf
Merge pull request #4023 from omrilitov/master
...
Added getNativeWindowHandle method
2016-01-11 13:32:29 +08:00
leethomas
fee301e768
follow style guidelines
2016-01-10 19:15:40 -08:00
Eran Tiktin
29939dc0b7
Remove unneeded extra semicolons (;; -> ;)
2016-01-11 02:11:40 +02:00
leethomas
803b06b7de
🏁 support defaultId for dialog boxes on Windows
2016-01-10 15:55:26 -08:00
leethomas
ae5c6add11
rename all references to default_button_index -> default_id to keep consistent with cancel_id
2016-01-10 15:33:27 -08:00
Robo
be50ca2653
session: allow user to isolate pac script and proxy bypass rules
2016-01-11 03:55:56 +05:30
leethomas
dfce803045
🏁 update windows message_box function signatures to accept default_button_index....and do nothing with it
2016-01-08 08:23:06 -08:00
leethomas
22c455175a
🐧 add default button index for linux/gtk
2016-01-08 08:22:10 -08:00
leethomas
f1edd5f26f
🍎 add default button index for osx
2016-01-08 08:21:54 -08:00
Cheng Zhao
df27cda36c
Bump v0.36.3
2016-01-08 13:40:47 +08:00
Cheng Zhao
ec4c5e58ff
Initialize resource bundle on browser process separately
2016-01-08 12:06:06 +08:00
Cheng Zhao
5f6a8a7c24
Merge pull request #4009 from atom/remove-getobject-handler
...
Remove custom WM_GETOBJECT handler
2016-01-08 09:55:24 +08:00
Omri Litov
943e46f3bd
Fix linux and mac build errors
2016-01-08 00:27:53 +02:00
Omri Litov
3f0c007578
Added getNativeWindowHandle
2016-01-07 22:38:35 +02:00
Cheng Zhao
3a32dc5da7
Fix "name" of Error object not serialized
...
Close #3364 .
2016-01-07 16:35:05 +08:00
Cheng Zhao
10f663d017
Fix hiding fullscreen button on EL Capitan
2016-01-07 15:46:40 +08:00
Cheng Zhao
3f2b26ddb7
Add blinkFeatures option
2016-01-07 14:10:18 +08:00
Cheng Zhao
bd20b3f32a
Rely on content switches for implementing experimental features
2016-01-07 12:49:00 +08:00
Cheng Zhao
16d23bbda5
Remove pageVisibility option
...
The original purpose of this option is not working anymore, also adds
docs on the current way to disable process backgrounding.
2016-01-07 12:28:20 +08:00
Cheng Zhao
c6e03f8390
Remove overlayScrollbars and sharedWorker options
...
They are already enabled by default.
2016-01-07 12:17:19 +08:00
Paul Betts
705001a50e
Remove custom WM_GETOBJECT
...
As of Chromium 47 this seems to be handled automatically, nvda still reports
elements and the typing lag issue described in #4001 is fixed
2016-01-06 10:37:12 -08:00
Cheng Zhao
3ca5b0ce23
win: Don't change transparent window's style
...
Close #1952 .
2016-01-06 23:02:33 +08:00
Cheng Zhao
89fccb7eb2
Fix crash when request failed
2016-01-06 21:07:07 +08:00
leethomas
59eda67ba4
🍎 🐛 make displaying alternate tray image depend on mouse down event instead of highlight state
2016-01-05 09:49:27 -08:00
Cheng Zhao
2b6ac966c0
Do not write our own filter code
...
The Win32 API has done everything for us, there is no need to do this
oursevles.
2016-01-05 13:45:34 +08:00
Cheng Zhao
698700716b
Show menu by clicking the menu button
2016-01-05 12:05:27 +08:00
Cheng Zhao
43bfce26a7
Do not behave like bookmarkbar menu
2016-01-05 11:57:58 +08:00
Cheng Zhao
0df03a23a3
Pass origin in capturePage
2016-01-04 20:06:36 +08:00
Cheng Zhao
7a1717156e
Revert "browser: dont lose coordinates in capturepage src rect"
...
This reverts commit 3c5e5053e3
2016-01-04 19:37:25 +08:00
Cheng Zhao
4844e68ba1
Rename did-navigate-to-different-page to did-navigate
2016-01-04 12:09:11 +08:00
Cheng Zhao
941232a76b
Merge pull request #3975 from leethomas/add-webview-navigation-events
...
Add webview navigation events
2016-01-04 11:24:27 +08:00
Cheng Zhao
14db4a1946
Add isDevToolsFocused to webview
2016-01-04 10:46:30 +08:00
leethomas
911e60b507
add did-navigate-in-page event to webview & webcontents (triggers on hash/ref changes, anchor links...), pass url into events
2016-01-01 17:13:39 -08:00
leethomas
9f6319dd71
add will-navigate, did-navigate-to-different-page events to webview
2016-01-01 13:36:35 -08:00
leethomas
54c8c3e3fc
📝 update webview docs to include devtools-* events
2016-01-01 04:49:34 -08:00
leethomas
96d68b9285
🐛 add isDevToolsFocused to WebContents to fix #3928 , add devtools-[focused|open|close] events to WebView to fix #3783 .
2015-12-31 22:21:54 -08:00
Cheng Zhao
8aced2c31e
Add comment on why checking empty set
2015-12-31 18:58:16 +08:00
Cheng Zhao
b308cd6f96
Merge pull request #3967 from leethomas/fix-osx-crash-when-extensions-empty
...
🍎 fix #3864 where saving a file causes a crash if file extensio…
2015-12-31 18:51:55 +08:00
Cheng Zhao
be2f900d93
Merge pull request #3968 from leethomas/fix-window-submenu-crashes
...
🍎 only add sub menus to Window when they actually have menu ite…
2015-12-31 18:51:45 +08:00
Cheng Zhao
af5e76f6ae
Merge pull request #3959 from deepak1556/remote_object_patch
...
remote: support arguments of type Date
2015-12-31 18:46:22 +08:00
leethomas
eac2f6fec3
🍎 only add sub menus to Window when they actually have menu items. fixes #3873
2015-12-30 19:38:14 -08:00
leethomas
ba26a4b4e6
🍎 fix #3864 where saving a file causes a crash if file extension array is empty
2015-12-30 13:26:38 -08:00
Cheng Zhao
cb5d79e0df
Merge pull request #3957 from atom/widevine
...
Merge #3830
2015-12-30 12:46:19 +08:00
Nishanth Shanmugham
20d03b10d9
osx: Implement clear recent documents
...
Fixes #3932
2015-12-29 18:36:16 -06:00
Robo
72374b6e31
remote: support arguments of type Date
2015-12-30 01:41:31 +05:30
Cheng Zhao
c76db0ba1d
Fix coding styles
2015-12-29 18:59:27 +08:00
Nishanth Shanmugham
2bbf86c524
tray: Support file-drop from OS X Dock
...
A long-standing Apple bug does not call `prepareForDragOperation:sender`
for file drag-and-drop operations from the Dock. So we manually
call our custom `handleDrop:sender` for all drag-and-drop cases (that
is, from the Dock and from Finder).
References to the bug in question:
- http://stackoverflow.com/q/9534543/3309046
- http://openradar.appspot.com/radar?id=1745403
However, we still need to return YES from `prepareForDragOperation:sender`,
otherwise the "drag failed" animation occurs. For the same reason, we also
return YES from `performDragOperation:sender`.
2015-12-29 03:27:59 -06:00
Cyrille Lebeaupin
9d878ad6b2
Add widevine third party
...
Add 2 new command options to use widevine:
- widevine-cdm-path: Path to widevine plugin
- widevine-cdm-version: Version of the widevine plugin
2015-12-29 14:50:59 +08:00
Cheng Zhao
9ffe502fb1
Bump v0.36.2
2015-12-25 13:45:07 +08:00
Cheng Zhao
e96f89133c
Reset whole headers when requestHeaders is set
2015-12-24 16:59:13 +08:00
Cheng Zhao
d3d8ab7c66
linux: Fix pressing Alt not toggling window menu bar
2015-12-24 11:43:14 +08:00
Cheng Zhao
a6074f89a3
Merge pull request #3900 from bbondy/theme-color
...
Theme color
2015-12-23 16:09:57 +08:00
Cheng Zhao
e90435e236
Remove visual artifacts of hidden-inset window
2015-12-23 12:38:11 +08:00
Brian R. Bondy
29b00ae0d6
Add tests for did-change-theme-color event
2015-12-22 23:05:03 -05:00
Cheng Zhao
79b507bda6
Merge pull request #3890 from jaanus/hidden-inset-fullscreen-fix
...
Fixes #2810 : correct look of hidden-inset windows in full screen.
2015-12-23 11:26:06 +08:00
Cheng Zhao
3e1edfc9d0
Cancel callback in OnComplete event
2015-12-23 10:20:59 +08:00
Brian R. Bondy
11b2015535
Add did-change-theme-color event to webview
2015-12-22 17:28:22 -05:00
jaanus
aa2f7aaf3a
Fixes #2810 : correct look of hidden-inset windows in full screen.
...
`hidden` and `hidden-inset` windows differ only by the hidden-inset window having a toolbar. Yet, the toolbar yields an incorrect look in fullscreen mode. So, we hide and recreate the toolbar for such windows when going to/from fullscreen.
There are some visible artifacts during the fullscreen animations, as the toolbar gets created and destroyed. When entering fullscreen, you see a toolbar that then disappears. When going back to normal window, you see the traffic light buttons jump around a little bit. Yet, this is definitely better than the current broken fullscreen look.
2015-12-22 20:31:55 +02:00
Cheng Zhao
c8c4381085
Cancel callback when URLRequest is destroyed
2015-12-22 23:35:23 +08:00
Robo
61004f0e46
fix cpplint warning
2015-12-21 19:16:02 +05:30
Robo
d162180196
add api to webview
2015-12-21 17:13:23 +05:30
Robo
39e615ed87
webContents: adding findInPage api
2015-12-21 17:09:56 +05:30
Cheng Zhao
144b73c267
Merge pull request #3877 from bbondy/master
...
Add media play events to webview
2015-12-21 18:22:30 +08:00
Cheng Zhao
fa8d251370
Merge pull request #3875 from deepak1556/history_navigation_patch
...
navigaton: handle history operations from renderer
2015-12-21 18:18:45 +08:00
Cheng Zhao
99a661e2d2
Code cleanup of browser_mac.mm
2015-12-21 10:52:49 +08:00
Cheng Zhao
8d094d99da
Merge pull request #3853 from jrehbein/fix-issue-3739-mac-dockshow
...
DockShow workaround for issue #3739
2015-12-21 10:38:52 +08:00
Brian R. Bondy
fed0c43970
Add media play events to webview
2015-12-19 22:37:51 -05:00
Robo
7b03ac6d61
navigaton: handle history operations from renderer
2015-12-20 01:23:47 +05:30
Cheng Zhao
bff2861311
Bump v0.36.1
2015-12-18 13:16:30 +08:00
Robo
836c13b330
browser: check for rvh existence
2015-12-18 04:45:32 +05:30
Jeff Rehbein
a39834740c
DockShow workaround
...
Implemented workaround in DockShow for TransformProcessType bugginess
based on discussion at http://stackoverflow.com/questions/7596643/
2015-12-17 14:00:04 -06:00
Cheng Zhao
353f08e477
Remove sync call in remote module
2015-12-17 22:03:16 +08:00
Cheng Zhao
0282d424bf
Pass opener ID in command line
2015-12-17 21:27:14 +08:00
Cheng Zhao
d0962b1a93
Fix crash when passing empty path to addRecentDocument
2015-12-15 17:17:24 +08:00
Cheng Zhao
02e0c169a2
Merge pull request #3815 from bjrmatos/master
...
Add A5 Page Size to printToPDF
2015-12-15 16:55:17 +08:00
Cheng Zhao
8ddf4da9ad
Merge pull request #3809 from deepak1556/capture_page_api_patch
...
browser: dont lose coordinates in capturepage src rect
2015-12-15 15:33:02 +08:00
BJR Matos
86bf7341b7
Add A5 Page Size to printToPDF
2015-12-14 23:28:25 -05:00
Kevin Sawicki
d133553c6a
Remove unused ipc event handler
2015-12-14 16:58:32 -08:00
Kevin Sawicki
184b11be4c
Use id from source window when building proxy for event source
2015-12-14 16:47:33 -08:00
Robo
3c5e5053e3
browser: dont lose coordinates in capturepage src rect
2015-12-14 00:52:05 +05:30
Cheng Zhao
10cad5d9ec
Passing '' to fromPartiion should return default partition
2015-12-12 15:47:15 +08:00
Cheng Zhao
4d1e223044
Cleanup the cookies code
2015-12-12 15:33:51 +08:00
Cheng Zhao
9438d42322
Use generic function to handle events
2015-12-12 13:49:58 +08:00
Cheng Zhao
f976e1eda3
Add generic version for FillDetailsObject
2015-12-12 13:20:53 +08:00
Cheng Zhao
d3e723557e
spec: Add test cases for webRequest
2015-12-12 11:31:19 +08:00
Cheng Zhao
fed94aada0
Make the webRequest listener asynchronous
2015-12-12 00:09:03 +08:00
Cheng Zhao
d3c8363450
EventType can not be OR'ed
2015-12-11 21:22:23 +08:00
Cheng Zhao
15cc8164b8
Use lower case for getters
2015-12-11 21:21:02 +08:00
Cheng Zhao
67886cf513
Parse filters in API code
2015-12-11 21:14:13 +08:00
Cheng Zhao
79a627014c
Unify how listeners are handled
2015-12-11 21:02:44 +08:00
Cheng Zhao
9d406b695f
Simpily the code that fills |details|
2015-12-11 20:40:39 +08:00
Cheng Zhao
e295eb0de7
Fix memory leak
2015-12-11 20:11:59 +08:00
Cheng Zhao
467e3b25b2
EvenTypes => EventType
2015-12-11 20:11:22 +08:00
Cheng Zhao
62f4b25cf9
Allow passing null to webRequest
2015-12-11 19:13:56 +08:00
Cheng Zhao
98ba1a24db
Merge pull request #3640 from deepak1556/webrequest_api_patch
...
session: add webrequest api
2015-12-11 16:56:00 +08:00
Cheng Zhao
9495392a1a
Bump v0.36.0
2015-12-11 11:49:01 +08:00
Kevin Sawicki
9bc7c62588
Use source origin in window.postMessage event
2015-12-10 16:52:39 -08:00
Kevin Sawicki
afd736d9f9
Guard against null guest or embedder
...
Uncaught exceptions would occur when these were null and
the target origin was '*'
2015-12-10 15:51:15 -08:00
Robo
053c77d6f4
default session should be persistent
2015-12-11 00:27:15 +05:30
Robo
658accab94
fix pointer usage
2015-12-11 00:25:25 +05:30
Cheng Zhao
a05aa81570
Merge pull request #3701 from deepak1556/protocol_post_data_patch
...
protocol: provide upload data when available
2015-12-10 19:38:35 +08:00
Cheng Zhao
991c8b1aa6
Merge pull request #3733 from deepak1556/service_worker_scheme_patch
...
protocol: api to register schemes that can handle service worker
2015-12-10 19:29:51 +08:00
Cheng Zhao
f4f4b9428d
Merge pull request #3750 from atom/fullscreen-menu-item
...
Don't add the "Enter Full Screen" menu item automatically
2015-12-10 11:54:26 +08:00
Cheng Zhao
c180607ef6
Merge pull request #3721 from atom/emit-process-exit-event-with-code
...
Emit process exit event with app exit code
2015-12-10 11:39:14 +08:00
Cheng Zhao
2d940b7df7
Don't add the "Enter Full Screen" menu item automatically
2015-12-10 11:27:41 +08:00
Cheng Zhao
388a18b265
Don't emit will-quit event when calling app.exit
2015-12-10 11:22:55 +08:00
Kevin Sawicki
ea1479a651
Revert comment tweak
2015-12-09 18:20:53 -08:00
Kevin Sawicki
3e5caf7e54
Get exit code from within App::OnQuit
2015-12-09 18:19:51 -08:00
Kevin Sawicki
fc724b51e8
Move event forwarding back to init
2015-12-09 18:11:38 -08:00
Kevin Sawicki
92433be888
Include exit code with quit event
2015-12-09 18:09:59 -08:00
Kevin Sawicki
63c0095efb
Emit process exit event with app exit code
2015-12-09 14:40:53 -08:00
Robo
461ee49988
fix response headers modification
2015-12-09 20:14:18 +05:30
Robo
c5b5bbbeb2
add documentation
2015-12-09 20:14:18 +05:30
Robo
29f32c5ec7
support filtering event with url regex
2015-12-09 20:14:18 +05:30
Robo
13b5cab738
session: add webrequest api
2015-12-09 20:14:18 +05:30
deepak1556
fbb5091f94
provide option to set content for POST request with url_fetcher
2015-12-09 20:10:57 +05:30
Cheng Zhao
8aee0f52e9
Merge pull request #3715 from atom/do-not-edit-menu-template
...
Do not modify the specified menu template
2015-12-09 12:13:07 +08:00
Cheng Zhao
774ba2a235
Merge pull request #3706 from billyct/master
...
support an api with SetIgnoreMouseEvents for osx
2015-12-09 12:00:16 +08:00
Robo
855d49100f
protocol: api to register schemes that can handle service worker
2015-12-09 03:11:58 +05:30
Cheng Zhao
836a8b1794
Simplify the desktopCapturer code
2015-12-08 13:49:26 +08:00
Cheng Zhao
51368952a2
Remove deprecated API usages
2015-12-08 12:58:39 +08:00
Cheng Zhao
04f7ceab73
Merge branch 'master' into desktop-capture-api
2015-12-08 12:43:44 +08:00
Cheng Zhao
0f2f9b5543
No need to use CommandDispatcher
2015-12-08 11:20:07 +08:00
Cheng Zhao
e8b5a6dedf
Merge pull request #3718 from atom/chrome47-linux
...
Port Chrome47 on Linux
2015-12-08 10:14:27 +08:00
Paul Betts
af28900189
Fix up Chrome47 changes
2015-12-07 13:27:05 -08:00
Kevin Sawicki
68d937ed47
🎨
2015-12-07 11:20:15 -08:00
Kevin Sawicki
96ef09742c
Directly assign submenu when constructor is Menu
2015-12-07 11:16:36 -08:00
Paul Betts
3931ebb7ef
Fix up Windows build errors
2015-12-07 10:02:06 -08:00
Kevin Sawicki
d5c740957f
🎨
2015-12-07 09:29:03 -08:00
Kevin Sawicki
26ac86c95c
Convert submenu when non-Menu is passed into MenuItem ctor
2015-12-07 09:28:48 -08:00
Cheng Zhao
d0be6c7411
Fix cppling warning
2015-12-07 22:44:35 +08:00
Cheng Zhao
73e7773d84
Update to API changes of Chrome 47
2015-12-07 19:56:23 +08:00
billyct
5f092a6c65
support an api with SetIgnoreMouseEvents, and worked fine with osx
2015-12-06 10:14:54 +08:00
Cheng Zhao
e1d7ef7e24
Bump v0.35.4
2015-12-04 19:23:48 +08:00
Cheng Zhao
c8e2be7b28
Bump v0.35.3
2015-12-04 16:43:23 +08:00
Cheng Zhao
5e5ae81c53
'key of' is better than Object.keys
2015-12-04 11:40:35 +08:00
Cheng Zhao
973ae06f21
Destroy the native window in next tick
...
It fixes a possible crash when native code is iterating all windows
while the JavaScript code decides to destroy a window.
2015-12-04 11:35:04 +08:00
Cheng Zhao
2c6d232254
Don't add too much listeners in BrowserWindowProxy
2015-12-04 11:12:36 +08:00
Cheng Zhao
504d3d3088
Merge pull request #3670 from mixmaxhq/jeff/fix_window_open
...
Fix `window.open` not respecting the features string
2015-12-04 10:55:51 +08:00
Charlie Hess
f2797d2eab
Merge commit '58567834c7cb9c290ef48c9e8f54ae37246ef665' into web-contents-download-url
...
Conflicts:
atom/browser/api/atom_api_web_contents.cc
2015-12-03 10:31:51 -08:00
Cheng Zhao
48a11bd237
Weak map only needs to be deleted for once
2015-12-03 17:10:14 +08:00
Cheng Zhao
eb8426269f
Remove itself from the cleanup list when it is destroyed
2015-12-03 17:04:40 +08:00
Cheng Zhao
117b7462de
window.id is no longer available when window is closed
2015-12-03 16:17:10 +08:00
Cheng Zhao
a15f9fab5b
Use BuildPrototype to build prototype
...
This saves the step of manually keeping the global template object,
which is easy to forget then leak.
2015-12-03 16:04:46 +08:00
Cheng Zhao
6795bd1d96
Do not manually manage native resources
...
We should rely on the destructor to cleanup everything, instead of
putting them in the Destroy method.
2015-12-03 15:38:43 +08:00
Charlie Hess
c311c6cf1b
Add a DownloadURL method on WebContents.
2015-12-02 13:49:30 -08:00
Jeff Wear
225fe72d03
Ensure that window.open does not override the child options
...
Fixes https://github.com/atom/electron/issues/3652 .
2015-12-02 12:00:51 -08:00
Cheng Zhao
615ce45849
win: Implement menu parameter
2015-12-02 19:58:10 +08:00
Cheng Zhao
3cdd0f35c7
mac: Implement menu parameter
2015-12-02 19:05:22 +08:00
Cheng Zhao
2fba05b5e7
Add menu parameter for Tray.popUpContextMenu
2015-12-02 18:43:11 +08:00
Cheng Zhao
202475f5a9
Deprecating a property with method of same name causes trouble
...
Close #3511 .
2015-12-02 17:29:58 +08:00
Cheng Zhao
e5974e44ed
Deprecate the page-title-set event
...
We have two names for the same event, page-title-updated wins.
2015-12-01 18:50:56 +08:00
Cheng Zhao
c95117fb22
Delay the page-title-set event to next tick
2015-12-01 18:34:58 +08:00
Cheng Zhao
83ee78451a
Emit event when title becomes empty
2015-12-01 17:53:13 +08:00
Cheng Zhao
8d20dda6d7
No need to override TitleWasSet in NativeWindow
2015-12-01 17:51:09 +08:00
Cheng Zhao
1b3eb1cc5d
Delay the did-fail-provisional-load event to next tick
...
Chrome is doing some stuff after the DidFailProvisionalLoad event, if we
call LoadURL at this time crash would happen.
2015-12-01 17:00:42 +08:00
Cheng Zhao
0f17a0163d
Put common constants in atom_constants
2015-12-01 16:21:15 +08:00
Paul Betts
7fd1db192b
Lint harder
2015-11-30 18:12:00 -08:00
Paul Betts
549da7fd91
Linting
2015-11-30 11:10:18 -08:00
Paul Betts
7cce3987eb
Add CORS header to file jobs
2015-11-30 11:08:45 -08:00
Paul Betts
65cb1488b0
Fix CORS header code to be cleaner
2015-11-30 11:08:44 -08:00
