Commit graph

2990 commits

Author SHA1 Message Date
Cheng Zhao
eaa60e9c17 Destroy the item once item is downloaded 2016-02-02 19:54:41 +08:00
Cheng Zhao
12d311fd29 Gracefully destroy downloadItem 2016-02-02 19:52:09 +08:00
Cheng Zhao
65cf85808f Calling cancel() should destroy the downloadItem 2016-02-02 19:05:58 +08:00
Cheng Zhao
f1f91828ba Rely on OnDownloadDestroyed to destroy downloadItem 2016-02-02 18:49:43 +08:00
Cheng Zhao
f624800881 Merge pull request #4314 from deepak1556/download_cancel_patch
fix crash when default download is canceled
2016-02-02 18:40:44 +08:00
Robo
2819af9586 fix lifetime of downloadItem class when defaultdownload canceled 2016-02-02 15:54:51 +05:30
Cheng Zhao
b2d44a94ce Merge pull request #4312 from deepak1556/host_resolver_cache_clear_patch
session: api to clear host resolver cache
2016-02-02 13:49:35 +08:00
Robo
ce2ea963b9 session: api to clear host resolver cache 2016-02-02 02:06:49 +05:30
yan
035c1dd5a1 Fix 'user strict' typo 2016-02-01 11:46:02 -08:00
Robo
045e42a10c fix crash when default download is canceled 2016-02-02 00:26:37 +05:30
Cheng Zhao
7d68ca21c8 No need of DefaultWebContentsDelegate 2016-02-01 21:09:12 +08:00
Cheng Zhao
159fb857f4 No need to override RequestToLockMouse in CommonWebContentsDelegate 2016-02-01 21:05:29 +08:00
Cheng Zhao
69f93a7528 Merge pull request #4223 from deepak1556/notification_disable_patch
session: add setPermissionRequestHandler api
2016-02-01 20:51:22 +08:00
Robo
ff5fb512b8 use mediastreamdevicescontroller from brightray to enumerate available devices 2016-02-01 17:45:53 +05:30
Robo
b575cd0ef9 add fullscreen permission type 2016-02-01 16:22:05 +05:30
Cheng Zhao
6c282775a9 Merge pull request #4301 from ragingwind/set-icon-crash
Fix type cast of sharedApplication
2016-02-01 18:46:20 +08:00
Robo
45eada306f add pointerlock permission type 2016-02-01 15:13:49 +05:30
Cheng Zhao
e450d1586e Merge pull request #4288 from MaxWhere/master
Adding cursor-changed event to webContents
2016-02-01 17:03:16 +08:00
ragingwind
d2ec311c55 Fix type cast of sharedApplication 2016-02-01 17:17:22 +09:00
Robo
db26dcaf4c expose handler from session and remove permission-request event 2016-02-01 12:23:51 +05:30
Heilig Benedek
745253a369 Quick fix for the memory leak + docs 2016-02-01 07:17:58 +01:00
Cheng Zhao
457c7f55e6 Merge pull request #4271 from thingsinjars/master
🍎 Add 'Hide' to App API for OS X only
2016-02-01 12:54:07 +08:00
Robo
04c3e083fb remove unnecessary getter 2016-02-01 00:43:29 +05:30
Heilig Benedek
066c189249 Renamed some cursor types to their CSS names and added a way to handle custom cursors properly. 2016-01-31 17:00:14 +01:00
Heilig Benedek
61e0219e91 Added documentation, restructured the files to fit better with electron's style and fixed a typo in keyboard_util's name. 2016-01-31 02:27:14 +01:00
Simon Madine
f9efdc4435 🍎 Add Show to API for OS X 2016-01-30 22:30:38 +01:00
Robo
f7556de9fb add spec for new permissions 2016-01-30 19:10:52 +05:30
Cheng Zhao
0aa0efa439 Do not print warning for FILE_ERROR_NOT_FOUND
Close #4282.
2016-01-30 20:49:35 +08:00
Robo
2a278ceb8f delegate to permission manager for other permissions 2016-01-30 16:49:18 +05:30
Heilig Benedek
0c9174bc7c Introduced the cursor-changed event with one parameter - the name of the cursor type 2016-01-30 06:33:55 +01:00
Cheng Zhao
9d8e23c822 Bump v0.36.7 2016-01-30 13:20:46 +08:00
Cheng Zhao
11e2058136 Merge pull request #4281 from atom/fix-object-destroyed
Fix the occasional `Object has been destroyed` exception in the main process
2016-01-30 13:20:09 +08:00
Cheng Zhao
d2c757e2a5 Merge pull request #4277 from lukeadams/osx-min-version-bump
OS X min version bump (10.8=>10.9)
2016-01-30 13:02:24 +08:00
Cheng Zhao
3f68b2f227 Check whether sender is destroyed before calling sender.send
Fix #4279.
2016-01-30 12:58:21 +08:00
Cheng Zhao
5d16257c2d Fix "Object has been destroyed" error in "page-title-updated" event
Close #4249.
2016-01-30 12:20:28 +08:00
Cheng Zhao
899294a040 win: Don't close the handle since we already closed the fd
Fix #4266.
2016-01-30 11:47:22 +08:00
Simon Madine
6a643ec3c8 Only add Hide if OS_X is defined 2016-01-29 22:51:06 +01:00
Luke Adams
839612c9ae Bump minimum OSX version to 10.9 2016-01-29 13:57:48 -06:00
Simon Madine
7a370ccd0f 🍎 Add 'Hide' to App API for OS X only 2016-01-29 16:09:54 +01:00
Robo
f32bf08eb3 add spec 2016-01-29 15:23:28 +05:30
Robo
85e13333c3 webview: add permission-request event 2016-01-29 15:23:28 +05:30
Cheng Zhao
30b35644f6 Bump v0.36.6 2016-01-29 12:43:35 +08:00
Cheng Zhao
77cf30f758 Revert "renderer: dont fork the process when there is server redirect"
This reverts commit ab9d1bf97e.
2016-01-29 11:52:31 +08:00
Cheng Zhao
516b01e398 win: Call _close before close file handle
Fix #4258.
2016-01-28 22:38:53 +08:00
Paul Betts
05aeceeb52 Always fall back to OpenFolderViaShell when trying to reveal a file
We should always fallback to OpenFolderViaShell when revealing a file fails,
since this API seems to be highly subject to Random Bad Things happening to
you.
2016-01-28 19:05:16 +08:00
Cheng Zhao
30ff18ac64 Merge branch 'webrequest_upload_data_patch' of https://github.com/deepak1556/atom-shell into deepak1556-webrequest_upload_data_patch 2016-01-28 18:41:39 +08:00
Cheng Zhao
e9d00b1fc0 Merge pull request #4247 from deepak1556/common_exports_patch
common: export hideInternalModules
2016-01-27 23:20:59 +08:00
Robo
a6bcc5d110 common: export hideInternalModules 2016-01-27 18:44:47 +05:30
Robo
dc0151099c session: provide uploadData with webrequest api when available 2016-01-27 18:39:40 +05:30
Paul P
cbf11f38ca remove unused variable 2016-01-26 14:55:31 +00:00
Paul P
864449db89 prevent assignment to constant variable (url) 2016-01-26 14:44:46 +00:00
Cheng Zhao
a83aee90e5 No need to use scoped_nsobject for id 2016-01-25 15:15:58 +08:00
Cheng Zhao
059d97e1aa Merge pull request #4181 from bengotow/scroll-touch-events
Extend NativeWindow to track touch-based scroll events on OS X
2016-01-25 14:47:54 +08:00
Cheng Zhao
253a4f226f Merge pull request #4211 from ragingwind/dock-seticon
Add app.dock.setIcon to change icon of dock
2016-01-24 22:36:28 +08:00
Cheng Zhao
93cdc91f1a Merge pull request #4206 from ragingwind/paramter-consistency
Update name of paramter for consistency
2016-01-24 22:11:01 +08:00
Cheng Zhao
e1e58b642e Merge pull request #4182 from deepak1556/debugger_api_patch
browser: add webContents.debugger api
2016-01-24 21:43:18 +08:00
Cheng Zhao
7761815339 Merge branch 'bg-color-pr' of https://github.com/evgenyzinoviev/electron 2016-01-24 21:33:53 +08:00
Cheng Zhao
cc560a3900 spec: Fix failing tests on Windows 2016-01-24 14:31:37 +08:00
Cheng Zhao
c41de501cb spec: Test the -able methods 2016-01-24 14:31:37 +08:00
Cheng Zhao
010cc3276a Simplify the setStyleMask calls 2016-01-24 14:31:37 +08:00
Cheng Zhao
239bfe970c Make hasShadow work on Windows/Linux 2016-01-24 14:31:37 +08:00
Cheng Zhao
d704b3f7ba Reorgnize how attributes work 2016-01-24 14:31:37 +08:00
Cheng Zhao
ae7e96f181 Fix fullscreenable on EL Capitan 2016-01-24 14:31:36 +08:00
Cheng Zhao
5372b6cd91 Fullscreenable => FullScreenable 2016-01-24 14:31:36 +08:00
ragingwind
7229d2462a Add app.dock.setIcon to change icon of dock 2016-01-24 08:30:14 +09:00
ragingwind
09966aec38 Update name of paramter for consistency 2016-01-23 22:59:05 +09:00
Cheng Zhao
31624995bc Merge pull request #4202 from evgenyzinoviev/shadow-pr
Added hasShadow option to BrowserWindow on OS X
2016-01-22 23:56:38 -08:00
Cheng Zhao
8cabe0f008 Merge pull request #4156 from evgenyzinoviev/windows-pr
Improvements in BrowserWindow
2016-01-22 23:42:41 -08:00
Robo
d938dd68b0 wrap debugger for lazy initialization 2016-01-23 09:32:21 +05:30
evgenyzinoviev
ff41b4a267 added hasShadow option to BrowserWindow (osx) 2016-01-23 01:16:08 +01:00
evgenyzinoviev
2fcd3ce7cd Support alpha in backgroundColor 2016-01-23 00:55:08 +01:00
evgenyzinoviev
85991d312a mac: SetResizable fix 2016-01-22 23:44:17 +01:00
evgenyzinoviev
ef51e4e108 maximizable and fullscreenable 2016-01-22 23:21:46 +01:00
Cheng Zhao
984462be44 Remove Menu::Popup 2016-01-22 11:59:08 -07:00
Cheng Zhao
ca77c95c6d No more need to override Menu::Popup 2016-01-22 11:27:17 -07:00
Cheng Zhao
0e3a3d0748 views: Remove PopupAtPoint 2016-01-22 11:25:16 -07:00
Cheng Zhao
5f195a789a mac: Remove duplicate code of Popup 2016-01-22 11:17:12 -07:00
Cheng Zhao
360266ba5b positioningItem => positioning_item 2016-01-22 10:51:51 -07:00
Cheng Zhao
ea9b0cfed0 Merge pull request #4192 from evgenyzinoviev/menu-pr
Menu.popup: specify positioning item (OS X)
2016-01-22 10:49:17 -07:00
Robo
3a60ab386c add spec 2016-01-22 19:10:48 +05:30
Robo
df5bad3f89 fix api and docs 2016-01-22 10:27:25 +05:30
evgenyzinoviev
072ab0ddea specify positioning item for popup menus 2016-01-22 03:18:27 +01:00
Ben Gotow
d186dceb4b Add correct window check for wheel events. See description
Tested that with two windows, events are fired on the correct BrowserWindow instance and not both, and that scrolling a window which is in the background works properly.
2016-01-21 16:36:48 -08:00
Ben Gotow
e96e674201 Properly clean up NSEvent monitor 2016-01-21 16:31:31 -08:00
Ben Gotow
d492ff45d5 Rename up/down => begin/end 2016-01-21 16:31:09 -08:00
Cheng Zhao
a230a89de4 Bump v0.36.5 2016-01-21 17:04:38 -07:00
Cheng Zhao
b039741c6b Merge pull request #3902 from bengotow/asar-perf
Add env var to export a hint file to optimize ASAR ordering
2016-01-21 16:46:49 -07:00
Jessica Lord
980bc7bf32 Use Alt in accelerator 2016-01-21 15:48:06 -07:00
Ben Gotow
a3b6f69772 Log ASAR file access to build ordering hint file
This is a work in progress—need to make this behavior optional via a new flag.
2016-01-21 14:45:22 -08:00
Cheng Zhao
21f5e27a5e Merge pull request #4161 from gabriel/master
Support backgroundColor for window on mac
2016-01-21 15:42:21 -07:00
Cheng Zhao
bbf622187c Merge pull request #4178 from deepak1556/webview_blinkfeatures_attributes_patch
webview: add blinkfeatures attribute
2016-01-21 15:03:33 -07:00
Cheng Zhao
a98d576b48 Merge pull request #4177 from deepak1556/default_download_dir_patch
browser: change location of default download dir
2016-01-21 14:54:21 -07:00
Cheng Zhao
56e8ddbdaf Merge pull request #4186 from CharlieHess/webview-load-url
Expose loadURL for the webview tag.
2016-01-21 14:53:32 -07:00
Cheng Zhao
000625e23f Merge pull request #4163 from deepak1556/web_preferences_fonts_patch
browser: add font related settings to webpreferences
2016-01-21 14:35:30 -07:00
Charlie Hess
7192a8517b Expose loadURL for the webview tag. 2016-01-21 13:31:35 -08:00
Gabriel Handford
239baa3e9a Support backgroundColor for window on mac 2016-01-21 11:07:33 -08:00
Robo
0e2323c9c8 browser: add webContents.debugger api 2016-01-21 23:52:23 +05:30
Ben Gotow
bd2252ea55 Extend NativeWindow to track touch-based scroll events on OS X
In N1, we want to implement the famous "swipe to archive" action on threads in the user's inbox. Chrome exposes `scroll` and `wheel` events, but these aren't sufficient to implement the interaction because the element needs to "snap" when the user lifts their fingers from the trackpad, not when they / we stop receiving `wheel` / `scroll` events. These events may stop before the user lifts their fingers, or continue after the user has lifted their fingers if they had enough momentum for the gesture to continue.

This exposes BrowserWindow `scroll-touch-down` and `scroll-touch-up`, which fire immeditaely when the user touches two fingers to the trackpad, and again when the user lifts their fingers. Combined with the existing wheel event should allow for "swipe-to-archive" and other similar interactions.

Note: This is only implemented on Mac OS X and the events don't fire unless you're using a trackpad!

Related: #1486, #2683, https://github.com/nylas/N1/issues/541
2016-01-21 09:40:21 -08:00
Kevin Sawicki
16b4b58de1 e -> error 2016-01-21 09:32:21 -07:00
Kevin Sawicki
b1f679ff6d Clean up semicolon lint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
70bcb0ac5a Clean up no-unused-vars lint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
4f4456bde8 Clean up indent eslint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
45ddbb6d67 Clean up no-unreachable lint errors 2016-01-21 09:32:21 -07:00
Robo
fab34b400e webview: add blinkfeatures attribute 2016-01-21 15:43:41 +05:30
Robo
c14dd71df1 browser: change location of default download dir 2016-01-21 13:51:37 +05:30
Robo
8a00406862 browser: add font related settings to webpreferences 2016-01-21 13:30:05 +05:30
Cheng Zhao
40557083f0 Merge pull request #4164 from deepak1556/menu_toggle_crash_patch
browser: fix crash when switching to sibling menu from submenus
2016-01-20 15:32:53 -07:00
Kevin Sawicki
8140adb6bc Remove trailing whitespace 2016-01-20 09:43:32 -07:00
Robo
65325dc63f browser: fix crash when switching to sibling menu from submenus 2016-01-20 10:54:12 +05:30
Kevin Sawicki
517dce443b Remove unused errorMessage reference 2016-01-19 11:02:12 -08:00
evgenyzinoviev
fd5c249cb8 fix for windows 2016-01-19 16:58:19 +01:00
evgenyzinoviev
0a79204abb IsMovable to return true on Linux 2016-01-19 16:44:04 +01:00
evgenyzinoviev
c3049e1e99 docs updated 2016-01-19 16:14:59 +01:00
evgenyzinoviev
2a554cb138 added or/and improved closable, minimizable, movable, resizable features for windows on os x and windows 2016-01-19 16:14:57 +01:00
Cheng Zhao
3b62ce7fa6 modules.exports => module.exports 2016-01-16 14:26:01 +08:00
Cheng Zhao
775e475d5c Merge pull request #4131 from etiktin/add_is_DWM_enabled
Add API for checking if DWM composition (Aero Glass) is enabled
2016-01-16 14:16:22 +08:00
Cheng Zhao
25afcf2673 Merge pull request #4121 from atom/format-coffee-helpers
Format leftover CoffeeScript helpers
2016-01-16 13:24:26 +08:00
Eran Tiktin
83b36ce40b Add API for checking if AeroGlass/DWM is enabled
Resolves #1020
2016-01-16 06:27:44 +02:00
Cheng Zhao
712f11a9a3 Merge pull request #4112 from evgenyzinoviev/resize-animate-pr
Animate window resizing on OS X
2016-01-16 12:12:00 +08:00
Cheng Zhao
b132c0dde8 Update brightray, close #4124 2016-01-16 11:43:46 +08:00
Eran Tiktin
85449e953e Fix Windows crash when trying to free asar fd 2016-01-16 03:48:07 +02:00
Kevin Sawicki
0fe539f2c3 Remove unneeded semicolon 2016-01-15 15:30:07 -08:00
Kevin Sawicki
ae20292322 Add missing { 2016-01-15 15:30:07 -08:00
Kevin Sawicki
f830af49c2 Use ES6 style class 2016-01-15 15:30:01 -08:00
Kevin Sawicki
5fc671f522 Add back v8Util binding 2016-01-15 14:29:36 -08:00
Kevin Sawicki
aab2821122 Use ES6 style class 2016-01-15 14:28:12 -08:00
Kevin Sawicki
aab1568682 Use ES6 style class 2016-01-15 14:16:38 -08:00
Kevin Sawicki
02f055b784 Use ES6 style class 2016-01-15 14:12:57 -08:00
Kevin Sawicki
caf7cf5582 Use const instead of var 2016-01-15 11:46:52 -08:00
Kevin Sawicki
79f1029d59 Remove unneeded .constructor segments 2016-01-15 10:29:00 -08:00
Kevin Sawicki
34030d7b2b Use util.inherits instead of CoffeeScript's extend function 2016-01-15 10:17:45 -08:00
Kevin Sawicki
2b95aeba3c Declare vars one per line 2016-01-15 10:17:45 -08:00
Kevin Sawicki
2833db78ad Use [].inclues where appropriate 2016-01-15 10:17:45 -08:00
Kevin Sawicki
c2d473cf65 Remove unneeded [].indexOf fallback 2016-01-15 10:17:45 -08:00
Kevin Sawicki
741d148776 Add missing semicolon 2016-01-15 10:09:19 -08:00
Kevin Sawicki
b119704ea9 Use 2 space indent instead of 3 2016-01-15 10:05:35 -08:00
evgenyzinoviev
64f310168c code style fix 2016-01-15 17:40:42 +01:00
evgenyzinoviev
b75dccb0be arguments handing rewritten, doc updated 2016-01-15 17:31:31 +01:00
Cheng Zhao
63278aeec2 Merge pull request #4118 from Ivshti/patch-1
Ensure we close FD on Windows
2016-01-15 23:58:57 +08:00
Cheng Zhao
0937144849 Merge pull request #4111 from evgenyzinoviev/movable
Added an option to prevent a window from being moved on OS X
2016-01-15 23:24:22 +08:00
Ivo Georgiev
7586078d0a Ensure we close FD on Windows 2016-01-15 16:54:29 +02:00
Cheng Zhao
9ccc7ee30d Small ajustments on lifetime of webContents 2016-01-15 16:36:35 +08:00
Cheng Zhao
c10c419f1d No need to call sender.callbacks.remove
The IDWeakMap automatically removes the key when object is garbage
collected.
2016-01-15 16:36:35 +08:00
Cheng Zhao
3875b30fcf Merge pull request #4109 from atom/const
[WIP] Use `const` for requires
2016-01-15 16:32:07 +08:00
Cheng Zhao
39225ac5ec Bump v0.36.4 2016-01-15 14:27:19 +08:00
evgenyzinoviev
2598b00b41 Animate window resizing on OS X 2016-01-15 05:59:58 +01:00
evgenyzinoviev
cda88db77c Added option to prevent a window from being moved on OS X 2016-01-15 03:58:57 +01:00
Jessica Lord
003de0debe Clean up variable declarations 2016-01-14 18:07:29 -08:00
Jessica Lord
5a4a8e1fa7 🔥 stray ref 2016-01-14 17:03:55 -08:00
Jessica Lord
ae2893ceaa Inline var 2016-01-14 15:44:33 -08:00