Darshan Sen
6733279037
docs: document when BrowserWindow and BrowserView can be used ( #33696 )
...
We already document such info for other APIs, like the 'screen' API in
f711fe6b57/docs/api/screen.md (L7-L8)
2022-04-18 10:11:44 -04:00
Samuel Attard
2d0ad04354
docs: update security guide regarding ctx isolation ( #33807 )
2022-04-18 10:09:54 -04:00
Shelley Vohr
b66667b843
feat: allow null when subscribing notification ( #33641 )
...
* feat: allow null when subscribing notification
* docs: document null event
2022-04-13 22:02:33 +02:00
Shelley Vohr
3057ff0120
docs: note safeStorage.isEncryptionAvailable() needs ready event ( #33724 )
2022-04-12 12:47:15 -07:00
Shelley Vohr
caddc83cfe
feat: implement chrome.tabs.reload ( #33560 )
2022-04-11 22:51:10 +02:00
Cheng Zhao
75ccec7996
docs: recommend setting e.returnValue ( #33628 )
2022-04-07 09:39:51 +02:00
David Sanders
0ac6d74536
docs: mark platform-specific functionality for BrowserWindow ( #33512 )
2022-04-04 18:00:45 +09:00
Cheng Zhao
cbd06cd25e
docs: remove "cache" from app.getPath ( #33509 )
2022-03-31 09:33:38 +09:00
Mitchell Cohen
a9296229c8
feat: add app.isHidden API for macOS ( #32155 )
...
* feat: add app.isHidden API
* Update docs/api/app.md
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
* fixed isHidden tests
* Update docs/api/app.md
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
* Update spec-main/api-app-spec.ts
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
2022-03-29 21:34:07 -04:00
Samuel Attard
4c988a5a24
docs: fix type of 'value' param in setUserDefaults ( #33481 )
2022-03-29 14:47:06 -07:00
Joseph
6b66fea67d
docs: update heading level of webFrame.insertCSS ( #33467 )
2022-03-29 16:02:30 +09:00
Calvin
f69b59effc
feat: add WCO title bar style setters ( #33066 )
...
* feat: add wco title bar style setters
* return after throwing
2022-03-24 20:02:45 -04:00
Jeremy Rose
4fdf8584ed
docs: fix SCA and postMessage links in web-frame-main.md ( #33415 )
2022-03-24 13:12:47 -04:00
Charles Kerr
0af2b8de73
docs: mark skipTaskbar as unsupported on Linux ( #33226 )
...
Fixes #33124 .
2022-03-22 15:12:20 +09:00
Shelley Vohr
db79734bfb
feat: support more color formats for backgroundColor ( #31868 )
2022-03-21 18:35:54 +01:00
Milan Burda
755feb4d81
feat: add nativeTheme.inForcedColorsMode ( #32956 )
2022-03-21 10:30:02 +01:00
David Sanders
7acb513ba6
docs: update links to Chromium source ( #33309 )
2022-03-17 13:45:55 +01:00
Jeremy Rose
4342b7ff55
chore: remove awkward semi-documented preloadURL WebPreference ( #33228 )
2022-03-16 16:23:41 -07:00
Jeremy Rose
02fe245521
docs: webFrame.insertCSS should mention options arg ( #33274 )
2022-03-16 10:56:20 -04:00
David Sanders
fc7f38c7ce
docs: remove "marked" from process.getBlinkMemoryInfo() ( #33263 )
2022-03-16 11:51:56 +01:00
Milan Burda
2657383ea7
feat: allow setting code cache directory ( #31154 )
...
* feat: allow setting code cache directory
* chore: address review feedback
* chore: update docs
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: rewrite with base::Contains
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-03-15 15:34:53 -05:00
CanadaHonk
37a904c299
docs: specify default for BrowserWindow's center option ( #33264 )
2022-03-15 10:48:25 -07:00
Kevin Ushey
3bc3896ee7
docs: fix documented return value for getFocusedWebContents ( #33170 )
2022-03-08 14:15:05 -05:00
Makonede
12aa991df2
Fix a typo ( #33042 )
2022-03-07 17:17:12 -05:00
t57ser
41b2945ced
feat: add ability to configure if window should close when opener closes ( #31314 )
...
* feat: Added ability to configure if window should close when opener closes
* fix: check if embedder is destroyed
* fix: correctly take over closeWithOpener property
* chore: Added documentation
* Update docs/api/window-open.md
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
* chore: refactor
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* chore: changed property name from `closeWithOpener` to `outlivesOpener`
* dummy change to kick lint
* undo above
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2022-02-23 16:59:50 +09:00
Erick Zhao
e9a43be9be
docs: add IPC doc ( #32059 )
...
* docs: add IPC doc
* fix: use "string" primitive
* use 'string' ipcrenderer
* use "number" primitive
* Update docs/tutorial/ipc.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* Update docs/tutorial/ipc.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* add code sample
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2022-02-09 11:00:05 -05:00
Jeremy Rose
ce86e81aa6
docs: clarify meaning of cssOrigin ( #32753 )
2022-02-08 12:59:28 +01:00
Shelley Vohr
81fcd732c2
fix: savePage throw on relative paths ( #32728 )
2022-02-07 09:51:59 +01:00
Cheng Zhao
c3d11e2ea2
test: fix failing tests of focus/blur events of WebContents ( #32711 )
2022-02-02 10:32:53 -05:00
Tobias Nießen
2289a52fb3
docs: fix typo in BrowserWindow description ( #32667 )
2022-02-01 12:47:49 +01:00
Samuel Maddock
aeee9cfb78
feat: add focus and blur events for WebContents ( #25873 )
...
test: add focus and blur WebContents event tests
test: confirm that webcontents focus event is fired on browserwindow focus
fix: mac focus event test timeout
2022-02-01 19:28:57 +09:00
Paul Hollinsky
e34d7f5d6f
docs: fix missing tag end in clipboard example ( #32673 )
2022-02-01 17:57:33 +09:00
Harshil jain
d657cd8ed6
docs: Remove the latin words from doc ( #32641 )
2022-01-28 12:40:20 -08:00
Mikael Finstad
20ed5701e9
docs: update context bridge docs about Promises and Errors ( #32533 )
...
* Update context bridge docs about Promises
From my testing it doesn't remove Promises in nested objects,
also according to the test suite it does not:
80577a4f08/spec-main/api-context-bridge-spec.ts (L693)
2022-01-27 20:23:40 +09:00
WeiZhiHuang
8ec81c1437
fix webRequest.onBeforeSendHeaders' attributes ( #32474 )
...
Co-authored-by: Wayne Huang <zjason4202@gmail.com>
2022-01-26 11:41:54 -05:00
Shelley Vohr
65bee9120f
docs: correct requestSingleInstanceLock parameter ( #32595 )
2022-01-25 12:57:57 -08:00
Michaela Laurencin
2f0d5651a9
feat: add WCO height option ( #31222 )
...
* feat: add WCO height option
* add docs and mac functionality
* add macOS functionality and height lowerbound
* Update docs/api/browser-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* update macOS functionality
* add chromium related notes
* add test and fix pixel under button bug and fix typo
* revert changes to docs/api/frameless-window.md
* modify `useCustomHeight` calls
* update `useCustomHeight` and `getCurrentMargin`
* modify margin calculation
* fix minimum custom height on macOS
* Update window_buttons_proxy.mm
* fix specified traffic light positions
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2022-01-24 17:09:21 -05:00
Kevin
2fe5d0e1e8
feat: Added missing info to IAP transaction and product structures ( #31739 )
2022-01-24 08:55:18 -08:00
Matthew Rayermann
d26d337bb8
feat: add rawHeaders to IncomingMessage ( #31853 )
...
* Add response.rawHeaders to docs for IncomingMessage
* Remove trailing spaces
* Implement raw headers, add tests
* Fix lint issues
* Add example from NodeJS docs
* Fix lint issue in doc example
* Add missing #
2022-01-24 11:46:15 -05:00
AN
ac0d6bdb1e
Clarify will-redirect event doc ( #32093 )
2022-01-18 12:06:22 -05:00
David Sanders
fac61122d5
docs: fix anchors for broken relative links ( #32478 )
2022-01-17 16:36:19 +09:00
Charles Kerr
ddd66543f7
docs: explicitly allow string for MessageBoxOptions.icon ( #32422 )
...
Fixes #32390 . See #19782 for context.
2022-01-13 10:30:15 +09:00
electron-roller[bot]
b0f315a637
chore: bump chromium to 99.0.4767.0 (main) ( #31986 )
...
* chore: bump chromium in DEPS to 98.0.4726.0
* 3292117: Remove unneeded base/compiler_specific.h includes in //chrome.
https://chromium-review.googlesource.com/c/chromium/src/+/3292117
* 3289198: Enables calculating line, word and sentence boundaries on the browser
https://chromium-review.googlesource.com/c/chromium/src/+/3289198
* 3276176: Remove expired gdi-text-printing flag and associated code.
https://chromium-review.googlesource.com/c/chromium/src/+/3276176
* 3240963: content: allow embedder to prevent locking scheme registry
https://chromium-review.googlesource.com/c/chromium/src/+/3240963
* 3269899: Rename WebContentsImpl::GetFrameTree to GetPrimaryFrameTree
https://chromium-review.googlesource.com/c/chromium/src/+/3269899
* chore: fixup patch indices
* 3276279: Enable -Wshadow by default for the "chromium code" config.
https://chromium-review.googlesource.com/c/chromium/src/+/3276279
* 3279737: appcache: Remove WebPreference/WebSetting
https://chromium-review.googlesource.com/c/chromium/src/+/3279737
* 3275564: [api] Advance API deprecation for APIs last marked in v9.6
https://chromium-review.googlesource.com/c/v8/v8/+/3275564
* 3261873: Clean up WebScriptSource constructors
https://chromium-review.googlesource.com/c/chromium/src/+/3261873
* 3279346: appcache: Remove ConsoleMessage appcache field
https://chromium-review.googlesource.com/c/chromium/src/+/3279346
* 3264212: Move legacy file loading to legacy_test_runner
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264212
Both Persistence and UI have been removed from globals, but the issues they
seemed to be patching are no longer reproducible from what I can tell, and
so we can just delete these and re-evaluate if something surfaces.
* 3290415: x11: remove the USE_X11 define.
https://chromium-review.googlesource.com/c/chromium/src/+/3290415
* chore: bump Chromium to 98.0.4728.0
* 3179530: Defer system calls in PrintingContext for OOP printing
https://chromium-review.googlesource.com/c/chromium/src/+/3179530
* 3299445: Consolidate is_win conditionals in chrome/test/BUILD.gn.
https://chromium-review.googlesource.com/c/chromium/src/+/3299445
* chore: update patch indices
* 3223975: Break PrintJobWorker OOP logic into separate class
https://chromium-review.googlesource.com/c/chromium/src/+/3223975
* chore: bump chromium in DEPS to 98.0.4730.0
* 3279001: Remove support for font-family: -webkit-pictograph
https://chromium-review.googlesource.com/c/chromium/src/+/3279001
* chore: fixup patch indices
* chore: bump chromium in DEPS to 98.0.4732.0
* chore: update patches
* chore: bump chromium in DEPS to 98.0.4734.0
* chore: bump chromium in DEPS to 98.0.4736.0
* chore: update patches
* chore: update printing patch for miracle ptr
* chore: add noexcept to fix clang error
* chore: bump chromium in DEPS to 98.0.4738.0
* chore: update patches
* chore: bump chromium in DEPS to 98.0.4740.0
* chore: bump chromium in DEPS to 98.0.4742.0
* chore: bump chromium in DEPS to 98.0.4744.0
* chore: bump chromium in DEPS to 98.0.4746.0
* chore: bump chromium in DEPS to 98.0.4748.0
* chore: bump chromium in DEPS to 98.0.4750.0
* chore: update patches
* 3293841: Remove File Handling permissions code
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3293841
* chore: update patches
3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700
* 3289260: [CodeHealth]: Remove uses of Notification Service
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3289260
* 3301600: Disable scripted print in fenced frames
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3301600
* chore: add missing thread_restrictions headers
* 3305132: Rewrite most `Foo* field_` pointer fields to `raw_ptr<Foo> field_`.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3305132
* fix: add ppapi_sandbox header for linux
3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700
* chore: manually bump chromium in DEPS to 98.0.4757.0
* chore: update patches
* 3321044: Remove DictionaryValue::Clear()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3321044
* chore: update printing.patch
Refs:
- 3304556: [code health] Remove notification observation from PrintJob. | https://chromium-review.googlesource.com/c/chromium/src/+/3304556
- 3305095: [code health] Remove NotificationService from PrintViewManagerBase. | https://chromium-review.googlesource.com/c/chromium/src/+/3305095
* build: add v8-embedder-state headers to GN patch
* chore: bump chromium in DEPS to 99.0.4767.0
* chore: update patches
* chore: rename CookiePartitionKeychain
...to CookiePartitionKeyCollection
* chore: update video consumers
* refactor: use newer base::Value API
* 3232598: Convert net::DnsOverHttpsServerConfig into a class | https://chromium-review.googlesource.com/c/chromium/src/+/3232598
* 3327865: Remove the default WebContentsUserData ctor. | https://chromium-review.googlesource.com/c/chromium/src/+/3327865
* 3302814: DevTools: Add getPreference binding | https://chromium-review.googlesource.com/c/chromium/src/+/3302814
* 3301474: [tq][runtime] Use build flags for JS context promise hooks | https://chromium-review.googlesource.com/c/v8/v8/+/3301474
* oops 😵💫
* 3272411: Reland "base/allocator: Enable PartitionAlloc-Everywhere on macOS" | https://chromium-review.googlesource.com/c/chromium/src/+/3272411
build: turn PartitionAlloc back off on mac for now
* fix: WCO method got renamed
* 3344749: Revert "Stop using NSRunLoop in renderer process"
https://chromium-review.googlesource.com/c/chromium/src/+/3344749
* 3288746: [serial] Fix BluetoothSerialDeviceEnumerator threading issues.
https://chromium-review.googlesource.com/c/chromium/src/+/3288746
* Revert "3288746: [serial] Fix BluetoothSerialDeviceEnumerator threading issues."
This reverts commit 5cc69f102e43ca72ac9ef45063711bcc7d849740.
* chore: disable serial device enumerator sequence dcheck
* fix: comment out line in DeviceService dtor
* fixup! 3279001: Remove support for font-family: -webkit-pictograph
* fixup! 3279346: appcache: Remove ConsoleMessage appcache field
* chore: update patches after rebase
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2022-01-10 17:31:39 -05:00
Raymond Zhao
746927c972
feat: Add first-instance-ack event to the app.requestSingleInstanceLock() flow ( #31460 )
...
* feat: Add onFirstInstanceAck event for requestSingleInstanceLock
* Add tests
* Apply patch fix
* Add back missing docs
* Rebase
* Listen for exit earlier in test
* Rebase
2022-01-10 11:54:46 -05:00
Evan Hahn
ef058892bb
docs: clarify case insensitive dictionary hosting ( #32222 )
...
You must either (1) have a case-insensitive file server (2) upload files in both casings. This improves the docs to clarify that.
[0]: https://github.com/electron/electron/issues/22482#issuecomment-593617375
2022-01-10 11:07:46 +01:00
David Sanders
bd861e5079
docs: fix note for will-move event ( #32362 )
2022-01-10 11:02:16 +01:00
Milan Burda
6d8a858897
docs: left is a valid mode in contents.openDevTools() options ( #32372 )
2022-01-10 10:50:18 +01:00
Mitchell Cohen
5af6b898d9
feat: add Substitutions menu roles on macOS ( #32024 )
2022-01-06 10:41:28 -08:00
Jeremy Rose
d44a187d0b
feat: remove nativeWindowOpen option ( #29405 )
...
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2022-01-06 09:28:03 -08:00
MikeBusuttil
c1c710bc01
docs: improve BrowserView example ( #32098 )
...
* working example
previous example not beginner-friendly
* Update browser-view.md
Co-authored-by: Cheng Zhao <github@zcbenz.com>
2022-01-06 12:09:36 +09:00
Maciej Krawczyk
84f1d78558
docs: correct webFrame description ( #32205 )
...
The current description incorrectly states that the webFrame export represents the top frame but it actually represents the current frame.
2022-01-04 10:12:55 +09:00
Duncan Hewett
2c700da4de
docs: add Bugsnag as a 3rd party crash server ( #32053 )
2022-01-03 14:48:15 -05:00
Samuel Attard
a11f5cbb27
fix: ensure bluetooth devices are not returned by default ( #32178 )
2021-12-15 11:46:48 -08:00
Cheng Zhao
35ac7fb8e6
fix: window.open not overriding parent's webPreferences ( #32057 )
...
* fix: window.open not overriding parent's webPreferences
* test: remove "nativeWindowOpen: false" from renderer tests
2021-12-06 12:54:14 +09:00
Milan Burda
e6b1d95a1c
docs: type names changed from wrapper to primitive ( #31752 )
2021-11-15 22:13:18 -06:00
Keeley Hammond
bf7b245fa0
fix: change cookie default from NO_RESTRICTION to LAX_MODE ( #31800 )
...
* fix: change default from NO_RESTRICTION to LAX_MODE
* chore: update cookie docs, redirect tests
2021-11-15 09:20:04 -06:00
John Kleinschmidt
5899a72df9
fix: clipboard.read() to recognize custom types ( #31623 )
2021-11-01 10:00:36 -04:00
Erick Zhao
3193d7e99b
docs: link to Apple developer docs for app.ready event ( #31583 )
...
Changes some links around. There was no link for `NSUserNotification`, and
`UNNotificationResponse` incorrectly linked to our own `NotificationResponse`
API structure doc.
2021-10-27 09:06:01 +09:00
Mitchell McCaffrey
23cdf65c53
feat: add webContents.getMediaSourceId() method ( #31204 )
...
* feat: add webContents.getMediaSourceId() method
* fix: account for null frame_hosts in webContents.getMediaSourceId()
* fix: move webContents.getMediaSourceId definition to be more organised
* fix: move webContents.getMediaSourceId implementation
* fix: move webContents.getMediaSourceId docs
2021-10-25 20:03:59 -04:00
Darshan Sen
8f51d3e1bf
feat: add webContents.getPrintersAsync() ( #31023 )
...
This deprecates the synchronous and blocking `webContents.getPrinters()`
function and introduces `webContents.getPrintersAsync()`, which is
asynchronous and non-blocking.
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
2021-10-25 14:16:58 -04:00
Milan Burda
3332420886
docs: win.getParentWindow() returns BrowserWindow | null ( #31548 )
2021-10-25 11:10:33 -04:00
Erick Zhao
c3a8ad254a
docs: add window customization guide ( #31054 )
...
* docs: add window customization guide
* fixes
* Update docs/api/browser-window.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/api/browser-window.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/fiddles/windows/manage-windows/frameless-window/index.html
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/window-customization.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* fix code fence
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
2021-10-19 09:58:35 +09:00
universalstrapping
14736c5f30
Avoid Undefined Variable In printToPdf Example ( #31455 )
2021-10-19 09:53:59 +09:00
Raymond Zhao
db0a152bc1
feat: Add data parameter to app.requestSingleInstanceLock() ( #30891 )
...
* WIP
* Use serialization
* Rebase windows impl of new app requestSingleInstanceLock parameter
* Fix test
* Implement posix side
* Add backwards compatibility test
* Apply PR feedback Windows
* Fix posix impl
* Switch mac impl back to vector
* Refactor Windows impl
* Use vectors, inline make_span
* Use blink converter
* fix: ownership across sequences
* Fix upstream merge from Chromium
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2021-10-14 21:32:32 -04:00
Maxime Serrano
b2a2b077da
fix: also pass securityOrigin to media permissions request handler ( #31357 )
2021-10-13 17:10:12 -04:00
Samuel Attard
014ebbd6fa
feat: add commandLine.removeSwitch ( #30933 )
...
* feat: add commandLine.removeSwitch
In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher
* fix: add missing removeSwitch to app.ts
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2021-10-06 16:45:58 -04:00
John Kleinschmidt
d6de243837
chore: refactor persisting permission granted to serial ports ( #31181 )
2021-10-06 16:18:00 -04:00
Milan Burda
36ed216040
docs: add missing 'context-menu' event to webview-tag.md ( #31277 )
2021-10-05 20:42:09 -07:00
Jeremy Rose
4fd7c2adcd
feat: make desktopCapturer main-process-only ( #30720 )
...
* feat: make desktopCapturer main-process-only
* remove --enable-api-filtering-logging
* remove test
* merge lib/browser/api/desktop-capturer.ts with lib/browser/desktop-capturer.ts
* remove desktop-capturer-get-sources event
* fix specs
* getSources needs to be async
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2021-10-04 12:16:00 +09:00
Tobias Nießen
e53bd1b72a
fix: fix typo in description of secureDnsMode ( #31255 )
2021-10-04 09:57:19 +09:00
John Kleinschmidt
6aece4a83d
feat: add support for WebHID ( #30213 )
...
* feat: add support for WebHID
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* Address review feedback
* Address review feedback
* chore: clear granted_devices on navigation
Also added test to verify devices get cleared
* fixup testing for device clear
* make sure navigator.hid.getDevices is run on correct frame
* clear granted devices on RenderFrameHost deletion/change
* manage device permissions per RenderFrameHost
This change makes sure we don't clear device permission prematurely due to child frame navigation
* Update shell/browser/api/electron_api_web_contents.cc
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* apply review feedback from @zcbenz
* Match upstream ObjectMap
This change matches what ObjectPermissionContextBase uses to cache object permissions: https://source.chromium.org/chromium/chromium/src/+/main:components/permissions/object_permission_context_base.h;l=52;drc=8f95b5eab2797a3e26bba299f3b0df85bfc98bf5;bpv=1;bpt=0
The main reason for this was to resolve this crash on Win x64:
ok 2 WebContentsView doesn't crash when GCed during allocation
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
gin::WrappableBase::SecondWeakCallback [0x00007FF6F2AFA005+133] (o:\gin\wrappable.cc:53)
v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacks [0x00007FF6F028F9AB+171] (o:\v8\src\handles\global-handles.cc:1400)
v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacksFromTask [0x00007FF6F028F867+391] (o:\v8\src\handles\global-handles.cc:1387)
node::PerIsolatePlatformData::RunForegroundTask [0x00007FF6F3B4D065+317] (o:\third_party\electron_node\src\node_platform.cc:415)
node::PerIsolatePlatformData::FlushForegroundTasksInternal [0x00007FF6F3B4C424+776] (o:\third_party\electron_node\src\node_platform.cc:479)
uv_run [0x00007FF6F2DDD07C+492] (o:\third_party\electron_node\deps\uv\src\win\core.c:609)
electron::NodeBindings::UvRunOnce [0x00007FF6EEE1E036+294] (o:\electron\shell\common\node_bindings.cc:631)
base::TaskAnnotator::RunTask [0x00007FF6F2318A19+457] (o:\base\task\common\task_annotator.cc:178)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x00007FF6F2E6F553+963] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:361)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x00007FF6F2E6EC69+137] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:266)
base::MessagePumpForUI::DoRunLoop [0x00007FF6F235AA58+216] (o:\base\message_loop\message_pump_win.cc:221)
base::MessagePumpWin::Run [0x00007FF6F235A01A+106] (o:\base\message_loop\message_pump_win.cc:79)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FF6F2E702DA+682] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:470)
base::RunLoop::Run [0x00007FF6F22F95BA+842] (o:\base\run_loop.cc:136)
content::BrowserMainLoop::RunMainMessageLoop [0x00007FF6F14423CC+208] (o:\content\browser\browser_main_loop.cc:990)
content::BrowserMainRunnerImpl::Run [0x00007FF6F144402F+143] (o:\content\browser\browser_main_runner_impl.cc:153)
content::BrowserMain [0x00007FF6F143F911+257] (o:\content\browser\browser_main.cc:49)
content::RunBrowserProcessMain [0x00007FF6EFFA7D18+112] (o:\content\app\content_main_runner_impl.cc:608)
content::ContentMainRunnerImpl::RunBrowser [0x00007FF6EFFA8CF4+1220] (o:\content\app\content_main_runner_impl.cc:1104)
content::ContentMainRunnerImpl::Run [0x00007FF6EFFA87C9+393] (o:\content\app\content_main_runner_impl.cc:971)
content::RunContentProcess [0x00007FF6EFFA73BD+733] (o:\content\app\content_main.cc:394)
content::ContentMain [0x00007FF6EFFA79E1+54] (o:\content\app\content_main.cc:422)
wWinMain [0x00007FF6EECA1535+889] (o:\electron\shell\app\electron_main.cc:291)
__scrt_common_main_seh [0x00007FF6F6F88482+262] (d:\A01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
BaseThreadInitThunk [0x00007FFEC0087034+20]
RtlUserThreadStart [0x00007FFEC1F02651+33]
✗ Electron tests failed with code 0xc0000005.
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-09-23 20:00:11 +09:00
Milan Burda
77579614e0
feat: add width option to dialog.showMessageBox() ( #30474 )
2021-09-23 19:56:14 +09:00
Black-Hole
e39a1d2ea0
fix: startDrag params type incorrect ( #31034 )
2021-09-23 17:07:39 +09:00
Samuel Maddock
70c534fd14
feat: add frame to context-menu event params ( #30831 )
...
* feat: add frame to context-menu event params
* doc: rephrase frame description
2021-09-22 08:52:49 +09:00
Shelley Vohr
629d8913f6
fix: maximized state calculation for non-resizable windows ( #30989 )
2021-09-21 12:04:32 +02:00
Milan Burda
92bff00d43
feat: add isMainFrame argument to 'certificate-error' event ( #30879 )
2021-09-21 15:49:15 +09:00
Erick Zhao
54b44584fa
chore: correct hierarchy of BrowserWindow headings ( #30905 )
...
* chore: correct hierarchy of BrowserWindow headings
* Update docs/api/browser-window.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/api/browser-window.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/api/browser-window.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
2021-09-15 09:41:37 +09:00
Finn Behrens
6a1726576d
docs: Update windows info for auto-updater ( #30538 )
...
Squirrel.Mac can be served from a static host as well.
2021-09-07 17:03:56 +02:00
Isaac Taylor
4a2f41ee58
docs: updated webview tag documentation to accurately reflect preload behavior with asar archives ( #30768 )
2021-09-06 17:00:17 +09:00
Samuel Maddock
4d89174b41
feat: add 'dom-ready' event to WebFrameMain ( #29290 )
2021-09-01 15:21:15 -07:00
electron-roller[bot]
49e62f1261
chore: bump chromium to 95.0.4629.0 (main) ( #30676 )
...
* chore: bump chromium in DEPS to 95.0.4620.0
* chore: update patches
* 3076261: Move args_ to private in ExtensionFunction
https://chromium-review.googlesource.com/c/chromium/src/+/3076261
* [GURL -> SiteForCookies] content/public/browser/content_browser_client.h
https://chromium-review.googlesource.com/c/chromium/src/+/3107759
* chore: fix -Wunreachable-code-return in node
* Tracing to diagnose ContentScriptTracker-related bad message reports
https://chromium-review.googlesource.com/c/chromium/src/+/3057922
* chore: bump chromium in DEPS to 95.0.4621.0
* chore: update patches
* Remove title from the URL format on Windows.
https://chromium-review.googlesource.com/c/chromium/src/+/3108445
* chore: bump chromium in DEPS to 95.0.4623.0
* Revert "chore: disable v8 oilpan"
This reverts commit 5d255cf1d8e8efbb906047937a713279e5f800d0.
(cherry picked from commit ba5cde4da2428020d99b7fb603c702878f95da78)
* Change file paths in network context params to be relative.
https://chromium-review.googlesource.com/c/chromium/src/+/3092927
* Code Health: Rename/replace content::WebUI::RegisterMessageCallback().
https://chromium-review.googlesource.com/c/chromium/src/+/3104691
* Migrate CanExecuteContentScriptSync to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/3108452
* chore: update patches
* remove unreachable code
* Revert "Revert "chore: disable v8 oilpan""
This reverts commit fef495c0294e21760df51bddb5f7bf1ec9ed5f1e.
* fixup mas patch
* Reland "[include] Split out v8.h"
https://chromium-review.googlesource.com/c/v8/v8/+/3113629
* chore: bump chromium in DEPS to 95.0.4624.0
* chore: bump chromium in DEPS to 95.0.4625.0
* chore: bump chromium in DEPS to 95.0.4626.0
* 3033504: Pass NavigationDownloadPolicy in CreateNewWindowParams
https://chromium-review.googlesource.com/c/chromium/src/+/3033504
* 3058038: Introduce TestPrintingContext & test UpdatePrintSettings
https://chromium-review.googlesource.com/c/chromium/src/+/3058038
* 3114943: [Conditional Focus][#4 ] Add tests and remove flag gating
https://chromium-review.googlesource.com/c/chromium/src/+/3114943
* chore: update patch indices
* chore: bump chromium in DEPS to 95.0.4627.0
* chore: update patches
* 3093591: ozone: webpagepopups: calculate anchor for menu bounds. 4/*
https://chromium-review.googlesource.com/c/chromium/src/+/3093591
* 3110414: [PA] Remove the leading cookie
https://chromium-review.googlesource.com/c/chromium/src/+/3110414
* chore: update patches
* 3076261: Move args_ to private in ExtensionFunction
https://chromium-review.googlesource.com/c/chromium/src/+/3076261
* 3113629: Reland "[include] Split out v8.h"
https://chromium-review.googlesource.com/c/v8/v8/+/3113629
* chore: bump chromium in DEPS to 95.0.4628.0
* chore: update patches
* chore: bump chromium in DEPS to 95.0.4629.0
* chore: update patches
* Fix chrome root store codegen for cross-compile builds.
https://chromium-review.googlesource.com/c/chromium/src/+/3133701
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-09-01 15:55:07 -04:00
Jeremy Rose
dd7aeda6fb
feat: add app.configureHostResolver ( #30576 )
2021-08-31 11:55:30 -07:00
Samuel Maddock
352ac21413
feat: add webContents.fromDevToolsTargetId() ( #29399 )
...
* feat: add webContents.fromDevToolsTargetId()
* refactor: avoid using FromOrCreate
2021-08-27 14:01:24 -07:00
Milan Burda
501ac15b1d
feat: add <webview>.sendToFrame() / frameId to 'ipc-message' event ( #30451 )
2021-08-25 09:46:46 +02:00
Samuel Attard
be43996d35
docs: explain the null webContents case in permission checks ( #30645 )
...
* docs: explain the null webContents case in permission checks
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2021-08-25 09:41:56 +09:00
Shelley Vohr
32194f0f71
fix: crash when using TouchBarScrubber arrow button ( #30661 )
2021-08-24 18:28:57 +02:00
electron-roller[bot]
5513e66982
chore: bump chromium to 95.0.4612.5 (main) ( #30503 )
...
* chore: bump chromium in DEPS to 94.0.4604.0
* build: 3-way merge of chromium patches
* chore: bump chromium in DEPS to 94.0.4605.0
* build: 3-way merge of chromium patches
* 3076040: Reland Remove delete_children RemoveAllChildViews arg
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3076040
* 3069287: Remove the remaining uses and delete the deprecated API
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3069287
* 2297212: Replace RemoveWithoutPathExpansion(.*, nullptr) with Value::RemoveKey()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2297212
Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296
* 3082756: Change transport_security_persister_path param to be a path to a file.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3082756
> this CL intentionally changes the name of the parameter
> in the network context parameters and the order of the constructor
> parameters to ensure all callers update their code to pass a full
> file path rather than a path to a directory.
The 'path' in this diff is already an absolute path, coming from
`CHECK(base::PathService::Get(chrome::DIR_USER_DATA, &path_));` at
08ff1c2cbf/shell/browser/electron_browser_context.cc (L126)https://chromium-review.googlesource.com/c/chromium/src/+/2999884
(example of replacing GetStringWithoutPathExpansion() w/FindStringKey())
Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296
(removal of DictionaryValue::GetStringWithoutPathExpansion)
* 3059260: Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3059260
We had both of these in a 'disable_features' list. Since these feature have
been removed upstream, remove them from our disable list, too.
IMPORTANT: this commit should not be backported to older branches that
still have these features, because doing so would un-disable them.
* 2920890: Load reroute_info from download in-progress and history db back into DownloadItem.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2920890
* 3039323: [Clipboard API] Clipboard Custom Formats implementation Part 5.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3039323
* chore: bump chromium in DEPS to 94.0.4606.0
* 3084502: Add a new PrintRasterizePdfDpi policy.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3084502
* chore: update patches
* chore: bump chromium in DEPS to 94.0.4606.3
* chore: bump chromium in DEPS to 95.0.4608.0
* chore: bump chromium in DEPS to 95.0.4609.0
* [DevTools] Remove report_raw_headers from network::ResourceRequest
https://chromium-review.googlesource.com/c/chromium/src/+/2856099
* Remove content::WebContentsObserver::OnInterfaceRequestFromFrame
https://chromium-review.googlesource.com/c/chromium/src/+/3092665
* Disable kDesktopCaptureMacV2
https://chromium-review.googlesource.com/c/chromium/src/+/3069272
* Add a new PrintRasterizePdfDpi policy.
https://chromium-review.googlesource.com/c/chromium/src/+/3084502
* chore: update patches
* chore: bump chromium in DEPS to 95.0.4609.3
* disable `use_lld` for macos
* chore: update patches
* Linux: use chrome_crashpad_handler instead of crashpad_handler
https://chromium-review.googlesource.com/c/chromium/src/+/3054290
* chore: fix lint
* Revert "[DevTools] Remove report_raw_headers from network::ResourceRequest"
This reverts commit 28f4da1582d046e96cb58f3cbb590503e89dfd0d.
* [DevTools] Remove report_raw_headers from network::ResourceRequest (Attempt #2 )
https://chromium-review.googlesource.com/c/chromium/src/+/2856099
* DCHECK that predictor always has a non-empty NetworkIsolationKey.
https://chromium-review.googlesource.com/c/chromium/src/+/3067698
* Remove --no-untrusted-code-mitigations from //content and //gin
https://chromium-review.googlesource.com/c/chromium/src/+/3096585
* fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
https://chromium-review.googlesource.com/c/chromium/src/+/3059260
* fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
* Convert PrintManager to RenderFrameHostReceiverSet.
https://chromium-review.googlesource.com/c/chromium/src/+/3072019
* chore: bump chromium in DEPS to 95.0.4612.5
* chore: disable v8 oilpan
* [Compiler] Remove untrusted code mitigations.
https://chromium-review.googlesource.com/c/v8/v8/+/3045704
* Remove most FTP logic from services/network.
https://chromium-review.googlesource.com/c/chromium/src/+/3076119
* Rename scale_factor.h -> resource_scale_factor.h
https://chromium-review.googlesource.com/c/chromium/src/+/3057113
* [GURL -> SiteForCookies] extensions/
https://chromium-review.googlesource.com/c/chromium/src/+/3100825
* breadcrumbs: add desktop entry point
https://chromium-review.googlesource.com/c/chromium/src/+/3021746
* Move args_ to private in ExtensionFunction
https://chromium-review.googlesource.com/c/chromium/src/+/3076261
* chore: iwyu
* fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
* Disable kDesktopCaptureMacV2
https://chromium-review.googlesource.com/c/chromium/src/+/3069272
* fixup! [Compiler] Remove untrusted code mitigations.
* fixup! Disable kDesktopCaptureMacV2
* Revert "chore: disable v8 oilpan"
This reverts commit 5d255cf1d8e8efbb906047937a713279e5f800d0.
* Reland "chore: disable v8 oilpan"
This reverts commit 1c252765b07a205560e7b5eed06de2605336e2d8.
The previous revert was to test on which platforms did the
heapsnapshot test actually fail.
* [Clipboard API] Clipboard Custom Formats implementation Part 5.
https://chromium-review.googlesource.com/c/chromium/src/+/3039323
* Convert ExtensionFrameHost to RenderFrameHostReceiverSet.
https://chromium-review.googlesource.com/c/chromium/src/+/3063358
* Convert PDFWebContentsHelper to RenderFrameHostReceiverSet.
https://chromium-review.googlesource.com/c/chromium/src/+/3049751
* [Underscore Migration] Migrate ui/legacy
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093160
* chore: remove unknown permission error
* chore: fix lint
* chore: ignore -Wunreachable-code-return for node deps/
* fixup! chore: ignore -Wunreachable-code-return for node deps/
* fix: windows build
* fix: build dependency
Dependency was missed in cbeae20438https://chromium-review.googlesource.com/c/codecs/libgav1/+/3108669
* chore: revert libgav1 roll
* Revert "3108669: arm,dsp: Fix 8bpp Dct64_NEON()."
This reverts commit 7ed31323127aac8ba2eaff9cae6c9be9a4954f33.
* Revert "chore: revert libgav1 roll"
This reverts commit 084a490d298811267316c786762fe7aa91b6318d.
* chore: revert clang roll
* chore: Fix -Wunreachable-code-aggressive warnings in arm and arm64 code
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: mlaurencin <mlaurencin@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2021-08-23 20:52:17 -04:00
Milan Burda
aad1c0d493
feat: add <webview> 'did-redirect-navigation' event ( #30457 )
2021-08-23 10:26:00 -04:00
Erick Zhao
655b614ecd
docs: remove unused Desktop Environment Integration doc ( #30577 )
...
* docs: remove unused Desktop Environment Integration doc
* Update docs/api/app.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/api/app.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
2021-08-19 08:34:34 +09:00
Erick Zhao
6669abf38d
docs: clarify platform-specific usage of the acceptFirstMouse option ( #30522 )
2021-08-16 14:13:02 +02:00
Samuel Attard
439e83de6c
refactor: remove all usages of the legacy request module ( #30492 )
...
* Replaces request with got
* Replaces nugget with got streams
* Replaces request in docs with got
* Upgrades dugite to drop requests dependency
2021-08-12 10:34:49 -07:00
Michaela Laurencin
41646d1168
feat: enable windows control overlay on Windows ( #29600 )
...
* rebase "feat: enable windows control overlay on Windows"
* correct compilation error
* fix linting errors
* modify includes and build file
* change `hidden` option to `overlay`
* add patch to fix visual layout
* add button background color parameter
* add button text color parameter
* modify `overlay` in docs and modify button hover/press transition color
* change `text` to `symbol`
* remove todo and fix `text` replacement
* add new titleBarOverlay property and remove titleBarStyle `overlay`
* update browser and frameless window docs
* remove chromium patches
* chore: update patches
* change button hover color, update trailing `_`, update test file
* add dchecks, update title bar drawing checks, update test file
* modify for mac and linux builds
* update docs with overlayColor and overlaySymbolColor
* add corner and side hit test info
* modify docs and copyright info
* modify `titlebar_overlay_` as boolean or object
* move `title_bar_style_ to `NativeWindow`
* update docs with boolean and object titlebar_overlay_
* add `IsEmpty` checks
* move get options for boolean and object checks
* fix linting error
* disable `use_lld` for macos
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Apply docs suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* modify `true` option description `titleBarOverlay`
* ci: cleanup keychain after tests on arm64 mac (#30472 )
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-08-11 14:07:36 -04:00
Milan Burda
4f739d7837
docs: add missing <webview> event documentation ( #30450 )
2021-08-10 10:12:54 +09:00
nibbleswap
590858a38d
docs: fix camelcase in menu example ( #30341 )
...
* docs: fix camelcase in menu example and add hint to deal with TS error
hideothers -> hideOthers (the TS compiler caught this)
The TypeScript compiler also did not like the pattern used to
switch between platforms for submenus was loosing the type information
of the literal constants and generalized them as strings which
conflicts with the type definition of MenuItemConstructorOptions.
* docs: Fix spelling, added hint to TypeScript
Without explicitly stating the type for the const template TypeScript does not create a
with the correct shape due to generalization to strings.
* remove ts hints
Co-authored-by: a <a@b>
Co-authored-by: Cheng Zhao <github@zcbenz.com>
2021-08-10 10:01:39 +09:00
George Xu
bc508c6113
feat: add electron.safeStorage encryption API ( #30020 )
...
* feat: add SafeStorage api; first commit
* chore: rename files to fit semantically
* chore: add linkedBindings
* chore: fix function signatures
* chore: refactor eisCookieEncryptionEnabled() fuse
* chore: create test file
* chore: add tests and documentation
* chore: add copyright and lint
* chore: add additional tests
* chore: fix constructor
* chore: commit for pair programming
* wip: commit for keeley pairing
* chore: docs change and code cleanup
* chore: add linux import
* chore: add description to documentation
* chore: fixing tests
* chore: modify behaviour to not allow unencrypted strings as decyption input
* fix add patch for enabling default v11 encryption on Linux
* chore: remove file after each test
* chore: fix patch
* chore: remove chromium patch
* chore: add linux specific tests
* chore: fix path
* chore: add checker for linuux file deletion
* chore: add dcheck back
* chore: remove reference to headless mode
* chore: remove tests for linux
* chore: edit commit message
* chore: refactor safeStorage to not be a class
* chore: remove static variable from header
* chore: spec file remove settimeout
Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
2021-08-05 15:12:54 -07:00
Jeremy Rose
40e76dca07
feat: switch to crashpad on linux ( #30278 )
2021-08-03 14:01:12 -07:00
Biru Mohanathas
ced2e8779f
feat: Allow detection of MITM HTTPS proxies like ZScaler ( #30174 )
...
* feat: Allow detection of MITM HTTPS proxies like ZScaler
For security purposes, Figma heavily restrics the origins that are
allowed to load within our Electron app. Unfortunately some corporate
environments use MITM proxies like ZScaler, which intercepts our
connection to `https://www.figma.com ` and serves a redirect to e.g.
`https://gateway.zscloud.net ` before finally redirecting back to
`https://www.figma.com `.
In order to detect this situation and handle it gracefully, we need to
be able to know whether or not the certificate for our own origin
(`https://www.figma.com `) is chained to a known root. We do this by
exposesing `CertVerifyResult::is_issued_by_known_root`.
If the certification verification passed without the certificate being
tied to a known root, we can safely assume that we are dealing with a
MITM proxy that has its root CA installed locally on the machine. This
means that HTTPS can't be trusted so we might as well make life easier
for corporate users by loosening our origin restrictions without any
manual steps.
* Tweak docs wording
2021-08-02 10:24:58 +09:00
John Kleinschmidt
9cc1b55663
chore: remove experimental from navigator.serial implementation ( #30237 )
2021-07-30 08:57:22 +09:00
Anders Kaseorg
1c95d30c0f
fix: Add missing items to menuItem.role documentation ( #30217 )
2021-07-28 08:45:06 +02:00
Jeremy Rose
ceebae170e
feat: partially support chrome.tabs.update ( #30069 )
2021-07-27 13:36:22 -07:00
Cheng Zhao
05ba6359d0
feat: add signal option to dialog.showMessageBox ( #26102 )
...
* mac: add dialog.closeMessageBox API
* win: Implement dialog.closeMessageBox
* mac: Return cancelId with closeMessageBox
* gtk: Implement dialog.closeMessageBox
* win: Fix 32bit build
* win: Reduce the scope of lock
* fix: Build error after rebase
* feat: Use AbortSignal to close message box
* chore: silently handle duplicate ID
* win: Add more notes about the threads
* chore: apply reviews
* fix: base::NoDestructor should be warpped in function
* chore: fix style on windows
2021-07-15 07:59:27 +09:00
Utkarsh Dixit
b2da2f759a
docs: add runtime.reload as supported extension api ( #29925 )
2021-07-14 15:37:53 -07:00
Milan Burda
c0995b8dff
docs: add <webview> 'did-attach' event documentation ( #29899 )
2021-07-14 20:59:20 +09:00
Jeremy Rose
4d0475c9ce
feat: expose location and modifiers on before-input-event ( #29850 )
...
* feat: expose location and modifiers on before-input-event
* lint
2021-07-14 20:50:02 +09:00
1akshat1
d267f979b7
feat: continue-activity event is extended to support webpageURL property ( #30042 )
...
Co-authored-by: Akshat Malik <amalik@microstrategy.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-07-13 13:21:33 -07:00
Milan Burda
53386914e1
docs: move webRequest filters definition to structures/web-request-filter.md ( #29900 )
2021-07-08 00:20:08 -07:00
Milan Burda
635ed5a6e3
feat: add missing resourceType conversions for webRequest listener details ( #29902 )
2021-07-08 00:19:16 -07:00
Jeremy Rose
550d3c11a8
docs: mention contextIsolation in ipc-main example ( #29918 )
2021-07-06 10:27:35 -07:00
electron-roller[bot]
2585e6d5fa
chore: bump chromium to 93.0.4566.0 (main) ( #29980 )
...
* chore: bump chromium in DEPS to 93.0.4562.0
* chore: update patches
* [base] Made Value::Take{Dict,List}() rvalue ref-qualified.
https://chromium-review.googlesource.com/c/chromium/src/+/2988105
* Revert "Reland "Roll src/buildtools/third_party/libc++/trunk/ 8fa879467..79a2e924d (426 commits)""
https://chromium-review.googlesource.com/c/chromium/src/+/2995482
This reverts commit 9691d6c265f010791c37d374248559969980ec65 and 797723ec838709ddeba0c104e30727ee0b7ac8ca
* Pass gfx::Insets to GetHTComponentForFrame
https://chromium-review.googlesource.com/c/chromium/src/+/2984243
* chore: bump chromium in DEPS to 93.0.4563.0
* [Clipboard API] Clipboard Custom Formats implementation Part 2.
https://chromium-review.googlesource.com/c/chromium/src/+/2967649
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4564.0
* chore: bump chromium in DEPS to 93.0.4565.0
* chore: update patches
* Prevent use of base::NoDestructor for trivially-destructible types
https://chromium-review.googlesource.com/c/chromium/src/+/2998672
* chore: update patches
* fixup! [Clipboard API] Clipboard Custom Formats implementation Part 2.
* chore: bump chromium in DEPS to 93.0.4566.0
* chore: update patches
* chore: add missing header
* ci: do not run clipboard tests on WOA
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2021-07-06 08:17:13 -04:00
Antón Molleda
20c1f504ae
docs: remove Experimental from contextBridge.exposeInMainWorld ( #29985 )
...
The API has been around for about 3 years. It should no longer be
considered experimental.
2021-07-05 08:46:47 +09:00
John Kleinschmidt
1f8a46c9c6
feat: enable window controls overlay on macOS ( #29253 )
...
* feat: enable windows control overlay on macOS
* address review feedback
* chore: address review feedback
* Address review feedback
* update doc per review
* only enable WCO when titleBarStyle is overlay
* Revert "only enable WCO when titleBarStyle is overlay"
This reverts commit 1b58b5b1fcb8f091880a4e5d1f8855399c44afad.
* Add new titleBarOverlay property to manage feature
* spelling fix
* Update docs/api/frameless-window.md
Co-authored-by: Samuel Attard <sam@electronjs.org>
* Update shell/browser/api/electron_api_browser_window.cc
Co-authored-by: Samuel Attard <sam@electronjs.org>
* update per review feedback
Co-authored-by: Samuel Attard <sam@electronjs.org>
2021-07-01 15:25:40 -04:00
Samuel Attard
da9261497e
feat: add MenuItem.userAccelerator property ( #26682 )
...
* feat: add MenuItem.userAccelerator property
This allows folks to read the user-assigned accelerator that macOS users can provide in system preferences. Useful for showing in-app shortcut help dialogs, you need to know if the accelerator you provided is not being used in favor of a user assigned one.
* chore: update syntax
* chore: add safety check for command index being -1
2021-06-29 16:28:16 -07:00
David Sanders
9142563748
docs: remove requestHeaders in webRequest.onHeadersReceived ( #29907 )
2021-06-28 15:52:06 -07:00
Jeremy Rose
c5066cce22
docs: fix broken markdown in dialog.md ( #29782 )
2021-06-22 09:49:30 -07:00
Charles Kerr
8ccab4ce91
feat: bring --enable-logging functionality in line with Chromium ( #25089 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-06-17 14:17:25 -07:00
kdau
226f2a9a56
fix setWindowOpenHandler call syntax ( #29551 )
2021-06-16 16:16:18 +09:00
Samuel Attard
81795744cf
fix: ensure the typescript definitions only export correct value types ( #28712 )
...
* fix: ensure the typescript definitions only export correct value types
In typescript there are two main types of "types" you can export, value types (class, const) and definition types (type, interface). The typescript compiler will let anything declared via const or class be used as a value. Unfortunately we were exporting a bunch of things (see the diff) as class/const when they weren't actually exported values. This lead to typescript being happy but the runtime throwing errors (not something we want).
This change passes "exported-in" context through our docs, to the parser and then to the definitions generator to ensure we only mark things as exported in the ts defs that we actually export.
Fixes #22167
* chore: update typescript-defs
* chore: update typescript-defs
* chore: fix bad typescript in IPC test
* docs: test rendering of new syntax
* chore: update per feedback, use same syntax but with 'this is not exportedd' line
2021-06-15 13:50:31 -07:00
David Sanders
7019713126
docs: use relative links within docs ( #29651 )
2021-06-14 14:02:23 -05:00
Samuel Attard
8446ce1fc7
feat: add new imageAnimationPolicy webpref and webContents setter ( #29095 )
2021-06-08 11:00:22 +09:00
David Sanders
bb6903543c
docs: link to IncomingMessage ( #29457 )
2021-06-03 14:54:33 +09:00
Sergio Padrino
abf6f5c8ba
feat: add new runningUnderARM64Translation property to detect x64 translated apps running on Windows ARM ( #29168 )
...
* feat: add new runningUnderARM64Translation property to detect x64 translated apps running on Windows ARM
* docs: add documentation for the new runningUnderARM64Translation property
* refactor: clean up `IsRunningUnderARM64Translation` Windows implementation
* Return false if IsWow64Process2 doesn't exist
* Emit deprecation warning in runningUnderRosettaTranslation
2021-06-02 16:16:33 +09:00
Samuel Maddock
f9d2a7077e
feat: include resize edge with will-resize event ( #29199 )
...
* feat: emit resize edge with will-resize event
fix: wparam type
fix: private member usage on mac
docs: will-resize event edge option
refactor: 'info' -> 'details' for better type gen
* Update docs/api/browser-window.md
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* Update docs/api/browser-window.md
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-06-02 11:37:10 +09:00
Samuel Attard
f01e35f4ea
feat: add support for Blob's going over the ctx bridge ( #29247 )
2021-05-26 10:34:29 -07:00
Erick Zhao
6330f8be9f
docs: rework introduction docs ( #29062 )
...
* docs: add 'introduction' doc
* note
* wip
* updates
* wip
* wip
* wip
* add missing code
* wip
* add image for chrome processes
* process model wip
* finish line?
* update links
* Update docs/README.md
Co-authored-by: Cheng Zhao <github@zcbenz.com>
* Update docs/tutorial/introduction.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/quick-start.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/process-model.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/process-model.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/process-model.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/quick-start.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/quick-start.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/quick-start.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/quick-start.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* address code review
* Update docs/tutorial/application-distribution.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* remove wip doc
Co-authored-by: Cheng Zhao <github@zcbenz.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
2021-05-24 11:32:36 +09:00
Tabea4
014bdc9f8a
docs: option title for showSaveDialog is not supported for some platforms ( #28747 )
2021-05-19 09:44:17 +02:00
Thomas Kainrad
af426cbdab
Update accelerator.md ( #29193 )
...
`Meta` is a valid alternative for `Super` and should be listed as an available modifier.
2021-05-19 09:52:06 +09:00
Noelle Leigh
5e6f8349ec
docs: --force-fieldtrials was h2 rather than h3 ( #29161 )
...
All the other argument headers were h3 (`###`) but `--force-fieldtrials` was h2 (`##`) for some reason.
I changed it to make it consistent with the others.
2021-05-14 18:32:21 -07:00
Cheng Zhao
4073599f59
fix: remove background color hack in vibrancy ( #29114 )
2021-05-14 11:05:34 +02:00
PalmerAL
5233feaef9
docs: Improve description of findInPage options ( #29077 )
...
* docs: improve webContents.findInPage description
* docs: improve webview.findInPage description
2021-05-13 11:12:08 +09:00
Erick Zhao
8f8708680f
docs: rework sandbox guide ( #28978 )
...
* docs: rework sandbox guide
* update doc name
* add missing comment to code sample
* Update docs/tutorial/sandbox.md
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* Update docs/tutorial/sandbox.md
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* Update docs/tutorial/sandbox.md
Co-authored-by: Biru Mohanathas <birunthan@mohanathas.com>
* load https in the examples
* change `process` docs to Electron's
* remove bit on chrome://sandbox page
* Update docs/tutorial/sandbox.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* Update docs/tutorial/sandbox.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* clarify sandbox default posture
* clarify tasks sandboxed renderers need ipc for
* clarify polyfilled preload environment
* emphasize that --no-sandbox is bad
* clarify preload polyfill `require`
* format markdown references properly
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Biru Mohanathas <birunthan@mohanathas.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-05-06 20:53:55 +09:00
Hamish Macpherson
9fb3a49c7c
docs: link to BrowserView from webview page ( #28942 )
...
* docs: Link to `BrowserView` from `webview` page
* fix relative link
2021-05-05 16:12:16 +09:00
Rajdeep Chatterjee
dd80952877
docs: Added loadFile instead of loadURL in BrowserWindow documentation example ( #28829 )
...
* Added loadFile instead of loadURL in the example
For loading a local file the loadFile API is a better way to load any html file in the Renderer process.
Have changed it in the example.
* Changed backticks to single quote to correct for linting error
In order to correct the linting error reported by the bot, I have changed backticks to single quote in the example.
2021-05-03 13:56:33 -04:00
Erick Zhao
18a76c6b9d
docs: uniformize module API doc format ( #28920 )
...
This PR ensures that all API modules are present in the README doc,
as there were a couple missing. It also formats all modules to contain
a level-1 heading and a blockquote description.
2021-04-29 09:56:31 +02:00
Michael Kozakov
c37c9adbe2
docs: Add clarification for Visual Zoom behavior ( #28860 )
...
* Add clarification for visual zoom documentation
2021-04-28 17:20:47 -04:00
Erick Zhao
0b42316803
docs: remove api/locales page ( #28911 )
...
This page is just a table writing out the contents of an array in
the Chromium source code. We don't actively maintain it, and
it's only referenced in one API, so it makes sense to just
link directly to the code here.
2021-04-28 13:11:50 -07:00
Samuel Attard
fa61e3b119
feat: add session.storagePath to get path on disk for session data ( #28665 )
2021-04-27 09:54:28 -07:00
Jeremy Rose
583660a85a
docs: fix unintentional emoji in win.getMediaSourceId description ( #28767 )
2021-04-22 10:56:25 -07:00
Samuel Maddock
43d27cc4d1
feat: add WebFrameMain.visibilityState ( #28706 )
...
* feat: add WebFrameMain.visibilityState
* docs: mention other page visibility APIs
* test: delay visibilityState check after hiding
* test: add waitForTrue to avoid flaky visibilityState test
* refactor: waitForTrue -> waitUntil
2021-04-22 12:00:58 -04:00
Samuel Attard
79077f6df9
chore: remove app.allowRendererProcessReuse ( #26874 )
2021-04-21 13:59:11 -07:00
Jeremy Rose
4ca518468d
feat: remove BrowserWindow option inheritance ( #28550 )
2021-04-21 10:55:17 -07:00
Shelley Vohr
11199d8824
feat: add BrowserWindow.isFocusable() ( #28642 )
2021-04-21 12:32:19 +02:00
Jeremy Rose
e12a3cb59c
feat: remove deprecated additionalFeatures ( #28548 )
2021-04-19 15:46:54 -07:00
Samuel Attard
400d7c4bce
chore: update ts parser for description comment fixes and generic types ( #28709 )
...
* chore: update ts parser for description comment fixes
* docs: strongly type the getUserDefault API
* spec: add getUserMedia type assertions to smoke run
2021-04-19 11:44:58 -07:00
Electron Bot
22a70eb803
chore: bump chromium to 92.0.4475.0 (master) ( #28462 )
...
* chore: bump chromium in DEPS to 91.0.4464.0
* chore: rebuild chromium/dcheck.patch with import-patches -3
Mechanical only; no code changes
* chore: remove content_browser_main_loop.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
The function being patched (BrowserMainLoop::MainMessageLoopRun()) no
longer exists.
NB: if removing this introduces regressions the likely fix will be to
add a similar patch for ShellBrowserMainParts::WillRunMainMessageLoop()
which has similar code and was added at the same time this was removed.
* chore: rebuild chromium/put_back_deleted_colors_for_autofill.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/disable_color_correct_rendering.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/eat_allow_disabling_blink_scheduler_throttling_per_renderview.patch with patch
Mechanical only; no code changes
* chore: rebuild chromium/gpu_notify_when_dxdiag_request_fails.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/ui_gtk_public_header.patch manually
no code changes
* chore: rebuild chromium/web_contents.patch with import-patches -3
Mechanical only; no code changes
* chore: remove v8/skip_global_registration_of_shared_arraybuffer_backing_stores.patch
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2763874
This patch has been merged upstream
* chore: export patches
* chore: update add_trustedauthclient_to_urlloaderfactory.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_
* chore: sync chromium/put_back_deleted_colors_for_autofill.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2785841
SkColorFromColorId() no longer takes theme, scheme args
* chore: sync chromium/put_back_deleted_colors_for_autofill.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2772143
Change new calls to GetDarkSchemeColor to fit our patched call signature
* chore: update add_trustedauthclient_to_urlloaderfactory.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_ in our mojom
* chore: update chromium/frame_host_manager.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
* chore: update chromium/revert_remove_contentrendererclient_shouldfork.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2755314
Upstream has removed `history_list_length_` which we were comparing to 0
to calculate our `is_initial_navigation` bool when calling ShouldFork().
ShouldFork() is ours and none of the code paths actually use that param,
so this commit removes it altogether.
* chore: update permissions_to_register
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2789074
Replace all uses of APIPermission::ID enum with Mojo type
* refactor: update return type of PreMainMessageLoopRun()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
Used to return void; now returns an int errorcode.
Note: 2725153 also has some nice doc updates about Browser's "stages"
* refactor: sync ElectronBrowserMainParts to MainParts changes
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
RunMainMessageLoopParts has been replaced with WillRunMainMessageLoop
so `BrowserMainLoop::result_code_` is no longer available to us for our
exit_code_ pointer.
This variable held a dual role: (1) of course, hold the exit code, but
also (2) was a nullptr before the message loop was ready, indicating to
anyone calling SetExitCode() that we were still in startup and could
just exit() without any extra steps. exit_code_ still fulfills these two
roles but is now a base::Optional.
* chore: update ElectronBrowserMainParts::PreDefaultMainMessageLoopRun
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
BrowserMainParts::BrowsePreDefaultMainMesssageLoopRun() has been
removed; move that work to the new WillRunMainMessageLoop().
* refactor: stop using CallbackList; it has been removed.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2785973
* refactor: update use of threadpools.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2773408
The upstream code is still in flux (e.g. reverts and re-lands) but the
tl;dr for this commit is (1) include thread_pool.h if you're using it
and (2) don't instantiate pools directly.
* refactor: remove routing_id from CreateLoaderAndStart
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762858
NB: One logic branch in ProxyingURLLoaderFactory::CreateLoaderAndStart
calls std::make_unique<InProgressRequest>, which needs a routing_id.
This PR uses the member field `routing_id_` since there's no longer one
being passed into CreateLoaderAndStart.
* refactor: sync to upstream ParittionOptions churn
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771318
PartitionOptions' enums have changed.
* refactor: update Manifest::Location usage
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771320
tldr: s/Manifest::FOO/ManifestLocation::kFoo/
* chore: bump chromium in DEPS to 91.0.4465.0
* update patches
* refactor: update extensions::Manifest to upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771320
- extensions::Manifest::COMPONENT
+ extensions::mojom::ManifestLocation::kExternalComponent
* refactor: sync with upstream UrlInfo ctor changes
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
* chore: update invocation of convert_protocol_to_json.py
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2792623
python3 is being used in parts of the upstream build, but the copy of
convert_protocol_to_json.py invoked in v8/third_party/inspector_protocol
is not python3-friendly. Node has a py2+3-friendly version of it in its
tools directory, so call it instead.
* chore: use extensions::mojom::APIPermissionID
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791122
tldr:
- extensions::APIPermission::kFoo
+ extensions::mojom::APIPermissionID::kFoo
* chore: Remove support for TLS1.0/1.1 in SSLVersionMin policy
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2765737
Remove TLS v1.0 & 1.1 from our SSLProtocolVersionFromString() function.
This is the same change made upstream at
https://chromium-review.googlesource.com/c/chromium/src/+/2765737/8/chrome/browser/ssl/ssl_config_service_manager_pref.cc
* fixup! chore: update ElectronBrowserMainParts::PreDefaultMainMessageLoopRun
* chore: Use IDType for permission change subscriptions.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791431
tldr: {Subscribe,Unsubscribe}PermissionStatusChange's tag type used to
be an int; now it's the new SubscriptionId type (which is an IdType64).
* chore: sync PowerMonitor code to upstream refactor
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2752635
tldr: PowerMonitor has been split into PowerStateObserver,
PowerSuspendObserver, and PowerThermalObserver to reduce number of tasks
posted to consumers who only need notifications for one of those things
instead of all of them.
* chore: use PartitionOptions's new Cookies field
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771318
* Revert "refactor: remove routing_id from CreateLoaderAndStart"
This reverts commit 8c9773b87a3c84f9073a47089eb2b6889d745245.
8c9773b was only a partial fix; reverting to start & try again.
* update patches
* chore: bump chromium in DEPS to 91.0.4466.0
* chore: update chromium/accelerator.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2795472
tldr: sync patch with upstream renamed variable & macro names.
* chore: update chromium/gtk_visibility.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2796200
tldr: no code changes; just updating the diff to apply cleanly.
note: ooh upstream Wayland hacking!
* chore: update chromium/picture-in-picture.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2710023
tldr: no code changes; just updating the diff to apply cleanly.
* chore: update chromium/worker_feat_add_hook_to_notify_script_ready.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2775573
tldr: no code changes; just updating the diff to apply cleanly.
* chore: export_all_patches
* chore: update chromium/feat_add_set_theme_source_to_allow_apps_to.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2796511
tldr: NotifyObservers has been renamed to NotifyOnNativeThemeUpdated,
so update the invocation in our patch.
* chore: update ElectronBrowserClient w/upstream API
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797454
tldr: GetDevToolsManagerDelegate() was returning an owned raw pointer.
Replaced it with CreateDevToolsManagerDelegate() which uses unique_ptr<>.
* chore: handle new content::PermissionType::FILE_HANDLING in toV8()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762201
`file-handling` string confirmed in https://chromium-review.googlesource.com/c/chromium/src/+/2762201/18/chrome/browser/ui/webui/settings/site_settings_helper.cc
* refactor: remove routing_id from CreateLoaderAndStart pt 1
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762858
Part 1: the easiest ones
* 2796724: Support Python3
https://chromium-review.googlesource.com/c/infra/luci/python-adb/+/2796724
* chore: bump chromium in DEPS to 91.0.4468.0
* 2668974: WebShare: Implement SharingServicePicker
https://chromium-review.googlesource.com/c/chromium/src/+/2668974
* 2802766: Apply modernize-make-unique to media/
https://chromium-review.googlesource.com/c/chromium/src/+/2802766
* 2802823: Apply modernize-make-unique to gpu/
https://chromium-review.googlesource.com/c/chromium/src/+/2802823
* 2803041: Apply modernize-make-unique to remaining files
https://chromium-review.googlesource.com/c/chromium/src/+/2803041
* 2798873: Convert GtkKeyBindingsHandler build checks to runtime checks
https://chromium-review.googlesource.com/c/chromium/src/+/2798873
* 2733595: [ch-r] Parse ACCEPT_CH H2/3 frame and restart with new headers if needed
https://chromium-review.googlesource.com/c/chromium/src/+/2733595
* chore: update patch indices
* 2795107: Remove unused PermissionRequest IDs.
https://chromium-review.googlesource.com/c/chromium/src/+/2795107
* chore: bump chromium in DEPS to 91.0.4469.0
* chore: fixup patch indices
* chore: bump chromium in DEPS to 91.0.4469.5
* PiP 1.5: Add microphone, camera, and hang up buttons to the PiP window
https://chromium-review.googlesource.com/c/chromium/src/+/2710023
* fixup! refactor: remove routing_id from CreateLoaderAndStart
* refactor: use URLLoaderNetworkServiceObserver for auth requests from SimpleURLLoader
* fixup! chore: fixup patch indices
* 2724817: Expand scope of wasm-eval to all URLs
https://chromium-review.googlesource.com/c/chromium/src/+/2724817
* Fixup patch after rebase
* chore: bump chromium in DEPS to 91.0.4472.0
* 2797341: [ozone/x11] Enabled the global shortcut listener.
https://chromium-review.googlesource.com/c/chromium/src/+/2797341
* 2805553: Reland Add GTK ColorMixers to ColorPipeline P1
https://chromium-review.googlesource.com/c/chromium/src/+/2805553
* 2804366https://chromium-review.googlesource.com/c/chromium/src/+/2804366
* 2784730: Fix crash on AX mode change in NativeViewHost without a Widget
https://chromium-review.googlesource.com/c/chromium/src/+/2784730
* chore: update patch indices
* 2810174: Add PdfAnnotationsEnabled policy.
https://chromium-review.googlesource.com/c/chromium/src/+/2810174
* 2807829: Allow capturers to indicate if they want a WakeLock or not.
https://chromium-review.googlesource.com/c/chromium/src/+/2807829
* chore: bump chromium in DEPS to 92.0.4473.0
* chore: bump chromium in DEPS to 92.0.4474.0
* chore: bump chromium in DEPS to 92.0.4475.0
* chore: update patches
* chore: updates patches
* chore: update is_media_key patch to handle new ozone impl
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797341
* fix: ExecuteJavascript requests now need to be flagged as non-bf-aware
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2787195
* chore: icon_util_x11 is now icon_util_linux
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791362
* build: update sysroots
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2628496
* build: fix missing symbols on linux build
* use_ozone and use_x11 are not exclusive
* new button view to build for pip
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797341
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2804366
* chore: fix broken gtk_util color patch
* chore: remove patch conflict
* build: update linux manifests
* chore: build bttlb on all platforms for pip
* chore: add thread_pool include for views delegate win
* chore: fix lint
* chore: add node patches for V8 changes
* build: add missing base include on windows
* fix: update frame host manager patch for new state transitions
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2714464
* chore: update windows zip manifests
* chore: update mac zip manifests
* chore: fix patch linting
* refactor: implement missing URLLoaderNetworkServiceObserver methods
It is against The Mojo Rules to leave hanging callbacks. These always
have to be called.
Refs: 186528aab92622e91c4493077afbfb4e33ee0ad3https://chromium-review.googlesource.com/c/chromium/src/+/2709931
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
2021-04-15 10:44:35 -07:00
Jeremy Rose
f8bdef5349
feat: enable nativeWindowOpen by default ( #28552 )
...
* feat: enable nativeWindowOpen by default
* set nativeWindowOpen: false on spec/ main window
* update snapshots
* fix tests
* fix test
* fix webview test missing allowpopups
* fix other test
* update default
2021-04-13 15:36:38 -04:00
Jeremy Rose
dba4df9326
feat: add more info in setWindowOpenHandler details ( #28518 )
...
* fix: invoke the window open handler for _blank links
* feat: add disposition to setWindowOpenHandler details
* fix: pass postData to new-window event
* postData can be heterogeneous
* fix type of postBody
* fix type of UploadFile and UploadRawData to be discriminated unions
* exclude the empty string from additionalFeatures
* add a test
* add postBody and referrer to setWindowOpenHandler args
* appease typescript
* Update api-browser-window-spec.ts
* update snapshots
2021-04-13 15:35:27 -04:00
Samuel Maddock
ef4954fa1f
docs: systemPreferences.subscribeWorkspaceNotification return type ( #28588 )
2021-04-11 14:02:58 -07:00
Milan Burda
da8c35e3b2
chore: remove deprecated worldSafeExecuteJavaScript option ( #28456 )
2021-04-08 12:03:57 -04:00
Germain
2865d161b7
docs: remove checkbox options in dialog.showMessageBoxSync ( #28418 )
2021-04-07 00:18:19 -07:00
Shelley Vohr
7d04f729d8
fix: beforeunload and unload firing in BrowserViews ( #28382 )
...
* fix: beforeunload and unload firing in BrowserViews
* Ensure UserGesture is sent for BV webContents
* spec: add tests
* refactor: clean up logic
* spec: fixup specs
* docs: document event behavior for BrowserViews
2021-04-07 00:16:10 -07:00
Jeremy Rose
77dcf1020a
fix: pass postData to new-window event ( #28513 )
2021-04-06 09:54:05 -07:00
Michaela Laurencin
19d7a6b761
fix: enable system maximization for frameless windows except if transparent ( #28207 )
...
* fix: move widget maximization check
* fix linting error
* change workaround to only effect transparent windows
* disable menu maximize and restore for transparent windows
* disable double clicking title bar max/unmax for transparent windows
* add docs change and address review
2021-04-06 08:53:59 +09:00
SushiJackal
82ea8ea68c
fix: reject task append to JumpList when description exceeds 260 characters ( #28485 )
...
* fix: reject task when description exceeds 260 characters
* Switched out wcslen() for size() [linear -> constant time]
* Included comment describing the need for the additional check
* Added information about character limit to documentation
* Added newline character to end of jump-list-category.md
2021-04-06 08:50:39 +09:00
Michaela Laurencin
2a55ae4b85
docs: add frameName note for window.open ( #28435 )
2021-03-31 13:57:39 -07:00
Saúl Ibarra Corretgé
2632564ccf
feat: initialize field trials from command line arguments ( #28305 )
...
Fixes : #27877
2021-03-26 09:49:00 +09:00
Alexander Prinzhorn
521146f71e
docs: add missing line in web-contents.md ( #28376 )
...
* Update web-contents.md
The text block was rendered as part of the `features` property, not the `handler`
* fix linting
2021-03-26 09:46:59 +09:00
Will Anderson
8c3165434a
docs: update Node global symbols example to use contextBridge ( #28245 )
...
* docs: update Node global symbols example to use contextBridge
* Trigger Build
* docs: change Node API example to show how to expose a crypto API
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* docs: Fix lint warning for crypto code sample
* docs: update node API example description to emphasize APIs instead of symbols
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-03-22 11:01:12 +09:00
Jeremy Rose
502d4c19ce
feat: allow omitting submitURL when uploadToServer is false ( #28105 )
2021-03-18 14:15:19 -07:00
Samuel Attard
f35fc93080
chore: rename process.contextIsolation to process.contextIsolated ( #28259 )
...
* chore: rename process.contextIsolation to process.contextIsolated
* thing
2021-03-18 14:00:19 -07:00
Milan Burda
fc7f2042ec
feat: add process.contextIsolation property ( #28030 )
2021-03-17 11:23:29 -07:00
Milan Burda
485fa5bea9
feat: add process.contextId used by @electron/remote ( #28007 )
2021-03-17 11:23:03 -07:00
Samuel Attard
b045d42b0e
docs: document the parameter structure of hookWindowMessage ( #28189 )
...
Fixes #28178
2021-03-16 17:54:41 +09:00
Gerrit Niezen
45c4dd529f
docs: remove unnecessary enableBlinkFeatures ( #28129 )
...
* docs: remove unnecessary enableBlinkFeatures
* docs: remove trailing comma
2021-03-15 10:29:10 +09:00
Binyamin Aron Green
a442f11574
fixed typo in docs/api/window-open.md ( #28117 )
2021-03-13 10:47:33 +09:00
Samuel Attard
74e7f98572
docs: fix cookies event documentation for type generation ( #28115 )
2021-03-11 12:14:16 -08:00
Milan Burda
5b205731f6
chore: remove deprecated remote module ( #25734 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-03-09 17:12:40 -08:00
Shelley Vohr
d9997c303f
fix: capturePage not resolving with hidden windows ( #27883 )
2021-03-09 05:51:44 -08:00
Konstantin Pschera
5b50c88508
docs: auto update downloading multiple times ( #27888 )
2021-03-08 10:03:34 +09:00
Erick Zhao
9ccb8f5910
docs: update WebPreferences default values for Electron 12 ( #27984 )
...
Updates the values for `contextIsolation` and `worldSafeExecuteJavaScript` for Electron 12.
2021-03-08 09:56:50 +09:00
Domenic Horner
46cfb347d7
docs: setWindowOpenHandler should show object return ( #28015 )
...
* Should use object return
* Fix lint
Co-authored-by: Cheng Zhao <github@zcbenz.com>
2021-03-08 09:56:07 +09:00
Stathis Siatras
d92bab0e29
docs: suspend and resume are available on Linux ( #27958 )
...
* docs: suspend and resume are available on Linux
* docs: suspend and resume are available on Linux
2021-03-05 10:11:36 +09:00
Keeley Hammond
84d0e827a3
chore: revert webFrameMain.executeJavaScriptInIsolatedWorld method ( #27926 )
2021-03-01 10:07:25 -05:00
Jeremy Rose
2e13ce58c0
docs: fix header level of some events in app.md ( #27860 )
2021-02-24 18:04:41 +09:00
Michaela Laurencin
0dd283a7a6
docs: update menu item '&' escaping ( #27770 )
2021-02-19 15:41:16 +09:00
Dennis Keil
8a88799ce2
docs: transparent window opaque while dev tools opened ( #27705 )
...
* Transparent window disabled while dev tools opened
Read that on some external website. I think this should be added to the official docs.
* Update frameless-window.md
Co-authored-by: Cheng Zhao <github@zcbenz.com>
2021-02-15 11:59:40 +09:00
Samuel Maddock
3250ef551c
feat: support registering MV3 extension service workers ( #27562 )
...
* feat: support registering MV3 extension service workers
* feat: load chrome extension APIs in worker context
* feat: add more ContentRendererClient service worker overrides
* fix: lint error
* refactor: emit object for 'registration-completed'
* docs: clarify when registration-completed emits
2021-02-11 10:58:03 -05:00
Stewart Lord
5f5afaae27
feat: add win.setTopBrowserView() so that BrowserViews can be raised ( #27007 )
...
* feat: Raise a browser view via `BrowserWindow.setTopBrowserView()`.
This is similar to removing and re-adding a browser view, but avoids a visible flicker as the browser view is not removed from the window when using `setTopBrowserView`. Note: if the given browser view is not attached to the window, it will be added.
This commit contains the macOS implementation.
* feat: setTopBrowserView support for Windows and Linux
* docs: add info about setTopBrowserView
* docs: Clarify behavior when browserView is not yet attached.
* fix: throw en error when browserView is not attached to the window
* fix: build error
* fix: test
* fix: add test case
* fix: tests
* fix: reparenting
* fix: close second window in tests
Co-authored-by: sentialx <sentialx@gmail.com>
2021-02-10 16:23:35 +09:00
Cheng Zhao
af4a050a1b
feat: add roundedCorners option for BrowserWindow ( #27572 )
...
* feat: add roundedCorner option for BrowserWindow
* Make roundedCorner work with vibrancy views
* roundedCorner => roundedCorners
2021-02-09 08:38:35 -08:00
Jeremy Rose
28599e5e7c
feat: add exit code to render-process-gone details ( #27580 )
2021-02-08 17:08:11 -08:00
Erick Zhao
affbf1b3e6
docs: remove v5 and v6 modernization docs ( #27498 )
...
* docs: remove v5 and v6 modernization docs
* typo
* run script/gen-filenames.ts
2021-02-03 15:57:33 +09:00
Cyrus Roshan
444ad26f89
feat: add option to not transform processes on win.SetVisibleOnAllWorkspaces ( #27200 )
...
* fix: optionally transform processes on win.SetVisibleOnAllWorkspaces on macOS, making it backwards-compatible with v9.2.1 (#27101 )
* fix: optionally transform processes on win.SetVisibleOnAllWorkspaces on macOS, making it backwards-compatible with v9.2.1 (#27101 )
Co-authored-by: Cyrus Roshan <cyrusroshan@users.noreply.github.com>
2021-02-02 21:24:04 +09:00
Ahmed Elshafey
272611cc82
docs: Update ipcMain.handle() docs in ipc-main.md for error-handling details ( #27461 )
...
* Update ipc-main.md
Include information about ipcMain.handle() error handling and workaround included in issue #24427
* Update ipc-main.md
fixed a typo
* Update ipc-main.md
Remove the exception passing workaround from ipcMain.handle() and refer to open issue only.
* Remove trailing spaces
Co-authored-by: Cheng Zhao <github@zcbenz.com>
2021-02-02 21:22:20 +09:00
Сковорода Никита Андреевич
a5e9af330f
feat: implement allowFileAccess loadExtension option ( #25198 )
...
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-02-01 14:41:08 -08:00
Cheng Zhao
8bf66f8974
fix: clean up implementations of titleBarStyle ( #27489 )
...
* Rewrite titleBarStyle impls with WindowButtonsView
* Remove fullscreenWindowTitle option
* Make buttons show correctly under RTL
* Fix docs about traffic lights position
* Fix test on fullscreen resizable
* Fix button states with closabe/minimizable/fullscreenable
* Fix typo
* Deprecate the fullscreenWindowTitle option
2021-01-30 17:15:10 -06:00
Erick Zhao
78d4cb9f5c
docs: update verb tenses for structured clone notes ( #27483 )
2021-01-26 14:14:44 -08:00
John Kleinschmidt
c5a41defbd
fix: enable navigator.setAppBadge/clearAppBadge ( #27067 )
2021-01-21 14:45:06 +09:00
Cheng Zhao
c3091c3a70
fix: make SetWindowButtonVisibility work for customButtonsOnHover ( #27073 )
2021-01-19 19:12:09 +09:00
Milan Burda
2be3d03630
feat: add webFrameMain.send() / webFrameMain.postMessage() ( #26807 )
2021-01-15 09:00:37 +09:00
Jeremy Rose
088f2e625f
feat: add frame and webContents to webRequest details ( #27078 )
...
* feat: add frame and webContents to webRequest details
* chore: use frame_converter.h
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2021-01-11 12:20:43 +09:00
AHFriedman
1ef766c4a6
docs: correct meaning of DesktopCapturerSource.id ( #27255 )
...
* docs: correction meaning of DesktopCapturerSource.id
Corrected the meaning of the id string to match observed behavior
(verified on Windows 10 and Ubuntu).
* chore: adjust wordings
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2021-01-11 12:20:00 +09:00
Jim Fisher
01b7ceac17
docs: coordinate system of badly named method getCursorScreenPoint ( #27156 )
...
* Document coordinate system of badly named method getCursorScreenPoint
[Electron inherits this confusing name from Chromium](99314be815/ui/display/win/screen_win.cc (L677-L681)
2021-01-11 12:19:48 +09:00
Jim Fisher
0f8b5ab606
docs: coordinate system of Display.bounds and Display.workArea ( #27157 )
...
They are in DIP points (rather than screen points). We can use
screen.dipToScreen* to convert to screen points.
2021-01-07 19:49:45 +09:00
theLMGN
b531123b4d
docs: NSVisualEffectMaterialDark has been deprecated and removed as of macOS 10.15 ( #27125 )
...
* NSVisualEffectMaterialDark has been deprecated and removed as of macOS 10.15.
* Update browser-window.md
2021-01-05 13:39:07 -08:00
Milan Burda
3d59aa5609
feat: add webFrameMain.executeJavaScriptInIsolatedWorld() ( #26913 )
2021-01-05 17:18:38 +09:00
Cheng Zhao
5f99569b6c
feat: make win.setAspectRatio() work on Windows ( #26941 )
...
* feat: make win.setAspectRatio() work on Windows
* update patches
Co-authored-by: Electron Bot <electron@github.com>
2021-01-05 17:17:33 +09:00
Milan Burda
16c864a932
docs: webFrameMain.fromId() can return undefined ( #27068 )
...
* docs: webFrameMain.fromId() can return undefined
* docs: webFrameMain.fromId() can return undefined
2021-01-05 11:31:21 +09:00
Jeremy Rose
c210956afb
docs: document frameId meaning ( #27072 )
2021-01-05 11:12:38 +09:00
Erick Zhao
4db3e3a08a
docs: update broken Chrome webview URL ( #27079 )
2021-01-04 12:48:35 -08:00
Electron Bot
8383c14aba
chore: bump chromium to 7264889ce3aad1568ff3d211c81fe (master) ( #27003 )
...
* chore: bump chromium in DEPS to 91c9f44297abe2844f593ec7956e6ce79c81f463
* chore: update chromium patches
* chore: update v8 patches
* build: service_names.mojom has been deleted
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2568681
* chore: add DISPLAY_CAPTURE permission to converter
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2551098
* chore: handle AXPropertyFilter::SCRIPT in accessibility_ui
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2563923
* refactor: web_isolated_world_ids.h has been deleted
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585255
* refactor: ResourceType has been deprecated / removed in ExtensionsBrowserClient
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2562002
* chore: fix lint
* chore: remove deleted headers
* build: disable gn check for blink header
* fix: refactor X11 event handling
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2577887
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585750
* chore: update patches
* chore: bump chromium in DEPS to bfd8e7dbd37af8b1bc40d887815edd5a29496fa3
* chore: update patches
* refactor: xeventobserver is now x11:eventobserver
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585750
* refactor: remove UseWebUIBindingsForURL
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2583590
* chore: DidProcessXEvent has been removed
* chore: bump chromium in DEPS to b13e791d7244a08d9d61dbfa2bb2b6cdf1ff6294
* chore: update patches
* build: change gfx::GetAtom to x11:GetAtom
Refs: d972a0ae4ad972a0ae4ac38f8571a8https://chromium-review.googlesource.com/c/chromium/src/+/2572896
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-12-22 14:14:44 -08:00
Eryk Rakowski
bf24759354
fix(extensions): implement missing web_request hooks ( #22655 )
...
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com>
2020-12-18 15:11:43 -08:00
